review: settle-window open-url assertion; drop debug payload field

CodeRabbit follow-ups: the UI test now also asserts the open-url capture
stays at exactly one entry through the settle window, and
debugSimulateCommandClick no longer exposes the open-url dispatch state
in its payload (nothing consumed it).

Co-Authored-By: Claude Fable 5 <[email protected]>
This commit is contained in:
austinpower1258
2026-08-15 20:13:39 -07:00
co-authored by Claude Fable 5
parent e8ad112051
commit aa025fa30a
2 changed files with 7 additions and 1 deletions
-1
View File
@@ -7154,7 +7154,6 @@ class GhosttyNSView: NSView, NSUserInterfaceValidations {
var payload: [String: Any] = [
"pressHandled": pressHandled ? "1" : "0",
"releaseConsumed": releaseConsumed ? "1" : "0",
"dispatchedOpenURL": dispatchedOpenURL ? "1" : "0",
]
if let resolution {
payload["openedPath"] = resolution.path
@@ -250,6 +250,13 @@ final class TerminalCmdClickUITests: XCTestCase {
waitForOpenCountToStay(0, timeout: 1.5),
"Cmd-click dispatched a second open for the same click: the word-path fallback ran even though Ghostty already routed the link. opened=\(loadCapturedOpenPaths()) result=\(result)"
)
// The open-url route itself must also stay at exactly one dispatch
// through the settle window never a duplicate primary open either.
XCTAssertEqual(
loadCapturedOpenPaths(path: openURLCapturePath),
[expectedURL],
"Expected exactly one open-url dispatch for the click after settling. result=\(result)"
)
}
func testCmdClickRawLsStylePathPrefersSnapshotWhenQuicklookDisagrees() throws {