fix: untrack the coding-agents node_modules symlink (#3422)
I committed this in #3380 and it has been on main since, in the v0.2.0 and v0.2.1 tags: a symlink at hindsight-integrations/coding-agents/node_modules pointing at an absolute path on my own machine. Anyone cloning gets a dangling link where the package's node_modules belongs. The published npm tarballs are unaffected — npm excludes node_modules from packs — so this is repository hygiene, not a shipped defect. .gitignore had `node_modules/`, which matches directories only. A symlink is a file, so it slipped straight past — which is exactly how it got committed, since pointing a scratch worktree at an already-installed node_modules is the fast way to run this package's tests. Adding the slashless pattern closes that.
This commit is contained in:
@@ -20,6 +20,9 @@ wheels/
|
||||
|
||||
# Node
|
||||
node_modules/
|
||||
# Without this, the pattern above matches directories only — a node_modules SYMLINK (what you get
|
||||
# pointing a scratch worktree at an installed one) is a file, slips past it, and can be committed.
|
||||
node_modules
|
||||
|
||||
# Environment variables and local config
|
||||
.env
|
||||
|
||||
@@ -1 +0,0 @@
|
||||
/Users/nicoloboschi/dev/hs-coding-plugin-wt/hindsight-integrations/coding-agents/node_modules
|
||||
Reference in New Issue
Block a user