ci: add upgrade tests

.env.example

@@ -2,7 +2,7 @@
 # Copy this file to .env and fill in your values
 
 # LLM Configuration (Required)
-# Supported providers: openai, groq, ollama, gemini, anthropic, lmstudio, vertexai
+# Supported providers: openai, groq, ollama, gemini, anthropic, lmstudio
 HINDSIGHT_API_LLM_PROVIDER=openai
 HINDSIGHT_API_LLM_API_KEY=your-api-key-here
 HINDSIGHT_API_LLM_MODEL=o3-mini
@@ -13,13 +13,6 @@ HINDSIGHT_API_LLM_BASE_URL=https://api.openai.com/v1
 # HINDSIGHT_API_LLM_API_KEY=your-anthropic-api-key
 # HINDSIGHT_API_LLM_MODEL=claude-sonnet-4-20250514
 
-# Example: Google Vertex AI configuration
-# HINDSIGHT_API_LLM_PROVIDER=vertexai
-# HINDSIGHT_API_LLM_MODEL=google/gemini-2.0-flash-001
-# HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID=your-gcp-project-id
-# HINDSIGHT_API_LLM_VERTEXAI_REGION=us-central1
-# HINDSIGHT_API_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY=/path/to/service-account-key.json  # Optional, uses ADC if not set
-
 # Example: LM Studio local configuration (Qwen 2.5 32B recommended)
 # HINDSIGHT_API_LLM_PROVIDER=lmstudio
 # HINDSIGHT_API_LLM_API_KEY=lmstudio
@@ -33,7 +26,6 @@ HINDSIGHT_API_LOG_LEVEL=info
 
 # Database (Optional - uses embedded pg0 by default)
 # HINDSIGHT_API_DATABASE_URL=postgresql://user:pass@host:5432/db
-# HINDSIGHT_API_DATABASE_SCHEMA=public  # PostgreSQL schema name (default: public)
 
 # Embeddings Configuration (Optional - uses local by default)
 # Provider: "local" (default) or "tei" (HuggingFace Text Embeddings Inference)

.github/workflows/release.yml

@@ -139,55 +139,6 @@ jobs:
         path: hindsight-clients/typescript/*.tgz
         retention-days: 1
 
-  release-openclaw-integration:
-    runs-on: ubuntu-latest
-    environment: npm
-
-    steps:
-    - uses: actions/checkout@v4
-
-    - name: Set up Node.js
-      uses: actions/setup-node@v4
-      with:
-        node-version: '22'
-        registry-url: 'https://registry.npmjs.org'
-
-    - name: Install dependencies
-      working-directory: ./hindsight-integrations/openclaw
-      run: npm ci
-
-    - name: Build
-      working-directory: ./hindsight-integrations/openclaw
-      run: npm run build
-
-    - name: Publish to npm
-      working-directory: ./hindsight-integrations/openclaw
-      run: |
-        set +e
-        OUTPUT=$(npm publish --access public 2>&1)
-        EXIT_CODE=$?
-        echo "$OUTPUT"
-        if [ $EXIT_CODE -ne 0 ]; then
-          if echo "$OUTPUT" | grep -q "cannot publish over"; then
-            echo "Package version already published, skipping..."
-            exit 0
-          fi
-          exit $EXIT_CODE
-        fi
-      env:
-        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-
-    - name: Pack for GitHub release
-      working-directory: ./hindsight-integrations/openclaw
-      run: npm pack
-
-    - name: Upload artifacts
-      uses: actions/upload-artifact@v4
-      with:
-        name: openclaw-integration
-        path: hindsight-integrations/openclaw/*.tgz
-        retention-days: 1
-
   release-control-plane:
     runs-on: ubuntu-latest
     environment: npm
@@ -415,7 +366,7 @@ jobs:
 
   create-github-release:
     runs-on: ubuntu-latest
-    needs: [release-python-packages, release-typescript-client, release-openclaw-integration, release-control-plane, release-rust-cli, release-docker-images, release-helm-chart]
+    needs: [release-python-packages, release-typescript-client, release-control-plane, release-rust-cli, release-docker-images, release-helm-chart]
     permissions:
       contents: write
 
@@ -438,12 +389,6 @@ jobs:
         name: typescript-client
         path: ./artifacts/typescript-client
 
-    - name: Download OpenClaw Integration
-      uses: actions/download-artifact@v4
-      with:
-        name: openclaw-integration
-        path: ./artifacts/openclaw-integration
-
     - name: Download Control Plane
       uses: actions/download-artifact@v4
       with:
@@ -485,8 +430,6 @@ jobs:
         cp artifacts/python-packages/hindsight-embed/dist/* release-assets/ || true
         # TypeScript client
         cp artifacts/typescript-client/*.tgz release-assets/ || true
-        # OpenClaw Integration
-        cp artifacts/openclaw-integration/*.tgz release-assets/ || true
         # Control Plane
         cp artifacts/control-plane/*.tgz release-assets/ || true
         # Rust CLI binaries

.github/workflows/test.yml

@@ -82,29 +82,6 @@ jobs:
     - name: Build TypeScript client
       run: npm run build --workspace=hindsight-clients/typescript
 
-  build-openclaw-integration:
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v4
-
-    - name: Set up Node.js
-      uses: actions/setup-node@v4
-      with:
-        node-version: '22'
-
-    - name: Install dependencies
-      working-directory: ./hindsight-integrations/openclaw
-      run: npm ci
-
-    - name: Run tests
-      working-directory: ./hindsight-integrations/openclaw
-      run: npm test
-
-    - name: Build
-      working-directory: ./hindsight-integrations/openclaw
-      run: npm run build
-
   build-control-plane:
     runs-on: ubuntu-latest
 
@@ -749,9 +726,9 @@ jobs:
   test-embed:
     runs-on: ubuntu-latest
     env:
-      HINDSIGHT_API_LLM_PROVIDER: groq
-      HINDSIGHT_API_LLM_API_KEY: ${{ secrets.GROQ_API_KEY }}
-      HINDSIGHT_API_LLM_MODEL: openai/gpt-oss-20b
+      HINDSIGHT_EMBED_LLM_PROVIDER: groq
+      HINDSIGHT_EMBED_LLM_API_KEY: ${{ secrets.GROQ_API_KEY }}
+      HINDSIGHT_EMBED_LLM_MODEL: openai/gpt-oss-20b
       # Prefer CPU-only PyTorch in CI
       UV_INDEX: pytorch=https://download.pytorch.org/whl/cpu
 
@@ -782,10 +759,6 @@ jobs:
           ${{ runner.os }}-huggingface-embed-
           ${{ runner.os }}-huggingface-
 
-    - name: Run unit and integration tests
-      working-directory: ./hindsight-embed
-      run: uv run pytest tests/ -v
-
     - name: Run smoke test
       working-directory: ./hindsight-embed
       run: ./test.sh
@@ -962,18 +935,6 @@ jobs:
       working-directory: ./hindsight-dev
       run: uv run pytest upgrade_tests/ -v --tb=short
 
-    - name: Show upgrade test logs
-      if: always()
-      run: |
-        echo "=== Upgrade Test Server Logs ==="
-        for log in /tmp/upgrade-test-*.log; do
-          if [ -f "$log" ]; then
-            echo ""
-            echo "--- $log ---"
-            tail -500 "$log"
-          fi
-        done
-
   verify-generated-files:
     runs-on: ubuntu-latest
     env:

.gitignore

@@ -45,12 +45,9 @@ hindsight-docs/static/llms-full.txt
 
 hindsight-dev/benchmarks/locomo/results/
 hindsight-dev/benchmarks/longmemeval/results/
-hindsight-dev/benchmarks/consolidation/results/
-benchmarks/results/
 hindsight-cli/target
 hindsight-clients/rust/target
 .claude
 whats-next.md
 TASK.md
-# Changelog is now tracked in hindsight-docs/src/pages/changelog.md
-# CHANGELOG.md
+CHANGELOG.md

CLAUDE.md

@@ -7,7 +7,8 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 Hindsight is an agent memory system that provides long-term memory for AI agents using biomimetic data structures. Memories are organized as:
 - **World facts**: General knowledge ("The sky is blue")
 - **Experience facts**: Personal experiences ("I visited Paris in 2023")
-- **Mental models**: Consolidated knowledge synthesized from facts ("User prefers functional programming patterns")
+- **Opinion facts**: Beliefs with confidence scores ("Paris is beautiful" - 0.9 confidence)
+- **Observations**: Complex mental models derived from reflection
 
 ## Development Commands
 
@@ -100,7 +101,7 @@ cd hindsight-control-plane && npm run dev
 Main operations:
 - **Retain**: Store memories, extracts facts/entities/relationships
 - **Recall**: Retrieve memories via 4 parallel strategies (semantic, BM25, graph, temporal) + reranking
-- **Reflect**: Disposition-aware reasoning using memories and mental models.
+- **Reflect**: Deep analysis forming new opinions/observations (disposition-aware)
 
 ### Database
 PostgreSQL with pgvector. Schema managed via Alembic migrations in `hindsight-api/hindsight_api/alembic/`. Migrations run automatically on API startup.

CONTRIBUTING.md

@@ -93,34 +93,6 @@ uv run ty check hindsight_api  # Type check
 3. Run tests to ensure nothing breaks
 4. Submit a PR with a clear description of changes
 
-## Release Process
-
-The project uses `scripts/release.sh` for creating releases. This script automates the entire release workflow:
-
-1. Bumps version in all components (API, clients, CLI, control plane, Helm)
-2. **Regenerates OpenAPI spec and client SDKs** (Python, TypeScript, Rust)
-3. Updates documentation versioning
-4. Creates a commit and git tag
-5. Pushes to GitHub (triggers CI/CD to publish packages)
-
-### Usage
-
-```bash
-./scripts/release.sh <version>
-```
-
-**Example:**
-```bash
-./scripts/release.sh 0.5.0
-```
-
-### Important for Developers
-
-- During development, version bumps in `__init__.py` do NOT require client regeneration
-- Clients are only regenerated during releases
-- Do not manually run `./scripts/generate-clients.sh` unless testing generation changes
-- Client version comments will reflect the API version from the latest release
-
 ## Reporting Issues
 
 Open an issue on GitHub with:

README.md

@@ -1,6 +1,6 @@
 <div align="center">
 
-![Hindsight Banner](./hindsight-docs/static/img/hindsight-github-banner.png)
+![Hindsight Banner](./hindsight-docs/static/img/banner.svg)
 
 [Documentation](https://hindsight.vectorize.io) • [Paper](https://arxiv.org/abs/2512.12818) • [Cookbook](https://hindsight.vectorize.io/cookbook) • [Hindsight Cloud](https://vectorize.io/hindsight/cloud)
 
@@ -17,31 +17,55 @@
 
 ## What is Hindsight?
 
-Hindsight™ is an agent memory system built to create smarter agents that learn over time. Most agent memory systems focus on recalling conversation history. Hindsight is focused on making agents that learn, not just remember.
+Hindsight™ is an agent memory system built to create smarter agents that learn over time. It eliminates the shortcomings of alternative techniques such as RAG and knowledge graph and delivers state-of-the-art performance on long term memory tasks.
 
+Hindsight addresses common challenges that have frustrated AI engineers building agents to automate tasks and assist users with conversational interfaces. Many of these challenges stem directly from a lack of memory.
 
-<video src="https://github.com/user-attachments/assets/923b798d-3581-4897-bb62-9cfa5a931682" controls></video>
+- **Inconsistency:** Agents complete tasks successfully one time, then fail when asked to complete the same task again. Memory gives the agent a mechanism to remember what worked and what didn't and to use that information to reduce errors and improve consistency.
+- **Hallucinations:** Long term memory can be seeded with external knowledge to ground agent behavior in reliable sources to augment training data.
+- **Cognitive Overload:** As workflows get complex, retrievals, tool calls, user messages and agent responses can grow to fill the context window leading to context rot. Short term memory optimization allows agents to reduce tokens and focus context by removing irrelevant details.
 
-It eliminates the shortcomings of alternative techniques such as RAG and knowledge graph and delivers state-of-the-art performance on long term memory tasks.
+## How is Hindsight Different From Other Memory Systems?
+
+![Overview](./hindsight-docs/static/img/hindsight-overview.webp)
+
+Most agent memory implementation rely on basic vector search or sometimes use a knowledge graph. Hindsight uses biomimetic data structures to organize agent memories in a way that is more like how human memory works:
+
+- **World:** Facts about the world ("The stove gets hot")
+- **Experiences:** Agent's own experiences ("I touched the stove and it really hurt")
+- **Opinion:** Beliefs with confidence scores ("I shouldn't touch the stove again" - .99 confidence)
+- **Observation:** Complex mental models derived by reflecting on facts and experiences ("Curling irons, ovens, and fire are also hot. I shouldn't touch those either.")
+
+Memories in Hindsight are stored in banks (i.e. memory banks). When memories are added to Hindsight, they are pushed into either the world facts or experiences memory pathway. They are then represented as a combination of entities, relationships, and time series with sparse/dense vector representations to aid in later recall.
+
+Hindsight provides three simple methods to interact with the system:
+
+- **Retain:** Provide information to Hindsight that you want it to remember
+- **Recall:** Retrieve memories from Hindsight
+- **Reflect:** Reflect on memories and experiences to generate new observations and insights from existing memories.
+
+### Agent Memory That Learns
+
+A key goal of Hindsight is to build agent memory that enables agents to learn and improve over time. This is the role of the `reflect` operation which provides the agent to form broader opinions and observations over time.
+
+For example, imagine a product support agent that is helping a user troubleshoot a problem. It uses a `search-documentation` tool it found on an MCP server. Later in the conversation, the agent discovers that the documentation returned from the tool wasn't for the product the user was asking about. The agent now has an experience in its memory bank. And just like humans, we want that agent to learn from its experience.
+
+As the agent gains more experiences, `reflect` allows the agent to form observations about what worked, what didn't, and what to do differently the next time it encounters a similar task.
+
+---
 
 ## Memory Performance & Accuracy
 
-Hindsight is the most accurate agent memory system ever tested according to benchmark performance. It has achieved state-of-the-art performance on the LongMemEval benchmark, widely used to assess memory system performance across a variety of conversational AI scenarios. The current reported performance of Hindsight and other agent memory solutions as of January 2026 is shown here:
+Hindsight has achieved state-of-the-art performance on the LongMemEval benchmark, widely used to assess memory system performance across a variety of conversational
+AI scenarios. The current reported performance of Hindsight and other agent memory solutions as of December 2025 is shown here:
 
 ![Overview](./hindsight-docs/static/img/hindsight-bench.jpg)
 
-The benchmark performance data for Hindsight has been independently reproduced by research collaborators at the Virginia Tech [Sanghani Center for Artificial Intelligence and Data Analytics](https://sanghani.cs.vt.edu/) and The Washington Post. Other scores are self-reported by software vendors.
+The benchmark performance data for Hindsight and GPT-4o (full context) have been reproduced by research collaborators at the Virginia Tech [Sanghani Center for Artificial Intelligence and Data Analytics](https://sanghani.cs.vt.edu/) and The Washington Post. Other scores are self-reported by software vendors.
 
-Hindsight is being used in production at Fortune 500 enterprises and by a growing number of AI startups. 
-
-## Adding Hindsight to Your AI Agents
-
-The easiest way use Hindsight with an existing agent is with the LLM Wrapper. You can add memory to your agent with 2 lines of code. That will swap your current LLM client out with the Hindsight wrapper. After that, memories will be stored and retrieved automatically as you make LLM calls.
-
-If you need more control over how and when your agent stores and recalls memories, there's also a simple API you can integrate with using the SDKs or directly via HTTP.
-
-![Hindsight Banner](./hindsight-docs/static/img/migration-code.png)
+A thorough examination of the techniques implemented in Hindsight and detailed breakdowns of benchmark performance are [available on arXiv](https://arxiv.org/abs/2512.12818). This research is currently being prepared for conference submission and the wider peer review process.
 
+The benchmark results from this research can be inspected in our [visual benchmark explorer](https://hindsight-benchmarks.vercel.app). As additional improvements are made to Hindsight, new benchmark data will be available for review using this same tool.
 
 ## Quick Start
 
@@ -124,45 +148,8 @@ await client.recall('my-bank', 'What does Alice like?');
 
 ---
 
-## Use Cases
-
-
-Hindsight is built to support conversational AI agents as well as agents that are intended to perform tasks autonomously. The ideal use case for Hindsight are agents that require a blend of these features such as AI employees that need to handle open-ended tasks, change behavior based on user feedback, and learn to perform complex tasks to automate work at a level that approximates a human work. Hindsight can be used with simple AI workflows like those built with n8n and other similar tools, but may be overkill for such applications.
-
-### Per-User Memories and Chat History
-
-One of the simpler use cases you can use Hindsight for is to personalize AI chatbots and other conversational agents by storing and recalling memories associated with individual users.
-
-The requirements for this use case usually look something like this:
-
-![Per-User Memories](./hindsight-docs/static/img/per-user-memory-requirements.png)
-
-<video src="https://github.com/user-attachments/assets/4805e8e1-e7d1-47c6-a4f8-2344a5ec8906" controls></video>
-
-Satisfying these requirements in Hindsight is straightforward. When new user inputs and tool calls are ingested into Hindsight using the retain operation, custom metadata can be used to enrich the new memories. Metadata provides a convenient way to isolate memories that need to be restricted to a given user. Once these are fed into the retain operation, any raw memories and mental models that get created can be filtered when retrieving relevant memories. 
-
-![Per-User Memories](./hindsight-docs/static/img/per-user-memory-howto.png)
-
----
-
 ## Architecture & Operations
 
-![Overview](./hindsight-docs/static/img/hindsight-overview.webp)
-
-Most agent memory implementation rely on basic vector search or sometimes use a knowledge graph. Hindsight uses biomimetic data structures to organize agent memories in a way that is more like how human memory works:
-
-- **World:** Facts about the world ("The stove gets hot")
-- **Experiences:** Agent's own experiences ("I touched the stove and it really hurt")
-- **Mental Models:** Learned understanding of the agent's world formed by reflecting on raw memories and experiences.
-
-Memories in Hindsight are stored in banks (i.e. memory banks). When memories are added to Hindsight, they are pushed into either the world facts or experiences memory pathway. They are then represented as a combination of entities, relationships, and time series with sparse/dense vector representations to aid in later recall.
-
-Hindsight provides three simple methods to interact with the system:
-
-- **Retain:** Provide information to Hindsight that you want it to remember
-- **Recall:** Retrieve memories from Hindsight
-- **Reflect:** Reflect on memories and experiences to generate new observations and insights from existing memories.
-
 ### Retain
 
 The `retain` operation is used to push new memories into Hindsight. It tells Hindsight to _retain_ the information you pass in as an input.
@@ -221,7 +208,7 @@ The final output is trimmed as needed to fit within the token limit.
 
 ### Reflect
 
-The reflect operation is used to perform a more thorough analysis of existing memories. This allows the agent to form new connections between memories and build a more thorough understanding of its world.
+The reflect operation is used to perform a more thorough analysis of existing memories. This allows the agent to form new connections between memories which are then persisted as opinions and/or observations. When building agents, the reflect operation is a key capability to enable the agent to learn from its experiences. 
 
 For example, the `reflect` operation can be used to support use cases such as:
 

docker/standalone/Dockerfile

@@ -169,34 +169,16 @@ ENV PATH="/app/api/.venv/bin:${PATH}"
 
 # Pre-download ML models to avoid runtime download (conditional)
 # Only runs if both PRELOAD_ML_MODELS=true AND INCLUDE_LOCAL_MODELS=true
-# Includes retry logic with exponential backoff for transient network failures
 ARG PRELOAD_ML_MODELS
 ARG INCLUDE_LOCAL_MODELS
-ENV HF_HUB_DOWNLOAD_TIMEOUT=600
 RUN if [ "$PRELOAD_ML_MODELS" = "true" ] && [ "$INCLUDE_LOCAL_MODELS" = "true" ]; then \
-    MAX_RETRIES=3; \
-    RETRY_DELAY=10; \
-    for i in $(seq 1 $MAX_RETRIES); do \
-      echo "Attempt $i/$MAX_RETRIES: Downloading ML models..."; \
-      /app/api/.venv/bin/python -c "\
-import os; os.environ['HF_HUB_DOWNLOAD_TIMEOUT'] = '600'; \
+    /app/api/.venv/bin/python -c "\
 from sentence_transformers import SentenceTransformer, CrossEncoder; \
 print('Downloading embedding model...'); \
 SentenceTransformer('BAAI/bge-small-en-v1.5'); \
 print('Downloading cross-encoder model...'); \
 CrossEncoder('cross-encoder/ms-marco-MiniLM-L-6-v2'); \
-print('Downloading tiktoken encoding...'); import tiktoken; tiktoken.get_encoding('cl100k_base'); \
-print('Models cached successfully')" && break; \
-      if [ $i -lt $MAX_RETRIES ]; then \
-        echo "Attempt $i failed, retrying in ${RETRY_DELAY}s..."; \
-        sleep $RETRY_DELAY; \
-        RETRY_DELAY=$((RETRY_DELAY * 2)); \
-      fi; \
-    done; \
-    if [ $i -eq $MAX_RETRIES ] && ! /app/api/.venv/bin/python -c "from sentence_transformers import SentenceTransformer; SentenceTransformer('BAAI/bge-small-en-v1.5')" 2>/dev/null; then \
-      echo "ERROR: Failed to download models after $MAX_RETRIES attempts"; \
-      exit 1; \
-    fi; \
+print('Models cached successfully')"; \
     elif [ "$INCLUDE_LOCAL_MODELS" != "true" ]; then echo "Skipping ML model preload (local-models not included)"; \
     else echo "Skipping ML model preload"; fi
 
@@ -208,10 +190,6 @@ ENV HINDSIGHT_API_LOG_LEVEL=info
 ENV HINDSIGHT_ENABLE_API=true
 ENV HINDSIGHT_ENABLE_CP=false
 ENV PYTHONUNBUFFERED=1
-# Suppress verbose transformers/HuggingFace model loading warnings
-ENV TRANSFORMERS_VERBOSITY=error
-ENV HF_HUB_VERBOSITY=error
-ENV TOKENIZERS_PARALLELISM=false
 
 CMD ["/app/start-all.sh"]
 
@@ -299,34 +277,16 @@ ENV PATH="/app/api/.venv/bin:${PATH}"
 
 # Pre-download ML models to avoid runtime download (conditional)
 # Only runs if both PRELOAD_ML_MODELS=true AND INCLUDE_LOCAL_MODELS=true
-# Includes retry logic with exponential backoff for transient network failures
 ARG PRELOAD_ML_MODELS
 ARG INCLUDE_LOCAL_MODELS
-ENV HF_HUB_DOWNLOAD_TIMEOUT=600
 RUN if [ "$PRELOAD_ML_MODELS" = "true" ] && [ "$INCLUDE_LOCAL_MODELS" = "true" ]; then \
-    MAX_RETRIES=3; \
-    RETRY_DELAY=10; \
-    for i in $(seq 1 $MAX_RETRIES); do \
-      echo "Attempt $i/$MAX_RETRIES: Downloading ML models..."; \
-      /app/api/.venv/bin/python -c "\
-import os; os.environ['HF_HUB_DOWNLOAD_TIMEOUT'] = '600'; \
+    /app/api/.venv/bin/python -c "\
 from sentence_transformers import SentenceTransformer, CrossEncoder; \
 print('Downloading embedding model...'); \
 SentenceTransformer('BAAI/bge-small-en-v1.5'); \
 print('Downloading cross-encoder model...'); \
 CrossEncoder('cross-encoder/ms-marco-MiniLM-L-6-v2'); \
-print('Downloading tiktoken encoding...'); import tiktoken; tiktoken.get_encoding('cl100k_base'); \
-print('Models cached successfully')" && break; \
-      if [ $i -lt $MAX_RETRIES ]; then \
-        echo "Attempt $i failed, retrying in ${RETRY_DELAY}s..."; \
-        sleep $RETRY_DELAY; \
-        RETRY_DELAY=$((RETRY_DELAY * 2)); \
-      fi; \
-    done; \
-    if [ $i -eq $MAX_RETRIES ] && ! /app/api/.venv/bin/python -c "from sentence_transformers import SentenceTransformer; SentenceTransformer('BAAI/bge-small-en-v1.5')" 2>/dev/null; then \
-      echo "ERROR: Failed to download models after $MAX_RETRIES attempts"; \
-      exit 1; \
-    fi; \
+print('Models cached successfully')"; \
     elif [ "$INCLUDE_LOCAL_MODELS" != "true" ]; then echo "Skipping ML model preload (local-models not included)"; \
     else echo "Skipping ML model preload"; fi
 
@@ -340,10 +300,6 @@ ENV HINDSIGHT_CP_DATAPLANE_API_URL=http://localhost:8888
 ENV HINDSIGHT_ENABLE_API=true
 ENV HINDSIGHT_ENABLE_CP=true
 ENV PYTHONUNBUFFERED=1
-# Suppress verbose transformers/HuggingFace model loading warnings
-ENV TRANSFORMERS_VERBOSITY=error
-ENV HF_HUB_VERBOSITY=error
-ENV TOKENIZERS_PARALLELISM=false
 
 CMD ["/app/start-all.sh"]
 

helm/hindsight/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: hindsight
 description: Hindsight helm chart
 type: application
-version: 0.4.8
-appVersion: "0.4.8"
+version: 0.3.0
+appVersion: "0.3.0"
 keywords:
   - ai
   - memory

hindsight-api/hindsight_api/__init__.py

@@ -46,4 +46,4 @@ __all__ = [
     "RemoteTEICrossEncoder",
     "LLMConfig",
 ]
-__version__ = "0.4.8"
+__version__ = "0.1.0"

hindsight-api/hindsight_api/alembic/versions/5a366d414dce_initial_schema.py

@@ -11,7 +11,6 @@ from collections.abc import Sequence
 import sqlalchemy as sa
 from alembic import op
 from pgvector.sqlalchemy import Vector
-from sqlalchemy import text
 from sqlalchemy.dialects import postgresql
 
 # revision identifiers, used by Alembic.
@@ -24,21 +23,8 @@ depends_on: str | Sequence[str] | None = None
 def upgrade() -> None:
     """Upgrade schema - create all tables from scratch."""
 
-    # Note: pgvector extension is installed globally BEFORE migrations run
-    # See migrations.py:run_migrations() - this ensures the extension is available
-    # to all schemas, not just the one being migrated
-
-    # We keep this here as a fallback for backwards compatibility
-    # This may fail if user lacks permissions, which is fine if extension already exists
-    try:
-        op.execute("CREATE EXTENSION IF NOT EXISTS vector")
-    except Exception:
-        # Extension might already exist or user lacks permissions - verify it exists
-        conn = op.get_bind()
-        result = conn.execute(text("SELECT 1 FROM pg_extension WHERE extname = 'vector'")).fetchone()
-        if not result:
-            # Extension truly doesn't exist - re-raise the error
-            raise
+    # Enable required extensions
+    op.execute("CREATE EXTENSION IF NOT EXISTS vector")
 
     # Create banks table
     op.create_table(

hindsight-api/hindsight_api/alembic/versions/t5o6p7q8r9s0_rename_mental_models_to_observations.py

@@ -1,134 +0,0 @@
-"""Rename mental_model fact_type to observation and reflections table to mental_models
-
-Revision ID: t5o6p7q8r9s0
-Revises: s4n5o6p7q8r9
-Create Date: 2026-01-26
-
-This migration implements the terminology rename:
-1. mental_model (fact_type in memory_units) -> observation
-2. reflections table -> mental_models table
-
-The new terminology:
-- Observations: Consolidated knowledge synthesized from facts (was mental_model)
-- Mental Models: Stored reflect responses (was reflections)
-"""
-
-from collections.abc import Sequence
-
-from alembic import context, op
-
-revision: str = "t5o6p7q8r9s0"
-down_revision: str | Sequence[str] | None = "s4n5o6p7q8r9"
-branch_labels: str | Sequence[str] | None = None
-depends_on: str | Sequence[str] | None = None
-
-
-def _get_schema_prefix() -> str:
-    """Get schema prefix for table names (required for multi-tenant support)."""
-    schema = context.config.get_main_option("target_schema")
-    return f'"{schema}".' if schema else ""
-
-
-def upgrade() -> None:
-    """Rename mental_model -> observation and reflections -> mental_models."""
-    schema = _get_schema_prefix()
-
-    # 1. Update fact_type values: mental_model -> observation
-    op.execute(f"""
-        UPDATE {schema}memory_units
-        SET fact_type = 'observation'
-        WHERE fact_type = 'mental_model'
-    """)
-
-    # 2. Update the CHECK constraint - remove mental_model, keep observation
-    op.execute(f"ALTER TABLE {schema}memory_units DROP CONSTRAINT IF EXISTS memory_units_fact_type_check")
-    op.execute(f"""
-        ALTER TABLE {schema}memory_units
-        ADD CONSTRAINT memory_units_fact_type_check
-        CHECK (fact_type IN ('world', 'experience', 'opinion', 'observation'))
-    """)
-
-    # 3. Rename the index for observations (was for mental_models)
-    op.execute(f"DROP INDEX IF EXISTS {schema}idx_memory_units_mental_models")
-    op.execute(f"""
-        CREATE INDEX IF NOT EXISTS idx_memory_units_observations
-        ON {schema}memory_units(bank_id, fact_type)
-        WHERE fact_type = 'observation'
-    """)
-
-    # 4. Update the unconsolidated index to not filter by fact_type since observations
-    # are now the consolidated type
-    op.execute(f"DROP INDEX IF EXISTS {schema}idx_memory_units_unconsolidated")
-    op.execute(f"""
-        CREATE INDEX IF NOT EXISTS idx_memory_units_unconsolidated
-        ON {schema}memory_units (bank_id, created_at)
-        WHERE consolidated_at IS NULL AND fact_type IN ('experience', 'world')
-    """)
-
-    # 5. Rename reflections table to mental_models
-    op.execute(f"ALTER TABLE IF EXISTS {schema}reflections RENAME TO mental_models")
-
-    # 6. Rename indexes for mental_models (was reflections)
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_bank_id RENAME TO idx_mental_models_bank_id")
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_embedding RENAME TO idx_mental_models_embedding")
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_tags RENAME TO idx_mental_models_tags")
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_text_search RENAME TO idx_mental_models_text_search")
-
-    # 7. Rename foreign key constraint
-    op.execute(f"""
-        ALTER TABLE {schema}mental_models
-        DROP CONSTRAINT IF EXISTS fk_reflections_bank_id
-    """)
-    op.execute(f"""
-        ALTER TABLE {schema}mental_models
-        ADD CONSTRAINT fk_mental_models_bank_id
-        FOREIGN KEY (bank_id) REFERENCES {schema}banks(bank_id) ON DELETE CASCADE
-    """)
-
-
-def downgrade() -> None:
-    """Reverse: observation -> mental_model and mental_models -> reflections."""
-    schema = _get_schema_prefix()
-
-    # 1. Rename mental_models table back to reflections
-    op.execute(f"ALTER TABLE IF EXISTS {schema}mental_models RENAME TO reflections")
-
-    # 2. Rename indexes back
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_bank_id RENAME TO idx_reflections_bank_id")
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_embedding RENAME TO idx_reflections_embedding")
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_tags RENAME TO idx_reflections_tags")
-    op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_text_search RENAME TO idx_reflections_text_search")
-
-    # 3. Rename foreign key back
-    op.execute(f"""
-        ALTER TABLE {schema}reflections
-        DROP CONSTRAINT IF EXISTS fk_mental_models_bank_id
-    """)
-    op.execute(f"""
-        ALTER TABLE {schema}reflections
-        ADD CONSTRAINT fk_reflections_bank_id
-        FOREIGN KEY (bank_id) REFERENCES {schema}banks(bank_id) ON DELETE CASCADE
-    """)
-
-    # 4. Update fact_type values: observation -> mental_model
-    op.execute(f"""
-        UPDATE {schema}memory_units
-        SET fact_type = 'mental_model'
-        WHERE fact_type = 'observation'
-    """)
-
-    # 5. Update the CHECK constraint back
-    op.execute(f"ALTER TABLE {schema}memory_units DROP CONSTRAINT IF EXISTS memory_units_fact_type_check")
-    op.execute(f"""
-        ALTER TABLE {schema}memory_units
-        ADD CONSTRAINT memory_units_fact_type_check
-        CHECK (fact_type IN ('world', 'experience', 'opinion', 'observation', 'mental_model'))
-    """)
-
-    # 6. Rename index back
-    op.execute(f"DROP INDEX IF EXISTS {schema}idx_memory_units_observations")
-    op.execute(f"""
-        CREATE INDEX IF NOT EXISTS idx_memory_units_mental_models
-        ON {schema}memory_units(bank_id, fact_type)
-        WHERE fact_type = 'mental_model'
-    """)

hindsight-api/hindsight_api/alembic/versions/u6p7q8r9s0t1_mental_models_text_id.py

@@ -1,41 +0,0 @@
-"""Change mental_models.id from UUID to TEXT
-
-Revision ID: u6p7q8r9s0t1
-Revises: t5o6p7q8r9s0
-Create Date: 2026-01-27
-
-This migration changes the mental_models.id column from UUID to TEXT
-to support user-defined text identifiers like 'team-communication' instead of UUIDs.
-"""
-
-from collections.abc import Sequence
-
-from alembic import context, op
-
-revision: str = "u6p7q8r9s0t1"
-down_revision: str | Sequence[str] | None = "t5o6p7q8r9s0"
-branch_labels: str | Sequence[str] | None = None
-depends_on: str | Sequence[str] | None = None
-
-
-def _get_schema_prefix() -> str:
-    """Get schema prefix for table names (required for multi-tenant support)."""
-    schema = context.config.get_main_option("target_schema")
-    return f'"{schema}".' if schema else ""
-
-
-def upgrade() -> None:
-    """Change mental_models.id from UUID to TEXT."""
-    schema = _get_schema_prefix()
-
-    # Change the id column type from UUID to TEXT
-    # Existing UUIDs will be converted to their string representation
-    op.execute(f"ALTER TABLE {schema}mental_models ALTER COLUMN id TYPE TEXT USING id::TEXT")
-
-
-def downgrade() -> None:
-    """Revert mental_models.id from TEXT to UUID."""
-    schema = _get_schema_prefix()
-
-    # Note: This will fail if any id values are not valid UUIDs
-    op.execute(f"ALTER TABLE {schema}mental_models ALTER COLUMN id TYPE UUID USING id::UUID")

hindsight-api/hindsight_api/alembic/versions/v7q8r9s0t1u2_add_max_tokens_to_mental_models.py

@@ -1,50 +0,0 @@
-"""Add max_tokens and trigger columns to mental_models
-
-Revision ID: v7q8r9s0t1u2
-Revises: u6p7q8r9s0t1
-Create Date: 2026-01-27
-
-This migration adds:
-- max_tokens column: token limit for content generation during refresh
-- trigger column: JSONB for trigger settings (e.g., refresh_after_consolidation)
-"""
-
-from collections.abc import Sequence
-
-from alembic import context, op
-
-revision: str = "v7q8r9s0t1u2"
-down_revision: str | Sequence[str] | None = "u6p7q8r9s0t1"
-branch_labels: str | Sequence[str] | None = None
-depends_on: str | Sequence[str] | None = None
-
-
-def _get_schema_prefix() -> str:
-    """Get schema prefix for table names (required for multi-tenant support)."""
-    schema = context.config.get_main_option("target_schema")
-    return f'"{schema}".' if schema else ""
-
-
-def upgrade() -> None:
-    """Add max_tokens and trigger columns to mental_models."""
-    schema = _get_schema_prefix()
-
-    op.execute(f"""
-        ALTER TABLE {schema}mental_models
-        ADD COLUMN IF NOT EXISTS max_tokens INT NOT NULL DEFAULT 2048
-    """)
-
-    # trigger column stores trigger settings as JSONB
-    # Default: refresh_after_consolidation = false (not "real time")
-    op.execute(f"""
-        ALTER TABLE {schema}mental_models
-        ADD COLUMN IF NOT EXISTS trigger JSONB NOT NULL DEFAULT '{{"refresh_after_consolidation": false}}'::jsonb
-    """)
-
-
-def downgrade() -> None:
-    """Remove max_tokens and trigger columns from mental_models."""
-    schema = _get_schema_prefix()
-
-    op.execute(f"ALTER TABLE {schema}mental_models DROP COLUMN IF EXISTS max_tokens")
-    op.execute(f"ALTER TABLE {schema}mental_models DROP COLUMN IF EXISTS trigger")

hindsight-api/hindsight_api/api/http.py

@@ -92,7 +92,8 @@ class RecallRequest(BaseModel):
     query: str
     types: list[str] | None = Field(
         default=None,
-        description="List of fact types to recall: 'world', 'experience', 'observation'. Defaults to world and experience if not specified.",
+        description="List of fact types to recall: 'world', 'experience', 'mental_model'. Defaults to world and experience if not specified. "
+        "Note: 'opinion' is accepted but ignored (opinions are excluded from recall).",
     )
     budget: Budget = Budget.MID
     max_tokens: int = 4096
@@ -503,6 +504,13 @@ class ReflectRequest(BaseModel):
     )
 
 
+class OpinionItem(BaseModel):
+    """Model for an opinion with confidence score."""
+
+    text: str
+    confidence: float
+
+
 class ReflectFact(BaseModel):
     """A fact used in think response."""
 
@@ -521,28 +529,12 @@ class ReflectFact(BaseModel):
 
     id: str | None = None
     text: str
-    type: str | None = None  # fact type: world, experience, observation
+    type: str | None = None  # fact type: world, experience, opinion
     context: str | None = None
     occurred_start: str | None = None
     occurred_end: str | None = None
 
 
-class ReflectDirective(BaseModel):
-    """A directive applied during reflect."""
-
-    id: str = Field(description="Directive ID")
-    name: str = Field(description="Directive name")
-    content: str = Field(description="Directive content")
-
-
-class ReflectMentalModel(BaseModel):
-    """A mental model used during reflect."""
-
-    id: str = Field(description="Mental model ID")
-    text: str = Field(description="Mental model content")
-    context: str | None = Field(default=None, description="Additional context")
-
-
 class ReflectToolCall(BaseModel):
     """A tool call made during reflect agent execution."""
 
@@ -562,14 +554,22 @@ class ReflectLLMCall(BaseModel):
     duration_ms: int = Field(description="Execution time in milliseconds")
 
 
+class ReflectMentalModel(BaseModel):
+    """A mental model accessed during reflect."""
+
+    id: str = Field(description="Mental model ID")
+    name: str = Field(description="Mental model name")
+    type: str = Field(description="Mental model type: entity, concept, event")
+    subtype: str = Field(description="Mental model subtype: structural, emergent, learned, directive")
+    observations: list[str] | None = Field(
+        default=None, description="Observations for directive mental models (subtype='directive')"
+    )
+
+
 class ReflectBasedOn(BaseModel):
-    """Evidence the response is based on: memories, mental models, and directives."""
+    """Evidence the response is based on: memories and mental models."""
 
     memories: list[ReflectFact] = Field(default_factory=list, description="Memory facts used to generate the response")
-    mental_models: list[ReflectMentalModel] = Field(
-        default_factory=list, description="Mental models used during reflection"
-    )
-    directives: list[ReflectDirective] = Field(default_factory=list, description="Directives applied during reflection")
 
 
 class ReflectTrace(BaseModel):
@@ -577,6 +577,10 @@ class ReflectTrace(BaseModel):
 
     tool_calls: list[ReflectToolCall] = Field(default_factory=list, description="Tool calls made during reflection")
     llm_calls: list[ReflectLLMCall] = Field(default_factory=list, description="LLM calls made during reflection")
+    mental_models: list[ReflectMentalModel] = Field(
+        default_factory=list,
+        description="Mental models used during reflection (includes directives with subtype='directive')",
+    )
 
 
 class ReflectResponse(BaseModel):
@@ -591,6 +595,15 @@ class ReflectResponse(BaseModel):
                         {"id": "123", "text": "AI is used in healthcare", "type": "world"},
                         {"id": "456", "text": "I discussed AI applications last week", "type": "experience"},
                     ],
+                    "mental_models": [
+                        {
+                            "id": "mm-1",
+                            "name": "AI Technology",
+                            "type": "concept",
+                            "subtype": "structural",
+                            "description": "Understanding of AI capabilities",
+                        }
+                    ],
                 },
                 "structured_output": {
                     "summary": "AI is transformative",
@@ -600,14 +613,6 @@ class ReflectResponse(BaseModel):
                 "trace": {
                     "tool_calls": [{"tool": "recall", "input": {"query": "AI"}, "duration_ms": 150}],
                     "llm_calls": [{"scope": "agent_1", "duration_ms": 1200}],
-                    "observations": [
-                        {
-                            "id": "obs-1",
-                            "name": "AI Technology",
-                            "type": "concept",
-                            "subtype": "structural",
-                        }
-                    ],
                 },
             }
         }
@@ -1011,7 +1016,7 @@ class BankStatsResponse(BaseModel):
                 "failed_operations": 0,
                 "last_consolidated_at": "2024-01-15T10:30:00Z",
                 "pending_consolidation": 0,
-                "total_observations": 45,
+                "total_mental_models": 45,
             }
         }
     )
@@ -1028,8 +1033,8 @@ class BankStatsResponse(BaseModel):
     failed_operations: int
     # Consolidation stats
     last_consolidated_at: str | None = Field(default=None, description="When consolidation last ran (ISO format)")
-    pending_consolidation: int = Field(default=0, description="Number of memories not yet processed into observations")
-    total_observations: int = Field(default=0, description="Total number of observations")
+    pending_consolidation: int = Field(default=0, description="Number of memories not yet processed into mental models")
+    total_mental_models: int = Field(default=0, description="Total number of mental models")
 
 
 # Mental Model models
@@ -1090,21 +1095,12 @@ class UpdateDirectiveRequest(BaseModel):
 
 
 # =========================================================================
-# Mental Models (stored reflect responses)
+# Reflections Models
 # =========================================================================
 
 
-class MentalModelTrigger(BaseModel):
-    """Trigger settings for a mental model."""
-
-    refresh_after_consolidation: bool = Field(
-        default=False,
-        description="If true, refresh this mental model after observations consolidation (real-time mode)",
-    )
-
-
-class MentalModelResponse(BaseModel):
-    """Response model for a mental model (stored reflect response)."""
+class ReflectionResponse(BaseModel):
+    """Response model for a reflection."""
 
     id: str
     bank_id: str
@@ -1112,24 +1108,22 @@ class MentalModelResponse(BaseModel):
     source_query: str
     content: str
     tags: list[str] = Field(default_factory=list)
-    max_tokens: int = Field(default=2048)
-    trigger: MentalModelTrigger = Field(default_factory=MentalModelTrigger)
     last_refreshed_at: str | None = None
     created_at: str | None = None
     reflect_response: dict | None = Field(
         default=None,
-        description="Full reflect API response payload including based_on facts and observations",
+        description="Full reflect API response payload including based_on facts and mental_models",
     )
 
 
-class MentalModelListResponse(BaseModel):
-    """Response model for listing mental models."""
+class ReflectionListResponse(BaseModel):
+    """Response model for listing reflections."""
 
-    items: list[MentalModelResponse]
+    items: list[ReflectionResponse]
 
 
-class CreateMentalModelRequest(BaseModel):
-    """Request model for creating a mental model."""
+class CreateReflectionRequest(BaseModel):
+    """Request model for creating a reflection."""
 
     model_config = ConfigDict(
         json_schema_extra={
@@ -1138,44 +1132,34 @@ class CreateMentalModelRequest(BaseModel):
                 "source_query": "How does the team prefer to communicate?",
                 "tags": ["team"],
                 "max_tokens": 2048,
-                "trigger": {"refresh_after_consolidation": False},
             }
         }
     )
 
-    name: str = Field(description="Human-readable name for the mental model")
+    name: str = Field(description="Human-readable name for the reflection")
     source_query: str = Field(description="The query to run to generate content")
     tags: list[str] = Field(default_factory=list, description="Tags for scoped visibility")
     max_tokens: int = Field(default=2048, ge=256, le=8192, description="Maximum tokens for generated content")
-    trigger: MentalModelTrigger = Field(default_factory=MentalModelTrigger, description="Trigger settings")
 
 
-class CreateMentalModelResponse(BaseModel):
-    """Response model for mental model creation."""
+class CreateReflectionResponse(BaseModel):
+    """Response model for reflection creation."""
 
     operation_id: str = Field(description="Operation ID to track progress")
 
 
-class UpdateMentalModelRequest(BaseModel):
-    """Request model for updating a mental model."""
+class UpdateReflectionRequest(BaseModel):
+    """Request model for updating a reflection."""
 
     model_config = ConfigDict(
         json_schema_extra={
             "example": {
                 "name": "Updated Team Communication Preferences",
-                "source_query": "How does the team prefer to communicate?",
-                "max_tokens": 4096,
-                "tags": ["team", "communication"],
-                "trigger": {"refresh_after_consolidation": True},
             }
         }
     )
 
-    name: str | None = Field(default=None, description="New name for the mental model")
-    source_query: str | None = Field(default=None, description="New source query for the mental model")
-    max_tokens: int | None = Field(default=None, ge=256, le=8192, description="Maximum tokens for generated content")
-    tags: list[str] | None = Field(default=None, description="Tags for scoped visibility")
-    trigger: MentalModelTrigger | None = Field(default=None, description="Trigger settings")
+    name: str | None = Field(default=None, description="New name for the reflection")
 
 
 class OperationResponse(BaseModel):
@@ -1304,7 +1288,7 @@ class AsyncOperationSubmitResponse(BaseModel):
 class FeaturesInfo(BaseModel):
     """Feature flags indicating which capabilities are enabled."""
 
-    observations: bool = Field(description="Whether observations (auto-consolidation) are enabled")
+    mental_models: bool = Field(description="Whether mental models (auto-consolidation) are enabled")
     mcp: bool = Field(description="Whether MCP (Model Context Protocol) server is enabled")
     worker: bool = Field(description="Whether the background worker is enabled")
 
@@ -1315,9 +1299,9 @@ class VersionResponse(BaseModel):
     model_config = ConfigDict(
         json_schema_extra={
             "example": {
-                "api_version": "0.4.0",
+                "api_version": "1.0.0",
                 "features": {
-                    "observations": False,
+                    "mental_models": False,
                     "mcp": True,
                     "worker": True,
                 },
@@ -1398,21 +1382,14 @@ def create_app(
 
         # Start worker poller if enabled (standalone mode)
         if config.worker_enabled and memory._pool is not None:
-            from ..config import DEFAULT_DATABASE_SCHEMA
-
             worker_id = config.worker_id or socket.gethostname()
-            # Convert default schema to None for SQL compatibility (no schema prefix)
-            schema = None if config.database_schema == DEFAULT_DATABASE_SCHEMA else config.database_schema
             poller = WorkerPoller(
                 pool=memory._pool,
                 worker_id=worker_id,
                 executor=memory.execute_task,
                 poll_interval_ms=config.worker_poll_interval_ms,
+                batch_size=config.worker_batch_size,
                 max_retries=config.worker_max_retries,
-                schema=schema,
-                tenant_extension=memory._tenant_extension,
-                max_slots=config.worker_max_slots,
-                consolidation_max_slots=config.worker_consolidation_max_slots,
             )
             poller_task = asyncio.create_task(poller.run())
             logging.info(f"Worker poller started (worker_id={worker_id})")
@@ -1565,14 +1542,13 @@ def _register_routes(app: FastAPI):
         Returns version info and feature flags that can be used by clients
         to determine which capabilities are available.
         """
-        from hindsight_api import __version__
         from hindsight_api.config import get_config
 
         config = get_config()
         return VersionResponse(
-            api_version=__version__,
+            api_version="1.0.0",
             features=FeaturesInfo(
-                observations=config.enable_observations,
+                mental_models=config.enable_mental_models,
                 mcp=config.mcp_enabled,
                 worker=config.worker_enabled,
             ),
@@ -1705,7 +1681,9 @@ def _register_routes(app: FastAPI):
         description="Recall memory using semantic similarity and spreading activation.\n\n"
         "The type parameter is optional and must be one of:\n"
         "- `world`: General knowledge about people, places, events, and things that happen\n"
-        "- `experience`: Memories about experience, conversations, actions taken, and tasks performed",
+        "- `experience`: Memories about experience, conversations, actions taken, and tasks performed\n"
+        "- `opinion`: The bank's formed beliefs, perspectives, and viewpoints\n\n"
+        "Set `include_entities=true` to get entity observations alongside recall results.",
         operation_id="recall_memories",
         tags=["Memory"],
     )
@@ -1719,8 +1697,10 @@ def _register_routes(app: FastAPI):
         metrics = get_metrics_collector()
 
         try:
-            # Default to world and experience if not specified (exclude observation)
+            # Default to world and experience if not specified (exclude observation and opinion)
+            # Filter out 'opinion' even if requested - opinions are excluded from recall
             fact_types = request.types if request.types else list(VALID_RECALL_FACT_TYPES)
+            fact_types = [ft for ft in fact_types if ft != "opinion"]
 
             # Parse query_timestamp if provided
             question_date = None
@@ -1852,7 +1832,8 @@ def _register_routes(app: FastAPI):
         "2. Retrieves world facts relevant to the query\n"
         "3. Retrieves existing opinions (bank's perspectives)\n"
         "4. Uses LLM to formulate a contextual answer\n"
-        "5. Returns plain text answer and the facts used",
+        "5. Extracts and stores any new opinions formed\n"
+        "6. Returns plain text answer, the facts used, and new opinions",
         operation_id="reflect",
         tags=["Memory"],
     )
@@ -1881,48 +1862,25 @@ def _register_routes(app: FastAPI):
                     tags_match=request.tags_match,
                 )
 
-            # Build based_on (memories + mental_models + directives) if facts are requested
+            # Build based_on (memories + mental_models) if facts are requested
             based_on_result: ReflectBasedOn | None = None
             if request.include.facts is not None:
                 memories = []
-                mental_models = []
-                directives = []
                 for fact_type, facts in core_result.based_on.items():
-                    if fact_type == "directives":
-                        # Directives have different structure (id, name, content)
-                        for directive in facts:
-                            directives.append(
-                                ReflectDirective(
-                                    id=directive.id,
-                                    name=directive.name,
-                                    content=directive.content,
-                                )
+                    for fact in facts:
+                        memories.append(
+                            ReflectFact(
+                                id=fact.id,
+                                text=fact.text,
+                                type=fact.fact_type,
+                                context=fact.context,
+                                occurred_start=fact.occurred_start,
+                                occurred_end=fact.occurred_end,
                             )
-                    elif fact_type == "mental_models":
-                        # Mental models are MemoryFact with type "mental_models"
-                        for fact in facts:
-                            mental_models.append(
-                                ReflectMentalModel(
-                                    id=fact.id,
-                                    text=fact.text,
-                                    context=fact.context,
-                                )
-                            )
-                    else:
-                        for fact in facts:
-                            memories.append(
-                                ReflectFact(
-                                    id=fact.id,
-                                    text=fact.text,
-                                    type=fact.fact_type,
-                                    context=fact.context,
-                                    occurred_start=fact.occurred_start,
-                                    occurred_end=fact.occurred_end,
-                                )
-                            )
-                based_on_result = ReflectBasedOn(memories=memories, mental_models=mental_models, directives=directives)
+                        )
+                based_on_result = ReflectBasedOn(memories=memories)
 
-            # Build trace (tool_calls + llm_calls + observations) if tool_calls is requested
+            # Build trace (tool_calls + llm_calls + mental_models) if tool_calls is requested
             trace_result: ReflectTrace | None = None
             if request.include.tool_calls is not None:
                 include_output = request.include.tool_calls.output
@@ -1937,9 +1895,33 @@ def _register_routes(app: FastAPI):
                     for tc in core_result.tool_trace
                 ]
                 llm_calls = [ReflectLLMCall(scope=lc.scope, duration_ms=lc.duration_ms) for lc in core_result.llm_trace]
+                # Build map of directive observations by id
+                directive_observations = {d.id: d.rules for d in core_result.directives_applied}
+                # Build mental models from tool trace (get_mental_model outputs)
+                trace_mental_models: list[ReflectMentalModel] = []
+                seen_model_ids: set[str] = set()
+                for tc in core_result.tool_trace:
+                    if tc.tool == "get_mental_model" and tc.output.get("found") and "model" in tc.output:
+                        model = tc.output["model"]
+                        model_id = model.get("id")
+                        if model_id and model_id not in seen_model_ids:
+                            seen_model_ids.add(model_id)
+                            model_subtype = model.get("subtype", "structural")
+                            trace_mental_models.append(
+                                ReflectMentalModel(
+                                    id=model_id,
+                                    name=model.get("name", ""),
+                                    type=model.get("type", "concept"),
+                                    subtype=model_subtype,
+                                    observations=directive_observations.get(model_id)
+                                    if model_subtype == "directive"
+                                    else None,
+                                )
+                            )
                 trace_result = ReflectTrace(
                     tool_calls=tool_calls,
                     llm_calls=llm_calls,
+                    mental_models=trace_mental_models,
                 )
 
             return ReflectResponse(
@@ -2087,16 +2069,16 @@ def _register_routes(app: FastAPI):
                 last_consolidated_at = consolidation_stats["last_consolidated_at"] if consolidation_stats else None
                 pending_consolidation = consolidation_stats["pending"] if consolidation_stats else 0
 
-                # Count total observations (consolidated knowledge)
-                observation_count_result = await conn.fetchrow(
+                # Count total mental models
+                mental_model_count_result = await conn.fetchrow(
                     f"""
                     SELECT COUNT(*) as count
                     FROM {fq_table("memory_units")}
-                    WHERE bank_id = $1 AND fact_type = 'observation'
+                    WHERE bank_id = $1 AND fact_type = 'mental_model'
                     """,
                     bank_id,
                 )
-                total_observations = observation_count_result["count"] if observation_count_result else 0
+                total_mental_models = mental_model_count_result["count"] if mental_model_count_result else 0
 
                 # Format results
                 nodes_by_type = {row["fact_type"]: row["count"] for row in node_stats}
@@ -2129,7 +2111,7 @@ def _register_routes(app: FastAPI):
                     failed_operations=failed_operations,
                     last_consolidated_at=(last_consolidated_at.isoformat() if last_consolidated_at else None),
                     pending_consolidation=pending_consolidation,
-                    total_observations=total_observations,
+                    total_mental_models=total_mental_models,
                 )
 
         except (AuthenticationError, HTTPException):
@@ -2236,18 +2218,18 @@ def _register_routes(app: FastAPI):
 
     # =========================================================================
     # =========================================================================
-    # MENTAL MODELS ENDPOINTS (stored reflect responses)
+    # REFLECTIONS ENDPOINTS
     # =========================================================================
 
     @app.get(
-        "/v1/default/banks/{bank_id}/mental-models",
-        response_model=MentalModelListResponse,
-        summary="List mental models",
+        "/v1/default/banks/{bank_id}/reflections",
+        response_model=ReflectionListResponse,
+        summary="List reflections",
         description="List user-curated living documents that stay current.",
-        operation_id="list_mental_models",
-        tags=["Mental Models"],
+        operation_id="list_reflections",
+        tags=["Reflections"],
     )
-    async def api_list_mental_models(
+    async def api_list_reflections(
         bank_id: str,
         tags_filter: list[str] | None = Query(None, alias="tags", description="Filter by tags"),
         tags_match: Literal["any", "all", "exact"] = Query("any", description="How to match tags"),
@@ -2255,9 +2237,9 @@ def _register_routes(app: FastAPI):
         offset: int = Query(0, ge=0),
         request_context: RequestContext = Depends(get_request_context),
     ):
-        """List mental models for a bank."""
+        """List reflections for a bank."""
         try:
-            mental_models = await app.state.memory.list_mental_models(
+            reflections = await app.state.memory.list_reflections(
                 bank_id=bank_id,
                 tags=tags_filter,
                 tags_match=tags_match,
@@ -2265,187 +2247,103 @@ def _register_routes(app: FastAPI):
                 offset=offset,
                 request_context=request_context,
             )
-            return MentalModelListResponse(items=[MentalModelResponse(**m) for m in mental_models])
+            return ReflectionListResponse(items=[ReflectionResponse(**r) for r in reflections])
         except (AuthenticationError, HTTPException):
             raise
         except Exception as e:
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
-            logger.error(f"Error in GET /v1/default/banks/{bank_id}/mental-models: {error_detail}")
+            logger.error(f"Error in GET /v1/default/banks/{bank_id}/reflections: {error_detail}")
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.get(
-        "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
-        response_model=MentalModelResponse,
-        summary="Get mental model",
-        description="Get a specific mental model by ID.",
-        operation_id="get_mental_model",
-        tags=["Mental Models"],
+        "/v1/default/banks/{bank_id}/reflections/{reflection_id}",
+        response_model=ReflectionResponse,
+        summary="Get reflection",
+        description="Get a specific reflection by ID.",
+        operation_id="get_reflection",
+        tags=["Reflections"],
     )
-    async def api_get_mental_model(
+    async def api_get_reflection(
         bank_id: str,
-        mental_model_id: str,
+        reflection_id: str,
         request_context: RequestContext = Depends(get_request_context),
     ):
-        """Get a mental model by ID."""
+        """Get a reflection by ID."""
         try:
-            # Pre-operation validation hook
-            validator = app.state.memory._operation_validator
-            if validator:
-                from hindsight_api.extensions.operation_validator import MentalModelGetContext
-
-                ctx = MentalModelGetContext(
-                    bank_id=bank_id,
-                    mental_model_id=mental_model_id,
-                    request_context=request_context,
-                )
-                validation = await validator.validate_mental_model_get(ctx)
-                if not validation.allowed:
-                    raise OperationValidationError(
-                        validation.reason or "Operation not allowed",
-                        status_code=validation.status_code,
-                    )
-
-            mental_model = await app.state.memory.get_mental_model(
+            reflection = await app.state.memory.get_reflection(
                 bank_id=bank_id,
-                mental_model_id=mental_model_id,
+                reflection_id=reflection_id,
                 request_context=request_context,
             )
-            if mental_model is None:
-                raise HTTPException(status_code=404, detail=f"Mental model '{mental_model_id}' not found")
-
-            # Post-operation hook
-            if validator:
-                from hindsight_api.extensions.operation_validator import MentalModelGetResult
-
-                content = mental_model.get("content", "")
-                output_tokens = len(content) // 4 if content else 0
-
-                result_ctx = MentalModelGetResult(
-                    bank_id=bank_id,
-                    mental_model_id=mental_model_id,
-                    request_context=request_context,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-                try:
-                    await validator.on_mental_model_get_complete(result_ctx)
-                except Exception as hook_err:
-                    logger.warning(f"Post-mental-model-get hook error (non-fatal): {hook_err}")
-
-            return MentalModelResponse(**mental_model)
+            if reflection is None:
+                raise HTTPException(status_code=404, detail=f"Reflection '{reflection_id}' not found")
+            return ReflectionResponse(**reflection)
         except (AuthenticationError, HTTPException):
             raise
-        except OperationValidationError as e:
-            raise HTTPException(status_code=e.status_code, detail=e.reason)
         except Exception as e:
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
-            logger.error(f"Error in GET /v1/default/banks/{bank_id}/mental-models/{mental_model_id}: {error_detail}")
+            logger.error(f"Error in GET /v1/default/banks/{bank_id}/reflections/{reflection_id}: {error_detail}")
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.post(
-        "/v1/default/banks/{bank_id}/mental-models",
-        response_model=CreateMentalModelResponse,
-        summary="Create mental model",
-        description="Create a mental model by running reflect with the source query in the background. "
+        "/v1/default/banks/{bank_id}/reflections",
+        response_model=CreateReflectionResponse,
+        summary="Create reflection",
+        description="Create a reflection by running reflect with the source query in the background. "
         "Returns an operation ID to track progress. The content is auto-generated by the reflect endpoint. "
         "Use the operations endpoint to check completion status.",
-        operation_id="create_mental_model",
-        tags=["Mental Models"],
+        operation_id="create_reflection",
+        tags=["Reflections"],
     )
-    async def api_create_mental_model(
+    async def api_create_reflection(
         bank_id: str,
-        body: CreateMentalModelRequest,
+        body: CreateReflectionRequest,
         request_context: RequestContext = Depends(get_request_context),
     ):
-        """Create a mental model (async - returns operation_id)."""
+        """Create a reflection (async - returns operation_id)."""
         try:
-            # Pre-operation validation hook
-            validator = app.state.memory._operation_validator
-            if validator:
-                from hindsight_api.extensions.operation_validator import MentalModelRefreshContext
-
-                ctx = MentalModelRefreshContext(
-                    bank_id=bank_id,
-                    mental_model_id=None,  # Not yet created
-                    request_context=request_context,
-                )
-                validation = await validator.validate_mental_model_refresh(ctx)
-                if not validation.allowed:
-                    raise OperationValidationError(
-                        validation.reason or "Operation not allowed",
-                        status_code=validation.status_code,
-                    )
-
-            # 1. Create the mental model with placeholder content
-            mental_model = await app.state.memory.create_mental_model(
+            result = await app.state.memory.submit_async_create_reflection(
                 bank_id=bank_id,
                 name=body.name,
                 source_query=body.source_query,
-                content="Generating content...",
                 tags=body.tags if body.tags else None,
                 max_tokens=body.max_tokens,
-                trigger=body.trigger.model_dump() if body.trigger else None,
                 request_context=request_context,
             )
-            # 2. Schedule a refresh to generate the actual content
-            result = await app.state.memory.submit_async_refresh_mental_model(
-                bank_id=bank_id,
-                mental_model_id=mental_model["id"],
-                request_context=request_context,
-            )
-            return CreateMentalModelResponse(operation_id=result["operation_id"])
+            return CreateReflectionResponse(operation_id=result["operation_id"])
         except ValueError as e:
             raise HTTPException(status_code=400, detail=str(e))
         except (AuthenticationError, HTTPException):
             raise
-        except OperationValidationError as e:
-            raise HTTPException(status_code=e.status_code, detail=e.reason)
         except Exception as e:
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
-            logger.error(f"Error in POST /v1/default/banks/{bank_id}/mental-models: {error_detail}")
+            logger.error(f"Error in POST /v1/default/banks/{bank_id}/reflections: {error_detail}")
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.post(
-        "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}/refresh",
+        "/v1/default/banks/{bank_id}/reflections/{reflection_id}/refresh",
         response_model=AsyncOperationSubmitResponse,
-        summary="Refresh mental model",
+        summary="Refresh reflection",
         description="Submit an async task to re-run the source query through reflect and update the content.",
-        operation_id="refresh_mental_model",
-        tags=["Mental Models"],
+        operation_id="refresh_reflection",
+        tags=["Reflections"],
     )
-    async def api_refresh_mental_model(
+    async def api_refresh_reflection(
         bank_id: str,
-        mental_model_id: str,
+        reflection_id: str,
         request_context: RequestContext = Depends(get_request_context),
     ):
-        """Refresh a mental model by re-running its source query (async)."""
+        """Refresh a reflection by re-running its source query (async)."""
         try:
-            # Pre-operation validation hook
-            validator = app.state.memory._operation_validator
-            if validator:
-                from hindsight_api.extensions.operation_validator import MentalModelRefreshContext
-
-                ctx = MentalModelRefreshContext(
-                    bank_id=bank_id,
-                    mental_model_id=mental_model_id,
-                    request_context=request_context,
-                )
-                validation = await validator.validate_mental_model_refresh(ctx)
-                if not validation.allowed:
-                    raise OperationValidationError(
-                        validation.reason or "Operation not allowed",
-                        status_code=validation.status_code,
-                    )
-
-            result = await app.state.memory.submit_async_refresh_mental_model(
+            result = await app.state.memory.submit_async_refresh_reflection(
                 bank_id=bank_id,
-                mental_model_id=mental_model_id,
+                reflection_id=reflection_id,
                 request_context=request_context,
             )
             return AsyncOperationSubmitResponse(operation_id=result["operation_id"], status="queued")
@@ -2453,76 +2351,70 @@ def _register_routes(app: FastAPI):
             raise HTTPException(status_code=404, detail=str(e))
         except (AuthenticationError, HTTPException):
             raise
-        except OperationValidationError as e:
-            raise HTTPException(status_code=e.status_code, detail=e.reason)
         except Exception as e:
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
             logger.error(
-                f"Error in POST /v1/default/banks/{bank_id}/mental-models/{mental_model_id}/refresh: {error_detail}"
+                f"Error in POST /v1/default/banks/{bank_id}/reflections/{reflection_id}/refresh: {error_detail}"
             )
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.patch(
-        "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
-        response_model=MentalModelResponse,
-        summary="Update mental model",
-        description="Update a mental model's name and/or source query.",
-        operation_id="update_mental_model",
-        tags=["Mental Models"],
+        "/v1/default/banks/{bank_id}/reflections/{reflection_id}",
+        response_model=ReflectionResponse,
+        summary="Update reflection",
+        description="Update a reflection's name.",
+        operation_id="update_reflection",
+        tags=["Reflections"],
     )
-    async def api_update_mental_model(
+    async def api_update_reflection(
         bank_id: str,
-        mental_model_id: str,
-        body: UpdateMentalModelRequest,
+        reflection_id: str,
+        body: UpdateReflectionRequest,
         request_context: RequestContext = Depends(get_request_context),
     ):
-        """Update a mental model."""
+        """Update a reflection."""
         try:
-            mental_model = await app.state.memory.update_mental_model(
+            reflection = await app.state.memory.update_reflection(
                 bank_id=bank_id,
-                mental_model_id=mental_model_id,
+                reflection_id=reflection_id,
                 name=body.name,
-                source_query=body.source_query,
-                max_tokens=body.max_tokens,
-                tags=body.tags,
-                trigger=body.trigger.model_dump() if body.trigger else None,
                 request_context=request_context,
             )
-            if mental_model is None:
-                raise HTTPException(status_code=404, detail=f"Mental model '{mental_model_id}' not found")
-            return MentalModelResponse(**mental_model)
+            if reflection is None:
+                raise HTTPException(status_code=404, detail=f"Reflection '{reflection_id}' not found")
+            return ReflectionResponse(**reflection)
         except (AuthenticationError, HTTPException):
             raise
         except Exception as e:
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
-            logger.error(f"Error in PATCH /v1/default/banks/{bank_id}/mental-models/{mental_model_id}: {error_detail}")
+            logger.error(f"Error in PATCH /v1/default/banks/{bank_id}/reflections/{reflection_id}: {error_detail}")
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.delete(
-        "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
-        summary="Delete mental model",
-        description="Delete a mental model.",
-        operation_id="delete_mental_model",
-        tags=["Mental Models"],
+        "/v1/default/banks/{bank_id}/reflections/{reflection_id}",
+        summary="Delete reflection",
+        description="Delete a reflection.",
+        operation_id="delete_reflection",
+        tags=["Reflections"],
     )
-    async def api_delete_mental_model(
+    async def api_delete_reflection(
         bank_id: str,
-        mental_model_id: str,
+        reflection_id: str,
         request_context: RequestContext = Depends(get_request_context),
     ):
-        """Delete a mental model."""
+        """Delete a reflection."""
         try:
-            deleted = await app.state.memory.delete_mental_model(
+            deleted = await app.state.memory.delete_reflection(
                 bank_id=bank_id,
-                mental_model_id=mental_model_id,
+                reflection_id=reflection_id,
                 request_context=request_context,
             )
             if not deleted:
-                raise HTTPException(status_code=404, detail=f"Mental model '{mental_model_id}' not found")
+                raise HTTPException(status_code=404, detail=f"Reflection '{reflection_id}' not found")
             return {"status": "deleted"}
         except (AuthenticationError, HTTPException):
             raise
@@ -2530,7 +2422,7 @@ def _register_routes(app: FastAPI):
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
-            logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/mental-models/{mental_model_id}: {error_detail}")
+            logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/reflections/{reflection_id}: {error_detail}")
             raise HTTPException(status_code=500, detail=str(e))
 
     # =========================================================================
@@ -3254,20 +3146,20 @@ def _register_routes(app: FastAPI):
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.delete(
-        "/v1/default/banks/{bank_id}/observations",
+        "/v1/default/banks/{bank_id}/mental-models",
         response_model=DeleteResponse,
-        summary="Clear all observations",
-        description="Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.",
-        operation_id="clear_observations",
+        summary="Clear all mental models",
+        description="Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.",
+        operation_id="clear_mental_models",
         tags=["Banks"],
     )
-    async def api_clear_observations(bank_id: str, request_context: RequestContext = Depends(get_request_context)):
-        """Clear all observations for a bank."""
+    async def api_clear_mental_models(bank_id: str, request_context: RequestContext = Depends(get_request_context)):
+        """Clear all mental models for a bank."""
         try:
-            result = await app.state.memory.clear_observations(bank_id, request_context=request_context)
+            result = await app.state.memory.clear_mental_models(bank_id, request_context=request_context)
             return DeleteResponse(
                 success=True,
-                message=f"Cleared {result.get('deleted_count', 0)} observations",
+                message=f"Cleared {result.get('deleted_count', 0)} mental models",
                 deleted_count=result.get("deleted_count", 0),
             )
         except (AuthenticationError, HTTPException):
@@ -3276,14 +3168,14 @@ def _register_routes(app: FastAPI):
             import traceback
 
             error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
-            logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/observations: {error_detail}")
+            logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/mental-models: {error_detail}")
             raise HTTPException(status_code=500, detail=str(e))
 
     @app.post(
         "/v1/default/banks/{bank_id}/consolidate",
         response_model=ConsolidationResponse,
         summary="Trigger consolidation",
-        description="Run memory consolidation to create/update observations from recent memories.",
+        description="Run memory consolidation to create/update mental models from recent memories.",
         operation_id="trigger_consolidation",
         tags=["Banks"],
     )

hindsight-api/hindsight_api/api/mcp.py

@@ -29,26 +29,15 @@ logger = logging.getLogger(__name__)
 # Default bank_id from environment variable
 DEFAULT_BANK_ID = os.environ.get("HINDSIGHT_MCP_BANK_ID", "default")
 
-# MCP authentication token (optional - if set, Bearer token auth is required)
-MCP_AUTH_TOKEN = os.environ.get("HINDSIGHT_API_MCP_AUTH_TOKEN")
-
 # Context variable to hold the current bank_id
 _current_bank_id: ContextVar[str | None] = ContextVar("current_bank_id", default=None)
 
-# Context variable to hold the current API key (for tenant auth propagation)
-_current_api_key: ContextVar[str | None] = ContextVar("current_api_key", default=None)
-
 
 def get_current_bank_id() -> str | None:
     """Get the current bank_id from context."""
     return _current_bank_id.get()
 
 
-def get_current_api_key() -> str | None:
-    """Get the current API key from context."""
-    return _current_api_key.get()
-
-
 def create_mcp_server(memory: MemoryEngine) -> FastMCP:
     """
     Create and configure the Hindsight MCP server.
@@ -65,7 +54,6 @@ def create_mcp_server(memory: MemoryEngine) -> FastMCP:
     # Configure and register tools using shared module
     config = MCPToolsConfig(
         bank_id_resolver=get_current_bank_id,
-        api_key_resolver=get_current_api_key,  # Propagate API key for tenant auth
         include_bank_id_param=True,  # HTTP MCP supports multi-bank via parameter
         tools=None,  # All tools
         retain_fire_and_forget=False,  # HTTP MCP supports sync/async modes
@@ -77,11 +65,7 @@ def create_mcp_server(memory: MemoryEngine) -> FastMCP:
 
 
 class MCPMiddleware:
-    """ASGI middleware that handles authentication and extracts bank_id from header or path.
-
-    Authentication:
-        If HINDSIGHT_API_MCP_AUTH_TOKEN is set, all requests must include a valid
-        Authorization header with Bearer token or direct token matching the configured value.
+    """ASGI middleware that extracts bank_id from header or path and sets context.
 
     Bank ID can be provided via:
     1. X-Bank-Id header (recommended for Claude Code)
@@ -90,7 +74,7 @@ class MCPMiddleware:
 
     For Claude Code, configure with:
         claude mcp add --transport http hindsight http://localhost:8888/mcp \\
-            --header "X-Bank-Id: my-bank" --header "Authorization: Bearer <token>"
+            --header "X-Bank-Id: my-bank"
     """
 
     def __init__(self, app, memory: MemoryEngine):
@@ -114,22 +98,6 @@ class MCPMiddleware:
             await self.mcp_app(scope, receive, send)
             return
 
-        # Extract auth token from header (for tenant auth propagation)
-        auth_header = self._get_header(scope, "Authorization")
-        auth_token: str | None = None
-        if auth_header:
-            # Support both "Bearer <token>" and direct token
-            auth_token = auth_header[7:].strip() if auth_header.startswith("Bearer ") else auth_header.strip()
-
-        # Authenticate if MCP_AUTH_TOKEN is configured
-        if MCP_AUTH_TOKEN:
-            if not auth_token:
-                await self._send_error(send, 401, "Authorization header required")
-                return
-            if auth_token != MCP_AUTH_TOKEN:
-                await self._send_error(send, 401, "Invalid authentication token")
-                return
-
         path = scope.get("path", "")
 
         # Strip any mount prefix (e.g., /mcp) that FastAPI might not have stripped
@@ -164,10 +132,8 @@ class MCPMiddleware:
             bank_id = DEFAULT_BANK_ID
             logger.debug(f"Using default bank_id: {bank_id}")
 
-        # Set bank_id and api_key context
-        bank_id_token = _current_bank_id.set(bank_id)
-        # Store the auth token for tenant extension to validate
-        api_key_token = _current_api_key.set(auth_token) if auth_token else None
+        # Set bank_id context
+        token = _current_bank_id.set(bank_id)
         try:
             new_scope = scope.copy()
             new_scope["path"] = new_path
@@ -186,9 +152,7 @@ class MCPMiddleware:
 
             await self.mcp_app(new_scope, receive, send_wrapper)
         finally:
-            _current_bank_id.reset(bank_id_token)
-            if api_key_token is not None:
-                _current_api_key.reset(api_key_token)
+            _current_bank_id.reset(token)
 
     async def _send_error(self, send, status: int, message: str):
         """Send an error response."""
@@ -212,10 +176,6 @@ def create_mcp_app(memory: MemoryEngine):
     """
     Create an ASGI app that handles MCP requests.
 
-    Authentication:
-        Set HINDSIGHT_API_MCP_AUTH_TOKEN to require Bearer token authentication.
-        If not set, MCP endpoint is open (for local development).
-
     Bank ID can be provided via:
     1. X-Bank-Id header: claude mcp add --transport http hindsight http://localhost:8888/mcp --header "X-Bank-Id: my-bank"
     2. URL path: /mcp/{bank_id}/

hindsight-api/hindsight_api/banner.py

@@ -83,12 +83,9 @@ def print_startup_info(
     embeddings_provider: str,
     reranker_provider: str,
     mcp_enabled: bool = False,
-    version: str | None = None,
 ):
     """Print styled startup information."""
     print(color_start("Starting Hindsight API..."))
-    if version:
-        print(f"  {dim('Version:')} {color(f'v{version}', 0.1)}")
     print(f"  {dim('URL:')} {color(f'http://{host}:{port}', 0.2)}")
     print(f"  {dim('Database:')} {color(database_url, 0.4)}")
     print(f"  {dim('LLM:')} {color(f'{llm_provider} / {llm_model}', 0.6)}")

hindsight-api/hindsight_api/config.py

@@ -20,15 +20,11 @@ logger = logging.getLogger(__name__)
 
 # Environment variable names
 ENV_DATABASE_URL = "HINDSIGHT_API_DATABASE_URL"
-ENV_DATABASE_SCHEMA = "HINDSIGHT_API_DATABASE_SCHEMA"
 ENV_LLM_PROVIDER = "HINDSIGHT_API_LLM_PROVIDER"
 ENV_LLM_API_KEY = "HINDSIGHT_API_LLM_API_KEY"
 ENV_LLM_MODEL = "HINDSIGHT_API_LLM_MODEL"
 ENV_LLM_BASE_URL = "HINDSIGHT_API_LLM_BASE_URL"
 ENV_LLM_MAX_CONCURRENT = "HINDSIGHT_API_LLM_MAX_CONCURRENT"
-ENV_LLM_MAX_RETRIES = "HINDSIGHT_API_LLM_MAX_RETRIES"
-ENV_LLM_INITIAL_BACKOFF = "HINDSIGHT_API_LLM_INITIAL_BACKOFF"
-ENV_LLM_MAX_BACKOFF = "HINDSIGHT_API_LLM_MAX_BACKOFF"
 ENV_LLM_TIMEOUT = "HINDSIGHT_API_LLM_TIMEOUT"
 ENV_LLM_GROQ_SERVICE_TIER = "HINDSIGHT_API_LLM_GROQ_SERVICE_TIER"
 
@@ -37,35 +33,19 @@ ENV_RETAIN_LLM_PROVIDER = "HINDSIGHT_API_RETAIN_LLM_PROVIDER"
 ENV_RETAIN_LLM_API_KEY = "HINDSIGHT_API_RETAIN_LLM_API_KEY"
 ENV_RETAIN_LLM_MODEL = "HINDSIGHT_API_RETAIN_LLM_MODEL"
 ENV_RETAIN_LLM_BASE_URL = "HINDSIGHT_API_RETAIN_LLM_BASE_URL"
-ENV_RETAIN_LLM_MAX_CONCURRENT = "HINDSIGHT_API_RETAIN_LLM_MAX_CONCURRENT"
-ENV_RETAIN_LLM_MAX_RETRIES = "HINDSIGHT_API_RETAIN_LLM_MAX_RETRIES"
-ENV_RETAIN_LLM_INITIAL_BACKOFF = "HINDSIGHT_API_RETAIN_LLM_INITIAL_BACKOFF"
-ENV_RETAIN_LLM_MAX_BACKOFF = "HINDSIGHT_API_RETAIN_LLM_MAX_BACKOFF"
-ENV_RETAIN_LLM_TIMEOUT = "HINDSIGHT_API_RETAIN_LLM_TIMEOUT"
 
 ENV_REFLECT_LLM_PROVIDER = "HINDSIGHT_API_REFLECT_LLM_PROVIDER"
 ENV_REFLECT_LLM_API_KEY = "HINDSIGHT_API_REFLECT_LLM_API_KEY"
 ENV_REFLECT_LLM_MODEL = "HINDSIGHT_API_REFLECT_LLM_MODEL"
 ENV_REFLECT_LLM_BASE_URL = "HINDSIGHT_API_REFLECT_LLM_BASE_URL"
-ENV_REFLECT_LLM_MAX_CONCURRENT = "HINDSIGHT_API_REFLECT_LLM_MAX_CONCURRENT"
-ENV_REFLECT_LLM_MAX_RETRIES = "HINDSIGHT_API_REFLECT_LLM_MAX_RETRIES"
-ENV_REFLECT_LLM_INITIAL_BACKOFF = "HINDSIGHT_API_REFLECT_LLM_INITIAL_BACKOFF"
-ENV_REFLECT_LLM_MAX_BACKOFF = "HINDSIGHT_API_REFLECT_LLM_MAX_BACKOFF"
-ENV_REFLECT_LLM_TIMEOUT = "HINDSIGHT_API_REFLECT_LLM_TIMEOUT"
 
 ENV_CONSOLIDATION_LLM_PROVIDER = "HINDSIGHT_API_CONSOLIDATION_LLM_PROVIDER"
 ENV_CONSOLIDATION_LLM_API_KEY = "HINDSIGHT_API_CONSOLIDATION_LLM_API_KEY"
 ENV_CONSOLIDATION_LLM_MODEL = "HINDSIGHT_API_CONSOLIDATION_LLM_MODEL"
 ENV_CONSOLIDATION_LLM_BASE_URL = "HINDSIGHT_API_CONSOLIDATION_LLM_BASE_URL"
-ENV_CONSOLIDATION_LLM_MAX_CONCURRENT = "HINDSIGHT_API_CONSOLIDATION_LLM_MAX_CONCURRENT"
-ENV_CONSOLIDATION_LLM_MAX_RETRIES = "HINDSIGHT_API_CONSOLIDATION_LLM_MAX_RETRIES"
-ENV_CONSOLIDATION_LLM_INITIAL_BACKOFF = "HINDSIGHT_API_CONSOLIDATION_LLM_INITIAL_BACKOFF"
-ENV_CONSOLIDATION_LLM_MAX_BACKOFF = "HINDSIGHT_API_CONSOLIDATION_LLM_MAX_BACKOFF"
-ENV_CONSOLIDATION_LLM_TIMEOUT = "HINDSIGHT_API_CONSOLIDATION_LLM_TIMEOUT"
 
 ENV_EMBEDDINGS_PROVIDER = "HINDSIGHT_API_EMBEDDINGS_PROVIDER"
 ENV_EMBEDDINGS_LOCAL_MODEL = "HINDSIGHT_API_EMBEDDINGS_LOCAL_MODEL"
-ENV_EMBEDDINGS_LOCAL_FORCE_CPU = "HINDSIGHT_API_EMBEDDINGS_LOCAL_FORCE_CPU"
 ENV_EMBEDDINGS_TEI_URL = "HINDSIGHT_API_EMBEDDINGS_TEI_URL"
 ENV_EMBEDDINGS_OPENAI_API_KEY = "HINDSIGHT_API_EMBEDDINGS_OPENAI_API_KEY"
 ENV_EMBEDDINGS_OPENAI_MODEL = "HINDSIGHT_API_EMBEDDINGS_OPENAI_MODEL"
@@ -85,7 +65,6 @@ ENV_RERANKER_LITELLM_MODEL = "HINDSIGHT_API_RERANKER_LITELLM_MODEL"
 
 ENV_RERANKER_PROVIDER = "HINDSIGHT_API_RERANKER_PROVIDER"
 ENV_RERANKER_LOCAL_MODEL = "HINDSIGHT_API_RERANKER_LOCAL_MODEL"
-ENV_RERANKER_LOCAL_FORCE_CPU = "HINDSIGHT_API_RERANKER_LOCAL_FORCE_CPU"
 ENV_RERANKER_LOCAL_MAX_CONCURRENT = "HINDSIGHT_API_RERANKER_LOCAL_MAX_CONCURRENT"
 ENV_RERANKER_TEI_URL = "HINDSIGHT_API_RERANKER_TEI_URL"
 ENV_RERANKER_TEI_BATCH_SIZE = "HINDSIGHT_API_RERANKER_TEI_BATCH_SIZE"
@@ -108,22 +87,21 @@ ENV_MCP_LOCAL_BANK_ID = "HINDSIGHT_API_MCP_LOCAL_BANK_ID"
 ENV_MCP_INSTRUCTIONS = "HINDSIGHT_API_MCP_INSTRUCTIONS"
 ENV_MENTAL_MODEL_REFRESH_CONCURRENCY = "HINDSIGHT_API_MENTAL_MODEL_REFRESH_CONCURRENCY"
 
-# Vertex AI configuration
-ENV_LLM_VERTEXAI_PROJECT_ID = "HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID"
-ENV_LLM_VERTEXAI_REGION = "HINDSIGHT_API_LLM_VERTEXAI_REGION"
-ENV_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY = "HINDSIGHT_API_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY"
+# Observation thresholds
+ENV_OBSERVATION_MIN_FACTS = "HINDSIGHT_API_OBSERVATION_MIN_FACTS"
+ENV_OBSERVATION_TOP_ENTITIES = "HINDSIGHT_API_OBSERVATION_TOP_ENTITIES"
 
 # Retain settings
 ENV_RETAIN_MAX_COMPLETION_TOKENS = "HINDSIGHT_API_RETAIN_MAX_COMPLETION_TOKENS"
 ENV_RETAIN_CHUNK_SIZE = "HINDSIGHT_API_RETAIN_CHUNK_SIZE"
 ENV_RETAIN_EXTRACT_CAUSAL_LINKS = "HINDSIGHT_API_RETAIN_EXTRACT_CAUSAL_LINKS"
 ENV_RETAIN_EXTRACTION_MODE = "HINDSIGHT_API_RETAIN_EXTRACTION_MODE"
-ENV_RETAIN_CUSTOM_INSTRUCTIONS = "HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS"
+ENV_RETAIN_OBSERVATIONS_ASYNC = "HINDSIGHT_API_RETAIN_OBSERVATIONS_ASYNC"
 
-# Observations settings (consolidated knowledge from facts)
-ENV_ENABLE_OBSERVATIONS = "HINDSIGHT_API_ENABLE_OBSERVATIONS"
+# Mental models settings
+ENV_ENABLE_MENTAL_MODELS = "HINDSIGHT_API_ENABLE_MENTAL_MODELS"
+ENV_CONSOLIDATION_SIMILARITY_THRESHOLD = "HINDSIGHT_API_CONSOLIDATION_SIMILARITY_THRESHOLD"
 ENV_CONSOLIDATION_BATCH_SIZE = "HINDSIGHT_API_CONSOLIDATION_BATCH_SIZE"
-ENV_CONSOLIDATION_MAX_TOKENS = "HINDSIGHT_API_CONSOLIDATION_MAX_TOKENS"
 
 # Optimization flags
 ENV_SKIP_LLM_VERIFICATION = "HINDSIGHT_API_SKIP_LLM_VERIFICATION"
@@ -143,52 +121,26 @@ ENV_WORKER_ENABLED = "HINDSIGHT_API_WORKER_ENABLED"
 ENV_WORKER_ID = "HINDSIGHT_API_WORKER_ID"
 ENV_WORKER_POLL_INTERVAL_MS = "HINDSIGHT_API_WORKER_POLL_INTERVAL_MS"
 ENV_WORKER_MAX_RETRIES = "HINDSIGHT_API_WORKER_MAX_RETRIES"
+ENV_WORKER_BATCH_SIZE = "HINDSIGHT_API_WORKER_BATCH_SIZE"
 ENV_WORKER_HTTP_PORT = "HINDSIGHT_API_WORKER_HTTP_PORT"
-ENV_WORKER_MAX_SLOTS = "HINDSIGHT_API_WORKER_MAX_SLOTS"
-ENV_WORKER_CONSOLIDATION_MAX_SLOTS = "HINDSIGHT_API_WORKER_CONSOLIDATION_MAX_SLOTS"
 
 # Reflect agent settings
 ENV_REFLECT_MAX_ITERATIONS = "HINDSIGHT_API_REFLECT_MAX_ITERATIONS"
 
 # Default values
 DEFAULT_DATABASE_URL = "pg0"
-DEFAULT_DATABASE_SCHEMA = "public"
 DEFAULT_LLM_PROVIDER = "openai"
-
-# Provider-specific default models
-PROVIDER_DEFAULT_MODELS = {
-    "openai": "o3-mini",
-    "anthropic": "claude-haiku-4-5-20251001",
-    "gemini": "gemini-2.5-flash",
-    "groq": "openai/gpt-oss-120b",
-    "ollama": "gemma3:12b",
-    "lmstudio": "local-model",
-    "vertexai": "gemini-2.0-flash-001",
-    "openai-codex": "gpt-5.2-codex",
-    "claude-code": "claude-sonnet-4-5-20250929",
-    "mock": "mock-model",
-}
-DEFAULT_LLM_MODEL = "o3-mini"  # Fallback if provider not in table
+DEFAULT_LLM_MODEL = "gpt-5-mini"
 DEFAULT_LLM_MAX_CONCURRENT = 32
-DEFAULT_LLM_MAX_RETRIES = 10  # Max retry attempts for LLM API calls
-DEFAULT_LLM_INITIAL_BACKOFF = 1.0  # Initial backoff in seconds for retry exponential backoff
-DEFAULT_LLM_MAX_BACKOFF = 60.0  # Max backoff cap in seconds for retry exponential backoff
 DEFAULT_LLM_TIMEOUT = 120.0  # seconds
 
-# Vertex AI defaults
-DEFAULT_LLM_VERTEXAI_PROJECT_ID = None  # Required for Vertex AI
-DEFAULT_LLM_VERTEXAI_REGION = "us-central1"
-DEFAULT_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY = None  # Optional, uses ADC if not set
-
 DEFAULT_EMBEDDINGS_PROVIDER = "local"
 DEFAULT_EMBEDDINGS_LOCAL_MODEL = "BAAI/bge-small-en-v1.5"
-DEFAULT_EMBEDDINGS_LOCAL_FORCE_CPU = False  # Force CPU mode for local embeddings (avoids MPS/XPC issues on macOS)
 DEFAULT_EMBEDDINGS_OPENAI_MODEL = "text-embedding-3-small"
 DEFAULT_EMBEDDING_DIMENSION = 384
 
 DEFAULT_RERANKER_PROVIDER = "local"
 DEFAULT_RERANKER_LOCAL_MODEL = "cross-encoder/ms-marco-MiniLM-L-6-v2"
-DEFAULT_RERANKER_LOCAL_FORCE_CPU = False  # Force CPU mode for local reranker (avoids MPS/XPC issues on macOS)
 DEFAULT_RERANKER_LOCAL_MAX_CONCURRENT = 4  # Limit concurrent CPU-bound reranking to prevent thrashing
 DEFAULT_RERANKER_TEI_BATCH_SIZE = 128
 DEFAULT_RERANKER_TEI_MAX_CONCURRENT = 8
@@ -217,18 +169,22 @@ DEFAULT_RECALL_CONNECTION_BUDGET = 4  # Max concurrent DB connections per recall
 DEFAULT_MCP_LOCAL_BANK_ID = "mcp"
 DEFAULT_MENTAL_MODEL_REFRESH_CONCURRENCY = 8  # Max concurrent mental model refreshes
 
+# Observation thresholds
+DEFAULT_OBSERVATION_MIN_FACTS = 5  # Min facts required to generate entity observations
+DEFAULT_OBSERVATION_TOP_ENTITIES = 5  # Max entities to process per retain batch
+
 # Retain settings
 DEFAULT_RETAIN_MAX_COMPLETION_TOKENS = 64000  # Max tokens for fact extraction LLM call
 DEFAULT_RETAIN_CHUNK_SIZE = 3000  # Max chars per chunk for fact extraction
 DEFAULT_RETAIN_EXTRACT_CAUSAL_LINKS = True  # Extract causal links between facts
-DEFAULT_RETAIN_EXTRACTION_MODE = "concise"  # Extraction mode: "concise", "verbose", or "custom"
-RETAIN_EXTRACTION_MODES = ("concise", "verbose", "custom")  # Allowed extraction modes
-DEFAULT_RETAIN_CUSTOM_INSTRUCTIONS = None  # Custom extraction guidelines (only used when mode="custom")
+DEFAULT_RETAIN_EXTRACTION_MODE = "concise"  # Extraction mode: "concise" or "verbose"
+RETAIN_EXTRACTION_MODES = ("concise", "verbose")  # Allowed extraction modes
+DEFAULT_RETAIN_OBSERVATIONS_ASYNC = False  # Run observation generation async (after retain completes)
 
-# Observations defaults (consolidated knowledge from facts)
-DEFAULT_ENABLE_OBSERVATIONS = True  # Observations enabled by default
+# Mental models defaults
+DEFAULT_ENABLE_MENTAL_MODELS = False  # Mental models disabled by default (experimental)
+DEFAULT_CONSOLIDATION_SIMILARITY_THRESHOLD = 0.75  # Minimum similarity to consider a learning related
 DEFAULT_CONSOLIDATION_BATCH_SIZE = 50  # Memories to load per batch (internal memory optimization)
-DEFAULT_CONSOLIDATION_MAX_TOKENS = 1024  # Max tokens for recall when finding related observations
 
 # Database migrations
 DEFAULT_RUN_MIGRATIONS_ON_STARTUP = True
@@ -244,9 +200,8 @@ DEFAULT_WORKER_ENABLED = True  # API runs worker by default (standalone mode)
 DEFAULT_WORKER_ID = None  # Will use hostname if not specified
 DEFAULT_WORKER_POLL_INTERVAL_MS = 500  # Poll database every 500ms
 DEFAULT_WORKER_MAX_RETRIES = 3  # Max retries before marking task failed
+DEFAULT_WORKER_BATCH_SIZE = 10  # Tasks to claim per poll cycle
 DEFAULT_WORKER_HTTP_PORT = 8889  # HTTP port for worker metrics/health
-DEFAULT_WORKER_MAX_SLOTS = 10  # Total concurrent tasks per worker
-DEFAULT_WORKER_CONSOLIDATION_MAX_SLOTS = 2  # Max concurrent consolidation tasks per worker
 
 # Reflect agent settings
 DEFAULT_REFLECT_MAX_ITERATIONS = 10  # Max tool call iterations before forcing response
@@ -317,18 +272,12 @@ def _validate_extraction_mode(mode: str) -> str:
     return mode_lower
 
 
-def _get_default_model_for_provider(provider: str) -> str:
-    """Get the default model for a given provider."""
-    return PROVIDER_DEFAULT_MODELS.get(provider.lower(), DEFAULT_LLM_MODEL)
-
-
 @dataclass
 class HindsightConfig:
     """Configuration container for Hindsight API."""
 
     # Database
     database_url: str
-    database_schema: str
 
     # LLM (default, used as fallback for per-operation config)
     llm_provider: str
@@ -336,51 +285,27 @@ class HindsightConfig:
     llm_model: str
     llm_base_url: str | None
     llm_max_concurrent: int
-    llm_max_retries: int
-    llm_initial_backoff: float
-    llm_max_backoff: float
     llm_timeout: float
 
-    # Vertex AI configuration
-    llm_vertexai_project_id: str | None
-    llm_vertexai_region: str
-    llm_vertexai_service_account_key: str | None
-
     # Per-operation LLM configuration (None = use default LLM config)
     retain_llm_provider: str | None
     retain_llm_api_key: str | None
     retain_llm_model: str | None
     retain_llm_base_url: str | None
-    retain_llm_max_concurrent: int | None
-    retain_llm_max_retries: int | None
-    retain_llm_initial_backoff: float | None
-    retain_llm_max_backoff: float | None
-    retain_llm_timeout: float | None
 
     reflect_llm_provider: str | None
     reflect_llm_api_key: str | None
     reflect_llm_model: str | None
     reflect_llm_base_url: str | None
-    reflect_llm_max_concurrent: int | None
-    reflect_llm_max_retries: int | None
-    reflect_llm_initial_backoff: float | None
-    reflect_llm_max_backoff: float | None
-    reflect_llm_timeout: float | None
 
     consolidation_llm_provider: str | None
     consolidation_llm_api_key: str | None
     consolidation_llm_model: str | None
     consolidation_llm_base_url: str | None
-    consolidation_llm_max_concurrent: int | None
-    consolidation_llm_max_retries: int | None
-    consolidation_llm_initial_backoff: float | None
-    consolidation_llm_max_backoff: float | None
-    consolidation_llm_timeout: float | None
 
     # Embeddings
     embeddings_provider: str
     embeddings_local_model: str
-    embeddings_local_force_cpu: bool
     embeddings_tei_url: str | None
     embeddings_openai_base_url: str | None
     embeddings_cohere_base_url: str | None
@@ -388,8 +313,6 @@ class HindsightConfig:
     # Reranker
     reranker_provider: str
     reranker_local_model: str
-    reranker_local_force_cpu: bool
-    reranker_local_max_concurrent: int
     reranker_tei_url: str | None
     reranker_tei_batch_size: int
     reranker_tei_max_concurrent: int
@@ -410,17 +333,21 @@ class HindsightConfig:
     recall_connection_budget: int
     mental_model_refresh_concurrency: int
 
+    # Observation thresholds
+    observation_min_facts: int
+    observation_top_entities: int
+
     # Retain settings
     retain_max_completion_tokens: int
     retain_chunk_size: int
     retain_extract_causal_links: bool
     retain_extraction_mode: str
-    retain_custom_instructions: str | None
+    retain_observations_async: bool
 
-    # Observations settings (consolidated knowledge from facts)
-    enable_observations: bool
+    # Mental models settings
+    enable_mental_models: bool
+    consolidation_similarity_threshold: float
     consolidation_batch_size: int
-    consolidation_max_tokens: int
 
     # Optimization flags
     skip_llm_verification: bool
@@ -440,9 +367,8 @@ class HindsightConfig:
     worker_id: str | None
     worker_poll_interval_ms: int
     worker_max_retries: int
+    worker_batch_size: int
     worker_http_port: int
-    worker_max_slots: int
-    worker_consolidation_max_slots: int
 
     # Reflect agent settings
     reflect_max_iterations: int
@@ -450,120 +376,38 @@ class HindsightConfig:
     @classmethod
     def from_env(cls) -> "HindsightConfig":
         """Create configuration from environment variables."""
-        # Get provider first to determine default model
-        llm_provider = os.getenv(ENV_LLM_PROVIDER, DEFAULT_LLM_PROVIDER)
-        llm_model = os.getenv(ENV_LLM_MODEL) or _get_default_model_for_provider(llm_provider)
-
         return cls(
             # Database
             database_url=os.getenv(ENV_DATABASE_URL, DEFAULT_DATABASE_URL),
-            database_schema=os.getenv(ENV_DATABASE_SCHEMA, DEFAULT_DATABASE_SCHEMA),
             # LLM
-            llm_provider=llm_provider,
+            llm_provider=os.getenv(ENV_LLM_PROVIDER, DEFAULT_LLM_PROVIDER),
             llm_api_key=os.getenv(ENV_LLM_API_KEY),
-            llm_model=llm_model,
+            llm_model=os.getenv(ENV_LLM_MODEL, DEFAULT_LLM_MODEL),
             llm_base_url=os.getenv(ENV_LLM_BASE_URL) or None,
             llm_max_concurrent=int(os.getenv(ENV_LLM_MAX_CONCURRENT, str(DEFAULT_LLM_MAX_CONCURRENT))),
-            llm_max_retries=int(os.getenv(ENV_LLM_MAX_RETRIES, str(DEFAULT_LLM_MAX_RETRIES))),
-            llm_initial_backoff=float(os.getenv(ENV_LLM_INITIAL_BACKOFF, str(DEFAULT_LLM_INITIAL_BACKOFF))),
-            llm_max_backoff=float(os.getenv(ENV_LLM_MAX_BACKOFF, str(DEFAULT_LLM_MAX_BACKOFF))),
             llm_timeout=float(os.getenv(ENV_LLM_TIMEOUT, str(DEFAULT_LLM_TIMEOUT))),
-            # Vertex AI
-            llm_vertexai_project_id=os.getenv(ENV_LLM_VERTEXAI_PROJECT_ID) or DEFAULT_LLM_VERTEXAI_PROJECT_ID,
-            llm_vertexai_region=os.getenv(ENV_LLM_VERTEXAI_REGION, DEFAULT_LLM_VERTEXAI_REGION),
-            llm_vertexai_service_account_key=os.getenv(ENV_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY)
-            or DEFAULT_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY,
             # Per-operation LLM config (None = use default)
             retain_llm_provider=os.getenv(ENV_RETAIN_LLM_PROVIDER) or None,
             retain_llm_api_key=os.getenv(ENV_RETAIN_LLM_API_KEY) or None,
-            retain_llm_model=os.getenv(ENV_RETAIN_LLM_MODEL)
-            or (
-                _get_default_model_for_provider(os.getenv(ENV_RETAIN_LLM_PROVIDER))
-                if os.getenv(ENV_RETAIN_LLM_PROVIDER)
-                else None
-            ),
+            retain_llm_model=os.getenv(ENV_RETAIN_LLM_MODEL) or None,
             retain_llm_base_url=os.getenv(ENV_RETAIN_LLM_BASE_URL) or None,
-            retain_llm_max_concurrent=int(os.getenv(ENV_RETAIN_LLM_MAX_CONCURRENT))
-            if os.getenv(ENV_RETAIN_LLM_MAX_CONCURRENT)
-            else None,
-            retain_llm_max_retries=int(os.getenv(ENV_RETAIN_LLM_MAX_RETRIES))
-            if os.getenv(ENV_RETAIN_LLM_MAX_RETRIES)
-            else None,
-            retain_llm_initial_backoff=float(os.getenv(ENV_RETAIN_LLM_INITIAL_BACKOFF))
-            if os.getenv(ENV_RETAIN_LLM_INITIAL_BACKOFF)
-            else None,
-            retain_llm_max_backoff=float(os.getenv(ENV_RETAIN_LLM_MAX_BACKOFF))
-            if os.getenv(ENV_RETAIN_LLM_MAX_BACKOFF)
-            else None,
-            retain_llm_timeout=float(os.getenv(ENV_RETAIN_LLM_TIMEOUT)) if os.getenv(ENV_RETAIN_LLM_TIMEOUT) else None,
             reflect_llm_provider=os.getenv(ENV_REFLECT_LLM_PROVIDER) or None,
             reflect_llm_api_key=os.getenv(ENV_REFLECT_LLM_API_KEY) or None,
-            reflect_llm_model=os.getenv(ENV_REFLECT_LLM_MODEL)
-            or (
-                _get_default_model_for_provider(os.getenv(ENV_REFLECT_LLM_PROVIDER))
-                if os.getenv(ENV_REFLECT_LLM_PROVIDER)
-                else None
-            ),
+            reflect_llm_model=os.getenv(ENV_REFLECT_LLM_MODEL) or None,
             reflect_llm_base_url=os.getenv(ENV_REFLECT_LLM_BASE_URL) or None,
-            reflect_llm_max_concurrent=int(os.getenv(ENV_REFLECT_LLM_MAX_CONCURRENT))
-            if os.getenv(ENV_REFLECT_LLM_MAX_CONCURRENT)
-            else None,
-            reflect_llm_max_retries=int(os.getenv(ENV_REFLECT_LLM_MAX_RETRIES))
-            if os.getenv(ENV_REFLECT_LLM_MAX_RETRIES)
-            else None,
-            reflect_llm_initial_backoff=float(os.getenv(ENV_REFLECT_LLM_INITIAL_BACKOFF))
-            if os.getenv(ENV_REFLECT_LLM_INITIAL_BACKOFF)
-            else None,
-            reflect_llm_max_backoff=float(os.getenv(ENV_REFLECT_LLM_MAX_BACKOFF))
-            if os.getenv(ENV_REFLECT_LLM_MAX_BACKOFF)
-            else None,
-            reflect_llm_timeout=float(os.getenv(ENV_REFLECT_LLM_TIMEOUT))
-            if os.getenv(ENV_REFLECT_LLM_TIMEOUT)
-            else None,
             consolidation_llm_provider=os.getenv(ENV_CONSOLIDATION_LLM_PROVIDER) or None,
             consolidation_llm_api_key=os.getenv(ENV_CONSOLIDATION_LLM_API_KEY) or None,
-            consolidation_llm_model=os.getenv(ENV_CONSOLIDATION_LLM_MODEL)
-            or (
-                _get_default_model_for_provider(os.getenv(ENV_CONSOLIDATION_LLM_PROVIDER))
-                if os.getenv(ENV_CONSOLIDATION_LLM_PROVIDER)
-                else None
-            ),
+            consolidation_llm_model=os.getenv(ENV_CONSOLIDATION_LLM_MODEL) or None,
             consolidation_llm_base_url=os.getenv(ENV_CONSOLIDATION_LLM_BASE_URL) or None,
-            consolidation_llm_max_concurrent=int(os.getenv(ENV_CONSOLIDATION_LLM_MAX_CONCURRENT))
-            if os.getenv(ENV_CONSOLIDATION_LLM_MAX_CONCURRENT)
-            else None,
-            consolidation_llm_max_retries=int(os.getenv(ENV_CONSOLIDATION_LLM_MAX_RETRIES))
-            if os.getenv(ENV_CONSOLIDATION_LLM_MAX_RETRIES)
-            else None,
-            consolidation_llm_initial_backoff=float(os.getenv(ENV_CONSOLIDATION_LLM_INITIAL_BACKOFF))
-            if os.getenv(ENV_CONSOLIDATION_LLM_INITIAL_BACKOFF)
-            else None,
-            consolidation_llm_max_backoff=float(os.getenv(ENV_CONSOLIDATION_LLM_MAX_BACKOFF))
-            if os.getenv(ENV_CONSOLIDATION_LLM_MAX_BACKOFF)
-            else None,
-            consolidation_llm_timeout=float(os.getenv(ENV_CONSOLIDATION_LLM_TIMEOUT))
-            if os.getenv(ENV_CONSOLIDATION_LLM_TIMEOUT)
-            else None,
             # Embeddings
             embeddings_provider=os.getenv(ENV_EMBEDDINGS_PROVIDER, DEFAULT_EMBEDDINGS_PROVIDER),
             embeddings_local_model=os.getenv(ENV_EMBEDDINGS_LOCAL_MODEL, DEFAULT_EMBEDDINGS_LOCAL_MODEL),
-            embeddings_local_force_cpu=os.getenv(
-                ENV_EMBEDDINGS_LOCAL_FORCE_CPU, str(DEFAULT_EMBEDDINGS_LOCAL_FORCE_CPU)
-            ).lower()
-            in ("true", "1"),
             embeddings_tei_url=os.getenv(ENV_EMBEDDINGS_TEI_URL),
             embeddings_openai_base_url=os.getenv(ENV_EMBEDDINGS_OPENAI_BASE_URL) or None,
             embeddings_cohere_base_url=os.getenv(ENV_EMBEDDINGS_COHERE_BASE_URL) or None,
             # Reranker
             reranker_provider=os.getenv(ENV_RERANKER_PROVIDER, DEFAULT_RERANKER_PROVIDER),
             reranker_local_model=os.getenv(ENV_RERANKER_LOCAL_MODEL, DEFAULT_RERANKER_LOCAL_MODEL),
-            reranker_local_force_cpu=os.getenv(
-                ENV_RERANKER_LOCAL_FORCE_CPU, str(DEFAULT_RERANKER_LOCAL_FORCE_CPU)
-            ).lower()
-            in ("true", "1"),
-            reranker_local_max_concurrent=int(
-                os.getenv(ENV_RERANKER_LOCAL_MAX_CONCURRENT, str(DEFAULT_RERANKER_LOCAL_MAX_CONCURRENT))
-            ),
             reranker_tei_url=os.getenv(ENV_RERANKER_TEI_URL),
             reranker_tei_batch_size=int(os.getenv(ENV_RERANKER_TEI_BATCH_SIZE, str(DEFAULT_RERANKER_TEI_BATCH_SIZE))),
             reranker_tei_max_concurrent=int(
@@ -590,6 +434,11 @@ class HindsightConfig:
             # Optimization flags
             skip_llm_verification=os.getenv(ENV_SKIP_LLM_VERIFICATION, "false").lower() == "true",
             lazy_reranker=os.getenv(ENV_LAZY_RERANKER, "false").lower() == "true",
+            # Observation thresholds
+            observation_min_facts=int(os.getenv(ENV_OBSERVATION_MIN_FACTS, str(DEFAULT_OBSERVATION_MIN_FACTS))),
+            observation_top_entities=int(
+                os.getenv(ENV_OBSERVATION_TOP_ENTITIES, str(DEFAULT_OBSERVATION_TOP_ENTITIES))
+            ),
             # Retain settings
             retain_max_completion_tokens=int(
                 os.getenv(ENV_RETAIN_MAX_COMPLETION_TOKENS, str(DEFAULT_RETAIN_MAX_COMPLETION_TOKENS))
@@ -602,15 +451,19 @@ class HindsightConfig:
             retain_extraction_mode=_validate_extraction_mode(
                 os.getenv(ENV_RETAIN_EXTRACTION_MODE, DEFAULT_RETAIN_EXTRACTION_MODE)
             ),
-            retain_custom_instructions=os.getenv(ENV_RETAIN_CUSTOM_INSTRUCTIONS) or DEFAULT_RETAIN_CUSTOM_INSTRUCTIONS,
-            # Observations settings (consolidated knowledge from facts)
-            enable_observations=os.getenv(ENV_ENABLE_OBSERVATIONS, str(DEFAULT_ENABLE_OBSERVATIONS)).lower() == "true",
+            retain_observations_async=os.getenv(
+                ENV_RETAIN_OBSERVATIONS_ASYNC, str(DEFAULT_RETAIN_OBSERVATIONS_ASYNC)
+            ).lower()
+            == "true",
+            # Mental models settings
+            enable_mental_models=os.getenv(ENV_ENABLE_MENTAL_MODELS, str(DEFAULT_ENABLE_MENTAL_MODELS)).lower()
+            == "true",
+            consolidation_similarity_threshold=float(
+                os.getenv(ENV_CONSOLIDATION_SIMILARITY_THRESHOLD, str(DEFAULT_CONSOLIDATION_SIMILARITY_THRESHOLD))
+            ),
             consolidation_batch_size=int(
                 os.getenv(ENV_CONSOLIDATION_BATCH_SIZE, str(DEFAULT_CONSOLIDATION_BATCH_SIZE))
             ),
-            consolidation_max_tokens=int(
-                os.getenv(ENV_CONSOLIDATION_MAX_TOKENS, str(DEFAULT_CONSOLIDATION_MAX_TOKENS))
-            ),
             # Database migrations
             run_migrations_on_startup=os.getenv(ENV_RUN_MIGRATIONS_ON_STARTUP, "true").lower() == "true",
             # Database connection pool
@@ -623,11 +476,8 @@ class HindsightConfig:
             worker_id=os.getenv(ENV_WORKER_ID) or DEFAULT_WORKER_ID,
             worker_poll_interval_ms=int(os.getenv(ENV_WORKER_POLL_INTERVAL_MS, str(DEFAULT_WORKER_POLL_INTERVAL_MS))),
             worker_max_retries=int(os.getenv(ENV_WORKER_MAX_RETRIES, str(DEFAULT_WORKER_MAX_RETRIES))),
+            worker_batch_size=int(os.getenv(ENV_WORKER_BATCH_SIZE, str(DEFAULT_WORKER_BATCH_SIZE))),
             worker_http_port=int(os.getenv(ENV_WORKER_HTTP_PORT, str(DEFAULT_WORKER_HTTP_PORT))),
-            worker_max_slots=int(os.getenv(ENV_WORKER_MAX_SLOTS, str(DEFAULT_WORKER_MAX_SLOTS))),
-            worker_consolidation_max_slots=int(
-                os.getenv(ENV_WORKER_CONSOLIDATION_MAX_SLOTS, str(DEFAULT_WORKER_CONSOLIDATION_MAX_SLOTS))
-            ),
             # Reflect agent settings
             reflect_max_iterations=int(os.getenv(ENV_REFLECT_MAX_ITERATIONS, str(DEFAULT_REFLECT_MAX_ITERATIONS))),
         )
@@ -685,7 +535,7 @@ class HindsightConfig:
 
     def log_config(self) -> None:
         """Log the current configuration (without sensitive values)."""
-        logger.info(f"Database: {self.database_url} (schema: {self.database_schema})")
+        logger.info(f"Database: {self.database_url}")
         logger.info(f"LLM: provider={self.llm_provider}, model={self.llm_model}")
         if self.retain_llm_provider or self.retain_llm_model:
             retain_provider = self.retain_llm_provider or self.llm_provider

hindsight-api/hindsight_api/daemon.py

@@ -1,10 +1,11 @@
 """
 Daemon mode support for Hindsight API.
 
-Provides idle timeout for running as a background daemon.
+Provides idle timeout and lockfile management for running as a background daemon.
 """
 
 import asyncio
+import fcntl
 import logging
 import os
 import sys
@@ -14,11 +15,10 @@ from pathlib import Path
 logger = logging.getLogger(__name__)
 
 # Default daemon configuration
-DEFAULT_DAEMON_PORT = 8888
+DEFAULT_DAEMON_PORT = 8889
 DEFAULT_IDLE_TIMEOUT = 0  # 0 = no auto-exit (hindsight-embed passes its own timeout)
-
-# Allow override via environment variable for profile-specific logs
-DAEMON_LOG_PATH = Path(os.getenv("HINDSIGHT_API_DAEMON_LOG", str(Path.home() / ".hindsight" / "daemon.log")))
+LOCKFILE_PATH = Path.home() / ".hindsight" / "daemon.lock"
+DAEMON_LOG_PATH = Path.home() / ".hindsight" / "daemon.log"
 
 
 class IdleTimeoutMiddleware:
@@ -52,10 +52,82 @@ class IdleTimeoutMiddleware:
                 logger.info(f"Idle timeout reached ({self.idle_timeout}s), shutting down daemon")
                 # Give a moment for any in-flight requests
                 await asyncio.sleep(1)
-                # Send SIGTERM to ourselves to trigger graceful shutdown
-                import signal
+                os._exit(0)
 
-                os.kill(os.getpid(), signal.SIGTERM)
+
+class DaemonLock:
+    """
+    File-based lock to prevent multiple daemon instances.
+
+    Uses fcntl.flock for atomic locking on Unix systems.
+    """
+
+    def __init__(self, lockfile: Path = LOCKFILE_PATH):
+        self.lockfile = lockfile
+        self._fd = None
+
+    def acquire(self) -> bool:
+        """
+        Try to acquire the daemon lock.
+
+        Returns True if lock acquired, False if another daemon is running.
+        """
+        self.lockfile.parent.mkdir(parents=True, exist_ok=True)
+
+        try:
+            self._fd = open(self.lockfile, "w")
+            fcntl.flock(self._fd.fileno(), fcntl.LOCK_EX | fcntl.LOCK_NB)
+            # Write PID for debugging
+            self._fd.write(str(os.getpid()))
+            self._fd.flush()
+            return True
+        except (IOError, OSError):
+            # Lock is held by another process
+            if self._fd:
+                self._fd.close()
+                self._fd = None
+            return False
+
+    def release(self):
+        """Release the daemon lock."""
+        if self._fd:
+            try:
+                fcntl.flock(self._fd.fileno(), fcntl.LOCK_UN)
+                self._fd.close()
+            except Exception:
+                pass
+            finally:
+                self._fd = None
+                # Remove lockfile
+                try:
+                    self.lockfile.unlink()
+                except Exception:
+                    pass
+
+    def is_locked(self) -> bool:
+        """Check if the lock is held by another process."""
+        if not self.lockfile.exists():
+            return False
+
+        try:
+            fd = open(self.lockfile, "r")
+            fcntl.flock(fd.fileno(), fcntl.LOCK_EX | fcntl.LOCK_NB)
+            # We got the lock, so no one else has it
+            fcntl.flock(fd.fileno(), fcntl.LOCK_UN)
+            fd.close()
+            return False
+        except (IOError, OSError):
+            return True
+
+    def get_pid(self) -> int | None:
+        """Get the PID of the daemon holding the lock."""
+        if not self.lockfile.exists():
+            return None
+        try:
+            with open(self.lockfile, "r") as f:
+                return int(f.read().strip())
+        except (ValueError, IOError):
+            return None
 
 
 def daemonize():
@@ -64,21 +136,16 @@ def daemonize():
 
     Uses double-fork technique to properly detach from terminal.
     """
-    # First fork - detach from parent
-    try:
-        pid = os.fork()
-        if pid > 0:
-            sys.exit(0)
-    except OSError as e:
-        sys.stderr.write(f"fork #1 failed: {e}\n")
-        sys.exit(1)
+    # First fork
+    pid = os.fork()
+    if pid > 0:
+        # Parent exits
+        sys.exit(0)
 
-    # Decouple from parent environment
-    os.chdir("/")
+    # Create new session
     os.setsid()
-    os.umask(0)
 
-    # Second fork - prevent zombie
+    # Second fork to prevent zombie processes
     pid = os.fork()
     if pid > 0:
         sys.exit(0)
@@ -111,3 +178,27 @@ def check_daemon_running(port: int = DEFAULT_DAEMON_PORT) -> bool:
         return result == 0
     except Exception:
         return False
+
+
+def stop_daemon(port: int = DEFAULT_DAEMON_PORT) -> bool:
+    """Stop a running daemon by sending SIGTERM to the process."""
+    lock = DaemonLock()
+    pid = lock.get_pid()
+
+    if pid is None:
+        return False
+
+    try:
+        import signal
+
+        os.kill(pid, signal.SIGTERM)
+        # Wait for process to exit
+        for _ in range(50):  # Wait up to 5 seconds
+            time.sleep(0.1)
+            try:
+                os.kill(pid, 0)  # Check if process exists
+            except OSError:
+                return True  # Process exited
+        return False
+    except OSError:
+        return False

hindsight-api/hindsight_api/engine/consolidation/consolidator.py

@@ -1,13 +1,13 @@
-"""Consolidation engine for automatic observation creation from memories.
+"""Consolidation engine for automatic mental model creation from memories.
 
 The consolidation engine runs as a background job after retain operations complete.
 It processes new memories and either:
-- Creates new observations from novel facts
-- Updates existing observations when new evidence supports/contradicts/refines them
+- Creates new mental models from novel facts
+- Updates existing mental models when new evidence supports/contradicts/refines them
 
-Observations are stored in memory_units with fact_type='observation' and include:
+Mental models are stored in memory_units with fact_type='mental_model' and include:
 - proof_count: Number of supporting memories
-- source_memory_ids: Array of memory UUIDs that contribute to this observation
+- source_memory_ids: Array of memory UUIDs that contribute to this mental model
 - history: JSONB tracking changes over time
 """
 
@@ -89,7 +89,7 @@ async def run_consolidation_job(
     max_memories_per_batch = config.consolidation_batch_size
 
     # Check if consolidation is enabled
-    if not config.enable_observations:
+    if not config.enable_mental_models:
         logger.debug(f"Consolidation disabled for bank {bank_id}")
         return {"status": "disabled", "bank_id": bank_id}
 
@@ -136,28 +136,24 @@ async def run_consolidation_job(
     # Process each memory with individual commits for crash recovery
     stats = {
         "memories_processed": 0,
-        "observations_created": 0,
-        "observations_updated": 0,
-        "observations_merged": 0,
+        "mental_models_created": 0,
+        "mental_models_updated": 0,
+        "mental_models_merged": 0,
         "actions_executed": 0,
         "skipped": 0,
     }
 
     batch_num = 0
-    last_progress_timings = {}  # Track timings at last progress log
     while True:
         batch_num += 1
         batch_start = time.time()
 
-        # Snapshot timings at batch start for per-batch calculation
-        batch_start_timings = perf.timings.copy()
-
         # Fetch next batch of unconsolidated memories
         async with pool.acquire() as conn:
             t0 = time.time()
             memories = await conn.fetch(
                 f"""
-                SELECT id, text, fact_type, occurred_start, occurred_end, event_date, tags, mentioned_at
+                SELECT id, text, fact_type, occurred_start, event_date, tags, mentioned_at
                 FROM {fq_table("memory_units")}
                 WHERE bank_id = $1
                   AND consolidated_at IS NULL
@@ -205,67 +201,42 @@ async def run_consolidation_job(
 
             action = result.get("action")
             if action == "created":
-                stats["observations_created"] += 1
+                stats["mental_models_created"] += 1
                 stats["actions_executed"] += 1
             elif action == "updated":
-                stats["observations_updated"] += 1
+                stats["mental_models_updated"] += 1
                 stats["actions_executed"] += 1
             elif action == "merged":
-                stats["observations_merged"] += 1
+                stats["mental_models_merged"] += 1
                 stats["actions_executed"] += 1
             elif action == "multiple":
-                stats["observations_created"] += result.get("created", 0)
-                stats["observations_updated"] += result.get("updated", 0)
-                stats["observations_merged"] += result.get("merged", 0)
+                stats["mental_models_created"] += result.get("created", 0)
+                stats["mental_models_updated"] += result.get("updated", 0)
+                stats["mental_models_merged"] += result.get("merged", 0)
                 stats["actions_executed"] += result.get("total_actions", 0)
             elif action == "skipped":
                 stats["skipped"] += 1
 
-            # Log progress periodically with timing breakdown
+            # Log progress periodically
             if stats["memories_processed"] % 10 == 0:
-                # Calculate timing deltas since last progress log
-                timing_parts = []
-                for key in ["recall", "llm", "embedding", "db_write"]:
-                    if key in perf.timings:
-                        delta = perf.timings[key] - last_progress_timings.get(key, 0)
-                        timing_parts.append(f"{key}={delta:.2f}s")
-
-                timing_str = f" | {', '.join(timing_parts)}" if timing_parts else ""
                 logger.info(
                     f"[CONSOLIDATION] bank={bank_id} progress: "
-                    f"{stats['memories_processed']}/{total_count} memories processed{timing_str}"
+                    f"{stats['memories_processed']}/{total_count} memories processed"
                 )
 
-                # Update last progress snapshot
-                last_progress_timings = perf.timings.copy()
-
         batch_time = time.time() - batch_start
         perf.log(
             f"[2] Batch {batch_num}: {len(memories)} memories in {batch_time:.3f}s "
             f"(avg {batch_time / len(memories):.3f}s/memory)"
         )
 
-        # Log timing breakdown after each batch (delta from batch start)
-        timing_parts = []
-        for key in ["recall", "llm", "embedding", "db_write"]:
-            if key in perf.timings:
-                delta = perf.timings[key] - batch_start_timings.get(key, 0)
-                timing_parts.append(f"{key}={delta:.3f}s")
-
-        if timing_parts:
-            avg_per_memory = batch_time / len(memories) if memories else 0
-            logger.info(
-                f"[CONSOLIDATION] bank={bank_id} batch {batch_num}/{len(memories)} memories: "
-                f"{', '.join(timing_parts)} | avg={avg_per_memory:.3f}s/memory"
-            )
-
     # Build summary
     perf.log(
         f"[3] Results: {stats['memories_processed']} memories -> "
         f"{stats['actions_executed']} actions "
-        f"({stats['observations_created']} created, "
-        f"{stats['observations_updated']} updated, "
-        f"{stats['observations_merged']} merged, "
+        f"({stats['mental_models_created']} created, "
+        f"{stats['mental_models_updated']} updated, "
+        f"{stats['mental_models_merged']} merged, "
         f"{stats['skipped']} skipped)"
     )
 
@@ -283,79 +254,11 @@ async def run_consolidation_job(
     if timing_parts:
         perf.log(f"[4] Timing breakdown: {', '.join(timing_parts)}")
 
-    # Trigger mental model refreshes for models with refresh_after_consolidation=true
-    mental_models_refreshed = await _trigger_mental_model_refreshes(
-        memory_engine=memory_engine,
-        bank_id=bank_id,
-        request_context=request_context,
-        perf=perf,
-    )
-    stats["mental_models_refreshed"] = mental_models_refreshed
-
     perf.flush()
 
     return {"status": "completed", "bank_id": bank_id, **stats}
 
 
-async def _trigger_mental_model_refreshes(
-    memory_engine: "MemoryEngine",
-    bank_id: str,
-    request_context: "RequestContext",
-    perf: ConsolidationPerfLog | None = None,
-) -> int:
-    """
-    Trigger refreshes for mental models with refresh_after_consolidation=true.
-
-    Args:
-        memory_engine: MemoryEngine instance
-        bank_id: Bank identifier
-        request_context: Request context for authentication
-        perf: Performance logging
-
-    Returns:
-        Number of mental models scheduled for refresh
-    """
-    pool = memory_engine._pool
-
-    # Find mental models with refresh_after_consolidation=true
-    async with pool.acquire() as conn:
-        rows = await conn.fetch(
-            f"""
-            SELECT id, name
-            FROM {fq_table("mental_models")}
-            WHERE bank_id = $1
-              AND (trigger->>'refresh_after_consolidation')::boolean = true
-            """,
-            bank_id,
-        )
-
-    if not rows:
-        return 0
-
-    if perf:
-        perf.log(f"[5] Triggering refresh for {len(rows)} mental models with refresh_after_consolidation=true")
-
-    # Submit refresh tasks for each mental model
-    refreshed_count = 0
-    for row in rows:
-        mental_model_id = row["id"]
-        try:
-            await memory_engine.submit_async_refresh_mental_model(
-                bank_id=bank_id,
-                mental_model_id=mental_model_id,
-                request_context=request_context,
-            )
-            refreshed_count += 1
-            logger.info(
-                f"[CONSOLIDATION] Triggered refresh for mental model {mental_model_id} "
-                f"(name: {row['name']}) in bank {bank_id}"
-            )
-        except Exception as e:
-            logger.warning(f"[CONSOLIDATION] Failed to trigger refresh for mental model {mental_model_id}: {e}")
-
-    return refreshed_count
-
-
 async def _process_memory(
     conn: "Connection",
     memory_engine: "MemoryEngine",
@@ -369,13 +272,13 @@ async def _process_memory(
     Process a single memory for consolidation using a SINGLE LLM call.
 
     This function:
-    1. Finds related observations (can be empty)
+    1. Finds related mental models (can be empty)
     2. Uses ONE LLM call to extract durable knowledge AND decide on actions
     3. Executes array of actions (can be multiple creates/updates)
 
     The LLM handles all cases:
-    - No related observations: returns create action(s) with extracted durable knowledge
-    - Related observations exist: returns update/create actions based on tag routing
+    - No related models: returns create action(s) with extracted durable knowledge
+    - Related models exist: returns update/create actions based on tag routing
     - Purely ephemeral fact: returns empty array (skip)
 
     Returns:
@@ -385,9 +288,9 @@ async def _process_memory(
     memory_id = memory["id"]
     fact_tags = memory.get("tags") or []
 
-    # Find related observations using the full recall system (NO tag filtering)
+    # Find related mental models using the full recall system (NO tag filtering)
     t0 = time.time()
-    related_observations = await _find_related_observations(
+    related_mental_models = await _find_related_mental_models(
         conn=conn,
         memory_engine=memory_engine,
         bank_id=bank_id,
@@ -397,13 +300,13 @@ async def _process_memory(
     if perf:
         perf.record_timing("recall", time.time() - t0)
 
-    # Single LLM call handles ALL cases (with or without existing observations)
-    # Note: Tags are NOT passed to LLM - they are handled algorithmically
+    # Single LLM call handles ALL cases (with or without existing models)
     t0 = time.time()
     actions = await _consolidate_with_llm(
         memory_engine=memory_engine,
         fact_text=fact_text,
-        observations=related_observations,  # Can be empty list
+        fact_tags=fact_tags,
+        mental_models=related_mental_models,  # Can be empty list
         mission=mission,
     )
     if perf:
@@ -424,10 +327,7 @@ async def _process_memory(
                 bank_id=bank_id,
                 memory_id=memory_id,
                 action=action,
-                observations=related_observations,
-                source_fact_tags=fact_tags,  # Pass source fact's tags for security
-                source_occurred_start=memory.get("occurred_start"),
-                source_occurred_end=memory.get("occurred_end"),
+                mental_models=related_mental_models,
                 source_mentioned_at=memory.get("mentioned_at"),
                 perf=perf,
             )
@@ -439,10 +339,8 @@ async def _process_memory(
                 bank_id=bank_id,
                 memory_id=memory_id,
                 action=action,
-                source_fact_tags=fact_tags,  # Pass source fact's tags for security
                 event_date=memory.get("event_date"),
                 occurred_start=memory.get("occurred_start"),
-                occurred_end=memory.get("occurred_end"),
                 mentioned_at=memory.get("mentioned_at"),
                 perf=perf,
             )
@@ -475,26 +373,15 @@ async def _execute_update_action(
     bank_id: str,
     memory_id: uuid.UUID,
     action: dict[str, Any],
-    observations: list[dict[str, Any]],
-    source_fact_tags: list[str] | None = None,
-    source_occurred_start: datetime | None = None,
-    source_occurred_end: datetime | None = None,
+    mental_models: list[dict[str, Any]],
     source_mentioned_at: datetime | None = None,
     perf: ConsolidationPerfLog | None = None,
 ) -> dict[str, Any]:
     """
-    Execute an update action on an existing observation.
+    Execute an update action on an existing mental model.
 
-    Updates the observation text, adds to history, increments proof_count,
-    and updates temporal fields:
-    - occurred_start: uses LEAST to keep the earliest start time
-    - occurred_end: uses GREATEST to keep the most recent end time
-    - mentioned_at: uses GREATEST to keep the most recent mention time
-
-    SECURITY: Merges source fact's tags into the observation's existing tags.
-    This ensures all contributors can see the observation they contributed to.
-    For example, if Lisa's observation (tags=['user_lisa']) is updated with
-    Mike's fact (tags=['user_mike']), the observation will have both tags.
+    Updates the mental model text, adds to history, increments proof_count,
+    and updates mentioned_at if the new source memory has a more recent date.
     """
     learning_id = action.get("learning_id")
     new_text = action.get("text")
@@ -503,8 +390,8 @@ async def _execute_update_action(
     if not learning_id or not new_text:
         return {"action": "skipped", "reason": "missing_learning_id_or_text"}
 
-    # Find the observation
-    model = next((m for m in observations if str(m["id"]) == learning_id), None)
+    # Find the mental model
+    model = next((m for m in mental_models if str(m["id"]) == learning_id), None)
     if not model:
         return {"action": "skipped", "reason": "learning_not_found"}
 
@@ -523,17 +410,6 @@ async def _execute_update_action(
     source_ids = list(model.get("source_memory_ids", []))
     source_ids.append(memory_id)
 
-    # SECURITY: Merge source fact's tags into existing observation tags
-    # This ensures all contributors can see the observation they contributed to
-    existing_tags = set(model.get("tags", []) or [])
-    source_tags = set(source_fact_tags or [])
-    merged_tags = list(existing_tags | source_tags)  # Union of both tag sets
-    if source_tags and source_tags != existing_tags:
-        logger.debug(
-            f"Security: Merging tags for observation {learning_id}: "
-            f"existing={list(existing_tags)}, source={list(source_tags)}, merged={merged_tags}"
-        )
-
     # Generate new embedding for updated text
     t0 = time.time()
     embeddings = await embedding_utils.generate_embeddings_batch(memory_engine.embeddings, [new_text])
@@ -541,11 +417,8 @@ async def _execute_update_action(
     if perf:
         perf.record_timing("embedding", time.time() - t0)
 
-    # Update the observation
-    # - occurred_start: LEAST keeps the earliest start time across all source facts
-    # - occurred_end: GREATEST keeps the most recent end time across all source facts
-    # - mentioned_at: GREATEST keeps the most recent mention time
-    # - tags: merged from existing + source fact (for visibility)
+    # Update the mental model
+    # Update mentioned_at if source memory has a more recent date
     t0 = time.time()
     await conn.execute(
         f"""
@@ -555,11 +428,8 @@ async def _execute_update_action(
             history = $3,
             source_memory_ids = $4,
             proof_count = $5,
-            tags = $10,
             updated_at = now(),
-            occurred_start = LEAST(occurred_start, COALESCE($7, occurred_start)),
-            occurred_end = GREATEST(occurred_end, COALESCE($8, occurred_end)),
-            mentioned_at = GREATEST(mentioned_at, COALESCE($9, mentioned_at))
+            mentioned_at = GREATEST(mentioned_at, COALESCE($7, mentioned_at))
         WHERE id = $6
         """,
         new_text,
@@ -568,20 +438,17 @@ async def _execute_update_action(
         source_ids,
         len(source_ids),
         uuid.UUID(learning_id),
-        source_occurred_start,
-        source_occurred_end,
         source_mentioned_at,
-        merged_tags,
     )
 
-    # Create links from memory to observation
+    # Create links from memory to mental model
     await _create_memory_links(conn, memory_id, uuid.UUID(learning_id))
     if perf:
         perf.record_timing("db_write", time.time() - t0)
 
-    logger.debug(f"Updated observation {learning_id} with memory {memory_id}")
+    logger.debug(f"Updated mental model {learning_id} with memory {memory_id}")
 
-    return {"action": "updated", "observation_id": learning_id}
+    return {"action": "updated", "mental_model_id": learning_id}
 
 
 async def _execute_create_action(
@@ -590,48 +457,38 @@ async def _execute_create_action(
     bank_id: str,
     memory_id: uuid.UUID,
     action: dict[str, Any],
-    source_fact_tags: list[str] | None = None,
     event_date: datetime | None = None,
     occurred_start: datetime | None = None,
-    occurred_end: datetime | None = None,
     mentioned_at: datetime | None = None,
     perf: ConsolidationPerfLog | None = None,
 ) -> dict[str, Any]:
     """
-    Execute a create action for a new observation.
+    Execute a create action for a new mental model.
 
-    Creates a new observation with the specified text.
+    Creates a new mental model with the specified text and tags.
     The text comes directly from the classify LLM - no second LLM call needed.
-
-    Tags are determined algorithmically (not by LLM):
-    - Observations always inherit their source fact's tags
-    - This ensures visibility scope is maintained (security)
     """
     text = action.get("text")
-
-    # Tags are determined algorithmically - always use source fact's tags
-    # This ensures private memories create private observations
-    tags = source_fact_tags or []
+    tags = action.get("tags", [])
 
     if not text:
         return {"action": "skipped", "reason": "missing_text"}
 
     # Use text directly from classify - skip the redundant LLM call
-    result = await _create_observation_directly(
+    result = await _create_mental_model_directly(
         conn=conn,
         memory_engine=memory_engine,
         bank_id=bank_id,
         source_memory_id=memory_id,
-        observation_text=text,  # Text already processed by classify LLM
+        mental_model_text=text,  # Text already processed by classify LLM
         tags=tags,
         event_date=event_date,
         occurred_start=occurred_start,
-        occurred_end=occurred_end,
         mentioned_at=mentioned_at,
         perf=perf,
     )
 
-    logger.debug(f"Created observation {result.get('observation_id')} from memory {memory_id} (tags: {tags})")
+    logger.debug(f"Created mental model {result.get('mental_model_id')} from memory {memory_id} (tags: {tags})")
 
     return result
 
@@ -639,28 +496,98 @@ async def _execute_create_action(
 async def _create_memory_links(
     conn: "Connection",
     memory_id: uuid.UUID,
-    observation_id: uuid.UUID,
+    mental_model_id: uuid.UUID,
 ) -> None:
     """
-    Placeholder for observation link creation.
+    Create links between a source memory and its mental model.
 
-    Observations do NOT get any memory_links copied from their source facts.
-    Instead, retrieval uses source_memory_ids to traverse:
-    - Entity connections: observation → source_memory_ids → unit_entities
-    - Semantic similarity: observations have their own embeddings
-    - Temporal proximity: observations have their own temporal fields
+    This:
+    1. Creates bidirectional semantic links between memory and mental model
+    2. Copies existing memory_links from the source memory to the mental model
+    3. Copies entity links from the source memory to the mental model
 
-    This avoids data duplication and ensures observations are always
-    connected via their source facts' relationships.
+    This enables graph traversal to find related memories via their mental models.
 
-    The memory_id and observation_id parameters are kept for interface
-    compatibility but no links are created.
+    Note: Uses EXISTS checks to handle the case where source memory was deleted
+    by a concurrent operation between fetching and link creation.
     """
-    # No links are created - observations rely on source_memory_ids for traversal
-    pass
+    mu_table = fq_table("memory_units")
+    ml_table = fq_table("memory_links")
+    ue_table = fq_table("unit_entities")
+
+    # 1. Bidirectional link between memory and mental model
+    # Only insert if both units exist (handles concurrent deletion)
+    await conn.execute(
+        f"""
+        INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, weight)
+        SELECT $1, $2, 'semantic', 1.0
+        WHERE EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $2)
+        ON CONFLICT DO NOTHING
+        """,
+        memory_id,
+        mental_model_id,
+    )
+    await conn.execute(
+        f"""
+        INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, weight)
+        SELECT $1, $2, 'semantic', 1.0
+        WHERE EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $2)
+        ON CONFLICT DO NOTHING
+        """,
+        mental_model_id,
+        memory_id,
+    )
+
+    # 2. Copy outgoing memory_links from source memory to mental model
+    # If source memory links to X, mental model should also link to X
+    await conn.execute(
+        f"""
+        INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, entity_id, weight)
+        SELECT $1, ml.to_unit_id, ml.link_type, ml.entity_id, ml.weight
+        FROM {ml_table} ml
+        WHERE ml.from_unit_id = $2 AND ml.to_unit_id != $1
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = ml.to_unit_id)
+        ON CONFLICT DO NOTHING
+        """,
+        mental_model_id,
+        memory_id,
+    )
+
+    # 3. Copy incoming memory_links from source memory to mental model
+    # If X links to source memory, X should also link to mental model
+    await conn.execute(
+        f"""
+        INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, entity_id, weight)
+        SELECT ml.from_unit_id, $1, ml.link_type, ml.entity_id, ml.weight
+        FROM {ml_table} ml
+        WHERE ml.to_unit_id = $2 AND ml.from_unit_id != $1
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = ml.from_unit_id)
+        ON CONFLICT DO NOTHING
+        """,
+        mental_model_id,
+        memory_id,
+    )
+
+    # 4. Copy entity links from source memory to mental model
+    await conn.execute(
+        f"""
+        INSERT INTO {ue_table} (unit_id, entity_id)
+        SELECT $1, ue.entity_id
+        FROM {ue_table} ue
+        WHERE ue.unit_id = $2
+          AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
+        ON CONFLICT DO NOTHING
+        """,
+        mental_model_id,
+        memory_id,
+    )
 
 
-async def _find_related_observations(
+async def _find_related_mental_models(
     conn: "Connection",
     memory_engine: "MemoryEngine",
     bank_id: str,
@@ -668,174 +595,104 @@ async def _find_related_observations(
     request_context: "RequestContext",
 ) -> list[dict[str, Any]]:
     """
-    Find observations related to the given query using optimized recall.
+    Find mental models related to the given query using the full recall system.
 
     IMPORTANT: We do NOT filter by tags here. Consolidation needs to see ALL
-    potentially related observations regardless of scope, so the LLM can
+    potentially related mental models regardless of scope, so the LLM can
     decide on tag routing (same scope update vs cross-scope create).
 
-    Uses max_tokens to naturally limit observations (no artificial count limit).
-    Includes source memories with dates for LLM context.
+    This leverages:
+    - Semantic search (embedding similarity)
+    - BM25 text search (keyword matching)
+    - Entity-based retrieval (shared entities)
+    - Graph traversal (connected via entity links)
 
     Returns:
-        List of related observations with their tags, source memories, and dates
+        List of related mental models with their tags for LLM tag routing
     """
-    # Use recall to find related observations with token budget
-    # max_tokens naturally limits how many observations are returned
-    from ...config import get_config
-
-    config = get_config()
+    # Use recall to find related mental models
+    # NO tags parameter - we want ALL mental models regardless of scope
+    # Use low max_tokens since we only need mental models, not memories
     recall_result = await memory_engine.recall_async(
         bank_id=bank_id,
         query=query,
-        max_tokens=config.consolidation_max_tokens,  # Token budget for observations (configurable)
-        fact_type=["observation"],  # Only retrieve observations
+        max_tokens=5000,  # Token budget for mental models
+        fact_type=["mental_model"],  # Only retrieve mental models
         request_context=request_context,
         _quiet=True,  # Suppress logging
-        # NO tags parameter - intentionally get ALL observations
+        # NO tags parameter - intentionally get ALL mental models
     )
 
-    # If no observations returned, return empty list
+    # If no mental models returned, return empty list
+    # When fact_type=["mental_model"], results come back in `results` field
     if not recall_result.results:
         return []
 
-    # Batch fetch all observations in a single query (no artificial limit)
-    observation_ids = [uuid.UUID(obs.id) for obs in recall_result.results]
-
-    rows = await conn.fetch(
-        f"""
-        SELECT id, text, proof_count, history, tags, source_memory_ids, created_at, updated_at,
-               occurred_start, occurred_end, mentioned_at
-        FROM {fq_table("memory_units")}
-        WHERE id = ANY($1) AND bank_id = $2 AND fact_type = 'observation'
-        """,
-        observation_ids,
-        bank_id,
-    )
-
-    # Build results list preserving recall order
-    id_to_row = {row["id"]: row for row in rows}
+    # Trust recall's relevance filtering - fetch full data for each mental model
     results = []
-
-    for obs in recall_result.results:
-        obs_id = uuid.UUID(obs.id)
-        if obs_id not in id_to_row:
-            continue
-
-        row = id_to_row[obs_id]
-        history = row["history"]
-        if isinstance(history, str):
-            history = json.loads(history)
-        elif history is None:
-            history = []
-
-        # Fetch source memories to include their text and dates
-        source_memory_ids = row["source_memory_ids"] or []
-        source_memories = []
-
-        if source_memory_ids:
-            source_rows = await conn.fetch(
-                f"""
-                SELECT text, occurred_start, occurred_end, mentioned_at, event_date
-                FROM {fq_table("memory_units")}
-                WHERE id = ANY($1) AND bank_id = $2
-                ORDER BY created_at ASC
-                LIMIT 5
-                """,
-                source_memory_ids[:5],  # Limit to first 5 source memories for token efficiency
-                bank_id,
-            )
-
-            for src_row in source_rows:
-                source_memories.append(
-                    {
-                        "text": src_row["text"],
-                        "occurred_start": src_row["occurred_start"],
-                        "occurred_end": src_row["occurred_end"],
-                        "mentioned_at": src_row["mentioned_at"],
-                        "event_date": src_row["event_date"],
-                    }
-                )
-
-        results.append(
-            {
-                "id": row["id"],
-                "text": row["text"],
-                "proof_count": row["proof_count"] or 1,
-                "tags": row["tags"] or [],
-                "source_memories": source_memories,
-                "occurred_start": row["occurred_start"],
-                "occurred_end": row["occurred_end"],
-                "mentioned_at": row["mentioned_at"],
-                "created_at": row["created_at"],
-                "updated_at": row["updated_at"],
-            }
+    for mm in recall_result.results:
+        # Fetch full mental model data from DB to get history, source_memory_ids, tags
+        row = await conn.fetchrow(
+            f"""
+            SELECT id, text, proof_count, history, tags, source_memory_ids, created_at, updated_at
+            FROM {fq_table("memory_units")}
+            WHERE id = $1 AND bank_id = $2 AND fact_type = 'mental_model'
+            """,
+            uuid.UUID(mm.id),
+            bank_id,
         )
 
+        if row:
+            history = row["history"]
+            if isinstance(history, str):
+                history = json.loads(history)
+            elif history is None:
+                history = []
+
+            results.append(
+                {
+                    "id": row["id"],
+                    "text": row["text"],
+                    "proof_count": row["proof_count"] or 1,
+                    "history": history,
+                    "tags": row["tags"] or [],  # Include tags for LLM tag routing
+                    "source_memory_ids": row["source_memory_ids"] or [],
+                    "similarity": 1.0,  # Retrieved via recall so assumed relevant
+                }
+            )
+
     return results
 
 
 async def _consolidate_with_llm(
     memory_engine: "MemoryEngine",
     fact_text: str,
-    observations: list[dict[str, Any]],
+    fact_tags: list[str],
+    mental_models: list[dict[str, Any]],
     mission: str,
 ) -> list[dict[str, Any]]:
     """
     Single LLM call to extract durable knowledge and decide on consolidation actions.
 
     This handles ALL cases:
-    - No related observations: extracts durable knowledge, returns create action
-    - Related observations exist: compares and returns update/create actions
+    - No related mental models: extracts durable knowledge, returns create action
+    - Related models exist: compares and returns update/create actions
     - Purely ephemeral fact: returns empty array
 
-    Note: Tags are NOT handled by the LLM. They are determined algorithmically:
-    - CREATE: observation inherits source fact's tags
-    - UPDATE: observation merges source fact's tags with existing tags
-
     Returns:
         List of actions, each being:
         - {"action": "update", "learning_id": "uuid", "text": "...", "reason": "..."}
-        - {"action": "create", "text": "...", "reason": "..."}
+        - {"action": "create", "tags": [...], "text": "...", "reason": "..."}
         - [] if fact is purely ephemeral (no durable knowledge)
     """
-    # Format observations as JSON with source memories and dates
-    if observations:
-        obs_list = []
-        for obs in observations:
-            obs_data = {
-                "id": str(obs["id"]),
-                "text": obs["text"],
-                "proof_count": obs["proof_count"],
-                "tags": obs["tags"],
-                "created_at": obs["created_at"].isoformat() if obs.get("created_at") else None,
-                "updated_at": obs["updated_at"].isoformat() if obs.get("updated_at") else None,
-            }
-
-            # Include temporal info if available
-            if obs.get("occurred_start"):
-                obs_data["occurred_start"] = obs["occurred_start"].isoformat()
-            if obs.get("occurred_end"):
-                obs_data["occurred_end"] = obs["occurred_end"].isoformat()
-            if obs.get("mentioned_at"):
-                obs_data["mentioned_at"] = obs["mentioned_at"].isoformat()
-
-            # Include source memories (up to 3 for brevity)
-            if obs.get("source_memories"):
-                obs_data["source_memories"] = [
-                    {
-                        "text": sm["text"],
-                        "event_date": sm["event_date"].isoformat() if sm.get("event_date") else None,
-                        "occurred_start": sm["occurred_start"].isoformat() if sm.get("occurred_start") else None,
-                    }
-                    for sm in obs["source_memories"][:3]  # Limit to 3 for token efficiency
-                ]
-
-            obs_list.append(obs_data)
-
-        observations_text = json.dumps(obs_list, indent=2)
+    # Format mental models WITH their tags (or "None" if empty)
+    if mental_models:
+        mental_models_text = "\n".join(
+            f'- ID: {mm["id"]}, Tags: {json.dumps(mm["tags"])}, Text: "{mm["text"]}" (proof_count: {mm["proof_count"]})'
+            for mm in mental_models
+        )
     else:
-        observations_text = "[]"
+        mental_models_text = "None (this is a new topic - create if fact contains durable knowledge)"
 
     # Only include mission section if mission is set and not the default
     mission_section = ""
@@ -849,7 +706,8 @@ Focus on DURABLE knowledge that serves this mission, not ephemeral state.
     user_prompt = CONSOLIDATION_USER_PROMPT.format(
         mission_section=mission_section,
         fact_text=fact_text,
-        observations_text=observations_text,
+        fact_tags=json.dumps(fact_tags),
+        mental_models_text=mental_models_text,
     )
 
     messages = [
@@ -865,14 +723,7 @@ Focus on DURABLE knowledge that serves this mission, not ephemeral state.
         )
         # Parse JSON response - should be an array
         if isinstance(result, str):
-            # Strip markdown code fences (some models wrap JSON in ```json ... ```)
-            clean = result.strip()
-            if clean.startswith("```"):
-                clean = clean.split("\n", 1)[1] if "\n" in clean else clean[3:]
-                if clean.endswith("```"):
-                    clean = clean[:-3]
-                clean = clean.strip()
-            result = json.loads(clean)
+            result = json.loads(result)
         # Ensure result is a list
         if isinstance(result, list):
             return result
@@ -895,68 +746,65 @@ Focus on DURABLE knowledge that serves this mission, not ephemeral state.
         return []
 
 
-async def _create_observation_directly(
+async def _create_mental_model_directly(
     conn: "Connection",
     memory_engine: "MemoryEngine",
     bank_id: str,
     source_memory_id: uuid.UUID,
-    observation_text: str,
+    mental_model_text: str,
     tags: list[str] | None = None,
     event_date: datetime | None = None,
     occurred_start: datetime | None = None,
-    occurred_end: datetime | None = None,
     mentioned_at: datetime | None = None,
     perf: ConsolidationPerfLog | None = None,
 ) -> dict[str, Any]:
     """
-    Create an observation directly with pre-processed text (no LLM call).
+    Create a mental model directly with pre-processed text (no LLM call).
 
     Used when the classify LLM has already provided the learning text.
     This avoids the redundant second LLM call.
     """
-    # Generate embedding for the observation (convert to string for pgvector)
+    # Generate embedding for the mental model (convert to string for pgvector)
     t0 = time.time()
-    embeddings = await embedding_utils.generate_embeddings_batch(memory_engine.embeddings, [observation_text])
+    embeddings = await embedding_utils.generate_embeddings_batch(memory_engine.embeddings, [mental_model_text])
     embedding_str = str(embeddings[0]) if embeddings else None
     if perf:
         perf.record_timing("embedding", time.time() - t0)
 
-    # Create the observation as a memory_unit
+    # Create the mental model as a memory_unit
     now = datetime.now(timezone.utc)
-    obs_event_date = event_date or now
-    obs_occurred_start = occurred_start or now
-    obs_occurred_end = occurred_end or now
-    obs_mentioned_at = mentioned_at or now
-    obs_tags = tags or []
+    mm_event_date = event_date or now
+    mm_occurred_start = occurred_start or now
+    mm_mentioned_at = mentioned_at or now
+    mm_tags = tags or []
 
     t0 = time.time()
-    observation_id = uuid.uuid4()
+    mental_model_id = uuid.uuid4()
     row = await conn.fetchrow(
         f"""
         INSERT INTO {fq_table("memory_units")} (
             id, bank_id, text, fact_type, embedding, proof_count, source_memory_ids, history,
-            tags, event_date, occurred_start, occurred_end, mentioned_at
+            tags, event_date, occurred_start, mentioned_at
         )
-        VALUES ($1, $2, $3, 'observation', $4::vector, 1, $5, '[]'::jsonb, $6, $7, $8, $9, $10)
+        VALUES ($1, $2, $3, 'mental_model', $4::vector, 1, $5, '[]'::jsonb, $6, $7, $8, $9)
         RETURNING id
         """,
-        observation_id,
+        mental_model_id,
         bank_id,
-        observation_text,
+        mental_model_text,
         embedding_str,
         [source_memory_id],
-        obs_tags,
-        obs_event_date,
-        obs_occurred_start,
-        obs_occurred_end,
-        obs_mentioned_at,
+        mm_tags,
+        mm_event_date,
+        mm_occurred_start,
+        mm_mentioned_at,
     )
 
-    # Create links between memory and observation (includes entity links, memory_links)
-    await _create_memory_links(conn, source_memory_id, observation_id)
+    # Create links between memory and mental model (includes entity links, memory_links)
+    await _create_memory_links(conn, source_memory_id, mental_model_id)
     if perf:
         perf.record_timing("db_write", time.time() - t0)
 
-    logger.debug(f"Created observation {observation_id} from memory {source_memory_id} (tags: {obs_tags})")
+    logger.debug(f"Created mental model {mental_model_id} from memory {source_memory_id} (tags: {mm_tags})")
 
-    return {"action": "created", "observation_id": str(row["id"]), "tags": obs_tags}
+    return {"action": "created", "mental_model_id": str(row["id"]), "tags": mm_tags}

hindsight-api/hindsight_api/engine/consolidation/prompts.py

@@ -1,6 +1,6 @@
 """Prompts for the consolidation engine."""
 
-CONSOLIDATION_SYSTEM_PROMPT = """You are a memory consolidation system. Your job is to convert facts into durable knowledge (observations) and merge with existing knowledge when appropriate.
+CONSOLIDATION_SYSTEM_PROMPT = """You are a memory consolidation system. Your job is to convert facts into durable knowledge (mental models) and merge with existing knowledge when appropriate.
 
 You must output ONLY valid JSON with no markdown formatting, no code blocks, and no additional text.
 
@@ -30,48 +30,62 @@ BAD examples:
 - "John likes pizza" -> "Understanding dietary preferences helps..." (TOO ABSTRACT)
 - "User is at Room 203" -> "User is currently at Room 203" (EPHEMERAL STATE)
 
-## MERGE RULES (when comparing to existing observations):
+## MERGE RULES (when comparing to existing mental models):
 1. REDUNDANT: Same information worded differently → update existing
 2. CONTRADICTION: Opposite information about same topic → update with history (e.g., "used to X, now Y")
 3. UPDATE: New state replacing old state → update with history
 
+## TAG ROUTING RULES:
+Tags define visibility scopes. The fact and each mental model have tags (can be empty = global).
+
+| Fact Tags | Model Tags | Action |
+|-----------|------------|--------|
+| [alice] | [alice] | UPDATE the model (same scope) |
+| [alice] | [] | UPDATE the model (global absorbs all scopes) |
+| [alice] | [bob] | CREATE new untagged model (cross-scope insight) |
+| [] | [alice] | UPDATE the model (untagged facts can update any scope) |
+| [] | [] | UPDATE the model (global to global) |
+
+When NO existing model matches the fact's topic: CREATE new model with fact's tags.
+
+## MULTIPLE ACTIONS:
+One fact can trigger MULTIPLE actions. For example:
+- Update a scoped model [alice] about pizza preferences
+- AND update a global model [] about pizza in general
+
+Output an ARRAY of actions (can be empty, one, or many).
+
 ## CRITICAL RULES:
 - NEVER merge facts about DIFFERENT people
 - NEVER merge unrelated topics (food preferences vs work vs hobbies)
 - When merging contradictions, capture the CHANGE (before → after)
-- Keep observations focused on ONE specific topic per person
-- The "text" field MUST contain durable knowledge, not ephemeral state
-- Do NOT include "tags" in output - tags are handled automatically"""
+- Keep mental models focused on ONE specific topic per person
+- Cross-scope insights (alice's fact about bob's topic) become UNTAGGED (global)
+- The "text" field MUST contain durable knowledge, not ephemeral state"""
 
 CONSOLIDATION_USER_PROMPT = """Analyze this new fact and consolidate into knowledge.
 {mission_section}
 NEW FACT: {fact_text}
+FACT TAGS: {fact_tags}
 
-EXISTING OBSERVATIONS (JSON array with source memories and dates):
-{observations_text}
-
-Each observation includes:
-- id: unique identifier for updating
-- text: the observation content
-- proof_count: number of supporting memories
-- tags: visibility scope (handled automatically)
-- created_at/updated_at: when observation was created/modified
-- occurred_start/occurred_end: temporal range of source facts
-- source_memories: array of supporting facts with their text and dates
+EXISTING MENTAL MODELS:
+{mental_models_text}
 
 Instructions:
-1. Extract DURABLE KNOWLEDGE from the new fact (not ephemeral state)
-2. Review source_memories in existing observations to understand evidence
-3. Check dates to detect contradictions or updates
-4. Compare with observations:
-   - Same topic → UPDATE with learning_id
-   - New topic → CREATE new observation
-   - Purely ephemeral → return []
+1. First, extract the DURABLE KNOWLEDGE from the fact (not ephemeral state like "user is at X")
+2. Then compare with existing mental models:
+   - If a model covers the same topic: UPDATE it with the new knowledge
+   - If no model covers the topic: CREATE a new one
+   - If fact is about different scope: apply tag routing rules
 
-Output JSON array of actions:
+Output JSON array of actions (ALWAYS an array, even for single action):
 [
-  {{"action": "update", "learning_id": "uuid-from-observations", "text": "updated knowledge", "reason": "..."}},
-  {{"action": "create", "text": "new durable knowledge", "reason": "..."}}
+  {{"action": "update", "learning_id": "uuid", "text": "updated durable knowledge", "reason": "..."}},
+  {{"action": "create", "tags": ["tag"], "text": "new durable knowledge", "reason": "..."}}
 ]
 
-Return [] if fact contains no durable knowledge."""
+If NO consolidation is needed (fact is purely ephemeral with no durable knowledge):
+[]
+
+If no models exist and fact contains durable knowledge:
+[{{"action": "create", "tags": {fact_tags}, "text": "durable knowledge text", "reason": "new topic"}}]"""

hindsight-api/hindsight_api/engine/cross_encoder.py

@@ -9,7 +9,6 @@ Configuration via environment variables - see hindsight_api.config for all env v
 import asyncio
 import logging
 import os
-import warnings
 from abc import ABC, abstractmethod
 from concurrent.futures import ThreadPoolExecutor
 
@@ -21,7 +20,6 @@ from ..config import (
     DEFAULT_RERANKER_FLASHRANK_CACHE_DIR,
     DEFAULT_RERANKER_FLASHRANK_MODEL,
     DEFAULT_RERANKER_LITELLM_MODEL,
-    DEFAULT_RERANKER_LOCAL_FORCE_CPU,
     DEFAULT_RERANKER_LOCAL_MAX_CONCURRENT,
     DEFAULT_RERANKER_LOCAL_MODEL,
     DEFAULT_RERANKER_PROVIDER,
@@ -35,7 +33,6 @@ from ..config import (
     ENV_RERANKER_FLASHRANK_CACHE_DIR,
     ENV_RERANKER_FLASHRANK_MODEL,
     ENV_RERANKER_LITELLM_MODEL,
-    ENV_RERANKER_LOCAL_FORCE_CPU,
     ENV_RERANKER_LOCAL_MAX_CONCURRENT,
     ENV_RERANKER_LOCAL_MODEL,
     ENV_RERANKER_PROVIDER,
@@ -102,7 +99,7 @@ class LocalSTCrossEncoder(CrossEncoderModel):
     _executor: ThreadPoolExecutor | None = None
     _max_concurrent: int = 4  # Limit concurrent CPU-bound reranking calls
 
-    def __init__(self, model_name: str | None = None, max_concurrent: int = 4, force_cpu: bool = False):
+    def __init__(self, model_name: str | None = None, max_concurrent: int = 4):
         """
         Initialize local SentenceTransformers cross-encoder.
 
@@ -111,11 +108,8 @@ class LocalSTCrossEncoder(CrossEncoderModel):
                        Default: cross-encoder/ms-marco-MiniLM-L-6-v2
             max_concurrent: Maximum concurrent reranking calls (default: 2).
                            Higher values may cause CPU thrashing under load.
-            force_cpu: Force CPU mode (avoids MPS/XPC issues on macOS in daemon mode).
-                      Default: False
         """
         self.model_name = model_name or DEFAULT_RERANKER_LOCAL_MODEL
-        self.force_cpu = force_cpu
         self._model = None
         LocalSTCrossEncoder._max_concurrent = max_concurrent
 
@@ -145,46 +139,19 @@ class LocalSTCrossEncoder(CrossEncoderModel):
         # after loading, which conflicts with accelerate's device_map handling.
         import torch
 
-        # Force CPU mode if configured (used in daemon mode to avoid MPS/XPC issues on macOS)
-        if self.force_cpu:
-            device = "cpu"
-            logger.info("Reranker: forcing CPU mode (HINDSIGHT_API_RERANKER_LOCAL_FORCE_CPU=1)")
+        # Check for GPU (CUDA) or Apple Silicon (MPS)
+        has_gpu = torch.cuda.is_available() or (hasattr(torch.backends, "mps") and torch.backends.mps.is_available())
+
+        if has_gpu:
+            device = None  # Let sentence-transformers auto-detect GPU/MPS
         else:
-            # Check for GPU (CUDA) or Apple Silicon (MPS)
-            # Wrap in try-except to gracefully handle any device detection issues
-            # (e.g., in CI environments or when PyTorch is built without GPU support)
-            device = "cpu"  # Default to CPU
-            try:
-                has_gpu = torch.cuda.is_available() or (
-                    hasattr(torch.backends, "mps") and torch.backends.mps.is_available()
-                )
-                if has_gpu:
-                    device = None  # Let sentence-transformers auto-detect GPU/MPS
-            except Exception as e:
-                logger.warning(f"Failed to detect GPU/MPS, falling back to CPU: {e}")
+            device = "cpu"
 
-        # Suppress verbose transformers warnings during model loading
-        # This suppresses the "UNEXPECTED" warnings from CrossEncoder which are harmless
-        # but look alarming to users (e.g., "embeddings.position_ids | UNEXPECTED")
-        with warnings.catch_warnings():
-            warnings.filterwarnings("ignore", category=UserWarning)
-            warnings.filterwarnings("ignore", message=".*was not found in model state dict.*")
-            warnings.filterwarnings("ignore", message=".*UNEXPECTED.*")
-
-            # Also suppress transformers library logging temporarily
-            transformers_logger = logging.getLogger("transformers")
-            original_level = transformers_logger.level
-            transformers_logger.setLevel(logging.ERROR)
-
-            try:
-                self._model = CrossEncoder(
-                    self.model_name,
-                    device=device,
-                    model_kwargs={"low_cpu_mem_usage": False},
-                )
-            finally:
-                # Restore original logging level
-                transformers_logger.setLevel(original_level)
+        self._model = CrossEncoder(
+            self.model_name,
+            device=device,
+            model_kwargs={"low_cpu_mem_usage": False},
+        )
 
         # Initialize shared executor (limited workers naturally limits concurrency)
         if LocalSTCrossEncoder._executor is None:
@@ -196,11 +163,6 @@ class LocalSTCrossEncoder(CrossEncoderModel):
         else:
             logger.info("Reranker: local provider initialized (using existing executor)")
 
-    def _predict_sync(self, pairs: list[tuple[str, str]]) -> list[float]:
-        """Synchronous prediction wrapper for thread pool execution."""
-        scores = self._model.predict(pairs, show_progress_bar=False)
-        return scores.tolist() if hasattr(scores, "tolist") else list(scores)
-
     async def predict(self, pairs: list[tuple[str, str]]) -> list[float]:
         """
         Score query-document pairs for relevance.
@@ -218,11 +180,11 @@ class LocalSTCrossEncoder(CrossEncoderModel):
 
         # Use dedicated executor - limited workers naturally limits concurrency
         loop = asyncio.get_event_loop()
-        return await loop.run_in_executor(
+        scores = await loop.run_in_executor(
             LocalSTCrossEncoder._executor,
-            self._predict_sync,
-            pairs,
+            lambda: self._model.predict(pairs, show_progress_bar=False),
         )
+        return scores.tolist() if hasattr(scores, "tolist") else list(scores)
 
 
 class RemoteTEICrossEncoder(CrossEncoderModel):
@@ -632,7 +594,7 @@ class FlashRankCrossEncoder(CrossEncoderModel):
             return
 
         try:
-            from flashrank import Ranker
+            from flashrank import Ranker  # type: ignore[import-untyped]
         except ImportError:
             raise ImportError("flashrank is required for FlashRankCrossEncoder. Install it with: pip install flashrank")
 
@@ -659,7 +621,7 @@ class FlashRankCrossEncoder(CrossEncoderModel):
 
     def _predict_sync(self, pairs: list[tuple[str, str]]) -> list[float]:
         """Synchronous predict - processes each query group."""
-        from flashrank import RerankRequest
+        from flashrank import RerankRequest  # type: ignore[import-untyped]
 
         if not pairs:
             return []
@@ -821,33 +783,29 @@ class LiteLLMCrossEncoder(CrossEncoderModel):
 
 def create_cross_encoder_from_env() -> CrossEncoderModel:
     """
-    Create a CrossEncoderModel instance based on configuration.
+    Create a CrossEncoderModel instance based on environment variables.
 
-    Reads configuration via get_config() to ensure consistency across the codebase.
+    See hindsight_api.config for environment variable names and defaults.
 
     Returns:
         Configured CrossEncoderModel instance
     """
-    from ..config import get_config
-
-    config = get_config()
-    provider = config.reranker_provider.lower()
+    provider = os.environ.get(ENV_RERANKER_PROVIDER, DEFAULT_RERANKER_PROVIDER).lower()
 
     if provider == "tei":
-        url = config.reranker_tei_url
+        url = os.environ.get(ENV_RERANKER_TEI_URL)
         if not url:
             raise ValueError(f"{ENV_RERANKER_TEI_URL} is required when {ENV_RERANKER_PROVIDER} is 'tei'")
-        return RemoteTEICrossEncoder(
-            base_url=url,
-            batch_size=config.reranker_tei_batch_size,
-            max_concurrent=config.reranker_tei_max_concurrent,
-        )
+        batch_size = int(os.environ.get(ENV_RERANKER_TEI_BATCH_SIZE, str(DEFAULT_RERANKER_TEI_BATCH_SIZE)))
+        max_concurrent = int(os.environ.get(ENV_RERANKER_TEI_MAX_CONCURRENT, str(DEFAULT_RERANKER_TEI_MAX_CONCURRENT)))
+        return RemoteTEICrossEncoder(base_url=url, batch_size=batch_size, max_concurrent=max_concurrent)
     elif provider == "local":
-        return LocalSTCrossEncoder(
-            model_name=config.reranker_local_model,
-            max_concurrent=config.reranker_local_max_concurrent,
-            force_cpu=config.reranker_local_force_cpu,
+        model = os.environ.get(ENV_RERANKER_LOCAL_MODEL)
+        model_name = model or DEFAULT_RERANKER_LOCAL_MODEL
+        max_concurrent = int(
+            os.environ.get(ENV_RERANKER_LOCAL_MAX_CONCURRENT, str(DEFAULT_RERANKER_LOCAL_MAX_CONCURRENT))
         )
+        return LocalSTCrossEncoder(model_name=model_name, max_concurrent=max_concurrent)
     elif provider == "cohere":
         api_key = os.environ.get(ENV_COHERE_API_KEY)
         if not api_key:

hindsight-api/hindsight_api/engine/embeddings.py

@@ -11,7 +11,6 @@ Configuration via environment variables - see hindsight_api.config for all env v
 
 import logging
 import os
-import warnings
 from abc import ABC, abstractmethod
 
 import httpx
@@ -19,7 +18,6 @@ import httpx
 from ..config import (
     DEFAULT_EMBEDDINGS_COHERE_MODEL,
     DEFAULT_EMBEDDINGS_LITELLM_MODEL,
-    DEFAULT_EMBEDDINGS_LOCAL_FORCE_CPU,
     DEFAULT_EMBEDDINGS_LOCAL_MODEL,
     DEFAULT_EMBEDDINGS_OPENAI_MODEL,
     DEFAULT_EMBEDDINGS_PROVIDER,
@@ -28,7 +26,6 @@ from ..config import (
     ENV_EMBEDDINGS_COHERE_BASE_URL,
     ENV_EMBEDDINGS_COHERE_MODEL,
     ENV_EMBEDDINGS_LITELLM_MODEL,
-    ENV_EMBEDDINGS_LOCAL_FORCE_CPU,
     ENV_EMBEDDINGS_LOCAL_MODEL,
     ENV_EMBEDDINGS_OPENAI_API_KEY,
     ENV_EMBEDDINGS_OPENAI_BASE_URL,
@@ -95,18 +92,15 @@ class LocalSTEmbeddings(Embeddings):
     The embedding dimension is auto-detected from the model.
     """
 
-    def __init__(self, model_name: str | None = None, force_cpu: bool = False):
+    def __init__(self, model_name: str | None = None):
         """
         Initialize local SentenceTransformers embeddings.
 
         Args:
             model_name: Name of the SentenceTransformer model to use.
                        Default: BAAI/bge-small-en-v1.5
-            force_cpu: Force CPU mode (avoids MPS/XPC issues on macOS in daemon mode).
-                      Default: False
         """
         self.model_name = model_name or DEFAULT_EMBEDDINGS_LOCAL_MODEL
-        self.force_cpu = force_cpu
         self._model = None
         self._dimension: int | None = None
 
@@ -140,46 +134,19 @@ class LocalSTEmbeddings(Embeddings):
         # which can cause issues when accelerate is installed but no GPU is available.
         import torch
 
-        # Force CPU mode if configured (used in daemon mode to avoid MPS/XPC issues on macOS)
-        if self.force_cpu:
-            device = "cpu"
-            logger.info("Embeddings: forcing CPU mode")
+        # Check for GPU (CUDA) or Apple Silicon (MPS)
+        has_gpu = torch.cuda.is_available() or (hasattr(torch.backends, "mps") and torch.backends.mps.is_available())
+
+        if has_gpu:
+            device = None  # Let sentence-transformers auto-detect GPU/MPS
         else:
-            # Check for GPU (CUDA) or Apple Silicon (MPS)
-            # Wrap in try-except to gracefully handle any device detection issues
-            # (e.g., in CI environments or when PyTorch is built without GPU support)
-            device = "cpu"  # Default to CPU
-            try:
-                has_gpu = torch.cuda.is_available() or (
-                    hasattr(torch.backends, "mps") and torch.backends.mps.is_available()
-                )
-                if has_gpu:
-                    device = None  # Let sentence-transformers auto-detect GPU/MPS
-            except Exception as e:
-                logger.warning(f"Failed to detect GPU/MPS, falling back to CPU: {e}")
+            device = "cpu"
 
-        # Suppress verbose transformers warnings during model loading
-        # This suppresses the "UNEXPECTED" warnings from BertModel which are harmless
-        # but look alarming to users (e.g., "embeddings.position_ids | UNEXPECTED")
-        with warnings.catch_warnings():
-            warnings.filterwarnings("ignore", category=UserWarning)
-            warnings.filterwarnings("ignore", message=".*was not found in model state dict.*")
-            warnings.filterwarnings("ignore", message=".*UNEXPECTED.*")
-
-            # Also suppress transformers library logging temporarily
-            transformers_logger = logging.getLogger("transformers")
-            original_level = transformers_logger.level
-            transformers_logger.setLevel(logging.ERROR)
-
-            try:
-                self._model = SentenceTransformer(
-                    self.model_name,
-                    device=device,
-                    model_kwargs={"low_cpu_mem_usage": False},
-                )
-            finally:
-                # Restore original logging level
-                transformers_logger.setLevel(original_level)
+        self._model = SentenceTransformer(
+            self.model_name,
+            device=device,
+            model_kwargs={"low_cpu_mem_usage": False},
+        )
 
         self._dimension = self._model.get_sentence_embedding_dimension()
         logger.info(f"Embeddings: local provider initialized (dim: {self._dimension})")
@@ -196,7 +163,6 @@ class LocalSTEmbeddings(Embeddings):
         """
         if self._model is None:
             raise RuntimeError("Embeddings not initialized. Call initialize() first.")
-
         embeddings = self._model.encode(texts, convert_to_numpy=True, show_progress_bar=False)
         return [emb.tolist() for emb in embeddings]
 
@@ -563,7 +529,7 @@ class CohereEmbeddings(Embeddings):
                 model=self.model,
                 input_type=self.input_type,
             )
-            if response.embeddings and isinstance(response.embeddings, list):
+            if response.embeddings:
                 self._dimension = len(response.embeddings[0])
 
         logger.info(f"Embeddings: Cohere provider initialized (model: {self.model}, dim: {self._dimension})")
@@ -720,28 +686,24 @@ class LiteLLMEmbeddings(Embeddings):
 
 def create_embeddings_from_env() -> Embeddings:
     """
-    Create an Embeddings instance based on configuration.
+    Create an Embeddings instance based on environment variables.
 
-    Reads configuration via get_config() to ensure consistency across the codebase.
+    See hindsight_api.config for environment variable names and defaults.
 
     Returns:
         Configured Embeddings instance
     """
-    from ..config import get_config
-
-    config = get_config()
-    provider = config.embeddings_provider.lower()
+    provider = os.environ.get(ENV_EMBEDDINGS_PROVIDER, DEFAULT_EMBEDDINGS_PROVIDER).lower()
 
     if provider == "tei":
-        url = config.embeddings_tei_url
+        url = os.environ.get(ENV_EMBEDDINGS_TEI_URL)
         if not url:
             raise ValueError(f"{ENV_EMBEDDINGS_TEI_URL} is required when {ENV_EMBEDDINGS_PROVIDER} is 'tei'")
         return RemoteTEIEmbeddings(base_url=url)
     elif provider == "local":
-        return LocalSTEmbeddings(
-            model_name=config.embeddings_local_model,
-            force_cpu=config.embeddings_local_force_cpu,
-        )
+        model = os.environ.get(ENV_EMBEDDINGS_LOCAL_MODEL)
+        model_name = model or DEFAULT_EMBEDDINGS_LOCAL_MODEL
+        return LocalSTEmbeddings(model_name=model_name)
     elif provider == "openai":
         # Use dedicated embeddings API key, or fall back to LLM API key
         api_key = os.environ.get(ENV_EMBEDDINGS_OPENAI_API_KEY) or os.environ.get(ENV_LLM_API_KEY)

hindsight-api/hindsight_api/engine/interface.py

@@ -442,6 +442,49 @@ class MemoryEngineInterface(ABC):
         """
         ...
 
+    @abstractmethod
+    async def get_entity_observations(
+        self,
+        bank_id: str,
+        entity_id: str,
+        *,
+        limit: int = 10,
+        request_context: "RequestContext",
+    ) -> list[Any]:
+        """
+        Get observations for an entity.
+
+        Args:
+            bank_id: The memory bank ID.
+            entity_id: The entity ID.
+            limit: Maximum observations.
+            request_context: Request context for authentication.
+
+        Returns:
+            List of EntityObservation objects.
+        """
+        ...
+
+    @abstractmethod
+    async def regenerate_entity_observations(
+        self,
+        bank_id: str,
+        entity_id: str,
+        entity_name: str,
+        *,
+        request_context: "RequestContext",
+    ) -> None:
+        """
+        Regenerate observations for an entity.
+
+        Args:
+            bank_id: The memory bank ID.
+            entity_id: The entity ID.
+            entity_name: The entity's canonical name.
+            request_context: Request context for authentication.
+        """
+        ...
+
     # =========================================================================
     # Statistics & Operations
     # =========================================================================

hindsight-api/hindsight_api/engine/llm_interface.py

@@ -1,146 +0,0 @@
-"""
-Abstract interface for LLM providers.
-
-This module defines the interface that all LLM providers must implement,
-enabling support for multiple LLM backends (OpenAI, Anthropic, Gemini, Codex, etc.)
-"""
-
-from abc import ABC, abstractmethod
-from typing import Any
-
-from .response_models import LLMToolCallResult, TokenUsage
-
-
-class LLMInterface(ABC):
-    """
-    Abstract interface for LLM providers.
-
-    All LLM provider implementations must inherit from this class and implement
-    the required methods.
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        **kwargs: Any,
-    ):
-        """
-        Initialize LLM provider.
-
-        Args:
-            provider: Provider name (e.g., "openai", "codex", "anthropic", "gemini").
-            api_key: API key or authentication token.
-            base_url: Base URL for the API.
-            model: Model name.
-            reasoning_effort: Reasoning effort level for supported providers.
-            **kwargs: Additional provider-specific parameters.
-        """
-        self.provider = provider.lower()
-        self.api_key = api_key
-        self.base_url = base_url
-        self.model = model
-        self.reasoning_effort = reasoning_effort
-
-    @abstractmethod
-    async def verify_connection(self) -> None:
-        """
-        Verify that the LLM provider is configured correctly by making a simple test call.
-
-        Raises:
-            RuntimeError: If the connection test fails.
-        """
-        pass
-
-    @abstractmethod
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Make an LLM API call with retry logic.
-
-        Args:
-            messages: List of message dicts with 'role' and 'content'.
-            response_format: Optional Pydantic model for structured output.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            skip_validation: Return raw JSON without Pydantic validation.
-            strict_schema: Use strict JSON schema enforcement (OpenAI only).
-            return_usage: If True, return tuple (result, TokenUsage) instead of just result.
-
-        Returns:
-            If return_usage=False: Parsed response if response_format is provided, otherwise text content.
-            If return_usage=True: Tuple of (result, TokenUsage) with token counts.
-
-        Raises:
-            OutputTooLongError: If output exceeds token limits.
-            Exception: Re-raises API errors after retries exhausted.
-        """
-        pass
-
-    @abstractmethod
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make an LLM API call with tool/function calling support.
-
-        Args:
-            messages: List of message dicts. Can include tool results with role='tool'.
-            tools: List of tool definitions in OpenAI format.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            tool_choice: How to choose tools - "auto", "none", "required", or specific function.
-
-        Returns:
-            LLMToolCallResult with content and/or tool_calls.
-        """
-        pass
-
-    @abstractmethod
-    async def cleanup(self) -> None:
-        """Clean up resources (close connections, etc.)."""
-        pass
-
-
-class OutputTooLongError(Exception):
-    """
-    Bridge exception raised when LLM output exceeds token limits.
-
-    This wraps provider-specific errors (e.g., OpenAI's LengthFinishReasonError)
-    to allow callers to handle output length issues without depending on
-    provider-specific implementations.
-    """
-
-    pass

hindsight-api/hindsight_api/engine/providers/__init__.py

@@ -1,14 +0,0 @@
-"""
-LLM provider implementations.
-
-This package contains concrete implementations of the LLMInterface for various providers.
-"""
-
-from .anthropic_llm import AnthropicLLM
-from .claude_code_llm import ClaudeCodeLLM
-from .codex_llm import CodexLLM
-from .gemini_llm import GeminiLLM
-from .mock_llm import MockLLM
-from .openai_compatible_llm import OpenAICompatibleLLM
-
-__all__ = ["AnthropicLLM", "ClaudeCodeLLM", "CodexLLM", "GeminiLLM", "MockLLM", "OpenAICompatibleLLM"]

hindsight-api/hindsight_api/engine/providers/anthropic_llm.py

@@ -1,434 +0,0 @@
-"""
-Anthropic LLM provider using the Anthropic Python SDK.
-
-This provider enables using Claude models from Anthropic with support for:
-- Structured JSON output
-- Tool/function calling with proper format conversion
-- Extended thinking mode
-- Retry logic with exponential backoff
-"""
-
-import asyncio
-import json
-import logging
-import time
-from typing import Any
-
-from hindsight_api.engine.llm_interface import LLMInterface, OutputTooLongError
-from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
-from hindsight_api.metrics import get_metrics_collector
-
-logger = logging.getLogger(__name__)
-
-
-class AnthropicLLM(LLMInterface):
-    """
-    LLM provider using Anthropic's Claude models.
-
-    Supports structured output, tool calling, and extended thinking mode.
-    Handles format conversion between OpenAI-style messages and Anthropic's format.
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        timeout: float = 300.0,
-        **kwargs: Any,
-    ):
-        """
-        Initialize Anthropic LLM provider.
-
-        Args:
-            provider: Provider name (should be "anthropic").
-            api_key: Anthropic API key.
-            base_url: Base URL for the API (optional, uses Anthropic default if empty).
-            model: Model name (e.g., "claude-sonnet-4-20250514").
-            reasoning_effort: Reasoning effort level (not used by Anthropic).
-            timeout: Request timeout in seconds.
-            **kwargs: Additional provider-specific parameters.
-        """
-        super().__init__(provider, api_key, base_url, model, reasoning_effort, **kwargs)
-
-        if not self.api_key:
-            raise ValueError("API key is required for Anthropic provider")
-
-        # Import and initialize Anthropic client
-        try:
-            from anthropic import AsyncAnthropic
-
-            client_kwargs: dict[str, Any] = {"api_key": self.api_key}
-            if self.base_url:
-                client_kwargs["base_url"] = self.base_url
-            if timeout:
-                client_kwargs["timeout"] = timeout
-
-            self._client = AsyncAnthropic(**client_kwargs)
-            logger.info(f"Anthropic client initialized for model: {self.model}")
-        except ImportError as e:
-            raise RuntimeError("Anthropic SDK not installed. Run: uv add anthropic or pip install anthropic") from e
-
-    async def verify_connection(self) -> None:
-        """
-        Verify that the Anthropic provider is configured correctly by making a simple test call.
-
-        Raises:
-            RuntimeError: If the connection test fails.
-        """
-        try:
-            test_messages = [{"role": "user", "content": "test"}]
-            await self.call(
-                messages=test_messages,
-                max_completion_tokens=10,
-                temperature=0.0,
-                scope="test",
-                max_retries=0,
-            )
-            logger.info("Anthropic connection verified successfully")
-        except Exception as e:
-            logger.error(f"Anthropic connection verification failed: {e}")
-            raise RuntimeError(f"Failed to verify Anthropic connection: {e}") from e
-
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Make an LLM API call with retry logic.
-
-        Args:
-            messages: List of message dicts with 'role' and 'content'.
-            response_format: Optional Pydantic model for structured output.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            skip_validation: Return raw JSON without Pydantic validation.
-            strict_schema: Use strict JSON schema enforcement (not supported by Anthropic).
-            return_usage: If True, return tuple (result, TokenUsage) instead of just result.
-
-        Returns:
-            If return_usage=False: Parsed response if response_format is provided, otherwise text content.
-            If return_usage=True: Tuple of (result, TokenUsage) with token counts.
-
-        Raises:
-            OutputTooLongError: If output exceeds token limits.
-            Exception: Re-raises API errors after retries exhausted.
-        """
-        from anthropic import APIConnectionError, APIStatusError, RateLimitError
-
-        start_time = time.time()
-
-        # Convert OpenAI-style messages to Anthropic format
-        system_prompt = None
-        anthropic_messages = []
-
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                if system_prompt:
-                    system_prompt += "\n\n" + content
-                else:
-                    system_prompt = content
-            else:
-                anthropic_messages.append({"role": role, "content": content})
-
-        # Add JSON schema instruction if response_format is provided
-        if response_format is not None and hasattr(response_format, "model_json_schema"):
-            schema = response_format.model_json_schema()
-            schema_msg = f"\n\nYou must respond with valid JSON matching this schema:\n{json.dumps(schema, indent=2)}"
-            if system_prompt:
-                system_prompt += schema_msg
-            else:
-                system_prompt = schema_msg
-
-        # Prepare parameters
-        call_params: dict[str, Any] = {
-            "model": self.model,
-            "messages": anthropic_messages,
-            "max_tokens": max_completion_tokens if max_completion_tokens is not None else 4096,
-        }
-
-        if system_prompt:
-            call_params["system"] = system_prompt
-
-        if temperature is not None:
-            call_params["temperature"] = temperature
-
-        last_exception = None
-
-        for attempt in range(max_retries + 1):
-            try:
-                response = await self._client.messages.create(**call_params)
-
-                # Anthropic response content is a list of blocks
-                content = ""
-                for block in response.content:
-                    if block.type == "text":
-                        content += block.text
-
-                if response_format is not None:
-                    # Models may wrap JSON in markdown code blocks
-                    clean_content = content
-                    if "```json" in content:
-                        clean_content = content.split("```json")[1].split("```")[0].strip()
-                    elif "```" in content:
-                        clean_content = content.split("```")[1].split("```")[0].strip()
-
-                    try:
-                        json_data = json.loads(clean_content)
-                    except json.JSONDecodeError:
-                        # Fallback to parsing raw content if markdown stripping failed
-                        json_data = json.loads(content)
-
-                    if skip_validation:
-                        result = json_data
-                    else:
-                        result = response_format.model_validate(json_data)
-                else:
-                    result = content
-
-                # Record metrics and log slow calls
-                duration = time.time() - start_time
-                input_tokens = response.usage.input_tokens or 0 if response.usage else 0
-                output_tokens = response.usage.output_tokens or 0 if response.usage else 0
-                total_tokens = input_tokens + output_tokens
-
-                # Record LLM metrics
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-
-                # Log slow calls
-                if duration > 10.0:
-                    logger.info(
-                        f"slow llm call: scope={scope}, model={self.provider}/{self.model}, "
-                        f"input_tokens={input_tokens}, output_tokens={output_tokens}, "
-                        f"time={duration:.3f}s"
-                    )
-
-                if return_usage:
-                    token_usage = TokenUsage(
-                        input_tokens=input_tokens,
-                        output_tokens=output_tokens,
-                        total_tokens=total_tokens,
-                    )
-                    return result, token_usage
-                return result
-
-            except json.JSONDecodeError as e:
-                last_exception = e
-                if attempt < max_retries:
-                    logger.warning("Anthropic returned invalid JSON, retrying...")
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    await asyncio.sleep(backoff)
-                    continue
-                else:
-                    logger.error(f"Anthropic returned invalid JSON after {max_retries + 1} attempts")
-                    raise
-
-            except (APIConnectionError, RateLimitError, APIStatusError) as e:
-                # Fast fail on 401/403
-                if isinstance(e, APIStatusError) and e.status_code in (401, 403):
-                    logger.error(f"Anthropic auth error (HTTP {e.status_code}), not retrying: {str(e)}")
-                    raise
-
-                last_exception = e
-                if attempt < max_retries:
-                    # Check if it's a rate limit or server error
-                    should_retry = isinstance(e, (APIConnectionError, RateLimitError)) or (
-                        isinstance(e, APIStatusError) and e.status_code >= 500
-                    )
-
-                    if should_retry:
-                        backoff = min(initial_backoff * (2**attempt), max_backoff)
-                        jitter = backoff * 0.2 * (2 * (time.time() % 1) - 1)
-                        await asyncio.sleep(backoff + jitter)
-                        continue
-
-                logger.error(f"Anthropic API error after {max_retries + 1} attempts: {str(e)}")
-                raise
-
-            except Exception as e:
-                logger.error(f"Unexpected error during Anthropic call: {type(e).__name__}: {str(e)}")
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Anthropic call failed after all retries")
-
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make an LLM API call with tool/function calling support.
-
-        Args:
-            messages: List of message dicts. Can include tool results with role='tool'.
-            tools: List of tool definitions in OpenAI format.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            tool_choice: How to choose tools - "auto", "none", "required", or specific function.
-
-        Returns:
-            LLMToolCallResult with content and/or tool_calls.
-        """
-        from anthropic import APIConnectionError, APIStatusError
-
-        start_time = time.time()
-
-        # Convert OpenAI tool format to Anthropic format
-        anthropic_tools = []
-        for tool in tools:
-            func = tool.get("function", {})
-            anthropic_tools.append(
-                {
-                    "name": func.get("name", ""),
-                    "description": func.get("description", ""),
-                    "input_schema": func.get("parameters", {"type": "object", "properties": {}}),
-                }
-            )
-
-        # Convert messages - handle tool results
-        system_prompt = None
-        anthropic_messages = []
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                system_prompt = (system_prompt + "\n\n" + content) if system_prompt else content
-            elif role == "tool":
-                # Anthropic uses tool_result blocks
-                anthropic_messages.append(
-                    {
-                        "role": "user",
-                        "content": [
-                            {"type": "tool_result", "tool_use_id": msg.get("tool_call_id", ""), "content": content}
-                        ],
-                    }
-                )
-            elif role == "assistant" and msg.get("tool_calls"):
-                # Convert assistant tool calls
-                tool_use_blocks = []
-                for tc in msg["tool_calls"]:
-                    tool_use_blocks.append(
-                        {
-                            "type": "tool_use",
-                            "id": tc.get("id", ""),
-                            "name": tc.get("function", {}).get("name", ""),
-                            "input": json.loads(tc.get("function", {}).get("arguments", "{}")),
-                        }
-                    )
-                anthropic_messages.append({"role": "assistant", "content": tool_use_blocks})
-            else:
-                anthropic_messages.append({"role": role, "content": content})
-
-        call_params: dict[str, Any] = {
-            "model": self.model,
-            "messages": anthropic_messages,
-            "tools": anthropic_tools,
-            "max_tokens": max_completion_tokens or 4096,
-        }
-        if system_prompt:
-            call_params["system"] = system_prompt
-
-        if temperature is not None:
-            call_params["temperature"] = temperature
-
-        last_exception = None
-        for attempt in range(max_retries + 1):
-            try:
-                response = await self._client.messages.create(**call_params)
-
-                # Extract content and tool calls
-                content_parts = []
-                tool_calls: list[LLMToolCall] = []
-
-                for block in response.content:
-                    if block.type == "text":
-                        content_parts.append(block.text)
-                    elif block.type == "tool_use":
-                        tool_calls.append(LLMToolCall(id=block.id, name=block.name, arguments=block.input or {}))
-
-                content = "".join(content_parts) if content_parts else None
-                finish_reason = "tool_calls" if tool_calls else "stop"
-
-                # Extract token usage
-                input_tokens = response.usage.input_tokens or 0
-                output_tokens = response.usage.output_tokens or 0
-
-                # Record metrics
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=time.time() - start_time,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-
-                return LLMToolCallResult(
-                    content=content,
-                    tool_calls=tool_calls,
-                    finish_reason=finish_reason,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                )
-
-            except (APIConnectionError, APIStatusError) as e:
-                if isinstance(e, APIStatusError) and e.status_code in (401, 403):
-                    raise
-                last_exception = e
-                if attempt < max_retries:
-                    await asyncio.sleep(min(initial_backoff * (2**attempt), max_backoff))
-                    continue
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Anthropic tool call failed")
-
-    async def cleanup(self) -> None:
-        """Clean up resources (close Anthropic client connections)."""
-        if hasattr(self, "_client") and self._client:
-            await self._client.close()

hindsight-api/hindsight_api/engine/providers/claude_code_llm.py

@@ -1,352 +0,0 @@
-"""
-Claude Code LLM provider using Claude Agent SDK.
-
-This provider enables using Claude Pro/Max subscriptions for API calls
-via the Claude CLI authentication. It uses the Claude Agent SDK which
-automatically handles authentication via `claude auth login` credentials.
-"""
-
-import asyncio
-import json
-import logging
-import time
-from typing import Any
-
-from hindsight_api.engine.llm_interface import LLMInterface, OutputTooLongError
-from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
-from hindsight_api.metrics import get_metrics_collector
-
-logger = logging.getLogger(__name__)
-
-
-class ClaudeCodeLLM(LLMInterface):
-    """
-    LLM provider using Claude Code authentication.
-
-    Authenticates using Claude Pro/Max credentials via `claude auth login`
-    and makes API calls through the Claude Agent SDK.
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,  # Will be ignored, uses CLI auth
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        **kwargs: Any,
-    ):
-        """Initialize Claude Code LLM provider."""
-        super().__init__(provider, api_key, base_url, model, reasoning_effort, **kwargs)
-
-        # Verify Claude Agent SDK is available
-        try:
-            self._verify_claude_code_available()
-            logger.info("Claude Code: Using Claude Agent SDK (authentication via claude auth login)")
-        except Exception as e:
-            raise RuntimeError(
-                f"Failed to initialize Claude Code provider: {e}\n\n"
-                "To set up Claude Code authentication:\n"
-                "1. Install Claude Code CLI: npm install -g @anthropics/claude-code\n"
-                "2. Login with your Pro/Max plan: claude auth login\n"
-                "3. Verify authentication: claude --version\n\n"
-                "Or use a different provider (anthropic, openai, gemini) with API keys."
-            ) from e
-
-        # Metrics collector is imported at module level
-
-    def _verify_claude_code_available(self) -> None:
-        """
-        Verify that Claude Agent SDK can be imported and is properly configured.
-
-        Raises:
-            ImportError: If Claude Agent SDK is not installed.
-            RuntimeError: If Claude Code is not authenticated.
-        """
-        try:
-            # Import Claude Agent SDK
-            # Reduce Claude Agent SDK logging verbosity
-            import logging as sdk_logging
-
-            from claude_agent_sdk import query  # noqa: F401
-
-            sdk_logging.getLogger("claude_agent_sdk").setLevel(sdk_logging.WARNING)
-            sdk_logging.getLogger("claude_agent_sdk._internal").setLevel(sdk_logging.WARNING)
-
-            logger.debug("Claude Agent SDK imported successfully")
-        except ImportError as e:
-            raise ImportError(
-                "Claude Agent SDK not installed. Run: uv add claude-agent-sdk or pip install claude-agent-sdk"
-            ) from e
-
-        # SDK will automatically check for authentication when first used
-        # No need to verify here - let it fail gracefully on first call with helpful error
-
-    async def verify_connection(self) -> None:
-        """
-        Verify that the Claude Code provider is configured correctly by making a simple test call.
-
-        Raises:
-            RuntimeError: If the connection test fails.
-        """
-        try:
-            test_messages = [{"role": "user", "content": "test"}]
-            await self.call(
-                messages=test_messages,
-                max_completion_tokens=10,
-                temperature=0.0,
-                scope="test",
-                max_retries=0,
-            )
-            logger.info("Claude Code connection verified successfully")
-        except Exception as e:
-            logger.error(f"Claude Code connection verification failed: {e}")
-            raise RuntimeError(f"Failed to verify Claude Code connection: {e}") from e
-
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Make an LLM API call with retry logic.
-
-        Args:
-            messages: List of message dicts with 'role' and 'content'.
-            response_format: Optional Pydantic model for structured output.
-            max_completion_tokens: Maximum tokens in response (ignored by Claude Agent SDK).
-            temperature: Sampling temperature (ignored by Claude Agent SDK).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            skip_validation: Return raw JSON without Pydantic validation.
-            strict_schema: Use strict JSON schema enforcement (not supported).
-            return_usage: If True, return tuple (result, TokenUsage) instead of just result.
-
-        Returns:
-            If return_usage=False: Parsed response if response_format is provided, otherwise text content.
-            If return_usage=True: Tuple of (result, TokenUsage) with estimated token counts.
-
-        Raises:
-            OutputTooLongError: If output exceeds token limits (not supported by Claude Agent SDK).
-            Exception: Re-raises API errors after retries exhausted.
-        """
-        from claude_agent_sdk import AssistantMessage, ClaudeAgentOptions, TextBlock, query
-
-        start_time = time.time()
-
-        # Build system prompt
-        system_prompt = ""
-        user_content = ""
-
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                system_prompt += ("\n\n" + content) if system_prompt else content
-            elif role == "user":
-                user_content += ("\n\n" + content) if user_content else content
-            elif role == "assistant":
-                # Claude Agent SDK doesn't support multi-turn easily in query()
-                # For now, prepend assistant messages to user content
-                user_content += f"\n\n[Previous assistant response: {content}]"
-
-        # Add JSON schema instruction if response_format is provided
-        if response_format is not None and hasattr(response_format, "model_json_schema"):
-            schema = response_format.model_json_schema()
-            schema_instruction = (
-                f"\n\nYou must respond with valid JSON matching this schema:\n{json.dumps(schema, indent=2)}\n\n"
-                "Respond with ONLY the JSON, no markdown formatting."
-            )
-            user_content += schema_instruction
-
-        # Configure SDK options
-        options = ClaudeAgentOptions(
-            system_prompt=system_prompt if system_prompt else None,
-            max_turns=1,  # Single-turn for API-style interactions
-            allowed_tools=[],  # Disable tools for standard LLM calls
-        )
-
-        # Call Claude Agent SDK
-        last_exception = None
-        for attempt in range(max_retries + 1):
-            try:
-                # Collect streaming response
-                full_text = ""
-
-                async for message in query(prompt=user_content, options=options):
-                    if isinstance(message, AssistantMessage):
-                        for block in message.content:
-                            if isinstance(block, TextBlock):
-                                full_text += block.text
-
-                # Handle structured output
-                if response_format is not None:
-                    # Models may wrap JSON in markdown
-                    clean_text = full_text
-                    if "```json" in full_text:
-                        clean_text = full_text.split("```json")[1].split("```")[0].strip()
-                    elif "```" in full_text:
-                        clean_text = full_text.split("```")[1].split("```")[0].strip()
-
-                    try:
-                        json_data = json.loads(clean_text)
-                    except json.JSONDecodeError as e:
-                        logger.warning(f"Claude Code JSON parse error (attempt {attempt + 1}/{max_retries + 1}): {e}")
-                        if attempt < max_retries:
-                            backoff = min(initial_backoff * (2**attempt), max_backoff)
-                            await asyncio.sleep(backoff)
-                            last_exception = e
-                            continue
-                        raise
-
-                    if skip_validation:
-                        result = json_data
-                    else:
-                        result = response_format.model_validate(json_data)
-                else:
-                    result = full_text
-
-                # Record metrics
-                duration = time.time() - start_time
-                metrics = get_metrics_collector()
-
-                # Estimate token usage (Claude Agent SDK doesn't report exact counts)
-                # Use character count / 4 as rough estimate (1 token ≈ 4 characters)
-                estimated_input = sum(len(m.get("content", "")) for m in messages) // 4
-                estimated_output = len(full_text) // 4
-
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=estimated_input,
-                    output_tokens=estimated_output,
-                    success=True,
-                )
-
-                # Log slow calls
-                if duration > 10.0:
-                    logger.info(
-                        f"slow llm call: scope={scope}, model={self.provider}/{self.model}, time={duration:.3f}s"
-                    )
-
-                if return_usage:
-                    token_usage = TokenUsage(
-                        input_tokens=estimated_input,
-                        output_tokens=estimated_output,
-                        total_tokens=estimated_input + estimated_output,
-                    )
-                    return result, token_usage
-
-                return result
-
-            except Exception as e:
-                last_exception = e
-
-                # Check for authentication errors
-                error_str = str(e).lower()
-                if "auth" in error_str or "login" in error_str or "credential" in error_str:
-                    logger.error(f"Claude Code authentication error: {e}")
-                    raise RuntimeError(
-                        f"Claude Code authentication failed: {e}\n\n"
-                        "Run 'claude auth login' to authenticate with Claude Pro/Max."
-                    ) from e
-
-                if attempt < max_retries:
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    logger.warning(f"Claude Code error (attempt {attempt + 1}/{max_retries + 1}): {e}")
-                    await asyncio.sleep(backoff)
-                    continue
-                else:
-                    logger.error(f"Claude Code error after {max_retries + 1} attempts: {e}")
-                    raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Claude Code call failed after all retries")
-
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make an LLM API call with tool/function calling support.
-
-        Note: This is a simplified implementation. Full tool support would require
-        integrating with Claude Agent SDK's tool system.
-
-        Args:
-            messages: List of message dicts. Can include tool results with role='tool'.
-            tools: List of tool definitions in OpenAI format.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature.
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            tool_choice: How to choose tools - "auto", "none", "required", or specific function.
-
-        Returns:
-            LLMToolCallResult with content and/or tool_calls.
-        """
-        # For now, use regular call without tools
-        # Full implementation would require mapping OpenAI tool format to Claude Agent SDK tools
-        logger.warning(
-            "Claude Code provider does not fully support tool calling yet. Falling back to regular text completion."
-        )
-
-        result = await self.call(
-            messages=messages,
-            response_format=None,
-            max_completion_tokens=max_completion_tokens,
-            temperature=temperature,
-            scope=scope,
-            max_retries=max_retries,
-            initial_backoff=initial_backoff,
-            max_backoff=max_backoff,
-            return_usage=True,
-        )
-
-        if isinstance(result, tuple):
-            text, usage = result
-            return LLMToolCallResult(
-                content=text,
-                tool_calls=[],
-                finish_reason="stop",
-                input_tokens=usage.input_tokens,
-                output_tokens=usage.output_tokens,
-            )
-        else:
-            # Fallback if return_usage didn't work as expected
-            return LLMToolCallResult(
-                content=str(result),
-                tool_calls=[],
-                finish_reason="stop",
-                input_tokens=0,
-                output_tokens=0,
-            )
-
-    async def cleanup(self) -> None:
-        """Clean up resources (no HTTP client to close for Claude Agent SDK)."""
-        pass

hindsight-api/hindsight_api/engine/providers/codex_llm.py

@@ -1,527 +0,0 @@
-"""
-OpenAI Codex LLM provider using ChatGPT Plus/Pro OAuth authentication.
-
-This provider enables using ChatGPT Plus/Pro subscriptions for API calls
-without separate OpenAI Platform API credits. It uses OAuth tokens from
-~/.codex/auth.json and communicates with the ChatGPT backend API.
-"""
-
-import asyncio
-import json
-import logging
-import os
-import time
-import uuid
-from pathlib import Path
-from typing import Any
-
-import httpx
-
-from hindsight_api.engine.llm_interface import LLMInterface, OutputTooLongError
-from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
-from hindsight_api.metrics import get_metrics_collector
-
-logger = logging.getLogger(__name__)
-
-
-class CodexLLM(LLMInterface):
-    """
-    LLM provider using OpenAI Codex OAuth authentication.
-
-    Authenticates using ChatGPT Plus/Pro credentials stored in ~/.codex/auth.json
-    and makes API calls to chatgpt.com/backend-api/codex/responses.
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,  # Will be ignored, reads from ~/.codex/auth.json
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        **kwargs: Any,
-    ):
-        """Initialize Codex LLM provider."""
-        super().__init__(provider, api_key, base_url, model, reasoning_effort, **kwargs)
-
-        # Load Codex OAuth credentials
-        try:
-            self.access_token, self.account_id = self._load_codex_auth()
-            logger.info(f"Loaded Codex OAuth credentials for account: {self.account_id}")
-        except Exception as e:
-            raise RuntimeError(
-                f"Failed to load Codex OAuth credentials from ~/.codex/auth.json: {e}\n\n"
-                "To set up Codex authentication:\n"
-                "1. Install Codex CLI: npm install -g @openai/codex\n"
-                "2. Login: codex auth login\n"
-                "3. Verify: ls ~/.codex/auth.json\n\n"
-                "Or use a different provider (openai, anthropic, gemini) with API keys."
-            ) from e
-
-        # Use ChatGPT backend API endpoint
-        if not self.base_url:
-            self.base_url = "https://chatgpt.com/backend-api"
-
-        # Normalize model name (strip openai/ prefix if present)
-        if self.model.startswith("openai/"):
-            self.model = self.model[len("openai/") :]
-
-        # Map reasoning effort to Codex reasoning summary format
-        # Codex supports: "auto", "concise", "detailed"
-        self.reasoning_summary = self._map_reasoning_effort(reasoning_effort)
-
-        # HTTP client for SSE streaming
-        self._client = httpx.AsyncClient(timeout=120.0)
-
-    def _load_codex_auth(self) -> tuple[str, str]:
-        """
-        Load OAuth credentials from ~/.codex/auth.json.
-
-        Returns:
-            Tuple of (access_token, account_id).
-
-        Raises:
-            FileNotFoundError: If auth file doesn't exist.
-            ValueError: If auth file is invalid.
-        """
-        auth_file = Path.home() / ".codex" / "auth.json"
-
-        if not auth_file.exists():
-            raise FileNotFoundError(
-                f"Codex auth file not found: {auth_file}\nRun 'codex auth login' to authenticate with ChatGPT Plus/Pro."
-            )
-
-        with open(auth_file) as f:
-            data = json.load(f)
-
-        # Validate auth structure
-        auth_mode = data.get("auth_mode")
-        if auth_mode != "chatgpt":
-            raise ValueError(f"Expected auth_mode='chatgpt', got: {auth_mode}")
-
-        tokens = data.get("tokens", {})
-        access_token = tokens.get("access_token")
-        account_id = tokens.get("account_id")
-
-        if not access_token:
-            raise ValueError("No access_token found in Codex auth file. Run 'codex auth login' again.")
-
-        return access_token, account_id
-
-    def _map_reasoning_effort(self, effort: str) -> str:
-        """
-        Map standard reasoning effort to Codex reasoning summary format.
-
-        Args:
-            effort: Standard effort level ("low", "medium", "high", "xhigh").
-
-        Returns:
-            Codex reasoning summary: "concise", "detailed", or "auto".
-        """
-        mapping = {
-            "low": "concise",
-            "medium": "auto",
-            "high": "detailed",
-            "xhigh": "detailed",
-        }
-        return mapping.get(effort.lower(), "auto")
-
-    async def verify_connection(self) -> None:
-        """Verify Codex connection by making a simple test call."""
-        try:
-            logger.info(f"Verifying Codex LLM: model={self.model}, account={self.account_id}...")
-            await self.call(
-                messages=[{"role": "user", "content": "Say 'ok'"}],
-                max_completion_tokens=10,
-                max_retries=2,
-                initial_backoff=0.5,
-                max_backoff=2.0,
-            )
-            logger.info(f"Codex LLM verified: {self.model}")
-        except Exception as e:
-            raise RuntimeError(f"Codex LLM connection verification failed for {self.model}: {e}") from e
-
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """Make API call to Codex backend with SSE streaming."""
-        start_time = time.time()
-
-        # Prepare system instructions
-        system_instruction = ""
-        user_messages = []
-
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                system_instruction += ("\n\n" + content) if system_instruction else content
-            else:
-                user_messages.append(msg)
-
-        # Add JSON schema instruction if response_format is provided
-        if response_format is not None and hasattr(response_format, "model_json_schema"):
-            schema = response_format.model_json_schema()
-            schema_msg = f"\n\nYou must respond with valid JSON matching this schema:\n{json.dumps(schema, indent=2)}"
-            system_instruction += schema_msg
-
-        # Build Codex request payload
-        payload = {
-            "model": self.model,
-            "instructions": system_instruction,
-            "input": [
-                {
-                    "type": "message",
-                    "role": msg.get("role", "user"),
-                    "content": msg.get("content", ""),
-                }
-                for msg in user_messages
-            ],
-            "tools": [],
-            "tool_choice": "auto",
-            "parallel_tool_calls": True,
-            "reasoning": {"summary": self.reasoning_summary},
-            "store": False,  # Codex uses stateless mode
-            "stream": True,  # SSE streaming
-            "include": ["reasoning.encrypted_content"],
-            "prompt_cache_key": str(uuid.uuid4()),
-        }
-
-        headers = {
-            "Authorization": f"Bearer {self.access_token}",
-            "Content-Type": "application/json",
-            "OpenAI-Account-ID": self.account_id,
-            "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7)",
-            "Origin": "https://chatgpt.com",
-        }
-
-        url = f"{self.base_url}/codex/responses"
-        last_exception = None
-
-        for attempt in range(max_retries + 1):
-            try:
-                response = await self._client.post(url, json=payload, headers=headers, timeout=120.0)
-                response.raise_for_status()
-
-                # Parse SSE stream
-                content = await self._parse_sse_stream(response)
-
-                # Handle structured output
-                if response_format is not None:
-                    # Models may wrap JSON in markdown
-                    clean_content = content
-                    if "```json" in content:
-                        clean_content = content.split("```json")[1].split("```")[0].strip()
-                    elif "```" in content:
-                        clean_content = content.split("```")[1].split("```")[0].strip()
-
-                    try:
-                        json_data = json.loads(clean_content)
-                    except json.JSONDecodeError as e:
-                        logger.warning(f"Codex JSON parse error (attempt {attempt + 1}/{max_retries + 1}): {e}")
-                        if attempt < max_retries:
-                            backoff = min(initial_backoff * (2**attempt), max_backoff)
-                            await asyncio.sleep(backoff)
-                            last_exception = e
-                            continue
-                        raise
-
-                    if skip_validation:
-                        result = json_data
-                    else:
-                        result = response_format.model_validate(json_data)
-                else:
-                    result = content
-
-                # Record metrics
-                duration = time.time() - start_time
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=0,  # Codex doesn't report token counts in SSE
-                    output_tokens=0,
-                    success=True,
-                )
-
-                if return_usage:
-                    # Codex doesn't provide token counts, estimate based on content
-                    estimated_input = sum(len(m.get("content", "")) for m in messages) // 4
-                    estimated_output = len(content) // 4
-                    token_usage = TokenUsage(
-                        input_tokens=estimated_input,
-                        output_tokens=estimated_output,
-                        total_tokens=estimated_input + estimated_output,
-                    )
-                    return result, token_usage
-
-                return result
-
-            except httpx.HTTPStatusError as e:
-                last_exception = e
-                status_code = e.response.status_code
-
-                # Fast fail on auth errors
-                if status_code in (401, 403):
-                    logger.error(f"Codex auth error (HTTP {status_code}): {e.response.text[:200]}")
-                    raise RuntimeError(
-                        "Codex authentication failed. Your OAuth token may have expired.\n"
-                        "Run 'codex auth login' to re-authenticate."
-                    ) from e
-
-                if attempt < max_retries:
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    logger.warning(f"Codex HTTP error {status_code} (attempt {attempt + 1}/{max_retries + 1})")
-                    await asyncio.sleep(backoff)
-                    continue
-                else:
-                    logger.error(f"Codex HTTP error after {max_retries + 1} attempts: {e}")
-                    raise
-
-            except httpx.RequestError as e:
-                last_exception = e
-                if attempt < max_retries:
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    logger.warning(f"Codex connection error (attempt {attempt + 1}/{max_retries + 1}): {e}")
-                    await asyncio.sleep(backoff)
-                    continue
-                else:
-                    logger.error(f"Codex connection error after {max_retries + 1} attempts: {e}")
-                    raise
-
-            except Exception as e:
-                logger.error(f"Unexpected Codex error: {type(e).__name__}: {e}")
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Codex call failed after all retries")
-
-    async def _parse_sse_stream(self, response: httpx.Response) -> str:
-        """
-        Parse Server-Sent Events (SSE) stream from Codex API.
-
-        Args:
-            response: HTTP response with SSE stream.
-
-        Returns:
-            Extracted text content from stream.
-        """
-        full_text = ""
-        event_type = None
-
-        async for line in response.aiter_lines():
-            if not line:
-                continue
-
-            # Track event type
-            if line.startswith("event: "):
-                event_type = line[7:]
-
-            # Parse data
-            elif line.startswith("data: "):
-                data_str = line[6:]
-                if data_str == "[DONE]":
-                    break
-
-                try:
-                    data = json.loads(data_str)
-
-                    # Extract content based on event type
-                    if event_type == "response.text.delta" and "delta" in data:
-                        full_text += data["delta"]
-                    elif event_type == "response.content_part.delta" and "delta" in data:
-                        full_text += data["delta"]
-                    # Check for item content
-                    elif "item" in data:
-                        item = data["item"]
-                        if "content" in item:
-                            content = item["content"]
-                            if isinstance(content, list):
-                                for part in content:
-                                    if isinstance(part, dict) and "text" in part:
-                                        full_text += part["text"]
-                            elif isinstance(content, str):
-                                full_text += content
-
-                except json.JSONDecodeError:
-                    # Skip malformed JSON events
-                    pass
-
-        return full_text
-
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make API call with tool calling support.
-
-        Note: This is a basic implementation. Full tool calling support for Codex
-        may require additional SSE event parsing.
-        """
-        start_time = time.time()
-
-        # Prepare system instructions
-        system_instruction = ""
-        user_messages = []
-
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                system_instruction += ("\n\n" + content) if system_instruction else content
-            elif role == "tool":
-                # Handle tool results
-                user_messages.append(
-                    {
-                        "type": "message",
-                        "role": "user",
-                        "content": f"Tool result: {content}",
-                    }
-                )
-            else:
-                user_messages.append(
-                    {
-                        "type": "message",
-                        "role": role,
-                        "content": content,
-                    }
-                )
-
-        # Convert tools to Codex format
-        codex_tools = []
-        for tool in tools:
-            func = tool.get("function", {})
-            codex_tools.append(
-                {
-                    "type": "function",
-                    "function": {
-                        "name": func.get("name", ""),
-                        "description": func.get("description", ""),
-                        "parameters": func.get("parameters", {}),
-                    },
-                }
-            )
-
-        payload = {
-            "model": self.model,
-            "instructions": system_instruction,
-            "input": user_messages,
-            "tools": codex_tools,
-            "tool_choice": tool_choice,
-            "parallel_tool_calls": True,
-            "reasoning": {"summary": self.reasoning_summary},
-            "store": False,
-            "stream": True,
-            "include": ["reasoning.encrypted_content"],
-            "prompt_cache_key": str(uuid.uuid4()),
-        }
-
-        headers = {
-            "Authorization": f"Bearer {self.access_token}",
-            "Content-Type": "application/json",
-            "OpenAI-Account-ID": self.account_id,
-            "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7)",
-            "Origin": "https://chatgpt.com",
-        }
-
-        url = f"{self.base_url}/codex/responses"
-
-        try:
-            response = await self._client.post(url, json=payload, headers=headers, timeout=120.0)
-            response.raise_for_status()
-
-            # Parse SSE for tool calls and content
-            content, tool_calls = await self._parse_sse_tool_stream(response)
-
-            duration = time.time() - start_time
-            metrics = get_metrics_collector()
-            metrics.record_llm_call(
-                provider=self.provider,
-                model=self.model,
-                scope=scope,
-                duration=duration,
-                input_tokens=0,
-                output_tokens=0,
-                success=True,
-            )
-
-            return LLMToolCallResult(
-                content=content,
-                tool_calls=tool_calls,
-                finish_reason="tool_calls" if tool_calls else "stop",
-                input_tokens=0,
-                output_tokens=0,
-            )
-
-        except Exception as e:
-            logger.error(f"Codex tool call error: {e}")
-            raise
-
-    async def _parse_sse_tool_stream(self, response: httpx.Response) -> tuple[str | None, list[LLMToolCall]]:
-        """
-        Parse SSE stream for tool calls and content.
-
-        Returns:
-            Tuple of (content, tool_calls).
-        """
-        content = ""
-        tool_calls: list[LLMToolCall] = []
-        event_type = None
-
-        async for line in response.aiter_lines():
-            if not line:
-                continue
-
-            if line.startswith("event: "):
-                event_type = line[7:]
-
-            elif line.startswith("data: "):
-                data_str = line[6:]
-                if data_str == "[DONE]":
-                    break
-
-                try:
-                    data = json.loads(data_str)
-
-                    # Extract text content
-                    if event_type == "response.text.delta" and "delta" in data:
-                        content += data["delta"]
-
-                    # Extract tool calls
-                    elif event_type == "response.function_call_arguments.delta":
-                        # Handle tool call events (implementation depends on actual Codex SSE format)
-                        pass
-
-                except json.JSONDecodeError:
-                    pass
-
-        return content if content else None, tool_calls
-
-    async def cleanup(self) -> None:
-        """Clean up HTTP client."""
-        await self._client.aclose()

hindsight-api/hindsight_api/engine/providers/gemini_llm.py

@@ -1,502 +0,0 @@
-"""
-Google Gemini/VertexAI LLM provider.
-
-This provider supports both:
-1. Gemini API (api.generativeai.google.com) with API key authentication
-2. Vertex AI with service account or Application Default Credentials (ADC)
-"""
-
-import asyncio
-import json
-import logging
-import os
-import time
-from typing import Any
-
-from google import genai
-from google.genai import errors as genai_errors
-from google.genai import types as genai_types
-
-from hindsight_api.engine.llm_interface import LLMInterface, OutputTooLongError
-from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
-from hindsight_api.metrics import get_metrics_collector
-
-logger = logging.getLogger(__name__)
-
-# Vertex AI imports (optional)
-try:
-    import google.auth
-    from google.oauth2 import service_account
-
-    VERTEXAI_AVAILABLE = True
-except ImportError:
-    VERTEXAI_AVAILABLE = False
-
-
-class GeminiLLM(LLMInterface):
-    """
-    LLM provider for Google Gemini and Vertex AI.
-
-    Supports:
-    - Gemini API: provider="gemini", requires api_key
-    - Vertex AI: provider="vertexai", requires project_id and region, uses ADC or service account
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        **kwargs: Any,
-    ):
-        """Initialize Gemini/VertexAI LLM provider."""
-        super().__init__(provider, api_key, base_url, model, reasoning_effort, **kwargs)
-
-        self._client = None
-        self._is_vertexai = self.provider == "vertexai"
-
-        if self._is_vertexai:
-            self._init_vertexai(**kwargs)
-        else:
-            self._init_gemini()
-
-    def _init_gemini(self) -> None:
-        """Initialize Gemini API client."""
-        if not self.api_key:
-            raise ValueError("Gemini provider requires api_key")
-
-        self._client = genai.Client(api_key=self.api_key)
-        logger.info(f"Gemini API: model={self.model}")
-
-    def _init_vertexai(self, **kwargs: Any) -> None:
-        """Initialize Vertex AI client with project, region, and credentials."""
-        # Extract Vertex AI config from kwargs
-        project_id = kwargs.get("vertexai_project_id")
-        region = kwargs.get("vertexai_region", "us-central1")
-        service_account_key = kwargs.get("vertexai_service_account_key")
-        credentials = kwargs.get("vertexai_credentials")  # Pre-loaded credentials object
-
-        if not project_id:
-            raise ValueError(
-                "HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID is required for Vertex AI provider. "
-                "Set it to your GCP project ID."
-            )
-
-        auth_method = "ADC"
-
-        # Use pre-loaded credentials if provided (passed from LLMProvider)
-        if credentials is not None:
-            auth_method = "service_account"
-        # Otherwise, load explicit service account credentials if path provided
-        elif service_account_key:
-            if not VERTEXAI_AVAILABLE:
-                raise ValueError(
-                    "Vertex AI service account auth requires 'google-auth' package. "
-                    "Install with: pip install google-auth"
-                )
-            credentials = service_account.Credentials.from_service_account_file(
-                service_account_key,
-                scopes=["https://www.googleapis.com/auth/cloud-platform"],
-            )
-            auth_method = "service_account"
-            logger.info(f"Vertex AI: Using service account key: {service_account_key}")
-
-        # Strip google/ prefix from model name — native SDK uses bare names
-        # e.g. "google/gemini-2.0-flash-lite-001" -> "gemini-2.0-flash-lite-001"
-        if self.model.startswith("google/"):
-            self.model = self.model[len("google/") :]
-
-        # Create Vertex AI client
-        client_kwargs: dict[str, Any] = {
-            "vertexai": True,
-            "project": project_id,
-            "location": region,
-        }
-        if credentials is not None:
-            client_kwargs["credentials"] = credentials
-
-        self._client = genai.Client(**client_kwargs)
-
-        logger.info(f"Vertex AI: project={project_id}, region={region}, model={self.model}, auth={auth_method}")
-
-    async def verify_connection(self) -> None:
-        """
-        Verify that the Gemini/VertexAI provider is configured correctly.
-
-        Raises:
-            RuntimeError: If the connection test fails.
-        """
-        try:
-            logger.info(f"Verifying {self.provider.upper()}: model={self.model}...")
-            await self.call(
-                messages=[{"role": "user", "content": "Say 'ok'"}],
-                max_completion_tokens=100,
-                max_retries=2,
-                initial_backoff=0.5,
-                max_backoff=2.0,
-            )
-            logger.info(f"{self.provider.upper()} connection verified successfully")
-        except Exception as e:
-            raise RuntimeError(f"Failed to verify {self.provider.upper()} connection: {e}") from e
-
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Make a Gemini/VertexAI API call with retry logic.
-
-        Args:
-            messages: List of message dicts with 'role' and 'content'.
-            response_format: Optional Pydantic model for structured output.
-            max_completion_tokens: Maximum tokens in response (not supported by Gemini).
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            skip_validation: Return raw JSON without Pydantic validation.
-            strict_schema: Use strict JSON schema enforcement (not supported by Gemini).
-            return_usage: If True, return tuple (result, TokenUsage).
-
-        Returns:
-            If return_usage=False: Parsed response if response_format provided, else text.
-            If return_usage=True: Tuple of (result, TokenUsage).
-        """
-        start_time = time.time()
-
-        # Convert OpenAI-style messages to Gemini format
-        system_instruction = None
-        gemini_contents = []
-
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                if system_instruction:
-                    system_instruction += "\n\n" + content
-                else:
-                    system_instruction = content
-            elif role == "assistant":
-                gemini_contents.append(genai_types.Content(role="model", parts=[genai_types.Part(text=content)]))
-            else:
-                gemini_contents.append(genai_types.Content(role="user", parts=[genai_types.Part(text=content)]))
-
-        # Add JSON schema instruction if response_format is provided
-        if response_format is not None and hasattr(response_format, "model_json_schema"):
-            schema = response_format.model_json_schema()
-            schema_msg = f"\n\nYou must respond with valid JSON matching this schema:\n{json.dumps(schema, indent=2)}"
-            if system_instruction:
-                system_instruction += schema_msg
-            else:
-                system_instruction = schema_msg
-
-        # Build generation config
-        config_kwargs: dict[str, Any] = {}
-        if system_instruction:
-            config_kwargs["system_instruction"] = system_instruction
-        if response_format is not None:
-            config_kwargs["response_mime_type"] = "application/json"
-            config_kwargs["response_schema"] = response_format
-        if temperature is not None:
-            config_kwargs["temperature"] = temperature
-
-        generation_config = genai_types.GenerateContentConfig(**config_kwargs) if config_kwargs else None
-
-        last_exception = None
-
-        for attempt in range(max_retries + 1):
-            try:
-                response = await self._client.aio.models.generate_content(
-                    model=self.model,
-                    contents=gemini_contents,
-                    config=generation_config,
-                )
-
-                content = response.text
-
-                # Handle empty response
-                if content is None:
-                    block_reason = None
-                    if hasattr(response, "candidates") and response.candidates:
-                        candidate = response.candidates[0]
-                        if hasattr(candidate, "finish_reason"):
-                            block_reason = candidate.finish_reason
-
-                    if attempt < max_retries:
-                        logger.warning(f"Gemini returned empty response (reason: {block_reason}), retrying...")
-                        backoff = min(initial_backoff * (2**attempt), max_backoff)
-                        await asyncio.sleep(backoff)
-                        continue
-                    else:
-                        raise RuntimeError(f"Gemini returned empty response after {max_retries + 1} attempts")
-
-                # Parse structured output if requested
-                if response_format is not None:
-                    json_data = json.loads(content)
-                    if skip_validation:
-                        result = json_data
-                    else:
-                        result = response_format.model_validate(json_data)
-                else:
-                    result = content
-
-                # Extract token usage
-                input_tokens = 0
-                output_tokens = 0
-                if hasattr(response, "usage_metadata") and response.usage_metadata:
-                    usage = response.usage_metadata
-                    input_tokens = usage.prompt_token_count or 0
-                    output_tokens = usage.candidates_token_count or 0
-
-                # Record metrics
-                duration = time.time() - start_time
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-
-                # Log slow calls
-                if duration > 10.0 and input_tokens > 0:
-                    logger.info(
-                        f"slow llm call: scope={scope}, model={self.provider}/{self.model}, "
-                        f"input_tokens={input_tokens}, output_tokens={output_tokens}, "
-                        f"time={duration:.3f}s"
-                    )
-
-                if return_usage:
-                    token_usage = TokenUsage(
-                        input_tokens=input_tokens,
-                        output_tokens=output_tokens,
-                        total_tokens=input_tokens + output_tokens,
-                    )
-                    return result, token_usage
-                return result
-
-            except json.JSONDecodeError as e:
-                last_exception = e
-                if attempt < max_retries:
-                    logger.warning("Gemini returned invalid JSON, retrying...")
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    await asyncio.sleep(backoff)
-                    continue
-                else:
-                    logger.error(f"Gemini returned invalid JSON after {max_retries + 1} attempts")
-                    raise
-
-            except genai_errors.APIError as e:
-                # Fast fail on auth errors - these won't recover with retries
-                if e.code in (401, 403):
-                    logger.error(f"Gemini auth error (HTTP {e.code}), not retrying: {str(e)}")
-                    raise
-
-                # Retry on retryable errors (rate limits, server errors, client errors)
-                if e.code in (400, 429, 500, 502, 503, 504) or (e.code and e.code >= 500):
-                    last_exception = e
-                    if attempt < max_retries:
-                        backoff = min(initial_backoff * (2**attempt), max_backoff)
-                        jitter = backoff * 0.2 * (2 * (time.time() % 1) - 1)
-                        await asyncio.sleep(backoff + jitter)
-                    else:
-                        logger.error(f"Gemini API error after {max_retries + 1} attempts: {str(e)}")
-                        raise
-                else:
-                    logger.error(f"Gemini API error: {type(e).__name__}: {str(e)}")
-                    raise
-
-            except Exception as e:
-                logger.error(f"Unexpected error during Gemini call: {type(e).__name__}: {str(e)}")
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Gemini call failed after all retries")
-
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make a Gemini/VertexAI API call with tool/function calling support.
-
-        Args:
-            messages: List of message dicts. Can include tool results with role='tool'.
-            tools: List of tool definitions in OpenAI format.
-            max_completion_tokens: Maximum tokens (not supported by Gemini).
-            temperature: Sampling temperature.
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            tool_choice: How to choose tools (Gemini uses "auto" only).
-
-        Returns:
-            LLMToolCallResult with content and/or tool_calls.
-        """
-        start_time = time.time()
-
-        # Convert tools to Gemini format
-        gemini_tools = []
-        for tool in tools:
-            func = tool.get("function", {})
-            gemini_tools.append(
-                genai_types.Tool(
-                    function_declarations=[
-                        genai_types.FunctionDeclaration(
-                            name=func.get("name", ""),
-                            description=func.get("description", ""),
-                            parameters=func.get("parameters"),
-                        )
-                    ]
-                )
-            )
-
-        # Convert messages
-        system_instruction = None
-        gemini_contents = []
-        for msg in messages:
-            role = msg.get("role", "user")
-            content = msg.get("content", "")
-
-            if role == "system":
-                system_instruction = (system_instruction + "\n\n" + content) if system_instruction else content
-            elif role == "tool":
-                # Gemini uses function_response
-                gemini_contents.append(
-                    genai_types.Content(
-                        role="user",
-                        parts=[
-                            genai_types.Part(
-                                function_response=genai_types.FunctionResponse(
-                                    name=msg.get("name", ""),
-                                    response={"result": content},
-                                )
-                            )
-                        ],
-                    )
-                )
-            elif role == "assistant":
-                gemini_contents.append(genai_types.Content(role="model", parts=[genai_types.Part(text=content)]))
-            else:
-                gemini_contents.append(genai_types.Content(role="user", parts=[genai_types.Part(text=content)]))
-
-        config_kwargs: dict[str, Any] = {"tools": gemini_tools}
-        if system_instruction:
-            config_kwargs["system_instruction"] = system_instruction
-        if temperature is not None:
-            config_kwargs["temperature"] = temperature
-
-        config = genai_types.GenerateContentConfig(**config_kwargs)
-
-        last_exception = None
-        for attempt in range(max_retries + 1):
-            try:
-                response = await self._client.aio.models.generate_content(
-                    model=self.model,
-                    contents=gemini_contents,
-                    config=config,
-                )
-
-                # Extract content and tool calls
-                content = None
-                tool_calls: list[LLMToolCall] = []
-
-                if response.candidates and response.candidates[0].content:
-                    parts = response.candidates[0].content.parts
-                    if parts:
-                        for part in parts:
-                            if hasattr(part, "text") and part.text:
-                                content = part.text
-                            if hasattr(part, "function_call") and part.function_call:
-                                fc = part.function_call
-                                tool_calls.append(
-                                    LLMToolCall(
-                                        id=f"gemini_{len(tool_calls)}",
-                                        name=fc.name,
-                                        arguments=dict(fc.args) if fc.args else {},
-                                    )
-                                )
-
-                finish_reason = "tool_calls" if tool_calls else "stop"
-
-                # Extract token usage
-                input_tokens = 0
-                output_tokens = 0
-                if response.usage_metadata:
-                    input_tokens = response.usage_metadata.prompt_token_count or 0
-                    output_tokens = response.usage_metadata.candidates_token_count or 0
-
-                # Record metrics
-                duration = time.time() - start_time
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-
-                return LLMToolCallResult(
-                    content=content,
-                    tool_calls=tool_calls,
-                    finish_reason=finish_reason,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                )
-
-            except genai_errors.APIError as e:
-                # Fast fail on auth errors
-                if e.code in (401, 403):
-                    logger.error(f"Gemini auth error (HTTP {e.code}), not retrying: {str(e)}")
-                    raise
-
-                # Retry on retryable errors
-                last_exception = e
-                if attempt < max_retries:
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    await asyncio.sleep(backoff)
-                    continue
-                raise
-
-            except Exception as e:
-                logger.error(f"Unexpected error during Gemini tool call: {type(e).__name__}: {str(e)}")
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Gemini tool call failed")
-
-    async def cleanup(self) -> None:
-        """Clean up resources (close connections, etc.)."""
-        # Gemini client doesn't require explicit cleanup
-        pass

hindsight-api/hindsight_api/engine/providers/mock_llm.py

@@ -1,234 +0,0 @@
-"""
-Mock LLM provider for testing.
-
-This provider allows tests to record LLM calls and return configurable mock responses
-without making actual API calls to external LLM services.
-"""
-
-import logging
-from typing import Any
-
-from ..llm_interface import LLMInterface
-from ..response_models import LLMToolCall, LLMToolCallResult, TokenUsage
-
-logger = logging.getLogger(__name__)
-
-
-class MockLLM(LLMInterface):
-    """
-    Mock LLM provider for testing.
-
-    This provider records all calls and returns configurable mock responses,
-    enabling tests to verify LLM interactions without making real API calls.
-
-    Example:
-        # Create mock provider
-        mock_llm = MockLLM(provider="mock", api_key="", base_url="", model="mock-model")
-
-        # Set mock response
-        mock_llm.set_mock_response({"answer": "test"})
-
-        # Make calls
-        result = await mock_llm.call(
-            messages=[{"role": "user", "content": "test"}],
-            response_format=MyResponseModel
-        )
-
-        # Verify calls
-        calls = mock_llm.get_mock_calls()
-        assert len(calls) == 1
-        assert calls[0]["scope"] == "memory"
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        **kwargs: Any,
-    ):
-        """
-        Initialize mock LLM provider.
-
-        Args:
-            provider: Provider name (should be "mock").
-            api_key: Not used for mock provider.
-            base_url: Not used for mock provider.
-            model: Model name for tracking.
-            reasoning_effort: Not used for mock provider.
-            **kwargs: Additional parameters (not used).
-        """
-        super().__init__(provider, api_key, base_url, model, reasoning_effort, **kwargs)
-
-        # Storage for test verification
-        self._mock_calls: list[dict] = []
-        self._mock_response: Any = None
-
-    async def verify_connection(self) -> None:
-        """
-        Verify mock provider (always succeeds).
-
-        Mock provider doesn't need connection verification since it doesn't
-        make real API calls.
-        """
-        logger.debug("Mock LLM: connection verification (always succeeds)")
-
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Make a mock LLM API call.
-
-        Records the call for test verification and returns the configured mock response.
-
-        Args:
-            messages: List of message dicts with 'role' and 'content'.
-            response_format: Optional Pydantic model for structured output.
-            max_completion_tokens: Not used in mock.
-            temperature: Not used in mock.
-            scope: Scope identifier for tracking.
-            max_retries: Not used in mock.
-            initial_backoff: Not used in mock.
-            max_backoff: Not used in mock.
-            skip_validation: Return raw JSON without Pydantic validation.
-            strict_schema: Not used in mock.
-            return_usage: If True, return tuple (result, TokenUsage) instead of just result.
-
-        Returns:
-            If return_usage=False: Parsed response if response_format is provided, otherwise text content.
-            If return_usage=True: Tuple of (result, TokenUsage) with mock token counts.
-        """
-        # Record the call for test verification
-        call_record = {
-            "provider": self.provider,
-            "model": self.model,
-            "messages": messages,
-            "response_format": response_format.__name__
-            if response_format and hasattr(response_format, "__name__")
-            else str(response_format),
-            "scope": scope,
-        }
-        self._mock_calls.append(call_record)
-        logger.debug(f"Mock LLM call recorded: scope={scope}, model={self.model}")
-
-        # Return mock response
-        if self._mock_response is not None:
-            result = self._mock_response
-        elif response_format is not None:
-            # Try to create a minimal valid instance of the response format
-            try:
-                # For Pydantic models, try to create with minimal valid data
-                result = {"mock": True}
-            except Exception:
-                result = {"mock": True}
-        else:
-            result = "mock response"
-
-        if return_usage:
-            token_usage = TokenUsage(input_tokens=10, output_tokens=5, total_tokens=15)
-            return result, token_usage
-        return result
-
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make a mock LLM API call with tool/function calling support.
-
-        Records the call for test verification and returns the configured mock response.
-
-        Args:
-            messages: List of message dicts. Can include tool results with role='tool'.
-            tools: List of tool definitions in OpenAI format.
-            max_completion_tokens: Not used in mock.
-            temperature: Not used in mock.
-            scope: Scope identifier for tracking.
-            max_retries: Not used in mock.
-            initial_backoff: Not used in mock.
-            max_backoff: Not used in mock.
-            tool_choice: Not used in mock.
-
-        Returns:
-            LLMToolCallResult with content and/or tool_calls.
-        """
-        # Record the call for test verification
-        call_record = {
-            "provider": self.provider,
-            "model": self.model,
-            "messages": messages,
-            "tools": [t.get("function", {}).get("name") for t in tools],
-            "scope": scope,
-        }
-        self._mock_calls.append(call_record)
-
-        if self._mock_response is not None:
-            if isinstance(self._mock_response, LLMToolCallResult):
-                return self._mock_response
-            # Allow setting just tool calls as a list
-            if isinstance(self._mock_response, list):
-                return LLMToolCallResult(
-                    tool_calls=[
-                        LLMToolCall(id=f"mock_{i}", name=tc["name"], arguments=tc.get("arguments", {}))
-                        for i, tc in enumerate(self._mock_response)
-                    ],
-                    finish_reason="tool_calls",
-                )
-
-        return LLMToolCallResult(content="mock response", finish_reason="stop")
-
-    async def cleanup(self) -> None:
-        """Clean up resources (no-op for mock provider)."""
-        pass
-
-    def set_mock_response(self, response: Any) -> None:
-        """
-        Set the response to return from mock calls.
-
-        Args:
-            response: The response to return. Can be:
-                - A dict/Pydantic model for regular calls
-                - An LLMToolCallResult for tool calls
-                - A list of tool call dicts for tool calls
-                - Any other value to return as-is
-        """
-        self._mock_response = response
-
-    def get_mock_calls(self) -> list[dict]:
-        """
-        Get the list of recorded mock calls.
-
-        Returns:
-            List of call records, each containing:
-                - provider: Provider name
-                - model: Model name
-                - messages: Messages sent
-                - response_format/tools: Format or tools used
-                - scope: Call scope
-        """
-        return self._mock_calls
-
-    def clear_mock_calls(self) -> None:
-        """Clear the recorded mock calls."""
-        self._mock_calls = []

hindsight-api/hindsight_api/engine/providers/openai_compatible_llm.py

@@ -1,745 +0,0 @@
-"""
-OpenAI-compatible LLM provider supporting OpenAI, Groq, Ollama, and LMStudio.
-
-This provider handles all OpenAI API-compatible models including:
-- OpenAI: GPT-4, GPT-4o, GPT-5, o1, o3 (reasoning models)
-- Groq: Fast inference with seed control and service tiers
-- Ollama: Local models with native streaming API support
-- LMStudio: Local models with OpenAI-compatible API
-
-Features:
-- Reasoning models with extended thinking (o1, o3, GPT-5 families)
-- Strict JSON schema enforcement (OpenAI)
-- Provider-specific parameters (Groq seed, service tier)
-- Native Ollama streaming for better structured output
-- Automatic token limit handling per model family
-"""
-
-import asyncio
-import json
-import logging
-import os
-import re
-import time
-from typing import Any
-
-import httpx
-from openai import APIConnectionError, APIStatusError, AsyncOpenAI, LengthFinishReasonError
-
-from hindsight_api.config import DEFAULT_LLM_TIMEOUT, ENV_LLM_TIMEOUT
-from hindsight_api.engine.llm_interface import LLMInterface, OutputTooLongError
-from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
-from hindsight_api.metrics import get_metrics_collector
-
-logger = logging.getLogger(__name__)
-
-# Seed applied to every Groq request for deterministic behavior
-DEFAULT_LLM_SEED = 4242
-
-
-class OpenAICompatibleLLM(LLMInterface):
-    """
-    LLM provider for OpenAI-compatible APIs.
-
-    Supports:
-    - OpenAI: Standard models (GPT-4, GPT-4o) and reasoning models (o1, o3, GPT-5)
-    - Groq: Fast inference with seed control and service tiers
-    - Ollama: Local models with native streaming API for better structured output
-    - LMStudio: Local models with OpenAI-compatible API
-    """
-
-    def __init__(
-        self,
-        provider: str,
-        api_key: str,
-        base_url: str,
-        model: str,
-        reasoning_effort: str = "low",
-        timeout: float | None = None,
-        groq_service_tier: str | None = None,
-        **kwargs: Any,
-    ):
-        """
-        Initialize OpenAI-compatible LLM provider.
-
-        Args:
-            provider: Provider name ("openai", "groq", "ollama", "lmstudio").
-            api_key: API key (optional for ollama/lmstudio).
-            base_url: Base URL for the API (uses defaults for groq/ollama/lmstudio if empty).
-            model: Model name.
-            reasoning_effort: Reasoning effort level for supported models ("low", "medium", "high").
-            timeout: Request timeout in seconds (uses env var or 300s default).
-            groq_service_tier: Groq service tier ("on_demand", "flex", "auto").
-            **kwargs: Additional provider-specific parameters.
-        """
-        super().__init__(provider, api_key, base_url, model, reasoning_effort, **kwargs)
-
-        # Validate provider
-        valid_providers = ["openai", "groq", "ollama", "lmstudio"]
-        if self.provider not in valid_providers:
-            raise ValueError(f"OpenAICompatibleLLM only supports: {', '.join(valid_providers)}. Got: {self.provider}")
-
-        # Set default base URLs
-        if not self.base_url:
-            if self.provider == "groq":
-                self.base_url = "https://api.groq.com/openai/v1"
-            elif self.provider == "ollama":
-                self.base_url = "http://localhost:11434/v1"
-            elif self.provider == "lmstudio":
-                self.base_url = "http://localhost:1234/v1"
-
-        # For ollama/lmstudio, use dummy key if not provided
-        if self.provider in ("ollama", "lmstudio") and not self.api_key:
-            self.api_key = "local"
-
-        # Validate API key for cloud providers
-        if self.provider in ("openai", "groq") and not self.api_key:
-            raise ValueError(f"API key is required for {self.provider}")
-
-        # Groq service tier configuration
-        self.groq_service_tier = groq_service_tier or os.getenv("HINDSIGHT_API_LLM_GROQ_SERVICE_TIER", "auto")
-
-        # Get timeout config
-        self.timeout = timeout or float(os.getenv(ENV_LLM_TIMEOUT, str(DEFAULT_LLM_TIMEOUT)))
-
-        # Create OpenAI client
-        client_kwargs: dict[str, Any] = {"api_key": self.api_key, "max_retries": 0}
-        if self.base_url:
-            client_kwargs["base_url"] = self.base_url
-        if self.timeout:
-            client_kwargs["timeout"] = self.timeout
-
-        self._client = AsyncOpenAI(**client_kwargs)
-        logger.info(
-            f"OpenAI-compatible client initialized: provider={self.provider}, model={self.model}, "
-            f"base_url={self.base_url or 'default'}"
-        )
-
-    async def verify_connection(self) -> None:
-        """
-        Verify that the provider is configured correctly by making a simple test call.
-
-        Raises:
-            RuntimeError: If the connection test fails.
-        """
-        try:
-            logger.info(f"Verifying connection: {self.provider}/{self.model}")
-            await self.call(
-                messages=[{"role": "user", "content": "Say 'ok'"}],
-                max_completion_tokens=100,
-                max_retries=2,
-                initial_backoff=0.5,
-                max_backoff=2.0,
-            )
-            logger.info(f"Connection verified: {self.provider}/{self.model}")
-        except Exception as e:
-            raise RuntimeError(f"Connection verification failed for {self.provider}/{self.model}: {e}") from e
-
-    def _supports_reasoning_model(self) -> bool:
-        """Check if the current model is a reasoning model (o1, o3, GPT-5, DeepSeek)."""
-        model_lower = self.model.lower()
-        return any(x in model_lower for x in ["gpt-5", "o1", "o3", "deepseek"])
-
-    def _get_max_reasoning_tokens(self) -> int | None:
-        """Get max reasoning tokens for reasoning models."""
-        model_lower = self.model.lower()
-
-        # GPT-4 and GPT-4.1 models have different caps
-        if any(x in model_lower for x in ["gpt-4.1", "gpt-4-"]):
-            return 32000
-        elif "gpt-4o" in model_lower:
-            return 16384
-
-        return None
-
-    async def call(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any | None = None,
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "memory",
-        max_retries: int = 10,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 60.0,
-        skip_validation: bool = False,
-        strict_schema: bool = False,
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Make an LLM API call with retry logic.
-
-        Args:
-            messages: List of message dicts with 'role' and 'content'.
-            response_format: Optional Pydantic model for structured output.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            skip_validation: Return raw JSON without Pydantic validation.
-            strict_schema: Use strict JSON schema enforcement (OpenAI only).
-            return_usage: If True, return tuple (result, TokenUsage) instead of just result.
-
-        Returns:
-            If return_usage=False: Parsed response if response_format is provided, otherwise text content.
-            If return_usage=True: Tuple of (result, TokenUsage) with token counts.
-
-        Raises:
-            OutputTooLongError: If output exceeds token limits.
-            Exception: Re-raises API errors after retries exhausted.
-        """
-        # Handle Ollama with native API for structured output (better schema enforcement)
-        if self.provider == "ollama" and response_format is not None:
-            return await self._call_ollama_native(
-                messages=messages,
-                response_format=response_format,
-                max_completion_tokens=max_completion_tokens,
-                temperature=temperature,
-                max_retries=max_retries,
-                initial_backoff=initial_backoff,
-                max_backoff=max_backoff,
-                skip_validation=skip_validation,
-                scope=scope,
-                return_usage=return_usage,
-            )
-
-        start_time = time.time()
-
-        # Build call parameters
-        call_params: dict[str, Any] = {
-            "model": self.model,
-            "messages": messages,
-        }
-
-        # Check if model supports reasoning parameter
-        is_reasoning_model = self._supports_reasoning_model()
-
-        # Apply model-specific token limits
-        if max_completion_tokens is not None:
-            max_tokens_cap = self._get_max_reasoning_tokens()
-            if max_tokens_cap and max_completion_tokens > max_tokens_cap:
-                max_completion_tokens = max_tokens_cap
-            # For reasoning models, enforce minimum to ensure space for reasoning + output
-            if is_reasoning_model and max_completion_tokens < 16000:
-                max_completion_tokens = 16000
-            call_params["max_completion_tokens"] = max_completion_tokens
-
-        # Temperature - reasoning models don't support custom temperature
-        if temperature is not None and not is_reasoning_model:
-            call_params["temperature"] = temperature
-
-        # Set reasoning_effort for reasoning models
-        if is_reasoning_model:
-            call_params["reasoning_effort"] = self.reasoning_effort
-
-        # Provider-specific parameters
-        if self.provider == "groq":
-            call_params["seed"] = DEFAULT_LLM_SEED
-            extra_body: dict[str, Any] = {}
-            # Add service_tier if configured
-            if self.groq_service_tier:
-                extra_body["service_tier"] = self.groq_service_tier
-            # Add reasoning parameters for reasoning models
-            if is_reasoning_model:
-                extra_body["include_reasoning"] = False
-            if extra_body:
-                call_params["extra_body"] = extra_body
-
-        # Prepare response format ONCE before retry loop
-        if response_format is not None:
-            schema = None
-            if hasattr(response_format, "model_json_schema"):
-                schema = response_format.model_json_schema()
-
-            if strict_schema and schema is not None:
-                # Use OpenAI's strict JSON schema enforcement
-                call_params["response_format"] = {
-                    "type": "json_schema",
-                    "json_schema": {
-                        "name": "response",
-                        "strict": True,
-                        "schema": schema,
-                    },
-                }
-            else:
-                # Soft enforcement: add schema to prompt and use json_object mode
-                if schema is not None:
-                    schema_msg = (
-                        f"\n\nYou must respond with valid JSON matching this schema:\n{json.dumps(schema, indent=2)}"
-                    )
-
-                    if call_params["messages"] and call_params["messages"][0].get("role") == "system":
-                        first_msg = call_params["messages"][0]
-                        if isinstance(first_msg, dict) and isinstance(first_msg.get("content"), str):
-                            first_msg["content"] += schema_msg
-                    elif call_params["messages"]:
-                        first_msg = call_params["messages"][0]
-                        if isinstance(first_msg, dict) and isinstance(first_msg.get("content"), str):
-                            first_msg["content"] = schema_msg + "\n\n" + first_msg["content"]
-                if self.provider not in ("lmstudio", "ollama"):
-                    # LM Studio and Ollama don't support json_object response format reliably
-                    call_params["response_format"] = {"type": "json_object"}
-
-        last_exception = None
-
-        for attempt in range(max_retries + 1):
-            try:
-                if response_format is not None:
-                    response = await self._client.chat.completions.create(**call_params)
-
-                    content = response.choices[0].message.content
-
-                    # Strip reasoning model thinking tags
-                    # Supports: <think>, <thinking>, <reasoning>, |startthink|/|endthink|
-                    if content:
-                        original_len = len(content)
-                        content = re.sub(r"<think>.*?</think>", "", content, flags=re.DOTALL)
-                        content = re.sub(r"<thinking>.*?</thinking>", "", content, flags=re.DOTALL)
-                        content = re.sub(r"<reasoning>.*?</reasoning>", "", content, flags=re.DOTALL)
-                        content = re.sub(r"\|startthink\|.*?\|endthink\|", "", content, flags=re.DOTALL)
-                        content = content.strip()
-                        if len(content) < original_len:
-                            logger.debug(f"Stripped {original_len - len(content)} chars of reasoning tokens")
-
-                    # For local models, they may wrap JSON in markdown code blocks
-                    if self.provider in ("lmstudio", "ollama"):
-                        clean_content = content
-                        if "```json" in content:
-                            clean_content = content.split("```json")[1].split("```")[0].strip()
-                        elif "```" in content:
-                            clean_content = content.split("```")[1].split("```")[0].strip()
-                        try:
-                            json_data = json.loads(clean_content)
-                        except json.JSONDecodeError:
-                            # Fallback to parsing raw content
-                            json_data = json.loads(content)
-                    else:
-                        # Log raw LLM response for debugging JSON parse issues
-                        try:
-                            json_data = json.loads(content)
-                        except json.JSONDecodeError as json_err:
-                            # Truncate content for logging
-                            content_preview = content[:500] if content else "<empty>"
-                            if content and len(content) > 700:
-                                content_preview = f"{content[:500]}...TRUNCATED...{content[-200:]}"
-                            logger.warning(
-                                f"JSON parse error from LLM response (attempt {attempt + 1}/{max_retries + 1}): {json_err}\n"
-                                f"  Model: {self.provider}/{self.model}\n"
-                                f"  Content length: {len(content) if content else 0} chars\n"
-                                f"  Content preview: {content_preview!r}\n"
-                                f"  Finish reason: {response.choices[0].finish_reason if response.choices else 'unknown'}"
-                            )
-                            # Retry on JSON parse errors
-                            if attempt < max_retries:
-                                backoff = min(initial_backoff * (2**attempt), max_backoff)
-                                await asyncio.sleep(backoff)
-                                last_exception = json_err
-                                continue
-                            else:
-                                logger.error(f"JSON parse error after {max_retries + 1} attempts, giving up")
-                                raise
-
-                    if skip_validation:
-                        result = json_data
-                    else:
-                        result = response_format.model_validate(json_data)
-                else:
-                    response = await self._client.chat.completions.create(**call_params)
-                    result = response.choices[0].message.content
-
-                # Record token usage metrics
-                duration = time.time() - start_time
-                usage = response.usage
-                input_tokens = usage.prompt_tokens or 0 if usage else 0
-                output_tokens = usage.completion_tokens or 0 if usage else 0
-                total_tokens = usage.total_tokens or 0 if usage else 0
-
-                # Record LLM metrics
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-
-                # Log slow calls
-                if duration > 10.0 and usage:
-                    ratio = max(1, output_tokens) / max(1, input_tokens)
-                    cached_tokens = 0
-                    if hasattr(usage, "prompt_tokens_details") and usage.prompt_tokens_details:
-                        cached_tokens = getattr(usage.prompt_tokens_details, "cached_tokens", 0) or 0
-                    cache_info = f", cached_tokens={cached_tokens}" if cached_tokens > 0 else ""
-                    logger.info(
-                        f"slow llm call: scope={scope}, model={self.provider}/{self.model}, "
-                        f"input_tokens={input_tokens}, output_tokens={output_tokens}, "
-                        f"total_tokens={total_tokens}{cache_info}, time={duration:.3f}s, ratio out/in={ratio:.2f}"
-                    )
-
-                if return_usage:
-                    token_usage = TokenUsage(
-                        input_tokens=input_tokens,
-                        output_tokens=output_tokens,
-                        total_tokens=total_tokens,
-                    )
-                    return result, token_usage
-                return result
-
-            except LengthFinishReasonError as e:
-                logger.warning(f"LLM output exceeded token limits: {str(e)}")
-                raise OutputTooLongError(
-                    "LLM output exceeded token limits. Input may need to be split into smaller chunks."
-                ) from e
-
-            except APIConnectionError as e:
-                last_exception = e
-                status_code = getattr(e, "status_code", None) or getattr(
-                    getattr(e, "response", None), "status_code", None
-                )
-                logger.warning(f"APIConnectionError (HTTP {status_code}), attempt {attempt + 1}: {str(e)[:200]}")
-                if attempt < max_retries:
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    await asyncio.sleep(backoff)
-                    continue
-                else:
-                    logger.error(f"Connection error after {max_retries + 1} attempts: {str(e)}")
-                    raise
-
-            except APIStatusError as e:
-                # Fast fail only on 401 (unauthorized) and 403 (forbidden)
-                if e.status_code in (401, 403):
-                    logger.error(f"Auth error (HTTP {e.status_code}), not retrying: {str(e)}")
-                    raise
-
-                # Handle tool_use_failed error - model outputted in tool call format
-                if e.status_code == 400 and response_format is not None:
-                    try:
-                        error_body = e.body if hasattr(e, "body") else {}
-                        if isinstance(error_body, dict):
-                            error_info: dict[str, Any] = error_body.get("error") or {}
-                            if error_info.get("code") == "tool_use_failed":
-                                failed_gen = error_info.get("failed_generation", "")
-                                if failed_gen:
-                                    # Parse tool call format and convert to expected format
-                                    tool_call = json.loads(failed_gen)
-                                    tool_name = tool_call.get("name", "")
-                                    tool_args = tool_call.get("arguments", {})
-                                    converted = {"actions": [{"tool": tool_name, **tool_args}]}
-                                    if skip_validation:
-                                        result = converted
-                                    else:
-                                        result = response_format.model_validate(converted)
-
-                                    # Record metrics
-                                    duration = time.time() - start_time
-                                    metrics = get_metrics_collector()
-                                    metrics.record_llm_call(
-                                        provider=self.provider,
-                                        model=self.model,
-                                        scope=scope,
-                                        duration=duration,
-                                        input_tokens=0,
-                                        output_tokens=0,
-                                        success=True,
-                                    )
-                                    if return_usage:
-                                        return result, TokenUsage(input_tokens=0, output_tokens=0, total_tokens=0)
-                                    return result
-                    except (json.JSONDecodeError, KeyError, TypeError):
-                        pass  # Failed to parse tool_use_failed, continue with normal retry
-
-                last_exception = e
-                if attempt < max_retries:
-                    backoff = min(initial_backoff * (2**attempt), max_backoff)
-                    jitter = backoff * 0.2 * (2 * (time.time() % 1) - 1)
-                    sleep_time = backoff + jitter
-                    await asyncio.sleep(sleep_time)
-                else:
-                    logger.error(f"API error after {max_retries + 1} attempts: {str(e)}")
-                    raise
-
-            except Exception:
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("LLM call failed after all retries with no exception captured")
-
-    async def call_with_tools(
-        self,
-        messages: list[dict[str, Any]],
-        tools: list[dict[str, Any]],
-        max_completion_tokens: int | None = None,
-        temperature: float | None = None,
-        scope: str = "tools",
-        max_retries: int = 5,
-        initial_backoff: float = 1.0,
-        max_backoff: float = 30.0,
-        tool_choice: str | dict[str, Any] = "auto",
-    ) -> LLMToolCallResult:
-        """
-        Make an LLM API call with tool/function calling support.
-
-        Args:
-            messages: List of message dicts. Can include tool results with role='tool'.
-            tools: List of tool definitions in OpenAI format.
-            max_completion_tokens: Maximum tokens in response.
-            temperature: Sampling temperature (0.0-2.0).
-            scope: Scope identifier for tracking.
-            max_retries: Maximum retry attempts.
-            initial_backoff: Initial backoff time in seconds.
-            max_backoff: Maximum backoff time in seconds.
-            tool_choice: How to choose tools - "auto", "none", "required", or specific function.
-
-        Returns:
-            LLMToolCallResult with content and/or tool_calls.
-        """
-        start_time = time.time()
-
-        # Build call parameters
-        call_params: dict[str, Any] = {
-            "model": self.model,
-            "messages": messages,
-            "tools": tools,
-            "tool_choice": tool_choice,
-        }
-
-        if max_completion_tokens is not None:
-            call_params["max_completion_tokens"] = max_completion_tokens
-        if temperature is not None:
-            call_params["temperature"] = temperature
-
-        # Provider-specific parameters
-        if self.provider == "groq":
-            call_params["seed"] = DEFAULT_LLM_SEED
-
-        last_exception = None
-
-        for attempt in range(max_retries + 1):
-            try:
-                response = await self._client.chat.completions.create(**call_params)
-
-                message = response.choices[0].message
-                finish_reason = response.choices[0].finish_reason
-
-                # Extract tool calls if present
-                tool_calls: list[LLMToolCall] = []
-                if message.tool_calls:
-                    for tc in message.tool_calls:
-                        try:
-                            args = json.loads(tc.function.arguments) if tc.function.arguments else {}
-                        except json.JSONDecodeError:
-                            args = {"_raw": tc.function.arguments}
-                        tool_calls.append(LLMToolCall(id=tc.id, name=tc.function.name, arguments=args))
-
-                content = message.content
-
-                # Record metrics
-                duration = time.time() - start_time
-                usage = response.usage
-                input_tokens = usage.prompt_tokens or 0 if usage else 0
-                output_tokens = usage.completion_tokens or 0 if usage else 0
-
-                metrics = get_metrics_collector()
-                metrics.record_llm_call(
-                    provider=self.provider,
-                    model=self.model,
-                    scope=scope,
-                    duration=duration,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                    success=True,
-                )
-
-                return LLMToolCallResult(
-                    content=content,
-                    tool_calls=tool_calls,
-                    finish_reason=finish_reason,
-                    input_tokens=input_tokens,
-                    output_tokens=output_tokens,
-                )
-
-            except APIConnectionError as e:
-                last_exception = e
-                if attempt < max_retries:
-                    await asyncio.sleep(min(initial_backoff * (2**attempt), max_backoff))
-                    continue
-                raise
-
-            except APIStatusError as e:
-                if e.status_code in (401, 403):
-                    raise
-                last_exception = e
-                if attempt < max_retries:
-                    await asyncio.sleep(min(initial_backoff * (2**attempt), max_backoff))
-                    continue
-                raise
-
-            except Exception:
-                raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Tool call failed after all retries")
-
-    async def _call_ollama_native(
-        self,
-        messages: list[dict[str, str]],
-        response_format: Any,
-        max_completion_tokens: int | None,
-        temperature: float | None,
-        max_retries: int,
-        initial_backoff: float,
-        max_backoff: float,
-        skip_validation: bool,
-        scope: str = "memory",
-        return_usage: bool = False,
-    ) -> Any:
-        """
-        Call Ollama using native API with JSON schema enforcement.
-
-        Ollama's native API supports passing a full JSON schema in the 'format' parameter,
-        which provides better structured output control than the OpenAI-compatible API.
-        """
-        start_time = time.time()
-
-        # Get the JSON schema from the Pydantic model
-        schema = response_format.model_json_schema() if hasattr(response_format, "model_json_schema") else None
-
-        # Build the base URL for Ollama's native API
-        # Default OpenAI-compatible URL is http://localhost:11434/v1
-        # Native API is at http://localhost:11434/api/chat
-        base_url = self.base_url or "http://localhost:11434/v1"
-        if base_url.endswith("/v1"):
-            native_url = base_url[:-3] + "/api/chat"
-        else:
-            native_url = base_url.rstrip("/") + "/api/chat"
-
-        # Build request payload
-        payload: dict[str, Any] = {
-            "model": self.model,
-            "messages": messages,
-            "stream": False,
-        }
-
-        # Add schema as format parameter for structured output
-        if schema:
-            payload["format"] = schema
-
-        # Add optional parameters with optimized defaults for Ollama
-        options: dict[str, Any] = {
-            "num_ctx": 16384,  # 16k context window for larger prompts
-            "num_batch": 512,  # Optimal batch size for prompt processing
-        }
-        if max_completion_tokens:
-            options["num_predict"] = max_completion_tokens
-        if temperature is not None:
-            options["temperature"] = temperature
-        payload["options"] = options
-
-        last_exception = None
-
-        async with httpx.AsyncClient(timeout=300.0) as client:
-            for attempt in range(max_retries + 1):
-                try:
-                    response = await client.post(native_url, json=payload)
-                    response.raise_for_status()
-
-                    result = response.json()
-                    content = result.get("message", {}).get("content", "")
-
-                    # Parse JSON response
-                    try:
-                        json_data = json.loads(content)
-                    except json.JSONDecodeError as json_err:
-                        content_preview = content[:500] if content else "<empty>"
-                        if content and len(content) > 700:
-                            content_preview = f"{content[:500]}...TRUNCATED...{content[-200:]}"
-                        logger.warning(
-                            f"Ollama JSON parse error (attempt {attempt + 1}/{max_retries + 1}): {json_err}\n"
-                            f"  Model: ollama/{self.model}\n"
-                            f"  Content length: {len(content) if content else 0} chars\n"
-                            f"  Content preview: {content_preview!r}"
-                        )
-                        if attempt < max_retries:
-                            backoff = min(initial_backoff * (2**attempt), max_backoff)
-                            await asyncio.sleep(backoff)
-                            last_exception = json_err
-                            continue
-                        else:
-                            raise
-
-                    # Extract token usage from Ollama response
-                    duration = time.time() - start_time
-                    input_tokens = result.get("prompt_eval_count", 0) or 0
-                    output_tokens = result.get("eval_count", 0) or 0
-                    total_tokens = input_tokens + output_tokens
-
-                    # Record LLM metrics
-                    metrics = get_metrics_collector()
-                    metrics.record_llm_call(
-                        provider=self.provider,
-                        model=self.model,
-                        scope=scope,
-                        duration=duration,
-                        input_tokens=input_tokens,
-                        output_tokens=output_tokens,
-                        success=True,
-                    )
-
-                    # Validate against Pydantic model or return raw JSON
-                    if skip_validation:
-                        validated_result = json_data
-                    else:
-                        validated_result = response_format.model_validate(json_data)
-
-                    if return_usage:
-                        token_usage = TokenUsage(
-                            input_tokens=input_tokens,
-                            output_tokens=output_tokens,
-                            total_tokens=total_tokens,
-                        )
-                        return validated_result, token_usage
-                    return validated_result
-
-                except httpx.HTTPStatusError as e:
-                    last_exception = e
-                    if attempt < max_retries:
-                        logger.warning(
-                            f"Ollama HTTP error (attempt {attempt + 1}/{max_retries + 1}): {e.response.status_code}"
-                        )
-                        backoff = min(initial_backoff * (2**attempt), max_backoff)
-                        await asyncio.sleep(backoff)
-                        continue
-                    else:
-                        logger.error(f"Ollama HTTP error after {max_retries + 1} attempts: {e}")
-                        raise
-
-                except httpx.RequestError as e:
-                    last_exception = e
-                    if attempt < max_retries:
-                        logger.warning(f"Ollama connection error (attempt {attempt + 1}/{max_retries + 1}): {e}")
-                        backoff = min(initial_backoff * (2**attempt), max_backoff)
-                        await asyncio.sleep(backoff)
-                        continue
-                    else:
-                        logger.error(f"Ollama connection error after {max_retries + 1} attempts: {e}")
-                        raise
-
-                except Exception as e:
-                    logger.error(f"Unexpected error during Ollama call: {type(e).__name__}: {e}")
-                    raise
-
-        if last_exception:
-            raise last_exception
-        raise RuntimeError("Ollama call failed after all retries")
-
-    async def cleanup(self) -> None:
-        """Clean up resources (close OpenAI client connections)."""
-        if hasattr(self, "_client") and self._client:
-            await self._client.close()

hindsight-api/hindsight_api/engine/reflect/__init__.py

@@ -4,15 +4,17 @@ Reflect agent module for agentic reflection with tools.
 The reflect agent uses an iterative loop with tools to:
 1. Lookup mental models (existing knowledge)
 2. Recall facts (semantic + temporal search)
-3. Expand memories (get chunk/document context)
+3. Learn new insights (create/update mental models)
+4. Expand memories (get chunk/document context)
 """
 
 from .agent import ReflectAgentResult, run_reflect_agent
-from .models import ReflectAction, ReflectActionBatch
+from .models import MentalModelInput, ReflectAction, ReflectActionBatch
 
 __all__ = [
     "run_reflect_agent",
     "ReflectAgentResult",
     "ReflectAction",
     "ReflectActionBatch",
+    "MentalModelInput",
 ]

hindsight-api/hindsight_api/engine/reflect/agent.py

@@ -2,8 +2,8 @@
 Reflect agent - agentic loop for reflection with native tool calling.
 
 Uses hierarchical retrieval:
-1. search_mental_models - User-curated summaries (highest quality)
-2. search_observations - Consolidated knowledge with freshness
+1. search_reflections - User-curated summaries (highest quality)
+2. search_mental_models - Consolidated knowledge with freshness
 3. recall - Raw facts as ground truth
 """
 
@@ -20,12 +20,7 @@ from .tools_schema import get_reflect_tools
 
 
 def _build_directives_applied(directives: list[dict[str, Any]] | None) -> list[DirectiveInfo]:
-    """Build list of DirectiveInfo from directive mental models.
-
-    Handles multiple directive formats:
-    1. New format: directives have direct 'content' field
-    2. Fallback: directives have 'description' field
-    """
+    """Build list of DirectiveInfo from directive mental models."""
     if not directives:
         return []
 
@@ -33,11 +28,17 @@ def _build_directives_applied(directives: list[dict[str, Any]] | None) -> list[D
     for directive in directives:
         directive_id = directive.get("id", "")
         directive_name = directive.get("name", "")
+        observations = directive.get("observations", [])
 
-        # Get content from 'content' field or fallback to 'description'
-        content = directive.get("content", "") or directive.get("description", "")
+        rules = []
+        for obs in observations:
+            # Support both Pydantic Observation objects and dicts
+            if hasattr(obs, "content"):
+                rules.append(obs.content)
+            elif isinstance(obs, dict) and obs.get("content"):
+                rules.append(obs["content"])
 
-        result.append(DirectiveInfo(id=directive_id, name=directive_name, content=content))
+        result.append(DirectiveInfo(id=directive_id, name=directive_name, rules=rules))
 
     return result
 
@@ -58,7 +59,6 @@ def _normalize_tool_name(name: str) -> str:
     - 'functions.done' (OpenAI-style prefix)
     - 'call=functions.done' (some models)
     - 'call=done' (some models)
-    - 'done<|channel|>commentary' (malformed special tokens appended)
 
     Returns the normalized tool name (e.g., 'done', 'recall', etc.)
     """
@@ -70,11 +70,6 @@ def _normalize_tool_name(name: str) -> str:
     if name.startswith("functions."):
         name = name[len("functions.") :]
 
-    # Handle malformed special tokens appended to tool name
-    # e.g., 'done<|channel|>commentary' -> 'done'
-    if "<|" in name:
-        name = name.split("<|")[0]
-
     return name
 
 
@@ -86,18 +81,6 @@ def _is_done_tool(name: str) -> bool:
 # Pattern to match done() call as text - handles done({...}) with nested JSON
 _DONE_CALL_PATTERN = re.compile(r"done\s*\(\s*\{.*$", re.DOTALL)
 
-# Patterns for leaked structured output in the answer field
-_LEAKED_JSON_SUFFIX = re.compile(
-    r'\s*```(?:json)?\s*\{[^}]*(?:"(?:observation_ids|memory_ids|mental_model_ids)"|\})\s*```\s*$',
-    re.DOTALL | re.IGNORECASE,
-)
-_LEAKED_JSON_OBJECT = re.compile(
-    r'\s*\{[^{]*"(?:observation_ids|memory_ids|mental_model_ids|answer)"[^}]*\}\s*$', re.DOTALL
-)
-_TRAILING_IDS_PATTERN = re.compile(
-    r"\s*(?:observation_ids|memory_ids|mental_model_ids)\s*[=:]\s*\[.*?\]\s*$", re.DOTALL | re.IGNORECASE
-)
-
 
 def _clean_answer_text(text: str) -> str:
     """Clean up answer text by removing any done() tool call syntax.
@@ -110,33 +93,6 @@ def _clean_answer_text(text: str) -> str:
     return cleaned if cleaned else text
 
 
-def _clean_done_answer(text: str) -> str:
-    """Clean up the answer field from a done() tool call.
-
-    Some LLMs leak structured output patterns into the answer text, such as:
-    - JSON code blocks with observation_ids/memory_ids at the end
-    - Raw JSON objects with these fields
-    - Plain text like "observation_ids: [...]"
-
-    This cleans those patterns while preserving the actual answer content.
-    """
-    if not text:
-        return text
-
-    cleaned = text
-
-    # Remove leaked JSON in code blocks at the end
-    cleaned = _LEAKED_JSON_SUFFIX.sub("", cleaned).strip()
-
-    # Remove leaked raw JSON objects at the end
-    cleaned = _LEAKED_JSON_OBJECT.sub("", cleaned).strip()
-
-    # Remove trailing ID patterns
-    cleaned = _TRAILING_IDS_PATTERN.sub("", cleaned).strip()
-
-    return cleaned if cleaned else text
-
-
 async def _generate_structured_output(
     answer: str,
     response_schema: dict,
@@ -186,55 +142,35 @@ async def _generate_structured_output(
             fields[field_name] = (field_type, default)
 
         if not fields:
-            logger.warning(f"[REFLECT {reflect_id}] No fields found in response_schema, skipping structured output")
-            return None, 0, 0
+            return None
 
         DynamicModel = create_model("StructuredResponse", **fields)
 
         # Include the full schema in the prompt for better LLM guidance
         schema_str = json.dumps(response_schema, indent=2)
 
-        # Build field descriptions for the prompt
-        field_descriptions = []
-        for field_name, field_schema in schema_props.items():
-            field_type = field_schema.get("type", "string")
-            field_desc = field_schema.get("description", "")
-            is_required = field_name in required_fields
-            req_marker = " (REQUIRED)" if is_required else " (optional)"
-            field_descriptions.append(f"- {field_name} ({field_type}){req_marker}: {field_desc}")
-        fields_text = "\n".join(field_descriptions)
-
         # Call LLM with the answer to extract structured data
-        structured_prompt = f"""Your task is to extract specific information from the answer below and format it as JSON.
+        structured_prompt = f"""Based on this answer, extract the information into the requested structured format.
 
-ANSWER TO EXTRACT FROM:
-\"\"\"
-{answer}
-\"\"\"
+Answer: {answer}
 
-REQUIRED OUTPUT FORMAT - Extract the following fields from the answer above:
-{fields_text}
-
-JSON Schema:
+JSON Schema to follow:
 ```json
 {schema_str}
 ```
 
-INSTRUCTIONS:
-1. Read the answer carefully and identify the information that matches each field
-2. Extract the ACTUAL content from the answer - do NOT leave fields empty if information is present
-3. For string fields: use the exact text or a clear summary from the answer
-4. For array fields: return a JSON array (e.g., ["item1", "item2"]), NOT a string
-5. For required fields: you MUST provide a value extracted from the answer
-6. Return ONLY the JSON object, no explanation
+Return ONLY a valid JSON object that matches this exact schema. Pay special attention to field types:
+- "type": "array" means the value must be a JSON array/list, NOT a string
+- "type": "string" means the value must be a string
+- "type": "object" means the value must be a JSON object
 
-OUTPUT:"""
+Do not include any explanation, only the JSON object."""
 
         structured_result, usage = await llm_config.call(
             messages=[
                 {
                     "role": "system",
-                    "content": "You are a precise data extraction assistant. Extract information from text and return it as valid JSON matching the provided schema. Always extract actual content - never return empty strings for required fields if information is available.",
+                    "content": "Extract structured data from the given answer. Return only valid JSON matching the provided schema exactly.",
                 },
                 {"role": "user", "content": structured_prompt},
             ],
@@ -253,12 +189,6 @@ OUTPUT:"""
             # Try to parse as JSON
             structured_output = json.loads(str(structured_result))
 
-        # Validate that required fields have non-empty values
-        for field_name in required_fields:
-            value = structured_output.get(field_name)
-            if value is None or value == "" or value == []:
-                logger.warning(f"[REFLECT {reflect_id}] Required field '{field_name}' is empty in structured output")
-
         logger.info(f"[REFLECT {reflect_id}] Generated structured output with {len(structured_output)} fields")
         return structured_output, usage.input_tokens, usage.output_tokens
 
@@ -272,8 +202,8 @@ async def run_reflect_agent(
     bank_id: str,
     query: str,
     bank_profile: dict[str, Any],
+    search_reflections_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     search_mental_models_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
-    search_observations_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     recall_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     expand_fn: Callable[[list[str], str], Awaitable[dict[str, Any]]],
     context: str | None = None,
@@ -281,15 +211,13 @@ async def run_reflect_agent(
     max_tokens: int | None = None,
     response_schema: dict | None = None,
     directives: list[dict[str, Any]] | None = None,
-    has_mental_models: bool = False,
-    budget: str | None = None,
 ) -> ReflectAgentResult:
     """
     Execute the reflect agent loop using native tool calling.
 
     The agent uses hierarchical retrieval:
-    1. search_mental_models - User-curated summaries (try first)
-    2. search_observations - Consolidated knowledge with freshness
+    1. search_reflections - User-curated summaries (try first)
+    2. search_mental_models - Consolidated knowledge with freshness
     3. recall - Raw facts as ground truth
 
     Args:
@@ -297,8 +225,8 @@ async def run_reflect_agent(
         bank_id: Bank identifier
         query: Question to answer
         bank_profile: Bank profile with name and mission
+        search_reflections_fn: Tool callback for searching reflections (query, max_results) -> result
         search_mental_models_fn: Tool callback for searching mental models (query, max_results) -> result
-        search_observations_fn: Tool callback for searching observations (query, max_results) -> result
         recall_fn: Tool callback for recall (query, max_tokens) -> result
         expand_fn: Tool callback for expand (memory_ids, depth) -> result
         context: Optional additional context
@@ -323,9 +251,7 @@ async def run_reflect_agent(
     tools = get_reflect_tools(directive_rules=directive_rules)
 
     # Build initial messages (directives are injected into system prompt at START and END)
-    system_prompt = build_system_prompt_for_tools(
-        bank_profile, context, directives=directives, has_mental_models=has_mental_models, budget=budget
-    )
+    system_prompt = build_system_prompt_for_tools(bank_profile, context, directives=directives)
     messages: list[dict[str, Any]] = [
         {"role": "system", "content": system_prompt},
         {"role": "user", "content": query},
@@ -344,8 +270,8 @@ async def run_reflect_agent(
 
     # Track available IDs for validation (prevents hallucinated citations)
     available_memory_ids: set[str] = set()
+    available_reflection_ids: set[str] = set()
     available_mental_model_ids: set[str] = set()
-    available_observation_ids: set[str] = set()
 
     def _get_llm_trace() -> list[LLMCall]:
         return [
@@ -468,7 +394,7 @@ async def run_reflect_agent(
             llm_trace.append({"scope": f"agent_{iteration + 1}_err", "duration_ms": err_duration})
             # Guardrail: If no evidence gathered yet, retry
             has_gathered_evidence = (
-                bool(available_memory_ids) or bool(available_mental_model_ids) or bool(available_observation_ids)
+                bool(available_memory_ids) or bool(available_reflection_ids) or bool(available_mental_model_ids)
             )
             if not has_gathered_evidence and iteration < max_iterations - 1:
                 continue
@@ -593,7 +519,7 @@ async def run_reflect_agent(
         if done_call:
             # Guardrail: Require evidence before done
             has_gathered_evidence = (
-                bool(available_memory_ids) or bool(available_mental_model_ids) or bool(available_observation_ids)
+                bool(available_memory_ids) or bool(available_reflection_ids) or bool(available_mental_model_ids)
             )
             if not has_gathered_evidence and iteration < max_iterations - 1:
                 # Add assistant message and fake tool result asking for evidence
@@ -610,7 +536,7 @@ async def run_reflect_agent(
                         "name": done_call.name,  # Required by Gemini
                         "content": json.dumps(
                             {
-                                "error": "You must search for information first. Use search_mental_models(), search_observations(), or recall() before providing your final answer."
+                                "error": "You must search for information first. Use search_reflections(), search_mental_models(), or recall() before providing your final answer."
                             }
                         ),
                     }
@@ -621,8 +547,8 @@ async def run_reflect_agent(
             return await _process_done_tool(
                 done_call,
                 available_memory_ids,
+                available_reflection_ids,
                 available_mental_model_ids,
-                available_observation_ids,
                 iteration + 1,
                 total_tools_called,
                 tool_trace,
@@ -650,8 +576,8 @@ async def run_reflect_agent(
             tool_tasks = [
                 _execute_tool_with_timing(
                     tc,
+                    search_reflections_fn,
                     search_mental_models_fn,
-                    search_observations_fn,
                     recall_fn,
                     expand_fn,
                 )
@@ -680,6 +606,15 @@ async def run_reflect_agent(
                     )
 
                 # Track available IDs from tool results (only for successful responses)
+                if (
+                    normalized_tool_name == "search_reflections"
+                    and isinstance(output, dict)
+                    and "reflections" in output
+                ):
+                    for reflection in output["reflections"]:
+                        if "id" in reflection:
+                            available_reflection_ids.add(reflection["id"])
+
                 if (
                     normalized_tool_name == "search_mental_models"
                     and isinstance(output, dict)
@@ -689,15 +624,6 @@ async def run_reflect_agent(
                         if "id" in mm:
                             available_mental_model_ids.add(mm["id"])
 
-                if (
-                    normalized_tool_name == "search_observations"
-                    and isinstance(output, dict)
-                    and "observations" in output
-                ):
-                    for obs in output["observations"]:
-                        if "id" in obs:
-                            available_observation_ids.add(obs["id"])
-
                 if normalized_tool_name == "recall" and isinstance(output, dict) and "memories" in output:
                     for memory in output["memories"]:
                         if "id" in memory:
@@ -717,17 +643,9 @@ async def run_reflect_agent(
                 input_dict = {"tool": tc.name, **tc.arguments}
                 input_summary = _summarize_input(tc.name, tc.arguments)
 
-                # Extract reason from tool arguments (if provided)
-                tool_reason = tc.arguments.get("reason")
-
                 tool_trace.append(
                     ToolCall(
-                        tool=tc.name,
-                        reason=tool_reason,
-                        input=input_dict,
-                        output=output,
-                        duration_ms=duration_ms,
-                        iteration=iteration + 1,
+                        tool=tc.name, input=input_dict, output=output, duration_ms=duration_ms, iteration=iteration + 1
                     )
                 )
 
@@ -777,8 +695,8 @@ def _tool_call_to_dict(tc: "LLMToolCall") -> dict[str, Any]:
 async def _process_done_tool(
     done_call: "LLMToolCall",
     available_memory_ids: set[str],
+    available_reflection_ids: set[str],
     available_mental_model_ids: set[str],
-    available_observation_ids: set[str],
     iterations: int,
     total_tools_called: int,
     tool_trace: list[ToolCall],
@@ -793,16 +711,14 @@ async def _process_done_tool(
     """Process the done tool call and return the result."""
     args = done_call.arguments
 
-    # Extract and clean the answer - some LLMs leak structured output into the answer text
-    raw_answer = args.get("answer", "").strip()
-    answer = _clean_done_answer(raw_answer) if raw_answer else ""
+    answer = args.get("answer", "").strip()
     if not answer:
         answer = "No answer provided."
 
     # Validate IDs (only include IDs that were actually retrieved)
     used_memory_ids = [mid for mid in args.get("memory_ids", []) if mid in available_memory_ids]
+    used_reflection_ids = [rid for rid in args.get("reflection_ids", []) if rid in available_reflection_ids]
     used_mental_model_ids = [mid for mid in args.get("mental_model_ids", []) if mid in available_mental_model_ids]
-    used_observation_ids = [oid for oid in args.get("observation_ids", []) if oid in available_observation_ids]
 
     # Generate structured output if schema provided
     structured_output = None
@@ -828,16 +744,16 @@ async def _process_done_tool(
         llm_trace=llm_trace,
         usage=final_usage,
         used_memory_ids=used_memory_ids,
+        used_reflection_ids=used_reflection_ids,
         used_mental_model_ids=used_mental_model_ids,
-        used_observation_ids=used_observation_ids,
         directives_applied=directives_applied,
     )
 
 
 async def _execute_tool_with_timing(
     tc: "LLMToolCall",
+    search_reflections_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     search_mental_models_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
-    search_observations_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     recall_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     expand_fn: Callable[[list[str], str], Awaitable[dict[str, Any]]],
 ) -> tuple[dict[str, Any], int]:
@@ -846,8 +762,8 @@ async def _execute_tool_with_timing(
     result = await _execute_tool(
         tc.name,
         tc.arguments,
+        search_reflections_fn,
         search_mental_models_fn,
-        search_observations_fn,
         recall_fn,
         expand_fn,
     )
@@ -858,8 +774,8 @@ async def _execute_tool_with_timing(
 async def _execute_tool(
     tool_name: str,
     args: dict[str, Any],
+    search_reflections_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     search_mental_models_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
-    search_observations_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     recall_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
     expand_fn: Callable[[list[str], str], Awaitable[dict[str, Any]]],
 ) -> dict[str, Any]:
@@ -867,19 +783,19 @@ async def _execute_tool(
     # Normalize tool name for various LLM output formats
     tool_name = _normalize_tool_name(tool_name)
 
-    if tool_name == "search_mental_models":
+    if tool_name == "search_reflections":
+        query = args.get("query")
+        if not query:
+            return {"error": "search_reflections requires a query parameter"}
+        max_results = args.get("max_results") or 5
+        return await search_reflections_fn(query, max_results)
+
+    elif tool_name == "search_mental_models":
         query = args.get("query")
         if not query:
             return {"error": "search_mental_models requires a query parameter"}
-        max_results = args.get("max_results") or 5
-        return await search_mental_models_fn(query, max_results)
-
-    elif tool_name == "search_observations":
-        query = args.get("query")
-        if not query:
-            return {"error": "search_observations requires a query parameter"}
         max_tokens = max(args.get("max_tokens") or 5000, 1000)  # Default 5000, min 1000
-        return await search_observations_fn(query, max_tokens)
+        return await search_mental_models_fn(query, max_tokens)
 
     elif tool_name == "recall":
         query = args.get("query")
@@ -901,12 +817,12 @@ async def _execute_tool(
 
 def _summarize_input(tool_name: str, args: dict[str, Any]) -> str:
     """Create a summary of tool input for logging, showing all params."""
-    if tool_name == "search_mental_models":
+    if tool_name == "search_reflections":
         query = args.get("query", "")
         query_preview = f"'{query[:30]}...'" if len(query) > 30 else f"'{query}'"
         max_results = args.get("max_results") or 5
         return f"(query={query_preview}, max_results={max_results})"
-    elif tool_name == "search_observations":
+    elif tool_name == "search_mental_models":
         query = args.get("query", "")
         query_preview = f"'{query[:30]}...'" if len(query) > 30 else f"'{query}'"
         max_tokens = max(args.get("max_tokens") or 5000, 1000)
@@ -925,9 +841,9 @@ def _summarize_input(tool_name: str, args: dict[str, Any]) -> str:
         answer = args.get("answer", "")
         answer_preview = f"'{answer[:30]}...'" if len(answer) > 30 else f"'{answer}'"
         memory_ids = args.get("memory_ids", [])
+        reflection_ids = args.get("reflection_ids", [])
         mental_model_ids = args.get("mental_model_ids", [])
-        observation_ids = args.get("observation_ids", [])
         return (
-            f"(answer={answer_preview}, mem={len(memory_ids)}, mm={len(mental_model_ids)}, obs={len(observation_ids)})"
+            f"(answer={answer_preview}, mem={len(memory_ids)}, ref={len(reflection_ids)}, mm={len(mental_model_ids)})"
         )
     return str(args)

hindsight-api/hindsight_api/engine/reflect/models.py

@@ -7,28 +7,51 @@ from typing import Any, Literal
 from pydantic import BaseModel, Field
 
 
-class ObservationSection(BaseModel):
-    """A section within an observation with its supporting memories."""
+class MentalModelObservation(BaseModel):
+    """An observation within a mental model with its supporting memories."""
 
-    title: str = Field(description="Section header (can be empty for intro)")
-    text: str = Field(description="Section content - no headers, use lists/tables/bold")
+    title: str = Field(description="Observation header (can be empty for intro)")
+    text: str = Field(description="Observation content - no headers, use lists/tables/bold")
+    memory_ids: list[str] = Field(default_factory=list, description="Memory IDs supporting this observation")
+
+
+class MentalModelInput(BaseModel):
+    """Input for the learn tool to create a mental model placeholder.
+
+    The agent only specifies name and description - the actual content/observations
+    are generated during refresh, similar to pinned models.
+    """
+
+    name: str = Field(description="Human-readable name for the mental model")
+    description: str = Field(description="What to track - used as prompt for content generation during refresh")
+    entity_id: str | None = Field(default=None, description="Optional link to existing entity ID")
+
+
+class AnswerSection(BaseModel):
+    """A section of the answer with its supporting evidence (DEPRECATED)."""
+
+    title: str = Field(description="Section header/title")
+    text: str = Field(description="Section content")
     memory_ids: list[str] = Field(default_factory=list, description="Memory IDs supporting this section")
+    model_ids: list[str] = Field(default_factory=list, description="Mental model IDs supporting this section")
 
 
 class ReflectAction(BaseModel):
     """Single action the reflect agent can take."""
 
-    tool: Literal["list_observations", "get_observation", "recall", "expand", "done"] = Field(
-        description="Tool to invoke: list_observations, get_observation, recall, expand, or done"
+    tool: Literal["list_mental_models", "get_mental_model", "recall", "learn", "expand", "done"] = Field(
+        description="Tool to invoke: list_mental_models, get_mental_model, recall, learn, expand, or done"
     )
     # Tool-specific parameters
-    observation_id: str | None = Field(default=None, description="Observation ID for get_observation")
+    model_id: str | None = Field(default=None, description="Mental model ID for get_mental_model")
     query: str | None = Field(default=None, description="Search query for recall")
     max_tokens: int | None = Field(default=None, description="Max tokens for recall results (default 2048)")
+    mental_model: MentalModelInput | None = Field(default=None, description="Mental model to create/update for learn")
     memory_ids: list[str] | None = Field(default=None, description="Memory unit IDs for expand (batched)")
     depth: Literal["chunk", "document"] | None = Field(default=None, description="Expansion depth for expand")
-    observation_sections: list[ObservationSection] | None = Field(
-        default=None, description="Observation sections for done action (when output_mode=observations)"
+    sections: list[AnswerSection] | None = Field(default=None, description="DEPRECATED: Use answer field instead")
+    observations: list[MentalModelObservation] | None = Field(
+        default=None, description="Observations for done action (when output_mode=observations)"
     )
     # Plain text answer fields (for output_mode=answer)
     answer: str | None = Field(default=None, description="Plain text answer for done action (no markdown)")
@@ -50,8 +73,7 @@ class ReflectActionBatch(BaseModel):
 class ToolCall(BaseModel):
     """A single tool call made during reflect."""
 
-    tool: str = Field(description="Tool name: lookup, recall, expand")
-    reason: str | None = Field(default=None, description="Agent's reasoning for making this tool call")
+    tool: str = Field(description="Tool name: lookup, recall, learn, expand")
     input: dict = Field(description="Tool input parameters")
     output: dict = Field(description="Tool output/result")
     duration_ms: int = Field(description="Execution time in milliseconds")
@@ -72,7 +94,7 @@ class DirectiveInfo(BaseModel):
 
     id: str = Field(description="Directive mental model ID")
     name: str = Field(description="Directive name")
-    content: str = Field(description="Directive content")
+    rules: list[str] = Field(default_factory=list, description="Directive rules/observations that were applied")
 
 
 class TokenUsageSummary(BaseModel):
@@ -98,12 +120,12 @@ class ReflectAgentResult(BaseModel):
         default_factory=TokenUsageSummary, description="Total token usage across all LLM calls"
     )
     used_memory_ids: list[str] = Field(default_factory=list, description="Validated memory IDs actually used in answer")
+    used_reflection_ids: list[str] = Field(
+        default_factory=list, description="Validated reflection IDs actually used in answer"
+    )
     used_mental_model_ids: list[str] = Field(
         default_factory=list, description="Validated mental model IDs actually used in answer"
     )
-    used_observation_ids: list[str] = Field(
-        default_factory=list, description="Validated observation IDs actually used in answer"
-    )
     directives_applied: list[DirectiveInfo] = Field(
         default_factory=list, description="Directive mental models that affected this reflection"
     )

hindsight-api/hindsight_api/engine/reflect/prompts.py

@@ -2,8 +2,8 @@
 System prompts for the reflect agent.
 
 The reflect agent uses hierarchical retrieval:
-1. search_mental_models - User-curated summaries (highest quality)
-2. search_observations - Consolidated knowledge with freshness awareness
+1. search_reflections - User-curated summaries (highest quality)
+2. search_mental_models - Consolidated knowledge with freshness awareness
 3. recall - Raw facts as ground truth fallback
 """
 
@@ -125,23 +125,21 @@ def build_system_prompt_for_tools(
     bank_profile: dict[str, Any],
     context: str | None = None,
     directives: list[dict[str, Any]] | None = None,
-    has_mental_models: bool = False,
-    budget: str | None = None,
+    has_reflections: bool = False,
 ) -> str:
     """
     Build the system prompt for tool-calling reflect agent.
 
     The agent uses hierarchical retrieval:
-    1. search_mental_models - User-curated summaries (try first, if available)
-    2. search_observations - Consolidated knowledge with freshness
+    1. search_reflections - User-curated summaries (try first, if available)
+    2. search_mental_models - Consolidated knowledge with freshness
     3. recall - Raw facts as ground truth
 
     Args:
         bank_profile: Bank profile with name and mission
         context: Optional additional context
         directives: Optional list of directive mental models to inject as hard rules
-        has_mental_models: Whether the bank has any mental models (skip if not)
-        budget: Search depth budget - "low", "mid", or "high". Controls exploration thoroughness.
+        has_reflections: Whether the bank has any reflections (skip if not)
     """
     name = bank_profile.get("name", "Assistant")
     mission = bank_profile.get("mission", "")
@@ -178,25 +176,25 @@ def build_system_prompt_for_tools(
     )
 
     # Build retrieval levels based on what's available
-    if has_mental_models:
+    if has_reflections:
         parts.extend(
             [
                 "You have access to THREE levels of knowledge. Use them in this order:",
                 "",
-                "### 1. MENTAL MODELS (search_mental_models) - Try First",
+                "### 1. REFLECTIONS (search_reflections) - Try First",
                 "- User-curated summaries about specific topics",
                 "- HIGHEST quality - manually created and maintained",
-                "- If a relevant mental model exists and is FRESH, it may fully answer the question",
+                "- If a relevant reflection exists and is FRESH, it may fully answer the question",
                 "- Check `is_stale` field - if stale, also verify with lower levels",
                 "",
-                "### 2. OBSERVATIONS (search_observations) - Second Priority",
+                "### 2. MENTAL MODELS (search_mental_models) - Second Priority",
                 "- Auto-consolidated knowledge from memories",
                 "- Check `is_stale` field - if stale, ALSO use recall() to verify",
                 "- Good for understanding patterns and summaries",
                 "",
                 "### 3. RAW FACTS (recall) - Ground Truth",
                 "- Individual memories (world facts and experiences)",
-                "- Use when: no mental models/observations exist, they're stale, or you need specific details",
+                "- Use when: no reflections/models exist, they're stale, or you need specific details",
                 "- This is the source of truth that other levels are built from",
                 "",
             ]
@@ -206,15 +204,15 @@ def build_system_prompt_for_tools(
             [
                 "You have access to TWO levels of knowledge. Use them in this order:",
                 "",
-                "### 1. OBSERVATIONS (search_observations) - Try First",
+                "### 1. MENTAL MODELS (search_mental_models) - Try First",
                 "- Auto-consolidated knowledge from memories",
                 "- Check `is_stale` field - if stale, ALSO use recall() to verify",
                 "- Good for understanding patterns and summaries",
                 "",
                 "### 2. RAW FACTS (recall) - Ground Truth",
                 "- Individual memories (world facts and experiences)",
-                "- Use when: no observations exist, they're stale, or you need specific details",
-                "- This is the source of truth that observations are built from",
+                "- Use when: no mental models exist, they're stale, or you need specific details",
+                "- This is the source of truth that mental models are built from",
                 "",
             ]
         )
@@ -232,57 +230,16 @@ def build_system_prompt_for_tools(
             "",
             "Think: What ENTITIES and CONCEPTS does this question involve? Search for each separately.",
             "",
+            "## Workflow",
         ]
     )
 
-    # Add budget guidance
-    if budget:
-        budget_lower = budget.lower()
-        if budget_lower == "low":
-            parts.extend(
-                [
-                    "## RESEARCH DEPTH: SHALLOW (Quick Response)",
-                    "- Prioritize speed over completeness",
-                    "- If mental models or observations provide a reasonable answer, stop there",
-                    "- Only dig deeper if the initial results are clearly insufficient",
-                    "- Prefer a quick overview rather than exhaustive details",
-                    "- Answer promptly with available information",
-                    "",
-                ]
-            )
-        elif budget_lower == "mid":
-            parts.extend(
-                [
-                    "## RESEARCH DEPTH: MODERATE (Balanced)",
-                    "- Balance thoroughness with efficiency",
-                    "- Check multiple sources when the question warrants it",
-                    "- Verify stale data if it's central to the answer",
-                    "- Don't over-explore, but ensure reasonable coverage",
-                    "",
-                ]
-            )
-        elif budget_lower == "high":
-            parts.extend(
-                [
-                    "## RESEARCH DEPTH: DEEP (Thorough Exploration)",
-                    "- Explore comprehensively before answering",
-                    "- Search across all available knowledge levels",
-                    "- Use multiple query variations to ensure coverage",
-                    "- Verify information across different retrieval levels",
-                    "- Use expand() to get full context on important memories",
-                    "- Take time to synthesize a complete, well-researched answer",
-                    "",
-                ]
-            )
-
-    parts.append("## Workflow")
-
-    if has_mental_models:
+    if has_reflections:
         parts.extend(
             [
-                "1. First, try search_mental_models() - check if a curated summary exists",
-                "2. If no mental model or it's stale, try search_observations() for consolidated knowledge",
-                "3. If observations are stale OR you need specific details, use recall() for raw facts",
+                "1. First, try search_reflections() - check if a curated summary exists",
+                "2. If no reflection or it's stale, try search_mental_models() for consolidated knowledge",
+                "3. If mental models are stale OR you need specific details, use recall() for raw facts",
                 "4. Use expand() if you need more context on specific memories",
                 "5. When ready, call done() with your answer and supporting IDs",
             ]
@@ -290,8 +247,8 @@ def build_system_prompt_for_tools(
     else:
         parts.extend(
             [
-                "1. First, try search_observations() - check for consolidated knowledge",
-                "2. If observations are stale OR you need specific details, use recall() for raw facts",
+                "1. First, try search_mental_models() - check for consolidated knowledge",
+                "2. If mental models are stale OR you need specific details, use recall() for raw facts",
                 "3. Use expand() if you need more context on specific memories",
                 "4. When ready, call done() with your answer and supporting IDs",
             ]
@@ -304,7 +261,7 @@ def build_system_prompt_for_tools(
             "Call done() with a plain text 'answer' field.",
             "- Do NOT use markdown formatting",
             "- NEVER include memory IDs, UUIDs, or 'Memory references' in the answer text",
-            "- Put IDs ONLY in the memory_ids/mental_model_ids/observation_ids arrays, not in the answer",
+            "- Put IDs ONLY in the memory_ids/reflection_ids/mental_model_ids arrays, not in the answer",
         ]
     )
 
@@ -399,8 +356,8 @@ def build_agent_prompt(
         parts.append(
             "\n## Instructions\n"
             "Start by searching for relevant information using the hierarchical retrieval strategy:\n"
-            "1. Try search_mental_models() first for curated summaries\n"
-            "2. Try search_observations() for consolidated knowledge\n"
+            "1. Try search_reflections() first for curated summaries\n"
+            "2. Try search_mental_models() for consolidated knowledge\n"
             "3. Use recall() for specific details or to verify stale data"
         )
 

hindsight-api/hindsight_api/engine/reflect/tools.py

@@ -2,8 +2,8 @@
 Tool implementations for the reflect agent.
 
 Implements hierarchical retrieval:
-1. search_mental_models - User-curated stored reflect responses (highest quality)
-2. search_observations - Consolidated knowledge with freshness
+1. search_reflections - User-curated summaries (highest quality)
+2. search_mental_models - Consolidated knowledge with freshness
 3. recall - Raw facts as ground truth
 """
 
@@ -20,11 +20,11 @@ if TYPE_CHECKING:
 
 logger = logging.getLogger(__name__)
 
-# Observation is considered stale if not updated in this many days
+# Mental model is considered stale if not updated in this many days
 STALE_THRESHOLD_DAYS = 7
 
 
-async def tool_search_mental_models(
+async def tool_search_reflections(
     conn: "Connection",
     bank_id: str,
     query: str,
@@ -35,9 +35,9 @@ async def tool_search_mental_models(
     exclude_ids: list[str] | None = None,
 ) -> dict[str, Any]:
     """
-    Search user-curated mental models by semantic similarity.
+    Search user-curated reflections by semantic similarity.
 
-    Mental models are high-quality, manually created summaries about specific topics.
+    Reflections are high-quality, manually created summaries about specific topics.
     They should be searched FIRST as they represent the most reliable synthesized knowledge.
 
     Args:
@@ -45,13 +45,13 @@ async def tool_search_mental_models(
         bank_id: Bank identifier
         query: Search query (for logging/tracing)
         query_embedding: Pre-computed embedding for semantic search
-        max_results: Maximum number of mental models to return
-        tags: Optional tags to filter mental models
+        max_results: Maximum number of reflections to return
+        tags: Optional tags to filter reflections
         tags_match: How to match tags - "any" (OR), "all" (AND)
-        exclude_ids: Optional list of mental model IDs to exclude (e.g., when refreshing a mental model)
+        exclude_ids: Optional list of reflection IDs to exclude (e.g., when refreshing a reflection)
 
     Returns:
-        Dict with matching mental models including content and freshness info
+        Dict with matching reflections including content and freshness info
     """
     from ..memory_engine import fq_table
 
@@ -69,18 +69,18 @@ async def tool_search_mental_models(
         next_param += 1
 
     if exclude_ids:
-        filters += f" AND id != ALL(${next_param}::text[])"
+        filters += f" AND id != ALL(${next_param}::uuid[])"
         params.append(exclude_ids)
         next_param += 1
 
-    # Search mental models by embedding similarity
+    # Search reflections by embedding similarity
     rows = await conn.fetch(
         f"""
         SELECT
-            id, name, content,
+            id, name, content, reflect_response,
             tags, created_at, last_refreshed_at,
             1 - (embedding <=> $2::vector) as relevance
-        FROM {fq_table("mental_models")}
+        FROM {fq_table("reflections")}
         WHERE bank_id = $1 AND embedding IS NOT NULL {filters}
         ORDER BY embedding <=> $2::vector
         LIMIT $3
@@ -89,7 +89,7 @@ async def tool_search_mental_models(
     )
 
     now = datetime.now(timezone.utc)
-    mental_models = []
+    reflections = []
 
     for row in rows:
         last_refreshed_at = row["last_refreshed_at"]
@@ -102,11 +102,12 @@ async def tool_search_mental_models(
             age = now - last_refreshed_at
             is_stale = age > timedelta(days=STALE_THRESHOLD_DAYS)
 
-        mental_models.append(
+        reflections.append(
             {
                 "id": str(row["id"]),
                 "name": row["name"],
                 "content": row["content"],
+                "reflect_response": row["reflect_response"],
                 "tags": row["tags"] or [],
                 "relevance": round(row["relevance"], 4),
                 "updated_at": last_refreshed_at.isoformat() if last_refreshed_at else None,
@@ -116,12 +117,12 @@ async def tool_search_mental_models(
 
     return {
         "query": query,
-        "count": len(mental_models),
-        "mental_models": mental_models,
+        "count": len(reflections),
+        "reflections": reflections,
     }
 
 
-async def tool_search_observations(
+async def tool_search_mental_models(
     memory_engine: "MemoryEngine",
     bank_id: str,
     query: str,
@@ -133,9 +134,9 @@ async def tool_search_observations(
     pending_consolidation: int = 0,
 ) -> dict[str, Any]:
     """
-    Search consolidated observations using recall with include_observations.
+    Search consolidated mental models using recall with include_mental_models.
 
-    Observations are auto-generated from memories. Returns freshness info
+    Mental models are auto-generated from memories. Returns freshness info
     so the agent knows if it should also verify with recall().
 
     Args:
@@ -144,22 +145,22 @@ async def tool_search_observations(
         query: Search query
         request_context: Request context for authentication
         max_tokens: Maximum tokens for results (default 5000)
-        tags: Optional tags to filter observations
+        tags: Optional tags to filter models
         tags_match: How to match tags - "any" (OR), "all" (AND)
         last_consolidated_at: When consolidation last ran (for staleness check)
         pending_consolidation: Number of memories waiting to be consolidated
 
     Returns:
-        Dict with matching observations including freshness info
+        Dict with matching mental models including freshness info
     """
     from ..memory_engine import fq_table
 
-    # Use recall to search observations (they come back in results field when fact_type=["observation"])
+    # Use recall to search mental models (they come back in results field when fact_type=["mental_model"])
     result = await memory_engine.recall_async(
         bank_id=bank_id,
         query=query,
-        fact_type=["observation"],  # Only retrieve observations
-        max_tokens=max_tokens,  # Token budget controls how many observations are returned
+        fact_type=["mental_model"],  # Only retrieve mental models
+        max_tokens=max_tokens,  # Token budget controls how many mental models are returned
         enable_trace=False,
         request_context=request_context,
         tags=tags,
@@ -168,29 +169,29 @@ async def tool_search_observations(
         _quiet=True,
     )
 
-    observations = []
+    mental_models = []
 
-    # When fact_type=["observation"], results come back in `results` field as MemoryFact objects
+    # When fact_type=["mental_model"], results come back in `results` field as MemoryFact objects
     # We need to fetch additional fields (proof_count, source_memory_ids) from the database
     if result.results:
-        obs_ids = [m.id for m in result.results]
+        mm_ids = [m.id for m in result.results]
 
-        # Fetch proof_count and source_memory_ids for these observations
+        # Fetch proof_count and source_memory_ids for these mental models
         pool = await memory_engine._get_pool()
         async with pool.acquire() as conn:
-            obs_rows = await conn.fetch(
+            mm_rows = await conn.fetch(
                 f"""
                 SELECT id, proof_count, source_memory_ids
                 FROM {fq_table("memory_units")}
                 WHERE id = ANY($1::uuid[])
                 """,
-                obs_ids,
+                mm_ids,
             )
-            obs_data = {str(row["id"]): row for row in obs_rows}
+            mm_data = {str(row["id"]): row for row in mm_rows}
 
         for m in result.results:
             # Get additional data from DB lookup
-            extra = obs_data.get(m.id, {})
+            extra = mm_data.get(m.id, {})
             proof_count = extra.get("proof_count", 1) if extra else 1
             source_ids = extra.get("source_memory_ids", []) if extra else []
             # Convert UUIDs to strings
@@ -203,7 +204,7 @@ async def tool_search_observations(
                 is_stale = True
                 staleness_reason = f"{pending_consolidation} memories pending consolidation"
 
-            observations.append(
+            mental_models.append(
                 {
                     "id": str(m.id),
                     "text": m.text,
@@ -225,8 +226,8 @@ async def tool_search_observations(
 
     return {
         "query": query,
-        "count": len(observations),
-        "observations": observations,
+        "count": len(mental_models),
+        "mental_models": mental_models,
         "freshness": freshness,
     }
 
@@ -246,7 +247,7 @@ async def tool_recall(
     Search memories using TEMPR retrieval.
 
     This is the ground truth - raw facts and experiences.
-    Use when mental models/observations don't exist, are stale, or need verification.
+    Use when reflections/mental models don't exist, are stale, or need verification.
 
     Args:
         memory_engine: Memory engine instance
@@ -265,7 +266,7 @@ async def tool_recall(
     result = await memory_engine.recall_async(
         bank_id=bank_id,
         query=query,
-        fact_type=["experience", "world"],  # Exclude opinions and observations
+        fact_type=["experience", "world"],  # Exclude opinions and mental_models
         max_tokens=max_tokens,
         enable_trace=False,
         request_context=request_context,

hindsight-api/hindsight_api/engine/reflect/tools_schema.py

@@ -3,69 +3,61 @@ Tool schema definitions for the reflect agent.
 
 These are OpenAI-format tool definitions used with native tool calling.
 The reflect agent uses a hierarchical retrieval strategy:
-1. search_mental_models - User-curated stored reflect responses (highest quality, if applicable)
-2. search_observations - Consolidated knowledge with freshness awareness
+1. search_reflections - User-curated summaries (highest quality, if applicable)
+2. search_mental_models - Consolidated knowledge with freshness awareness
 3. recall - Raw facts (world/experience) as ground truth fallback
 """
 
 # Tool definitions in OpenAI format
 
+TOOL_SEARCH_REFLECTIONS = {
+    "type": "function",
+    "function": {
+        "name": "search_reflections",
+        "description": (
+            "Search user-curated reflections (summaries). These are high-quality, manually created "
+            "summaries about specific topics. Use FIRST when the question might be covered by an "
+            "existing reflection. Returns reflections with their content and last refresh time."
+        ),
+        "parameters": {
+            "type": "object",
+            "properties": {
+                "query": {
+                    "type": "string",
+                    "description": "Search query to find relevant reflections",
+                },
+                "max_results": {
+                    "type": "integer",
+                    "description": "Maximum number of reflections to return (default 5)",
+                },
+            },
+            "required": ["query"],
+        },
+    },
+}
+
 TOOL_SEARCH_MENTAL_MODELS = {
     "type": "function",
     "function": {
         "name": "search_mental_models",
         "description": (
-            "Search user-curated mental models (stored reflect responses). These are high-quality, manually created "
-            "summaries about specific topics. Use FIRST when the question might be covered by an "
-            "existing mental model. Returns mental models with their content and last refresh time."
+            "Search consolidated mental models (auto-generated knowledge). These are automatically "
+            "synthesized from memories. Returns models with freshness info (updated_at, is_stale). "
+            "If a model is STALE, you should ALSO use recall() to verify with current facts."
         ),
         "parameters": {
             "type": "object",
             "properties": {
-                "reason": {
-                    "type": "string",
-                    "description": "Brief explanation of why you're making this search (for debugging)",
-                },
                 "query": {
                     "type": "string",
                     "description": "Search query to find relevant mental models",
                 },
-                "max_results": {
-                    "type": "integer",
-                    "description": "Maximum number of mental models to return (default 5)",
-                },
-            },
-            "required": ["reason", "query"],
-        },
-    },
-}
-
-TOOL_SEARCH_OBSERVATIONS = {
-    "type": "function",
-    "function": {
-        "name": "search_observations",
-        "description": (
-            "Search consolidated observations (auto-generated knowledge). These are automatically "
-            "synthesized from memories. Returns observations with freshness info (updated_at, is_stale). "
-            "If an observation is STALE, you should ALSO use recall() to verify with current facts."
-        ),
-        "parameters": {
-            "type": "object",
-            "properties": {
-                "reason": {
-                    "type": "string",
-                    "description": "Brief explanation of why you're making this search (for debugging)",
-                },
-                "query": {
-                    "type": "string",
-                    "description": "Search query to find relevant observations",
-                },
                 "max_tokens": {
                     "type": "integer",
                     "description": "Maximum tokens for results (default 5000). Use higher values for broader searches.",
                 },
             },
-            "required": ["reason", "query"],
+            "required": ["query"],
         },
     },
 }
@@ -83,10 +75,6 @@ TOOL_RECALL = {
         "parameters": {
             "type": "object",
             "properties": {
-                "reason": {
-                    "type": "string",
-                    "description": "Brief explanation of why you're making this search (for debugging)",
-                },
                 "query": {
                     "type": "string",
                     "description": "Search query string",
@@ -96,7 +84,7 @@ TOOL_RECALL = {
                     "description": "Optional limit on result size (default 2048). Use higher values for broader searches.",
                 },
             },
-            "required": ["reason", "query"],
+            "required": ["query"],
         },
     },
 }
@@ -109,10 +97,6 @@ TOOL_EXPAND = {
         "parameters": {
             "type": "object",
             "properties": {
-                "reason": {
-                    "type": "string",
-                    "description": "Brief explanation of why you need more context (for debugging)",
-                },
                 "memory_ids": {
                     "type": "array",
                     "items": {"type": "string"},
@@ -124,7 +108,7 @@ TOOL_EXPAND = {
                     "description": "chunk: surrounding text chunk, document: full source document",
                 },
             },
-            "required": ["reason", "memory_ids", "depth"],
+            "required": ["memory_ids", "depth"],
         },
     },
 }
@@ -146,16 +130,16 @@ TOOL_DONE_ANSWER = {
                     "items": {"type": "string"},
                     "description": "Array of memory IDs that support your answer (put IDs here, NOT in answer text)",
                 },
+                "reflection_ids": {
+                    "type": "array",
+                    "items": {"type": "string"},
+                    "description": "Array of reflection IDs that support your answer",
+                },
                 "mental_model_ids": {
                     "type": "array",
                     "items": {"type": "string"},
                     "description": "Array of mental model IDs that support your answer",
                 },
-                "observation_ids": {
-                    "type": "array",
-                    "items": {"type": "string"},
-                    "description": "Array of observation IDs that support your answer",
-                },
             },
             "required": ["answer"],
         },
@@ -197,16 +181,16 @@ def _build_done_tool_with_directives(directive_rules: list[str]) -> dict:
                         "items": {"type": "string"},
                         "description": "Array of memory IDs that support your answer (put IDs here, NOT in answer text)",
                     },
+                    "reflection_ids": {
+                        "type": "array",
+                        "items": {"type": "string"},
+                        "description": "Array of reflection IDs that support your answer",
+                    },
                     "mental_model_ids": {
                         "type": "array",
                         "items": {"type": "string"},
                         "description": "Array of mental model IDs that support your answer",
                     },
-                    "observation_ids": {
-                        "type": "array",
-                        "items": {"type": "string"},
-                        "description": "Array of observation IDs that support your answer",
-                    },
                     "directive_compliance": {
                         "type": "string",
                         "description": f"REQUIRED: Confirm your answer complies with ALL directives. List each directive and how your answer follows it:\n{rules_list}\n\nFormat: 'Directive 1: [how answer complies]. Directive 2: [how answer complies]...'",
@@ -223,8 +207,8 @@ def get_reflect_tools(directive_rules: list[str] | None = None) -> list[dict]:
     Get the list of tools for the reflect agent.
 
     The tools support a hierarchical retrieval strategy:
-    1. search_mental_models - User-curated stored reflect responses (try first)
-    2. search_observations - Consolidated knowledge with freshness
+    1. search_reflections - User-curated summaries (try first)
+    2. search_mental_models - Consolidated knowledge with freshness
     3. recall - Raw facts as ground truth
 
     Args:
@@ -235,8 +219,8 @@ def get_reflect_tools(directive_rules: list[str] | None = None) -> list[dict]:
         List of tool definitions in OpenAI format
     """
     tools = [
+        TOOL_SEARCH_REFLECTIONS,
         TOOL_SEARCH_MENTAL_MODELS,
-        TOOL_SEARCH_OBSERVATIONS,
         TOOL_RECALL,
         TOOL_EXPAND,
     ]

hindsight-api/hindsight_api/engine/response_models.py

@@ -10,8 +10,8 @@ from typing import Any
 
 from pydantic import BaseModel, ConfigDict, Field
 
-# Valid fact types for recall operations (excludes 'opinion' which is deprecated)
-VALID_RECALL_FACT_TYPES = frozenset(["world", "experience", "observation"])
+# Valid fact types for recall operations (excludes 'observation' which is internal, and 'opinion' which is deprecated)
+VALID_RECALL_FACT_TYPES = frozenset(["world", "experience", "mental_model"])
 
 
 class LLMToolCall(BaseModel):
@@ -36,7 +36,6 @@ class ToolCallTrace(BaseModel):
     """A single tool call made during reflect."""
 
     tool: str = Field(description="Tool name: lookup, recall, learn, expand")
-    reason: str | None = Field(default=None, description="Agent's reasoning for making this tool call")
     input: dict = Field(description="Tool input parameters")
     output: dict = Field(description="Tool output/result")
     duration_ms: int = Field(description="Execution time in milliseconds")
@@ -50,13 +49,13 @@ class LLMCallTrace(BaseModel):
     duration_ms: int = Field(description="Execution time in milliseconds")
 
 
-class ObservationRef(BaseModel):
-    """Reference to an observation accessed during reflect."""
+class MentalModelRef(BaseModel):
+    """Reference to a mental model accessed during reflect."""
 
-    id: str = Field(description="Observation ID")
-    name: str = Field(description="Observation name")
-    type: str = Field(description="Observation type: entity, concept, event")
-    subtype: str = Field(description="Observation subtype: structural, emergent, learned")
+    id: str = Field(description="Mental model ID")
+    name: str = Field(description="Mental model name")
+    type: str = Field(description="Mental model type: entity, concept, event")
+    subtype: str = Field(description="Mental model subtype: structural, emergent, learned")
     description: str = Field(description="Brief description")
     summary: str | None = Field(default=None, description="Full summary (when looked up in detail)")
 
@@ -66,7 +65,7 @@ class DirectiveRef(BaseModel):
 
     id: str = Field(description="Directive mental model ID")
     name: str = Field(description="Directive name")
-    content: str = Field(description="Directive content")
+    rules: list[str] = Field(default_factory=list, description="Directive rules/observations that were applied")
 
 
 class TokenUsage(BaseModel):
@@ -169,23 +168,23 @@ class ChunkInfo(BaseModel):
     truncated: bool = Field(default=False, description="Whether the chunk was truncated due to token limits")
 
 
-class ObservationResult(BaseModel):
-    """An observation result from recall (consolidated knowledge synthesized from facts)."""
+class MentalModelResult(BaseModel):
+    """A mental model result from recall."""
 
-    id: str = Field(description="Unique observation ID")
-    text: str = Field(description="The observation text")
-    proof_count: int = Field(description="Number of facts supporting this observation")
+    id: str = Field(description="Unique mental model ID")
+    text: str = Field(description="The mental model text")
+    proof_count: int = Field(description="Number of facts supporting this mental model")
     relevance: float = Field(default=0.0, description="Relevance score to the query")
     tags: list[str] | None = Field(default=None, description="Tags for visibility scoping")
     source_memory_ids: list[str] = Field(
-        default_factory=list, description="IDs of facts that contribute to this observation"
+        default_factory=list, description="IDs of facts that contribute to this mental model"
     )
 
 
-class MentalModelResult(BaseModel):
-    """A mental model result from recall (stored reflect response)."""
+class ReflectionResult(BaseModel):
+    """A reflection result from recall."""
 
-    id: str = Field(description="Unique mental model ID")
+    id: str = Field(description="Unique reflection ID")
     name: str = Field(description="Human-readable name")
     content: str = Field(description="The synthesized content")
     relevance: float = Field(default=0.0, description="Relevance score to the query")
@@ -254,15 +253,9 @@ class ReflectResult(BaseModel):
                     ],
                     "experience": [],
                     "opinion": [],
-                    "mental_models": [],
-                    "directives": [
-                        {
-                            "id": "directive-123",
-                            "name": "Response Style",
-                            "rules": ["Always be concise"],
-                        }
-                    ],
+                    "mental-models": [],
                 },
+                "new_opinions": ["Machine learning has great potential in healthcare"],
                 "structured_output": {"summary": "ML in healthcare", "confidence": 0.9},
                 "usage": {"input_tokens": 1500, "output_tokens": 500, "total_tokens": 2000},
             }
@@ -270,9 +263,10 @@ class ReflectResult(BaseModel):
     )
 
     text: str = Field(description="The formulated answer text")
-    based_on: dict[str, Any] = Field(
-        description="Facts used to formulate the answer, organized by type (world, experience, mental_models, directives)"
+    based_on: dict[str, list[MemoryFact]] = Field(
+        description="Facts used to formulate the answer, organized by type (world, experience, opinion, mental-models)"
     )
+    new_opinions: list[str] = Field(default_factory=list, description="List of newly formed opinions during reflection")
     structured_output: dict[str, Any] | None = Field(
         default=None,
         description="Structured output parsed according to the provided response schema. Only present when response_schema was provided.",
@@ -295,6 +289,24 @@ class ReflectResult(BaseModel):
     )
 
 
+class Opinion(BaseModel):
+    """
+    An opinion with confidence score.
+
+    Opinions represent the bank's formed perspectives on topics,
+    with a confidence level indicating strength of belief.
+    """
+
+    model_config = ConfigDict(
+        json_schema_extra={
+            "example": {"text": "Machine learning has great potential in healthcare", "confidence": 0.85}
+        }
+    )
+
+    text: str = Field(description="The opinion text")
+    confidence: float = Field(description="Confidence score between 0.0 and 1.0")
+
+
 class EntityObservation(BaseModel):
     """
     An observation about an entity.

hindsight-api/hindsight_api/engine/retain/fact_extraction.py

@@ -57,25 +57,21 @@ def _infer_temporal_date(fact_text: str, event_date: datetime) -> str | None:
     return None
 
 
-def _sanitize_text(text: str | None) -> str | None:
+def _sanitize_text(text: str) -> str:
     """
-    Sanitize text by removing characters that break downstream systems.
+    Sanitize text by removing invalid Unicode surrogate characters.
 
-    Removes:
-    - Null bytes (\\x00): Invalid in PostgreSQL UTF-8 encoding
-    - Unicode surrogates (U+D800-U+DFFF): Invalid in UTF-8, break LLM APIs
+    Surrogate characters (U+D800 to U+DFFF) are used in UTF-16 encoding
+    but cannot be encoded in UTF-8. They can appear in Python strings
+    from improperly decoded data (e.g., from JavaScript or broken files).
 
-    Surrogate characters are used in UTF-16 encoding but cannot be encoded
-    in UTF-8. They can appear in Python strings from improperly decoded data
-    (e.g., from JavaScript or broken files). Null bytes commonly appear in
-    OCR output, PDF extraction, or copy-paste from binary sources.
+    This function removes unpaired surrogates to prevent UnicodeEncodeError
+    when the text is sent to the LLM API.
     """
-    if text is None:
-        return None
     if not text:
         return text
-    # Remove null bytes and surrogate characters
-    text = text.replace("\x00", "")
+    # Remove surrogate characters (U+D800 to U+DFFF) using regex
+    # These are invalid in UTF-8 and cause encoding errors
     return re.sub(r"[\ud800-\udfff]", "", text)
 
 
@@ -436,15 +432,34 @@ def _chunk_conversation(turns: list[dict], max_chars: int) -> list[str]:
 # FACT EXTRACTION PROMPTS
 # =============================================================================
 
-# Base prompt template (shared by concise and custom modes)
-# Uses {extraction_guidelines} placeholder for mode-specific instructions
-_BASE_FACT_EXTRACTION_PROMPT = """Extract SIGNIFICANT facts from text. Be SELECTIVE - only extract facts worth remembering long-term.
+# Concise extraction prompt (default) - selective, high-quality facts
+CONCISE_FACT_EXTRACTION_PROMPT = """Extract SIGNIFICANT facts from text. Be SELECTIVE - only extract facts worth remembering long-term.
 
 LANGUAGE REQUIREMENT: Detect the language of the input text. All extracted facts, entity names, descriptions, and other output MUST be in the SAME language as the input. Do not translate to another language.
 
 {fact_types_instruction}
 
-{extraction_guidelines}
+══════════════════════════════════════════════════════════════════════════
+SELECTIVITY - CRITICAL (Reduces 90% of unnecessary output)
+══════════════════════════════════════════════════════════════════════════
+
+ONLY extract facts that are:
+✅ Personal info: names, relationships, roles, background
+✅ Preferences: likes, dislikes, habits, interests (e.g., "Alice likes coffee")
+✅ Significant events: milestones, decisions, achievements, changes
+✅ Plans/goals: future intentions, deadlines, commitments
+✅ Expertise: skills, knowledge, certifications, experience
+✅ Important context: projects, problems, constraints
+✅ Sensory/emotional details: feelings, sensations, perceptions that provide context
+✅ Observations: descriptions of people, places, things with specific details
+
+DO NOT extract:
+❌ Generic greetings: "how are you", "hello", pleasantries without substance
+❌ Pure filler: "thanks", "sounds good", "ok", "got it", "sure"
+❌ Process chatter: "let me check", "one moment", "I'll look into it"
+❌ Repeated info: if already stated, don't extract again
+
+CONSOLIDATE related statements into ONE fact when possible.
 
 ══════════════════════════════════════════════════════════════════════════
 FACT FORMAT - BE CONCISE
@@ -492,33 +507,7 @@ ENTITIES
 ══════════════════════════════════════════════════════════════════════════
 
 Include: people names, organizations, places, key objects, abstract concepts (career, friendship, etc.)
-Always include "user" when fact is about the user.{examples}"""
-
-# Concise mode guidelines
-_CONCISE_GUIDELINES = """══════════════════════════════════════════════════════════════════════════
-SELECTIVITY - CRITICAL (Reduces 90% of unnecessary output)
-══════════════════════════════════════════════════════════════════════════
-
-ONLY extract facts that are:
-✅ Personal info: names, relationships, roles, background
-✅ Preferences: likes, dislikes, habits, interests (e.g., "Alice likes coffee")
-✅ Significant events: milestones, decisions, achievements, changes
-✅ Plans/goals: future intentions, deadlines, commitments
-✅ Expertise: skills, knowledge, certifications, experience
-✅ Important context: projects, problems, constraints
-✅ Sensory/emotional details: feelings, sensations, perceptions that provide context
-✅ Observations: descriptions of people, places, things with specific details
-
-DO NOT extract:
-❌ Generic greetings: "how are you", "hello", pleasantries without substance
-❌ Pure filler: "thanks", "sounds good", "ok", "got it", "sure"
-❌ Process chatter: "let me check", "one moment", "I'll look into it"
-❌ Repeated info: if already stated, don't extract again
-
-CONSOLIDATE related statements into ONE fact when possible."""
-
-# Concise mode examples
-_CONCISE_EXAMPLES = """
+Always include "user" when fact is about the user.
 
 ══════════════════════════════════════════════════════════════════════════
 EXAMPLES
@@ -544,20 +533,6 @@ QUALITY OVER QUANTITY
 
 Ask: "Would this be useful to recall in 6 months?" If no, skip it."""
 
-# Assembled concise prompt (backward compatible - exact same output as before)
-CONCISE_FACT_EXTRACTION_PROMPT = _BASE_FACT_EXTRACTION_PROMPT.format(
-    fact_types_instruction="{fact_types_instruction}",
-    extraction_guidelines=_CONCISE_GUIDELINES,
-    examples=_CONCISE_EXAMPLES,
-)
-
-# Custom prompt uses same base but without examples
-CUSTOM_FACT_EXTRACTION_PROMPT = _BASE_FACT_EXTRACTION_PROMPT.format(
-    fact_types_instruction="{fact_types_instruction}",
-    extraction_guidelines="{custom_instructions}",
-    examples="",  # No examples for custom mode
-)
-
 
 # Verbose extraction prompt - detailed, comprehensive facts (legacy mode)
 VERBOSE_FACT_EXTRACTION_PROMPT = """Extract facts from text into structured format with FIVE required dimensions - BE EXTREMELY DETAILED.
@@ -697,6 +672,7 @@ async def _extract_facts_from_chunk(
     context: str,
     llm_config: "LLMConfig",
     agent_name: str = None,
+    extract_opinions: bool = False,
 ) -> tuple[list[dict[str, str]], TokenUsage]:
     """
     Extract facts from a single chunk (internal helper for parallel processing).
@@ -704,15 +680,17 @@ async def _extract_facts_from_chunk(
     Note: event_date parameter is kept for backward compatibility but not used in prompt.
     The LLM extracts temporal information from the context string instead.
     """
-    import logging
+    memory_bank_context = f"\n- Your name: {agent_name}" if agent_name and extract_opinions else ""
 
-    from openai import BadRequestError
-
-    logger = logging.getLogger(__name__)
-
-    # Determine which fact types to extract
+    # Determine which fact types to extract based on the flag
     # Note: We use "assistant" in the prompt but convert to "bank" for storage
-    fact_types_instruction = "Extract ONLY 'world' and 'assistant' type facts."
+    if extract_opinions:
+        # Opinion extraction uses a separate prompt (not this one)
+        fact_types_instruction = "Extract ONLY 'opinion' type facts (formed opinions, beliefs, and perspectives). DO NOT extract 'world' or 'assistant' facts."
+    else:
+        fact_types_instruction = (
+            "Extract ONLY 'world' and 'assistant' type facts. DO NOT extract opinions - those are extracted separately."
+        )
 
     # Check config for extraction mode and causal link extraction
     config = get_config()
@@ -720,27 +698,13 @@ async def _extract_facts_from_chunk(
     extract_causal_links = config.retain_extract_causal_links
 
     # Select base prompt based on extraction mode
-    if extraction_mode == "custom":
-        # Custom mode: inject user-provided guidelines
-        if not config.retain_custom_instructions:
-            logger.warning(
-                "extraction_mode='custom' but HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS not set. "
-                "Falling back to 'concise' mode."
-            )
-            base_prompt = CONCISE_FACT_EXTRACTION_PROMPT
-            prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
-        else:
-            base_prompt = CUSTOM_FACT_EXTRACTION_PROMPT
-            prompt = base_prompt.format(
-                fact_types_instruction=fact_types_instruction,
-                custom_instructions=config.retain_custom_instructions,
-            )
-    elif extraction_mode == "verbose":
+    if extraction_mode == "verbose":
         base_prompt = VERBOSE_FACT_EXTRACTION_PROMPT
-        prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
     else:
         base_prompt = CONCISE_FACT_EXTRACTION_PROMPT
-        prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
+
+    # Format the prompt with fact types instruction
+    prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
 
     # Build the full prompt with or without causal relationships section
     # Select appropriate response schema based on extraction mode and causal links
@@ -753,6 +717,12 @@ async def _extract_facts_from_chunk(
     else:
         response_schema = FactExtractionResponseNoCausal
 
+    import logging
+
+    from openai import BadRequestError
+
+    logger = logging.getLogger(__name__)
+
     # Retry logic for JSON validation errors
     max_retries = 2
     last_error = None
@@ -763,12 +733,9 @@ async def _extract_facts_from_chunk(
 
     # Build user message with metadata and chunk content in a clear format
     # Format event_date with day of week for better temporal reasoning
-    # Handle both datetime objects and ISO string formats (from deserialized async tasks)
-    from .orchestrator import parse_datetime_flexible
-
-    event_date = parse_datetime_flexible(event_date)
     event_date_formatted = event_date.strftime("%A, %B %d, %Y")  # e.g., "Monday, June 10, 2024"
     user_message = f"""Extract facts from the following text chunk.
+{memory_bank_context}
 
 Chunk: {chunk_index + 1}/{total_chunks}
 Event Date: {event_date_formatted} ({event_date.isoformat()})
@@ -780,28 +747,12 @@ Text:
     usage = TokenUsage()  # Track cumulative usage across retries
     for attempt in range(max_retries):
         try:
-            # Use retain-specific overrides if set, otherwise fall back to global LLM config
-            max_retries = (
-                config.retain_llm_max_retries if config.retain_llm_max_retries is not None else config.llm_max_retries
-            )
-            initial_backoff = (
-                config.retain_llm_initial_backoff
-                if config.retain_llm_initial_backoff is not None
-                else config.llm_initial_backoff
-            )
-            max_backoff = (
-                config.retain_llm_max_backoff if config.retain_llm_max_backoff is not None else config.llm_max_backoff
-            )
-
             extraction_response_json, call_usage = await llm_config.call(
                 messages=[{"role": "system", "content": prompt}, {"role": "user", "content": user_message}],
                 response_format=response_schema,
                 scope="memory_extract_facts",
                 temperature=0.1,
                 max_completion_tokens=config.retain_max_completion_tokens,
-                max_retries=max_retries,
-                initial_backoff=initial_backoff,
-                max_backoff=max_backoff,
                 skip_validation=True,  # Get raw JSON, we'll validate leniently
                 return_usage=True,
             )
@@ -1027,6 +978,7 @@ async def _extract_facts_with_auto_split(
     context: str,
     llm_config: LLMConfig,
     agent_name: str = None,
+    extract_opinions: bool = False,
 ) -> tuple[list[dict[str, str]], TokenUsage]:
     """
     Extract facts from a chunk with automatic splitting if output exceeds token limits.
@@ -1042,6 +994,7 @@ async def _extract_facts_with_auto_split(
         context: Context about the conversation/document
         llm_config: LLM configuration to use
         agent_name: Optional agent name (memory owner)
+        extract_opinions: If True, extract ONLY opinions. If False, extract world and agent facts (no opinions)
 
     Returns:
         Tuple of (facts list, token usage) extracted from the chunk (possibly from sub-chunks)
@@ -1060,6 +1013,7 @@ async def _extract_facts_with_auto_split(
             context=context,
             llm_config=llm_config,
             agent_name=agent_name,
+            extract_opinions=extract_opinions,
         )
     except OutputTooLongError:
         # Output exceeded token limits - split the chunk in half and retry
@@ -1104,6 +1058,7 @@ async def _extract_facts_with_auto_split(
                 context=context,
                 llm_config=llm_config,
                 agent_name=agent_name,
+                extract_opinions=extract_opinions,
             ),
             _extract_facts_with_auto_split(
                 chunk=second_half,
@@ -1113,6 +1068,7 @@ async def _extract_facts_with_auto_split(
                 context=context,
                 llm_config=llm_config,
                 agent_name=agent_name,
+                extract_opinions=extract_opinions,
             ),
         ]
 
@@ -1136,6 +1092,7 @@ async def extract_facts_from_text(
     llm_config: LLMConfig,
     agent_name: str,
     context: str = "",
+    extract_opinions: bool = False,
 ) -> tuple[list[Fact], list[tuple[str, int]], TokenUsage]:
     """
     Extract semantic facts from conversational or narrative text using LLM.
@@ -1152,6 +1109,7 @@ async def extract_facts_from_text(
         context: Context about the conversation/document
         llm_config: LLM configuration to use
         agent_name: Agent name (memory owner)
+        extract_opinions: If True, extract ONLY opinions. If False, extract world and bank facts (no opinions)
 
     Returns:
         Tuple of (facts, chunks, usage) where:
@@ -1179,6 +1137,7 @@ async def extract_facts_from_text(
             context=context,
             llm_config=llm_config,
             agent_name=agent_name,
+            extract_opinions=extract_opinions,
         )
         for i, chunk in enumerate(chunks)
     ]
@@ -1210,7 +1169,7 @@ SECONDS_PER_FACT = 10
 
 
 async def extract_facts_from_contents(
-    contents: list[RetainContent], llm_config, agent_name: str
+    contents: list[RetainContent], llm_config, agent_name: str, extract_opinions: bool = False
 ) -> tuple[list[ExtractedFactType], list[ChunkMetadata], TokenUsage]:
     """
     Extract facts from multiple content items in parallel.
@@ -1225,6 +1184,7 @@ async def extract_facts_from_contents(
         contents: List of RetainContent objects to process
         llm_config: LLM configuration for fact extraction
         agent_name: Name of the agent (for agent-related fact detection)
+        extract_opinions: If True, extract only opinions; otherwise world/bank facts
 
     Returns:
         Tuple of (extracted_facts, chunks_metadata, usage)
@@ -1243,6 +1203,7 @@ async def extract_facts_from_contents(
             context=item.context,
             llm_config=llm_config,
             agent_name=agent_name,
+            extract_opinions=extract_opinions,
         )
         fact_extraction_tasks.append(task)
 
@@ -1354,8 +1315,6 @@ def _add_temporal_offsets(facts: list[ExtractedFactType], contents: list[RetainC
 
     Modifies facts in place.
     """
-    from .orchestrator import parse_datetime_flexible
-
     # Group facts by content_index
     current_content_idx = 0
     content_fact_start = 0
@@ -1370,10 +1329,10 @@ def _add_temporal_offsets(facts: list[ExtractedFactType], contents: list[RetainC
         fact_position = i - content_fact_start
         offset = timedelta(seconds=fact_position * SECONDS_PER_FACT)
 
-        # Apply offset to all temporal fields (handle both datetime objects and ISO strings)
+        # Apply offset to all temporal fields
         if fact.occurred_start:
-            fact.occurred_start = parse_datetime_flexible(fact.occurred_start) + offset
+            fact.occurred_start = fact.occurred_start + offset
         if fact.occurred_end:
-            fact.occurred_end = parse_datetime_flexible(fact.occurred_end) + offset
+            fact.occurred_end = fact.occurred_end + offset
         if fact.mentioned_at:
-            fact.mentioned_at = parse_datetime_flexible(fact.mentioned_at) + offset
+            fact.mentioned_at = fact.mentioned_at + offset

hindsight-api/hindsight_api/engine/retain/fact_storage.py

@@ -8,7 +8,6 @@ import json
 import logging
 
 from ..memory_engine import fq_table
-from .fact_extraction import _sanitize_text
 from .types import ProcessedFact
 
 logger = logging.getLogger(__name__)
@@ -48,7 +47,7 @@ async def insert_facts_batch(
     tags_list = []
 
     for fact in facts:
-        fact_texts.append(_sanitize_text(fact.fact_text))
+        fact_texts.append(fact.fact_text)
         # Convert embedding to string for asyncpg vector type
         embeddings.append(str(fact.embedding))
         # event_date: Use occurred_start if available, otherwise use mentioned_at
@@ -57,7 +56,7 @@ async def insert_facts_batch(
         occurred_starts.append(fact.occurred_start)
         occurred_ends.append(fact.occurred_end)
         mentioned_ats.append(fact.mentioned_at)
-        contexts.append(_sanitize_text(fact.context))
+        contexts.append(fact.context)
         fact_types.append(fact.fact_type)
         # confidence_score is only for opinion facts
         confidence_scores.append(1.0 if fact.fact_type == "opinion" else None)
@@ -158,8 +157,7 @@ async def handle_document_tracking(
     """
     import hashlib
 
-    # Sanitize and calculate content hash
-    combined_content = _sanitize_text(combined_content) or ""
+    # Calculate content hash
     content_hash = hashlib.sha256(combined_content.encode()).hexdigest()
 
     # Always delete old document first if it exists (cascades to units and links)

hindsight-api/hindsight_api/engine/retain/orchestrator.py

@@ -8,7 +8,6 @@ import logging
 import time
 import uuid
 from datetime import UTC, datetime
-from typing import Any
 
 from ..db_utils import acquire_with_retry
 from . import bank_utils
@@ -19,39 +18,6 @@ def utcnow():
     return datetime.now(UTC)
 
 
-def parse_datetime_flexible(value: Any) -> datetime:
-    """
-    Parse a datetime value that could be either a datetime object or an ISO string.
-
-    This handles datetime values from both direct Python calls and deserialized JSON
-    (where datetime objects are serialized as ISO strings).
-
-    Args:
-        value: Either a datetime object or an ISO format string
-
-    Returns:
-        datetime object (timezone-aware)
-
-    Raises:
-        TypeError: If value is neither datetime nor string
-        ValueError: If string is not a valid ISO datetime
-    """
-    if isinstance(value, datetime):
-        # Ensure timezone-aware
-        if value.tzinfo is None:
-            return value.replace(tzinfo=UTC)
-        return value
-    elif isinstance(value, str):
-        # Parse ISO format string (handles both 'Z' and '+00:00' timezone formats)
-        dt = datetime.fromisoformat(value.replace("Z", "+00:00"))
-        # Ensure timezone-aware
-        if dt.tzinfo is None:
-            return dt.replace(tzinfo=UTC)
-        return dt
-    else:
-        raise TypeError(f"Expected datetime or string, got {type(value).__name__}")
-
-
 from ..response_models import TokenUsage
 from . import (
     chunk_storage,
@@ -123,18 +89,10 @@ async def retain_batch(
         # Merge item-level tags with document-level tags
         item_tags = item.get("tags", []) or []
         merged_tags = list(set(item_tags + (document_tags or [])))
-
-        # Handle event_date: parse flexibly (handles both datetime objects and ISO strings)
-        event_date_value = item.get("event_date")
-        if event_date_value:
-            event_date_value = parse_datetime_flexible(event_date_value)
-        else:
-            event_date_value = utcnow()
-
         content = RetainContent(
             content=item["content"],
             context=item.get("context", ""),
-            event_date=event_date_value,
+            event_date=item.get("event_date") or utcnow(),
             metadata=item.get("metadata", {}),
             entities=item.get("entities", []),
             tags=merged_tags,
@@ -143,8 +101,11 @@ async def retain_batch(
 
     # Step 1: Extract facts from all contents
     step_start = time.time()
+    extract_opinions = fact_type_override == "opinion"
 
-    extracted_facts, chunks, usage = await fact_extraction.extract_facts_from_contents(contents, llm_config, agent_name)
+    extracted_facts, chunks, usage = await fact_extraction.extract_facts_from_contents(
+        contents, llm_config, agent_name, extract_opinions
+    )
     log_buffer.append(
         f"[1] Extract facts: {len(extracted_facts)} facts, {len(chunks)} chunks from {len(contents)} contents in {time.time() - step_start:.3f}s"
     )

hindsight-api/hindsight_api/engine/search/link_expansion_retrieval.py

@@ -155,6 +155,7 @@ class LinkExpansionRetriever(GraphRetriever):
                 all_seeds.extend(temporal_seeds)
 
             if not all_seeds:
+                logger.debug("[LinkExpansion] No seeds found, returning empty results")
                 return [], timings
 
             seed_ids = list({s.id for s in all_seeds})
@@ -163,102 +164,30 @@ class LinkExpansionRetriever(GraphRetriever):
             # Run entity and causal expansion sequentially on same connection
             query_start = time.time()
 
-            # For observations, traverse through source_memory_ids to find entity connections.
-            # Observations don't have direct unit_entities - they inherit entities via their
-            # source world/experience facts.
-            #
-            # Path: observation → source_memory_ids → world fact → entities →
-            #       ALL world facts with those entities → their observations (excluding seeds)
-            if fact_type == "observation":
-                # Debug: Check what source_memory_ids exist on seed observations
-                debug_sources = await conn.fetch(
-                    f"""
-                    SELECT id, source_memory_ids
-                    FROM {fq_table("memory_units")}
-                    WHERE id = ANY($1::uuid[])
-                    """,
-                    seed_ids,
-                )
-                source_ids_found = []
-                for row in debug_sources:
-                    if row["source_memory_ids"]:
-                        source_ids_found.extend(row["source_memory_ids"])
-                logger.debug(
-                    f"[LinkExpansion] observation graph: {len(seed_ids)} seeds, "
-                    f"{len(source_ids_found)} source_memory_ids found"
-                )
-
-                entity_rows = await conn.fetch(
-                    f"""
-                    WITH seed_sources AS (
-                        -- Get source memory IDs from seed observations
-                        SELECT DISTINCT unnest(source_memory_ids) AS source_id
-                        FROM {fq_table("memory_units")}
-                        WHERE id = ANY($1::uuid[])
-                          AND source_memory_ids IS NOT NULL
-                    ),
-                    source_entities AS (
-                        -- Get entities from those source memories (filtered by frequency)
-                        SELECT DISTINCT ue.entity_id
-                        FROM seed_sources ss
-                        JOIN {fq_table("unit_entities")} ue ON ss.source_id = ue.unit_id
-                        JOIN {fq_table("entities")} e ON ue.entity_id = e.id
-                        WHERE e.mention_count < $2
-                    ),
-                    all_connected_sources AS (
-                        -- Find ALL world facts sharing those entities (don't exclude seed sources)
-                        -- The exclusion happens at the observation level, not the source level
-                        SELECT DISTINCT other_ue.unit_id AS source_id
-                        FROM source_entities se
-                        JOIN {fq_table("unit_entities")} other_ue ON se.entity_id = other_ue.entity_id
-                    )
-                    -- Find observations derived from connected source memories
-                    -- Only exclude the actual seed observations
-                    SELECT
-                        mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
-                        mu.occurred_end, mu.mentioned_at, mu.embedding,
-                        mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
-                        COUNT(DISTINCT cs.source_id)::float AS score
-                    FROM all_connected_sources cs
-                    JOIN {fq_table("memory_units")} mu
-                        ON mu.source_memory_ids @> ARRAY[cs.source_id]
-                    WHERE mu.fact_type = 'observation'
-                      AND mu.id != ALL($1::uuid[])
-                    GROUP BY mu.id
-                    ORDER BY score DESC
-                    LIMIT $3
-                    """,
-                    seed_ids,
-                    self.max_entity_frequency,
-                    budget,
-                )
-                logger.debug(f"[LinkExpansion] observation graph: found {len(entity_rows)} connected observations")
-            else:
-                # For world/experience facts, use direct entity lookup
-                entity_rows = await conn.fetch(
-                    f"""
-                    SELECT
-                        mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
-                        mu.occurred_end, mu.mentioned_at, mu.embedding,
-                        mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
-                        COUNT(*)::float AS score
-                    FROM {fq_table("unit_entities")} seed_ue
-                    JOIN {fq_table("entities")} e ON seed_ue.entity_id = e.id
-                    JOIN {fq_table("unit_entities")} other_ue ON seed_ue.entity_id = other_ue.entity_id
-                    JOIN {fq_table("memory_units")} mu ON other_ue.unit_id = mu.id
-                    WHERE seed_ue.unit_id = ANY($1::uuid[])
-                      AND e.mention_count < $2
-                      AND mu.id != ALL($1::uuid[])
-                      AND mu.fact_type = $3
-                    GROUP BY mu.id
-                    ORDER BY score DESC
-                    LIMIT $4
-                    """,
-                    seed_ids,
-                    self.max_entity_frequency,
-                    fact_type,
-                    budget,
-                )
+            entity_rows = await conn.fetch(
+                f"""
+                SELECT
+                    mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
+                    mu.occurred_end, mu.mentioned_at, mu.embedding,
+                    mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
+                    COUNT(*)::float AS score
+                FROM {fq_table("unit_entities")} seed_ue
+                JOIN {fq_table("entities")} e ON seed_ue.entity_id = e.id
+                JOIN {fq_table("unit_entities")} other_ue ON seed_ue.entity_id = other_ue.entity_id
+                JOIN {fq_table("memory_units")} mu ON other_ue.unit_id = mu.id
+                WHERE seed_ue.unit_id = ANY($1::uuid[])
+                  AND e.mention_count < $2
+                  AND mu.id != ALL($1::uuid[])
+                  AND mu.fact_type = $3
+                GROUP BY mu.id
+                ORDER BY score DESC
+                LIMIT $4
+                """,
+                seed_ids,
+                self.max_entity_frequency,
+                fact_type,
+                budget,
+            )
 
             causal_rows = await conn.fetch(
                 f"""
@@ -282,69 +211,11 @@ class LinkExpansionRetriever(GraphRetriever):
                 budget,
             )
 
-            # Fallback: semantic/temporal/entity links from memory_links table
-            # These are secondary to entity links (via unit_entities) and causal links
-            # Weight is halved (0.5x) to prioritize primary link types
-            # Check both directions: seeds -> others AND others -> seeds
-            fallback_rows = await conn.fetch(
-                f"""
-                WITH outgoing AS (
-                    -- Links FROM seeds TO other facts
-                    SELECT mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
-                           mu.occurred_end, mu.mentioned_at, mu.embedding,
-                           mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
-                           ml.weight
-                    FROM {fq_table("memory_links")} ml
-                    JOIN {fq_table("memory_units")} mu ON ml.to_unit_id = mu.id
-                    WHERE ml.from_unit_id = ANY($1::uuid[])
-                      AND ml.link_type IN ('semantic', 'temporal', 'entity')
-                      AND ml.weight >= $2
-                      AND mu.fact_type = $3
-                      AND mu.id != ALL($1::uuid[])
-                ),
-                incoming AS (
-                    -- Links FROM other facts TO seeds (reverse direction)
-                    SELECT mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
-                           mu.occurred_end, mu.mentioned_at, mu.embedding,
-                           mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
-                           ml.weight
-                    FROM {fq_table("memory_links")} ml
-                    JOIN {fq_table("memory_units")} mu ON ml.from_unit_id = mu.id
-                    WHERE ml.to_unit_id = ANY($1::uuid[])
-                      AND ml.link_type IN ('semantic', 'temporal', 'entity')
-                      AND ml.weight >= $2
-                      AND mu.fact_type = $3
-                      AND mu.id != ALL($1::uuid[])
-                ),
-                combined AS (
-                    SELECT * FROM outgoing
-                    UNION ALL
-                    SELECT * FROM incoming
-                )
-                SELECT DISTINCT ON (id)
-                    id, text, context, event_date, occurred_start,
-                    occurred_end, mentioned_at, embedding,
-                    fact_type, document_id, chunk_id, tags,
-                    (MAX(weight) * 0.5) AS score
-                FROM combined
-                GROUP BY id, text, context, event_date, occurred_start,
-                         occurred_end, mentioned_at, embedding,
-                         fact_type, document_id, chunk_id, tags
-                ORDER BY id, score DESC
-                LIMIT $4
-                """,
-                seed_ids,
-                self.causal_weight_threshold,
-                fact_type,
-                budget,
-            )
-
             timings.edge_load_time = time.time() - query_start
-            timings.db_queries = 3
-            timings.edge_count = len(entity_rows) + len(causal_rows) + len(fallback_rows)
+            timings.db_queries = 2
+            timings.edge_count = len(entity_rows) + len(causal_rows)
 
         # Merge results, taking max score per fact
-        # Priority: entity links (unit_entities) > causal links > fallback links
         score_map: dict[str, float] = {}
         row_map: dict[str, dict] = {}
 
@@ -359,12 +230,6 @@ class LinkExpansionRetriever(GraphRetriever):
             if fact_id not in row_map:
                 row_map[fact_id] = dict(row)
 
-        for row in fallback_rows:
-            fact_id = str(row["id"])
-            score_map[fact_id] = max(score_map.get(fact_id, 0), row["score"])
-            if fact_id not in row_map:
-                row_map[fact_id] = dict(row)
-
         # Sort by score and limit
         sorted_ids = sorted(score_map.keys(), key=lambda x: score_map[x], reverse=True)[:budget]
         rows = [row_map[fact_id] for fact_id in sorted_ids]

hindsight-api/hindsight_api/engine/search/scoring.py

@@ -0,0 +1,134 @@
+"""
+Scoring functions for memory search and retrieval.
+
+Includes recency weighting, frequency weighting, temporal proximity,
+and similarity calculations used in memory activation and ranking.
+"""
+
+from datetime import datetime
+
+
+def cosine_similarity(vec1: list[float], vec2: list[float]) -> float:
+    """
+    Calculate cosine similarity between two vectors.
+
+    Args:
+        vec1: First vector
+        vec2: Second vector
+
+    Returns:
+        Similarity score between 0 and 1
+    """
+    if len(vec1) != len(vec2):
+        raise ValueError("Vectors must have same dimension")
+
+    dot_product = sum(a * b for a, b in zip(vec1, vec2))
+    magnitude1 = sum(a * a for a in vec1) ** 0.5
+    magnitude2 = sum(b * b for b in vec2) ** 0.5
+
+    if magnitude1 == 0 or magnitude2 == 0:
+        return 0.0
+
+    return dot_product / (magnitude1 * magnitude2)
+
+
+def calculate_recency_weight(days_since: float, half_life_days: float = 365.0) -> float:
+    """
+    Calculate recency weight using logarithmic decay.
+
+    This provides much better differentiation over long time periods compared to
+    exponential decay. Uses a log-based decay where the half-life parameter controls
+    when memories reach 50% weight.
+
+    Examples:
+        - Today (0 days): 1.0
+        - 1 year (365 days): ~0.5 (with default half_life=365)
+        - 2 years (730 days): ~0.33
+        - 5 years (1825 days): ~0.17
+        - 10 years (3650 days): ~0.09
+
+    This ensures that 2-year-old and 5-year-old memories have meaningfully
+    different weights, unlike exponential decay which makes them both ~0.
+
+    Args:
+        days_since: Number of days since the memory was created
+        half_life_days: Number of days for weight to reach 0.5 (default: 1 year)
+
+    Returns:
+        Weight between 0 and 1
+    """
+    import math
+
+    # Logarithmic decay: 1 / (1 + log(1 + days_since/half_life))
+    # This decays much slower than exponential, giving better long-term differentiation
+    normalized_age = days_since / half_life_days
+    return 1.0 / (1.0 + math.log1p(normalized_age))
+
+
+def calculate_temporal_anchor(occurred_start: datetime, occurred_end: datetime) -> datetime:
+    """
+    Calculate a single temporal anchor point from a temporal range.
+
+    Used for spreading activation - we need a single representative date
+    to calculate temporal proximity between facts. This simplifies the
+    range-to-range distance problem.
+
+    Strategy: Use midpoint of the range for balanced representation.
+
+    Args:
+        occurred_start: Start of temporal range
+        occurred_end: End of temporal range
+
+    Returns:
+        Single datetime representing the temporal anchor (midpoint)
+
+    Examples:
+        - Point event (July 14): start=July 14, end=July 14 → anchor=July 14
+        - Month range (February): start=Feb 1, end=Feb 28 → anchor=Feb 14
+        - Year range (2023): start=Jan 1, end=Dec 31 → anchor=July 1
+    """
+    # Calculate midpoint
+    time_delta = occurred_end - occurred_start
+    midpoint = occurred_start + (time_delta / 2)
+    return midpoint
+
+
+def calculate_temporal_proximity(anchor_a: datetime, anchor_b: datetime, half_life_days: float = 30.0) -> float:
+    """
+    Calculate temporal proximity between two temporal anchors.
+
+    Used for spreading activation to determine how "close" two facts are
+    in time. Uses logarithmic decay so that temporal similarity doesn't
+    drop off too quickly.
+
+    Args:
+        anchor_a: Temporal anchor of first fact
+        anchor_b: Temporal anchor of second fact
+        half_life_days: Number of days for proximity to reach 0.5
+                       (default: 30 days = 1 month)
+
+    Returns:
+        Proximity score in [0, 1] where:
+        - 1.0 = same day
+        - 0.5 = ~half_life days apart
+        - 0.0 = very distant in time
+
+    Examples:
+        - Same day: 1.0
+        - 1 week apart (half_life=30): ~0.7
+        - 1 month apart (half_life=30): ~0.5
+        - 1 year apart (half_life=30): ~0.2
+    """
+    import math
+
+    days_apart = abs((anchor_a - anchor_b).days)
+
+    if days_apart == 0:
+        return 1.0
+
+    # Logarithmic decay: 1 / (1 + log(1 + days_apart/half_life))
+    # Similar to calculate_recency_weight but for proximity between events
+    normalized_distance = days_apart / half_life_days
+    proximity = 1.0 / (1.0 + math.log1p(normalized_distance))
+
+    return proximity

hindsight-api/hindsight_api/engine/task_backend.py

@@ -144,21 +144,17 @@ class BrokerTaskBackend(TaskBackend):
         self,
         pool_getter: Callable[[], "asyncpg.Pool"],
         schema: str | None = None,
-        schema_getter: Callable[[], str | None] | None = None,
     ):
         """
         Initialize the broker task backend.
 
         Args:
             pool_getter: Callable that returns the asyncpg connection pool
-            schema: Database schema for multi-tenant support (optional, static)
-            schema_getter: Callable that returns current schema dynamically (optional).
-                          If set, takes precedence over static schema for submit_task.
+            schema: Database schema for multi-tenant support (optional)
         """
         super().__init__()
         self._pool_getter = pool_getter
         self._schema = schema
-        self._schema_getter = schema_getter
 
     async def initialize(self):
         """Initialize the backend."""
@@ -182,19 +178,9 @@ class BrokerTaskBackend(TaskBackend):
         operation_id = task_dict.get("operation_id")
         task_type = task_dict.get("type", "unknown")
         bank_id = task_dict.get("bank_id")
+        payload_json = json.dumps(task_dict)
 
-        # Custom encoder to handle datetime objects
-        from datetime import datetime
-
-        def datetime_encoder(obj):
-            if isinstance(obj, datetime):
-                return obj.isoformat()
-            raise TypeError(f"Object of type {type(obj).__name__} is not JSON serializable")
-
-        payload_json = json.dumps(task_dict, default=datetime_encoder)
-
-        schema = self._schema_getter() if self._schema_getter else self._schema
-        table = fq_table("async_operations", schema)
+        table = fq_table("async_operations", self._schema)
 
         if operation_id:
             # Update existing operation with task payload
@@ -245,8 +231,7 @@ class BrokerTaskBackend(TaskBackend):
         import asyncio
 
         pool = self._pool_getter()
-        schema = self._schema_getter() if self._schema_getter else self._schema
-        table = fq_table("async_operations", schema)
+        table = fq_table("async_operations", self._schema)
 
         start_time = asyncio.get_event_loop().time()
         while asyncio.get_event_loop().time() - start_time < timeout:

hindsight-api/hindsight_api/engine/utils.py

@@ -19,6 +19,7 @@ async def extract_facts(
     context: str = "",
     llm_config: "LLMConfig" = None,
     agent_name: str = None,
+    extract_opinions: bool = False,
 ) -> tuple[list["Fact"], list[tuple[str, int]]]:
     """
     Extract semantic facts from text using LLM.
@@ -35,6 +36,7 @@ async def extract_facts(
         context: Context about the conversation/document
         llm_config: LLM configuration to use
         agent_name: Optional agent name to help identify agent-related facts
+        extract_opinions: If True, extract ONLY opinions. If False, extract world and agent facts (no opinions)
 
     Returns:
         Tuple of (facts, chunks) where:
@@ -53,6 +55,7 @@ async def extract_facts(
         context=context,
         llm_config=llm_config,
         agent_name=agent_name,
+        extract_opinions=extract_opinions,
     )
 
     if not facts:
@@ -62,3 +65,129 @@ async def extract_facts(
         return [], chunks
 
     return facts, chunks
+
+
+def cosine_similarity(vec1: list[float], vec2: list[float]) -> float:
+    """
+    Calculate cosine similarity between two vectors.
+
+    Args:
+        vec1: First vector
+        vec2: Second vector
+
+    Returns:
+        Similarity score between 0 and 1
+    """
+    if len(vec1) != len(vec2):
+        raise ValueError("Vectors must have same dimension")
+
+    dot_product = sum(a * b for a, b in zip(vec1, vec2))
+    magnitude1 = sum(a * a for a in vec1) ** 0.5
+    magnitude2 = sum(b * b for b in vec2) ** 0.5
+
+    if magnitude1 == 0 or magnitude2 == 0:
+        return 0.0
+
+    return dot_product / (magnitude1 * magnitude2)
+
+
+def calculate_recency_weight(days_since: float, half_life_days: float = 365.0) -> float:
+    """
+    Calculate recency weight using logarithmic decay.
+
+    This provides much better differentiation over long time periods compared to
+    exponential decay. Uses a log-based decay where the half-life parameter controls
+    when memories reach 50% weight.
+
+    Examples:
+        - Today (0 days): 1.0
+        - 1 year (365 days): ~0.5 (with default half_life=365)
+        - 2 years (730 days): ~0.33
+        - 5 years (1825 days): ~0.17
+        - 10 years (3650 days): ~0.09
+
+    This ensures that 2-year-old and 5-year-old memories have meaningfully
+    different weights, unlike exponential decay which makes them both ~0.
+
+    Args:
+        days_since: Number of days since the memory was created
+        half_life_days: Number of days for weight to reach 0.5 (default: 1 year)
+
+    Returns:
+        Weight between 0 and 1
+    """
+    import math
+
+    # Logarithmic decay: 1 / (1 + log(1 + days_since/half_life))
+    # This decays much slower than exponential, giving better long-term differentiation
+    normalized_age = days_since / half_life_days
+    return 1.0 / (1.0 + math.log1p(normalized_age))
+
+
+def calculate_temporal_anchor(occurred_start: datetime, occurred_end: datetime) -> datetime:
+    """
+    Calculate a single temporal anchor point from a temporal range.
+
+    Used for spreading activation - we need a single representative date
+    to calculate temporal proximity between facts. This simplifies the
+    range-to-range distance problem.
+
+    Strategy: Use midpoint of the range for balanced representation.
+
+    Args:
+        occurred_start: Start of temporal range
+        occurred_end: End of temporal range
+
+    Returns:
+        Single datetime representing the temporal anchor (midpoint)
+
+    Examples:
+        - Point event (July 14): start=July 14, end=July 14 → anchor=July 14
+        - Month range (February): start=Feb 1, end=Feb 28 → anchor=Feb 14
+        - Year range (2023): start=Jan 1, end=Dec 31 → anchor=July 1
+    """
+    # Calculate midpoint
+    time_delta = occurred_end - occurred_start
+    midpoint = occurred_start + (time_delta / 2)
+    return midpoint
+
+
+def calculate_temporal_proximity(anchor_a: datetime, anchor_b: datetime, half_life_days: float = 30.0) -> float:
+    """
+    Calculate temporal proximity between two temporal anchors.
+
+    Used for spreading activation to determine how "close" two facts are
+    in time. Uses logarithmic decay so that temporal similarity doesn't
+    drop off too quickly.
+
+    Args:
+        anchor_a: Temporal anchor of first fact
+        anchor_b: Temporal anchor of second fact
+        half_life_days: Number of days for proximity to reach 0.5
+                       (default: 30 days = 1 month)
+
+    Returns:
+        Proximity score in [0, 1] where:
+        - 1.0 = same day
+        - 0.5 = ~half_life days apart
+        - 0.0 = very distant in time
+
+    Examples:
+        - Same day: 1.0
+        - 1 week apart (half_life=30): ~0.7
+        - 1 month apart (half_life=30): ~0.5
+        - 1 year apart (half_life=30): ~0.2
+    """
+    import math
+
+    days_apart = abs((anchor_a - anchor_b).days)
+
+    if days_apart == 0:
+        return 1.0
+
+    # Logarithmic decay: 1 / (1 + log(1 + days_apart/half_life))
+    # Similar to calculate_recency_weight but for proximity between events
+    normalized_distance = days_apart / half_life_days
+    proximity = 1.0 / (1.0 + math.log1p(normalized_distance))
+
+    return proximity

hindsight-api/hindsight_api/extensions/__init__.py

@@ -24,11 +24,6 @@ from hindsight_api.extensions.operation_validator import (
     # Consolidation operation
     ConsolidateContext,
     ConsolidateResult,
-    # Mental Model operations
-    MentalModelGetContext,
-    MentalModelGetResult,
-    MentalModelRefreshContext,
-    MentalModelRefreshResult,
     # Core operations
     OperationValidationError,
     OperationValidatorExtension,
@@ -70,11 +65,6 @@ __all__ = [
     # Operation Validator - Consolidation
     "ConsolidateContext",
     "ConsolidateResult",
-    # Operation Validator - Mental Model
-    "MentalModelGetContext",
-    "MentalModelGetResult",
-    "MentalModelRefreshContext",
-    "MentalModelRefreshResult",
     # Tenant/Auth
     "ApiKeyTenantExtension",
     "AuthenticationError",

hindsight-api/hindsight_api/extensions/builtin/tenant.py

@@ -1,59 +1,20 @@
 """Built-in tenant extension implementations."""
 
-from hindsight_api.config import get_config
 from hindsight_api.extensions.tenant import AuthenticationError, Tenant, TenantContext, TenantExtension
 from hindsight_api.models import RequestContext
 
 
-class DefaultTenantExtension(TenantExtension):
-    """
-    Default single-tenant extension with no authentication.
-
-    This is the default extension used when no tenant extension is configured.
-    It provides single-tenant behavior using the configured schema from
-    HINDSIGHT_API_DATABASE_SCHEMA (defaults to 'public').
-
-    Features:
-    - No authentication required (passes all requests)
-    - Uses configured schema from environment
-    - Perfect for single-tenant deployments without auth
-
-    Configuration:
-        HINDSIGHT_API_DATABASE_SCHEMA=your-schema (optional, defaults to 'public')
-
-    This is automatically enabled by default. To use custom authentication,
-    configure a different tenant extension:
-        HINDSIGHT_API_TENANT_EXTENSION=hindsight_api.extensions.builtin.tenant:ApiKeyTenantExtension
-    """
-
-    def __init__(self, config: dict[str, str]):
-        super().__init__(config)
-        # Cache the schema at initialization for consistency
-        # Support explicit schema override via config, otherwise use environment
-        self._schema = config.get("schema", get_config().database_schema)
-
-    async def authenticate(self, context: RequestContext) -> TenantContext:
-        """Return configured schema without any authentication."""
-        return TenantContext(schema_name=self._schema)
-
-    async def list_tenants(self) -> list[Tenant]:
-        """Return configured schema for single-tenant setup."""
-        return [Tenant(schema=self._schema)]
-
-
 class ApiKeyTenantExtension(TenantExtension):
     """
     Built-in tenant extension that validates API key against an environment variable.
 
     This is a simple implementation that:
     1. Validates the API key matches HINDSIGHT_API_TENANT_API_KEY
-    2. Returns the configured schema (HINDSIGHT_API_DATABASE_SCHEMA, default 'public')
-       for all authenticated requests
+    2. Returns 'public' as the schema for all authenticated requests
 
     Configuration:
         HINDSIGHT_API_TENANT_EXTENSION=hindsight_api.extensions.builtin.tenant:ApiKeyTenantExtension
         HINDSIGHT_API_TENANT_API_KEY=your-secret-key
-        HINDSIGHT_API_DATABASE_SCHEMA=your-schema (optional, defaults to 'public')
 
     For multi-tenant setups with separate schemas per tenant, implement a custom
     TenantExtension that looks up the schema based on the API key or token claims.
@@ -66,11 +27,11 @@ class ApiKeyTenantExtension(TenantExtension):
             raise ValueError("HINDSIGHT_API_TENANT_API_KEY is required when using ApiKeyTenantExtension")
 
     async def authenticate(self, context: RequestContext) -> TenantContext:
-        """Validate API key and return configured schema context."""
+        """Validate API key and return public schema context."""
         if context.api_key != self.expected_api_key:
             raise AuthenticationError("Invalid API key")
-        return TenantContext(schema_name=get_config().database_schema)
+        return TenantContext(schema_name="public")
 
     async def list_tenants(self) -> list[Tenant]:
-        """Return configured schema for single-tenant setup."""
-        return [Tenant(schema=get_config().database_schema)]
+        """Return public schema for single-tenant setup."""
+        return [Tenant(schema="public")]

hindsight-api/hindsight_api/extensions/operation_validator.py

@@ -196,57 +196,6 @@ class ConsolidateResult:
     error: str | None = None
 
 
-# =============================================================================
-# Mental Model Contexts
-# =============================================================================
-
-
-@dataclass
-class MentalModelGetContext:
-    """Context for a mental model GET operation validation (pre-operation)."""
-
-    bank_id: str
-    mental_model_id: str
-    request_context: "RequestContext"
-
-
-@dataclass
-class MentalModelRefreshContext:
-    """Context for a mental model refresh/create operation validation (pre-operation)."""
-
-    bank_id: str
-    mental_model_id: str | None  # None for create (not yet assigned)
-    request_context: "RequestContext"
-
-
-@dataclass
-class MentalModelGetResult:
-    """Result context for post-mental-model-GET hook."""
-
-    bank_id: str
-    mental_model_id: str
-    request_context: "RequestContext"
-    output_tokens: int  # tokens in the returned content
-    success: bool = True
-    error: str | None = None
-
-
-@dataclass
-class MentalModelRefreshResult:
-    """Result context for post-mental-model-refresh hook."""
-
-    bank_id: str
-    mental_model_id: str
-    request_context: "RequestContext"
-    query_tokens: int  # tokens in source_query
-    output_tokens: int  # tokens in generated content
-    context_tokens: int  # tokens in context (if any)
-    facts_used: int  # facts referenced in based_on
-    mental_models_used: int  # mental models referenced in based_on
-    success: bool = True
-    error: str | None = None
-
-
 class OperationValidatorExtension(Extension, ABC):
     """
     Validates and hooks into retain/recall/reflect/consolidate operations.
@@ -453,81 +402,3 @@ class OperationValidatorExtension(Extension, ABC):
                 - error: Error message (if failed)
         """
         pass
-
-    # =========================================================================
-    # Mental Model - Pre-operation validation hook (optional - override to implement)
-    # =========================================================================
-
-    async def validate_mental_model_get(self, ctx: MentalModelGetContext) -> ValidationResult:
-        """
-        Validate a mental model GET operation before execution.
-
-        Override to implement custom validation logic for mental model retrieval.
-
-        Args:
-            ctx: Context containing:
-                - bank_id: Bank identifier
-                - mental_model_id: Mental model identifier
-                - request_context: Request context with auth info
-
-        Returns:
-            ValidationResult indicating whether the operation is allowed.
-        """
-        return ValidationResult.accept()
-
-    async def validate_mental_model_refresh(self, ctx: MentalModelRefreshContext) -> ValidationResult:
-        """
-        Validate a mental model refresh/create operation before execution.
-
-        Override to implement custom validation logic for mental model refresh.
-
-        Args:
-            ctx: Context containing:
-                - bank_id: Bank identifier
-                - mental_model_id: Mental model identifier (None for create)
-                - request_context: Request context with auth info
-
-        Returns:
-            ValidationResult indicating whether the operation is allowed.
-        """
-        return ValidationResult.accept()
-
-    # =========================================================================
-    # Mental Model - Post-operation hooks (optional - override to implement)
-    # =========================================================================
-
-    async def on_mental_model_get_complete(self, result: MentalModelGetResult) -> None:
-        """
-        Called after a mental model GET operation completes (success or failure).
-
-        Override to implement post-operation logic such as tracking or audit logging.
-
-        Args:
-            result: Result context containing:
-                - bank_id: Bank identifier
-                - mental_model_id: Mental model identifier
-                - output_tokens: Token count of the returned content
-                - success: Whether the operation succeeded
-                - error: Error message (if failed)
-        """
-        pass
-
-    async def on_mental_model_refresh_complete(self, result: MentalModelRefreshResult) -> None:
-        """
-        Called after a mental model refresh operation completes (success or failure).
-
-        Override to implement post-operation logic such as tracking or audit logging.
-
-        Args:
-            result: Result context containing:
-                - bank_id: Bank identifier
-                - mental_model_id: Mental model identifier
-                - query_tokens: Tokens in source_query
-                - output_tokens: Tokens in generated content
-                - context_tokens: Tokens in context
-                - facts_used: Number of facts referenced
-                - mental_models_used: Number of mental models referenced
-                - success: Whether the operation succeeded
-                - error: Error message (if failed)
-        """
-        pass

hindsight-api/hindsight_api/main.py

@@ -20,13 +20,14 @@ import warnings
 
 import uvicorn
 
-from . import MemoryEngine, __version__
+from . import MemoryEngine
 from .api import create_app
 from .banner import print_banner
 from .config import DEFAULT_WORKERS, ENV_WORKERS, HindsightConfig, get_config
 from .daemon import (
     DEFAULT_DAEMON_PORT,
     DEFAULT_IDLE_TIMEOUT,
+    DaemonLock,
     IdleTimeoutMiddleware,
     daemonize,
 )
@@ -135,15 +136,30 @@ def main():
 
     # Daemon mode handling
     if args.daemon:
-        # Use port from args (may be custom for profiles)
-        if args.port == config.port:  # No custom port specified
-            args.port = DEFAULT_DAEMON_PORT
+        # Use fixed daemon port
+        args.port = DEFAULT_DAEMON_PORT
         args.host = "127.0.0.1"  # Only bind to localhost for security
 
+        # Check if another daemon is already running
+        daemon_lock = DaemonLock()
+        if not daemon_lock.acquire():
+            print(f"Daemon already running (PID: {daemon_lock.get_pid()})", file=sys.stderr)
+            sys.exit(1)
+
         # Fork into background
-        # No lockfile needed - port binding prevents duplicate daemons
         daemonize()
 
+        # Re-acquire lock in child process
+        daemon_lock = DaemonLock()
+        if not daemon_lock.acquire():
+            sys.exit(1)
+
+        # Register cleanup to release lock
+        def release_lock():
+            daemon_lock.release()
+
+        atexit.register(release_lock)
+
     # Print banner (not in daemon mode)
     if not args.daemon:
         print()
@@ -154,56 +170,31 @@ def main():
     if args.log_level != config.log_level:
         config = HindsightConfig(
             database_url=config.database_url,
-            database_schema=config.database_schema,
             llm_provider=config.llm_provider,
             llm_api_key=config.llm_api_key,
             llm_model=config.llm_model,
             llm_base_url=config.llm_base_url,
             llm_max_concurrent=config.llm_max_concurrent,
-            llm_max_retries=config.llm_max_retries,
-            llm_initial_backoff=config.llm_initial_backoff,
-            llm_max_backoff=config.llm_max_backoff,
             llm_timeout=config.llm_timeout,
-            llm_vertexai_project_id=config.llm_vertexai_project_id,
-            llm_vertexai_region=config.llm_vertexai_region,
-            llm_vertexai_service_account_key=config.llm_vertexai_service_account_key,
             retain_llm_provider=config.retain_llm_provider,
             retain_llm_api_key=config.retain_llm_api_key,
             retain_llm_model=config.retain_llm_model,
             retain_llm_base_url=config.retain_llm_base_url,
-            retain_llm_max_concurrent=config.retain_llm_max_concurrent,
-            retain_llm_max_retries=config.retain_llm_max_retries,
-            retain_llm_initial_backoff=config.retain_llm_initial_backoff,
-            retain_llm_max_backoff=config.retain_llm_max_backoff,
-            retain_llm_timeout=config.retain_llm_timeout,
             reflect_llm_provider=config.reflect_llm_provider,
             reflect_llm_api_key=config.reflect_llm_api_key,
             reflect_llm_model=config.reflect_llm_model,
             reflect_llm_base_url=config.reflect_llm_base_url,
-            reflect_llm_max_concurrent=config.reflect_llm_max_concurrent,
-            reflect_llm_max_retries=config.reflect_llm_max_retries,
-            reflect_llm_initial_backoff=config.reflect_llm_initial_backoff,
-            reflect_llm_max_backoff=config.reflect_llm_max_backoff,
-            reflect_llm_timeout=config.reflect_llm_timeout,
             consolidation_llm_provider=config.consolidation_llm_provider,
             consolidation_llm_api_key=config.consolidation_llm_api_key,
             consolidation_llm_model=config.consolidation_llm_model,
             consolidation_llm_base_url=config.consolidation_llm_base_url,
-            consolidation_llm_max_concurrent=config.consolidation_llm_max_concurrent,
-            consolidation_llm_max_retries=config.consolidation_llm_max_retries,
-            consolidation_llm_initial_backoff=config.consolidation_llm_initial_backoff,
-            consolidation_llm_max_backoff=config.consolidation_llm_max_backoff,
-            consolidation_llm_timeout=config.consolidation_llm_timeout,
             embeddings_provider=config.embeddings_provider,
             embeddings_local_model=config.embeddings_local_model,
-            embeddings_local_force_cpu=config.embeddings_local_force_cpu,
             embeddings_tei_url=config.embeddings_tei_url,
             embeddings_openai_base_url=config.embeddings_openai_base_url,
             embeddings_cohere_base_url=config.embeddings_cohere_base_url,
             reranker_provider=config.reranker_provider,
             reranker_local_model=config.reranker_local_model,
-            reranker_local_force_cpu=config.reranker_local_force_cpu,
-            reranker_local_max_concurrent=config.reranker_local_max_concurrent,
             reranker_tei_url=config.reranker_tei_url,
             reranker_tei_batch_size=config.reranker_tei_batch_size,
             reranker_tei_max_concurrent=config.reranker_tei_max_concurrent,
@@ -218,14 +209,16 @@ def main():
             mpfp_top_k_neighbors=config.mpfp_top_k_neighbors,
             recall_max_concurrent=config.recall_max_concurrent,
             recall_connection_budget=config.recall_connection_budget,
+            observation_min_facts=config.observation_min_facts,
+            observation_top_entities=config.observation_top_entities,
             retain_max_completion_tokens=config.retain_max_completion_tokens,
             retain_chunk_size=config.retain_chunk_size,
             retain_extract_causal_links=config.retain_extract_causal_links,
             retain_extraction_mode=config.retain_extraction_mode,
-            retain_custom_instructions=config.retain_custom_instructions,
-            enable_observations=config.enable_observations,
+            retain_observations_async=config.retain_observations_async,
+            enable_mental_models=config.enable_mental_models,
+            consolidation_similarity_threshold=config.consolidation_similarity_threshold,
             consolidation_batch_size=config.consolidation_batch_size,
-            consolidation_max_tokens=config.consolidation_max_tokens,
             skip_llm_verification=config.skip_llm_verification,
             lazy_reranker=config.lazy_reranker,
             run_migrations_on_startup=config.run_migrations_on_startup,
@@ -237,9 +230,8 @@ def main():
             worker_id=config.worker_id,
             worker_poll_interval_ms=config.worker_poll_interval_ms,
             worker_max_retries=config.worker_max_retries,
+            worker_batch_size=config.worker_batch_size,
             worker_http_port=config.worker_http_port,
-            worker_max_slots=config.worker_max_slots,
-            worker_consolidation_max_slots=config.worker_consolidation_max_slots,
             reflect_max_iterations=config.reflect_max_iterations,
             mental_model_refresh_concurrency=config.mental_model_refresh_concurrency,
         )
@@ -346,13 +338,11 @@ def main():
             embeddings_provider=config.embeddings_provider,
             reranker_provider=config.reranker_provider,
             mcp_enabled=config.mcp_enabled,
-            version=__version__,
         )
 
     # Start idle checker in daemon mode
     if idle_middleware is not None:
         # Start the idle checker in a background thread with its own event loop
-        import logging
         import threading
 
         def run_idle_checker():
@@ -363,12 +353,12 @@ def main():
                 loop = asyncio.new_event_loop()
                 asyncio.set_event_loop(loop)
                 loop.run_until_complete(idle_middleware._check_idle())
-            except Exception as e:
-                logging.error(f"Idle checker error: {e}", exc_info=True)
+            except Exception:
+                pass
 
         threading.Thread(target=run_idle_checker, daemon=True).start()
 
-    uvicorn.run(**uvicorn_config)
+    uvicorn.run(**uvicorn_config)  # type: ignore[invalid-argument-type] - dict kwargs
 
 
 if __name__ == "__main__":

hindsight-api/hindsight_api/mcp_tools.py

@@ -32,9 +32,6 @@ class MCPToolsConfig:
     # How to resolve bank_id for operations
     bank_id_resolver: Callable[[], str | None]
 
-    # How to resolve API key for tenant auth (optional)
-    api_key_resolver: Callable[[], str | None] | None = None
-
     # Whether to include bank_id as a parameter on tools (for multi-bank support)
     include_bank_id_param: bool = False
 
@@ -49,16 +46,6 @@ class MCPToolsConfig:
     retain_fire_and_forget: bool = False  # If True, use asyncio.create_task pattern
 
 
-def _get_request_context(config: MCPToolsConfig) -> RequestContext:
-    """Create RequestContext with API key from resolver if available.
-
-    This enables tenant auth to work with MCP tools by propagating
-    the Bearer token from the MCP middleware to the memory engine.
-    """
-    api_key = config.api_key_resolver() if config.api_key_resolver else None
-    return RequestContext(api_key=api_key)
-
-
 def parse_timestamp(timestamp: str) -> datetime | None:
     """Parse an ISO format timestamp string.
 
@@ -168,14 +155,12 @@ def _register_retain(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig)
                 if error:
                     return {"status": "error", "message": error}
 
-                request_context = _get_request_context(config)
-
                 async def _retain():
                     try:
                         await memory.retain_batch_async(
                             bank_id=target_bank,
                             contents=[content_dict],
-                            request_context=request_context,
+                            request_context=RequestContext(),
                         )
                     except Exception as e:
                         logger.error(f"Error storing memory: {e}", exc_info=True)
@@ -211,17 +196,16 @@ def _register_retain(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig)
                         return f"Error: {error}"
 
                     contents = [content_dict]
-                    request_context = _get_request_context(config)
                     if async_processing:
                         result = await memory.submit_async_retain(
-                            bank_id=target_bank, contents=contents, request_context=request_context
+                            bank_id=target_bank, contents=contents, request_context=RequestContext()
                         )
                         return f"Memory queued for background processing (operation_id: {result.get('operation_id', 'N/A')})"
                     else:
                         await memory.retain_batch_async(
                             bank_id=target_bank,
                             contents=contents,
-                            request_context=request_context,
+                            request_context=RequestContext(),
                         )
                         return f"Memory stored successfully in bank '{target_bank}'"
                 except Exception as e:
@@ -253,14 +237,12 @@ def _register_retain(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig)
             if error:
                 return {"status": "error", "message": error}
 
-            request_context = _get_request_context(config)
-
             async def _retain():
                 try:
                     await memory.retain_batch_async(
                         bank_id=target_bank,
                         contents=[content_dict],
-                        request_context=request_context,
+                        request_context=RequestContext(),
                     )
                 except Exception as e:
                     logger.error(f"Error storing memory: {e}", exc_info=True)
@@ -298,7 +280,7 @@ def _register_recall(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig)
                     fact_type=list(VALID_RECALL_FACT_TYPES),
                     budget=Budget.HIGH,
                     max_tokens=max_tokens,
-                    request_context=_get_request_context(config),
+                    request_context=RequestContext(),
                 )
 
                 return recall_result.model_dump_json(indent=2)
@@ -329,7 +311,7 @@ def _register_recall(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig)
                     fact_type=list(VALID_RECALL_FACT_TYPES),
                     budget=Budget.HIGH,
                     max_tokens=max_tokens,
-                    request_context=_get_request_context(config),
+                    request_context=RequestContext(),
                 )
 
                 return recall_result.model_dump()
@@ -388,7 +370,7 @@ def _register_reflect(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig
                     query=query,
                     budget=budget_enum,
                     context=context,
-                    request_context=_get_request_context(config),
+                    request_context=RequestContext(),
                 )
 
                 return reflect_result.model_dump_json(indent=2)
@@ -441,7 +423,7 @@ def _register_reflect(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsConfig
                     query=query,
                     budget=budget_enum,
                     context=context,
-                    request_context=_get_request_context(config),
+                    request_context=RequestContext(),
                 )
 
                 return reflect_result.model_dump()
@@ -465,7 +447,7 @@ def _register_list_banks(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsCon
             JSON list of banks with their IDs, names, dispositions, and missions.
         """
         try:
-            banks = await memory.list_banks(request_context=_get_request_context(config))
+            banks = await memory.list_banks(request_context=RequestContext())
             return json.dumps({"banks": banks}, indent=2)
         except Exception as e:
             logger.error(f"Error listing banks: {e}", exc_info=True)
@@ -489,9 +471,8 @@ def _register_create_bank(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsCo
             mission: Optional mission describing who the agent is and what they're trying to accomplish
         """
         try:
-            request_context = _get_request_context(config)
             # get_bank_profile auto-creates bank if it doesn't exist
-            profile = await memory.get_bank_profile(bank_id, request_context=request_context)
+            profile = await memory.get_bank_profile(bank_id, request_context=RequestContext())
 
             # Update name/mission if provided
             if name is not None or mission is not None:
@@ -499,10 +480,10 @@ def _register_create_bank(mcp: FastMCP, memory: MemoryEngine, config: MCPToolsCo
                     bank_id,
                     name=name,
                     mission=mission,
-                    request_context=request_context,
+                    request_context=RequestContext(),
                 )
                 # Fetch updated profile
-                profile = await memory.get_bank_profile(bank_id, request_context=request_context)
+                profile = await memory.get_bank_profile(bank_id, request_context=RequestContext())
 
             # Serialize disposition if it's a Pydantic model
             if "disposition" in profile and hasattr(profile["disposition"], "model_dump"):

hindsight-api/hindsight_api/metrics.py

@@ -189,7 +189,7 @@ class MetricsCollectorBase:
         Args:
             provider: LLM provider name (openai, anthropic, gemini, groq, ollama, lmstudio)
             model: Model name
-            scope: Scope identifier (e.g., "memory", "reflect", "consolidation")
+            scope: Scope identifier (e.g., "memory", "reflect", "entity_observation")
             duration: Call duration in seconds
             input_tokens: Number of input/prompt tokens
             output_tokens: Number of output/completion tokens
@@ -321,7 +321,7 @@ class MetricsCollector(MetricsCollectorBase):
                 pass
 
         Args:
-            operation: Operation name (retain, recall, reflect, consolidation)
+            operation: Operation name (retain, recall, reflect, entity_observation)
             bank_id: Memory bank ID
             source: Source of the operation (api, reflect, internal)
             budget: Optional budget level (low, mid, high)
@@ -371,7 +371,7 @@ class MetricsCollector(MetricsCollectorBase):
         Args:
             provider: LLM provider name (openai, anthropic, gemini, groq, ollama, lmstudio)
             model: Model name
-            scope: Scope identifier (e.g., "memory", "reflect", "consolidation")
+            scope: Scope identifier (e.g., "memory", "reflect", "entity_observation")
             duration: Call duration in seconds
             input_tokens: Number of input/prompt tokens
             output_tokens: Number of output/completion tokens

hindsight-api/hindsight_api/migrations.py

@@ -165,81 +165,6 @@ def run_migrations(
             logger.debug("Migration advisory lock acquired")
 
             try:
-                # Ensure pgvector extension is installed globally BEFORE schema migrations
-                # This is critical: the extension must exist database-wide before any schema
-                # migrations run, otherwise custom schemas won't have access to vector types
-                logger.debug("Checking pgvector extension availability...")
-
-                # First, check if extension already exists
-                ext_check = conn.execute(
-                    text(
-                        "SELECT extname, nspname FROM pg_extension e "
-                        "JOIN pg_namespace n ON e.extnamespace = n.oid "
-                        "WHERE extname = 'vector'"
-                    )
-                ).fetchone()
-
-                if ext_check:
-                    # Extension exists - check if in correct schema
-                    ext_schema = ext_check[1]
-                    if ext_schema == "public":
-                        logger.info("pgvector extension found in public schema - ready to use")
-                    else:
-                        # Extension in wrong schema - try to fix if we have permissions
-                        logger.warning(
-                            f"pgvector extension found in schema '{ext_schema}' instead of 'public'. "
-                            f"Attempting to relocate..."
-                        )
-                        try:
-                            conn.execute(text("DROP EXTENSION vector CASCADE"))
-                            conn.execute(text("SET search_path TO public"))
-                            conn.execute(text("CREATE EXTENSION vector"))
-                            conn.commit()
-                            logger.info("pgvector extension relocated to public schema")
-                        except Exception as e:
-                            # Failed to relocate - log but don't fail if extension exists somewhere
-                            logger.warning(
-                                f"Could not relocate pgvector extension to public schema: {e}. "
-                                f"Continuing with extension in '{ext_schema}' schema."
-                            )
-                            conn.rollback()
-                else:
-                    # Extension doesn't exist - try to install
-                    logger.info("pgvector extension not found, attempting to install...")
-                    try:
-                        conn.execute(text("SET search_path TO public"))
-                        conn.execute(text("CREATE EXTENSION vector"))
-                        conn.commit()
-                        logger.info("pgvector extension installed in public schema")
-                    except Exception as e:
-                        # Installation failed - this is only fatal if extension truly doesn't exist
-                        # Check one more time in case another process installed it
-                        conn.rollback()
-                        ext_recheck = conn.execute(
-                            text(
-                                "SELECT nspname FROM pg_extension e "
-                                "JOIN pg_namespace n ON e.extnamespace = n.oid "
-                                "WHERE extname = 'vector'"
-                            )
-                        ).fetchone()
-
-                        if ext_recheck:
-                            logger.warning(
-                                f"Could not install pgvector extension (permission denied?), "
-                                f"but extension exists in '{ext_recheck[0]}' schema. Continuing..."
-                            )
-                        else:
-                            # Extension truly doesn't exist and we can't install it
-                            logger.error(
-                                f"pgvector extension is not installed and cannot be installed: {e}. "
-                                f"Please ensure pgvector is installed by a database administrator. "
-                                f"See: https://github.com/pgvector/pgvector#installation"
-                            )
-                            raise RuntimeError(
-                                "pgvector extension is required but not installed. "
-                                "Please install it with: CREATE EXTENSION vector;"
-                            ) from e
-
                 # Run migrations while holding the lock
                 _run_migrations_internal(database_url, script_location, schema=schema)
             finally:

hindsight-api/hindsight_api/pg0.py

@@ -40,7 +40,7 @@ class EmbeddedPostgres:
             # Only set port if explicitly specified
             if self.port is not None:
                 kwargs["port"] = self.port
-            self._pg0 = Pg0(**kwargs)
+            self._pg0 = Pg0(**kwargs)  # type: ignore[invalid-argument-type] - dict kwargs
         return self._pg0
 
     async def start(self, max_retries: int = 5, retry_delay: float = 4.0) -> str:

hindsight-api/hindsight_api/worker/main.py

@@ -124,6 +124,12 @@ def main():
         default=config.worker_poll_interval_ms,
         help=f"Poll interval in milliseconds (default: {config.worker_poll_interval_ms}, env: HINDSIGHT_API_WORKER_POLL_INTERVAL_MS)",
     )
+    parser.add_argument(
+        "--batch-size",
+        type=int,
+        default=config.worker_batch_size,
+        help=f"Tasks to claim per poll (default: {config.worker_batch_size}, env: HINDSIGHT_API_WORKER_BATCH_SIZE)",
+    )
     parser.add_argument(
         "--max-retries",
         type=int,
@@ -162,9 +168,8 @@ def main():
 
     print(f"Starting Hindsight Worker: {args.worker_id}")
     print(f"  Poll interval: {args.poll_interval}ms")
+    print(f"  Batch size: {args.batch_size}")
     print(f"  Max retries: {args.max_retries}")
-    print(f"  Max slots: {config.worker_max_slots}")
-    print(f"  Consolidation max slots: {config.worker_consolidation_max_slots}")
     print(f"  HTTP server: {args.http_host}:{args.http_port}")
     print()
 
@@ -176,19 +181,7 @@ def main():
         nonlocal memory, poller
         import uvicorn
 
-        from ..extensions import OperationValidatorExtension, TenantExtension, load_extension
-
-        # Load tenant extension BEFORE creating MemoryEngine so it can
-        # set correct schema context during task execution. Without this,
-        # _authenticate_tenant sees no extension and resets schema to "public",
-        # causing worker writes to land in the wrong schema.
-        tenant_extension = load_extension("TENANT", TenantExtension)
-
-        # Load operation validator so workers can record usage metering
-        # for async operations (e.g. refresh_mental_model after consolidation)
-        operation_validator = load_extension("OPERATION_VALIDATOR", OperationValidatorExtension)
-        if operation_validator:
-            logger.info(f"Loaded operation validator: {operation_validator.__class__.__name__}")
+        from ..extensions import TenantExtension, load_extension
 
         # Initialize MemoryEngine
         # Workers use SyncTaskBackend because they execute tasks directly,
@@ -196,63 +189,43 @@ def main():
         memory = MemoryEngine(
             run_migrations=False,  # Workers don't run migrations
             task_backend=SyncTaskBackend(),
-            tenant_extension=tenant_extension,
-            operation_validator=operation_validator,
         )
 
         await memory.initialize()
 
         print(f"Database connected: {config.database_url}")
 
+        # Load tenant extension for dynamic schema discovery
+        tenant_extension = load_extension("TENANT", TenantExtension)
+
         if tenant_extension:
             print("Tenant extension loaded - schemas will be discovered dynamically on each poll")
         else:
-            print(f"No tenant extension configured, using schema: {config.database_schema}")
+            print("No tenant extension configured, using public schema only")
 
         # Create a single poller that handles all schemas dynamically
-        # Convert default schema to None for SQL compatibility (no schema prefix)
-        from hindsight_api.config import DEFAULT_DATABASE_SCHEMA
-
-        schema = None if config.database_schema == DEFAULT_DATABASE_SCHEMA else config.database_schema
         poller = WorkerPoller(
             pool=memory._pool,
             worker_id=args.worker_id,
             executor=memory.execute_task,
             poll_interval_ms=args.poll_interval,
+            batch_size=args.batch_size,
             max_retries=args.max_retries,
-            schema=schema,
             tenant_extension=tenant_extension,
-            max_slots=config.worker_max_slots,
-            consolidation_max_slots=config.worker_consolidation_max_slots,
         )
 
         # Create the HTTP app for metrics/health
         app = create_worker_app(poller, memory)
 
-        # Setup signal handlers for graceful shutdown using asyncio
+        # Setup signal handlers for graceful shutdown
         shutdown_requested = asyncio.Event()
-        force_exit = False
 
-        loop = asyncio.get_event_loop()
+        def signal_handler(signum, frame):
+            print(f"\nReceived signal {signum}, initiating graceful shutdown...")
+            shutdown_requested.set()
 
-        def signal_handler():
-            nonlocal force_exit
-            if shutdown_requested.is_set():
-                # Second signal = force exit
-                print("\nReceived second signal, forcing immediate exit...")
-                force_exit = True
-                # Restore default handler so third signal kills process
-                loop.remove_signal_handler(signal.SIGINT)
-                loop.remove_signal_handler(signal.SIGTERM)
-                sys.exit(1)
-            else:
-                print("\nReceived shutdown signal, initiating graceful shutdown...")
-                print("(Press Ctrl+C again to force immediate exit)")
-                shutdown_requested.set()
-
-        # Use asyncio's signal handlers which work properly with the event loop
-        loop.add_signal_handler(signal.SIGINT, signal_handler)
-        loop.add_signal_handler(signal.SIGTERM, signal_handler)
+        signal.signal(signal.SIGINT, signal_handler)
+        signal.signal(signal.SIGTERM, signal_handler)
 
         # Create uvicorn config and server
         uvicorn_config = uvicorn.Config(
@@ -271,10 +244,7 @@ def main():
         print(f"Worker started. Metrics available at http://{args.http_host}:{args.http_port}/metrics")
 
         # Wait for shutdown signal
-        try:
-            await shutdown_requested.wait()
-        except KeyboardInterrupt:
-            print("\nReceived interrupt, initiating graceful shutdown...")
+        await shutdown_requested.wait()
 
         # Graceful shutdown
         print("Shutting down HTTP server...")

hindsight-api/hindsight_api/worker/poller.py

@@ -57,11 +57,10 @@ class WorkerPoller:
         worker_id: str,
         executor: Callable[[dict[str, Any]], Awaitable[None]],
         poll_interval_ms: int = 500,
+        batch_size: int = 10,
         max_retries: int = 3,
         schema: str | None = None,
         tenant_extension: "TenantExtension | None" = None,
-        max_slots: int = 10,
-        consolidation_max_slots: int = 2,
     ):
         """
         Initialize the worker poller.
@@ -71,158 +70,91 @@ class WorkerPoller:
             worker_id: Unique identifier for this worker
             executor: Async function to execute tasks (typically MemoryEngine.execute_task)
             poll_interval_ms: Interval between polls when no tasks found (milliseconds)
+            batch_size: Maximum number of tasks to claim per poll cycle
             max_retries: Maximum retry attempts before marking task as failed
-            schema: Database schema for single-tenant support (deprecated, use tenant_extension)
-            tenant_extension: Extension for dynamic multi-tenant discovery. If None, creates a
-                            DefaultTenantExtension with the configured schema.
-            max_slots: Maximum concurrent tasks per worker
-            consolidation_max_slots: Maximum concurrent consolidation tasks per worker
+            schema: Database schema for single-tenant support (ignored if tenant_extension is set)
+            tenant_extension: Extension for dynamic multi-tenant discovery. If set, list_tenants()
+                            is called on each poll cycle to discover schemas dynamically.
         """
         self._pool = pool
         self._worker_id = worker_id
         self._executor = executor
         self._poll_interval_ms = poll_interval_ms
+        self._batch_size = batch_size
         self._max_retries = max_retries
         self._schema = schema
-        # Always set tenant extension (use DefaultTenantExtension if none provided)
-        if tenant_extension is None:
-            from ..extensions.builtin.tenant import DefaultTenantExtension
-
-            # Pass schema parameter to DefaultTenantExtension if explicitly provided
-            config = {"schema": schema} if schema else {}
-            tenant_extension = DefaultTenantExtension(config=config)
         self._tenant_extension = tenant_extension
-        self._max_slots = max_slots
-        self._consolidation_max_slots = consolidation_max_slots
         self._shutdown = asyncio.Event()
         self._current_tasks: set[asyncio.Task] = set()
         self._in_flight_count = 0
         self._in_flight_lock = asyncio.Lock()
         self._last_progress_log = 0.0
         self._tasks_completed_since_log = 0
-        # Track active tasks locally: operation_id -> (op_type, bank_id, schema, asyncio.Task)
-        self._active_tasks: dict[str, tuple[str, str, str | None, asyncio.Task]] = {}
-        # Track in-flight tasks by operation type
-        self._in_flight_by_type: dict[str, int] = {}
+        # Track active tasks locally: operation_id -> (op_type, bank_id, schema)
+        self._active_tasks: dict[str, tuple[str, str, str | None]] = {}
 
     async def _get_schemas(self) -> list[str | None]:
-        """Get list of schemas to poll. Returns [None] for default schema (no prefix)."""
-        from ..config import DEFAULT_DATABASE_SCHEMA
-
-        tenants = await self._tenant_extension.list_tenants()
-        # Convert default schema to None for SQL compatibility (no prefix), keep others as-is
-        return [t.schema if t.schema != DEFAULT_DATABASE_SCHEMA else None for t in tenants]
-
-    async def _get_available_slots(self) -> tuple[int, int]:
-        """
-        Calculate available slots for claiming tasks.
-
-        Returns:
-            (total_available, consolidation_available) tuple
-        """
-        async with self._in_flight_lock:
-            total_in_flight = self._in_flight_count
-            consolidation_in_flight = self._in_flight_by_type.get("consolidation", 0)
-
-        total_available = max(0, self._max_slots - total_in_flight)
-        consolidation_available = max(0, self._consolidation_max_slots - consolidation_in_flight)
-
-        return total_available, consolidation_available
-
-    async def wait_for_active_tasks(self, timeout: float = 10.0) -> bool:
-        """
-        Wait for all active background tasks to complete (test helper).
-
-        This is a test-only utility that allows tests to synchronize with
-        fire-and-forget background tasks without using sleep().
-
-        Args:
-            timeout: Maximum time to wait in seconds
-
-        Returns:
-            True if all tasks completed, False if timeout was reached
-        """
-        start_time = asyncio.get_event_loop().time()
-        while True:
-            async with self._in_flight_lock:
-                if self._in_flight_count == 0:
-                    return True
-
-            elapsed = asyncio.get_event_loop().time() - start_time
-            if elapsed >= timeout:
-                return False
-
-            # Short sleep to avoid busy-waiting
-            await asyncio.sleep(0.01)
+        """Get list of schemas to poll. Returns [None] for public schema."""
+        if self._tenant_extension is not None:
+            tenants = await self._tenant_extension.list_tenants()
+            # Convert "public" to None for SQL compatibility, keep others as-is
+            return [t.schema if t.schema != "public" else None for t in tenants]
+        # Single schema mode
+        return [self._schema]
 
     async def claim_batch(self) -> list[ClaimedTask]:
         """
-        Claim pending tasks atomically across all tenant schemas,
-        respecting slot limits (total and consolidation).
+        Claim up to batch_size pending tasks atomically across all tenant schemas.
 
         Uses FOR UPDATE SKIP LOCKED to ensure no conflicts with other workers.
 
+        For consolidation tasks specifically, skips pending tasks if there's already
+        a processing consolidation for the same bank (to avoid duplicate work).
+
+        If tenant_extension is configured, dynamically discovers schemas on each call.
+
         Returns:
             List of ClaimedTask objects containing operation_id, task_dict, and schema
         """
-        # Calculate available slots
-        total_available, consolidation_available = await self._get_available_slots()
-
-        if total_available <= 0:
-            return []
-
         schemas = await self._get_schemas()
         all_tasks: list[ClaimedTask] = []
-        remaining_total = total_available
-        remaining_consolidation = consolidation_available
+        remaining_batch = self._batch_size
 
         for schema in schemas:
-            if remaining_total <= 0:
+            if remaining_batch <= 0:
                 break
 
-            tasks = await self._claim_batch_for_schema(schema, remaining_total, remaining_consolidation)
-
-            # Update remaining slots based on what was claimed
-            for task in tasks:
-                op_type = task.task_dict.get("operation_type", "unknown")
-                if op_type == "consolidation":
-                    remaining_consolidation -= 1
-
+            tasks = await self._claim_batch_for_schema(schema, remaining_batch)
             all_tasks.extend(tasks)
-            remaining_total -= len(tasks)
+            remaining_batch -= len(tasks)
 
         return all_tasks
 
-    async def _claim_batch_for_schema(
-        self, schema: str | None, limit: int, consolidation_limit: int
-    ) -> list[ClaimedTask]:
-        """Claim tasks from a specific schema respecting slot limits."""
-        try:
-            return await self._claim_batch_for_schema_inner(schema, limit, consolidation_limit)
-        except Exception as e:
-            # Format schema for logging: custom schemas in quotes, None as-is
-            schema_display = f'"{schema}"' if schema else str(schema)
-            logger.warning(f"Worker {self._worker_id} failed to claim tasks for schema {schema_display}: {e}")
-            return []
-
-    async def _claim_batch_for_schema_inner(
-        self, schema: str | None, limit: int, consolidation_limit: int
-    ) -> list[ClaimedTask]:
-        """Inner implementation for claiming tasks from a specific schema with slot limits."""
+    async def _claim_batch_for_schema(self, schema: str | None, limit: int) -> list[ClaimedTask]:
+        """Claim tasks from a specific schema."""
         table = fq_table("async_operations", schema)
 
         async with self._pool.acquire() as conn:
             async with conn.transaction():
-                # Strategy: Claim non-consolidation tasks first, then consolidation up to limit
-
-                # 1. Claim non-consolidation tasks (up to limit)
-                non_consolidation_rows = await conn.fetch(
+                # Select and lock pending tasks
+                # For consolidation: skip if same bank already has one processing
+                rows = await conn.fetch(
                     f"""
                     SELECT operation_id, task_payload
-                    FROM {table}
-                    WHERE status = 'pending'
-                      AND task_payload IS NOT NULL
-                      AND operation_type != 'consolidation'
+                    FROM {table} AS pending
+                    WHERE status = 'pending' AND task_payload IS NOT NULL
+                    AND (
+                        -- Non-consolidation tasks: always claimable
+                        operation_type != 'consolidation'
+                        OR
+                        -- Consolidation: only if no other consolidation processing for same bank
+                        NOT EXISTS (
+                            SELECT 1 FROM {table} AS processing
+                            WHERE processing.bank_id = pending.bank_id
+                            AND processing.operation_type = 'consolidation'
+                            AND processing.status = 'processing'
+                        )
+                    )
                     ORDER BY created_at
                     LIMIT $1
                     FOR UPDATE SKIP LOCKED
@@ -230,39 +162,11 @@ class WorkerPoller:
                     limit,
                 )
 
-                claimed_count = len(non_consolidation_rows)
-                remaining_limit = limit - claimed_count
-
-                # 2. Claim consolidation tasks (up to consolidation_limit and remaining_limit)
-                consolidation_rows = []
-                if consolidation_limit > 0 and remaining_limit > 0:
-                    consolidation_rows = await conn.fetch(
-                        f"""
-                        SELECT operation_id, task_payload
-                        FROM {table} AS pending
-                        WHERE status = 'pending'
-                          AND task_payload IS NOT NULL
-                          AND operation_type = 'consolidation'
-                          AND NOT EXISTS (
-                              SELECT 1 FROM {table} AS processing
-                              WHERE processing.bank_id = pending.bank_id
-                                AND processing.operation_type = 'consolidation'
-                                AND processing.status = 'processing'
-                          )
-                        ORDER BY created_at
-                        LIMIT $1
-                        FOR UPDATE SKIP LOCKED
-                        """,
-                        min(consolidation_limit, remaining_limit),
-                    )
-
-                all_rows = non_consolidation_rows + consolidation_rows
-
-                if not all_rows:
+                if not rows:
                     return []
 
                 # Claim the tasks by updating status and worker_id
-                operation_ids = [row["operation_id"] for row in all_rows]
+                operation_ids = [row["operation_id"] for row in rows]
                 await conn.execute(
                     f"""
                     UPDATE {table}
@@ -280,7 +184,7 @@ class WorkerPoller:
                         task_dict=json.loads(row["task_payload"]),
                         schema=schema,
                     )
-                    for row in all_rows
+                    for row in rows
                 ]
 
     async def _mark_completed(self, operation_id: str, schema: str | None):
@@ -346,45 +250,17 @@ class WorkerPoller:
             logger.warning(f"Task {operation_id} failed, will retry (attempt {retry_count + 1}/{self._max_retries})")
 
     async def execute_task(self, task: ClaimedTask):
-        """Execute a single task as a background job (fire-and-forget)."""
+        """Execute a single task and update its status."""
         task_type = task.task_dict.get("type", "unknown")
-        operation_type = task.task_dict.get("operation_type", "unknown")
         bank_id = task.task_dict.get("bank_id", "unknown")
 
-        # Create background task
-        bg_task = asyncio.create_task(self._execute_task_inner(task))
-
         # Track this task as active
         async with self._in_flight_lock:
-            self._active_tasks[task.operation_id] = (task_type, bank_id, task.schema, bg_task)
-            self._in_flight_count += 1
-            self._in_flight_by_type[operation_type] = self._in_flight_by_type.get(operation_type, 0) + 1
-
-        # Add cleanup callback
-        bg_task.add_done_callback(lambda _: asyncio.create_task(self._cleanup_task(task.operation_id, operation_type)))
-
-    async def _cleanup_task(self, operation_id: str, operation_type: str):
-        """Remove task from tracking after completion."""
-        async with self._in_flight_lock:
-            if operation_id in self._active_tasks:
-                self._active_tasks.pop(operation_id, None)
-                self._in_flight_count -= 1
-                count = self._in_flight_by_type.get(operation_type, 0)
-                if count > 0:
-                    self._in_flight_by_type[operation_type] = count - 1
-                    if self._in_flight_by_type[operation_type] == 0:
-                        del self._in_flight_by_type[operation_type]
-
-    async def _execute_task_inner(self, task: ClaimedTask):
-        """Inner task execution with error handling."""
-        task_type = task.task_dict.get("type", "unknown")
-        bank_id = task.task_dict.get("bank_id", "unknown")
+            self._active_tasks[task.operation_id] = (task_type, bank_id, task.schema)
 
         try:
             schema_info = f", schema={task.schema}" if task.schema else ""
             logger.debug(f"Executing task {task.operation_id} (type={task_type}, bank={bank_id}{schema_info})")
-            if task.schema:
-                task.task_dict["_schema"] = task.schema
             await self._executor(task.task_dict)
             await self._mark_completed(task.operation_id, task.schema)
             logger.debug(f"Task {task.operation_id} completed successfully")
@@ -392,6 +268,10 @@ class WorkerPoller:
             error_msg = f"{type(e).__name__}: {e}\n{traceback.format_exc()}"
             logger.error(f"Task {task.operation_id} failed: {e}")
             await self._retry_or_fail(task.operation_id, error_msg, task.schema)
+        finally:
+            # Remove from active tasks
+            async with self._in_flight_lock:
+                self._active_tasks.pop(task.operation_id, None)
 
     async def recover_own_tasks(self) -> int:
         """
@@ -410,25 +290,20 @@ class WorkerPoller:
         total_count = 0
 
         for schema in schemas:
-            try:
-                table = fq_table("async_operations", schema)
+            table = fq_table("async_operations", schema)
 
-                result = await self._pool.execute(
-                    f"""
-                    UPDATE {table}
-                    SET status = 'pending', worker_id = NULL, claimed_at = NULL, updated_at = now()
-                    WHERE status = 'processing' AND worker_id = $1
-                    """,
-                    self._worker_id,
-                )
+            result = await self._pool.execute(
+                f"""
+                UPDATE {table}
+                SET status = 'pending', worker_id = NULL, claimed_at = NULL, updated_at = now()
+                WHERE status = 'processing' AND worker_id = $1
+                """,
+                self._worker_id,
+            )
 
-                # Parse "UPDATE N" to get count
-                count = int(result.split()[-1]) if result else 0
-                total_count += count
-            except Exception as e:
-                # Format schema for logging: custom schemas in quotes, None as-is
-                schema_display = f'"{schema}"' if schema else str(schema)
-                logger.warning(f"Worker {self._worker_id} failed to recover tasks for schema {schema_display}: {e}")
+            # Parse "UPDATE N" to get count
+            count = int(result.split()[-1]) if result else 0
+            total_count += count
 
         if total_count > 0:
             logger.info(f"Worker {self._worker_id} recovered {total_count} stale tasks from previous run")
@@ -436,60 +311,59 @@ class WorkerPoller:
 
     async def run(self):
         """
-        Main polling loop with fire-and-forget task execution.
+        Main polling loop.
 
-        Continuously polls for pending tasks, spawns them as background tasks,
-        and immediately continues polling (up to slot limits).
+        Continuously polls for pending tasks, claims them, and executes them
+        until shutdown is signaled.
+
+        If tenant_extension is configured, dynamically discovers schemas on each poll.
         """
+        # Recover any tasks from a previous crash before starting
         await self.recover_own_tasks()
 
-        logger.info(
-            f"Worker {self._worker_id} starting polling loop "
-            f"(max_slots={self._max_slots}, consolidation_max_slots={self._consolidation_max_slots})"
-        )
+        logger.info(f"Worker {self._worker_id} starting polling loop")
 
         while not self._shutdown.is_set():
             try:
-                # Claim a batch of tasks (respecting slot limits)
+                # Claim a batch of tasks (across all tenant schemas if configured)
                 tasks = await self.claim_batch()
 
                 if tasks:
                     # Log batch info
                     task_types: dict[str, int] = {}
                     schemas_seen: set[str | None] = set()
-                    consolidation_count = 0
                     for task in tasks:
                         t = task.task_dict.get("type", "unknown")
-                        op_type = task.task_dict.get("operation_type", "unknown")
                         task_types[t] = task_types.get(t, 0) + 1
                         schemas_seen.add(task.schema)
-                        if op_type == "consolidation":
-                            consolidation_count += 1
-
                     types_str = ", ".join(f"{k}:{v}" for k, v in task_types.items())
-                    # Display None as "default" in logs
-                    schemas_str = ", ".join(s if s else "default" for s in schemas_seen)
+                    schemas_str = ", ".join(s or "public" for s in schemas_seen)
                     logger.info(
-                        f"Worker {self._worker_id} claimed {len(tasks)} tasks "
-                        f"({consolidation_count} consolidation): {types_str} (schemas: {schemas_str})"
+                        f"Worker {self._worker_id} claimed {len(tasks)} tasks: {types_str} (schemas: {schemas_str})"
                     )
 
-                    # Spawn tasks as background jobs (fire-and-forget)
-                    for task in tasks:
-                        await self.execute_task(task)
+                    # Track in-flight tasks
+                    async with self._in_flight_lock:
+                        self._in_flight_count += len(tasks)
 
-                    # Continue immediately to claim more tasks (if slots available)
-                    continue
-
-                # No tasks claimed (either no pending tasks or slots full)
-                # Wait before polling again
-                try:
-                    await asyncio.wait_for(
-                        self._shutdown.wait(),
-                        timeout=self._poll_interval_ms / 1000,
-                    )
-                except asyncio.TimeoutError:
-                    pass  # Normal timeout, continue polling
+                    # Execute tasks concurrently
+                    try:
+                        await asyncio.gather(
+                            *[self.execute_task(task) for task in tasks],
+                            return_exceptions=True,
+                        )
+                    finally:
+                        async with self._in_flight_lock:
+                            self._in_flight_count -= len(tasks)
+                else:
+                    # No tasks found, wait before polling again
+                    try:
+                        await asyncio.wait_for(
+                            self._shutdown.wait(),
+                            timeout=self._poll_interval_ms / 1000,
+                        )
+                    except asyncio.TimeoutError:
+                        pass  # Normal timeout, continue polling
 
                 # Log progress stats periodically
                 await self._log_progress_if_due()
@@ -520,27 +394,15 @@ class WorkerPoller:
         while asyncio.get_event_loop().time() - start_time < timeout:
             async with self._in_flight_lock:
                 in_flight = self._in_flight_count
-                active_task_objects = [task_info[3] for task_info in self._active_tasks.values()]
 
             if in_flight == 0:
                 logger.info(f"Worker {self._worker_id} graceful shutdown complete")
                 return
 
             logger.info(f"Worker {self._worker_id} waiting for {in_flight} in-flight tasks")
+            await asyncio.sleep(0.5)
 
-            # Wait for at least one task to complete
-            if active_task_objects:
-                done, _ = await asyncio.wait(active_task_objects, timeout=0.5, return_when=asyncio.FIRST_COMPLETED)
-            else:
-                await asyncio.sleep(0.5)
-
-        logger.warning(f"Worker {self._worker_id} shutdown timeout after {timeout}s, cancelling remaining tasks")
-
-        # Cancel remaining tasks
-        async with self._in_flight_lock:
-            for operation_id, (_, _, _, bg_task) in list(self._active_tasks.items()):
-                if not bg_task.done():
-                    bg_task.cancel()
+        logger.warning(f"Worker {self._worker_id} shutdown timeout after {timeout}s")
 
     async def _log_progress_if_due(self):
         """Log progress stats every PROGRESS_LOG_INTERVAL seconds."""
@@ -551,19 +413,14 @@ class WorkerPoller:
         self._last_progress_log = now
 
         try:
-            # Get local active tasks
+            # Get local active tasks (this worker only)
             async with self._in_flight_lock:
                 in_flight = self._in_flight_count
-                in_flight_by_type = dict(self._in_flight_by_type)
-                active_tasks = dict(self._active_tasks)
+                active_tasks = dict(self._active_tasks)  # Copy to avoid holding lock
 
-            consolidation_count = in_flight_by_type.get("consolidation", 0)
-            available_slots = self._max_slots - in_flight
-            available_consolidation_slots = self._consolidation_max_slots - consolidation_count
-
-            # Build local processing breakdown
+            # Build local processing breakdown grouped by (op_type, bank_id)
             task_groups: dict[tuple[str, str], int] = {}
-            for op_type, bank_id, _, _ in active_tasks.values():
+            for op_type, bank_id, _ in active_tasks.values():
                 key = (op_type, bank_id)
                 task_groups[key] = task_groups.get(key, 0) + 1
 
@@ -572,7 +429,7 @@ class WorkerPoller:
             if len(processing_info) > 10:
                 processing_str += f" +{len(processing_info) - 10} more"
 
-            # Get global stats from DB
+            # Get global stats from DB across all schemas
             schemas = await self._get_schemas()
             global_pending = 0
             all_worker_counts: dict[str, int] = {}
@@ -584,6 +441,7 @@ class WorkerPoller:
                     row = await conn.fetchrow(f"SELECT COUNT(*) as count FROM {table} WHERE status = 'pending'")
                     global_pending += row["count"] if row else 0
 
+                    # Get processing breakdown by worker
                     worker_rows = await conn.fetch(
                         f"""
                         SELECT worker_id, COUNT(*) as count
@@ -596,18 +454,16 @@ class WorkerPoller:
                         wid = wr["worker_id"] or "unknown"
                         all_worker_counts[wid] = all_worker_counts.get(wid, 0) + wr["count"]
 
+            # Format other workers' processing counts
             other_workers = []
             for wid, cnt in all_worker_counts.items():
                 if wid != self._worker_id:
                     other_workers.append(f"{wid}:{cnt}")
             others_str = ", ".join(other_workers) if other_workers else "none"
 
-            # Display None as "default" in logs
-            schemas_str = ", ".join(s if s else "default" for s in schemas)
+            schemas_str = ", ".join(s or "public" for s in schemas)
             logger.info(
-                f"[WORKER_STATS] worker={self._worker_id} "
-                f"slots={in_flight}/{self._max_slots} (consolidation={consolidation_count}/{self._consolidation_max_slots}) | "
-                f"available={available_slots} (consolidation={available_consolidation_slots}) | "
+                f"[WORKER_STATS] worker={self._worker_id} in_flight={in_flight} | "
                 f"global: pending={global_pending} (schemas: {schemas_str}) | "
                 f"others: {others_str} | "
                 f"my_active: {processing_str}"

hindsight-api/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "hindsight-api"
-version = "0.4.8"
+version = "0.3.0"
 description = "Hindsight: Agent Memory That Works Like Human Memory"
 readme = "README.md"
 requires-python = ">=3.11"
@@ -25,7 +25,7 @@ dependencies = [
     "psycopg2-binary>=2.9.11",
     "tiktoken>=0.12.0",
     "httpx>=0.27.0",
-    "fastmcp>=2.14.0", # CVE-2025-66416
+    "fastmcp>=2.14.0",  # CVE-2025-66416
     "pg0-embedded>=0.11.0",
     "python-dateutil>=2.8.0",
     "opentelemetry-api>=1.20.0",
@@ -34,24 +34,22 @@ dependencies = [
     "opentelemetry-exporter-prometheus>=0.41b0",
     "dateparser>=1.2.2",
     "google-genai>=1.0.0",
-    "google-auth>=2.0.0",
     "anthropic>=0.40.0",
     "typer>=0.9.0",
     "cohere>=5.0.0",
     "flashrank>=0.2.0",
     # Local ML models for embeddings/reranking - can be excluded in Docker with INCLUDE_LOCAL_MODELS=false
     "sentence-transformers>=3.3.0",
-    "transformers>=4.53.0", # Security fixes for ReDoS vulnerabilities
-    "torch>=2.6.0", # CVE fix for remote code execution
+    "transformers>=4.53.0",  # Security fixes for ReDoS vulnerabilities
+    "torch>=2.6.0",  # CVE fix for remote code execution
     "uvloop>=0.22.1",
     # Transitive dependency security fixes
-    "pyasn1>=0.6.2", # DoS vulnerability fix
-    "urllib3>=2.6.3", # Decompression-bomb safeguards bypass fix
-    "langchain-core>=1.2.5", # Serialization injection vulnerability fix
-    "filelock>=3.20.1", # TOCTOU race condition fix
-    "authlib>=1.6.6", # Account takeover vulnerability fix
-    "aiohttp>=3.13.3", # Multiple DoS vulnerabilities
-    "claude-agent-sdk>=0.1.27",
+    "pyasn1>=0.6.2",  # DoS vulnerability fix
+    "urllib3>=2.6.3",  # Decompression-bomb safeguards bypass fix
+    "langchain-core>=1.2.5",  # Serialization injection vulnerability fix
+    "filelock>=3.20.1",  # TOCTOU race condition fix
+    "authlib>=1.6.6",  # Account takeover vulnerability fix
+    "aiohttp>=3.13.3",  # Multiple DoS vulnerabilities
 ]
 
 [project.optional-dependencies]
@@ -143,11 +141,6 @@ known-third-party = ["alembic"]
 quote-style = "double"
 indent-style = "space"
 
-[tool.uv]
-# Allow uv to search all configured indexes for packages, not just the first one
-# This prevents dependency resolution failures when using pytorch index + PyPI
-index-strategy = "unsafe-best-match"
-
 [tool.ty]
 # Type checking configuration
 # ty is an extremely fast Python type checker from Astral (same team as ruff/uv)

hindsight-api/tests/test_fact_extraction_analysis.py

@@ -58,6 +58,7 @@ async def test_fact_extraction_basic_analysis(llm_config):
         llm_config=llm_config,
         agent_name="test-agent",
         context="Friday Standup meeting",
+        extract_opinions=False,
     )
 
     duration = time.time() - start_time

hindsight-api/tests/test_http_api_integration.py

@@ -1063,169 +1063,3 @@ async def test_retain_async_no_usage(api_client):
 
     # Usage should be None for async operations
     assert result.get("usage") is None, "Async retain should not include usage"
-
-
-@pytest.mark.asyncio
-async def test_version_endpoint_returns_correct_version(api_client):
-    """Test that the /version endpoint returns the correct API version.
-
-    The version should match the __version__ defined in hindsight_api.__init__.py
-    and should not be a hardcoded string.
-    """
-    from hindsight_api import __version__
-
-    # Call the /version endpoint
-    response = await api_client.get("/version")
-    assert response.status_code == 200
-    result = response.json()
-
-    # Verify response structure
-    assert "api_version" in result, "Response should include 'api_version' field"
-    assert "features" in result, "Response should include 'features' field"
-
-    # Verify the version matches the package version
-    assert result["api_version"] == __version__, (
-        f"API version should be {__version__}, got {result['api_version']}"
-    )
-
-    # Verify features field structure
-    features = result["features"]
-    assert "observations" in features
-    assert "mcp" in features
-    assert "worker" in features
-    assert isinstance(features["observations"], bool)
-    assert isinstance(features["mcp"], bool)
-    assert isinstance(features["worker"], bool)
-
-    print(f"Version endpoint returned: api_version={result['api_version']}, features={features}")
-
-
-@pytest.mark.asyncio
-async def test_retain_with_timestamp_async(api_client, test_bank_id):
-    """Test that async retain accepts timestamp field and serializes correctly."""
-    response = await api_client.post(
-        f"/v1/default/banks/{test_bank_id}/memories",
-        json={
-            "items": [
-                {
-                    "content": "Test memory with timestamp",
-                    "context": "test",
-                    "timestamp": "2026-01-30T11:45:00Z"
-                }
-            ],
-            "async": True
-        }
-    )
-    
-    assert response.status_code == 200, f"Expected 200, got {response.status_code}: {response.text}"
-    data = response.json()
-    assert data["success"] is True
-    assert data["async"] is True
-    assert "operation_id" in data
-    
-
-@pytest.mark.asyncio
-async def test_retain_with_timestamp_sync(api_client, test_bank_id):
-    """Test that sync retain accepts timestamp field."""
-    response = await api_client.post(
-        f"/v1/default/banks/{test_bank_id}/memories",
-        json={
-            "items": [
-                {
-                    "content": "Test memory with timestamp sync",
-                    "context": "test", 
-                    "timestamp": "2026-01-30T11:45:00Z"
-                }
-            ],
-            "async": False
-        }
-    )
-    
-    assert response.status_code == 200, f"Expected 200, got {response.status_code}: {response.text}"
-    data = response.json()
-    assert data["success"] is True
-    assert data["async"] is False
-    
-
-@pytest.mark.asyncio
-async def test_retain_with_multiple_timestamps(api_client, test_bank_id):
-    """Test that multiple items with different timestamp formats work."""
-    response = await api_client.post(
-        f"/v1/default/banks/{test_bank_id}/memories",
-        json={
-            "items": [
-                {
-                    "content": "Event 1",
-                    "timestamp": "2026-01-30T11:45:00Z"  # With Z
-                },
-                {
-                    "content": "Event 2", 
-                    "timestamp": "2026-01-30T12:00:00+00:00"  # With timezone
-                },
-                {
-                    "content": "Event 3"  # No timestamp
-                }
-            ],
-            "async": True
-        }
-    )
-    
-    assert response.status_code == 200, f"Expected 200, got {response.status_code}: {response.text}"
-    data = response.json()
-    assert data["success"] is True
-    assert data["items_count"] == 3
-
-
-@pytest.mark.asyncio
-async def test_retain_with_timestamp_async_complete_processing(api_client, test_bank_id):
-    """Test that async retain with timestamp completes full processing including fact extraction."""
-    # Submit async retain with timestamp
-    response = await api_client.post(
-        f"/v1/default/banks/{test_bank_id}/memories",
-        json={
-            "items": [
-                {
-                    "content": "The quarterly meeting was held on January 30th 2026",
-                    "context": "meetings",
-                    "timestamp": "2026-01-30T11:45:00Z"
-                }
-            ],
-            "async": True
-        }
-    )
-    
-    assert response.status_code == 200, f"Expected 200, got {response.status_code}: {response.text}"
-    data = response.json()
-    assert data["success"] is True
-    assert data["async"] is True
-    operation_id = data["operation_id"]
-    
-    # Wait for async processing to complete (poll operation status)
-    max_wait_seconds = 30
-    poll_interval = 0.5
-    elapsed = 0
-    operation_completed = False
-    
-    while elapsed < max_wait_seconds:
-        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/operations/{operation_id}")
-        if response.status_code == 200:
-            op_status = response.json()
-            if op_status.get("status") == "completed":
-                operation_completed = True
-                break
-            elif op_status.get("status") == "failed":
-                raise AssertionError(f"Operation failed: {op_status.get('error_message')}")
-        
-        await asyncio.sleep(poll_interval)
-        elapsed += poll_interval
-    
-    assert operation_completed, f"Async operation did not complete within {max_wait_seconds} seconds"
-    
-    # Verify memories were actually stored
-    response = await api_client.get(
-        f"/v1/default/banks/{test_bank_id}/memories/list",
-        params={"limit": 10}
-    )
-    assert response.status_code == 200
-    items = response.json()["items"]
-    assert len(items) > 0, "Should have stored memories after async processing"

hindsight-api/tests/test_link_expansion_retrieval.py

@@ -1,278 +0,0 @@
-"""
-Tests for LinkExpansion graph retrieval.
-
-Tests cover the entity-based graph traversal for observations.
-"""
-
-from datetime import datetime, timezone
-
-import pytest
-
-
-@pytest.fixture(autouse=True)
-def enable_observations():
-    """Enable observations for all tests in this module."""
-    from hindsight_api.config import get_config
-
-    config = get_config()
-    original_value = config.enable_observations
-    config.enable_observations = True
-    yield
-    config.enable_observations = original_value
-
-
-@pytest.mark.asyncio
-async def test_link_expansion_observation_graph_retrieval(memory, request_context):
-    """
-    Test that observations can find other observations via shared entities.
-
-    This tests the scenario where:
-    1. World fact A has entity "Python"
-    2. World fact B has entity "Python"
-    3. Observation OA is derived from world fact A
-    4. Observation OB is derived from world fact B
-
-    When searching for observations related to OA, graph retrieval should find OB
-    because they share the "Python" entity through their source world facts.
-
-    Current issue: Graph retrieval returns 0 for observations because:
-    - Entity links are copied from world facts to observations during consolidation
-    - But the entity expansion query filters by fact_type
-    - Observations only share entities with world facts (cross-type), not with other observations
-    - So filtering to fact_type='observation' returns 0 results
-    """
-    bank_id = f"test_link_expansion_obs_{datetime.now(timezone.utc).timestamp()}"
-
-    try:
-        # Store world facts with shared entities using retain_batch_async
-        # We need enough facts that semantic search won't return all of them as seeds
-        # Key: "Alice" query should find Alice's observation but NOT Bob's via semantic search
-        # Then graph retrieval should find Bob via shared "Python" entity
-        await memory.retain_batch_async(
-            bank_id=bank_id,
-            contents=[
-                # Python developers - should be connected via "Python" entity
-                {
-                    "content": "Alice works with Python at TechCorp building REST APIs",
-                    "context": "employee info",
-                    "entities": [{"text": "Python"}, {"text": "Alice"}, {"text": "TechCorp"}],
-                },
-                {
-                    "content": "Bob uses Python at DataSoft for machine learning models",
-                    "context": "employee info",
-                    "entities": [{"text": "Python"}, {"text": "Bob"}, {"text": "DataSoft"}],
-                },
-                # Many unrelated facts to dilute semantic search and ensure
-                # "Alice" query only finds Alice-related content as seeds
-                {
-                    "content": "The weather in San Francisco is often foggy and cool",
-                    "context": "weather info",
-                    "entities": [{"text": "San Francisco"}],
-                },
-                {
-                    "content": "Tokyo is the capital city of Japan with many trains",
-                    "context": "geography info",
-                    "entities": [{"text": "Tokyo"}, {"text": "Japan"}],
-                },
-                {
-                    "content": "The Great Wall of China is a historic fortification",
-                    "context": "history info",
-                    "entities": [{"text": "Great Wall"}, {"text": "China"}],
-                },
-                {
-                    "content": "Coffee beans are grown in tropical regions worldwide",
-                    "context": "food info",
-                    "entities": [{"text": "Coffee"}],
-                },
-                {
-                    "content": "Electric vehicles are becoming more popular globally",
-                    "context": "technology info",
-                    "entities": [{"text": "Electric vehicles"}],
-                },
-                {
-                    "content": "The Amazon rainforest contains diverse wildlife species",
-                    "context": "nature info",
-                    "entities": [{"text": "Amazon"}, {"text": "Rainforest"}],
-                },
-                {
-                    "content": "Basketball is a popular sport in the United States",
-                    "context": "sports info",
-                    "entities": [{"text": "Basketball"}, {"text": "United States"}],
-                },
-                {
-                    "content": "Mozart composed many famous classical music pieces",
-                    "context": "music info",
-                    "entities": [{"text": "Mozart"}, {"text": "Classical music"}],
-                },
-            ],
-            request_context=request_context,
-        )
-
-        # Consolidation runs automatically after retain - wait for it to complete
-        # by querying for observations (consolidation creates them)
-        import asyncio
-        from hindsight_api.engine.memory_engine import Budget
-
-        # Wait for consolidation to complete with retry logic
-        # Consolidation runs as a background task and may take longer in CI
-        obs_result = None
-        for _ in range(30):  # Try up to 30 times (30 seconds max)
-            await asyncio.sleep(1)  # Wait 1 second between attempts
-            obs_result = await memory.recall_async(
-                bank_id=bank_id,
-                query="Python developer",
-                fact_type=["observation"],
-                budget=Budget.MID,
-                max_tokens=2048,
-                request_context=request_context,
-            )
-            if obs_result.results and len(obs_result.results) >= 1:
-                break
-
-        assert obs_result is not None and obs_result.results is not None, "Should have observations after consolidation"
-        # We should have observations from consolidation
-        assert len(obs_result.results) >= 1, f"Should have at least 1 observation about Python, got {len(obs_result.results)}"
-
-        # Now test graph retrieval specifically
-        # Query for Alice - should find Bob via shared "Python" entity
-        result = await memory.recall_async(
-            bank_id=bank_id,
-            query="Alice",
-            fact_type=["observation"],
-            budget=Budget.MID,
-            max_tokens=2048,
-            enable_trace=True,
-            request_context=request_context,
-        )
-
-        # Verify graph retrieval is working by checking the internal debug logs
-        # The graph retrieval finds observations via entity links, but may not return
-        # NEW results if semantic search already found all connected observations.
-        # This is correct behavior - we verify the entity traversal path works.
-
-        # Check the trace for graph results
-        assert result.trace is not None, "Should have trace data"
-
-        # The key verification: the entity expansion path works (sources -> entities -> observations)
-        # We validated this in the debug logs above:
-        # - Observations have source_memory_ids pointing to world facts ✓
-        # - World facts have entity links ✓
-        # - Graph retrieval can traverse this path (seen in logs: potential_obs > 0)
-
-        # For a more rigorous test, we need data where semantic search misses something.
-        # Let's verify the world fact graph retrieval works (it uses direct entity links).
-        world_result = await memory.recall_async(
-            bank_id=bank_id,
-            query="Alice",
-            fact_type=["world"],
-            budget=Budget.MID,
-            max_tokens=2048,
-            enable_trace=True,
-            request_context=request_context,
-        )
-
-        assert world_result.trace is not None, "Should have trace data for world facts"
-        world_retrieval_results = world_result.trace.get("retrieval_results", [])
-        world_graph_results = [
-            r for r in world_retrieval_results if r.get("method_name") == "graph"
-        ]
-
-        if world_graph_results:
-            world_graph_result = [r for r in world_graph_results if r.get("fact_type") == "world"][0]
-            world_graph_results_list = world_graph_result.get("results", [])
-
-            # World facts use direct entity links, so graph may find results
-            if world_graph_results_list:
-                print(f"\n✓ Graph retrieval found {len(world_graph_results_list)} connected world facts")
-                graph_texts = [r.get("text", "") for r in world_graph_results_list]
-                bob_found = any("Bob" in t or "DataSoft" in t for t in graph_texts)
-                if bob_found:
-                    print("  Found Bob's world fact via shared 'Python' entity!")
-
-        print("\n✓ Link expansion observation test passed!")
-        print("  Entity traversal path verified (observations -> sources -> entities -> connected sources -> observations)")
-
-    finally:
-        await memory.delete_bank(bank_id, request_context=request_context)
-
-
-@pytest.mark.asyncio
-async def test_link_expansion_world_fact_graph_retrieval(memory, request_context):
-    """
-    Test that world facts can find other world facts via shared entities.
-
-    This verifies the direct entity link traversal for world facts works correctly.
-    Note: When semantic search finds all world facts as seeds, graph retrieval
-    won't return NEW results (this is correct - it shouldn't duplicate results).
-    """
-    bank_id = f"test_link_expansion_world_{datetime.now(timezone.utc).timestamp()}"
-
-    try:
-        # Store world facts with shared entities
-        await memory.retain_batch_async(
-            bank_id=bank_id,
-            contents=[
-                # Python developers - should be connected via "Python" entity
-                {
-                    "content": "Alice works with Python at TechCorp building REST APIs",
-                    "context": "employee info",
-                    "entities": [{"text": "Python"}, {"text": "Alice"}, {"text": "TechCorp"}],
-                },
-                {
-                    "content": "Bob uses Python at DataSoft for machine learning models",
-                    "context": "employee info",
-                    "entities": [{"text": "Python"}, {"text": "Bob"}, {"text": "DataSoft"}],
-                },
-                # Unrelated facts
-                {
-                    "content": "The weather in San Francisco is often foggy",
-                    "context": "weather info",
-                    "entities": [{"text": "San Francisco"}],
-                },
-                {
-                    "content": "Coffee beans are grown in tropical regions",
-                    "context": "food info",
-                    "entities": [{"text": "Coffee"}],
-                },
-            ],
-            request_context=request_context,
-        )
-
-        from hindsight_api.engine.memory_engine import Budget
-
-        # Query for Alice
-        result = await memory.recall_async(
-            bank_id=bank_id,
-            query="Alice",
-            fact_type=["world"],
-            budget=Budget.MID,
-            max_tokens=2048,
-            enable_trace=True,
-            request_context=request_context,
-        )
-
-        assert result.trace is not None, "Should have trace data"
-
-        # Verify graph retrieval ran (it may or may not find new results depending
-        # on whether semantic search already found everything)
-        retrieval_results = result.trace.get("retrieval_results", [])
-        graph_results = [
-            r for r in retrieval_results if r.get("method_name") == "graph"
-        ]
-        assert len(graph_results) > 0, "Should have graph retrieval results in trace"
-
-        # The important thing is that recall works and returns relevant results
-        assert result.results is not None and len(result.results) > 0, (
-            "Should return results for 'Alice' query"
-        )
-
-        # Alice's result should be at or near the top
-        result_texts = [r.text for r in result.results]
-        alice_found = any("Alice" in t for t in result_texts)
-        assert alice_found, f"Should find Alice in results: {result_texts[:3]}"
-
-        print("\n✓ Link expansion world fact test passed!")
-        print(f"  Recall returned {len(result.results)} results for 'Alice' query")
-
-    finally:
-        await memory.delete_bank(bank_id, request_context=request_context)

hindsight-api/tests/test_llm_provider.py

@@ -19,10 +19,6 @@ MODEL_MATRIX = [
     ("openai", "gpt-5-nano"),
     ("openai", "gpt-5"),
     ("openai", "gpt-5.2"),
-    # Anthropic models
-    ("anthropic", "claude-sonnet-4-20250514"),
-    ("anthropic", "claude-opus-4-5-20251101"),
-    ("anthropic", "claude-haiku-4-20250514"),
     # Groq models
     ("groq", "openai/gpt-oss-120b"),
     ("groq", "openai/gpt-oss-20b"),
@@ -40,7 +36,6 @@ def get_api_key_for_provider(provider: str) -> str | None:
     """Get API key for provider from environment variables."""
     provider_key_map = {
         "openai": "OPENAI_API_KEY",
-        "anthropic": "ANTHROPIC_API_KEY",
         "groq": "GROQ_API_KEY",
         "gemini": "GEMINI_API_KEY",
     }

hindsight-api/tests/test_llm_token_metrics.py

@@ -30,8 +30,7 @@ async def test_llm_metrics_recorded_for_groq():
     # Create a mock metrics collector to track record_llm_call calls
     mock_collector = MagicMock(spec=MetricsCollector)
 
-    # Patch the provider module where get_metrics_collector is actually called
-    with patch("hindsight_api.engine.providers.openai_compatible_llm.get_metrics_collector", return_value=mock_collector):
+    with patch("hindsight_api.engine.llm_wrapper.get_metrics_collector", return_value=mock_collector):
         llm = LLMProvider(
             provider="groq",
             api_key=api_key,
@@ -91,8 +90,7 @@ async def test_llm_metrics_recorded_for_structured_output():
 
     mock_collector = MagicMock(spec=MetricsCollector)
 
-    # Patch the provider module where get_metrics_collector is actually called
-    with patch("hindsight_api.engine.providers.openai_compatible_llm.get_metrics_collector", return_value=mock_collector):
+    with patch("hindsight_api.engine.llm_wrapper.get_metrics_collector", return_value=mock_collector):
         llm = LLMProvider(
             provider="groq",
             api_key=api_key,

hindsight-api/tests/test_llm_tools.py

@@ -241,8 +241,8 @@ class TestReflectToolSchemas:
         tools = get_reflect_tools()
 
         tool_names = [t["function"]["name"] for t in tools]
+        assert "search_reflections" in tool_names
         assert "search_mental_models" in tool_names
-        assert "search_observations" in tool_names
         assert "recall" in tool_names
         assert "expand" in tool_names
         assert "done" in tool_names
@@ -273,8 +273,8 @@ class TestReflectToolSchemas:
 
         assert "answer" in params
         assert "memory_ids" in params
-        assert "observation_ids" in params
         assert "mental_model_ids" in params
+        assert "reflection_ids" in params
 
 
 class TestLLMToolCallResult:

hindsight-api/tests/test_mcp_routing.py

@@ -97,47 +97,3 @@ def test_path_parsing_logic():
     bank_id, remaining = parse_path("/my-bank/some/path")
     assert bank_id == "my-bank"
     assert remaining == "/some/path"
-
-
-@pytest.mark.asyncio
-async def test_api_key_context_variable():
-    """Test that API key context variable works correctly."""
-    from hindsight_api.api.mcp import get_current_api_key, _current_api_key
-
-    # Initially None
-    assert get_current_api_key() is None
-
-    # Set and verify
-    token = _current_api_key.set("test-api-key-123")
-    try:
-        assert get_current_api_key() == "test-api-key-123"
-    finally:
-        _current_api_key.reset(token)
-
-    # Back to None after reset
-    assert get_current_api_key() is None
-
-
-@pytest.mark.asyncio
-async def test_mcp_tools_propagate_api_key(mock_memory):
-    """Test that MCP tools propagate API key to RequestContext."""
-    from hindsight_api.api.mcp import create_mcp_server, _current_bank_id, _current_api_key
-
-    mcp_server = create_mcp_server(mock_memory)
-    tools = mcp_server._tool_manager._tools
-
-    # Set both bank_id and api_key context
-    bank_token = _current_bank_id.set("test-bank")
-    api_key_token = _current_api_key.set("test-bearer-token")
-    try:
-        retain_tool = tools["retain"]
-        result = await retain_tool.fn(content="test content", context="test_context", async_processing=False)
-        assert "successfully" in result.lower()
-
-        # Verify the memory was called with request_context containing api_key
-        mock_memory.retain_batch_async.assert_called_once()
-        call_kwargs = mock_memory.retain_batch_async.call_args.kwargs
-        assert call_kwargs["request_context"].api_key == "test-bearer-token"
-    finally:
-        _current_bank_id.reset(bank_token)
-        _current_api_key.reset(api_key_token)

hindsight-api/tests/test_mental_model_hooks.py

@@ -1,206 +0,0 @@
-"""Unit tests for mental model operation validator hooks.
-
-Tests that the operation validator hooks are called correctly for
-mental model GET and refresh operations.
-"""
-
-import pytest
-
-from hindsight_api.extensions.operation_validator import (
-    MentalModelGetContext,
-    MentalModelGetResult,
-    MentalModelRefreshResult,
-    OperationValidatorExtension,
-    ValidationResult,
-)
-
-
-class TestMentalModelGetContextDataclass:
-    """Tests for MentalModelGetContext dataclass."""
-
-    def test_create_context(self):
-        """Test creating a MentalModelGetContext."""
-        from unittest.mock import MagicMock
-
-        request_context = MagicMock()
-        ctx = MentalModelGetContext(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=request_context,
-        )
-
-        assert ctx.bank_id == "bank-1"
-        assert ctx.mental_model_id == "mm-1"
-        assert ctx.request_context is request_context
-
-
-class TestMentalModelGetResultDataclass:
-    """Tests for MentalModelGetResult dataclass."""
-
-    def test_create_result_success(self):
-        """Test creating a successful MentalModelGetResult."""
-        from unittest.mock import MagicMock
-
-        request_context = MagicMock()
-        result = MentalModelGetResult(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=request_context,
-            output_tokens=250,
-        )
-
-        assert result.bank_id == "bank-1"
-        assert result.mental_model_id == "mm-1"
-        assert result.output_tokens == 250
-        assert result.success is True
-        assert result.error is None
-
-    def test_create_result_failure(self):
-        """Test creating a failed MentalModelGetResult."""
-        from unittest.mock import MagicMock
-
-        result = MentalModelGetResult(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=MagicMock(),
-            output_tokens=0,
-            success=False,
-            error="Not found",
-        )
-
-        assert result.success is False
-        assert result.error == "Not found"
-
-
-class TestMentalModelRefreshResultDataclass:
-    """Tests for MentalModelRefreshResult dataclass."""
-
-    def test_create_result_with_all_fields(self):
-        """Test creating a MentalModelRefreshResult with all fields."""
-        from unittest.mock import MagicMock
-
-        result = MentalModelRefreshResult(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=MagicMock(),
-            query_tokens=50,
-            output_tokens=500,
-            context_tokens=0,
-            facts_used=10,
-            mental_models_used=2,
-        )
-
-        assert result.query_tokens == 50
-        assert result.output_tokens == 500
-        assert result.context_tokens == 0
-        assert result.facts_used == 10
-        assert result.mental_models_used == 2
-        assert result.success is True
-        assert result.error is None
-
-    def test_create_result_failure(self):
-        """Test creating a failed MentalModelRefreshResult."""
-        from unittest.mock import MagicMock
-
-        result = MentalModelRefreshResult(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=MagicMock(),
-            query_tokens=50,
-            output_tokens=0,
-            context_tokens=0,
-            facts_used=0,
-            mental_models_used=0,
-            success=False,
-            error="Reflect failed",
-        )
-
-        assert result.success is False
-        assert result.error == "Reflect failed"
-
-
-class TestDefaultHookBehavior:
-    """Tests for default (no-op) behavior of mental model hooks on OperationValidatorExtension."""
-
-    @pytest.fixture
-    def validator(self):
-        """Create a concrete subclass for testing default behavior."""
-        from unittest.mock import MagicMock
-
-        # Create a concrete subclass that implements the abstract methods
-        class TestValidator(OperationValidatorExtension):
-            async def validate_retain(self, ctx):
-                return ValidationResult.accept()
-
-            async def validate_recall(self, ctx):
-                return ValidationResult.accept()
-
-            async def validate_reflect(self, ctx):
-                return ValidationResult.accept()
-
-        return TestValidator(config={})
-
-    @pytest.mark.asyncio
-    async def test_validate_mental_model_get_default_accepts(self, validator):
-        """Test that default validate_mental_model_get accepts."""
-        from unittest.mock import MagicMock
-
-        ctx = MentalModelGetContext(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=MagicMock(),
-        )
-
-        result = await validator.validate_mental_model_get(ctx)
-
-        assert result.allowed is True
-
-    @pytest.mark.asyncio
-    async def test_on_mental_model_get_complete_default_noop(self, validator):
-        """Test that default on_mental_model_get_complete is a no-op."""
-        from unittest.mock import MagicMock
-
-        result = MentalModelGetResult(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=MagicMock(),
-            output_tokens=100,
-        )
-
-        # Should not raise
-        await validator.on_mental_model_get_complete(result)
-
-    @pytest.mark.asyncio
-    async def test_on_mental_model_refresh_complete_default_noop(self, validator):
-        """Test that default on_mental_model_refresh_complete is a no-op."""
-        from unittest.mock import MagicMock
-
-        result = MentalModelRefreshResult(
-            bank_id="bank-1",
-            mental_model_id="mm-1",
-            request_context=MagicMock(),
-            query_tokens=50,
-            output_tokens=500,
-            context_tokens=0,
-            facts_used=5,
-            mental_models_used=1,
-        )
-
-        # Should not raise
-        await validator.on_mental_model_refresh_complete(result)
-
-
-class TestExportsAvailable:
-    """Test that mental model hooks are properly exported."""
-
-    def test_imports_from_extensions_package(self):
-        """Test that all mental model types can be imported from hindsight_api.extensions."""
-        from hindsight_api.extensions import (
-            MentalModelGetContext,
-            MentalModelGetResult,
-            MentalModelRefreshResult,
-        )
-
-        assert MentalModelGetContext is not None
-        assert MentalModelGetResult is not None
-        assert MentalModelRefreshResult is not None

hindsight-api/tests/test_metrics.py

@@ -358,7 +358,7 @@ class TestLLMMetrics:
         collector.record_llm_call(
             provider="gemini",
             model="gemini-pro",
-            scope="memory",
+            scope="entity_observation",
             duration=2.0,
             success=True,
         )
@@ -369,11 +369,11 @@ class TestLLMMetrics:
         assert call_args[0][0] == 1
         assert call_args[0][1]["provider"] == "gemini"
         assert call_args[0][1]["model"] == "gemini-pro"
-        assert call_args[0][1]["scope"] == "memory"
+        assert call_args[0][1]["scope"] == "entity_observation"
 
     def test_record_llm_call_different_scopes(self, collector):
         """Test recording LLM calls with different scopes."""
-        scopes = ["memory", "reflect", "consolidation", "answer"]
+        scopes = ["memory", "reflect", "entity_observation", "answer"]
 
         for scope in scopes:
             collector.llm_duration.record.reset_mock()

hindsight-api/tests/test_multilingual.py

@@ -469,6 +469,7 @@ async def test_mixed_language_entities(memory, request_context):
             budget=Budget.MID,
             max_tokens=1000,
             fact_type=["world"],
+            include_entities=True,
             request_context=request_context,
         )
 

hindsight-api/tests/test_observations.py

@@ -8,20 +8,9 @@ populated from the summary for backwards compatibility.
 import pytest
 from hindsight_api.engine.memory_engine import Budget
 from hindsight_api import RequestContext
-from hindsight_api.config import get_config
 from datetime import datetime, timezone
 
 
-@pytest.fixture
-def disable_observations():
-    """Disable observations for a specific test."""
-    config = get_config()
-    original_value = config.enable_observations
-    config.enable_observations = False
-    yield
-    config.enable_observations = original_value
-
-
 @pytest.mark.asyncio
 async def test_entity_extraction_on_retain(memory, request_context):
     """
@@ -91,13 +80,156 @@ async def test_entity_extraction_on_retain(memory, request_context):
             await conn.execute("DELETE FROM entities WHERE bank_id = $1", bank_id)
 
 
+@pytest.mark.asyncio
+async def test_regenerate_entity_observations(memory, request_context):
+    """
+    Test explicit regeneration of summary for an entity.
+    """
+    bank_id = f"test_regen_obs_{datetime.now(timezone.utc).timestamp()}"
+
+    try:
+        # Store facts about an entity
+        await memory.retain_async(
+            bank_id=bank_id,
+            content="Sarah is a product manager who loves user research and data analysis.",
+            context="work info",
+            event_date=datetime(2024, 1, 15, tzinfo=timezone.utc),
+            request_context=request_context,
+        )
+
+        await memory.wait_for_background_tasks()
+
+        # Find the Sarah entity
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            entity_row = await conn.fetchrow(
+                """
+                SELECT id, canonical_name
+                FROM entities
+                WHERE bank_id = $1 AND LOWER(canonical_name) LIKE '%sarah%'
+                LIMIT 1
+                """,
+                bank_id
+            )
+
+        if entity_row:
+            entity_id = str(entity_row['id'])
+            entity_name = entity_row['canonical_name']
+
+            # Manually regenerate summary (via observations API for backwards compat)
+            created_ids = await memory.regenerate_entity_observations(
+                bank_id=bank_id,
+                entity_id=entity_id,
+                entity_name=entity_name,
+                request_context=request_context,
+            )
+
+            print(f"\n=== Regenerated Summary ===")
+            print(f"Created {len(created_ids)} summary for {entity_name}")
+
+            # Get entity state
+            state = await memory.get_entity_state(
+                bank_id, entity_id, entity_name, request_context=request_context
+            )
+            for obs in state.observations:
+                print(f"  - {obs.text}")
+
+            # Verify summary was created
+            if len(created_ids) > 0:
+                assert len(state.observations) == 1, "Should have exactly 1 observation (the summary)"
+                print(f"Summary regenerated successfully")
+            else:
+                print(f"Note: No summary was regenerated")
+
+        else:
+            print(f"Note: No 'Sarah' entity was extracted")
+
+    finally:
+        # Cleanup
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            await conn.execute("DELETE FROM memory_units WHERE bank_id = $1", bank_id)
+            await conn.execute("DELETE FROM entities WHERE bank_id = $1", bank_id)
+
+
+@pytest.mark.asyncio
+async def test_entity_state_retrieval(memory, request_context):
+    """
+    Test retrieving entity state with facts.
+    """
+    bank_id = f"test_entity_state_{datetime.now(timezone.utc).timestamp()}"
+
+    try:
+        # Store facts
+        await memory.retain_async(
+            bank_id=bank_id,
+            content="Alice works at Google as a senior software engineer.",
+            context="work info",
+            event_date=datetime(2024, 1, 15, tzinfo=timezone.utc),
+            request_context=request_context,
+        )
+        await memory.retain_async(
+            bank_id=bank_id,
+            content="Alice loves hiking and outdoor photography.",
+            context="hobbies",
+            event_date=datetime(2024, 1, 16, tzinfo=timezone.utc),
+            request_context=request_context,
+        )
+
+        # Find the Alice entity
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            entity_row = await conn.fetchrow(
+                """
+                SELECT id, canonical_name
+                FROM entities
+                WHERE bank_id = $1 AND LOWER(canonical_name) LIKE '%alice%'
+                LIMIT 1
+                """,
+                bank_id
+            )
+
+        assert entity_row is not None, "Alice entity should have been extracted"
+
+        entity_id = str(entity_row['id'])
+        entity_name = entity_row['canonical_name']
+
+        # Check fact count
+        async with pool.acquire() as conn:
+            fact_count = await conn.fetchval(
+                "SELECT COUNT(*) FROM unit_entities WHERE entity_id = $1",
+                entity_row['id']
+            )
+
+        print(f"\n=== Entity State Test ===")
+        print(f"Entity: {entity_name} (id: {entity_id})")
+        print(f"Linked facts: {fact_count}")
+
+        # Get entity state
+        state = await memory.get_entity_state(
+            bank_id, entity_id, entity_name, request_context=request_context
+        )
+
+        assert state.entity_id == entity_id
+        assert state.canonical_name == entity_name
+        print(f"Entity state retrieved successfully")
+
+    finally:
+        # Cleanup
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            await conn.execute("DELETE FROM memory_units WHERE bank_id = $1", bank_id)
+            await conn.execute("DELETE FROM entities WHERE bank_id = $1", bank_id)
+
+
 @pytest.mark.asyncio
 async def test_search_with_include_entities(memory, request_context):
     """
-    Test that recall accepts include_entities parameter for backwards compatibility.
+    Test that search with include_entities=True returns entity information.
 
-    Note: Entity observations have been deprecated. This test verifies the parameter
-    is still accepted without errors.
+    This test verifies that:
+    1. Entities are extracted after retain
+    2. Entity info is returned in recall results with include_entities=True
     """
     bank_id = f"test_search_ent_{datetime.now(timezone.utc).timestamp()}"
 
@@ -106,6 +238,10 @@ async def test_search_with_include_entities(memory, request_context):
         contents = [
             "Alice is a data scientist who works on recommendation systems at Netflix.",
             "Alice presented her research at the ML conference last month.",
+            "Alice is an expert in deep learning and neural networks.",
+            "Alice graduated from Stanford with a PhD in Computer Science.",
+            "Alice leads a team of 5 data scientists at Netflix.",
+            "Alice published a paper on collaborative filtering algorithms.",
         ]
 
         for i, content in enumerate(contents):
@@ -120,7 +256,7 @@ async def test_search_with_include_entities(memory, request_context):
         # Wait for background tasks
         await memory.wait_for_background_tasks()
 
-        # Search with include_entities=True (should be accepted for backwards compatibility)
+        # Search with include_entities=True
         result = await memory.recall_async(
             bank_id=bank_id,
             query="What does Alice do?",
@@ -132,9 +268,35 @@ async def test_search_with_include_entities(memory, request_context):
             request_context=request_context,
         )
 
-        # Verify recall works
-        assert len(result.results) > 0, "Should find some facts"
+        print(f"\n=== Search Results ===")
         print(f"Found {len(result.results)} facts")
+        for fact in result.results:
+            print(f"  - {fact.text}")
+            if fact.entities:
+                print(f"    Entities: {', '.join(fact.entities)}")
+
+        # Verify results
+        assert len(result.results) > 0, "Should find some facts"
+
+        # Check if entities are included in facts
+        facts_with_entities = [f for f in result.results if f.entities]
+        assert len(facts_with_entities) > 0, "Some facts should have entity information"
+        print(f"{len(facts_with_entities)} facts have entity information")
+
+        # Check if entity info is returned
+        if result.entities:
+            print(f"Entity info included for {len(result.entities)} entities")
+
+            # Verify Alice entity is in results
+            alice_found = False
+            for name, state in result.entities.items():
+                assert state.canonical_name == name, "Entity canonical_name should match key"
+                assert state.entity_id, "Entity should have an ID"
+                if "alice" in name.lower():
+                    alice_found = True
+                    print(f"Alice entity found: {name}")
+
+            assert alice_found, "Alice entity should be in recall results"
 
     finally:
         # Cleanup
@@ -145,12 +307,75 @@ async def test_search_with_include_entities(memory, request_context):
 
 
 @pytest.mark.asyncio
-async def test_observation_fact_type_in_database(memory, request_context, disable_observations):
+async def test_get_entity_state(memory, request_context):
     """
-    Test that when observations are disabled, no observation records are created.
+    Test getting the full state of an entity.
+    """
+    bank_id = f"test_entity_state_{datetime.now(timezone.utc).timestamp()}"
 
-    When enable_observations=False, consolidation does not run and no
-    memory_units with fact_type='observation' should exist.
+    try:
+        # Store facts
+        await memory.retain_async(
+            bank_id=bank_id,
+            content="Bob is a frontend developer who specializes in React and TypeScript.",
+            context="work info",
+            event_date=datetime(2024, 1, 15, tzinfo=timezone.utc),
+            request_context=request_context,
+        )
+
+        await memory.wait_for_background_tasks()
+
+        # Find entity
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            entity_row = await conn.fetchrow(
+                """
+                SELECT id, canonical_name
+                FROM entities
+                WHERE bank_id = $1 AND LOWER(canonical_name) LIKE '%bob%'
+                LIMIT 1
+                """,
+                bank_id
+            )
+
+        if entity_row:
+            entity_id = str(entity_row['id'])
+            entity_name = entity_row['canonical_name']
+
+            # Get entity state
+            state = await memory.get_entity_state(
+                bank_id=bank_id,
+                entity_id=entity_id,
+                entity_name=entity_name,
+                limit=10,
+                request_context=request_context,
+            )
+
+            print(f"\n=== Entity State for {entity_name} ===")
+            print(f"Entity ID: {state.entity_id}")
+            print(f"Canonical Name: {state.canonical_name}")
+            print(f"Observations: {len(state.observations)}")
+            for obs in state.observations:
+                print(f"  - {obs.text}")
+
+            assert state.entity_id == entity_id, "Entity ID should match"
+            assert state.canonical_name == entity_name, "Canonical name should match"
+
+    finally:
+        # Cleanup
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            await conn.execute("DELETE FROM memory_units WHERE bank_id = $1", bank_id)
+            await conn.execute("DELETE FROM entities WHERE bank_id = $1", bank_id)
+
+
+@pytest.mark.asyncio
+async def test_observation_fact_type_in_database(memory, request_context):
+    """
+    Test that observations are NOT stored as memory_units with fact_type='observation'.
+
+    NOTE: Observations are now handled via mental models, not as memory_units
+    or entity summaries.
     """
     bank_id = f"test_obs_db_{datetime.now(timezone.utc).timestamp()}"
 

hindsight-api/tests/test_per_operation_llm_config.py

@@ -275,88 +275,3 @@ class TestReflectUsesReflectLLMConfig:
 
         # Verify it's different from the retain config
         assert engine._reflect_llm_config.model != engine._retain_llm_config.model
-
-
-class TestRetryAndBackoffConfiguration:
-    """Test retry and backoff configuration options."""
-
-    def test_global_retry_backoff_config_defaults(self):
-        """Test that global retry/backoff settings have correct defaults."""
-        from hindsight_api.config import get_config
-
-        config = get_config()
-
-        # Verify global defaults
-        assert config.llm_max_retries == 10
-        assert config.llm_initial_backoff == 1.0
-        assert config.llm_max_backoff == 60.0
-
-    def test_per_operation_retry_backoff_config_from_env(self):
-        """Test that per-operation retry/backoff settings are loaded from environment."""
-        from hindsight_api.config import clear_config_cache
-
-        # Set per-operation overrides
-        os.environ["HINDSIGHT_API_RETAIN_LLM_MAX_RETRIES"] = "3"
-        os.environ["HINDSIGHT_API_RETAIN_LLM_INITIAL_BACKOFF"] = "2.0"
-        os.environ["HINDSIGHT_API_RETAIN_LLM_MAX_BACKOFF"] = "120.0"
-        os.environ["HINDSIGHT_API_REFLECT_LLM_MAX_RETRIES"] = "5"
-        os.environ["HINDSIGHT_API_REFLECT_LLM_INITIAL_BACKOFF"] = "1.5"
-        os.environ["HINDSIGHT_API_REFLECT_LLM_MAX_BACKOFF"] = "90.0"
-
-        try:
-            clear_config_cache()
-            from hindsight_api.config import get_config
-
-            config = get_config()
-
-            # Verify retain overrides
-            assert config.retain_llm_max_retries == 3
-            assert config.retain_llm_initial_backoff == 2.0
-            assert config.retain_llm_max_backoff == 120.0
-
-            # Verify reflect overrides
-            assert config.reflect_llm_max_retries == 5
-            assert config.reflect_llm_initial_backoff == 1.5
-            assert config.reflect_llm_max_backoff == 90.0
-
-            # Verify global defaults remain unchanged
-            assert config.llm_max_retries == 10
-            assert config.llm_initial_backoff == 1.0
-            assert config.llm_max_backoff == 60.0
-        finally:
-            # Clean up
-            os.environ.pop("HINDSIGHT_API_RETAIN_LLM_MAX_RETRIES", None)
-            os.environ.pop("HINDSIGHT_API_RETAIN_LLM_INITIAL_BACKOFF", None)
-            os.environ.pop("HINDSIGHT_API_RETAIN_LLM_MAX_BACKOFF", None)
-            os.environ.pop("HINDSIGHT_API_REFLECT_LLM_MAX_RETRIES", None)
-            os.environ.pop("HINDSIGHT_API_REFLECT_LLM_INITIAL_BACKOFF", None)
-            os.environ.pop("HINDSIGHT_API_REFLECT_LLM_MAX_BACKOFF", None)
-            clear_config_cache()
-
-    def test_per_operation_retry_backoff_fallback_to_global(self):
-        """Test that per-operation settings fall back to global when not set."""
-        from hindsight_api.config import clear_config_cache, get_config
-
-        # Set only global values
-        os.environ["HINDSIGHT_API_LLM_MAX_RETRIES"] = "7"
-        os.environ["HINDSIGHT_API_LLM_INITIAL_BACKOFF"] = "3.0"
-        os.environ["HINDSIGHT_API_LLM_MAX_BACKOFF"] = "180.0"
-
-        try:
-            clear_config_cache()
-            config = get_config()
-
-            # Per-operation should be None (will fall back to global at runtime)
-            assert config.retain_llm_max_retries is None
-            assert config.retain_llm_initial_backoff is None
-            assert config.retain_llm_max_backoff is None
-
-            # Global values should be set
-            assert config.llm_max_retries == 7
-            assert config.llm_initial_backoff == 3.0
-            assert config.llm_max_backoff == 180.0
-        finally:
-            os.environ.pop("HINDSIGHT_API_LLM_MAX_RETRIES", None)
-            os.environ.pop("HINDSIGHT_API_LLM_INITIAL_BACKOFF", None)
-            os.environ.pop("HINDSIGHT_API_LLM_MAX_BACKOFF", None)
-            clear_config_cache()

hindsight-api/tests/test_provider_default_models.py

@@ -1,123 +0,0 @@
-"""Test provider-specific default models in config."""
-
-import os
-
-import pytest
-
-
-def test_provider_default_models():
-    """Test that each provider has a default model and it's used when model is not explicitly set."""
-    from hindsight_api.config import PROVIDER_DEFAULT_MODELS, HindsightConfig, clear_config_cache
-
-    # Save original env vars
-    original_provider = os.environ.get("HINDSIGHT_API_LLM_PROVIDER")
-    original_model = os.environ.get("HINDSIGHT_API_LLM_MODEL")
-
-    try:
-        # Test each provider has a default
-        for provider, expected_model in PROVIDER_DEFAULT_MODELS.items():
-            clear_config_cache()
-            os.environ["HINDSIGHT_API_LLM_PROVIDER"] = provider
-            # Remove explicit model setting to test default
-            if "HINDSIGHT_API_LLM_MODEL" in os.environ:
-                del os.environ["HINDSIGHT_API_LLM_MODEL"]
-
-            config = HindsightConfig.from_env()
-            assert config.llm_provider == provider, f"Provider mismatch for {provider}"
-            assert config.llm_model == expected_model, f"Expected {expected_model} for {provider}, got {config.llm_model}"
-
-    finally:
-        # Restore original env vars
-        clear_config_cache()
-        if original_provider:
-            os.environ["HINDSIGHT_API_LLM_PROVIDER"] = original_provider
-        elif "HINDSIGHT_API_LLM_PROVIDER" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_PROVIDER"]
-
-        if original_model:
-            os.environ["HINDSIGHT_API_LLM_MODEL"] = original_model
-        elif "HINDSIGHT_API_LLM_MODEL" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_MODEL"]
-
-
-def test_explicit_model_overrides_provider_default():
-    """Test that explicit model setting overrides provider default."""
-    from hindsight_api.config import HindsightConfig, clear_config_cache
-
-    original_provider = os.environ.get("HINDSIGHT_API_LLM_PROVIDER")
-    original_model = os.environ.get("HINDSIGHT_API_LLM_MODEL")
-
-    try:
-        clear_config_cache()
-        os.environ["HINDSIGHT_API_LLM_PROVIDER"] = "anthropic"
-        os.environ["HINDSIGHT_API_LLM_MODEL"] = "claude-sonnet-4-5-20250929"
-
-        config = HindsightConfig.from_env()
-        assert config.llm_provider == "anthropic"
-        assert config.llm_model == "claude-sonnet-4-5-20250929", "Explicit model should override default"
-
-    finally:
-        clear_config_cache()
-        if original_provider:
-            os.environ["HINDSIGHT_API_LLM_PROVIDER"] = original_provider
-        elif "HINDSIGHT_API_LLM_PROVIDER" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_PROVIDER"]
-
-        if original_model:
-            os.environ["HINDSIGHT_API_LLM_MODEL"] = original_model
-        elif "HINDSIGHT_API_LLM_MODEL" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_MODEL"]
-
-
-def test_per_operation_provider_default_model():
-    """Test that per-operation providers use their own default models."""
-    from hindsight_api.config import HindsightConfig, clear_config_cache
-
-    original_provider = os.environ.get("HINDSIGHT_API_LLM_PROVIDER")
-    original_model = os.environ.get("HINDSIGHT_API_LLM_MODEL")
-    original_retain_provider = os.environ.get("HINDSIGHT_API_RETAIN_LLM_PROVIDER")
-    original_retain_model = os.environ.get("HINDSIGHT_API_RETAIN_LLM_MODEL")
-
-    try:
-        clear_config_cache()
-        os.environ["HINDSIGHT_API_LLM_PROVIDER"] = "openai"
-        # Remove explicit model to use provider default
-        if "HINDSIGHT_API_LLM_MODEL" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_MODEL"]
-
-        # Set retain-specific provider but not model
-        os.environ["HINDSIGHT_API_RETAIN_LLM_PROVIDER"] = "anthropic"
-        if "HINDSIGHT_API_RETAIN_LLM_MODEL" in os.environ:
-            del os.environ["HINDSIGHT_API_RETAIN_LLM_MODEL"]
-
-        config = HindsightConfig.from_env()
-
-        # Global LLM should use OpenAI default
-        assert config.llm_model == "o3-mini", f"Expected o3-mini, got {config.llm_model}"
-
-        # Retain should use Anthropic default
-        assert (
-            config.retain_llm_model == "claude-haiku-4-5-20251001"
-        ), f"Expected claude-haiku-4-5-20251001, got {config.retain_llm_model}"
-
-    finally:
-        clear_config_cache()
-        if original_provider:
-            os.environ["HINDSIGHT_API_LLM_PROVIDER"] = original_provider
-        elif "HINDSIGHT_API_LLM_PROVIDER" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_PROVIDER"]
-
-        if original_model:
-            os.environ["HINDSIGHT_API_LLM_MODEL"] = original_model
-        elif "HINDSIGHT_API_LLM_MODEL" in os.environ:
-            del os.environ["HINDSIGHT_API_LLM_MODEL"]
-
-        if original_retain_provider:
-            os.environ["HINDSIGHT_API_RETAIN_LLM_PROVIDER"] = original_retain_provider
-        elif "HINDSIGHT_API_RETAIN_LLM_PROVIDER" in os.environ:
-            del os.environ["HINDSIGHT_API_RETAIN_LLM_PROVIDER"]
-
-        if original_retain_model:
-            os.environ["HINDSIGHT_API_RETAIN_LLM_MODEL"] = original_retain_model
-        elif "HINDSIGHT_API_RETAIN_LLM_MODEL" in os.environ:
-            del os.environ["HINDSIGHT_API_RETAIN_LLM_MODEL"]

hindsight-api/tests/test_reflect_agent.py

@@ -14,7 +14,6 @@ from hindsight_api.engine.reflect.agent import (
     _normalize_tool_name,
     _is_done_tool,
     _clean_answer_text,
-    _clean_done_answer,
     run_reflect_agent,
 )
 from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
@@ -62,79 +61,6 @@ class TestCleanAnswerText:
         assert cleaned == "Summary of findings."
 
 
-class TestCleanDoneAnswer:
-    """Test cleanup of answer field from done() tool call that leaks structured output."""
-
-    def test_clean_answer_with_leaked_json_code_block(self):
-        """Answer with leaked JSON code block at the end should be cleaned."""
-        text = '''The user's favorite color is blue.
-
-```json
-{"observation_ids": ["obs-1", "obs-2"]}
-```'''
-        cleaned = _clean_done_answer(text)
-        assert cleaned == "The user's favorite color is blue."
-        assert "observation_ids" not in cleaned
-
-    def test_clean_answer_with_memory_ids_code_block(self):
-        """Answer with leaked memory_ids JSON code block should be cleaned."""
-        text = '''Here is the answer.
-
-```json
-{"memory_ids": ["mem-1"]}
-```'''
-        cleaned = _clean_done_answer(text)
-        assert cleaned == "Here is the answer."
-
-    def test_clean_answer_with_raw_json_object(self):
-        """Answer with raw JSON object containing IDs at the end should be cleaned."""
-        text = 'The answer is 42. {"observation_ids": ["obs-1"]}'
-        cleaned = _clean_done_answer(text)
-        assert cleaned == "The answer is 42."
-
-    def test_clean_answer_with_trailing_ids_pattern(self):
-        """Answer with 'observation_ids: [...]' pattern at the end should be cleaned."""
-        text = "This is the answer.\n\nobservation_ids: [\"obs-1\", \"obs-2\"]"
-        cleaned = _clean_done_answer(text)
-        assert cleaned == "This is the answer."
-
-    def test_clean_answer_with_memory_ids_equals(self):
-        """Answer with 'memory_ids = [...]' pattern at the end should be cleaned."""
-        text = "Answer text here.\nmemory_ids = [\"mem-1\"]"
-        cleaned = _clean_done_answer(text)
-        assert cleaned == "Answer text here."
-
-    def test_clean_normal_answer_unchanged(self):
-        """Normal answer without leaked output should be unchanged."""
-        text = "This is a normal answer about observation strategies."
-        cleaned = _clean_done_answer(text)
-        assert cleaned == text
-
-    def test_clean_empty_answer(self):
-        """Empty answer should return empty."""
-        assert _clean_done_answer("") == ""
-
-    def test_clean_answer_with_observation_word_in_content(self):
-        """The word 'observation' in regular text should not be stripped."""
-        text = "Based on my observation, the user prefers dark mode."
-        cleaned = _clean_done_answer(text)
-        assert cleaned == text
-
-    def test_clean_answer_multiline_with_markdown(self):
-        """Answer with markdown and leaked JSON at end should clean only the leak."""
-        text = '''Summary:
-- Point 1
-- Point 2
-
-```json
-{"mental_model_ids": ["mm-1"]}
-```'''
-        cleaned = _clean_done_answer(text)
-        assert "Point 1" in cleaned
-        assert "Point 2" in cleaned
-        assert "mental_model_ids" not in cleaned
-
-
 class TestToolNameNormalization:
     """Test tool name normalization for various LLM output formats."""
 
@@ -142,15 +68,15 @@ class TestToolNameNormalization:
         """Standard tool names should pass through unchanged."""
         assert _normalize_tool_name("done") == "done"
         assert _normalize_tool_name("recall") == "recall"
+        assert _normalize_tool_name("search_reflections") == "search_reflections"
         assert _normalize_tool_name("search_mental_models") == "search_mental_models"
-        assert _normalize_tool_name("search_observations") == "search_observations"
         assert _normalize_tool_name("expand") == "expand"
 
     def test_normalize_functions_prefix(self):
         """Tool names with 'functions.' prefix should be normalized."""
         assert _normalize_tool_name("functions.done") == "done"
         assert _normalize_tool_name("functions.recall") == "recall"
-        assert _normalize_tool_name("functions.search_mental_models") == "search_mental_models"
+        assert _normalize_tool_name("functions.search_reflections") == "search_reflections"
 
     def test_normalize_call_equals_prefix(self):
         """Tool names with 'call=' prefix should be normalized."""
@@ -161,13 +87,7 @@ class TestToolNameNormalization:
         """Tool names with 'call=functions.' prefix should be normalized."""
         assert _normalize_tool_name("call=functions.done") == "done"
         assert _normalize_tool_name("call=functions.recall") == "recall"
-        assert _normalize_tool_name("call=functions.search_observations") == "search_observations"
-
-    def test_normalize_special_token_suffix(self):
-        """Tool names with malformed special tokens should be normalized."""
-        assert _normalize_tool_name("done<|channel|>commentary") == "done"
-        assert _normalize_tool_name("recall<|endoftext|>") == "recall"
-        assert _normalize_tool_name("search_observations<|im_end|>extra") == "search_observations"
+        assert _normalize_tool_name("call=functions.search_mental_models") == "search_mental_models"
 
     def test_is_done_tool(self):
         """Test _is_done_tool helper."""
@@ -180,14 +100,9 @@ class TestToolNameNormalization:
         assert _is_done_tool("call=done") is True
         assert _is_done_tool("call=functions.done") is True
 
-        # With malformed special tokens
-        assert _is_done_tool("done<|channel|>commentary") is True
-        assert _is_done_tool("done<|endoftext|>") is True
-
         # Not done
         assert _is_done_tool("functions.recall") is False
         assert _is_done_tool("call=functions.recall") is False
-        assert _is_done_tool("recall<|channel|>done") is False
 
 
 class TestReflectAgentMocked:
@@ -208,8 +123,8 @@ class TestReflectAgentMocked:
     def mock_functions(self):
         """Create mock search/recall functions."""
         return {
+            "search_reflections_fn": AsyncMock(return_value={"reflections": []}),
             "search_mental_models_fn": AsyncMock(return_value={"mental_models": []}),
-            "search_observations_fn": AsyncMock(return_value={"observations": []}),
             "recall_fn": AsyncMock(return_value={"memories": [{"id": "mem-1", "content": "test memory"}]}),
             "expand_fn": AsyncMock(return_value={"memories": []}),
         }

hindsight-api/tests/test_reflections.py

@@ -1,4 +1,4 @@
-"""Tests for mental models (formerly reflections), observations, and learnings functionality."""
+"""Tests for reflections, mental models, and learnings functionality."""
 
 import uuid
 
@@ -21,22 +21,22 @@ async def api_client(memory):
 @pytest.fixture
 def test_bank_id():
     """Provide a unique bank ID for this test run."""
-    return f"test_mental_models_{uuid.uuid4().hex[:8]}"
+    return f"test_reflections_{uuid.uuid4().hex[:8]}"
 
 
-class TestMentalModelsCRUD:
-    """Test mental models CRUD operations via memory engine."""
+class TestReflectionsCRUD:
+    """Test reflections CRUD operations via memory engine."""
 
     @pytest.mark.asyncio
-    async def test_create_and_get_mental_model(self, memory: MemoryEngine, request_context):
-        """Test creating and retrieving a mental model."""
-        bank_id = f"test-mental-model-{uuid.uuid4().hex[:8]}"
+    async def test_create_and_get_reflection(self, memory: MemoryEngine, request_context):
+        """Test creating and retrieving a reflection."""
+        bank_id = f"test-reflection-{uuid.uuid4().hex[:8]}"
 
         # Create the bank first
         await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
 
-        # Create a mental model
-        mental_model = await memory.create_mental_model(
+        # Create a reflection
+        reflection = await memory.create_reflection(
             bank_id=bank_id,
             name="Team Preferences",
             source_query="What are the team's communication preferences?",
@@ -45,45 +45,45 @@ class TestMentalModelsCRUD:
             request_context=request_context,
         )
 
-        assert mental_model["name"] == "Team Preferences"
-        assert mental_model["source_query"] == "What are the team's communication preferences?"
-        assert mental_model["content"] == "The team prefers async communication via Slack"
-        assert mental_model["tags"] == ["team"]
-        assert "id" in mental_model
+        assert reflection["name"] == "Team Preferences"
+        assert reflection["source_query"] == "What are the team's communication preferences?"
+        assert reflection["content"] == "The team prefers async communication via Slack"
+        assert reflection["tags"] == ["team"]
+        assert "id" in reflection
 
-        # Get the mental model
-        fetched = await memory.get_mental_model(
+        # Get the reflection
+        fetched = await memory.get_reflection(
             bank_id=bank_id,
-            mental_model_id=mental_model["id"],
+            reflection_id=reflection["id"],
             request_context=request_context,
         )
 
-        assert fetched["id"] == mental_model["id"]
+        assert fetched["id"] == reflection["id"]
         assert fetched["name"] == "Team Preferences"
 
         # Cleanup
         await memory.delete_bank(bank_id, request_context=request_context)
 
     @pytest.mark.asyncio
-    async def test_list_mental_models(self, memory: MemoryEngine, request_context):
-        """Test listing mental models with filters."""
-        bank_id = f"test-mental-model-list-{uuid.uuid4().hex[:8]}"
+    async def test_list_reflections(self, memory: MemoryEngine, request_context):
+        """Test listing reflections with filters."""
+        bank_id = f"test-reflection-list-{uuid.uuid4().hex[:8]}"
 
         # Create the bank first
         await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
 
-        # Create multiple mental models
-        await memory.create_mental_model(
+        # Create multiple reflections
+        await memory.create_reflection(
             bank_id=bank_id,
-            name="Mental Model 1",
+            name="Reflection 1",
             source_query="Query 1",
             content="Content 1",
             tags=["tag1"],
             request_context=request_context,
         )
-        await memory.create_mental_model(
+        await memory.create_reflection(
             bank_id=bank_id,
-            name="Mental Model 2",
+            name="Reflection 2",
             source_query="Query 2",
             content="Content 2",
             tags=["tag2"],
@@ -91,33 +91,33 @@ class TestMentalModelsCRUD:
         )
 
         # List all
-        all_mental_models = await memory.list_mental_models(
+        all_reflections = await memory.list_reflections(
             bank_id=bank_id,
             request_context=request_context,
         )
-        assert len(all_mental_models) == 2
+        assert len(all_reflections) == 2
 
         # List with tag filter
-        tag1_mental_models = await memory.list_mental_models(
+        tag1_reflections = await memory.list_reflections(
             bank_id=bank_id,
             tags=["tag1"],
             request_context=request_context,
         )
-        assert len(tag1_mental_models) == 1
+        assert len(tag1_reflections) == 1
 
         # Cleanup
         await memory.delete_bank(bank_id, request_context=request_context)
 
     @pytest.mark.asyncio
-    async def test_update_mental_model(self, memory: MemoryEngine, request_context):
-        """Test updating a mental model."""
-        bank_id = f"test-mental-model-update-{uuid.uuid4().hex[:8]}"
+    async def test_update_reflection(self, memory: MemoryEngine, request_context):
+        """Test updating a reflection."""
+        bank_id = f"test-reflection-update-{uuid.uuid4().hex[:8]}"
 
         # Create the bank first
         await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
 
-        # Create a mental model
-        mental_model = await memory.create_mental_model(
+        # Create a reflection
+        reflection = await memory.create_reflection(
             bank_id=bank_id,
             name="Original Name",
             source_query="Original Query",
@@ -125,10 +125,10 @@ class TestMentalModelsCRUD:
             request_context=request_context,
         )
 
-        # Update the mental model
-        updated = await memory.update_mental_model(
+        # Update the reflection
+        updated = await memory.update_reflection(
             bank_id=bank_id,
-            mental_model_id=mental_model["id"],
+            reflection_id=reflection["id"],
             name="Updated Name",
             content="Updated Content",
             request_context=request_context,
@@ -141,15 +141,15 @@ class TestMentalModelsCRUD:
         await memory.delete_bank(bank_id, request_context=request_context)
 
     @pytest.mark.asyncio
-    async def test_delete_mental_model(self, memory: MemoryEngine, request_context):
-        """Test deleting a mental model."""
-        bank_id = f"test-mental-model-delete-{uuid.uuid4().hex[:8]}"
+    async def test_delete_reflection(self, memory: MemoryEngine, request_context):
+        """Test deleting a reflection."""
+        bank_id = f"test-reflection-delete-{uuid.uuid4().hex[:8]}"
 
         # Create the bank first
         await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
 
-        # Create a mental model
-        mental_model = await memory.create_mental_model(
+        # Create a reflection
+        reflection = await memory.create_reflection(
             bank_id=bank_id,
             name="To Delete",
             source_query="Query",
@@ -157,17 +157,17 @@ class TestMentalModelsCRUD:
             request_context=request_context,
         )
 
-        # Delete the mental model
-        await memory.delete_mental_model(
+        # Delete the reflection
+        await memory.delete_reflection(
             bank_id=bank_id,
-            mental_model_id=mental_model["id"],
+            reflection_id=reflection["id"],
             request_context=request_context,
         )
 
         # Verify deletion - should return None
-        fetched = await memory.get_mental_model(
+        fetched = await memory.get_reflection(
             bank_id=bank_id,
-            mental_model_id=mental_model["id"],
+            reflection_id=reflection["id"],
             request_context=request_context,
         )
         assert fetched is None
@@ -176,45 +176,45 @@ class TestMentalModelsCRUD:
         await memory.delete_bank(bank_id, request_context=request_context)
 
 
-class TestObservationsAPI:
-    """Test observations API endpoints.
+class TestMentalModelsAPI:
+    """Test mental models API endpoints.
 
-    NOTE: Observations are now stored in memory_units with fact_type='observation'
-    and accessed via recall with fact_type=["observation"]. The old /observations
+    NOTE: Mental models are now stored in memory_units with fact_type='mental_model'
+    and accessed via recall with fact_type=["mental_model"]. The old /mental-models
     endpoint was removed. These tests are skipped.
     """
 
-    @pytest.mark.skip(reason="Observations endpoint removed - use recall with fact_type=['observation']")
+    @pytest.mark.skip(reason="Mental models endpoint removed - use recall with fact_type=['mental_model']")
     @pytest.mark.asyncio
-    async def test_list_observations_empty(self, api_client, test_bank_id):
-        """Test listing observations when none exist."""
+    async def test_list_mental_models_empty(self, api_client, test_bank_id):
+        """Test listing mental models when none exist."""
         pass
 
-    @pytest.mark.skip(reason="Observations endpoint removed - use recall with fact_type=['observation']")
+    @pytest.mark.skip(reason="Mental models endpoint removed - use recall with fact_type=['mental_model']")
     @pytest.mark.asyncio
-    async def test_get_observation_not_found(self, api_client, test_bank_id):
-        """Test getting a non-existent observation."""
+    async def test_get_mental_model_not_found(self, api_client, test_bank_id):
+        """Test getting a non-existent mental model."""
         pass
 
 
-class TestMentalModelsAPI:
-    """Test mental models API endpoints."""
+class TestReflectionsAPI:
+    """Test reflections API endpoints."""
 
     @pytest.mark.asyncio
-    async def test_mental_models_api_crud(self, api_client, test_bank_id):
+    async def test_reflections_api_crud(self, api_client, test_bank_id):
         """Test full CRUD cycle through API."""
         import asyncio
 
         # Create bank first via profile endpoint
         await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
 
-        # Create a mental model (async operation)
+        # Create a reflection (async operation)
         response = await api_client.post(
-            f"/v1/default/banks/{test_bank_id}/mental-models",
+            f"/v1/default/banks/{test_bank_id}/reflections",
             json={
-                "name": "API Test Mental Model",
+                "name": "API Test Reflection",
                 "source_query": "What is the API test about?",
-                "content": "This is an API test mental model",
+                "content": "This is an API test reflection",
                 "tags": ["api-test"],
             },
         )
@@ -232,72 +232,44 @@ class TestMentalModelsAPI:
                     break
             await asyncio.sleep(1)
 
-        # List mental models to get the created mental model
-        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/mental-models")
+        # List reflections to get the created reflection
+        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/reflections")
         assert response.status_code == 200
-        mental_models = response.json()["items"]
-        assert len(mental_models) >= 1
+        reflections = response.json()["items"]
+        assert len(reflections) >= 1
 
-        # Find our mental model
-        mental_model = next((m for m in mental_models if m["name"] == "API Test Mental Model"), None)
-        assert mental_model is not None, f"Mental model not found. Items: {mental_models}"
-        mental_model_id = mental_model["id"]
+        # Find our reflection
+        reflection = next((r for r in reflections if r["name"] == "API Test Reflection"), None)
+        assert reflection is not None, f"Reflection not found. Items: {reflections}"
+        reflection_id = reflection["id"]
 
-        # Get the mental model
-        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}")
+        # Get the reflection
+        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}")
         assert response.status_code == 200
-        assert response.json()["name"] == "API Test Mental Model"
+        assert response.json()["name"] == "API Test Reflection"
 
-        # Update the mental model
+        # Update the reflection
         response = await api_client.patch(
-            f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}",
-            json={"name": "Updated API Test Mental Model"},
+            f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}",
+            json={"name": "Updated API Test Reflection"},
         )
         assert response.status_code == 200
-        assert response.json()["name"] == "Updated API Test Mental Model"
+        assert response.json()["name"] == "Updated API Test Reflection"
 
-        # Delete the mental model
-        response = await api_client.delete(f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}")
+        # Delete the reflection
+        response = await api_client.delete(f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}")
         assert response.status_code == 200
 
         # Verify deletion
-        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}")
+        response = await api_client.get(f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}")
         assert response.status_code == 404
 
         # Cleanup
         await api_client.delete(f"/v1/default/banks/{test_bank_id}")
 
 
-class TestRecallWithObservationsAndMentalModels:
-    """Test recall integration with observations and mental models."""
-
-    @pytest.mark.asyncio
-    async def test_recall_includes_observations(self, api_client, test_bank_id):
-        """Test that recall can include observations in the response."""
-        # Create bank first via profile endpoint
-        await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
-
-        # Note: Observations are auto-created via consolidation, not manually
-        # This test just verifies the include parameter works
-
-        # Recall with observations included
-        response = await api_client.post(
-            f"/v1/default/banks/{test_bank_id}/memories/recall",
-            json={
-                "query": "What is machine learning?",
-                "include": {
-                    "observations": {"max_results": 5},
-                },
-            },
-        )
-        assert response.status_code == 200
-        result = response.json()
-
-        # Should have observations field in response (may be empty)
-        assert "observations" in result or result.get("observations") is None
-
-        # Cleanup
-        await api_client.delete(f"/v1/default/banks/{test_bank_id}")
+class TestRecallWithMentalModelsAndReflections:
+    """Test recall integration with mental models and reflections."""
 
     @pytest.mark.asyncio
     async def test_recall_includes_mental_models(self, api_client, test_bank_id):
@@ -305,9 +277,37 @@ class TestRecallWithObservationsAndMentalModels:
         # Create bank first via profile endpoint
         await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
 
-        # Create a mental model first
+        # Note: Mental models are auto-created via consolidation, not manually
+        # This test just verifies the include parameter works
+
+        # Recall with mental models included
         response = await api_client.post(
-            f"/v1/default/banks/{test_bank_id}/mental-models",
+            f"/v1/default/banks/{test_bank_id}/memories/recall",
+            json={
+                "query": "What is machine learning?",
+                "include": {
+                    "mental_models": {"max_results": 5},
+                },
+            },
+        )
+        assert response.status_code == 200
+        result = response.json()
+
+        # Should have mental_models field in response (may be empty)
+        assert "mental_models" in result or result.get("mental_models") is None
+
+        # Cleanup
+        await api_client.delete(f"/v1/default/banks/{test_bank_id}")
+
+    @pytest.mark.asyncio
+    async def test_recall_includes_reflections(self, api_client, test_bank_id):
+        """Test that recall can include reflections in the response."""
+        # Create bank first via profile endpoint
+        await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
+
+        # Create a reflection first
+        response = await api_client.post(
+            f"/v1/default/banks/{test_bank_id}/reflections",
             json={
                 "name": "AI Overview",
                 "source_query": "What is AI?",
@@ -317,32 +317,32 @@ class TestRecallWithObservationsAndMentalModels:
         )
         assert response.status_code == 200
 
-        # Recall with mental models included
+        # Recall with reflections included
         response = await api_client.post(
             f"/v1/default/banks/{test_bank_id}/memories/recall",
             json={
                 "query": "What is artificial intelligence?",
                 "include": {
-                    "mental_models": {"max_results": 5},
+                    "reflections": {"max_results": 5},
                 },
             },
         )
         assert response.status_code == 200
         result = response.json()
 
-        # Should have mental_models in response (may be empty if embedding not generated yet)
-        assert "mental_models" in result or result.get("mental_models") is None
+        # Should have reflections in response (may be empty if embedding not generated yet)
+        assert "reflections" in result or result.get("reflections") is None
 
         # Cleanup
         await api_client.delete(f"/v1/default/banks/{test_bank_id}")
 
     @pytest.mark.asyncio
-    async def test_recall_without_observations_by_default(self, api_client, test_bank_id):
-        """Test that recall does not include observations by default."""
+    async def test_recall_without_mental_models_by_default(self, api_client, test_bank_id):
+        """Test that recall does not include mental models by default."""
         # Create bank first via profile endpoint
         await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
 
-        # Recall without specifying observations
+        # Recall without specifying mental models
         response = await api_client.post(
             f"/v1/default/banks/{test_bank_id}/memories/recall",
             json={
@@ -352,97 +352,8 @@ class TestRecallWithObservationsAndMentalModels:
         assert response.status_code == 200
         result = response.json()
 
-        # Observations should not be in response
-        assert result.get("observations") is None
+        # Mental models should not be in response
+        assert result.get("mental_models") is None
 
         # Cleanup
         await api_client.delete(f"/v1/default/banks/{test_bank_id}")
-
-
-class TestReflectUsesMentalModels:
-    """Test that reflect searches and uses mental models when available."""
-
-    @pytest.mark.asyncio
-    async def test_reflect_searches_mental_models_when_available(self, memory: MemoryEngine, request_context):
-        """Test that reflect uses search_mental_models when the bank has mental models.
-
-        Given:
-        - A bank with a mental model about "team collaboration"
-
-        Expected:
-        - Reflect should call search_mental_models tool
-        - The mental model content should influence the response
-        """
-        bank_id = f"test-reflect-mm-{uuid.uuid4().hex[:8]}"
-
-        # Create the bank
-        await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
-
-        # Create a mental model about team collaboration
-        mental_model = await memory.create_mental_model(
-            bank_id=bank_id,
-            mental_model_id=str(uuid.uuid4()),
-            name="Team Collaboration Practices",
-            source_query="How does the team collaborate?",
-            content="The team uses async communication via Slack and holds daily standups at 9am. "
-            "Code reviews are required before merging. The team values documentation and "
-            "prefers written communication for complex decisions.",
-            tags=["team"],
-            request_context=request_context,
-        )
-
-        # Run reflect with a query about team collaboration
-        result = await memory.reflect_async(
-            bank_id=bank_id,
-            query="How does the team work together?",
-            request_context=request_context,
-        )
-
-        # Check that mental models were searched
-        tool_calls = result.tool_trace
-        search_mm_calls = [tc for tc in tool_calls if tc.tool == "search_mental_models"]
-
-        assert len(search_mm_calls) > 0, (
-            f"Expected search_mental_models to be called when bank has mental models. "
-            f"Tool calls: {[tc.tool for tc in tool_calls]}"
-        )
-
-        # Check that the reason field is populated for debugging
-        for tc in search_mm_calls:
-            assert tc.reason is not None, "Tool call should have a reason for debugging"
-
-        # The response should mention concepts from the mental model
-        response_text = result.text.lower()
-        has_relevant_content = any(
-            keyword in response_text
-            for keyword in ["slack", "async", "standup", "code review", "documentation", "communication"]
-        )
-        assert has_relevant_content, (
-            f"Expected response to reference mental model content. Got: {result.text[:500]}"
-        )
-
-        # Cleanup
-        await memory.delete_bank(bank_id, request_context=request_context)
-
-    @pytest.mark.asyncio
-    async def test_reflect_tool_trace_includes_reason(self, memory: MemoryEngine, request_context):
-        """Test that tool traces include the reason field for debugging."""
-        bank_id = f"test-reflect-reason-{uuid.uuid4().hex[:8]}"
-
-        # Create the bank
-        await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
-
-        # Run reflect - it should use observations or recall
-        result = await memory.reflect_async(
-            bank_id=bank_id,
-            query="What is the weather like?",
-            request_context=request_context,
-        )
-
-        # All tool calls should have a reason
-        for tc in result.tool_trace:
-            if tc.tool != "done":  # done doesn't need a reason
-                assert tc.reason is not None, f"Tool {tc.tool} should have a reason for debugging"
-
-        # Cleanup
-        await memory.delete_bank(bank_id, request_context=request_context)

hindsight-api/tests/test_retain.py

@@ -16,6 +16,7 @@ async def test_retain_with_chunks(memory, request_context):
     Test that retain function:
     1. Stores facts with associated chunks
     2. Recall returns chunk_id for each fact
+    3. Recall with include_entities=True also works (for compatibility)
     """
     bank_id = f"test_chunks_{datetime.now(timezone.utc).timestamp()}"
     document_id = "test_doc_123"
@@ -55,6 +56,7 @@ async def test_retain_with_chunks(memory, request_context):
             budget=Budget.LOW,
             max_tokens=500,
             fact_type=["world"],  # Search for world facts
+            include_entities=False,  # Disable entities for simpler test
             include_chunks=True,  # Enable chunks
             max_chunk_tokens=8192,
             request_context=request_context,
@@ -144,6 +146,7 @@ async def test_chunks_and_entities_follow_fact_order(memory, request_context):
             budget=Budget.MID,
             max_tokens=1000,
             fact_type=["world"],
+            include_entities=True,
             include_chunks=True,
             max_chunk_tokens=8192,
             request_context=request_context,
@@ -2079,117 +2082,3 @@ def test_recall_result_model_empty_construction():
     assert result.chunks == {}, "Should have empty chunks"
 
     logger.info("✓ RecallResult empty construction works correctly")
-
-
-@pytest.mark.asyncio
-async def test_custom_extraction_mode():
-    """
-    Test that custom extraction mode uses custom guidelines from env variable.
-
-    This test verifies that when HINDSIGHT_API_RETAIN_EXTRACTION_MODE=custom and
-    HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS is set, the fact extraction uses the
-    custom guidelines while keeping structural parts intact.
-    """
-    import os
-    from hindsight_api import LLMConfig
-    from hindsight_api.engine.retain.fact_extraction import extract_facts_from_text
-    from hindsight_api.config import clear_config_cache
-
-    # Save original env vars
-    original_mode = os.getenv("HINDSIGHT_API_RETAIN_EXTRACTION_MODE")
-    original_instructions = os.getenv("HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS")
-
-    try:
-        # Set custom extraction mode with challenging language-specific guidelines
-        os.environ["HINDSIGHT_API_RETAIN_EXTRACTION_MODE"] = "custom"
-        os.environ["HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS"] = """ONLY extract facts that are in ITALIAN language.
-
-DO NOT extract:
-❌ Facts in English
-❌ Facts in any other language besides Italian
-
-If the text contains both Italian and English content, extract ONLY the Italian facts."""
-
-        # Clear config cache to pick up new env vars
-        clear_config_cache()
-
-        # Test content with BOTH Italian (should extract) and English (should NOT extract) facts
-        # This is a much harder test than filtering greetings
-        text = """
-        The team discussed the new architecture. We will use microservices.
-
-        Il database PostgreSQL ha ridotto la latenza delle query del 60%.
-        Alice ha suggerito di usare il connection pooling per migliorare le prestazioni.
-
-        Bob mentioned that the API endpoint is ready for testing.
-        The deployment pipeline has been updated to use Kubernetes.
-
-        Marco ha completato la revisione del codice e ha approvato le modifiche.
-        Il sistema di autenticazione è stato migrato a OAuth 2.0.
-        """
-
-        llm_config = LLMConfig.for_memory()
-
-        facts, _, _ = await extract_facts_from_text(
-            text=text,
-            event_date=datetime(2024, 1, 15, tzinfo=timezone.utc),
-            context="team meeting notes",
-            llm_config=llm_config,
-            agent_name="TestUser"
-        )
-
-        logger.info(f"\nExtracted {len(facts)} facts with custom mode (Italian only):")
-        for i, fact in enumerate(facts):
-            logger.info(f"  {i+1}. {fact.fact}")
-
-        assert len(facts) > 0, "Should extract at least one Italian fact"
-
-        # All facts text
-        all_facts_text = " ".join([f.fact for f in facts])
-
-        # Should HAVE Italian content
-        italian_keywords = ["postgresql", "latenza", "query", "alice", "connection pooling", "prestazioni",
-                          "marco", "revisione", "codice", "autenticazione", "oauth"]
-        has_italian = any(keyword in all_facts_text.lower() for keyword in italian_keywords)
-        assert has_italian, f"Should extract Italian facts. Got: {all_facts_text}"
-
-        # Should NOT have English-only content
-        # These are facts that appear ONLY in English sections
-        english_only_keywords = ["microservices", "bob", "api endpoint", "testing", "deployment pipeline", "kubernetes"]
-
-        # Check if facts contain English-only content (this would be wrong)
-        facts_lower = all_facts_text.lower()
-        found_english_only = [kw for kw in english_only_keywords if kw in facts_lower]
-
-        if found_english_only:
-            logger.warning(f"⚠ Found English-only keywords in facts: {found_english_only}")
-            logger.warning(f"  Facts: {all_facts_text}")
-            logger.warning(f"  This may indicate the LLM is not strictly following language-specific custom guidelines")
-            # Log but don't fail - LLM behavior can vary
-        else:
-            logger.info("✓ Successfully extracted only Italian facts, ignored English facts")
-
-        # At least verify we have some Italian indicators
-        italian_indicators = ["latenza", "prestazioni", "revisione", "codice", "autenticazione"]
-        italian_count = sum(1 for ind in italian_indicators if ind in facts_lower)
-
-        assert italian_count >= 1, \
-            f"Should extract facts with Italian words. Found {italian_count} Italian indicators in: {all_facts_text}"
-
-        logger.info("✓ Custom extraction mode works with language-specific guidelines")
-        logger.info(f"✓ Extracted {len(facts)} Italian facts, found {italian_count} Italian indicators")
-
-    finally:
-        # Restore original env vars
-        if original_mode is not None:
-            os.environ["HINDSIGHT_API_RETAIN_EXTRACTION_MODE"] = original_mode
-        else:
-            os.environ.pop("HINDSIGHT_API_RETAIN_EXTRACTION_MODE", None)
-
-        if original_instructions is not None:
-            os.environ["HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS"] = original_instructions
-        else:
-            os.environ.pop("HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS", None)
-
-        # Clear cache again to restore original config
-        clear_config_cache()

hindsight-api/tests/test_sql_schema_safety.py

@@ -22,7 +22,7 @@ TABLES = [
     "chunks",
     "async_operations",
     "directives",
-    "mental_models",
+    "reflections",
 ]
 
 # Files to scan for SQL queries

hindsight-api/tests/test_tags_visibility.py

@@ -633,12 +633,7 @@ async def test_student_tracking_visibility(api_client):
 
 @pytest.mark.asyncio
 async def test_list_tags_returns_all_tags(api_client):
-    """Test that list_tags returns all unique tags with counts.
-
-    Note: list_tags counts all memory units including observations.
-    Observations inherit tags from their source facts (for visibility security),
-    so counts may be higher than the number of stored memories.
-    """
+    """Test that list_tags returns all unique tags with counts."""
     bank_id = f"list_tags_test_{datetime.now().timestamp()}"
 
     # Store memories with various tags
@@ -667,19 +662,18 @@ async def test_list_tags_returns_all_tags(api_client):
     assert "limit" in result
     assert "offset" in result
 
-    # Verify tags exist with at least the expected counts
-    # Note: Counts may be higher due to observations inheriting source fact tags
+    # Verify tags and counts
     tags_map = {item["tag"]: item["count"] for item in result["items"]}
     assert "user:alice" in tags_map
-    assert tags_map["user:alice"] >= 3  # At least 3 memories have this tag
+    assert tags_map["user:alice"] == 3  # 3 memories have this tag
     assert "user:bob" in tags_map
-    assert tags_map["user:bob"] >= 1
+    assert tags_map["user:bob"] == 1
     assert "session:123" in tags_map
-    assert tags_map["session:123"] >= 1
+    assert tags_map["session:123"] == 1
     assert "session:456" in tags_map
-    assert tags_map["session:456"] >= 1
+    assert tags_map["session:456"] == 1
 
-    assert result["total"] >= 4  # At least 4 unique tags
+    assert result["total"] == 4  # 4 unique tags
 
 
 @pytest.mark.asyncio

hindsight-api/tests/test_tei_cross_encoder.py

@@ -527,7 +527,6 @@ class TestRemoteTEICrossEncoderConfig:
         """Test creating encoder from environment variables."""
         import os
 
-        from hindsight_api.config import clear_config_cache
         from hindsight_api.engine.cross_encoder import create_cross_encoder_from_env
 
         with patch.dict(
@@ -539,7 +538,6 @@ class TestRemoteTEICrossEncoderConfig:
                 "HINDSIGHT_API_RERANKER_TEI_MAX_CONCURRENT": "16",
             },
         ):
-            clear_config_cache()  # Clear cache to pick up patched env vars
             encoder = create_cross_encoder_from_env()
 
             assert isinstance(encoder, RemoteTEICrossEncoder)
@@ -547,8 +545,6 @@ class TestRemoteTEICrossEncoderConfig:
             assert encoder.batch_size == 256
             assert encoder.max_concurrent == 16
 
-        clear_config_cache()  # Clear cache after test
-
 
 # ============================================================================
 # TEI Reranker Performance Benchmark Tests

hindsight-api/tests/test_think.py

@@ -1,5 +1,5 @@
 """
-Test reflect (think) function.
+Test think function for opinion generation and consistency.
 """
 import pytest
 from datetime import datetime, timezone
@@ -7,6 +7,131 @@ from hindsight_api.engine.memory_engine import Budget
 from hindsight_api import RequestContext
 
 
+@pytest.mark.asyncio
+async def test_think_opinion_consistency(memory, request_context):
+    """
+    Test that think function:
+    1. Generates an opinion
+    2. Stores the opinion in the database
+    3. Returns consistent response on subsequent calls with the same query
+    """
+    bank_id = f"test_think_{datetime.now(timezone.utc).timestamp()}"
+
+    try:
+
+        # Store some initial facts to give context for opinion formation
+        await memory.retain_async(
+            bank_id=bank_id,
+            content="Alice is a software engineer who has worked on 5 major projects. She always delivers on time and writes clean, well-documented code.",
+            context="performance review",
+            event_date=datetime(2024, 1, 15, tzinfo=timezone.utc),
+            request_context=request_context,
+        )
+
+        await memory.retain_async(
+            bank_id=bank_id,
+            content="Bob recently joined the team. He missed his first deadline and his code had many bugs.",
+            context="performance review",
+            event_date=datetime(2024, 2, 1, tzinfo=timezone.utc),
+            request_context=request_context,
+        )
+
+        # First think call - should generate opinions
+        query = "Who is a more reliable engineer?"
+        result1 = await memory.reflect_async(
+            bank_id=bank_id,
+            query=query,
+            budget=Budget.LOW,
+            request_context=request_context,
+        )
+
+        print(f"\n=== First Think Call ===")
+        print(f"Answer: {result1.text}")
+
+        # Verify we got an answer
+        assert result1.text, "First think call should return an answer"
+        assert result1.based_on, "Should return based_on facts"
+
+        # Wait for background opinion processing tasks to complete
+        await memory.wait_for_background_tasks()
+
+        # Search for stored opinions to verify they were actually saved
+        pool = await memory._get_pool()
+        async with pool.acquire() as conn:
+            stored_opinions = await conn.fetch(
+                """
+                SELECT id, text, confidence_score, fact_type
+                FROM memory_units
+                WHERE bank_id = $1 AND fact_type = 'opinion'
+                ORDER BY created_at DESC
+                """,
+                bank_id
+            )
+
+        print(f"\n=== Stored Opinions in Database ===")
+        print(f"Total opinions stored: {len(stored_opinions)}")
+        for op in stored_opinions:
+            print(f"  - {op['text']} (confidence: {op['confidence_score']:.2f})")
+
+        # Verify opinions were actually written to database
+        # NOTE: Opinion extraction may not always detect opinions depending on the LLM response format
+        if len(stored_opinions) > 0:
+            assert all(op['fact_type'] == 'opinion' for op in stored_opinions), "All stored items should have fact_type='opinion'"
+            print(f"✓ Opinions were successfully stored in database")
+        else:
+            print(f"⚠ Note: No opinions were extracted/stored (this can happen if the LLM response format doesn't trigger opinion extraction)")
+
+        # Second think call - should use the stored opinions
+        result2 = await memory.reflect_async(
+            bank_id=bank_id,
+            query=query,
+            budget=Budget.LOW,
+            request_context=request_context,
+        )
+
+        print(f"\n=== Second Think Call ===")
+        print(f"Answer: {result2.text}")
+        print(f"Existing opinions used: {len(result2.based_on.get('opinion', []))}")
+        for opinion in result2.based_on.get('opinion', []):
+            print(f"  - {opinion.text}")
+
+        # Verify second call also got an answer
+        assert result2.text, "Second think call should return an answer"
+
+        # Verify second call used the stored opinions (if any were stored)
+        if len(stored_opinions) > 0:
+            assert len(result2.based_on.get('opinion', [])) > 0, "Second call should retrieve stored opinions"
+
+        # The responses should be consistent (both should mention the same person as more reliable)
+        # We'll do a basic check that they're not contradictory
+        text1_lower = result1.text.lower()
+        text2_lower = result2.text.lower()
+
+        print(f"\n=== Consistency Check ===")
+
+        # Check if Alice is mentioned as more reliable in first response
+        if 'alice' in text1_lower and ('reliable' in text1_lower or 'better' in text1_lower):
+            print("First response favors Alice")
+            # Second response should also favor Alice (consistency)
+            assert 'alice' in text2_lower, "Second response should also mention Alice"
+            print("Second response also mentions Alice - CONSISTENT ✓")
+
+        # Check if Bob is mentioned
+        if 'bob' in text1_lower:
+            print("First response mentions Bob")
+            if 'bob' in text2_lower:
+                print("Second response also mentions Bob - CONSISTENT ✓")
+
+        print(f"\n✅ Test passed - opinions were formed, stored, and used consistently")
+
+    finally:
+        # Clean up agent data
+        try:
+            await memory.delete_bank(bank_id, request_context=request_context)
+        except Exception as e:
+            print(f"Warning: Error during cleanup: {e}")
+
+
 @pytest.mark.asyncio
 async def test_think_without_prior_context(memory, request_context):
     """

hindsight-api/tests/test_vertexai_provider.py

@@ -1,244 +0,0 @@
-"""
-Test Vertex AI provider integration using native genai SDK.
-"""
-
-import os
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-# Skip all tests if google-auth not available
-pytest.importorskip("google.auth")
-
-
-def test_llm_wrapper_vertexai_missing_dependency():
-    """Test error when google-auth is not available and service account key is set."""
-    from hindsight_api.engine import llm_wrapper
-
-    # VERTEXAI_AVAILABLE only matters when a service account key is provided
-    original_available = llm_wrapper.VERTEXAI_AVAILABLE
-    try:
-        llm_wrapper.VERTEXAI_AVAILABLE = False
-
-        with patch.dict(
-            os.environ,
-            {
-                "HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID": "test-project",
-                "HINDSIGHT_API_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY": "/path/to/key.json",
-            },
-            clear=False,
-        ):
-            from hindsight_api.config import clear_config_cache
-
-            clear_config_cache()
-
-            with pytest.raises(ValueError, match="google-auth"):
-                from hindsight_api.engine.llm_wrapper import LLMProvider
-
-                LLMProvider(
-                    provider="vertexai",
-                    api_key="",
-                    base_url="",
-                    model="google/gemini-2.0-flash-001",
-                )
-
-            clear_config_cache()
-    finally:
-        llm_wrapper.VERTEXAI_AVAILABLE = original_available
-
-
-def test_llm_wrapper_vertexai_missing_project_id():
-    """Test error when project ID is not configured."""
-    with patch.dict(os.environ, {"HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID": ""}, clear=False):
-        from hindsight_api.config import clear_config_cache
-
-        clear_config_cache()
-
-        with pytest.raises(ValueError, match="HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID"):
-            from hindsight_api.engine.llm_wrapper import LLMProvider
-
-            LLMProvider(
-                provider="vertexai",
-                api_key="",
-                base_url="",
-                model="google/gemini-2.0-flash-001",
-            )
-
-        clear_config_cache()
-
-
-def test_llm_wrapper_vertexai_adc_auth():
-    """Test Vertex AI with ADC authentication creates native genai client."""
-    from hindsight_api.engine.llm_wrapper import LLMProvider
-
-    with patch.dict(
-        os.environ,
-        {"HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID": "test-project"},
-        clear=False,
-    ):
-        from hindsight_api.config import clear_config_cache
-
-        clear_config_cache()
-
-        # genai.Client handles ADC internally — just verify it creates the client
-        with patch("google.genai.Client") as mock_client_cls:
-            mock_client_cls.return_value = MagicMock()
-
-            provider = LLMProvider(
-                provider="vertexai",
-                api_key="",
-                base_url="",
-                model="google/gemini-2.0-flash-001",
-            )
-
-            assert provider.provider == "vertexai"
-            assert provider.model == "gemini-2.0-flash-001"  # google/ prefix stripped
-            assert provider._gemini_client is not None
-
-            # Verify genai.Client was called with vertexai=True
-            mock_client_cls.assert_called_once_with(
-                vertexai=True,
-                project="test-project",
-                location="us-central1",
-            )
-
-        clear_config_cache()
-
-
-def test_llm_wrapper_vertexai_sa_auth():
-    """Test Vertex AI with service account authentication passes credentials to genai client."""
-    from hindsight_api.engine.llm_wrapper import LLMProvider
-
-    mock_credentials = MagicMock()
-
-    with patch.dict(
-        os.environ,
-        {
-            "HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID": "test-project",
-            "HINDSIGHT_API_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY": "/path/to/key.json",
-        },
-        clear=False,
-    ):
-        from hindsight_api.config import clear_config_cache
-
-        clear_config_cache()
-
-        with patch(
-            "google.oauth2.service_account.Credentials.from_service_account_file",
-            return_value=mock_credentials,
-        ):
-            with patch("google.genai.Client") as mock_client_cls:
-                mock_client_cls.return_value = MagicMock()
-
-                provider = LLMProvider(
-                    provider="vertexai",
-                    api_key="",
-                    base_url="",
-                    model="google/gemini-2.0-flash-001",
-                )
-
-                assert provider.provider == "vertexai"
-                assert provider._gemini_client is not None
-
-                # Verify credentials were passed to genai.Client
-                mock_client_cls.assert_called_once_with(
-                    vertexai=True,
-                    project="test-project",
-                    location="us-central1",
-                    credentials=mock_credentials,
-                )
-
-        clear_config_cache()
-
-
-def test_llm_wrapper_vertexai_strips_google_prefix():
-    """Test that google/ prefix is stripped from model name for native SDK."""
-    from hindsight_api.engine.llm_wrapper import LLMProvider
-
-    with patch.dict(
-        os.environ,
-        {"HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID": "test-project"},
-        clear=False,
-    ):
-        from hindsight_api.config import clear_config_cache
-
-        clear_config_cache()
-
-        with patch("google.genai.Client") as mock_client_cls:
-            mock_client_cls.return_value = MagicMock()
-
-            provider = LLMProvider(
-                provider="vertexai",
-                api_key="",
-                base_url="",
-                model="google/gemini-2.0-flash-lite-001",
-            )
-
-            assert provider.model == "gemini-2.0-flash-lite-001"
-
-        clear_config_cache()
-
-
-def test_llm_wrapper_vertexai_no_prefix_model():
-    """Test that model without google/ prefix is unchanged."""
-    from hindsight_api.engine.llm_wrapper import LLMProvider
-
-    with patch.dict(
-        os.environ,
-        {"HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID": "test-project"},
-        clear=False,
-    ):
-        from hindsight_api.config import clear_config_cache
-
-        clear_config_cache()
-
-        with patch("google.genai.Client") as mock_client_cls:
-            mock_client_cls.return_value = MagicMock()
-
-            provider = LLMProvider(
-                provider="vertexai",
-                api_key="",
-                base_url="",
-                model="gemini-2.0-flash-001",
-            )
-
-            assert provider.model == "gemini-2.0-flash-001"
-
-        clear_config_cache()
-
-
-@pytest.mark.asyncio
-@pytest.mark.skipif(
-    not os.getenv("HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID"),
-    reason="Vertex AI integration tests require HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID",
-)
-async def test_vertexai_integration_actual_api():
-    """
-    Integration test with actual Vertex AI API.
-
-    Requires:
-    - HINDSIGHT_API_LLM_VERTEXAI_PROJECT_ID
-    - ADC or HINDSIGHT_API_LLM_VERTEXAI_SERVICE_ACCOUNT_KEY
-    """
-    from hindsight_api.engine.llm_wrapper import LLMProvider
-
-    provider = LLMProvider(
-        provider="vertexai",
-        api_key="",
-        base_url="",
-        model="google/gemini-2.0-flash-001",
-    )
-
-    try:
-        # Simple test call
-        response = await provider.call(
-            messages=[{"role": "user", "content": "Say 'ok' and nothing else"}],
-            max_completion_tokens=10,
-        )
-
-        assert response is not None
-        assert isinstance(response, str)
-        assert len(response) > 0
-
-    finally:
-        await provider.cleanup()

hindsight-api/tests/test_worker.py

@@ -156,6 +156,7 @@ class TestWorkerPoller:
             pool=pool,
             worker_id="test-worker-1",
             executor=mock_executor,
+            batch_size=10,
         )
 
         claimed = await poller.claim_batch()
@@ -176,8 +177,8 @@ class TestWorkerPoller:
             assert row["worker_id"] == "test-worker-1"
 
     @pytest.mark.asyncio
-    async def test_claim_batch_respects_max_slots(self, pool, clean_operations):
-        """Test that claim_batch respects the max_slots limit."""
+    async def test_claim_batch_respects_batch_size(self, pool, clean_operations):
+        """Test that claim_batch respects the batch_size limit."""
         from hindsight_api.worker import WorkerPoller
 
         # Create 10 pending tasks
@@ -195,11 +196,12 @@ class TestWorkerPoller:
                 payload,
             )
 
+        # Claim with batch_size=3
         poller = WorkerPoller(
             pool=pool,
             worker_id="test-worker-1",
             executor=lambda x: None,
-            max_slots=3,  # Limit to 3 concurrent tasks
+            batch_size=3,
         )
 
         claimed = await poller.claim_batch()
@@ -236,14 +238,11 @@ class TestWorkerPoller:
             executor=mock_executor,
         )
 
-        # Execute the task (fire-and-forget)
+        # Execute the task
         task_dict = json.loads(payload)
         claimed_task = ClaimedTask(operation_id=str(op_id), task_dict=task_dict, schema=None)
         await poller.execute_task(claimed_task)
 
-        # Wait for background task to complete
-        completed = await poller.wait_for_active_tasks(timeout=5.0)
-        assert completed, "Task did not complete within timeout"
         assert len(executed) == 1
 
         # Verify task is marked as completed
@@ -284,15 +283,11 @@ class TestWorkerPoller:
             max_retries=3,
         )
 
-        # Execute (should fail and retry) - fire-and-forget
+        # Execute (should fail and retry)
         task_dict = json.loads(payload)
         claimed_task = ClaimedTask(operation_id=str(op_id), task_dict=task_dict, schema=None)
         await poller.execute_task(claimed_task)
 
-        # Wait for background task to complete
-        completed = await poller.wait_for_active_tasks(timeout=5.0)
-        assert completed, "Task did not complete within timeout"
-
         # Verify task is back to pending with incremented retry_count
         row = await pool.fetchrow(
             "SELECT status, retry_count, worker_id FROM async_operations WHERE operation_id = $1",
@@ -332,15 +327,11 @@ class TestWorkerPoller:
             max_retries=3,
         )
 
-        # Execute (should fail permanently) - fire-and-forget
+        # Execute (should fail permanently)
         task_dict = json.loads(payload)
         claimed_task = ClaimedTask(operation_id=str(op_id), task_dict=task_dict, schema=None)
         await poller.execute_task(claimed_task)
 
-        # Wait for background task to complete
-        completed = await poller.wait_for_active_tasks(timeout=5.0)
-        assert completed, "Task did not complete within timeout"
-
         # Verify task is marked as failed
         row = await pool.fetchrow(
             "SELECT status, error_message FROM async_operations WHERE operation_id = $1",
@@ -397,6 +388,7 @@ class TestWorkerPoller:
             pool=pool,
             worker_id="test-worker-1",
             executor=lambda x: None,
+            batch_size=10,
         )
 
         claimed = await poller.claim_batch()
@@ -448,6 +440,7 @@ class TestWorkerPoller:
             pool=pool,
             worker_id="test-worker-1",
             executor=lambda x: None,
+            batch_size=10,
         )
 
         claimed = await poller.claim_batch()
@@ -614,6 +607,7 @@ class TestConcurrentWorkers:
                 pool=pool,
                 worker_id=worker_id,
                 executor=lambda x: None,
+                batch_size=5,  # Each worker tries to claim 5
             )
             claimed = await poller.claim_batch()
             workers_claimed[worker_id] = [task.operation_id for task in claimed]
@@ -686,6 +680,7 @@ class TestConcurrentWorkers:
             pool=pool,
             worker_id="new-worker",
             executor=lambda x: None,
+            batch_size=10,
         )
 
         claimed = await poller.claim_batch()
@@ -884,6 +879,7 @@ class TestDynamicTenantDiscovery:
             pool=pool,
             worker_id="test-worker-1",
             executor=lambda x: None,
+            batch_size=10,
             tenant_extension=mock_extension,
         )
 
@@ -950,6 +946,7 @@ class TestDynamicTenantDiscovery:
             pool=pool,
             worker_id="test-worker-1",
             executor=lambda x: None,
+            batch_size=10,
             tenant_extension=dynamic_extension,
         )
 
@@ -1011,6 +1008,7 @@ class TestDynamicTenantDiscovery:
             pool=pool,
             worker_id="test-worker-1",
             executor=lambda x: None,
+            batch_size=10,
         )
 
         claimed = await poller.claim_batch()
@@ -1019,273 +1017,3 @@ class TestDynamicTenantDiscovery:
         # All tasks should have schema=None (public)
         for task in claimed:
             assert task.schema is None
-
-    @pytest.mark.asyncio
-    async def test_poller_with_custom_schema(self, pool):
-        """Test that poller uses custom schema when schema parameter is provided."""
-        from hindsight_api.worker import WorkerPoller
-
-        # Create a custom schema for testing
-        test_schema = "test_custom_schema"
-
-        try:
-            # Create schema and copy table structure
-            await pool.execute(f'CREATE SCHEMA IF NOT EXISTS "{test_schema}"')
-            await pool.execute(
-                f"""
-                CREATE TABLE "{test_schema}".async_operations (
-                    LIKE public.async_operations INCLUDING ALL
-                )
-                """
-            )
-
-            # Create pending tasks in the custom schema
-            bank_id = f"test-worker-{uuid.uuid4().hex[:8]}"
-            task_ids = []
-            for i in range(3):
-                op_id = uuid.uuid4()
-                task_ids.append(str(op_id))
-                payload = json.dumps({"type": "test_task", "index": i, "bank_id": bank_id})
-                await pool.execute(
-                    f"""
-                    INSERT INTO "{test_schema}".async_operations (operation_id, bank_id, operation_type, status, task_payload)
-                    VALUES ($1, $2, 'test', 'pending', $3::jsonb)
-                    """,
-                    op_id,
-                    bank_id,
-                    payload,
-                )
-
-            # Create poller with custom schema
-            poller = WorkerPoller(
-                pool=pool,
-                worker_id="test-worker-custom-schema",
-                executor=lambda x: None,
-                schema=test_schema,
-            )
-
-            # Claim tasks
-            claimed = await poller.claim_batch()
-            assert len(claimed) == 3, f"Expected 3 tasks, got {len(claimed)}"
-
-            # All tasks should have schema=test_schema
-            claimed_ids = []
-            for task in claimed:
-                assert task.schema == test_schema, f"Expected schema '{test_schema}', got '{task.schema}'"
-                claimed_ids.append(task.operation_id)
-
-            # Verify claimed tasks match what we inserted
-            assert set(claimed_ids) == set(task_ids)
-
-            # Verify tasks are marked as processing in the custom schema
-            rows = await pool.fetch(
-                f"""
-                SELECT operation_id, status, worker_id
-                FROM "{test_schema}".async_operations
-                WHERE operation_id = ANY($1)
-                """,
-                [uuid.UUID(tid) for tid in task_ids],
-            )
-            assert len(rows) == 3
-            for row in rows:
-                assert row["status"] == "processing"
-                assert row["worker_id"] == "test-worker-custom-schema"
-
-        finally:
-            # Clean up: drop the custom schema
-            await pool.execute(f'DROP SCHEMA IF EXISTS "{test_schema}" CASCADE')
-
-
-async def test_worker_fire_and_forget_nonblocking(pool, clean_operations):
-    """
-    Test that worker continues polling while tasks run (fire-and-forget pattern).
-
-    This test verifies the FIX: With the old blocking behavior, the worker would
-    wait for all tasks in a batch to complete before claiming more. This test
-    would FAIL with the old code because tasks 3-4 wouldn't be claimed until
-    tasks 1-2 complete. With fire-and-forget, tasks 3-4 are claimed immediately.
-    """
-    from hindsight_api.worker.poller import WorkerPoller
-
-    task_started = {}  # operation_id -> Event (set when task starts)
-    task_canfinish = {}  # operation_id -> Event (wait before finishing)
-
-    async def blocking_executor(task_dict: dict):
-        op_id = task_dict["operation_id"]
-        # Signal that this task has started
-        started = asyncio.Event()
-        task_started[op_id] = started
-        started.set()
-
-        # Block until we're told to finish
-        finish = asyncio.Event()
-        task_canfinish[op_id] = finish
-        await finish.wait()
-
-    poller = WorkerPoller(
-        pool=pool,
-        worker_id="test-worker",
-        executor=blocking_executor,
-        poll_interval_ms=50,  # Fast polling
-        max_slots=10,
-        consolidation_max_slots=2,
-    )
-
-    bank_id = f"test-worker-{uuid.uuid4().hex[:8]}"
-
-    # Submit initial 2 tasks
-    task_ids = []
-    for i in range(2):
-        op_id = uuid.uuid4()
-        task_ids.append(str(op_id))
-        payload = json.dumps({"type": "test", "operation_type": "retain", "operation_id": str(op_id), "bank_id": bank_id})
-        await pool.execute(
-            """
-            INSERT INTO async_operations (operation_id, bank_id, operation_type, status, task_payload)
-            VALUES ($1, $2, 'retain', 'pending', $3::jsonb)
-            """,
-            op_id,
-            bank_id,
-            payload,
-        )
-
-    poll_task = asyncio.create_task(poller.run())
-
-    try:
-        # Wait for first 2 tasks to start executing (but not finish)
-        for i in range(100):  # Try for up to 1 second
-            if len(task_started) >= 2:
-                break
-            await asyncio.sleep(0.01)
-        assert len(task_started) == 2, f"Expected 2 tasks started, got {len(task_started)}"
-
-        # Verify tasks are in_flight
-        async with poller._in_flight_lock:
-            assert poller._in_flight_count == 2
-
-        # NOW submit 2 more tasks WHILE the first 2 are still running
-        for i in range(2):
-            op_id = uuid.uuid4()
-            task_ids.append(str(op_id))
-            payload = json.dumps({"type": "test", "operation_type": "retain", "operation_id": str(op_id), "bank_id": bank_id})
-            await pool.execute(
-                """
-                INSERT INTO async_operations (operation_id, bank_id, operation_type, status, task_payload)
-                VALUES ($1, $2, 'retain', 'pending', $3::jsonb)
-                """,
-                op_id,
-                bank_id,
-                payload,
-            )
-
-        # KEY ASSERTION: Worker should claim tasks 3-4 WITHOUT waiting for 1-2 to finish
-        # This would FAIL with the old blocking behavior
-        for i in range(100):  # Try for up to 1 second
-            if len(task_started) >= 4:
-                break
-            await asyncio.sleep(0.01)
-
-        assert len(task_started) == 4, (
-            f"Fire-and-forget FAILED: Expected 4 tasks started, got {len(task_started)}. "
-            "This means the worker blocked waiting for the first batch to complete."
-        )
-
-        # Verify all 4 tasks are in-flight
-        async with poller._in_flight_lock:
-            assert poller._in_flight_count == 4
-
-        # Clean up: allow all tasks to finish
-        for event in task_canfinish.values():
-            event.set()
-
-    finally:
-        # Ensure cleanup
-        for event in task_canfinish.values():
-            event.set()
-        await poller.shutdown_graceful(timeout=2.0)
-        try:
-            await asyncio.wait_for(poll_task, timeout=1.0)
-        except asyncio.CancelledError:
-            pass
-
-
-async def test_worker_slot_limits_enforced(pool, clean_operations):
-    """Test that worker respects max_slots and won't exceed the limit."""
-    from hindsight_api.worker.poller import WorkerPoller
-
-    tasks_started = set()
-    task_events = {}
-
-    async def controlled_executor(task_dict: dict):
-        op_id = task_dict["operation_id"]
-        tasks_started.add(op_id)
-        event = asyncio.Event()
-        task_events[op_id] = event
-        await event.wait()
-
-    poller = WorkerPoller(
-        pool=pool,
-        worker_id="test-worker",
-        executor=controlled_executor,
-        poll_interval_ms=50,
-        max_slots=3,  # Only allow 3 concurrent tasks
-        consolidation_max_slots=1,
-    )
-
-    # Submit 10 tasks
-    bank_id = f"test-worker-{uuid.uuid4().hex[:8]}"
-    for i in range(10):
-        op_id = uuid.uuid4()
-        payload = json.dumps({"type": "test", "operation_type": "retain", "operation_id": str(op_id), "bank_id": bank_id})
-        await pool.execute(
-            """
-            INSERT INTO async_operations (operation_id, bank_id, operation_type, status, task_payload)
-            VALUES ($1, $2, 'retain', 'pending', $3::jsonb)
-            """,
-            op_id,
-            bank_id,
-            payload,
-        )
-
-    poll_task = asyncio.create_task(poller.run())
-
-    try:
-        # Wait for slots to fill
-        for i in range(100):
-            if len(tasks_started) >= 3:
-                break
-            await asyncio.sleep(0.01)
-
-        # Should have claimed exactly 3 tasks (slot limit)
-        assert len(tasks_started) == 3
-
-        # Wait to ensure no additional tasks are claimed
-        for i in range(30):
-            await asyncio.sleep(0.01)
-        assert len(tasks_started) == 3, "Worker exceeded slot limit!"
-
-        # Release tasks one by one and verify remaining are claimed
-        completed = 0
-        while completed < 10 and len(tasks_started) < 10:
-            # Release the next batch
-            events_to_release = list(task_events.values())[completed:completed+3]
-            for event in events_to_release:
-                event.set()
-            completed += len(events_to_release)
-
-            # Wait for new tasks to be claimed
-            for i in range(100):
-                if len(tasks_started) >= min(completed + 3, 10):
-                    break
-                await asyncio.sleep(0.01)
-
-        assert len(tasks_started) == 10
-
-    finally:
-        for event in task_events.values():
-            event.set()
-        await poller.shutdown_graceful(timeout=2.0)
-        try:
-            await asyncio.wait_for(poll_task, timeout=1.0)
-        except asyncio.CancelledError:
-            pass

hindsight-cli/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "hindsight-cli"
-version = "0.4.8"
+version = "0.3.0"
 edition = "2021"
 authors = ["Hindsight Team"]
 description = "A beautiful CLI for Hindsight - semantic memory system"

hindsight-cli/src/api.rs

@@ -437,57 +437,57 @@ impl ApiClient {
         })
     }
 
-    // --- Mental Model Methods ---
+    // --- Reflection Methods ---
 
-    pub fn list_mental_models(&self, bank_id: &str, _verbose: bool) -> Result<types::MentalModelListResponse> {
+    pub fn list_reflections(&self, bank_id: &str, _verbose: bool) -> Result<types::ReflectionListResponse> {
         self.runtime.block_on(async {
-            let response = self.client.list_mental_models(bank_id, None, None, None, None, None).await?;
+            let response = self.client.list_reflections(bank_id, None, None, None, None, None).await?;
             Ok(response.into_inner())
         })
     }
 
-    pub fn get_mental_model(&self, bank_id: &str, mental_model_id: &str, _verbose: bool) -> Result<types::MentalModelResponse> {
+    pub fn get_reflection(&self, bank_id: &str, reflection_id: &str, _verbose: bool) -> Result<types::ReflectionResponse> {
         self.runtime.block_on(async {
-            let response = self.client.get_mental_model(bank_id, mental_model_id, None).await?;
+            let response = self.client.get_reflection(bank_id, reflection_id, None).await?;
             Ok(response.into_inner())
         })
     }
 
-    pub fn create_mental_model(
+    pub fn create_reflection(
         &self,
         bank_id: &str,
-        request: &types::CreateMentalModelRequest,
+        request: &types::CreateReflectionRequest,
         _verbose: bool,
-    ) -> Result<types::CreateMentalModelResponse> {
+    ) -> Result<types::CreateReflectionResponse> {
         self.runtime.block_on(async {
-            let response = self.client.create_mental_model(bank_id, None, request).await?;
+            let response = self.client.create_reflection(bank_id, None, request).await?;
             Ok(response.into_inner())
         })
     }
 
-    pub fn update_mental_model(
+    pub fn update_reflection(
         &self,
         bank_id: &str,
-        mental_model_id: &str,
-        request: &types::UpdateMentalModelRequest,
+        reflection_id: &str,
+        request: &types::UpdateReflectionRequest,
         _verbose: bool,
-    ) -> Result<types::MentalModelResponse> {
+    ) -> Result<types::ReflectionResponse> {
         self.runtime.block_on(async {
-            let response = self.client.update_mental_model(bank_id, mental_model_id, None, request).await?;
+            let response = self.client.update_reflection(bank_id, reflection_id, None, request).await?;
             Ok(response.into_inner())
         })
     }
 
-    pub fn delete_mental_model(&self, bank_id: &str, mental_model_id: &str, _verbose: bool) -> Result<serde_json::Value> {
+    pub fn delete_reflection(&self, bank_id: &str, reflection_id: &str, _verbose: bool) -> Result<serde_json::Value> {
         self.runtime.block_on(async {
-            let response = self.client.delete_mental_model(bank_id, mental_model_id, None).await?;
+            let response = self.client.delete_reflection(bank_id, reflection_id, None).await?;
             Ok(response.into_inner())
         })
     }
 
-    pub fn refresh_mental_model(&self, bank_id: &str, mental_model_id: &str, _verbose: bool) -> Result<types::AsyncOperationSubmitResponse> {
+    pub fn refresh_reflection(&self, bank_id: &str, reflection_id: &str, _verbose: bool) -> Result<types::AsyncOperationSubmitResponse> {
         self.runtime.block_on(async {
-            let response = self.client.refresh_mental_model(bank_id, mental_model_id, None).await?;
+            let response = self.client.refresh_reflection(bank_id, reflection_id, None).await?;
             Ok(response.into_inner())
         })
     }
@@ -539,31 +539,6 @@ impl ApiClient {
             Ok(response.into_inner())
         })
     }
-
-    // --- Consolidation Methods ---
-
-    pub fn trigger_consolidation(&self, bank_id: &str, _verbose: bool) -> Result<types::ConsolidationResponse> {
-        self.runtime.block_on(async {
-            let response = self.client.trigger_consolidation(bank_id, None).await?;
-            Ok(response.into_inner())
-        })
-    }
-
-    pub fn clear_observations(&self, bank_id: &str, _verbose: bool) -> Result<types::DeleteResponse> {
-        self.runtime.block_on(async {
-            let response = self.client.clear_observations(bank_id, None).await?;
-            Ok(response.into_inner())
-        })
-    }
-
-    // --- Version Methods ---
-
-    pub fn get_version(&self, _verbose: bool) -> Result<types::VersionResponse> {
-        self.runtime.block_on(async {
-            let response = self.client.get_version().await?;
-            Ok(response.into_inner())
-        })
-    }
 }
 
 // Re-export types from the generated client for use in commands

hindsight-cli/src/commands/bank.rs

@@ -495,163 +495,3 @@ pub fn delete(
         Err(e) => Err(e)
     }
 }
-
-/// Trigger consolidation to create/update observations
-pub fn consolidate(
-    client: &ApiClient,
-    bank_id: &str,
-    wait: bool,
-    poll_interval: u64,
-    verbose: bool,
-    output_format: OutputFormat,
-) -> Result<()> {
-    let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Triggering consolidation..."))
-    } else {
-        None
-    };
-
-    let response = client.trigger_consolidation(bank_id, verbose);
-
-    if let Some(mut sp) = spinner {
-        sp.finish();
-    }
-
-    match response {
-        Ok(result) => {
-            let operation_id = result.operation_id.clone();
-
-            if output_format == OutputFormat::Pretty {
-                ui::print_success("Consolidation triggered");
-                println!("  {} {}", ui::dim("Operation ID:"), operation_id);
-                if result.deduplicated {
-                    println!("  {} {}", ui::dim("Note:"), "Reusing existing pending consolidation task");
-                }
-            } else {
-                output::print_output(&result, output_format)?;
-            }
-
-            if !wait {
-                if output_format == OutputFormat::Pretty {
-                    println!();
-                    println!("{}", ui::dim("Use --wait to poll for completion, or 'hindsight operation get' to check status."));
-                }
-                return Ok(());
-            }
-
-            // Poll for completion
-            if output_format == OutputFormat::Pretty {
-                println!();
-                println!("{}", ui::dim(&format!("Polling every {}s for completion...", poll_interval)));
-            }
-
-            let start = std::time::Instant::now();
-            loop {
-                std::thread::sleep(std::time::Duration::from_secs(poll_interval));
-                let elapsed = start.elapsed().as_secs();
-
-                let ops_result = client.list_operations(bank_id, verbose);
-                match ops_result {
-                    Ok(ops) => {
-                        // Find the operation by ID
-                        let op = ops.operations.iter().find(|o| o.id == operation_id);
-
-                        match op.map(|o| o.status.as_str()) {
-                            Some("completed") => {
-                                if output_format == OutputFormat::Pretty {
-                                    ui::print_success(&format!("Consolidation completed ({}s)", elapsed));
-                                }
-                                break;
-                            }
-                            Some("failed") => {
-                                let error_msg = op
-                                    .and_then(|o| o.error_message.as_ref())
-                                    .map(|s| s.as_str())
-                                    .unwrap_or("Unknown error");
-                                if output_format == OutputFormat::Pretty {
-                                    ui::print_error(&format!("Consolidation failed: {}", error_msg));
-                                }
-                                std::process::exit(1);
-                            }
-                            Some(status) => {
-                                if output_format == OutputFormat::Pretty {
-                                    println!("  ⏳ {} ({}s elapsed)", status, elapsed);
-                                }
-                            }
-                            None => {
-                                if output_format == OutputFormat::Pretty {
-                                    ui::print_warning(&format!("Operation {} not found in list", operation_id));
-                                }
-                                break;
-                            }
-                        }
-                    }
-                    Err(e) => {
-                        if output_format == OutputFormat::Pretty {
-                            ui::print_error(&format!("Failed to check operation status: {}", e));
-                        }
-                        return Err(e);
-                    }
-                }
-            }
-
-            Ok(())
-        }
-        Err(e) => Err(e),
-    }
-}
-
-/// Clear all observations for a bank
-pub fn clear_observations(
-    client: &ApiClient,
-    bank_id: &str,
-    yes: bool,
-    verbose: bool,
-    output_format: OutputFormat,
-) -> Result<()> {
-    // Confirmation prompt unless -y flag is used
-    if !yes && output_format == OutputFormat::Pretty {
-        let message = format!(
-            "Are you sure you want to clear all observations for bank '{}'? This cannot be undone.",
-            bank_id
-        );
-
-        let confirmed = ui::prompt_confirmation(&message)?;
-
-        if !confirmed {
-            ui::print_info("Operation cancelled");
-            return Ok(());
-        }
-    }
-
-    let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Clearing observations..."))
-    } else {
-        None
-    };
-
-    let response = client.clear_observations(bank_id, verbose);
-
-    if let Some(mut sp) = spinner {
-        sp.finish();
-    }
-
-    match response {
-        Ok(result) => {
-            if output_format == OutputFormat::Pretty {
-                if result.success {
-                    ui::print_success(&format!("Observations cleared for bank '{}'", bank_id));
-                    if let Some(count) = result.deleted_count {
-                        println!("  Observations deleted: {}", count);
-                    }
-                } else {
-                    ui::print_error("Failed to clear observations");
-                }
-            } else {
-                output::print_output(&result, output_format)?;
-            }
-            Ok(())
-        }
-        Err(e) => Err(e),
-    }
-}

hindsight-cli/src/commands/document.rs

@@ -1,6 +1,4 @@
 use anyhow::Result;
-use chrono::{Duration as ChronoDuration, NaiveDate, Utc};
-use std::collections::BTreeMap;
 use crate::api::ApiClient;
 use crate::output::{self, OutputFormat};
 use crate::ui;
@@ -9,17 +7,11 @@ pub fn list(
     client: &ApiClient,
     agent_id: &str,
     query: Option<String>,
-    date: Option<String>,
     limit: i32,
     offset: i32,
     verbose: bool,
     output_format: OutputFormat,
 ) -> Result<()> {
-    // If date filter is provided, use the date-aware listing
-    if date.is_some() {
-        return list_with_date(client, agent_id, date.as_deref(), verbose, output_format);
-    }
-
     let spinner = if output_format == OutputFormat::Pretty {
         Some(ui::create_spinner("Fetching documents..."))
     } else {
@@ -58,139 +50,6 @@ pub fn list(
     }
 }
 
-/// List documents with date filtering
-fn list_with_date(
-    client: &ApiClient,
-    bank_id: &str,
-    date_filter: Option<&str>,
-    verbose: bool,
-    output_format: OutputFormat,
-) -> Result<()> {
-    let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Fetching all documents..."))
-    } else {
-        None
-    };
-
-    // Fetch all documents with pagination
-    let all_docs = fetch_all_documents(client, bank_id, verbose)?;
-
-    if let Some(mut sp) = spinner {
-        sp.finish();
-    }
-
-    // Parse the date filter
-    let target_date = parse_date_filter(date_filter)?;
-
-    // Filter and group documents by date
-    let mut by_date: BTreeMap<String, Vec<serde_json::Value>> = BTreeMap::new();
-    let mut filtered_count = 0;
-
-    for doc in all_docs {
-        let created_at = doc.get("created_at")
-            .and_then(|v| v.as_str())
-            .unwrap_or("");
-
-        // Parse the date part (YYYY-MM-DD) from created_at
-        let doc_date = created_at.split('T').next().unwrap_or("");
-
-        // Apply date filter if specified
-        if let Some(ref target) = target_date {
-            let target_str = target.format("%Y-%m-%d").to_string();
-            if doc_date != target_str {
-                continue;
-            }
-        }
-
-        filtered_count += 1;
-        by_date.entry(doc_date.to_string()).or_default().push(doc);
-    }
-
-    // Output
-    if output_format == OutputFormat::Pretty {
-        let filter_desc = match date_filter {
-            None | Some("yesterday") => "yesterday".to_string(),
-            Some("today") => "today".to_string(),
-            Some("all") => "all dates".to_string(),
-            Some(d) => d.to_string(),
-        };
-
-        ui::print_info(&format!(
-            "Documents for bank '{}' (filter: {}, showing: {})",
-            bank_id, filter_desc, filtered_count
-        ));
-        println!();
-
-        // Show documents grouped by date (reverse order - newest first)
-        for (date_str, docs) in by_date.iter().rev() {
-            println!("  {} ({} documents)", date_str, docs.len());
-            for doc in docs {
-                let id = doc.get("id").and_then(|v| v.as_str()).unwrap_or("unknown");
-                let mem_count = doc.get("memory_unit_count").and_then(|v| v.as_i64()).unwrap_or(0);
-                println!("    - {} ({} memories)", id, mem_count);
-            }
-            println!();
-        }
-    } else {
-        // JSON/YAML output - convert to a list structure
-        let output: Vec<serde_json::Value> = by_date.values().flatten().cloned().collect();
-        output::print_output(&output, output_format)?;
-    }
-
-    Ok(())
-}
-
-/// Fetch all documents with pagination
-fn fetch_all_documents(
-    client: &ApiClient,
-    bank_id: &str,
-    verbose: bool,
-) -> Result<Vec<serde_json::Value>> {
-    let mut all_docs = Vec::new();
-    let mut offset = 0;
-    let limit = 500;
-
-    loop {
-        let response = client.list_documents(bank_id, None, Some(limit), Some(offset), verbose)?;
-
-        if response.items.is_empty() {
-            break;
-        }
-
-        // Convert Map<String, Value> to Value for each item
-        for item in response.items {
-            all_docs.push(serde_json::Value::Object(item));
-        }
-
-        offset += limit;
-
-        // Check if we've fetched everything
-        if all_docs.len() >= response.total as usize {
-            break;
-        }
-    }
-
-    Ok(all_docs)
-}
-
-/// Parse date filter string into a NaiveDate
-fn parse_date_filter(filter: Option<&str>) -> Result<Option<NaiveDate>> {
-    match filter {
-        None | Some("yesterday") => {
-            // Default to yesterday
-            Ok(Some(Utc::now().date_naive() - ChronoDuration::days(1)))
-        }
-        Some("today") => Ok(Some(Utc::now().date_naive())),
-        Some("all") => Ok(None), // No filtering
-        Some(date_str) => {
-            // Try to parse as YYYY-MM-DD
-            NaiveDate::parse_from_str(date_str, "%Y-%m-%d")
-                .map(Some)
-                .map_err(|e| anyhow::anyhow!("Invalid date format '{}': {}. Use YYYY-MM-DD, 'yesterday', 'today', or 'all'", date_str, e))
-        }
-    }
-}
-
 pub fn get(
     client: &ApiClient,
     agent_id: &str,

hindsight-cli/src/commands/health.rs

@@ -75,45 +75,6 @@ pub fn health(
     }
 }
 
-/// Get API version information
-pub fn version(
-    client: &ApiClient,
-    verbose: bool,
-    output_format: OutputFormat,
-) -> Result<()> {
-    let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Fetching version..."))
-    } else {
-        None
-    };
-
-    let response = client.get_version(verbose);
-
-    if let Some(mut sp) = spinner {
-        sp.finish();
-    }
-
-    match response {
-        Ok(result) => {
-            if output_format == OutputFormat::Pretty {
-                ui::print_section_header("API Version");
-                println!("  {} {}", ui::dim("Version:"), result.api_version);
-
-                println!();
-                println!("  {}", ui::dim("Features:"));
-                println!("    {} MCP Server: {}", ui::gradient_start("•"), if result.features.mcp { "enabled" } else { "disabled" });
-                println!("    {} Observations: {}", ui::gradient_start("•"), if result.features.observations { "enabled" } else { "disabled" });
-                println!("    {} Background Worker: {}", ui::gradient_start("•"), if result.features.worker { "enabled" } else { "disabled" });
-                println!();
-            } else {
-                output::print_output(&result, output_format)?;
-            }
-            Ok(())
-        }
-        Err(e) => Err(e),
-    }
-}
-
 /// Get Prometheus metrics
 pub fn metrics(
     client: &ApiClient,

hindsight-cli/src/commands/mod.rs

@@ -7,5 +7,5 @@ pub mod explore;
 pub mod health;
 pub mod memory;
 pub mod operation;
-pub mod mental_model;
+pub mod reflection;
 pub mod tag;

hindsight-cli/src/commands/reflection.rs

@@ -1,4 +1,4 @@
-//! Mental model commands for managing user-curated summaries.
+//! Reflection commands for managing user-curated summaries.
 
 use anyhow::Result;
 
@@ -8,7 +8,7 @@ use crate::ui;
 
 use hindsight_client::types;
 
-/// List mental models for a bank
+/// List reflections for a bank
 pub fn list(
     client: &ApiClient,
     bank_id: &str,
@@ -16,12 +16,12 @@ pub fn list(
     output_format: OutputFormat,
 ) -> Result<()> {
     let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Fetching mental models..."))
+        Some(ui::create_spinner("Fetching reflections..."))
     } else {
         None
     };
 
-    let response = client.list_mental_models(bank_id, verbose);
+    let response = client.list_reflections(bank_id, verbose);
 
     if let Some(mut sp) = spinner {
         sp.finish();
@@ -30,21 +30,21 @@ pub fn list(
     match response {
         Ok(result) => {
             if output_format == OutputFormat::Pretty {
-                ui::print_section_header(&format!("Mental Models: {}", bank_id));
+                ui::print_section_header(&format!("Reflections: {}", bank_id));
 
                 if result.items.is_empty() {
-                    println!("  {}", ui::dim("No mental models found."));
+                    println!("  {}", ui::dim("No reflections found."));
                 } else {
-                    for mental_model in &result.items {
+                    for reflection in &result.items {
                         println!(
                             "  {} {}",
-                            ui::gradient_start(&mental_model.id),
-                            mental_model.name
+                            ui::gradient_start(&reflection.id),
+                            reflection.name
                         );
 
                         // Show content preview
-                        let preview: String = mental_model.content.chars().take(80).collect();
-                        let ellipsis = if mental_model.content.len() > 80 { "..." } else { "" };
+                        let preview: String = reflection.content.chars().take(80).collect();
+                        let ellipsis = if reflection.content.len() > 80 { "..." } else { "" };
                         println!("    {}{}", ui::dim(&preview), ellipsis);
 
                         println!();
@@ -59,32 +59,32 @@ pub fn list(
     }
 }
 
-/// Get a specific mental model
+/// Get a specific reflection
 pub fn get(
     client: &ApiClient,
     bank_id: &str,
-    mental_model_id: &str,
+    reflection_id: &str,
     verbose: bool,
     output_format: OutputFormat,
 ) -> Result<()> {
     let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Fetching mental model..."))
+        Some(ui::create_spinner("Fetching reflection..."))
     } else {
         None
     };
 
-    let response = client.get_mental_model(bank_id, mental_model_id, verbose);
+    let response = client.get_reflection(bank_id, reflection_id, verbose);
 
     if let Some(mut sp) = spinner {
         sp.finish();
     }
 
     match response {
-        Ok(mental_model) => {
+        Ok(reflection) => {
             if output_format == OutputFormat::Pretty {
-                print_mental_model_detail(&mental_model);
+                print_reflection_detail(&reflection);
             } else {
-                output::print_output(&mental_model, output_format)?;
+                output::print_output(&reflection, output_format)?;
             }
             Ok(())
         }
@@ -92,7 +92,7 @@ pub fn get(
     }
 }
 
-/// Create a new mental model
+/// Create a new reflection
 pub fn create(
     client: &ApiClient,
     bank_id: &str,
@@ -102,20 +102,19 @@ pub fn create(
     output_format: OutputFormat,
 ) -> Result<()> {
     let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Creating mental model..."))
+        Some(ui::create_spinner("Creating reflection..."))
     } else {
         None
     };
 
-    let request = types::CreateMentalModelRequest {
+    let request = types::CreateReflectionRequest {
         name: name.to_string(),
         source_query: source_query.to_string(),
         max_tokens: 2048,
         tags: vec![],
-        trigger: None,
     };
 
-    let response = client.create_mental_model(bank_id, &request, verbose);
+    let response = client.create_reflection(bank_id, &request, verbose);
 
     if let Some(mut sp) = spinner {
         sp.finish();
@@ -124,7 +123,7 @@ pub fn create(
     match response {
         Ok(result) => {
             if output_format == OutputFormat::Pretty {
-                ui::print_success(&format!("Mental model created, operation_id: {}", result.operation_id));
+                ui::print_success(&format!("Reflection created, operation_id: {}", result.operation_id));
             } else {
                 output::print_output(&result, output_format)?;
             }
@@ -134,11 +133,11 @@ pub fn create(
     }
 }
 
-/// Update a mental model
+/// Update a reflection
 pub fn update(
     client: &ApiClient,
     bank_id: &str,
-    mental_model_id: &str,
+    reflection_id: &str,
     name: Option<String>,
     verbose: bool,
     output_format: OutputFormat,
@@ -148,33 +147,27 @@ pub fn update(
     }
 
     let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Updating mental model..."))
+        Some(ui::create_spinner("Updating reflection..."))
     } else {
         None
     };
 
-    let request = types::UpdateMentalModelRequest {
-        name,
-        source_query: None,
-        max_tokens: None,
-        tags: None,
-        trigger: None,
-    };
+    let request = types::UpdateReflectionRequest { name };
 
-    let response = client.update_mental_model(bank_id, mental_model_id, &request, verbose);
+    let response = client.update_reflection(bank_id, reflection_id, &request, verbose);
 
     if let Some(mut sp) = spinner {
         sp.finish();
     }
 
     match response {
-        Ok(mental_model) => {
+        Ok(reflection) => {
             if output_format == OutputFormat::Pretty {
-                ui::print_success(&format!("Mental model '{}' updated successfully", mental_model_id));
+                ui::print_success(&format!("Reflection '{}' updated successfully", reflection_id));
                 println!();
-                print_mental_model_detail(&mental_model);
+                print_reflection_detail(&reflection);
             } else {
-                output::print_output(&mental_model, output_format)?;
+                output::print_output(&reflection, output_format)?;
             }
             Ok(())
         }
@@ -182,11 +175,11 @@ pub fn update(
     }
 }
 
-/// Delete a mental model
+/// Delete a reflection
 pub fn delete(
     client: &ApiClient,
     bank_id: &str,
-    mental_model_id: &str,
+    reflection_id: &str,
     yes: bool,
     verbose: bool,
     output_format: OutputFormat,
@@ -194,8 +187,8 @@ pub fn delete(
     // Confirmation prompt unless -y flag is used
     if !yes && output_format == OutputFormat::Pretty {
         let message = format!(
-            "Are you sure you want to delete mental model '{}'? This cannot be undone.",
-            mental_model_id
+            "Are you sure you want to delete reflection '{}'? This cannot be undone.",
+            reflection_id
         );
 
         let confirmed = ui::prompt_confirmation(&message)?;
@@ -207,12 +200,12 @@ pub fn delete(
     }
 
     let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Deleting mental model..."))
+        Some(ui::create_spinner("Deleting reflection..."))
     } else {
         None
     };
 
-    let response = client.delete_mental_model(bank_id, mental_model_id, verbose);
+    let response = client.delete_reflection(bank_id, reflection_id, verbose);
 
     if let Some(mut sp) = spinner {
         sp.finish();
@@ -221,7 +214,7 @@ pub fn delete(
     match response {
         Ok(_) => {
             if output_format == OutputFormat::Pretty {
-                ui::print_success(&format!("Mental model '{}' deleted successfully", mental_model_id));
+                ui::print_success(&format!("Reflection '{}' deleted successfully", reflection_id));
             } else {
                 println!("{{\"success\": true}}");
             }
@@ -231,21 +224,21 @@ pub fn delete(
     }
 }
 
-/// Refresh a mental model
+/// Refresh a reflection
 pub fn refresh(
     client: &ApiClient,
     bank_id: &str,
-    mental_model_id: &str,
+    reflection_id: &str,
     verbose: bool,
     output_format: OutputFormat,
 ) -> Result<()> {
     let spinner = if output_format == OutputFormat::Pretty {
-        Some(ui::create_spinner("Submitting mental model refresh..."))
+        Some(ui::create_spinner("Submitting reflection refresh..."))
     } else {
         None
     };
 
-    let response = client.refresh_mental_model(bank_id, mental_model_id, verbose);
+    let response = client.refresh_reflection(bank_id, reflection_id, verbose);
 
     if let Some(mut sp) = spinner {
         sp.finish();
@@ -255,7 +248,7 @@ pub fn refresh(
         Ok(operation) => {
             if output_format == OutputFormat::Pretty {
                 ui::print_success(&format!(
-                    "Mental model refresh submitted. Operation ID: {}",
+                    "Reflection refresh submitted. Operation ID: {}",
                     operation.operation_id
                 ));
                 println!("  {} {}", ui::dim("Status:"), operation.status);
@@ -270,16 +263,16 @@ pub fn refresh(
     }
 }
 
-// Helper function to print mental model details
-fn print_mental_model_detail(mental_model: &types::MentalModelResponse) {
-    ui::print_section_header(&mental_model.name);
+// Helper function to print reflection details
+fn print_reflection_detail(reflection: &types::ReflectionResponse) {
+    ui::print_section_header(&reflection.name);
 
-    println!("  {} {}", ui::dim("ID:"), ui::gradient_start(&mental_model.id));
-    println!("  {} {}", ui::dim("Source Query:"), &mental_model.source_query);
+    println!("  {} {}", ui::dim("ID:"), ui::gradient_start(&reflection.id));
+    println!("  {} {}", ui::dim("Source Query:"), &reflection.source_query);
 
     println!();
     println!("{}", ui::gradient_text("─── Content ───"));
     println!();
-    println!("{}", &mental_model.content);
+    println!("{}", &reflection.content);
     println!();
 }

hindsight-cli/src/main.rs

@@ -95,9 +95,9 @@ enum Commands {
     #[command(subcommand)]
     Operation(OperationCommands),
 
-    /// Manage mental models (user-curated summaries)
+    /// Manage reflections (user-curated summaries)
     #[command(subcommand)]
-    MentalModel(MentalModelCommands),
+    Reflection(ReflectionCommands),
 
     /// Manage directives (behavioral rules)
     #[command(subcommand)]
@@ -109,9 +109,6 @@ enum Commands {
     /// Get Prometheus metrics
     Metrics,
 
-    /// Get API version information
-    Version,
-
     /// Interactive TUI explorer (k9s-style) for navigating banks, memories, entities, and performing recall/reflect
     #[command(alias = "tui")]
     Explore,
@@ -255,30 +252,6 @@ enum BankCommands {
         #[arg(short = 'y', long)]
         yes: bool,
     },
-
-    /// Trigger consolidation to create/update observations
-    Consolidate {
-        /// Bank ID
-        bank_id: String,
-
-        /// Wait for consolidation to complete (poll for status)
-        #[arg(long)]
-        wait: bool,
-
-        /// Poll interval in seconds (only used with --wait)
-        #[arg(long, default_value = "10")]
-        poll_interval: u64,
-    },
-
-    /// Clear all observations for a bank
-    ClearObservations {
-        /// Bank ID
-        bank_id: String,
-
-        /// Skip confirmation prompt
-        #[arg(short = 'y', long)]
-        yes: bool,
-    },
 }
 
 #[derive(Subcommand)]
@@ -449,10 +422,6 @@ enum DocumentCommands {
         #[arg(short = 'q', long)]
         query: Option<String>,
 
-        /// Filter by date (yesterday, today, YYYY-MM-DD, or all)
-        #[arg(short = 'd', long)]
-        date: Option<String>,
-
         /// Maximum number of results
         #[arg(short = 'l', long, default_value = "100")]
         limit: i32,
@@ -570,67 +539,67 @@ enum ChunkCommands {
 }
 
 #[derive(Subcommand)]
-enum MentalModelCommands {
-    /// List mental models for a bank
+enum ReflectionCommands {
+    /// List reflections for a bank
     List {
         /// Bank ID
         bank_id: String,
     },
 
-    /// Get a specific mental model
+    /// Get a specific reflection
     Get {
         /// Bank ID
         bank_id: String,
 
-        /// Mental model ID
-        mental_model_id: String,
+        /// Reflection ID
+        reflection_id: String,
     },
 
-    /// Create a new mental model
+    /// Create a new reflection
     Create {
         /// Bank ID
         bank_id: String,
 
-        /// Mental model name
+        /// Reflection name
         name: String,
 
-        /// Source query to generate the mental model from
+        /// Source query to generate the reflection from
         source_query: String,
     },
 
-    /// Update a mental model
+    /// Update a reflection
     Update {
         /// Bank ID
         bank_id: String,
 
-        /// Mental model ID
-        mental_model_id: String,
+        /// Reflection ID
+        reflection_id: String,
 
         /// New name
         #[arg(long)]
         name: Option<String>,
     },
 
-    /// Delete a mental model
+    /// Delete a reflection
     Delete {
         /// Bank ID
         bank_id: String,
 
-        /// Mental model ID
-        mental_model_id: String,
+        /// Reflection ID
+        reflection_id: String,
 
         /// Skip confirmation prompt
         #[arg(short = 'y', long)]
         yes: bool,
     },
 
-    /// Refresh a mental model (re-run the source query)
+    /// Refresh a reflection (re-run the source query)
     Refresh {
         /// Bank ID
         bank_id: String,
 
-        /// Mental model ID
-        mental_model_id: String,
+        /// Reflection ID
+        reflection_id: String,
     },
 }
 
@@ -737,10 +706,9 @@ fn run() -> Result<()> {
         Commands::Ui => unreachable!(), // Handled above
         Commands::Explore => commands::explore::run(&client),
 
-        // Health, Metrics, and Version
+        // Health and Metrics
         Commands::Health => commands::health::health(&client, verbose, output_format),
         Commands::Metrics => commands::health::metrics(&client, verbose, output_format),
-        Commands::Version => commands::health::version(&client, verbose, output_format),
 
         // Bank commands
         Commands::Bank(bank_cmd) => match bank_cmd {
@@ -766,12 +734,6 @@ fn run() -> Result<()> {
             BankCommands::Delete { bank_id, yes } => {
                 commands::bank::delete(&client, &bank_id, yes, verbose, output_format)
             }
-            BankCommands::Consolidate { bank_id, wait, poll_interval } => {
-                commands::bank::consolidate(&client, &bank_id, wait, poll_interval, verbose, output_format)
-            }
-            BankCommands::ClearObservations { bank_id, yes } => {
-                commands::bank::clear_observations(&client, &bank_id, yes, verbose, output_format)
-            }
         },
 
         // Memory commands
@@ -804,8 +766,8 @@ fn run() -> Result<()> {
 
         // Document commands
         Commands::Document(doc_cmd) => match doc_cmd {
-            DocumentCommands::List { bank_id, query, date, limit, offset } => {
-                commands::document::list(&client, &bank_id, query, date, limit, offset, verbose, output_format)
+            DocumentCommands::List { bank_id, query, limit, offset } => {
+                commands::document::list(&client, &bank_id, query, limit, offset, verbose, output_format)
             }
             DocumentCommands::Get { bank_id, document_id } => {
                 commands::document::get(&client, &bank_id, &document_id, verbose, output_format)
@@ -855,25 +817,25 @@ fn run() -> Result<()> {
             }
         },
 
-        // Mental model commands
-        Commands::MentalModel(mm_cmd) => match mm_cmd {
-            MentalModelCommands::List { bank_id } => {
-                commands::mental_model::list(&client, &bank_id, verbose, output_format)
+        // Reflection commands
+        Commands::Reflection(ref_cmd) => match ref_cmd {
+            ReflectionCommands::List { bank_id } => {
+                commands::reflection::list(&client, &bank_id, verbose, output_format)
             }
-            MentalModelCommands::Get { bank_id, mental_model_id } => {
-                commands::mental_model::get(&client, &bank_id, &mental_model_id, verbose, output_format)
+            ReflectionCommands::Get { bank_id, reflection_id } => {
+                commands::reflection::get(&client, &bank_id, &reflection_id, verbose, output_format)
             }
-            MentalModelCommands::Create { bank_id, name, source_query } => {
-                commands::mental_model::create(&client, &bank_id, &name, &source_query, verbose, output_format)
+            ReflectionCommands::Create { bank_id, name, source_query } => {
+                commands::reflection::create(&client, &bank_id, &name, &source_query, verbose, output_format)
             }
-            MentalModelCommands::Update { bank_id, mental_model_id, name } => {
-                commands::mental_model::update(&client, &bank_id, &mental_model_id, name, verbose, output_format)
+            ReflectionCommands::Update { bank_id, reflection_id, name } => {
+                commands::reflection::update(&client, &bank_id, &reflection_id, name, verbose, output_format)
             }
-            MentalModelCommands::Delete { bank_id, mental_model_id, yes } => {
-                commands::mental_model::delete(&client, &bank_id, &mental_model_id, yes, verbose, output_format)
+            ReflectionCommands::Delete { bank_id, reflection_id, yes } => {
+                commands::reflection::delete(&client, &bank_id, &reflection_id, yes, verbose, output_format)
             }
-            MentalModelCommands::Refresh { bank_id, mental_model_id } => {
-                commands::mental_model::refresh(&client, &bank_id, &mental_model_id, verbose, output_format)
+            ReflectionCommands::Refresh { bank_id, reflection_id } => {
+                commands::reflection::refresh(&client, &bank_id, &reflection_id, verbose, output_format)
             }
         },
 

hindsight-cli/tests/cli_integration.rs

@@ -481,409 +481,3 @@ fn test_json_yaml_output_formats() {
             .expect("Expected valid YAML for bank list");
     }
 }
-
-// ============================================================================
-// Directive Tests
-// ============================================================================
-
-#[test]
-fn test_directive_list() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("dir-list");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // List directives
-    let output = run_hindsight(&["directive", "list", &bank_id]);
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    // Should succeed (even if empty)
-    assert!(
-        output.status.success(),
-        "Directive list command failed: {} / {}",
-        stdout,
-        stderr
-    );
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-#[test]
-fn test_directive_create_get_update_delete() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("dir-crud");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // Create a directive
-    let output = run_hindsight(&[
-        "directive", "create",
-        &bank_id,
-        "Test Directive",
-        "Always respond politely",
-    ]);
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    assert!(
-        output.status.success(),
-        "Directive create failed: stdout={}, stderr={}",
-        stdout,
-        stderr
-    );
-
-    // List directives and get the ID
-    let output = run_hindsight(&["directive", "list", &bank_id, "-o", "json"]);
-    let stdout = String::from_utf8_lossy(&output.stdout);
-
-    assert!(
-        output.status.success(),
-        "Directive list failed: {}",
-        stdout
-    );
-
-    // Parse JSON and get directive ID
-    let directive_id: Option<String> = if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
-        result.get("items")
-            .and_then(|v| v.as_array())
-            .and_then(|items| items.first())
-            .and_then(|item| item.get("id"))
-            .and_then(|v| v.as_str())
-            .map(|s| s.to_string())
-    } else {
-        None
-    };
-
-    if let Some(id) = directive_id {
-        // Get the directive
-        let output = run_hindsight(&["directive", "get", &bank_id, &id]);
-        let stdout = String::from_utf8_lossy(&output.stdout);
-        let stderr = String::from_utf8_lossy(&output.stderr);
-
-        assert!(
-            output.status.success(),
-            "Directive get failed: stdout={}, stderr={}",
-            stdout,
-            stderr
-        );
-
-        // Update the directive
-        let output = run_hindsight(&[
-            "directive", "update",
-            &bank_id,
-            &id,
-            "--name", "Updated Directive",
-            "--content", "Always respond very politely",
-        ]);
-        let stdout = String::from_utf8_lossy(&output.stdout);
-        let stderr = String::from_utf8_lossy(&output.stderr);
-
-        assert!(
-            output.status.success(),
-            "Directive update failed: stdout={}, stderr={}",
-            stdout,
-            stderr
-        );
-
-        // Verify update in JSON
-        let output = run_hindsight(&["directive", "get", &bank_id, &id, "-o", "json"]);
-        if output.status.success() {
-            let stdout = String::from_utf8_lossy(&output.stdout);
-            let result: serde_json::Value = serde_json::from_str(&stdout).unwrap();
-            assert_eq!(
-                result.get("name").and_then(|v| v.as_str()),
-                Some("Updated Directive")
-            );
-        }
-
-        // Delete the directive
-        let output = run_hindsight(&["directive", "delete", &bank_id, &id, "-y"]);
-        let stdout = String::from_utf8_lossy(&output.stdout);
-        let stderr = String::from_utf8_lossy(&output.stderr);
-
-        assert!(
-            output.status.success(),
-            "Directive delete failed: stdout={}, stderr={}",
-            stdout,
-            stderr
-        );
-    }
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-// ============================================================================
-// Mental Model Extended Tests
-// ============================================================================
-
-#[test]
-fn test_mental_model_get() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("mm-get");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // Create a mental model
-    let output = run_hindsight(&[
-        "mental-model", "create",
-        &bank_id,
-        "Test Get Model",
-        "What are the key facts?",
-    ]);
-
-    if output.status.success() {
-        // List to get the ID
-        let output = run_hindsight(&["mental-model", "list", &bank_id, "-o", "json"]);
-        let stdout = String::from_utf8_lossy(&output.stdout);
-
-        if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
-            if let Some(id) = result.get("items")
-                .and_then(|v| v.as_array())
-                .and_then(|items| items.iter().find(|item| {
-                    item.get("name").and_then(|v| v.as_str()) == Some("Test Get Model")
-                }))
-                .and_then(|item| item.get("id"))
-                .and_then(|v| v.as_str())
-            {
-                // Get the mental model
-                let output = run_hindsight(&["mental-model", "get", &bank_id, id]);
-                let stdout = String::from_utf8_lossy(&output.stdout);
-                let stderr = String::from_utf8_lossy(&output.stderr);
-
-                assert!(
-                    output.status.success(),
-                    "Mental model get failed: stdout={}, stderr={}",
-                    stdout,
-                    stderr
-                );
-            }
-        }
-    }
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-#[test]
-fn test_mental_model_update() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("mm-update");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // Create a mental model
-    let output = run_hindsight(&[
-        "mental-model", "create",
-        &bank_id,
-        "Test Update Model",
-        "What are the key facts?",
-    ]);
-
-    if output.status.success() {
-        // List to get the ID
-        let output = run_hindsight(&["mental-model", "list", &bank_id, "-o", "json"]);
-        let stdout = String::from_utf8_lossy(&output.stdout);
-
-        if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
-            if let Some(id) = result.get("items")
-                .and_then(|v| v.as_array())
-                .and_then(|items| items.iter().find(|item| {
-                    item.get("name").and_then(|v| v.as_str()) == Some("Test Update Model")
-                }))
-                .and_then(|item| item.get("id"))
-                .and_then(|v| v.as_str())
-            {
-                // Update the mental model
-                let output = run_hindsight(&[
-                    "mental-model", "update",
-                    &bank_id,
-                    id,
-                    "--name", "Updated Model Name",
-                ]);
-                let stdout = String::from_utf8_lossy(&output.stdout);
-                let stderr = String::from_utf8_lossy(&output.stderr);
-
-                assert!(
-                    output.status.success(),
-                    "Mental model update failed: stdout={}, stderr={}",
-                    stdout,
-                    stderr
-                );
-
-                // Verify update
-                let output = run_hindsight(&["mental-model", "get", &bank_id, id, "-o", "json"]);
-                if output.status.success() {
-                    let stdout = String::from_utf8_lossy(&output.stdout);
-                    let result: serde_json::Value = serde_json::from_str(&stdout).unwrap();
-                    assert_eq!(
-                        result.get("name").and_then(|v| v.as_str()),
-                        Some("Updated Model Name")
-                    );
-                }
-            }
-        }
-    }
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-#[test]
-fn test_mental_model_refresh() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("mm-refresh");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // Create a mental model
-    let output = run_hindsight(&[
-        "mental-model", "create",
-        &bank_id,
-        "Test Refresh Model",
-        "What are the key facts?",
-    ]);
-
-    if output.status.success() {
-        // List to get the ID
-        let output = run_hindsight(&["mental-model", "list", &bank_id, "-o", "json"]);
-        let stdout = String::from_utf8_lossy(&output.stdout);
-
-        if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
-            if let Some(id) = result.get("items")
-                .and_then(|v| v.as_array())
-                .and_then(|items| items.iter().find(|item| {
-                    item.get("name").and_then(|v| v.as_str()) == Some("Test Refresh Model")
-                }))
-                .and_then(|item| item.get("id"))
-                .and_then(|v| v.as_str())
-            {
-                // Refresh the mental model
-                let output = run_hindsight(&["mental-model", "refresh", &bank_id, id]);
-                let stdout = String::from_utf8_lossy(&output.stdout);
-                let stderr = String::from_utf8_lossy(&output.stderr);
-
-                assert!(
-                    output.status.success(),
-                    "Mental model refresh failed: stdout={}, stderr={}",
-                    stdout,
-                    stderr
-                );
-            }
-        }
-    }
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-// ============================================================================
-// Bank Consolidation Tests
-// ============================================================================
-
-#[test]
-fn test_bank_consolidate() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("bank-consolidate");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // Trigger consolidation
-    let output = run_hindsight(&["bank", "consolidate", &bank_id]);
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    // Should succeed
-    assert!(
-        output.status.success(),
-        "Bank consolidate command failed: {} / {}",
-        stdout,
-        stderr
-    );
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-#[test]
-fn test_bank_clear_observations() {
-    skip_if_no_server!();
-
-    let bank_id = test_bank_id("bank-clear-obs");
-
-    // Create the bank first
-    let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
-
-    // Clear observations
-    let output = run_hindsight(&["bank", "clear-observations", &bank_id, "-y"]);
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    // Should succeed
-    assert!(
-        output.status.success(),
-        "Bank clear-observations command failed: {} / {}",
-        stdout,
-        stderr
-    );
-
-    // Clean up
-    let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
-}
-
-// ============================================================================
-// Version Test
-// ============================================================================
-
-#[test]
-fn test_version() {
-    skip_if_no_server!();
-
-    let output = run_hindsight(&["version"]);
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    // Should succeed
-    assert!(
-        output.status.success(),
-        "Version command failed: {} / {}",
-        stdout,
-        stderr
-    );
-}
-
-#[test]
-fn test_version_json() {
-    skip_if_no_server!();
-
-    let output = run_hindsight(&["version", "-o", "json"]);
-
-    if output.status.success() {
-        let stdout = String::from_utf8_lossy(&output.stdout);
-        let result: serde_json::Value = serde_json::from_str(&stdout)
-            .expect(&format!("Expected valid JSON output, got: {}", stdout));
-
-        // Should have api_version and features
-        assert!(result.get("api_version").is_some(), "Expected api_version field");
-        assert!(result.get("features").is_some(), "Expected features field");
-    }
-}

hindsight-cli/tests/integration_test.rs

@@ -1,125 +0,0 @@
-use std::process::Command;
-
-#[test]
-fn test_cli_help() {
-    let output = Command::new("cargo")
-        .args(["run", "--", "--help"])
-        .output()
-        .expect("Failed to execute command");
-
-    assert!(output.status.success());
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    assert!(stdout.contains("Hindsight CLI"));
-}
-
-#[test]
-fn test_cli_version() {
-    let output = Command::new("cargo")
-        .args(["run", "--", "--version"])
-        .output()
-        .expect("Failed to execute command");
-
-    assert!(output.status.success());
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    assert!(stdout.contains("hindsight"));
-}
-
-#[test]
-fn test_ui_command_without_config() {
-    // Test that the ui command handles missing config gracefully
-    // Create a temp home directory with no config
-    let temp_dir = std::env::temp_dir().join(format!("hindsight-test-ui-{}", std::process::id()));
-    std::fs::create_dir_all(&temp_dir).expect("Failed to create temp dir");
-
-    let output = Command::new("cargo")
-        .args(["run", "--", "ui"])
-        .env_remove("HINDSIGHT_API_URL")
-        .env_remove("HINDSIGHT_API_KEY")
-        .env("HOME", &temp_dir)
-        .output()
-        .expect("Failed to execute command");
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    // Either it fails with a config error or it succeeds if there's a default config
-    // Just verify it doesn't crash unexpectedly
-    assert!(
-        !output.status.success()
-        || stdout.contains("Launching Hindsight Control Plane UI")
-        || stderr.contains("Configuration error")
-        || stderr.contains("HINDSIGHT_API_URL"),
-        "Unexpected output - stdout: {}, stderr: {}",
-        stdout,
-        stderr
-    );
-
-    // Cleanup
-    std::fs::remove_dir_all(&temp_dir).ok();
-}
-
-#[test]
-fn test_ui_command_with_config() {
-    // This test is skipped by default since it requires a running control plane
-    // and would block for a long time. The other tests cover the basic functionality.
-    // To run this test manually:
-    // 1. Build the control plane: cd hindsight-control-plane && npm run build
-    // 2. Run: cargo test test_ui_command_with_config -- --ignored
-
-    // Just verify that the ui command accepts the configuration
-    let temp_dir = std::env::temp_dir().join(format!("hindsight-test-ui-valid-{}", std::process::id()));
-    std::fs::create_dir_all(&temp_dir).expect("Failed to create temp dir");
-
-    // Write a minimal config
-    let config_dir = temp_dir.join(".config").join("hindsight");
-    std::fs::create_dir_all(&config_dir).expect("Failed to create config dir");
-    let config_file = config_dir.join("config");
-    std::fs::write(&config_file, "api_url=http://localhost:8888\napi_key=test-key\n")
-        .expect("Failed to write config");
-
-    let output = Command::new("cargo")
-        .args(["run", "--", "ui", "--help"])
-        .env("HOME", &temp_dir)
-        .output()
-        .expect("Failed to execute command");
-
-    // The --help should work regardless
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    assert!(stdout.contains("Hindsight CLI") || output.status.success());
-
-    // Cleanup
-    std::fs::remove_dir_all(&temp_dir).ok();
-}
-
-#[test]
-fn test_configure_command() {
-    // Test that configure command creates/updates config
-    let temp_dir = std::env::temp_dir().join(format!("hindsight-test-{}", std::process::id()));
-    std::fs::create_dir_all(&temp_dir).expect("Failed to create temp dir");
-
-    let output = Command::new("cargo")
-        .args([
-            "run",
-            "--",
-            "configure",
-            "--api-url",
-            "http://localhost:9999",
-            "--api-key",
-            "test-key-123"
-        ])
-        .env("HOME", &temp_dir)
-        .output()
-        .expect("Failed to execute command");
-
-    assert!(
-        output.status.success(),
-        "Configure command failed: {}",
-        String::from_utf8_lossy(&output.stderr)
-    );
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    assert!(stdout.contains("Configuration saved") || stdout.contains("success"));
-
-    // Cleanup
-    std::fs::remove_dir_all(&temp_dir).ok();
-}

hindsight-clients/python/.openapi-generator/FILES

@@ -5,9 +5,9 @@ hindsight_client_api/api/directives_api.py
 hindsight_client_api/api/documents_api.py
 hindsight_client_api/api/entities_api.py
 hindsight_client_api/api/memory_api.py
-hindsight_client_api/api/mental_models_api.py
 hindsight_client_api/api/monitoring_api.py
 hindsight_client_api/api/operations_api.py
+hindsight_client_api/api/reflections_api.py
 hindsight_client_api/api_client.py
 hindsight_client_api/api_response.py
 hindsight_client_api/configuration.py
@@ -28,8 +28,8 @@ hindsight_client_api/models/chunk_response.py
 hindsight_client_api/models/consolidation_response.py
 hindsight_client_api/models/create_bank_request.py
 hindsight_client_api/models/create_directive_request.py
-hindsight_client_api/models/create_mental_model_request.py
-hindsight_client_api/models/create_mental_model_response.py
+hindsight_client_api/models/create_reflection_request.py
+hindsight_client_api/models/create_reflection_response.py
 hindsight_client_api/models/delete_document_response.py
 hindsight_client_api/models/delete_response.py
 hindsight_client_api/models/directive_list_response.py
@@ -51,9 +51,6 @@ hindsight_client_api/models/list_documents_response.py
 hindsight_client_api/models/list_memory_units_response.py
 hindsight_client_api/models/list_tags_response.py
 hindsight_client_api/models/memory_item.py
-hindsight_client_api/models/mental_model_list_response.py
-hindsight_client_api/models/mental_model_response.py
-hindsight_client_api/models/mental_model_trigger.py
 hindsight_client_api/models/operation_response.py
 hindsight_client_api/models/operation_status_response.py
 hindsight_client_api/models/operations_list_response.py
@@ -61,7 +58,6 @@ hindsight_client_api/models/recall_request.py
 hindsight_client_api/models/recall_response.py
 hindsight_client_api/models/recall_result.py
 hindsight_client_api/models/reflect_based_on.py
-hindsight_client_api/models/reflect_directive.py
 hindsight_client_api/models/reflect_fact.py
 hindsight_client_api/models/reflect_include_options.py
 hindsight_client_api/models/reflect_llm_call.py
@@ -70,6 +66,8 @@ hindsight_client_api/models/reflect_request.py
 hindsight_client_api/models/reflect_response.py
 hindsight_client_api/models/reflect_tool_call.py
 hindsight_client_api/models/reflect_trace.py
+hindsight_client_api/models/reflection_list_response.py
+hindsight_client_api/models/reflection_response.py
 hindsight_client_api/models/retain_request.py
 hindsight_client_api/models/retain_response.py
 hindsight_client_api/models/tag_item.py
@@ -77,7 +75,7 @@ hindsight_client_api/models/token_usage.py
 hindsight_client_api/models/tool_calls_include_options.py
 hindsight_client_api/models/update_directive_request.py
 hindsight_client_api/models/update_disposition_request.py
-hindsight_client_api/models/update_mental_model_request.py
+hindsight_client_api/models/update_reflection_request.py
 hindsight_client_api/models/validation_error.py
 hindsight_client_api/models/validation_error_loc_inner.py
 hindsight_client_api/models/version_response.py

hindsight-clients/python/hindsight_client/hindsight_client.py

@@ -10,7 +10,7 @@ from datetime import datetime
 from typing import Any, Literal
 
 import hindsight_client_api
-from hindsight_client_api.api import banks_api, directives_api, memory_api, mental_models_api
+from hindsight_client_api.api import banks_api, memory_api
 from hindsight_client_api.models import (
     memory_item,
     recall_request,
@@ -78,8 +78,6 @@ class Hindsight:
             self._api_client.set_default_header("Authorization", f"Bearer {api_key}")
         self._memory_api = memory_api.MemoryApi(self._api_client)
         self._banks_api = banks_api.BanksApi(self._api_client)
-        self._mental_models_api = mental_models_api.MentalModelsApi(self._api_client)
-        self._directives_api = directives_api.DirectivesApi(self._api_client)
 
     def __enter__(self):
         """Context manager entry."""
@@ -536,253 +534,3 @@ class Hindsight:
         )
 
         return await self._memory_api.reflect(bank_id, request_obj)
-
-    # Mental Models methods
-
-    def create_mental_model(
-        self,
-        bank_id: str,
-        name: str,
-        source_query: str,
-        tags: list[str] | None = None,
-        max_tokens: int | None = None,
-        trigger: dict[str, Any] | None = None,
-    ):
-        """
-        Create a mental model (runs reflect in background).
-
-        Args:
-            bank_id: The memory bank ID
-            name: Human-readable name for the mental model
-            source_query: The query to run to generate content
-            tags: Optional tags for filtering during retrieval
-            max_tokens: Optional maximum tokens for the mental model content
-            trigger: Optional trigger settings (e.g., {"refresh_after_consolidation": True})
-
-        Returns:
-            CreateMentalModelResponse with operation_id
-        """
-        from hindsight_client_api.models import create_mental_model_request, mental_model_trigger
-
-        trigger_obj = None
-        if trigger:
-            trigger_obj = mental_model_trigger.MentalModelTrigger(**trigger)
-
-        request_obj = create_mental_model_request.CreateMentalModelRequest(
-            name=name,
-            source_query=source_query,
-            tags=tags,
-            max_tokens=max_tokens,
-            trigger=trigger_obj,
-        )
-
-        return _run_async(self._mental_models_api.create_mental_model(bank_id, request_obj))
-
-    def list_mental_models(self, bank_id: str, tags: list[str] | None = None):
-        """
-        List all mental models in a bank.
-
-        Args:
-            bank_id: The memory bank ID
-            tags: Optional tags to filter by
-
-        Returns:
-            ListMentalModelsResponse with items
-        """
-        return _run_async(self._mental_models_api.list_mental_models(bank_id, tags=tags))
-
-    def get_mental_model(self, bank_id: str, mental_model_id: str):
-        """
-        Get a specific mental model.
-
-        Args:
-            bank_id: The memory bank ID
-            mental_model_id: The mental model ID
-
-        Returns:
-            MentalModelResponse
-        """
-        return _run_async(self._mental_models_api.get_mental_model(bank_id, mental_model_id))
-
-    def refresh_mental_model(self, bank_id: str, mental_model_id: str):
-        """
-        Refresh a mental model to update with current knowledge.
-
-        Args:
-            bank_id: The memory bank ID
-            mental_model_id: The mental model ID
-
-        Returns:
-            RefreshMentalModelResponse with operation_id
-        """
-        return _run_async(self._mental_models_api.refresh_mental_model(bank_id, mental_model_id))
-
-    def update_mental_model(
-        self,
-        bank_id: str,
-        mental_model_id: str,
-        name: str | None = None,
-        source_query: str | None = None,
-        tags: list[str] | None = None,
-        max_tokens: int | None = None,
-        trigger: dict[str, Any] | None = None,
-    ):
-        """
-        Update a mental model's metadata.
-
-        Args:
-            bank_id: The memory bank ID
-            mental_model_id: The mental model ID
-            name: Optional new name
-            source_query: Optional new source query
-            tags: Optional new tags
-            max_tokens: Optional new max tokens
-            trigger: Optional trigger settings (e.g., {"refresh_after_consolidation": True})
-
-        Returns:
-            MentalModelResponse
-        """
-        from hindsight_client_api.models import mental_model_trigger, update_mental_model_request
-
-        trigger_obj = None
-        if trigger:
-            trigger_obj = mental_model_trigger.MentalModelTrigger(**trigger)
-
-        request_obj = update_mental_model_request.UpdateMentalModelRequest(
-            name=name,
-            source_query=source_query,
-            tags=tags,
-            max_tokens=max_tokens,
-            trigger=trigger_obj,
-        )
-
-        return _run_async(self._mental_models_api.update_mental_model(bank_id, mental_model_id, request_obj))
-
-    def delete_mental_model(self, bank_id: str, mental_model_id: str):
-        """
-        Delete a mental model.
-
-        Args:
-            bank_id: The memory bank ID
-            mental_model_id: The mental model ID
-        """
-        return _run_async(self._mental_models_api.delete_mental_model(bank_id, mental_model_id))
-
-    # Directives methods
-
-    def create_directive(
-        self,
-        bank_id: str,
-        name: str,
-        content: str,
-        priority: int = 0,
-        is_active: bool = True,
-        tags: list[str] | None = None,
-    ):
-        """
-        Create a directive (hard rule for reflect).
-
-        Args:
-            bank_id: The memory bank ID
-            name: Human-readable name for the directive
-            content: The directive content/rules
-            priority: Priority level (higher = injected first)
-            is_active: Whether the directive is active
-            tags: Optional tags for filtering
-
-        Returns:
-            DirectiveResponse
-        """
-        from hindsight_client_api.models import create_directive_request
-
-        request_obj = create_directive_request.CreateDirectiveRequest(
-            name=name,
-            content=content,
-            priority=priority,
-            is_active=is_active,
-            tags=tags,
-        )
-
-        return _run_async(self._directives_api.create_directive(bank_id, request_obj))
-
-    def list_directives(self, bank_id: str, tags: list[str] | None = None):
-        """
-        List all directives in a bank.
-
-        Args:
-            bank_id: The memory bank ID
-            tags: Optional tags to filter by
-
-        Returns:
-            ListDirectivesResponse with items
-        """
-        return _run_async(self._directives_api.list_directives(bank_id, tags=tags))
-
-    def get_directive(self, bank_id: str, directive_id: str):
-        """
-        Get a specific directive.
-
-        Args:
-            bank_id: The memory bank ID
-            directive_id: The directive ID
-
-        Returns:
-            DirectiveResponse
-        """
-        return _run_async(self._directives_api.get_directive(bank_id, directive_id))
-
-    def update_directive(
-        self,
-        bank_id: str,
-        directive_id: str,
-        name: str | None = None,
-        content: str | None = None,
-        priority: int | None = None,
-        is_active: bool | None = None,
-        tags: list[str] | None = None,
-    ):
-        """
-        Update a directive.
-
-        Args:
-            bank_id: The memory bank ID
-            directive_id: The directive ID
-            name: Optional new name
-            content: Optional new content
-            priority: Optional new priority
-            is_active: Optional new active status
-            tags: Optional new tags
-
-        Returns:
-            DirectiveResponse
-        """
-        from hindsight_client_api.models import update_directive_request
-
-        request_obj = update_directive_request.UpdateDirectiveRequest(
-            name=name,
-            content=content,
-            priority=priority,
-            is_active=is_active,
-            tags=tags,
-        )
-
-        return _run_async(self._directives_api.update_directive(bank_id, directive_id, request_obj))
-
-    def delete_directive(self, bank_id: str, directive_id: str):
-        """
-        Delete a directive.
-
-        Args:
-            bank_id: The memory bank ID
-            directive_id: The directive ID
-        """
-        return _run_async(self._directives_api.delete_directive(bank_id, directive_id))
-
-    def delete_bank(self, bank_id: str):
-        """
-        Delete a memory bank.
-
-        Args:
-            bank_id: The memory bank ID
-        """
-        return _run_async(self._banks_api.delete_bank(bank_id))

hindsight-clients/python/hindsight_client_api/__init__.py

@@ -7,7 +7,7 @@
 
     HTTP API for Hindsight
 
-    The version of the OpenAPI document: 0.4.8
+    The version of the OpenAPI document: 0.1.0
     Generated by OpenAPI Generator (https://openapi-generator.tech)
 
     Do not edit the class manually.
@@ -22,9 +22,9 @@ from hindsight_client_api.api.directives_api import DirectivesApi
 from hindsight_client_api.api.documents_api import DocumentsApi
 from hindsight_client_api.api.entities_api import EntitiesApi
 from hindsight_client_api.api.memory_api import MemoryApi
-from hindsight_client_api.api.mental_models_api import MentalModelsApi
 from hindsight_client_api.api.monitoring_api import MonitoringApi
 from hindsight_client_api.api.operations_api import OperationsApi
+from hindsight_client_api.api.reflections_api import ReflectionsApi
 
 # import ApiClient
 from hindsight_client_api.api_response import ApiResponse
@@ -53,8 +53,8 @@ from hindsight_client_api.models.chunk_response import ChunkResponse
 from hindsight_client_api.models.consolidation_response import ConsolidationResponse
 from hindsight_client_api.models.create_bank_request import CreateBankRequest
 from hindsight_client_api.models.create_directive_request import CreateDirectiveRequest
-from hindsight_client_api.models.create_mental_model_request import CreateMentalModelRequest
-from hindsight_client_api.models.create_mental_model_response import CreateMentalModelResponse
+from hindsight_client_api.models.create_reflection_request import CreateReflectionRequest
+from hindsight_client_api.models.create_reflection_response import CreateReflectionResponse
 from hindsight_client_api.models.delete_document_response import DeleteDocumentResponse
 from hindsight_client_api.models.delete_response import DeleteResponse
 from hindsight_client_api.models.directive_list_response import DirectiveListResponse
@@ -76,9 +76,6 @@ from hindsight_client_api.models.list_documents_response import ListDocumentsRes
 from hindsight_client_api.models.list_memory_units_response import ListMemoryUnitsResponse
 from hindsight_client_api.models.list_tags_response import ListTagsResponse
 from hindsight_client_api.models.memory_item import MemoryItem
-from hindsight_client_api.models.mental_model_list_response import MentalModelListResponse
-from hindsight_client_api.models.mental_model_response import MentalModelResponse
-from hindsight_client_api.models.mental_model_trigger import MentalModelTrigger
 from hindsight_client_api.models.operation_response import OperationResponse
 from hindsight_client_api.models.operation_status_response import OperationStatusResponse
 from hindsight_client_api.models.operations_list_response import OperationsListResponse
@@ -86,7 +83,6 @@ from hindsight_client_api.models.recall_request import RecallRequest
 from hindsight_client_api.models.recall_response import RecallResponse
 from hindsight_client_api.models.recall_result import RecallResult
 from hindsight_client_api.models.reflect_based_on import ReflectBasedOn
-from hindsight_client_api.models.reflect_directive import ReflectDirective
 from hindsight_client_api.models.reflect_fact import ReflectFact
 from hindsight_client_api.models.reflect_include_options import ReflectIncludeOptions
 from hindsight_client_api.models.reflect_llm_call import ReflectLLMCall
@@ -95,6 +91,8 @@ from hindsight_client_api.models.reflect_request import ReflectRequest
 from hindsight_client_api.models.reflect_response import ReflectResponse
 from hindsight_client_api.models.reflect_tool_call import ReflectToolCall
 from hindsight_client_api.models.reflect_trace import ReflectTrace
+from hindsight_client_api.models.reflection_list_response import ReflectionListResponse
+from hindsight_client_api.models.reflection_response import ReflectionResponse
 from hindsight_client_api.models.retain_request import RetainRequest
 from hindsight_client_api.models.retain_response import RetainResponse
 from hindsight_client_api.models.tag_item import TagItem
@@ -102,7 +100,7 @@ from hindsight_client_api.models.token_usage import TokenUsage
 from hindsight_client_api.models.tool_calls_include_options import ToolCallsIncludeOptions
 from hindsight_client_api.models.update_directive_request import UpdateDirectiveRequest
 from hindsight_client_api.models.update_disposition_request import UpdateDispositionRequest
-from hindsight_client_api.models.update_mental_model_request import UpdateMentalModelRequest
+from hindsight_client_api.models.update_reflection_request import UpdateReflectionRequest
 from hindsight_client_api.models.validation_error import ValidationError
 from hindsight_client_api.models.validation_error_loc_inner import ValidationErrorLocInner
 from hindsight_client_api.models.version_response import VersionResponse

hindsight-clients/python/hindsight_client_api/api/__init__.py

@@ -6,7 +6,7 @@ from hindsight_client_api.api.directives_api import DirectivesApi
 from hindsight_client_api.api.documents_api import DocumentsApi
 from hindsight_client_api.api.entities_api import EntitiesApi
 from hindsight_client_api.api.memory_api import MemoryApi
-from hindsight_client_api.api.mental_models_api import MentalModelsApi
 from hindsight_client_api.api.monitoring_api import MonitoringApi
 from hindsight_client_api.api.operations_api import OperationsApi
+from hindsight_client_api.api.reflections_api import ReflectionsApi
 

hindsight-clients/python/hindsight_client_api/api/banks_api.py

@@ -5,7 +5,7 @@
 
     HTTP API for Hindsight
 
-    The version of the OpenAPI document: 0.4.8
+    The version of the OpenAPI document: 0.1.0
     Generated by OpenAPI Generator (https://openapi-generator.tech)
 
     Do not edit the class manually.
@@ -356,7 +356,7 @@ class BanksApi:
 
 
     @validate_call
-    async def clear_observations(
+    async def clear_mental_models(
         self,
         bank_id: StrictStr,
         authorization: Optional[StrictStr] = None,
@@ -373,9 +373,9 @@ class BanksApi:
         _headers: Optional[Dict[StrictStr, Any]] = None,
         _host_index: Annotated[StrictInt, Field(ge=0, le=0)] = 0,
     ) -> DeleteResponse:
-        """Clear all observations
+        """Clear all mental models
 
-        Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
+        Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
 
         :param bank_id: (required)
         :type bank_id: str
@@ -403,7 +403,7 @@ class BanksApi:
         :return: Returns the result object.
         """ # noqa: E501
 
-        _param = self._clear_observations_serialize(
+        _param = self._clear_mental_models_serialize(
             bank_id=bank_id,
             authorization=authorization,
             _request_auth=_request_auth,
@@ -428,7 +428,7 @@ class BanksApi:
 
 
     @validate_call
-    async def clear_observations_with_http_info(
+    async def clear_mental_models_with_http_info(
         self,
         bank_id: StrictStr,
         authorization: Optional[StrictStr] = None,
@@ -445,9 +445,9 @@ class BanksApi:
         _headers: Optional[Dict[StrictStr, Any]] = None,
         _host_index: Annotated[StrictInt, Field(ge=0, le=0)] = 0,
     ) -> ApiResponse[DeleteResponse]:
-        """Clear all observations
+        """Clear all mental models
 
-        Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
+        Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
 
         :param bank_id: (required)
         :type bank_id: str
@@ -475,7 +475,7 @@ class BanksApi:
         :return: Returns the result object.
         """ # noqa: E501
 
-        _param = self._clear_observations_serialize(
+        _param = self._clear_mental_models_serialize(
             bank_id=bank_id,
             authorization=authorization,
             _request_auth=_request_auth,
@@ -500,7 +500,7 @@ class BanksApi:
 
 
     @validate_call
-    async def clear_observations_without_preload_content(
+    async def clear_mental_models_without_preload_content(
         self,
         bank_id: StrictStr,
         authorization: Optional[StrictStr] = None,
@@ -517,9 +517,9 @@ class BanksApi:
         _headers: Optional[Dict[StrictStr, Any]] = None,
         _host_index: Annotated[StrictInt, Field(ge=0, le=0)] = 0,
     ) -> RESTResponseType:
-        """Clear all observations
+        """Clear all mental models
 
-        Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
+        Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
 
         :param bank_id: (required)
         :type bank_id: str
@@ -547,7 +547,7 @@ class BanksApi:
         :return: Returns the result object.
         """ # noqa: E501
 
-        _param = self._clear_observations_serialize(
+        _param = self._clear_mental_models_serialize(
             bank_id=bank_id,
             authorization=authorization,
             _request_auth=_request_auth,
@@ -567,7 +567,7 @@ class BanksApi:
         return response_data.response
 
 
-    def _clear_observations_serialize(
+    def _clear_mental_models_serialize(
         self,
         bank_id,
         authorization,
@@ -617,7 +617,7 @@ class BanksApi:
 
         return self.api_client.param_serialize(
             method='DELETE',
-            resource_path='/v1/default/banks/{bank_id}/observations',
+            resource_path='/v1/default/banks/{bank_id}/mental-models',
             path_params=_path_params,
             query_params=_query_params,
             header_params=_header_params,
@@ -2056,7 +2056,7 @@ class BanksApi:
     ) -> ConsolidationResponse:
         """Trigger consolidation
 
-        Run memory consolidation to create/update observations from recent memories.
+        Run memory consolidation to create/update mental models from recent memories.
 
         :param bank_id: (required)
         :type bank_id: str
@@ -2128,7 +2128,7 @@ class BanksApi:
     ) -> ApiResponse[ConsolidationResponse]:
         """Trigger consolidation
 
-        Run memory consolidation to create/update observations from recent memories.
+        Run memory consolidation to create/update mental models from recent memories.
 
         :param bank_id: (required)
         :type bank_id: str
@@ -2200,7 +2200,7 @@ class BanksApi:
     ) -> RESTResponseType:
         """Trigger consolidation
 
-        Run memory consolidation to create/update observations from recent memories.
+        Run memory consolidation to create/update mental models from recent memories.
 
         :param bank_id: (required)
         :type bank_id: str

hindsight-clients/python/hindsight_client_api/api/directives_api.py

@@ -5,7 +5,7 @@
 
     HTTP API for Hindsight
 
-    The version of the OpenAPI document: 0.4.8
+    The version of the OpenAPI document: 0.1.0
     Generated by OpenAPI Generator (https://openapi-generator.tech)
 
     Do not edit the class manually.

hindsight-clients/python/hindsight_client_api/api/documents_api.py

@@ -5,7 +5,7 @@
 
     HTTP API for Hindsight
 
-    The version of the OpenAPI document: 0.4.8
+    The version of the OpenAPI document: 0.1.0
     Generated by OpenAPI Generator (https://openapi-generator.tech)
 
     Do not edit the class manually.

hindsight-clients/python/hindsight_client_api/api/entities_api.py

@@ -5,7 +5,7 @@
 
     HTTP API for Hindsight
 
-    The version of the OpenAPI document: 0.4.8
+    The version of the OpenAPI document: 0.1.0
     Generated by OpenAPI Generator (https://openapi-generator.tech)
 
     Do not edit the class manually.