Compare commits

..
2 Commits
Author SHA1 Message Date
Nicolò Boschi ab968feae1 doc: mental models 2026-01-26 14:11:27 +01:00
Nicolò Boschi a4be464e6f doc: mental models 2026-01-26 12:08:54 +01:00
152 changed files with 10688 additions and 10921 deletions
-60
View File
@@ -875,66 +875,6 @@ jobs:
echo "=== API Server Logs ==="
cat /tmp/api-server.log || echo "No API server log found"
test-upgrade:
runs-on: ubuntu-latest
env:
HINDSIGHT_API_LLM_PROVIDER: groq
HINDSIGHT_API_LLM_API_KEY: ${{ secrets.GROQ_API_KEY }}
HINDSIGHT_API_LLM_MODEL: openai/gpt-oss-20b
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
UV_INDEX: pytorch=https://download.pytorch.org/whl/cpu
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # Full history needed for git clone of tags
- name: Fetch tags
run: git fetch --tags
- name: Install uv
uses: astral-sh/setup-uv@v5
with:
enable-cache: true
prune-cache: false
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version-file: ".python-version"
- name: Cache HuggingFace models
uses: actions/cache@v4
with:
path: ~/.cache/huggingface
key: ${{ runner.os }}-huggingface-${{ hashFiles('hindsight-api/pyproject.toml') }}
restore-keys: |
${{ runner.os }}-huggingface-
- name: Install hindsight-dev dependencies
working-directory: ./hindsight-dev
run: uv sync --frozen --extra test --index-strategy unsafe-best-match
- name: Install current hindsight-api
working-directory: ./hindsight-api
run: uv sync --frozen --index-strategy unsafe-best-match
- name: Pre-download models
working-directory: ./hindsight-api
run: |
uv run python -c "
from sentence_transformers import SentenceTransformer, CrossEncoder
print('Downloading embedding model...')
SentenceTransformer('BAAI/bge-small-en-v1.5')
print('Downloading cross-encoder model...')
CrossEncoder('cross-encoder/ms-marco-MiniLM-L-6-v2')
print('Models downloaded successfully')
"
- name: Run upgrade tests
working-directory: ./hindsight-dev
run: uv run pytest upgrade_tests/ -v --tb=short
verify-generated-files:
runs-on: ubuntu-latest
env:
+1 -1
View File
@@ -100,7 +100,7 @@ cd hindsight-control-plane && npm run dev
Main operations:
- **Retain**: Store memories, extracts facts/entities/relationships
- **Recall**: Retrieve memories via 4 parallel strategies (semantic, BM25, graph, temporal) + reranking
- **Reflect**: Disposition-aware reasoning using memories and mental models.
- **Reflect**: Disposition-aware reasoning using memories and mental models
### Database
PostgreSQL with pgvector. Schema managed via Alembic migrations in `hindsight-api/hindsight_api/alembic/`. Migrations run automatically on API startup.
@@ -1,134 +0,0 @@
"""Rename mental_model fact_type to observation and reflections table to mental_models
Revision ID: t5o6p7q8r9s0
Revises: s4n5o6p7q8r9
Create Date: 2026-01-26
This migration implements the terminology rename:
1. mental_model (fact_type in memory_units) -> observation
2. reflections table -> mental_models table
The new terminology:
- Observations: Consolidated knowledge synthesized from facts (was mental_model)
- Mental Models: Stored reflect responses (was reflections)
"""
from collections.abc import Sequence
from alembic import context, op
revision: str = "t5o6p7q8r9s0"
down_revision: str | Sequence[str] | None = "s4n5o6p7q8r9"
branch_labels: str | Sequence[str] | None = None
depends_on: str | Sequence[str] | None = None
def _get_schema_prefix() -> str:
"""Get schema prefix for table names (required for multi-tenant support)."""
schema = context.config.get_main_option("target_schema")
return f'"{schema}".' if schema else ""
def upgrade() -> None:
"""Rename mental_model -> observation and reflections -> mental_models."""
schema = _get_schema_prefix()
# 1. Update fact_type values: mental_model -> observation
op.execute(f"""
UPDATE {schema}memory_units
SET fact_type = 'observation'
WHERE fact_type = 'mental_model'
""")
# 2. Update the CHECK constraint - remove mental_model, keep observation
op.execute(f"ALTER TABLE {schema}memory_units DROP CONSTRAINT IF EXISTS memory_units_fact_type_check")
op.execute(f"""
ALTER TABLE {schema}memory_units
ADD CONSTRAINT memory_units_fact_type_check
CHECK (fact_type IN ('world', 'experience', 'opinion', 'observation'))
""")
# 3. Rename the index for observations (was for mental_models)
op.execute(f"DROP INDEX IF EXISTS {schema}idx_memory_units_mental_models")
op.execute(f"""
CREATE INDEX IF NOT EXISTS idx_memory_units_observations
ON {schema}memory_units(bank_id, fact_type)
WHERE fact_type = 'observation'
""")
# 4. Update the unconsolidated index to not filter by fact_type since observations
# are now the consolidated type
op.execute(f"DROP INDEX IF EXISTS {schema}idx_memory_units_unconsolidated")
op.execute(f"""
CREATE INDEX IF NOT EXISTS idx_memory_units_unconsolidated
ON {schema}memory_units (bank_id, created_at)
WHERE consolidated_at IS NULL AND fact_type IN ('experience', 'world')
""")
# 5. Rename reflections table to mental_models
op.execute(f"ALTER TABLE IF EXISTS {schema}reflections RENAME TO mental_models")
# 6. Rename indexes for mental_models (was reflections)
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_bank_id RENAME TO idx_mental_models_bank_id")
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_embedding RENAME TO idx_mental_models_embedding")
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_tags RENAME TO idx_mental_models_tags")
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_reflections_text_search RENAME TO idx_mental_models_text_search")
# 7. Rename foreign key constraint
op.execute(f"""
ALTER TABLE {schema}mental_models
DROP CONSTRAINT IF EXISTS fk_reflections_bank_id
""")
op.execute(f"""
ALTER TABLE {schema}mental_models
ADD CONSTRAINT fk_mental_models_bank_id
FOREIGN KEY (bank_id) REFERENCES {schema}banks(bank_id) ON DELETE CASCADE
""")
def downgrade() -> None:
"""Reverse: observation -> mental_model and mental_models -> reflections."""
schema = _get_schema_prefix()
# 1. Rename mental_models table back to reflections
op.execute(f"ALTER TABLE IF EXISTS {schema}mental_models RENAME TO reflections")
# 2. Rename indexes back
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_bank_id RENAME TO idx_reflections_bank_id")
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_embedding RENAME TO idx_reflections_embedding")
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_tags RENAME TO idx_reflections_tags")
op.execute(f"ALTER INDEX IF EXISTS {schema}idx_mental_models_text_search RENAME TO idx_reflections_text_search")
# 3. Rename foreign key back
op.execute(f"""
ALTER TABLE {schema}reflections
DROP CONSTRAINT IF EXISTS fk_mental_models_bank_id
""")
op.execute(f"""
ALTER TABLE {schema}reflections
ADD CONSTRAINT fk_reflections_bank_id
FOREIGN KEY (bank_id) REFERENCES {schema}banks(bank_id) ON DELETE CASCADE
""")
# 4. Update fact_type values: observation -> mental_model
op.execute(f"""
UPDATE {schema}memory_units
SET fact_type = 'mental_model'
WHERE fact_type = 'observation'
""")
# 5. Update the CHECK constraint back
op.execute(f"ALTER TABLE {schema}memory_units DROP CONSTRAINT IF EXISTS memory_units_fact_type_check")
op.execute(f"""
ALTER TABLE {schema}memory_units
ADD CONSTRAINT memory_units_fact_type_check
CHECK (fact_type IN ('world', 'experience', 'opinion', 'observation', 'mental_model'))
""")
# 6. Rename index back
op.execute(f"DROP INDEX IF EXISTS {schema}idx_memory_units_observations")
op.execute(f"""
CREATE INDEX IF NOT EXISTS idx_memory_units_mental_models
ON {schema}memory_units(bank_id, fact_type)
WHERE fact_type = 'mental_model'
""")
@@ -1,41 +0,0 @@
"""Change mental_models.id from UUID to TEXT
Revision ID: u6p7q8r9s0t1
Revises: t5o6p7q8r9s0
Create Date: 2026-01-27
This migration changes the mental_models.id column from UUID to TEXT
to support user-defined text identifiers like 'team-communication' instead of UUIDs.
"""
from collections.abc import Sequence
from alembic import context, op
revision: str = "u6p7q8r9s0t1"
down_revision: str | Sequence[str] | None = "t5o6p7q8r9s0"
branch_labels: str | Sequence[str] | None = None
depends_on: str | Sequence[str] | None = None
def _get_schema_prefix() -> str:
"""Get schema prefix for table names (required for multi-tenant support)."""
schema = context.config.get_main_option("target_schema")
return f'"{schema}".' if schema else ""
def upgrade() -> None:
"""Change mental_models.id from UUID to TEXT."""
schema = _get_schema_prefix()
# Change the id column type from UUID to TEXT
# Existing UUIDs will be converted to their string representation
op.execute(f"ALTER TABLE {schema}mental_models ALTER COLUMN id TYPE TEXT USING id::TEXT")
def downgrade() -> None:
"""Revert mental_models.id from TEXT to UUID."""
schema = _get_schema_prefix()
# Note: This will fail if any id values are not valid UUIDs
op.execute(f"ALTER TABLE {schema}mental_models ALTER COLUMN id TYPE UUID USING id::UUID")
@@ -1,50 +0,0 @@
"""Add max_tokens and trigger columns to mental_models
Revision ID: v7q8r9s0t1u2
Revises: u6p7q8r9s0t1
Create Date: 2026-01-27
This migration adds:
- max_tokens column: token limit for content generation during refresh
- trigger column: JSONB for trigger settings (e.g., refresh_after_consolidation)
"""
from collections.abc import Sequence
from alembic import context, op
revision: str = "v7q8r9s0t1u2"
down_revision: str | Sequence[str] | None = "u6p7q8r9s0t1"
branch_labels: str | Sequence[str] | None = None
depends_on: str | Sequence[str] | None = None
def _get_schema_prefix() -> str:
"""Get schema prefix for table names (required for multi-tenant support)."""
schema = context.config.get_main_option("target_schema")
return f'"{schema}".' if schema else ""
def upgrade() -> None:
"""Add max_tokens and trigger columns to mental_models."""
schema = _get_schema_prefix()
op.execute(f"""
ALTER TABLE {schema}mental_models
ADD COLUMN IF NOT EXISTS max_tokens INT NOT NULL DEFAULT 2048
""")
# trigger column stores trigger settings as JSONB
# Default: refresh_after_consolidation = false (not "real time")
op.execute(f"""
ALTER TABLE {schema}mental_models
ADD COLUMN IF NOT EXISTS trigger JSONB NOT NULL DEFAULT '{{"refresh_after_consolidation": false}}'::jsonb
""")
def downgrade() -> None:
"""Remove max_tokens and trigger columns from mental_models."""
schema = _get_schema_prefix()
op.execute(f"ALTER TABLE {schema}mental_models DROP COLUMN IF EXISTS max_tokens")
op.execute(f"ALTER TABLE {schema}mental_models DROP COLUMN IF EXISTS trigger")
+169 -207
View File
@@ -92,7 +92,7 @@ class RecallRequest(BaseModel):
query: str
types: list[str] | None = Field(
default=None,
description="List of fact types to recall: 'world', 'experience', 'observation'. Defaults to world and experience if not specified. "
description="List of fact types to recall: 'world', 'experience', 'mental_model'. Defaults to world and experience if not specified. "
"Note: 'opinion' is accepted but ignored (opinions are excluded from recall).",
)
budget: Budget = Budget.MID
@@ -535,22 +535,6 @@ class ReflectFact(BaseModel):
occurred_end: str | None = None
class ReflectDirective(BaseModel):
"""A directive applied during reflect."""
id: str = Field(description="Directive ID")
name: str = Field(description="Directive name")
content: str = Field(description="Directive content")
class ReflectMentalModel(BaseModel):
"""A mental model used during reflect."""
id: str = Field(description="Mental model ID")
text: str = Field(description="Mental model content")
context: str | None = Field(default=None, description="Additional context")
class ReflectToolCall(BaseModel):
"""A tool call made during reflect agent execution."""
@@ -570,14 +554,22 @@ class ReflectLLMCall(BaseModel):
duration_ms: int = Field(description="Execution time in milliseconds")
class ReflectMentalModel(BaseModel):
"""A mental model accessed during reflect."""
id: str = Field(description="Mental model ID")
name: str = Field(description="Mental model name")
type: str = Field(description="Mental model type: entity, concept, event")
subtype: str = Field(description="Mental model subtype: structural, emergent, learned, directive")
observations: list[str] | None = Field(
default=None, description="Observations for directive mental models (subtype='directive')"
)
class ReflectBasedOn(BaseModel):
"""Evidence the response is based on: memories, mental models, and directives."""
"""Evidence the response is based on: memories and mental models."""
memories: list[ReflectFact] = Field(default_factory=list, description="Memory facts used to generate the response")
mental_models: list[ReflectMentalModel] = Field(
default_factory=list, description="Mental models used during reflection"
)
directives: list[ReflectDirective] = Field(default_factory=list, description="Directives applied during reflection")
class ReflectTrace(BaseModel):
@@ -585,6 +577,10 @@ class ReflectTrace(BaseModel):
tool_calls: list[ReflectToolCall] = Field(default_factory=list, description="Tool calls made during reflection")
llm_calls: list[ReflectLLMCall] = Field(default_factory=list, description="LLM calls made during reflection")
mental_models: list[ReflectMentalModel] = Field(
default_factory=list,
description="Mental models used during reflection (includes directives with subtype='directive')",
)
class ReflectResponse(BaseModel):
@@ -608,9 +604,9 @@ class ReflectResponse(BaseModel):
"trace": {
"tool_calls": [{"tool": "recall", "input": {"query": "AI"}, "duration_ms": 150}],
"llm_calls": [{"scope": "agent_1", "duration_ms": 1200}],
"observations": [
"mental_models": [
{
"id": "obs-1",
"id": "mm-1",
"name": "AI Technology",
"type": "concept",
"subtype": "structural",
@@ -1019,7 +1015,7 @@ class BankStatsResponse(BaseModel):
"failed_operations": 0,
"last_consolidated_at": "2024-01-15T10:30:00Z",
"pending_consolidation": 0,
"total_observations": 45,
"total_mental_models": 45,
}
}
)
@@ -1036,8 +1032,8 @@ class BankStatsResponse(BaseModel):
failed_operations: int
# Consolidation stats
last_consolidated_at: str | None = Field(default=None, description="When consolidation last ran (ISO format)")
pending_consolidation: int = Field(default=0, description="Number of memories not yet processed into observations")
total_observations: int = Field(default=0, description="Total number of observations")
pending_consolidation: int = Field(default=0, description="Number of memories not yet processed into mental models")
total_mental_models: int = Field(default=0, description="Total number of mental models")
# Mental Model models
@@ -1098,21 +1094,12 @@ class UpdateDirectiveRequest(BaseModel):
# =========================================================================
# Mental Models (stored reflect responses)
# Reflections Models
# =========================================================================
class MentalModelTrigger(BaseModel):
"""Trigger settings for a mental model."""
refresh_after_consolidation: bool = Field(
default=False,
description="If true, refresh this mental model after observations consolidation (real-time mode)",
)
class MentalModelResponse(BaseModel):
"""Response model for a mental model (stored reflect response)."""
class ReflectionResponse(BaseModel):
"""Response model for a reflection."""
id: str
bank_id: str
@@ -1120,24 +1107,22 @@ class MentalModelResponse(BaseModel):
source_query: str
content: str
tags: list[str] = Field(default_factory=list)
max_tokens: int = Field(default=2048)
trigger: MentalModelTrigger = Field(default_factory=MentalModelTrigger)
last_refreshed_at: str | None = None
created_at: str | None = None
reflect_response: dict | None = Field(
default=None,
description="Full reflect API response payload including based_on facts and observations",
description="Full reflect API response payload including based_on facts and mental_models",
)
class MentalModelListResponse(BaseModel):
"""Response model for listing mental models."""
class ReflectionListResponse(BaseModel):
"""Response model for listing reflections."""
items: list[MentalModelResponse]
items: list[ReflectionResponse]
class CreateMentalModelRequest(BaseModel):
"""Request model for creating a mental model."""
class CreateReflectionRequest(BaseModel):
"""Request model for creating a reflection."""
model_config = ConfigDict(
json_schema_extra={
@@ -1146,44 +1131,34 @@ class CreateMentalModelRequest(BaseModel):
"source_query": "How does the team prefer to communicate?",
"tags": ["team"],
"max_tokens": 2048,
"trigger": {"refresh_after_consolidation": False},
}
}
)
name: str = Field(description="Human-readable name for the mental model")
name: str = Field(description="Human-readable name for the reflection")
source_query: str = Field(description="The query to run to generate content")
tags: list[str] = Field(default_factory=list, description="Tags for scoped visibility")
max_tokens: int = Field(default=2048, ge=256, le=8192, description="Maximum tokens for generated content")
trigger: MentalModelTrigger = Field(default_factory=MentalModelTrigger, description="Trigger settings")
class CreateMentalModelResponse(BaseModel):
"""Response model for mental model creation."""
class CreateReflectionResponse(BaseModel):
"""Response model for reflection creation."""
operation_id: str = Field(description="Operation ID to track progress")
class UpdateMentalModelRequest(BaseModel):
"""Request model for updating a mental model."""
class UpdateReflectionRequest(BaseModel):
"""Request model for updating a reflection."""
model_config = ConfigDict(
json_schema_extra={
"example": {
"name": "Updated Team Communication Preferences",
"source_query": "How does the team prefer to communicate?",
"max_tokens": 4096,
"tags": ["team", "communication"],
"trigger": {"refresh_after_consolidation": True},
}
}
)
name: str | None = Field(default=None, description="New name for the mental model")
source_query: str | None = Field(default=None, description="New source query for the mental model")
max_tokens: int | None = Field(default=None, ge=256, le=8192, description="Maximum tokens for generated content")
tags: list[str] | None = Field(default=None, description="Tags for scoped visibility")
trigger: MentalModelTrigger | None = Field(default=None, description="Trigger settings")
name: str | None = Field(default=None, description="New name for the reflection")
class OperationResponse(BaseModel):
@@ -1312,7 +1287,7 @@ class AsyncOperationSubmitResponse(BaseModel):
class FeaturesInfo(BaseModel):
"""Feature flags indicating which capabilities are enabled."""
observations: bool = Field(description="Whether observations (auto-consolidation) are enabled")
mental_models: bool = Field(description="Whether mental models (auto-consolidation) are enabled")
mcp: bool = Field(description="Whether MCP (Model Context Protocol) server is enabled")
worker: bool = Field(description="Whether the background worker is enabled")
@@ -1325,7 +1300,7 @@ class VersionResponse(BaseModel):
"example": {
"api_version": "1.0.0",
"features": {
"observations": False,
"mental_models": False,
"mcp": True,
"worker": True,
},
@@ -1414,7 +1389,6 @@ def create_app(
poll_interval_ms=config.worker_poll_interval_ms,
batch_size=config.worker_batch_size,
max_retries=config.worker_max_retries,
tenant_extension=getattr(memory, "_tenant_extension", None),
)
poller_task = asyncio.create_task(poller.run())
logging.info(f"Worker poller started (worker_id={worker_id})")
@@ -1573,7 +1547,7 @@ def _register_routes(app: FastAPI):
return VersionResponse(
api_version="1.0.0",
features=FeaturesInfo(
observations=config.enable_observations,
mental_models=config.enable_mental_models,
mcp=config.mcp_enabled,
worker=config.worker_enabled,
),
@@ -1887,48 +1861,25 @@ def _register_routes(app: FastAPI):
tags_match=request.tags_match,
)
# Build based_on (memories + mental_models + directives) if facts are requested
# Build based_on (memories + mental_models) if facts are requested
based_on_result: ReflectBasedOn | None = None
if request.include.facts is not None:
memories = []
mental_models = []
directives = []
for fact_type, facts in core_result.based_on.items():
if fact_type == "directives":
# Directives have different structure (id, name, content)
for directive in facts:
directives.append(
ReflectDirective(
id=directive.id,
name=directive.name,
content=directive.content,
)
for fact in facts:
memories.append(
ReflectFact(
id=fact.id,
text=fact.text,
type=fact.fact_type,
context=fact.context,
occurred_start=fact.occurred_start,
occurred_end=fact.occurred_end,
)
elif fact_type == "mental_models":
# Mental models are MemoryFact with type "mental_models"
for fact in facts:
mental_models.append(
ReflectMentalModel(
id=fact.id,
text=fact.text,
context=fact.context,
)
)
else:
for fact in facts:
memories.append(
ReflectFact(
id=fact.id,
text=fact.text,
type=fact.fact_type,
context=fact.context,
occurred_start=fact.occurred_start,
occurred_end=fact.occurred_end,
)
)
based_on_result = ReflectBasedOn(memories=memories, mental_models=mental_models, directives=directives)
)
based_on_result = ReflectBasedOn(memories=memories)
# Build trace (tool_calls + llm_calls + observations) if tool_calls is requested
# Build trace (tool_calls + llm_calls + mental_models) if tool_calls is requested
trace_result: ReflectTrace | None = None
if request.include.tool_calls is not None:
include_output = request.include.tool_calls.output
@@ -1943,9 +1894,33 @@ def _register_routes(app: FastAPI):
for tc in core_result.tool_trace
]
llm_calls = [ReflectLLMCall(scope=lc.scope, duration_ms=lc.duration_ms) for lc in core_result.llm_trace]
# Build map of directive observations by id
directive_observations = {d.id: d.rules for d in core_result.directives_applied}
# Build mental models from tool trace (get_mental_model outputs)
trace_mental_models: list[ReflectMentalModel] = []
seen_model_ids: set[str] = set()
for tc in core_result.tool_trace:
if tc.tool == "get_mental_model" and tc.output.get("found") and "model" in tc.output:
model = tc.output["model"]
model_id = model.get("id")
if model_id and model_id not in seen_model_ids:
seen_model_ids.add(model_id)
model_subtype = model.get("subtype", "structural")
trace_mental_models.append(
ReflectMentalModel(
id=model_id,
name=model.get("name", ""),
type=model.get("type", "concept"),
subtype=model_subtype,
observations=directive_observations.get(model_id)
if model_subtype == "directive"
else None,
)
)
trace_result = ReflectTrace(
tool_calls=tool_calls,
llm_calls=llm_calls,
mental_models=trace_mental_models,
)
return ReflectResponse(
@@ -2093,16 +2068,16 @@ def _register_routes(app: FastAPI):
last_consolidated_at = consolidation_stats["last_consolidated_at"] if consolidation_stats else None
pending_consolidation = consolidation_stats["pending"] if consolidation_stats else 0
# Count total observations (consolidated knowledge)
observation_count_result = await conn.fetchrow(
# Count total mental models
mental_model_count_result = await conn.fetchrow(
f"""
SELECT COUNT(*) as count
FROM {fq_table("memory_units")}
WHERE bank_id = $1 AND fact_type = 'observation'
WHERE bank_id = $1 AND fact_type = 'mental_model'
""",
bank_id,
)
total_observations = observation_count_result["count"] if observation_count_result else 0
total_mental_models = mental_model_count_result["count"] if mental_model_count_result else 0
# Format results
nodes_by_type = {row["fact_type"]: row["count"] for row in node_stats}
@@ -2135,7 +2110,7 @@ def _register_routes(app: FastAPI):
failed_operations=failed_operations,
last_consolidated_at=(last_consolidated_at.isoformat() if last_consolidated_at else None),
pending_consolidation=pending_consolidation,
total_observations=total_observations,
total_mental_models=total_mental_models,
)
except (AuthenticationError, HTTPException):
@@ -2242,18 +2217,18 @@ def _register_routes(app: FastAPI):
# =========================================================================
# =========================================================================
# MENTAL MODELS ENDPOINTS (stored reflect responses)
# REFLECTIONS ENDPOINTS
# =========================================================================
@app.get(
"/v1/default/banks/{bank_id}/mental-models",
response_model=MentalModelListResponse,
summary="List mental models",
"/v1/default/banks/{bank_id}/reflections",
response_model=ReflectionListResponse,
summary="List reflections",
description="List user-curated living documents that stay current.",
operation_id="list_mental_models",
tags=["Mental Models"],
operation_id="list_reflections",
tags=["Reflections"],
)
async def api_list_mental_models(
async def api_list_reflections(
bank_id: str,
tags_filter: list[str] | None = Query(None, alias="tags", description="Filter by tags"),
tags_match: Literal["any", "all", "exact"] = Query("any", description="How to match tags"),
@@ -2261,9 +2236,9 @@ def _register_routes(app: FastAPI):
offset: int = Query(0, ge=0),
request_context: RequestContext = Depends(get_request_context),
):
"""List mental models for a bank."""
"""List reflections for a bank."""
try:
mental_models = await app.state.memory.list_mental_models(
reflections = await app.state.memory.list_reflections(
bank_id=bank_id,
tags=tags_filter,
tags_match=tags_match,
@@ -2271,83 +2246,74 @@ def _register_routes(app: FastAPI):
offset=offset,
request_context=request_context,
)
return MentalModelListResponse(items=[MentalModelResponse(**m) for m in mental_models])
return ReflectionListResponse(items=[ReflectionResponse(**r) for r in reflections])
except (AuthenticationError, HTTPException):
raise
except Exception as e:
import traceback
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(f"Error in GET /v1/default/banks/{bank_id}/mental-models: {error_detail}")
logger.error(f"Error in GET /v1/default/banks/{bank_id}/reflections: {error_detail}")
raise HTTPException(status_code=500, detail=str(e))
@app.get(
"/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
response_model=MentalModelResponse,
summary="Get mental model",
description="Get a specific mental model by ID.",
operation_id="get_mental_model",
tags=["Mental Models"],
"/v1/default/banks/{bank_id}/reflections/{reflection_id}",
response_model=ReflectionResponse,
summary="Get reflection",
description="Get a specific reflection by ID.",
operation_id="get_reflection",
tags=["Reflections"],
)
async def api_get_mental_model(
async def api_get_reflection(
bank_id: str,
mental_model_id: str,
reflection_id: str,
request_context: RequestContext = Depends(get_request_context),
):
"""Get a mental model by ID."""
"""Get a reflection by ID."""
try:
mental_model = await app.state.memory.get_mental_model(
reflection = await app.state.memory.get_reflection(
bank_id=bank_id,
mental_model_id=mental_model_id,
reflection_id=reflection_id,
request_context=request_context,
)
if mental_model is None:
raise HTTPException(status_code=404, detail=f"Mental model '{mental_model_id}' not found")
return MentalModelResponse(**mental_model)
if reflection is None:
raise HTTPException(status_code=404, detail=f"Reflection '{reflection_id}' not found")
return ReflectionResponse(**reflection)
except (AuthenticationError, HTTPException):
raise
except Exception as e:
import traceback
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(f"Error in GET /v1/default/banks/{bank_id}/mental-models/{mental_model_id}: {error_detail}")
logger.error(f"Error in GET /v1/default/banks/{bank_id}/reflections/{reflection_id}: {error_detail}")
raise HTTPException(status_code=500, detail=str(e))
@app.post(
"/v1/default/banks/{bank_id}/mental-models",
response_model=CreateMentalModelResponse,
summary="Create mental model",
description="Create a mental model by running reflect with the source query in the background. "
"/v1/default/banks/{bank_id}/reflections",
response_model=CreateReflectionResponse,
summary="Create reflection",
description="Create a reflection by running reflect with the source query in the background. "
"Returns an operation ID to track progress. The content is auto-generated by the reflect endpoint. "
"Use the operations endpoint to check completion status.",
operation_id="create_mental_model",
tags=["Mental Models"],
operation_id="create_reflection",
tags=["Reflections"],
)
async def api_create_mental_model(
async def api_create_reflection(
bank_id: str,
body: CreateMentalModelRequest,
body: CreateReflectionRequest,
request_context: RequestContext = Depends(get_request_context),
):
"""Create a mental model (async - returns operation_id)."""
"""Create a reflection (async - returns operation_id)."""
try:
# 1. Create the mental model with placeholder content
mental_model = await app.state.memory.create_mental_model(
result = await app.state.memory.submit_async_create_reflection(
bank_id=bank_id,
name=body.name,
source_query=body.source_query,
content="Generating content...",
tags=body.tags if body.tags else None,
max_tokens=body.max_tokens,
trigger=body.trigger.model_dump() if body.trigger else None,
request_context=request_context,
)
# 2. Schedule a refresh to generate the actual content
result = await app.state.memory.submit_async_refresh_mental_model(
bank_id=bank_id,
mental_model_id=mental_model["id"],
request_context=request_context,
)
return CreateMentalModelResponse(operation_id=result["operation_id"])
return CreateReflectionResponse(operation_id=result["operation_id"])
except ValueError as e:
raise HTTPException(status_code=400, detail=str(e))
except (AuthenticationError, HTTPException):
@@ -2356,27 +2322,27 @@ def _register_routes(app: FastAPI):
import traceback
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(f"Error in POST /v1/default/banks/{bank_id}/mental-models: {error_detail}")
logger.error(f"Error in POST /v1/default/banks/{bank_id}/reflections: {error_detail}")
raise HTTPException(status_code=500, detail=str(e))
@app.post(
"/v1/default/banks/{bank_id}/mental-models/{mental_model_id}/refresh",
"/v1/default/banks/{bank_id}/reflections/{reflection_id}/refresh",
response_model=AsyncOperationSubmitResponse,
summary="Refresh mental model",
summary="Refresh reflection",
description="Submit an async task to re-run the source query through reflect and update the content.",
operation_id="refresh_mental_model",
tags=["Mental Models"],
operation_id="refresh_reflection",
tags=["Reflections"],
)
async def api_refresh_mental_model(
async def api_refresh_reflection(
bank_id: str,
mental_model_id: str,
reflection_id: str,
request_context: RequestContext = Depends(get_request_context),
):
"""Refresh a mental model by re-running its source query (async)."""
"""Refresh a reflection by re-running its source query (async)."""
try:
result = await app.state.memory.submit_async_refresh_mental_model(
result = await app.state.memory.submit_async_refresh_reflection(
bank_id=bank_id,
mental_model_id=mental_model_id,
reflection_id=reflection_id,
request_context=request_context,
)
return AsyncOperationSubmitResponse(operation_id=result["operation_id"], status="queued")
@@ -2389,69 +2355,65 @@ def _register_routes(app: FastAPI):
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(
f"Error in POST /v1/default/banks/{bank_id}/mental-models/{mental_model_id}/refresh: {error_detail}"
f"Error in POST /v1/default/banks/{bank_id}/reflections/{reflection_id}/refresh: {error_detail}"
)
raise HTTPException(status_code=500, detail=str(e))
@app.patch(
"/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
response_model=MentalModelResponse,
summary="Update mental model",
description="Update a mental model's name and/or source query.",
operation_id="update_mental_model",
tags=["Mental Models"],
"/v1/default/banks/{bank_id}/reflections/{reflection_id}",
response_model=ReflectionResponse,
summary="Update reflection",
description="Update a reflection's name.",
operation_id="update_reflection",
tags=["Reflections"],
)
async def api_update_mental_model(
async def api_update_reflection(
bank_id: str,
mental_model_id: str,
body: UpdateMentalModelRequest,
reflection_id: str,
body: UpdateReflectionRequest,
request_context: RequestContext = Depends(get_request_context),
):
"""Update a mental model."""
"""Update a reflection."""
try:
mental_model = await app.state.memory.update_mental_model(
reflection = await app.state.memory.update_reflection(
bank_id=bank_id,
mental_model_id=mental_model_id,
reflection_id=reflection_id,
name=body.name,
source_query=body.source_query,
max_tokens=body.max_tokens,
tags=body.tags,
trigger=body.trigger.model_dump() if body.trigger else None,
request_context=request_context,
)
if mental_model is None:
raise HTTPException(status_code=404, detail=f"Mental model '{mental_model_id}' not found")
return MentalModelResponse(**mental_model)
if reflection is None:
raise HTTPException(status_code=404, detail=f"Reflection '{reflection_id}' not found")
return ReflectionResponse(**reflection)
except (AuthenticationError, HTTPException):
raise
except Exception as e:
import traceback
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(f"Error in PATCH /v1/default/banks/{bank_id}/mental-models/{mental_model_id}: {error_detail}")
logger.error(f"Error in PATCH /v1/default/banks/{bank_id}/reflections/{reflection_id}: {error_detail}")
raise HTTPException(status_code=500, detail=str(e))
@app.delete(
"/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
summary="Delete mental model",
description="Delete a mental model.",
operation_id="delete_mental_model",
tags=["Mental Models"],
"/v1/default/banks/{bank_id}/reflections/{reflection_id}",
summary="Delete reflection",
description="Delete a reflection.",
operation_id="delete_reflection",
tags=["Reflections"],
)
async def api_delete_mental_model(
async def api_delete_reflection(
bank_id: str,
mental_model_id: str,
reflection_id: str,
request_context: RequestContext = Depends(get_request_context),
):
"""Delete a mental model."""
"""Delete a reflection."""
try:
deleted = await app.state.memory.delete_mental_model(
deleted = await app.state.memory.delete_reflection(
bank_id=bank_id,
mental_model_id=mental_model_id,
reflection_id=reflection_id,
request_context=request_context,
)
if not deleted:
raise HTTPException(status_code=404, detail=f"Mental model '{mental_model_id}' not found")
raise HTTPException(status_code=404, detail=f"Reflection '{reflection_id}' not found")
return {"status": "deleted"}
except (AuthenticationError, HTTPException):
raise
@@ -2459,7 +2421,7 @@ def _register_routes(app: FastAPI):
import traceback
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/mental-models/{mental_model_id}: {error_detail}")
logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/reflections/{reflection_id}: {error_detail}")
raise HTTPException(status_code=500, detail=str(e))
# =========================================================================
@@ -3183,20 +3145,20 @@ def _register_routes(app: FastAPI):
raise HTTPException(status_code=500, detail=str(e))
@app.delete(
"/v1/default/banks/{bank_id}/observations",
"/v1/default/banks/{bank_id}/mental-models",
response_model=DeleteResponse,
summary="Clear all observations",
description="Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.",
operation_id="clear_observations",
summary="Clear all mental models",
description="Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.",
operation_id="clear_mental_models",
tags=["Banks"],
)
async def api_clear_observations(bank_id: str, request_context: RequestContext = Depends(get_request_context)):
"""Clear all observations for a bank."""
async def api_clear_mental_models(bank_id: str, request_context: RequestContext = Depends(get_request_context)):
"""Clear all mental models for a bank."""
try:
result = await app.state.memory.clear_observations(bank_id, request_context=request_context)
result = await app.state.memory.clear_mental_models(bank_id, request_context=request_context)
return DeleteResponse(
success=True,
message=f"Cleared {result.get('deleted_count', 0)} observations",
message=f"Cleared {result.get('deleted_count', 0)} mental models",
deleted_count=result.get("deleted_count", 0),
)
except (AuthenticationError, HTTPException):
@@ -3205,14 +3167,14 @@ def _register_routes(app: FastAPI):
import traceback
error_detail = f"{str(e)}\n\nTraceback:\n{traceback.format_exc()}"
logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/observations: {error_detail}")
logger.error(f"Error in DELETE /v1/default/banks/{bank_id}/mental-models: {error_detail}")
raise HTTPException(status_code=500, detail=str(e))
@app.post(
"/v1/default/banks/{bank_id}/consolidate",
response_model=ConsolidationResponse,
summary="Trigger consolidation",
description="Run memory consolidation to create/update observations from recent memories.",
description="Run memory consolidation to create/update mental models from recent memories.",
operation_id="trigger_consolidation",
tags=["Banks"],
)
+34 -14
View File
@@ -87,16 +87,20 @@ ENV_MCP_LOCAL_BANK_ID = "HINDSIGHT_API_MCP_LOCAL_BANK_ID"
ENV_MCP_INSTRUCTIONS = "HINDSIGHT_API_MCP_INSTRUCTIONS"
ENV_MENTAL_MODEL_REFRESH_CONCURRENCY = "HINDSIGHT_API_MENTAL_MODEL_REFRESH_CONCURRENCY"
# Observation thresholds
ENV_OBSERVATION_MIN_FACTS = "HINDSIGHT_API_OBSERVATION_MIN_FACTS"
ENV_OBSERVATION_TOP_ENTITIES = "HINDSIGHT_API_OBSERVATION_TOP_ENTITIES"
# Retain settings
ENV_RETAIN_MAX_COMPLETION_TOKENS = "HINDSIGHT_API_RETAIN_MAX_COMPLETION_TOKENS"
ENV_RETAIN_CHUNK_SIZE = "HINDSIGHT_API_RETAIN_CHUNK_SIZE"
ENV_RETAIN_EXTRACT_CAUSAL_LINKS = "HINDSIGHT_API_RETAIN_EXTRACT_CAUSAL_LINKS"
ENV_RETAIN_EXTRACTION_MODE = "HINDSIGHT_API_RETAIN_EXTRACTION_MODE"
ENV_RETAIN_CUSTOM_INSTRUCTIONS = "HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS"
ENV_RETAIN_OBSERVATIONS_ASYNC = "HINDSIGHT_API_RETAIN_OBSERVATIONS_ASYNC"
# Observations settings (consolidated knowledge from facts)
ENV_ENABLE_OBSERVATIONS = "HINDSIGHT_API_ENABLE_OBSERVATIONS"
# Mental models settings
ENV_ENABLE_MENTAL_MODELS = "HINDSIGHT_API_ENABLE_MENTAL_MODELS"
ENV_CONSOLIDATION_SIMILARITY_THRESHOLD = "HINDSIGHT_API_CONSOLIDATION_SIMILARITY_THRESHOLD"
ENV_CONSOLIDATION_BATCH_SIZE = "HINDSIGHT_API_CONSOLIDATION_BATCH_SIZE"
# Optimization flags
@@ -165,17 +169,21 @@ DEFAULT_RECALL_CONNECTION_BUDGET = 4 # Max concurrent DB connections per recall
DEFAULT_MCP_LOCAL_BANK_ID = "mcp"
DEFAULT_MENTAL_MODEL_REFRESH_CONCURRENCY = 8 # Max concurrent mental model refreshes
# Observation thresholds
DEFAULT_OBSERVATION_MIN_FACTS = 5 # Min facts required to generate entity observations
DEFAULT_OBSERVATION_TOP_ENTITIES = 5 # Max entities to process per retain batch
# Retain settings
DEFAULT_RETAIN_MAX_COMPLETION_TOKENS = 64000 # Max tokens for fact extraction LLM call
DEFAULT_RETAIN_CHUNK_SIZE = 3000 # Max chars per chunk for fact extraction
DEFAULT_RETAIN_EXTRACT_CAUSAL_LINKS = True # Extract causal links between facts
DEFAULT_RETAIN_EXTRACTION_MODE = "concise" # Extraction mode: "concise", "verbose", or "custom"
RETAIN_EXTRACTION_MODES = ("concise", "verbose", "custom") # Allowed extraction modes
DEFAULT_RETAIN_CUSTOM_INSTRUCTIONS = None # Custom extraction guidelines (only used when mode="custom")
DEFAULT_RETAIN_EXTRACTION_MODE = "concise" # Extraction mode: "concise" or "verbose"
RETAIN_EXTRACTION_MODES = ("concise", "verbose") # Allowed extraction modes
DEFAULT_RETAIN_OBSERVATIONS_ASYNC = False # Run observation generation async (after retain completes)
# Observations defaults (consolidated knowledge from facts)
DEFAULT_ENABLE_OBSERVATIONS = True # Observations enabled by default
# Mental models defaults
DEFAULT_ENABLE_MENTAL_MODELS = False # Mental models disabled by default (experimental)
DEFAULT_CONSOLIDATION_SIMILARITY_THRESHOLD = 0.75 # Minimum similarity to consider a learning related
DEFAULT_CONSOLIDATION_BATCH_SIZE = 50 # Memories to load per batch (internal memory optimization)
# Database migrations
@@ -325,16 +333,20 @@ class HindsightConfig:
recall_connection_budget: int
mental_model_refresh_concurrency: int
# Observation thresholds
observation_min_facts: int
observation_top_entities: int
# Retain settings
retain_max_completion_tokens: int
retain_chunk_size: int
retain_extract_causal_links: bool
retain_extraction_mode: str
retain_custom_instructions: str | None
retain_observations_async: bool
# Observations settings (consolidated knowledge from facts)
enable_observations: bool
# Mental models settings
enable_mental_models: bool
consolidation_similarity_threshold: float
consolidation_batch_size: int
# Optimization flags
@@ -422,6 +434,11 @@ class HindsightConfig:
# Optimization flags
skip_llm_verification=os.getenv(ENV_SKIP_LLM_VERIFICATION, "false").lower() == "true",
lazy_reranker=os.getenv(ENV_LAZY_RERANKER, "false").lower() == "true",
# Observation thresholds
observation_min_facts=int(os.getenv(ENV_OBSERVATION_MIN_FACTS, str(DEFAULT_OBSERVATION_MIN_FACTS))),
observation_top_entities=int(
os.getenv(ENV_OBSERVATION_TOP_ENTITIES, str(DEFAULT_OBSERVATION_TOP_ENTITIES))
),
# Retain settings
retain_max_completion_tokens=int(
os.getenv(ENV_RETAIN_MAX_COMPLETION_TOKENS, str(DEFAULT_RETAIN_MAX_COMPLETION_TOKENS))
@@ -434,13 +451,16 @@ class HindsightConfig:
retain_extraction_mode=_validate_extraction_mode(
os.getenv(ENV_RETAIN_EXTRACTION_MODE, DEFAULT_RETAIN_EXTRACTION_MODE)
),
retain_custom_instructions=os.getenv(ENV_RETAIN_CUSTOM_INSTRUCTIONS) or DEFAULT_RETAIN_CUSTOM_INSTRUCTIONS,
retain_observations_async=os.getenv(
ENV_RETAIN_OBSERVATIONS_ASYNC, str(DEFAULT_RETAIN_OBSERVATIONS_ASYNC)
).lower()
== "true",
# Observations settings (consolidated knowledge from facts)
enable_observations=os.getenv(ENV_ENABLE_OBSERVATIONS, str(DEFAULT_ENABLE_OBSERVATIONS)).lower() == "true",
# Mental models settings
enable_mental_models=os.getenv(ENV_ENABLE_MENTAL_MODELS, str(DEFAULT_ENABLE_MENTAL_MODELS)).lower()
== "true",
consolidation_similarity_threshold=float(
os.getenv(ENV_CONSOLIDATION_SIMILARITY_THRESHOLD, str(DEFAULT_CONSOLIDATION_SIMILARITY_THRESHOLD))
),
consolidation_batch_size=int(
os.getenv(ENV_CONSOLIDATION_BATCH_SIZE, str(DEFAULT_CONSOLIDATION_BATCH_SIZE))
),
@@ -1,13 +1,13 @@
"""Consolidation engine for automatic observation creation from memories.
"""Consolidation engine for automatic mental model creation from memories.
The consolidation engine runs as a background job after retain operations complete.
It processes new memories and either:
- Creates new observations from novel facts
- Updates existing observations when new evidence supports/contradicts/refines them
- Creates new mental models from novel facts
- Updates existing mental models when new evidence supports/contradicts/refines them
Observations are stored in memory_units with fact_type='observation' and include:
Mental models are stored in memory_units with fact_type='mental_model' and include:
- proof_count: Number of supporting memories
- source_memory_ids: Array of memory UUIDs that contribute to this observation
- source_memory_ids: Array of memory UUIDs that contribute to this mental model
- history: JSONB tracking changes over time
"""
@@ -89,7 +89,7 @@ async def run_consolidation_job(
max_memories_per_batch = config.consolidation_batch_size
# Check if consolidation is enabled
if not config.enable_observations:
if not config.enable_mental_models:
logger.debug(f"Consolidation disabled for bank {bank_id}")
return {"status": "disabled", "bank_id": bank_id}
@@ -136,9 +136,9 @@ async def run_consolidation_job(
# Process each memory with individual commits for crash recovery
stats = {
"memories_processed": 0,
"observations_created": 0,
"observations_updated": 0,
"observations_merged": 0,
"mental_models_created": 0,
"mental_models_updated": 0,
"mental_models_merged": 0,
"actions_executed": 0,
"skipped": 0,
}
@@ -153,7 +153,7 @@ async def run_consolidation_job(
t0 = time.time()
memories = await conn.fetch(
f"""
SELECT id, text, fact_type, occurred_start, occurred_end, event_date, tags, mentioned_at
SELECT id, text, fact_type, occurred_start, event_date, tags, mentioned_at
FROM {fq_table("memory_units")}
WHERE bank_id = $1
AND consolidated_at IS NULL
@@ -201,18 +201,18 @@ async def run_consolidation_job(
action = result.get("action")
if action == "created":
stats["observations_created"] += 1
stats["mental_models_created"] += 1
stats["actions_executed"] += 1
elif action == "updated":
stats["observations_updated"] += 1
stats["mental_models_updated"] += 1
stats["actions_executed"] += 1
elif action == "merged":
stats["observations_merged"] += 1
stats["mental_models_merged"] += 1
stats["actions_executed"] += 1
elif action == "multiple":
stats["observations_created"] += result.get("created", 0)
stats["observations_updated"] += result.get("updated", 0)
stats["observations_merged"] += result.get("merged", 0)
stats["mental_models_created"] += result.get("created", 0)
stats["mental_models_updated"] += result.get("updated", 0)
stats["mental_models_merged"] += result.get("merged", 0)
stats["actions_executed"] += result.get("total_actions", 0)
elif action == "skipped":
stats["skipped"] += 1
@@ -234,9 +234,9 @@ async def run_consolidation_job(
perf.log(
f"[3] Results: {stats['memories_processed']} memories -> "
f"{stats['actions_executed']} actions "
f"({stats['observations_created']} created, "
f"{stats['observations_updated']} updated, "
f"{stats['observations_merged']} merged, "
f"({stats['mental_models_created']} created, "
f"{stats['mental_models_updated']} updated, "
f"{stats['mental_models_merged']} merged, "
f"{stats['skipped']} skipped)"
)
@@ -254,79 +254,11 @@ async def run_consolidation_job(
if timing_parts:
perf.log(f"[4] Timing breakdown: {', '.join(timing_parts)}")
# Trigger mental model refreshes for models with refresh_after_consolidation=true
mental_models_refreshed = await _trigger_mental_model_refreshes(
memory_engine=memory_engine,
bank_id=bank_id,
request_context=request_context,
perf=perf,
)
stats["mental_models_refreshed"] = mental_models_refreshed
perf.flush()
return {"status": "completed", "bank_id": bank_id, **stats}
async def _trigger_mental_model_refreshes(
memory_engine: "MemoryEngine",
bank_id: str,
request_context: "RequestContext",
perf: ConsolidationPerfLog | None = None,
) -> int:
"""
Trigger refreshes for mental models with refresh_after_consolidation=true.
Args:
memory_engine: MemoryEngine instance
bank_id: Bank identifier
request_context: Request context for authentication
perf: Performance logging
Returns:
Number of mental models scheduled for refresh
"""
pool = memory_engine._pool
# Find mental models with refresh_after_consolidation=true
async with pool.acquire() as conn:
rows = await conn.fetch(
f"""
SELECT id, name
FROM {fq_table("mental_models")}
WHERE bank_id = $1
AND (trigger->>'refresh_after_consolidation')::boolean = true
""",
bank_id,
)
if not rows:
return 0
if perf:
perf.log(f"[5] Triggering refresh for {len(rows)} mental models with refresh_after_consolidation=true")
# Submit refresh tasks for each mental model
refreshed_count = 0
for row in rows:
mental_model_id = row["id"]
try:
await memory_engine.submit_async_refresh_mental_model(
bank_id=bank_id,
mental_model_id=mental_model_id,
request_context=request_context,
)
refreshed_count += 1
logger.info(
f"[CONSOLIDATION] Triggered refresh for mental model {mental_model_id} "
f"(name: {row['name']}) in bank {bank_id}"
)
except Exception as e:
logger.warning(f"[CONSOLIDATION] Failed to trigger refresh for mental model {mental_model_id}: {e}")
return refreshed_count
async def _process_memory(
conn: "Connection",
memory_engine: "MemoryEngine",
@@ -340,13 +272,13 @@ async def _process_memory(
Process a single memory for consolidation using a SINGLE LLM call.
This function:
1. Finds related observations (can be empty)
1. Finds related mental models (can be empty)
2. Uses ONE LLM call to extract durable knowledge AND decide on actions
3. Executes array of actions (can be multiple creates/updates)
The LLM handles all cases:
- No related observations: returns create action(s) with extracted durable knowledge
- Related observations exist: returns update/create actions based on tag routing
- No related models: returns create action(s) with extracted durable knowledge
- Related models exist: returns update/create actions based on tag routing
- Purely ephemeral fact: returns empty array (skip)
Returns:
@@ -356,9 +288,9 @@ async def _process_memory(
memory_id = memory["id"]
fact_tags = memory.get("tags") or []
# Find related observations using the full recall system (NO tag filtering)
# Find related mental models using the full recall system (NO tag filtering)
t0 = time.time()
related_observations = await _find_related_observations(
related_mental_models = await _find_related_mental_models(
conn=conn,
memory_engine=memory_engine,
bank_id=bank_id,
@@ -368,13 +300,13 @@ async def _process_memory(
if perf:
perf.record_timing("recall", time.time() - t0)
# Single LLM call handles ALL cases (with or without existing observations)
# Note: Tags are NOT passed to LLM - they are handled algorithmically
# Single LLM call handles ALL cases (with or without existing models)
t0 = time.time()
actions = await _consolidate_with_llm(
memory_engine=memory_engine,
fact_text=fact_text,
observations=related_observations, # Can be empty list
fact_tags=fact_tags,
mental_models=related_mental_models, # Can be empty list
mission=mission,
)
if perf:
@@ -395,10 +327,7 @@ async def _process_memory(
bank_id=bank_id,
memory_id=memory_id,
action=action,
observations=related_observations,
source_fact_tags=fact_tags, # Pass source fact's tags for security
source_occurred_start=memory.get("occurred_start"),
source_occurred_end=memory.get("occurred_end"),
mental_models=related_mental_models,
source_mentioned_at=memory.get("mentioned_at"),
perf=perf,
)
@@ -410,10 +339,8 @@ async def _process_memory(
bank_id=bank_id,
memory_id=memory_id,
action=action,
source_fact_tags=fact_tags, # Pass source fact's tags for security
event_date=memory.get("event_date"),
occurred_start=memory.get("occurred_start"),
occurred_end=memory.get("occurred_end"),
mentioned_at=memory.get("mentioned_at"),
perf=perf,
)
@@ -446,26 +373,15 @@ async def _execute_update_action(
bank_id: str,
memory_id: uuid.UUID,
action: dict[str, Any],
observations: list[dict[str, Any]],
source_fact_tags: list[str] | None = None,
source_occurred_start: datetime | None = None,
source_occurred_end: datetime | None = None,
mental_models: list[dict[str, Any]],
source_mentioned_at: datetime | None = None,
perf: ConsolidationPerfLog | None = None,
) -> dict[str, Any]:
"""
Execute an update action on an existing observation.
Execute an update action on an existing mental model.
Updates the observation text, adds to history, increments proof_count,
and updates temporal fields:
- occurred_start: uses LEAST to keep the earliest start time
- occurred_end: uses GREATEST to keep the most recent end time
- mentioned_at: uses GREATEST to keep the most recent mention time
SECURITY: Merges source fact's tags into the observation's existing tags.
This ensures all contributors can see the observation they contributed to.
For example, if Lisa's observation (tags=['user_lisa']) is updated with
Mike's fact (tags=['user_mike']), the observation will have both tags.
Updates the mental model text, adds to history, increments proof_count,
and updates mentioned_at if the new source memory has a more recent date.
"""
learning_id = action.get("learning_id")
new_text = action.get("text")
@@ -474,8 +390,8 @@ async def _execute_update_action(
if not learning_id or not new_text:
return {"action": "skipped", "reason": "missing_learning_id_or_text"}
# Find the observation
model = next((m for m in observations if str(m["id"]) == learning_id), None)
# Find the mental model
model = next((m for m in mental_models if str(m["id"]) == learning_id), None)
if not model:
return {"action": "skipped", "reason": "learning_not_found"}
@@ -494,17 +410,6 @@ async def _execute_update_action(
source_ids = list(model.get("source_memory_ids", []))
source_ids.append(memory_id)
# SECURITY: Merge source fact's tags into existing observation tags
# This ensures all contributors can see the observation they contributed to
existing_tags = set(model.get("tags", []) or [])
source_tags = set(source_fact_tags or [])
merged_tags = list(existing_tags | source_tags) # Union of both tag sets
if source_tags and source_tags != existing_tags:
logger.debug(
f"Security: Merging tags for observation {learning_id}: "
f"existing={list(existing_tags)}, source={list(source_tags)}, merged={merged_tags}"
)
# Generate new embedding for updated text
t0 = time.time()
embeddings = await embedding_utils.generate_embeddings_batch(memory_engine.embeddings, [new_text])
@@ -512,11 +417,8 @@ async def _execute_update_action(
if perf:
perf.record_timing("embedding", time.time() - t0)
# Update the observation
# - occurred_start: LEAST keeps the earliest start time across all source facts
# - occurred_end: GREATEST keeps the most recent end time across all source facts
# - mentioned_at: GREATEST keeps the most recent mention time
# - tags: merged from existing + source fact (for visibility)
# Update the mental model
# Update mentioned_at if source memory has a more recent date
t0 = time.time()
await conn.execute(
f"""
@@ -526,11 +428,8 @@ async def _execute_update_action(
history = $3,
source_memory_ids = $4,
proof_count = $5,
tags = $10,
updated_at = now(),
occurred_start = LEAST(occurred_start, COALESCE($7, occurred_start)),
occurred_end = GREATEST(occurred_end, COALESCE($8, occurred_end)),
mentioned_at = GREATEST(mentioned_at, COALESCE($9, mentioned_at))
mentioned_at = GREATEST(mentioned_at, COALESCE($7, mentioned_at))
WHERE id = $6
""",
new_text,
@@ -539,20 +438,17 @@ async def _execute_update_action(
source_ids,
len(source_ids),
uuid.UUID(learning_id),
source_occurred_start,
source_occurred_end,
source_mentioned_at,
merged_tags,
)
# Create links from memory to observation
# Create links from memory to mental model
await _create_memory_links(conn, memory_id, uuid.UUID(learning_id))
if perf:
perf.record_timing("db_write", time.time() - t0)
logger.debug(f"Updated observation {learning_id} with memory {memory_id}")
logger.debug(f"Updated mental model {learning_id} with memory {memory_id}")
return {"action": "updated", "observation_id": learning_id}
return {"action": "updated", "mental_model_id": learning_id}
async def _execute_create_action(
@@ -561,48 +457,38 @@ async def _execute_create_action(
bank_id: str,
memory_id: uuid.UUID,
action: dict[str, Any],
source_fact_tags: list[str] | None = None,
event_date: datetime | None = None,
occurred_start: datetime | None = None,
occurred_end: datetime | None = None,
mentioned_at: datetime | None = None,
perf: ConsolidationPerfLog | None = None,
) -> dict[str, Any]:
"""
Execute a create action for a new observation.
Execute a create action for a new mental model.
Creates a new observation with the specified text.
Creates a new mental model with the specified text and tags.
The text comes directly from the classify LLM - no second LLM call needed.
Tags are determined algorithmically (not by LLM):
- Observations always inherit their source fact's tags
- This ensures visibility scope is maintained (security)
"""
text = action.get("text")
# Tags are determined algorithmically - always use source fact's tags
# This ensures private memories create private observations
tags = source_fact_tags or []
tags = action.get("tags", [])
if not text:
return {"action": "skipped", "reason": "missing_text"}
# Use text directly from classify - skip the redundant LLM call
result = await _create_observation_directly(
result = await _create_mental_model_directly(
conn=conn,
memory_engine=memory_engine,
bank_id=bank_id,
source_memory_id=memory_id,
observation_text=text, # Text already processed by classify LLM
mental_model_text=text, # Text already processed by classify LLM
tags=tags,
event_date=event_date,
occurred_start=occurred_start,
occurred_end=occurred_end,
mentioned_at=mentioned_at,
perf=perf,
)
logger.debug(f"Created observation {result.get('observation_id')} from memory {memory_id} (tags: {tags})")
logger.debug(f"Created mental model {result.get('mental_model_id')} from memory {memory_id} (tags: {tags})")
return result
@@ -610,28 +496,98 @@ async def _execute_create_action(
async def _create_memory_links(
conn: "Connection",
memory_id: uuid.UUID,
observation_id: uuid.UUID,
mental_model_id: uuid.UUID,
) -> None:
"""
Placeholder for observation link creation.
Create links between a source memory and its mental model.
Observations do NOT get any memory_links copied from their source facts.
Instead, retrieval uses source_memory_ids to traverse:
- Entity connections: observation → source_memory_ids → unit_entities
- Semantic similarity: observations have their own embeddings
- Temporal proximity: observations have their own temporal fields
This:
1. Creates bidirectional semantic links between memory and mental model
2. Copies existing memory_links from the source memory to the mental model
3. Copies entity links from the source memory to the mental model
This avoids data duplication and ensures observations are always
connected via their source facts' relationships.
This enables graph traversal to find related memories via their mental models.
The memory_id and observation_id parameters are kept for interface
compatibility but no links are created.
Note: Uses EXISTS checks to handle the case where source memory was deleted
by a concurrent operation between fetching and link creation.
"""
# No links are created - observations rely on source_memory_ids for traversal
pass
mu_table = fq_table("memory_units")
ml_table = fq_table("memory_links")
ue_table = fq_table("unit_entities")
# 1. Bidirectional link between memory and mental model
# Only insert if both units exist (handles concurrent deletion)
await conn.execute(
f"""
INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, weight)
SELECT $1, $2, 'semantic', 1.0
WHERE EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $2)
ON CONFLICT DO NOTHING
""",
memory_id,
mental_model_id,
)
await conn.execute(
f"""
INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, weight)
SELECT $1, $2, 'semantic', 1.0
WHERE EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $2)
ON CONFLICT DO NOTHING
""",
mental_model_id,
memory_id,
)
# 2. Copy outgoing memory_links from source memory to mental model
# If source memory links to X, mental model should also link to X
await conn.execute(
f"""
INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, entity_id, weight)
SELECT $1, ml.to_unit_id, ml.link_type, ml.entity_id, ml.weight
FROM {ml_table} ml
WHERE ml.from_unit_id = $2 AND ml.to_unit_id != $1
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = ml.to_unit_id)
ON CONFLICT DO NOTHING
""",
mental_model_id,
memory_id,
)
# 3. Copy incoming memory_links from source memory to mental model
# If X links to source memory, X should also link to mental model
await conn.execute(
f"""
INSERT INTO {ml_table} (from_unit_id, to_unit_id, link_type, entity_id, weight)
SELECT ml.from_unit_id, $1, ml.link_type, ml.entity_id, ml.weight
FROM {ml_table} ml
WHERE ml.to_unit_id = $2 AND ml.from_unit_id != $1
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = ml.from_unit_id)
ON CONFLICT DO NOTHING
""",
mental_model_id,
memory_id,
)
# 4. Copy entity links from source memory to mental model
await conn.execute(
f"""
INSERT INTO {ue_table} (unit_id, entity_id)
SELECT $1, ue.entity_id
FROM {ue_table} ue
WHERE ue.unit_id = $2
AND EXISTS (SELECT 1 FROM {mu_table} WHERE id = $1)
ON CONFLICT DO NOTHING
""",
mental_model_id,
memory_id,
)
async def _find_related_observations(
async def _find_related_mental_models(
conn: "Connection",
memory_engine: "MemoryEngine",
bank_id: str,
@@ -639,10 +595,10 @@ async def _find_related_observations(
request_context: "RequestContext",
) -> list[dict[str, Any]]:
"""
Find observations related to the given query using the full recall system.
Find mental models related to the given query using the full recall system.
IMPORTANT: We do NOT filter by tags here. Consolidation needs to see ALL
potentially related observations regardless of scope, so the LLM can
potentially related mental models regardless of scope, so the LLM can
decide on tag routing (same scope update vs cross-scope create).
This leverages:
@@ -652,37 +608,37 @@ async def _find_related_observations(
- Graph traversal (connected via entity links)
Returns:
List of related observations with their tags for LLM tag routing
List of related mental models with their tags for LLM tag routing
"""
# Use recall to find related observations
# NO tags parameter - we want ALL observations regardless of scope
# Use low max_tokens since we only need observations, not memories
# Use recall to find related mental models
# NO tags parameter - we want ALL mental models regardless of scope
# Use low max_tokens since we only need mental models, not memories
recall_result = await memory_engine.recall_async(
bank_id=bank_id,
query=query,
max_tokens=5000, # Token budget for observations
fact_type=["observation"], # Only retrieve observations
max_tokens=5000, # Token budget for mental models
fact_type=["mental_model"], # Only retrieve mental models
request_context=request_context,
_quiet=True, # Suppress logging
# NO tags parameter - intentionally get ALL observations
# NO tags parameter - intentionally get ALL mental models
)
# If no observations returned, return empty list
# When fact_type=["observation"], results come back in `results` field
# If no mental models returned, return empty list
# When fact_type=["mental_model"], results come back in `results` field
if not recall_result.results:
return []
# Trust recall's relevance filtering - fetch full data for each observation
# Trust recall's relevance filtering - fetch full data for each mental model
results = []
for obs in recall_result.results:
# Fetch full observation data from DB to get history, source_memory_ids, tags
for mm in recall_result.results:
# Fetch full mental model data from DB to get history, source_memory_ids, tags
row = await conn.fetchrow(
f"""
SELECT id, text, proof_count, history, tags, source_memory_ids, created_at, updated_at
FROM {fq_table("memory_units")}
WHERE id = $1 AND bank_id = $2 AND fact_type = 'observation'
WHERE id = $1 AND bank_id = $2 AND fact_type = 'mental_model'
""",
uuid.UUID(obs.id),
uuid.UUID(mm.id),
bank_id,
)
@@ -711,35 +667,32 @@ async def _find_related_observations(
async def _consolidate_with_llm(
memory_engine: "MemoryEngine",
fact_text: str,
observations: list[dict[str, Any]],
fact_tags: list[str],
mental_models: list[dict[str, Any]],
mission: str,
) -> list[dict[str, Any]]:
"""
Single LLM call to extract durable knowledge and decide on consolidation actions.
This handles ALL cases:
- No related observations: extracts durable knowledge, returns create action
- Related observations exist: compares and returns update/create actions
- No related mental models: extracts durable knowledge, returns create action
- Related models exist: compares and returns update/create actions
- Purely ephemeral fact: returns empty array
Note: Tags are NOT handled by the LLM. They are determined algorithmically:
- CREATE: observation inherits source fact's tags
- UPDATE: observation merges source fact's tags with existing tags
Returns:
List of actions, each being:
- {"action": "update", "learning_id": "uuid", "text": "...", "reason": "..."}
- {"action": "create", "text": "...", "reason": "..."}
- {"action": "create", "tags": [...], "text": "...", "reason": "..."}
- [] if fact is purely ephemeral (no durable knowledge)
"""
# Format observations WITH their tags (or "None" if empty)
if observations:
observations_text = "\n".join(
f'- ID: {obs["id"]}, Tags: {json.dumps(obs["tags"])}, Text: "{obs["text"]}" (proof_count: {obs["proof_count"]})'
for obs in observations
# Format mental models WITH their tags (or "None" if empty)
if mental_models:
mental_models_text = "\n".join(
f'- ID: {mm["id"]}, Tags: {json.dumps(mm["tags"])}, Text: "{mm["text"]}" (proof_count: {mm["proof_count"]})'
for mm in mental_models
)
else:
observations_text = "None (this is a new topic - create if fact contains durable knowledge)"
mental_models_text = "None (this is a new topic - create if fact contains durable knowledge)"
# Only include mission section if mission is set and not the default
mission_section = ""
@@ -753,7 +706,8 @@ Focus on DURABLE knowledge that serves this mission, not ephemeral state.
user_prompt = CONSOLIDATION_USER_PROMPT.format(
mission_section=mission_section,
fact_text=fact_text,
observations_text=observations_text,
fact_tags=json.dumps(fact_tags),
mental_models_text=mental_models_text,
)
messages = [
@@ -792,68 +746,65 @@ Focus on DURABLE knowledge that serves this mission, not ephemeral state.
return []
async def _create_observation_directly(
async def _create_mental_model_directly(
conn: "Connection",
memory_engine: "MemoryEngine",
bank_id: str,
source_memory_id: uuid.UUID,
observation_text: str,
mental_model_text: str,
tags: list[str] | None = None,
event_date: datetime | None = None,
occurred_start: datetime | None = None,
occurred_end: datetime | None = None,
mentioned_at: datetime | None = None,
perf: ConsolidationPerfLog | None = None,
) -> dict[str, Any]:
"""
Create an observation directly with pre-processed text (no LLM call).
Create a mental model directly with pre-processed text (no LLM call).
Used when the classify LLM has already provided the learning text.
This avoids the redundant second LLM call.
"""
# Generate embedding for the observation (convert to string for pgvector)
# Generate embedding for the mental model (convert to string for pgvector)
t0 = time.time()
embeddings = await embedding_utils.generate_embeddings_batch(memory_engine.embeddings, [observation_text])
embeddings = await embedding_utils.generate_embeddings_batch(memory_engine.embeddings, [mental_model_text])
embedding_str = str(embeddings[0]) if embeddings else None
if perf:
perf.record_timing("embedding", time.time() - t0)
# Create the observation as a memory_unit
# Create the mental model as a memory_unit
now = datetime.now(timezone.utc)
obs_event_date = event_date or now
obs_occurred_start = occurred_start or now
obs_occurred_end = occurred_end or now
obs_mentioned_at = mentioned_at or now
obs_tags = tags or []
mm_event_date = event_date or now
mm_occurred_start = occurred_start or now
mm_mentioned_at = mentioned_at or now
mm_tags = tags or []
t0 = time.time()
observation_id = uuid.uuid4()
mental_model_id = uuid.uuid4()
row = await conn.fetchrow(
f"""
INSERT INTO {fq_table("memory_units")} (
id, bank_id, text, fact_type, embedding, proof_count, source_memory_ids, history,
tags, event_date, occurred_start, occurred_end, mentioned_at
tags, event_date, occurred_start, mentioned_at
)
VALUES ($1, $2, $3, 'observation', $4::vector, 1, $5, '[]'::jsonb, $6, $7, $8, $9, $10)
VALUES ($1, $2, $3, 'mental_model', $4::vector, 1, $5, '[]'::jsonb, $6, $7, $8, $9)
RETURNING id
""",
observation_id,
mental_model_id,
bank_id,
observation_text,
mental_model_text,
embedding_str,
[source_memory_id],
obs_tags,
obs_event_date,
obs_occurred_start,
obs_occurred_end,
obs_mentioned_at,
mm_tags,
mm_event_date,
mm_occurred_start,
mm_mentioned_at,
)
# Create links between memory and observation (includes entity links, memory_links)
await _create_memory_links(conn, source_memory_id, observation_id)
# Create links between memory and mental model (includes entity links, memory_links)
await _create_memory_links(conn, source_memory_id, mental_model_id)
if perf:
perf.record_timing("db_write", time.time() - t0)
logger.debug(f"Created observation {observation_id} from memory {source_memory_id} (tags: {obs_tags})")
logger.debug(f"Created mental model {mental_model_id} from memory {source_memory_id} (tags: {mm_tags})")
return {"action": "created", "observation_id": str(row["id"]), "tags": obs_tags}
return {"action": "created", "mental_model_id": str(row["id"]), "tags": mm_tags}
@@ -1,6 +1,6 @@
"""Prompts for the consolidation engine."""
CONSOLIDATION_SYSTEM_PROMPT = """You are a memory consolidation system. Your job is to convert facts into durable knowledge (observations) and merge with existing knowledge when appropriate.
CONSOLIDATION_SYSTEM_PROMPT = """You are a memory consolidation system. Your job is to convert facts into durable knowledge (mental models) and merge with existing knowledge when appropriate.
You must output ONLY valid JSON with no markdown formatting, no code blocks, and no additional text.
@@ -30,40 +30,62 @@ BAD examples:
- "John likes pizza" -> "Understanding dietary preferences helps..." (TOO ABSTRACT)
- "User is at Room 203" -> "User is currently at Room 203" (EPHEMERAL STATE)
## MERGE RULES (when comparing to existing observations):
## MERGE RULES (when comparing to existing mental models):
1. REDUNDANT: Same information worded differently → update existing
2. CONTRADICTION: Opposite information about same topic → update with history (e.g., "used to X, now Y")
3. UPDATE: New state replacing old state → update with history
## TAG ROUTING RULES:
Tags define visibility scopes. The fact and each mental model have tags (can be empty = global).
| Fact Tags | Model Tags | Action |
|-----------|------------|--------|
| [alice] | [alice] | UPDATE the model (same scope) |
| [alice] | [] | UPDATE the model (global absorbs all scopes) |
| [alice] | [bob] | CREATE new untagged model (cross-scope insight) |
| [] | [alice] | UPDATE the model (untagged facts can update any scope) |
| [] | [] | UPDATE the model (global to global) |
When NO existing model matches the fact's topic: CREATE new model with fact's tags.
## MULTIPLE ACTIONS:
One fact can trigger MULTIPLE actions. For example:
- Update a scoped model [alice] about pizza preferences
- AND update a global model [] about pizza in general
Output an ARRAY of actions (can be empty, one, or many).
## CRITICAL RULES:
- NEVER merge facts about DIFFERENT people
- NEVER merge unrelated topics (food preferences vs work vs hobbies)
- When merging contradictions, capture the CHANGE (before → after)
- Keep observations focused on ONE specific topic per person
- The "text" field MUST contain durable knowledge, not ephemeral state
- Do NOT include "tags" in output - tags are handled automatically"""
- Keep mental models focused on ONE specific topic per person
- Cross-scope insights (alice's fact about bob's topic) become UNTAGGED (global)
- The "text" field MUST contain durable knowledge, not ephemeral state"""
CONSOLIDATION_USER_PROMPT = """Analyze this new fact and consolidate into knowledge.
{mission_section}
NEW FACT: {fact_text}
FACT TAGS: {fact_tags}
EXISTING OBSERVATIONS:
{observations_text}
EXISTING MENTAL MODELS:
{mental_models_text}
Instructions:
1. First, extract the DURABLE KNOWLEDGE from the fact (not ephemeral state like "user is at X")
2. Then compare with existing observations:
- If an observation covers the same topic: UPDATE it with the new knowledge
- If no observation covers the topic: CREATE a new one
2. Then compare with existing mental models:
- If a model covers the same topic: UPDATE it with the new knowledge
- If no model covers the topic: CREATE a new one
- If fact is about different scope: apply tag routing rules
Output JSON array of actions (ALWAYS an array, even for single action):
[
{{"action": "update", "learning_id": "uuid", "text": "updated durable knowledge", "reason": "..."}},
{{"action": "create", "text": "new durable knowledge", "reason": "..."}}
{{"action": "create", "tags": ["tag"], "text": "new durable knowledge", "reason": "..."}}
]
If NO consolidation is needed (fact is purely ephemeral with no durable knowledge):
[]
If no observations exist and fact contains durable knowledge:
[{{"action": "create", "text": "durable knowledge text", "reason": "new topic"}}]"""
If no models exist and fact contains durable knowledge:
[{{"action": "create", "tags": {fact_tags}, "text": "durable knowledge text", "reason": "new topic"}}]"""
@@ -163,101 +163,11 @@ class LocalSTCrossEncoder(CrossEncoderModel):
else:
logger.info("Reranker: local provider initialized (using existing executor)")
def _is_xpc_error(self, error: Exception) -> bool:
"""
Check if an error is an XPC connection error (macOS daemon issue).
On macOS, long-running daemons can lose XPC connections to system services
when the process is idle for extended periods.
"""
error_str = str(error).lower()
return "xpc_error_connection_invalid" in error_str or "xpc error" in error_str
def _reinitialize_model_sync(self) -> None:
"""
Clear and reinitialize the cross-encoder model synchronously.
This is used to recover from XPC errors on macOS where the
PyTorch/MPS backend loses its connection to system services.
"""
logger.warning(f"Reinitializing reranker model {self.model_name} due to backend error")
# Clear existing model
self._model = None
# Force garbage collection to free resources
import gc
import torch
gc.collect()
# If using CUDA/MPS, clear the cache
if torch.cuda.is_available():
torch.cuda.empty_cache()
elif hasattr(torch.backends, "mps") and torch.backends.mps.is_available():
try:
torch.mps.empty_cache()
except AttributeError:
pass # Method might not exist in all PyTorch versions
# Reinitialize the model
try:
from sentence_transformers import CrossEncoder
except ImportError:
raise ImportError(
"sentence-transformers is required for LocalSTCrossEncoder. "
"Install it with: pip install sentence-transformers"
)
# Determine device based on hardware availability
has_gpu = torch.cuda.is_available() or (hasattr(torch.backends, "mps") and torch.backends.mps.is_available())
if has_gpu:
device = None # Let sentence-transformers auto-detect GPU/MPS
else:
device = "cpu"
self._model = CrossEncoder(
self.model_name,
device=device,
model_kwargs={"low_cpu_mem_usage": False},
)
logger.info("Reranker: local provider reinitialized successfully")
def _predict_with_recovery(self, pairs: list[tuple[str, str]]) -> list[float]:
"""
Predict with automatic recovery from XPC errors.
This runs synchronously in the thread pool.
"""
max_retries = 1
for attempt in range(max_retries + 1):
try:
scores = self._model.predict(pairs, show_progress_bar=False)
return scores.tolist() if hasattr(scores, "tolist") else list(scores)
except Exception as e:
# Check if this is an XPC error (macOS daemon issue)
if self._is_xpc_error(e) and attempt < max_retries:
logger.warning(f"XPC error detected in reranker (attempt {attempt + 1}): {e}")
try:
self._reinitialize_model_sync()
logger.info("Reranker reinitialized successfully, retrying prediction")
continue
except Exception as reinit_error:
logger.error(f"Failed to reinitialize reranker: {reinit_error}")
raise Exception(f"Failed to recover from XPC error: {str(e)}")
else:
# Not an XPC error or out of retries
raise
async def predict(self, pairs: list[tuple[str, str]]) -> list[float]:
"""
Score query-document pairs for relevance.
Uses a dedicated thread pool with limited workers to prevent CPU thrashing.
Automatically recovers from XPC errors on macOS by reinitializing the model.
Args:
pairs: List of (query, document) tuples to score
@@ -270,11 +180,11 @@ class LocalSTCrossEncoder(CrossEncoderModel):
# Use dedicated executor - limited workers naturally limits concurrency
loop = asyncio.get_event_loop()
return await loop.run_in_executor(
scores = await loop.run_in_executor(
LocalSTCrossEncoder._executor,
self._predict_with_recovery,
pairs,
lambda: self._model.predict(pairs, show_progress_bar=False),
)
return scores.tolist() if hasattr(scores, "tolist") else list(scores)
class RemoteTEICrossEncoder(CrossEncoderModel):
@@ -151,75 +151,10 @@ class LocalSTEmbeddings(Embeddings):
self._dimension = self._model.get_sentence_embedding_dimension()
logger.info(f"Embeddings: local provider initialized (dim: {self._dimension})")
def _is_xpc_error(self, error: Exception) -> bool:
"""
Check if an error is an XPC connection error (macOS daemon issue).
On macOS, long-running daemons can lose XPC connections to system services
when the process is idle for extended periods.
"""
error_str = str(error).lower()
return "xpc_error_connection_invalid" in error_str or "xpc error" in error_str
def _reinitialize_model_sync(self) -> None:
"""
Clear and reinitialize the embedding model synchronously.
This is used to recover from XPC errors on macOS where the
PyTorch/MPS backend loses its connection to system services.
"""
logger.warning(f"Reinitializing embedding model {self.model_name} due to backend error")
# Clear existing model
self._model = None
# Force garbage collection to free resources
import gc
import torch
gc.collect()
# If using CUDA/MPS, clear the cache
if torch.cuda.is_available():
torch.cuda.empty_cache()
elif hasattr(torch.backends, "mps") and torch.backends.mps.is_available():
try:
torch.mps.empty_cache()
except AttributeError:
pass # Method might not exist in all PyTorch versions
# Reinitialize the model (inline version of initialize() but synchronous)
try:
from sentence_transformers import SentenceTransformer
except ImportError:
raise ImportError(
"sentence-transformers is required for LocalSTEmbeddings. "
"Install it with: pip install sentence-transformers"
)
# Determine device based on hardware availability
has_gpu = torch.cuda.is_available() or (hasattr(torch.backends, "mps") and torch.backends.mps.is_available())
if has_gpu:
device = None # Let sentence-transformers auto-detect GPU/MPS
else:
device = "cpu"
self._model = SentenceTransformer(
self.model_name,
device=device,
model_kwargs={"low_cpu_mem_usage": False},
)
logger.info("Embeddings: local provider reinitialized successfully")
def encode(self, texts: list[str]) -> list[list[float]]:
"""
Generate embeddings for a list of texts.
Automatically recovers from XPC errors on macOS by reinitializing the model.
Args:
texts: List of text strings to encode
@@ -228,27 +163,8 @@ class LocalSTEmbeddings(Embeddings):
"""
if self._model is None:
raise RuntimeError("Embeddings not initialized. Call initialize() first.")
# Try encoding with automatic recovery from XPC errors
max_retries = 1
for attempt in range(max_retries + 1):
try:
embeddings = self._model.encode(texts, convert_to_numpy=True, show_progress_bar=False)
return [emb.tolist() for emb in embeddings]
except Exception as e:
# Check if this is an XPC error (macOS daemon issue)
if self._is_xpc_error(e) and attempt < max_retries:
logger.warning(f"XPC error detected in embedding generation (attempt {attempt + 1}): {e}")
try:
self._reinitialize_model_sync()
logger.info("Model reinitialized successfully, retrying embedding generation")
continue
except Exception as reinit_error:
logger.error(f"Failed to reinitialize model: {reinit_error}")
raise Exception(f"Failed to recover from XPC error: {str(e)}")
else:
# Not an XPC error or out of retries
raise
embeddings = self._model.encode(texts, convert_to_numpy=True, show_progress_bar=False)
return [emb.tolist() for emb in embeddings]
class RemoteTEIEmbeddings(Embeddings):
File diff suppressed because it is too large Load Diff
@@ -4,15 +4,17 @@ Reflect agent module for agentic reflection with tools.
The reflect agent uses an iterative loop with tools to:
1. Lookup mental models (existing knowledge)
2. Recall facts (semantic + temporal search)
3. Expand memories (get chunk/document context)
3. Learn new insights (create/update mental models)
4. Expand memories (get chunk/document context)
"""
from .agent import ReflectAgentResult, run_reflect_agent
from .models import ReflectAction, ReflectActionBatch
from .models import MentalModelInput, ReflectAction, ReflectActionBatch
__all__ = [
"run_reflect_agent",
"ReflectAgentResult",
"ReflectAction",
"ReflectActionBatch",
"MentalModelInput",
]
@@ -2,8 +2,8 @@
Reflect agent - agentic loop for reflection with native tool calling.
Uses hierarchical retrieval:
1. search_mental_models - User-curated summaries (highest quality)
2. search_observations - Consolidated knowledge with freshness
1. search_reflections - User-curated summaries (highest quality)
2. search_mental_models - Consolidated knowledge with freshness
3. recall - Raw facts as ground truth
"""
@@ -20,12 +20,7 @@ from .tools_schema import get_reflect_tools
def _build_directives_applied(directives: list[dict[str, Any]] | None) -> list[DirectiveInfo]:
"""Build list of DirectiveInfo from directive mental models.
Handles multiple directive formats:
1. New format: directives have direct 'content' field
2. Fallback: directives have 'description' field
"""
"""Build list of DirectiveInfo from directive mental models."""
if not directives:
return []
@@ -33,11 +28,17 @@ def _build_directives_applied(directives: list[dict[str, Any]] | None) -> list[D
for directive in directives:
directive_id = directive.get("id", "")
directive_name = directive.get("name", "")
observations = directive.get("observations", [])
# Get content from 'content' field or fallback to 'description'
content = directive.get("content", "") or directive.get("description", "")
rules = []
for obs in observations:
# Support both Pydantic Observation objects and dicts
if hasattr(obs, "content"):
rules.append(obs.content)
elif isinstance(obs, dict) and obs.get("content"):
rules.append(obs["content"])
result.append(DirectiveInfo(id=directive_id, name=directive_name, content=content))
result.append(DirectiveInfo(id=directive_id, name=directive_name, rules=rules))
return result
@@ -80,18 +81,6 @@ def _is_done_tool(name: str) -> bool:
# Pattern to match done() call as text - handles done({...}) with nested JSON
_DONE_CALL_PATTERN = re.compile(r"done\s*\(\s*\{.*$", re.DOTALL)
# Patterns for leaked structured output in the answer field
_LEAKED_JSON_SUFFIX = re.compile(
r'\s*```(?:json)?\s*\{[^}]*(?:"(?:observation_ids|memory_ids|mental_model_ids)"|\})\s*```\s*$',
re.DOTALL | re.IGNORECASE,
)
_LEAKED_JSON_OBJECT = re.compile(
r'\s*\{[^{]*"(?:observation_ids|memory_ids|mental_model_ids|answer)"[^}]*\}\s*$', re.DOTALL
)
_TRAILING_IDS_PATTERN = re.compile(
r"\s*(?:observation_ids|memory_ids|mental_model_ids)\s*[=:]\s*\[.*?\]\s*$", re.DOTALL | re.IGNORECASE
)
def _clean_answer_text(text: str) -> str:
"""Clean up answer text by removing any done() tool call syntax.
@@ -104,33 +93,6 @@ def _clean_answer_text(text: str) -> str:
return cleaned if cleaned else text
def _clean_done_answer(text: str) -> str:
"""Clean up the answer field from a done() tool call.
Some LLMs leak structured output patterns into the answer text, such as:
- JSON code blocks with observation_ids/memory_ids at the end
- Raw JSON objects with these fields
- Plain text like "observation_ids: [...]"
This cleans those patterns while preserving the actual answer content.
"""
if not text:
return text
cleaned = text
# Remove leaked JSON in code blocks at the end
cleaned = _LEAKED_JSON_SUFFIX.sub("", cleaned).strip()
# Remove leaked raw JSON objects at the end
cleaned = _LEAKED_JSON_OBJECT.sub("", cleaned).strip()
# Remove trailing ID patterns
cleaned = _TRAILING_IDS_PATTERN.sub("", cleaned).strip()
return cleaned if cleaned else text
async def _generate_structured_output(
answer: str,
response_schema: dict,
@@ -180,55 +142,35 @@ async def _generate_structured_output(
fields[field_name] = (field_type, default)
if not fields:
logger.warning(f"[REFLECT {reflect_id}] No fields found in response_schema, skipping structured output")
return None, 0, 0
return None
DynamicModel = create_model("StructuredResponse", **fields)
# Include the full schema in the prompt for better LLM guidance
schema_str = json.dumps(response_schema, indent=2)
# Build field descriptions for the prompt
field_descriptions = []
for field_name, field_schema in schema_props.items():
field_type = field_schema.get("type", "string")
field_desc = field_schema.get("description", "")
is_required = field_name in required_fields
req_marker = " (REQUIRED)" if is_required else " (optional)"
field_descriptions.append(f"- {field_name} ({field_type}){req_marker}: {field_desc}")
fields_text = "\n".join(field_descriptions)
# Call LLM with the answer to extract structured data
structured_prompt = f"""Your task is to extract specific information from the answer below and format it as JSON.
structured_prompt = f"""Based on this answer, extract the information into the requested structured format.
ANSWER TO EXTRACT FROM:
\"\"\"
{answer}
\"\"\"
Answer: {answer}
REQUIRED OUTPUT FORMAT - Extract the following fields from the answer above:
{fields_text}
JSON Schema:
JSON Schema to follow:
```json
{schema_str}
```
INSTRUCTIONS:
1. Read the answer carefully and identify the information that matches each field
2. Extract the ACTUAL content from the answer - do NOT leave fields empty if information is present
3. For string fields: use the exact text or a clear summary from the answer
4. For array fields: return a JSON array (e.g., ["item1", "item2"]), NOT a string
5. For required fields: you MUST provide a value extracted from the answer
6. Return ONLY the JSON object, no explanation
Return ONLY a valid JSON object that matches this exact schema. Pay special attention to field types:
- "type": "array" means the value must be a JSON array/list, NOT a string
- "type": "string" means the value must be a string
- "type": "object" means the value must be a JSON object
OUTPUT:"""
Do not include any explanation, only the JSON object."""
structured_result, usage = await llm_config.call(
messages=[
{
"role": "system",
"content": "You are a precise data extraction assistant. Extract information from text and return it as valid JSON matching the provided schema. Always extract actual content - never return empty strings for required fields if information is available.",
"content": "Extract structured data from the given answer. Return only valid JSON matching the provided schema exactly.",
},
{"role": "user", "content": structured_prompt},
],
@@ -247,12 +189,6 @@ OUTPUT:"""
# Try to parse as JSON
structured_output = json.loads(str(structured_result))
# Validate that required fields have non-empty values
for field_name in required_fields:
value = structured_output.get(field_name)
if value is None or value == "" or value == []:
logger.warning(f"[REFLECT {reflect_id}] Required field '{field_name}' is empty in structured output")
logger.info(f"[REFLECT {reflect_id}] Generated structured output with {len(structured_output)} fields")
return structured_output, usage.input_tokens, usage.output_tokens
@@ -266,8 +202,8 @@ async def run_reflect_agent(
bank_id: str,
query: str,
bank_profile: dict[str, Any],
search_reflections_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
search_mental_models_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
search_observations_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
recall_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
expand_fn: Callable[[list[str], str], Awaitable[dict[str, Any]]],
context: str | None = None,
@@ -275,15 +211,13 @@ async def run_reflect_agent(
max_tokens: int | None = None,
response_schema: dict | None = None,
directives: list[dict[str, Any]] | None = None,
has_mental_models: bool = False,
budget: str | None = None,
) -> ReflectAgentResult:
"""
Execute the reflect agent loop using native tool calling.
The agent uses hierarchical retrieval:
1. search_mental_models - User-curated summaries (try first)
2. search_observations - Consolidated knowledge with freshness
1. search_reflections - User-curated summaries (try first)
2. search_mental_models - Consolidated knowledge with freshness
3. recall - Raw facts as ground truth
Args:
@@ -291,8 +225,8 @@ async def run_reflect_agent(
bank_id: Bank identifier
query: Question to answer
bank_profile: Bank profile with name and mission
search_reflections_fn: Tool callback for searching reflections (query, max_results) -> result
search_mental_models_fn: Tool callback for searching mental models (query, max_results) -> result
search_observations_fn: Tool callback for searching observations (query, max_results) -> result
recall_fn: Tool callback for recall (query, max_tokens) -> result
expand_fn: Tool callback for expand (memory_ids, depth) -> result
context: Optional additional context
@@ -317,9 +251,7 @@ async def run_reflect_agent(
tools = get_reflect_tools(directive_rules=directive_rules)
# Build initial messages (directives are injected into system prompt at START and END)
system_prompt = build_system_prompt_for_tools(
bank_profile, context, directives=directives, has_mental_models=has_mental_models, budget=budget
)
system_prompt = build_system_prompt_for_tools(bank_profile, context, directives=directives)
messages: list[dict[str, Any]] = [
{"role": "system", "content": system_prompt},
{"role": "user", "content": query},
@@ -338,8 +270,8 @@ async def run_reflect_agent(
# Track available IDs for validation (prevents hallucinated citations)
available_memory_ids: set[str] = set()
available_reflection_ids: set[str] = set()
available_mental_model_ids: set[str] = set()
available_observation_ids: set[str] = set()
def _get_llm_trace() -> list[LLMCall]:
return [
@@ -462,7 +394,7 @@ async def run_reflect_agent(
llm_trace.append({"scope": f"agent_{iteration + 1}_err", "duration_ms": err_duration})
# Guardrail: If no evidence gathered yet, retry
has_gathered_evidence = (
bool(available_memory_ids) or bool(available_mental_model_ids) or bool(available_observation_ids)
bool(available_memory_ids) or bool(available_reflection_ids) or bool(available_mental_model_ids)
)
if not has_gathered_evidence and iteration < max_iterations - 1:
continue
@@ -587,7 +519,7 @@ async def run_reflect_agent(
if done_call:
# Guardrail: Require evidence before done
has_gathered_evidence = (
bool(available_memory_ids) or bool(available_mental_model_ids) or bool(available_observation_ids)
bool(available_memory_ids) or bool(available_reflection_ids) or bool(available_mental_model_ids)
)
if not has_gathered_evidence and iteration < max_iterations - 1:
# Add assistant message and fake tool result asking for evidence
@@ -604,7 +536,7 @@ async def run_reflect_agent(
"name": done_call.name, # Required by Gemini
"content": json.dumps(
{
"error": "You must search for information first. Use search_mental_models(), search_observations(), or recall() before providing your final answer."
"error": "You must search for information first. Use search_reflections(), search_mental_models(), or recall() before providing your final answer."
}
),
}
@@ -615,8 +547,8 @@ async def run_reflect_agent(
return await _process_done_tool(
done_call,
available_memory_ids,
available_reflection_ids,
available_mental_model_ids,
available_observation_ids,
iteration + 1,
total_tools_called,
tool_trace,
@@ -644,8 +576,8 @@ async def run_reflect_agent(
tool_tasks = [
_execute_tool_with_timing(
tc,
search_reflections_fn,
search_mental_models_fn,
search_observations_fn,
recall_fn,
expand_fn,
)
@@ -674,6 +606,15 @@ async def run_reflect_agent(
)
# Track available IDs from tool results (only for successful responses)
if (
normalized_tool_name == "search_reflections"
and isinstance(output, dict)
and "reflections" in output
):
for reflection in output["reflections"]:
if "id" in reflection:
available_reflection_ids.add(reflection["id"])
if (
normalized_tool_name == "search_mental_models"
and isinstance(output, dict)
@@ -683,15 +624,6 @@ async def run_reflect_agent(
if "id" in mm:
available_mental_model_ids.add(mm["id"])
if (
normalized_tool_name == "search_observations"
and isinstance(output, dict)
and "observations" in output
):
for obs in output["observations"]:
if "id" in obs:
available_observation_ids.add(obs["id"])
if normalized_tool_name == "recall" and isinstance(output, dict) and "memories" in output:
for memory in output["memories"]:
if "id" in memory:
@@ -711,17 +643,9 @@ async def run_reflect_agent(
input_dict = {"tool": tc.name, **tc.arguments}
input_summary = _summarize_input(tc.name, tc.arguments)
# Extract reason from tool arguments (if provided)
tool_reason = tc.arguments.get("reason")
tool_trace.append(
ToolCall(
tool=tc.name,
reason=tool_reason,
input=input_dict,
output=output,
duration_ms=duration_ms,
iteration=iteration + 1,
tool=tc.name, input=input_dict, output=output, duration_ms=duration_ms, iteration=iteration + 1
)
)
@@ -771,8 +695,8 @@ def _tool_call_to_dict(tc: "LLMToolCall") -> dict[str, Any]:
async def _process_done_tool(
done_call: "LLMToolCall",
available_memory_ids: set[str],
available_reflection_ids: set[str],
available_mental_model_ids: set[str],
available_observation_ids: set[str],
iterations: int,
total_tools_called: int,
tool_trace: list[ToolCall],
@@ -787,16 +711,14 @@ async def _process_done_tool(
"""Process the done tool call and return the result."""
args = done_call.arguments
# Extract and clean the answer - some LLMs leak structured output into the answer text
raw_answer = args.get("answer", "").strip()
answer = _clean_done_answer(raw_answer) if raw_answer else ""
answer = args.get("answer", "").strip()
if not answer:
answer = "No answer provided."
# Validate IDs (only include IDs that were actually retrieved)
used_memory_ids = [mid for mid in args.get("memory_ids", []) if mid in available_memory_ids]
used_reflection_ids = [rid for rid in args.get("reflection_ids", []) if rid in available_reflection_ids]
used_mental_model_ids = [mid for mid in args.get("mental_model_ids", []) if mid in available_mental_model_ids]
used_observation_ids = [oid for oid in args.get("observation_ids", []) if oid in available_observation_ids]
# Generate structured output if schema provided
structured_output = None
@@ -822,16 +744,16 @@ async def _process_done_tool(
llm_trace=llm_trace,
usage=final_usage,
used_memory_ids=used_memory_ids,
used_reflection_ids=used_reflection_ids,
used_mental_model_ids=used_mental_model_ids,
used_observation_ids=used_observation_ids,
directives_applied=directives_applied,
)
async def _execute_tool_with_timing(
tc: "LLMToolCall",
search_reflections_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
search_mental_models_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
search_observations_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
recall_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
expand_fn: Callable[[list[str], str], Awaitable[dict[str, Any]]],
) -> tuple[dict[str, Any], int]:
@@ -840,8 +762,8 @@ async def _execute_tool_with_timing(
result = await _execute_tool(
tc.name,
tc.arguments,
search_reflections_fn,
search_mental_models_fn,
search_observations_fn,
recall_fn,
expand_fn,
)
@@ -852,8 +774,8 @@ async def _execute_tool_with_timing(
async def _execute_tool(
tool_name: str,
args: dict[str, Any],
search_reflections_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
search_mental_models_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
search_observations_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
recall_fn: Callable[[str, int], Awaitable[dict[str, Any]]],
expand_fn: Callable[[list[str], str], Awaitable[dict[str, Any]]],
) -> dict[str, Any]:
@@ -861,19 +783,19 @@ async def _execute_tool(
# Normalize tool name for various LLM output formats
tool_name = _normalize_tool_name(tool_name)
if tool_name == "search_mental_models":
if tool_name == "search_reflections":
query = args.get("query")
if not query:
return {"error": "search_reflections requires a query parameter"}
max_results = args.get("max_results") or 5
return await search_reflections_fn(query, max_results)
elif tool_name == "search_mental_models":
query = args.get("query")
if not query:
return {"error": "search_mental_models requires a query parameter"}
max_results = args.get("max_results") or 5
return await search_mental_models_fn(query, max_results)
elif tool_name == "search_observations":
query = args.get("query")
if not query:
return {"error": "search_observations requires a query parameter"}
max_tokens = max(args.get("max_tokens") or 5000, 1000) # Default 5000, min 1000
return await search_observations_fn(query, max_tokens)
return await search_mental_models_fn(query, max_tokens)
elif tool_name == "recall":
query = args.get("query")
@@ -895,12 +817,12 @@ async def _execute_tool(
def _summarize_input(tool_name: str, args: dict[str, Any]) -> str:
"""Create a summary of tool input for logging, showing all params."""
if tool_name == "search_mental_models":
if tool_name == "search_reflections":
query = args.get("query", "")
query_preview = f"'{query[:30]}...'" if len(query) > 30 else f"'{query}'"
max_results = args.get("max_results") or 5
return f"(query={query_preview}, max_results={max_results})"
elif tool_name == "search_observations":
elif tool_name == "search_mental_models":
query = args.get("query", "")
query_preview = f"'{query[:30]}...'" if len(query) > 30 else f"'{query}'"
max_tokens = max(args.get("max_tokens") or 5000, 1000)
@@ -919,9 +841,9 @@ def _summarize_input(tool_name: str, args: dict[str, Any]) -> str:
answer = args.get("answer", "")
answer_preview = f"'{answer[:30]}...'" if len(answer) > 30 else f"'{answer}'"
memory_ids = args.get("memory_ids", [])
reflection_ids = args.get("reflection_ids", [])
mental_model_ids = args.get("mental_model_ids", [])
observation_ids = args.get("observation_ids", [])
return (
f"(answer={answer_preview}, mem={len(memory_ids)}, mm={len(mental_model_ids)}, obs={len(observation_ids)})"
f"(answer={answer_preview}, mem={len(memory_ids)}, ref={len(reflection_ids)}, mm={len(mental_model_ids)})"
)
return str(args)
@@ -7,28 +7,51 @@ from typing import Any, Literal
from pydantic import BaseModel, Field
class ObservationSection(BaseModel):
"""A section within an observation with its supporting memories."""
class MentalModelObservation(BaseModel):
"""An observation within a mental model with its supporting memories."""
title: str = Field(description="Section header (can be empty for intro)")
text: str = Field(description="Section content - no headers, use lists/tables/bold")
title: str = Field(description="Observation header (can be empty for intro)")
text: str = Field(description="Observation content - no headers, use lists/tables/bold")
memory_ids: list[str] = Field(default_factory=list, description="Memory IDs supporting this observation")
class MentalModelInput(BaseModel):
"""Input for the learn tool to create a mental model placeholder.
The agent only specifies name and description - the actual content/observations
are generated during refresh, similar to pinned models.
"""
name: str = Field(description="Human-readable name for the mental model")
description: str = Field(description="What to track - used as prompt for content generation during refresh")
entity_id: str | None = Field(default=None, description="Optional link to existing entity ID")
class AnswerSection(BaseModel):
"""A section of the answer with its supporting evidence (DEPRECATED)."""
title: str = Field(description="Section header/title")
text: str = Field(description="Section content")
memory_ids: list[str] = Field(default_factory=list, description="Memory IDs supporting this section")
model_ids: list[str] = Field(default_factory=list, description="Mental model IDs supporting this section")
class ReflectAction(BaseModel):
"""Single action the reflect agent can take."""
tool: Literal["list_observations", "get_observation", "recall", "expand", "done"] = Field(
description="Tool to invoke: list_observations, get_observation, recall, expand, or done"
tool: Literal["list_mental_models", "get_mental_model", "recall", "learn", "expand", "done"] = Field(
description="Tool to invoke: list_mental_models, get_mental_model, recall, learn, expand, or done"
)
# Tool-specific parameters
observation_id: str | None = Field(default=None, description="Observation ID for get_observation")
model_id: str | None = Field(default=None, description="Mental model ID for get_mental_model")
query: str | None = Field(default=None, description="Search query for recall")
max_tokens: int | None = Field(default=None, description="Max tokens for recall results (default 2048)")
mental_model: MentalModelInput | None = Field(default=None, description="Mental model to create/update for learn")
memory_ids: list[str] | None = Field(default=None, description="Memory unit IDs for expand (batched)")
depth: Literal["chunk", "document"] | None = Field(default=None, description="Expansion depth for expand")
observation_sections: list[ObservationSection] | None = Field(
default=None, description="Observation sections for done action (when output_mode=observations)"
sections: list[AnswerSection] | None = Field(default=None, description="DEPRECATED: Use answer field instead")
observations: list[MentalModelObservation] | None = Field(
default=None, description="Observations for done action (when output_mode=observations)"
)
# Plain text answer fields (for output_mode=answer)
answer: str | None = Field(default=None, description="Plain text answer for done action (no markdown)")
@@ -50,8 +73,7 @@ class ReflectActionBatch(BaseModel):
class ToolCall(BaseModel):
"""A single tool call made during reflect."""
tool: str = Field(description="Tool name: lookup, recall, expand")
reason: str | None = Field(default=None, description="Agent's reasoning for making this tool call")
tool: str = Field(description="Tool name: lookup, recall, learn, expand")
input: dict = Field(description="Tool input parameters")
output: dict = Field(description="Tool output/result")
duration_ms: int = Field(description="Execution time in milliseconds")
@@ -72,7 +94,7 @@ class DirectiveInfo(BaseModel):
id: str = Field(description="Directive mental model ID")
name: str = Field(description="Directive name")
content: str = Field(description="Directive content")
rules: list[str] = Field(default_factory=list, description="Directive rules/observations that were applied")
class TokenUsageSummary(BaseModel):
@@ -98,12 +120,12 @@ class ReflectAgentResult(BaseModel):
default_factory=TokenUsageSummary, description="Total token usage across all LLM calls"
)
used_memory_ids: list[str] = Field(default_factory=list, description="Validated memory IDs actually used in answer")
used_reflection_ids: list[str] = Field(
default_factory=list, description="Validated reflection IDs actually used in answer"
)
used_mental_model_ids: list[str] = Field(
default_factory=list, description="Validated mental model IDs actually used in answer"
)
used_observation_ids: list[str] = Field(
default_factory=list, description="Validated observation IDs actually used in answer"
)
directives_applied: list[DirectiveInfo] = Field(
default_factory=list, description="Directive mental models that affected this reflection"
)
@@ -2,8 +2,8 @@
System prompts for the reflect agent.
The reflect agent uses hierarchical retrieval:
1. search_mental_models - User-curated summaries (highest quality)
2. search_observations - Consolidated knowledge with freshness awareness
1. search_reflections - User-curated summaries (highest quality)
2. search_mental_models - Consolidated knowledge with freshness awareness
3. recall - Raw facts as ground truth fallback
"""
@@ -125,23 +125,21 @@ def build_system_prompt_for_tools(
bank_profile: dict[str, Any],
context: str | None = None,
directives: list[dict[str, Any]] | None = None,
has_mental_models: bool = False,
budget: str | None = None,
has_reflections: bool = False,
) -> str:
"""
Build the system prompt for tool-calling reflect agent.
The agent uses hierarchical retrieval:
1. search_mental_models - User-curated summaries (try first, if available)
2. search_observations - Consolidated knowledge with freshness
1. search_reflections - User-curated summaries (try first, if available)
2. search_mental_models - Consolidated knowledge with freshness
3. recall - Raw facts as ground truth
Args:
bank_profile: Bank profile with name and mission
context: Optional additional context
directives: Optional list of directive mental models to inject as hard rules
has_mental_models: Whether the bank has any mental models (skip if not)
budget: Search depth budget - "low", "mid", or "high". Controls exploration thoroughness.
has_reflections: Whether the bank has any reflections (skip if not)
"""
name = bank_profile.get("name", "Assistant")
mission = bank_profile.get("mission", "")
@@ -178,25 +176,25 @@ def build_system_prompt_for_tools(
)
# Build retrieval levels based on what's available
if has_mental_models:
if has_reflections:
parts.extend(
[
"You have access to THREE levels of knowledge. Use them in this order:",
"",
"### 1. MENTAL MODELS (search_mental_models) - Try First",
"### 1. REFLECTIONS (search_reflections) - Try First",
"- User-curated summaries about specific topics",
"- HIGHEST quality - manually created and maintained",
"- If a relevant mental model exists and is FRESH, it may fully answer the question",
"- If a relevant reflection exists and is FRESH, it may fully answer the question",
"- Check `is_stale` field - if stale, also verify with lower levels",
"",
"### 2. OBSERVATIONS (search_observations) - Second Priority",
"### 2. MENTAL MODELS (search_mental_models) - Second Priority",
"- Auto-consolidated knowledge from memories",
"- Check `is_stale` field - if stale, ALSO use recall() to verify",
"- Good for understanding patterns and summaries",
"",
"### 3. RAW FACTS (recall) - Ground Truth",
"- Individual memories (world facts and experiences)",
"- Use when: no mental models/observations exist, they're stale, or you need specific details",
"- Use when: no reflections/models exist, they're stale, or you need specific details",
"- This is the source of truth that other levels are built from",
"",
]
@@ -206,15 +204,15 @@ def build_system_prompt_for_tools(
[
"You have access to TWO levels of knowledge. Use them in this order:",
"",
"### 1. OBSERVATIONS (search_observations) - Try First",
"### 1. MENTAL MODELS (search_mental_models) - Try First",
"- Auto-consolidated knowledge from memories",
"- Check `is_stale` field - if stale, ALSO use recall() to verify",
"- Good for understanding patterns and summaries",
"",
"### 2. RAW FACTS (recall) - Ground Truth",
"- Individual memories (world facts and experiences)",
"- Use when: no observations exist, they're stale, or you need specific details",
"- This is the source of truth that observations are built from",
"- Use when: no mental models exist, they're stale, or you need specific details",
"- This is the source of truth that mental models are built from",
"",
]
)
@@ -232,57 +230,16 @@ def build_system_prompt_for_tools(
"",
"Think: What ENTITIES and CONCEPTS does this question involve? Search for each separately.",
"",
"## Workflow",
]
)
# Add budget guidance
if budget:
budget_lower = budget.lower()
if budget_lower == "low":
parts.extend(
[
"## RESEARCH DEPTH: SHALLOW (Quick Response)",
"- Prioritize speed over completeness",
"- If mental models or observations provide a reasonable answer, stop there",
"- Only dig deeper if the initial results are clearly insufficient",
"- Prefer a quick overview rather than exhaustive details",
"- Answer promptly with available information",
"",
]
)
elif budget_lower == "mid":
parts.extend(
[
"## RESEARCH DEPTH: MODERATE (Balanced)",
"- Balance thoroughness with efficiency",
"- Check multiple sources when the question warrants it",
"- Verify stale data if it's central to the answer",
"- Don't over-explore, but ensure reasonable coverage",
"",
]
)
elif budget_lower == "high":
parts.extend(
[
"## RESEARCH DEPTH: DEEP (Thorough Exploration)",
"- Explore comprehensively before answering",
"- Search across all available knowledge levels",
"- Use multiple query variations to ensure coverage",
"- Verify information across different retrieval levels",
"- Use expand() to get full context on important memories",
"- Take time to synthesize a complete, well-researched answer",
"",
]
)
parts.append("## Workflow")
if has_mental_models:
if has_reflections:
parts.extend(
[
"1. First, try search_mental_models() - check if a curated summary exists",
"2. If no mental model or it's stale, try search_observations() for consolidated knowledge",
"3. If observations are stale OR you need specific details, use recall() for raw facts",
"1. First, try search_reflections() - check if a curated summary exists",
"2. If no reflection or it's stale, try search_mental_models() for consolidated knowledge",
"3. If mental models are stale OR you need specific details, use recall() for raw facts",
"4. Use expand() if you need more context on specific memories",
"5. When ready, call done() with your answer and supporting IDs",
]
@@ -290,8 +247,8 @@ def build_system_prompt_for_tools(
else:
parts.extend(
[
"1. First, try search_observations() - check for consolidated knowledge",
"2. If observations are stale OR you need specific details, use recall() for raw facts",
"1. First, try search_mental_models() - check for consolidated knowledge",
"2. If mental models are stale OR you need specific details, use recall() for raw facts",
"3. Use expand() if you need more context on specific memories",
"4. When ready, call done() with your answer and supporting IDs",
]
@@ -304,7 +261,7 @@ def build_system_prompt_for_tools(
"Call done() with a plain text 'answer' field.",
"- Do NOT use markdown formatting",
"- NEVER include memory IDs, UUIDs, or 'Memory references' in the answer text",
"- Put IDs ONLY in the memory_ids/mental_model_ids/observation_ids arrays, not in the answer",
"- Put IDs ONLY in the memory_ids/reflection_ids/mental_model_ids arrays, not in the answer",
]
)
@@ -399,8 +356,8 @@ def build_agent_prompt(
parts.append(
"\n## Instructions\n"
"Start by searching for relevant information using the hierarchical retrieval strategy:\n"
"1. Try search_mental_models() first for curated summaries\n"
"2. Try search_observations() for consolidated knowledge\n"
"1. Try search_reflections() first for curated summaries\n"
"2. Try search_mental_models() for consolidated knowledge\n"
"3. Use recall() for specific details or to verify stale data"
)
@@ -2,8 +2,8 @@
Tool implementations for the reflect agent.
Implements hierarchical retrieval:
1. search_mental_models - User-curated stored reflect responses (highest quality)
2. search_observations - Consolidated knowledge with freshness
1. search_reflections - User-curated summaries (highest quality)
2. search_mental_models - Consolidated knowledge with freshness
3. recall - Raw facts as ground truth
"""
@@ -20,11 +20,11 @@ if TYPE_CHECKING:
logger = logging.getLogger(__name__)
# Observation is considered stale if not updated in this many days
# Mental model is considered stale if not updated in this many days
STALE_THRESHOLD_DAYS = 7
async def tool_search_mental_models(
async def tool_search_reflections(
conn: "Connection",
bank_id: str,
query: str,
@@ -35,9 +35,9 @@ async def tool_search_mental_models(
exclude_ids: list[str] | None = None,
) -> dict[str, Any]:
"""
Search user-curated mental models by semantic similarity.
Search user-curated reflections by semantic similarity.
Mental models are high-quality, manually created summaries about specific topics.
Reflections are high-quality, manually created summaries about specific topics.
They should be searched FIRST as they represent the most reliable synthesized knowledge.
Args:
@@ -45,13 +45,13 @@ async def tool_search_mental_models(
bank_id: Bank identifier
query: Search query (for logging/tracing)
query_embedding: Pre-computed embedding for semantic search
max_results: Maximum number of mental models to return
tags: Optional tags to filter mental models
max_results: Maximum number of reflections to return
tags: Optional tags to filter reflections
tags_match: How to match tags - "any" (OR), "all" (AND)
exclude_ids: Optional list of mental model IDs to exclude (e.g., when refreshing a mental model)
exclude_ids: Optional list of reflection IDs to exclude (e.g., when refreshing a reflection)
Returns:
Dict with matching mental models including content and freshness info
Dict with matching reflections including content and freshness info
"""
from ..memory_engine import fq_table
@@ -73,14 +73,14 @@ async def tool_search_mental_models(
params.append(exclude_ids)
next_param += 1
# Search mental models by embedding similarity
# Search reflections by embedding similarity
rows = await conn.fetch(
f"""
SELECT
id, name, content,
id, name, content, reflect_response,
tags, created_at, last_refreshed_at,
1 - (embedding <=> $2::vector) as relevance
FROM {fq_table("mental_models")}
FROM {fq_table("reflections")}
WHERE bank_id = $1 AND embedding IS NOT NULL {filters}
ORDER BY embedding <=> $2::vector
LIMIT $3
@@ -89,7 +89,7 @@ async def tool_search_mental_models(
)
now = datetime.now(timezone.utc)
mental_models = []
reflections = []
for row in rows:
last_refreshed_at = row["last_refreshed_at"]
@@ -102,11 +102,12 @@ async def tool_search_mental_models(
age = now - last_refreshed_at
is_stale = age > timedelta(days=STALE_THRESHOLD_DAYS)
mental_models.append(
reflections.append(
{
"id": str(row["id"]),
"name": row["name"],
"content": row["content"],
"reflect_response": row["reflect_response"],
"tags": row["tags"] or [],
"relevance": round(row["relevance"], 4),
"updated_at": last_refreshed_at.isoformat() if last_refreshed_at else None,
@@ -116,12 +117,12 @@ async def tool_search_mental_models(
return {
"query": query,
"count": len(mental_models),
"mental_models": mental_models,
"count": len(reflections),
"reflections": reflections,
}
async def tool_search_observations(
async def tool_search_mental_models(
memory_engine: "MemoryEngine",
bank_id: str,
query: str,
@@ -133,9 +134,9 @@ async def tool_search_observations(
pending_consolidation: int = 0,
) -> dict[str, Any]:
"""
Search consolidated observations using recall with include_observations.
Search consolidated mental models using recall with include_mental_models.
Observations are auto-generated from memories. Returns freshness info
Mental models are auto-generated from memories. Returns freshness info
so the agent knows if it should also verify with recall().
Args:
@@ -144,22 +145,22 @@ async def tool_search_observations(
query: Search query
request_context: Request context for authentication
max_tokens: Maximum tokens for results (default 5000)
tags: Optional tags to filter observations
tags: Optional tags to filter models
tags_match: How to match tags - "any" (OR), "all" (AND)
last_consolidated_at: When consolidation last ran (for staleness check)
pending_consolidation: Number of memories waiting to be consolidated
Returns:
Dict with matching observations including freshness info
Dict with matching mental models including freshness info
"""
from ..memory_engine import fq_table
# Use recall to search observations (they come back in results field when fact_type=["observation"])
# Use recall to search mental models (they come back in results field when fact_type=["mental_model"])
result = await memory_engine.recall_async(
bank_id=bank_id,
query=query,
fact_type=["observation"], # Only retrieve observations
max_tokens=max_tokens, # Token budget controls how many observations are returned
fact_type=["mental_model"], # Only retrieve mental models
max_tokens=max_tokens, # Token budget controls how many mental models are returned
enable_trace=False,
request_context=request_context,
tags=tags,
@@ -168,29 +169,29 @@ async def tool_search_observations(
_quiet=True,
)
observations = []
mental_models = []
# When fact_type=["observation"], results come back in `results` field as MemoryFact objects
# When fact_type=["mental_model"], results come back in `results` field as MemoryFact objects
# We need to fetch additional fields (proof_count, source_memory_ids) from the database
if result.results:
obs_ids = [m.id for m in result.results]
mm_ids = [m.id for m in result.results]
# Fetch proof_count and source_memory_ids for these observations
# Fetch proof_count and source_memory_ids for these mental models
pool = await memory_engine._get_pool()
async with pool.acquire() as conn:
obs_rows = await conn.fetch(
mm_rows = await conn.fetch(
f"""
SELECT id, proof_count, source_memory_ids
FROM {fq_table("memory_units")}
WHERE id = ANY($1::uuid[])
""",
obs_ids,
mm_ids,
)
obs_data = {str(row["id"]): row for row in obs_rows}
mm_data = {str(row["id"]): row for row in mm_rows}
for m in result.results:
# Get additional data from DB lookup
extra = obs_data.get(m.id, {})
extra = mm_data.get(m.id, {})
proof_count = extra.get("proof_count", 1) if extra else 1
source_ids = extra.get("source_memory_ids", []) if extra else []
# Convert UUIDs to strings
@@ -203,7 +204,7 @@ async def tool_search_observations(
is_stale = True
staleness_reason = f"{pending_consolidation} memories pending consolidation"
observations.append(
mental_models.append(
{
"id": str(m.id),
"text": m.text,
@@ -225,8 +226,8 @@ async def tool_search_observations(
return {
"query": query,
"count": len(observations),
"observations": observations,
"count": len(mental_models),
"mental_models": mental_models,
"freshness": freshness,
}
@@ -246,7 +247,7 @@ async def tool_recall(
Search memories using TEMPR retrieval.
This is the ground truth - raw facts and experiences.
Use when mental models/observations don't exist, are stale, or need verification.
Use when reflections/mental models don't exist, are stale, or need verification.
Args:
memory_engine: Memory engine instance
@@ -265,7 +266,7 @@ async def tool_recall(
result = await memory_engine.recall_async(
bank_id=bank_id,
query=query,
fact_type=["experience", "world"], # Exclude opinions and observations
fact_type=["experience", "world"], # Exclude opinions and mental_models
max_tokens=max_tokens,
enable_trace=False,
request_context=request_context,
@@ -3,69 +3,61 @@ Tool schema definitions for the reflect agent.
These are OpenAI-format tool definitions used with native tool calling.
The reflect agent uses a hierarchical retrieval strategy:
1. search_mental_models - User-curated stored reflect responses (highest quality, if applicable)
2. search_observations - Consolidated knowledge with freshness awareness
1. search_reflections - User-curated summaries (highest quality, if applicable)
2. search_mental_models - Consolidated knowledge with freshness awareness
3. recall - Raw facts (world/experience) as ground truth fallback
"""
# Tool definitions in OpenAI format
TOOL_SEARCH_REFLECTIONS = {
"type": "function",
"function": {
"name": "search_reflections",
"description": (
"Search user-curated reflections (summaries). These are high-quality, manually created "
"summaries about specific topics. Use FIRST when the question might be covered by an "
"existing reflection. Returns reflections with their content and last refresh time."
),
"parameters": {
"type": "object",
"properties": {
"query": {
"type": "string",
"description": "Search query to find relevant reflections",
},
"max_results": {
"type": "integer",
"description": "Maximum number of reflections to return (default 5)",
},
},
"required": ["query"],
},
},
}
TOOL_SEARCH_MENTAL_MODELS = {
"type": "function",
"function": {
"name": "search_mental_models",
"description": (
"Search user-curated mental models (stored reflect responses). These are high-quality, manually created "
"summaries about specific topics. Use FIRST when the question might be covered by an "
"existing mental model. Returns mental models with their content and last refresh time."
"Search consolidated mental models (auto-generated knowledge). These are automatically "
"synthesized from memories. Returns models with freshness info (updated_at, is_stale). "
"If a model is STALE, you should ALSO use recall() to verify with current facts."
),
"parameters": {
"type": "object",
"properties": {
"reason": {
"type": "string",
"description": "Brief explanation of why you're making this search (for debugging)",
},
"query": {
"type": "string",
"description": "Search query to find relevant mental models",
},
"max_results": {
"type": "integer",
"description": "Maximum number of mental models to return (default 5)",
},
},
"required": ["reason", "query"],
},
},
}
TOOL_SEARCH_OBSERVATIONS = {
"type": "function",
"function": {
"name": "search_observations",
"description": (
"Search consolidated observations (auto-generated knowledge). These are automatically "
"synthesized from memories. Returns observations with freshness info (updated_at, is_stale). "
"If an observation is STALE, you should ALSO use recall() to verify with current facts."
),
"parameters": {
"type": "object",
"properties": {
"reason": {
"type": "string",
"description": "Brief explanation of why you're making this search (for debugging)",
},
"query": {
"type": "string",
"description": "Search query to find relevant observations",
},
"max_tokens": {
"type": "integer",
"description": "Maximum tokens for results (default 5000). Use higher values for broader searches.",
},
},
"required": ["reason", "query"],
"required": ["query"],
},
},
}
@@ -83,10 +75,6 @@ TOOL_RECALL = {
"parameters": {
"type": "object",
"properties": {
"reason": {
"type": "string",
"description": "Brief explanation of why you're making this search (for debugging)",
},
"query": {
"type": "string",
"description": "Search query string",
@@ -96,7 +84,7 @@ TOOL_RECALL = {
"description": "Optional limit on result size (default 2048). Use higher values for broader searches.",
},
},
"required": ["reason", "query"],
"required": ["query"],
},
},
}
@@ -109,10 +97,6 @@ TOOL_EXPAND = {
"parameters": {
"type": "object",
"properties": {
"reason": {
"type": "string",
"description": "Brief explanation of why you need more context (for debugging)",
},
"memory_ids": {
"type": "array",
"items": {"type": "string"},
@@ -124,7 +108,7 @@ TOOL_EXPAND = {
"description": "chunk: surrounding text chunk, document: full source document",
},
},
"required": ["reason", "memory_ids", "depth"],
"required": ["memory_ids", "depth"],
},
},
}
@@ -146,16 +130,16 @@ TOOL_DONE_ANSWER = {
"items": {"type": "string"},
"description": "Array of memory IDs that support your answer (put IDs here, NOT in answer text)",
},
"reflection_ids": {
"type": "array",
"items": {"type": "string"},
"description": "Array of reflection IDs that support your answer",
},
"mental_model_ids": {
"type": "array",
"items": {"type": "string"},
"description": "Array of mental model IDs that support your answer",
},
"observation_ids": {
"type": "array",
"items": {"type": "string"},
"description": "Array of observation IDs that support your answer",
},
},
"required": ["answer"],
},
@@ -197,16 +181,16 @@ def _build_done_tool_with_directives(directive_rules: list[str]) -> dict:
"items": {"type": "string"},
"description": "Array of memory IDs that support your answer (put IDs here, NOT in answer text)",
},
"reflection_ids": {
"type": "array",
"items": {"type": "string"},
"description": "Array of reflection IDs that support your answer",
},
"mental_model_ids": {
"type": "array",
"items": {"type": "string"},
"description": "Array of mental model IDs that support your answer",
},
"observation_ids": {
"type": "array",
"items": {"type": "string"},
"description": "Array of observation IDs that support your answer",
},
"directive_compliance": {
"type": "string",
"description": f"REQUIRED: Confirm your answer complies with ALL directives. List each directive and how your answer follows it:\n{rules_list}\n\nFormat: 'Directive 1: [how answer complies]. Directive 2: [how answer complies]...'",
@@ -223,8 +207,8 @@ def get_reflect_tools(directive_rules: list[str] | None = None) -> list[dict]:
Get the list of tools for the reflect agent.
The tools support a hierarchical retrieval strategy:
1. search_mental_models - User-curated stored reflect responses (try first)
2. search_observations - Consolidated knowledge with freshness
1. search_reflections - User-curated summaries (try first)
2. search_mental_models - Consolidated knowledge with freshness
3. recall - Raw facts as ground truth
Args:
@@ -235,8 +219,8 @@ def get_reflect_tools(directive_rules: list[str] | None = None) -> list[dict]:
List of tool definitions in OpenAI format
"""
tools = [
TOOL_SEARCH_REFLECTIONS,
TOOL_SEARCH_MENTAL_MODELS,
TOOL_SEARCH_OBSERVATIONS,
TOOL_RECALL,
TOOL_EXPAND,
]
@@ -10,8 +10,8 @@ from typing import Any
from pydantic import BaseModel, ConfigDict, Field
# Valid fact types for recall operations (excludes 'opinion' which is deprecated)
VALID_RECALL_FACT_TYPES = frozenset(["world", "experience", "observation"])
# Valid fact types for recall operations (excludes 'observation' which is internal, and 'opinion' which is deprecated)
VALID_RECALL_FACT_TYPES = frozenset(["world", "experience", "mental_model"])
class LLMToolCall(BaseModel):
@@ -36,7 +36,6 @@ class ToolCallTrace(BaseModel):
"""A single tool call made during reflect."""
tool: str = Field(description="Tool name: lookup, recall, learn, expand")
reason: str | None = Field(default=None, description="Agent's reasoning for making this tool call")
input: dict = Field(description="Tool input parameters")
output: dict = Field(description="Tool output/result")
duration_ms: int = Field(description="Execution time in milliseconds")
@@ -50,13 +49,13 @@ class LLMCallTrace(BaseModel):
duration_ms: int = Field(description="Execution time in milliseconds")
class ObservationRef(BaseModel):
"""Reference to an observation accessed during reflect."""
class MentalModelRef(BaseModel):
"""Reference to a mental model accessed during reflect."""
id: str = Field(description="Observation ID")
name: str = Field(description="Observation name")
type: str = Field(description="Observation type: entity, concept, event")
subtype: str = Field(description="Observation subtype: structural, emergent, learned")
id: str = Field(description="Mental model ID")
name: str = Field(description="Mental model name")
type: str = Field(description="Mental model type: entity, concept, event")
subtype: str = Field(description="Mental model subtype: structural, emergent, learned")
description: str = Field(description="Brief description")
summary: str | None = Field(default=None, description="Full summary (when looked up in detail)")
@@ -66,7 +65,7 @@ class DirectiveRef(BaseModel):
id: str = Field(description="Directive mental model ID")
name: str = Field(description="Directive name")
content: str = Field(description="Directive content")
rules: list[str] = Field(default_factory=list, description="Directive rules/observations that were applied")
class TokenUsage(BaseModel):
@@ -169,23 +168,23 @@ class ChunkInfo(BaseModel):
truncated: bool = Field(default=False, description="Whether the chunk was truncated due to token limits")
class ObservationResult(BaseModel):
"""An observation result from recall (consolidated knowledge synthesized from facts)."""
class MentalModelResult(BaseModel):
"""A mental model result from recall."""
id: str = Field(description="Unique observation ID")
text: str = Field(description="The observation text")
proof_count: int = Field(description="Number of facts supporting this observation")
id: str = Field(description="Unique mental model ID")
text: str = Field(description="The mental model text")
proof_count: int = Field(description="Number of facts supporting this mental model")
relevance: float = Field(default=0.0, description="Relevance score to the query")
tags: list[str] | None = Field(default=None, description="Tags for visibility scoping")
source_memory_ids: list[str] = Field(
default_factory=list, description="IDs of facts that contribute to this observation"
default_factory=list, description="IDs of facts that contribute to this mental model"
)
class MentalModelResult(BaseModel):
"""A mental model result from recall (stored reflect response)."""
class ReflectionResult(BaseModel):
"""A reflection result from recall."""
id: str = Field(description="Unique mental model ID")
id: str = Field(description="Unique reflection ID")
name: str = Field(description="Human-readable name")
content: str = Field(description="The synthesized content")
relevance: float = Field(default=0.0, description="Relevance score to the query")
@@ -254,14 +253,7 @@ class ReflectResult(BaseModel):
],
"experience": [],
"opinion": [],
"mental_models": [],
"directives": [
{
"id": "directive-123",
"name": "Response Style",
"rules": ["Always be concise"],
}
],
"mental-models": [],
},
"new_opinions": ["Machine learning has great potential in healthcare"],
"structured_output": {"summary": "ML in healthcare", "confidence": 0.9},
@@ -271,8 +263,8 @@ class ReflectResult(BaseModel):
)
text: str = Field(description="The formulated answer text")
based_on: dict[str, Any] = Field(
description="Facts used to formulate the answer, organized by type (world, experience, opinion, mental_models, directives)"
based_on: dict[str, list[MemoryFact]] = Field(
description="Facts used to formulate the answer, organized by type (world, experience, opinion, mental-models)"
)
new_opinions: list[str] = Field(default_factory=list, description="List of newly formed opinions during reflection")
structured_output: dict[str, Any] | None = Field(
@@ -432,15 +432,34 @@ def _chunk_conversation(turns: list[dict], max_chars: int) -> list[str]:
# FACT EXTRACTION PROMPTS
# =============================================================================
# Base prompt template (shared by concise and custom modes)
# Uses {extraction_guidelines} placeholder for mode-specific instructions
_BASE_FACT_EXTRACTION_PROMPT = """Extract SIGNIFICANT facts from text. Be SELECTIVE - only extract facts worth remembering long-term.
# Concise extraction prompt (default) - selective, high-quality facts
CONCISE_FACT_EXTRACTION_PROMPT = """Extract SIGNIFICANT facts from text. Be SELECTIVE - only extract facts worth remembering long-term.
LANGUAGE REQUIREMENT: Detect the language of the input text. All extracted facts, entity names, descriptions, and other output MUST be in the SAME language as the input. Do not translate to another language.
{fact_types_instruction}
{extraction_guidelines}
══════════════════════════════════════════════════════════════════════════
SELECTIVITY - CRITICAL (Reduces 90% of unnecessary output)
══════════════════════════════════════════════════════════════════════════
ONLY extract facts that are:
✅ Personal info: names, relationships, roles, background
✅ Preferences: likes, dislikes, habits, interests (e.g., "Alice likes coffee")
✅ Significant events: milestones, decisions, achievements, changes
✅ Plans/goals: future intentions, deadlines, commitments
✅ Expertise: skills, knowledge, certifications, experience
✅ Important context: projects, problems, constraints
✅ Sensory/emotional details: feelings, sensations, perceptions that provide context
✅ Observations: descriptions of people, places, things with specific details
DO NOT extract:
❌ Generic greetings: "how are you", "hello", pleasantries without substance
❌ Pure filler: "thanks", "sounds good", "ok", "got it", "sure"
❌ Process chatter: "let me check", "one moment", "I'll look into it"
❌ Repeated info: if already stated, don't extract again
CONSOLIDATE related statements into ONE fact when possible.
══════════════════════════════════════════════════════════════════════════
FACT FORMAT - BE CONCISE
@@ -488,33 +507,7 @@ ENTITIES
══════════════════════════════════════════════════════════════════════════
Include: people names, organizations, places, key objects, abstract concepts (career, friendship, etc.)
Always include "user" when fact is about the user.{examples}"""
# Concise mode guidelines
_CONCISE_GUIDELINES = """══════════════════════════════════════════════════════════════════════════
SELECTIVITY - CRITICAL (Reduces 90% of unnecessary output)
══════════════════════════════════════════════════════════════════════════
ONLY extract facts that are:
✅ Personal info: names, relationships, roles, background
✅ Preferences: likes, dislikes, habits, interests (e.g., "Alice likes coffee")
✅ Significant events: milestones, decisions, achievements, changes
✅ Plans/goals: future intentions, deadlines, commitments
✅ Expertise: skills, knowledge, certifications, experience
✅ Important context: projects, problems, constraints
✅ Sensory/emotional details: feelings, sensations, perceptions that provide context
✅ Observations: descriptions of people, places, things with specific details
DO NOT extract:
❌ Generic greetings: "how are you", "hello", pleasantries without substance
❌ Pure filler: "thanks", "sounds good", "ok", "got it", "sure"
❌ Process chatter: "let me check", "one moment", "I'll look into it"
❌ Repeated info: if already stated, don't extract again
CONSOLIDATE related statements into ONE fact when possible."""
# Concise mode examples
_CONCISE_EXAMPLES = """
Always include "user" when fact is about the user.
══════════════════════════════════════════════════════════════════════════
EXAMPLES
@@ -540,20 +533,6 @@ QUALITY OVER QUANTITY
Ask: "Would this be useful to recall in 6 months?" If no, skip it."""
# Assembled concise prompt (backward compatible - exact same output as before)
CONCISE_FACT_EXTRACTION_PROMPT = _BASE_FACT_EXTRACTION_PROMPT.format(
fact_types_instruction="{fact_types_instruction}",
extraction_guidelines=_CONCISE_GUIDELINES,
examples=_CONCISE_EXAMPLES,
)
# Custom prompt uses same base but without examples
CUSTOM_FACT_EXTRACTION_PROMPT = _BASE_FACT_EXTRACTION_PROMPT.format(
fact_types_instruction="{fact_types_instruction}",
extraction_guidelines="{custom_instructions}",
examples="", # No examples for custom mode
)
# Verbose extraction prompt - detailed, comprehensive facts (legacy mode)
VERBOSE_FACT_EXTRACTION_PROMPT = """Extract facts from text into structured format with FIVE required dimensions - BE EXTREMELY DETAILED.
@@ -701,12 +680,6 @@ async def _extract_facts_from_chunk(
Note: event_date parameter is kept for backward compatibility but not used in prompt.
The LLM extracts temporal information from the context string instead.
"""
import logging
from openai import BadRequestError
logger = logging.getLogger(__name__)
memory_bank_context = f"\n- Your name: {agent_name}" if agent_name and extract_opinions else ""
# Determine which fact types to extract based on the flag
@@ -725,27 +698,13 @@ async def _extract_facts_from_chunk(
extract_causal_links = config.retain_extract_causal_links
# Select base prompt based on extraction mode
if extraction_mode == "custom":
# Custom mode: inject user-provided guidelines
if not config.retain_custom_instructions:
logger.warning(
"extraction_mode='custom' but HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS not set. "
"Falling back to 'concise' mode."
)
base_prompt = CONCISE_FACT_EXTRACTION_PROMPT
prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
else:
base_prompt = CUSTOM_FACT_EXTRACTION_PROMPT
prompt = base_prompt.format(
fact_types_instruction=fact_types_instruction,
custom_instructions=config.retain_custom_instructions,
)
elif extraction_mode == "verbose":
if extraction_mode == "verbose":
base_prompt = VERBOSE_FACT_EXTRACTION_PROMPT
prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
else:
base_prompt = CONCISE_FACT_EXTRACTION_PROMPT
prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
# Format the prompt with fact types instruction
prompt = base_prompt.format(fact_types_instruction=fact_types_instruction)
# Build the full prompt with or without causal relationships section
# Select appropriate response schema based on extraction mode and causal links
@@ -758,6 +717,12 @@ async def _extract_facts_from_chunk(
else:
response_schema = FactExtractionResponseNoCausal
import logging
from openai import BadRequestError
logger = logging.getLogger(__name__)
# Retry logic for JSON validation errors
max_retries = 2
last_error = None
@@ -155,7 +155,7 @@ class LinkExpansionRetriever(GraphRetriever):
all_seeds.extend(temporal_seeds)
if not all_seeds:
logger.info("[LinkExpansion] No seeds found, returning empty results")
logger.debug("[LinkExpansion] No seeds found, returning empty results")
return [], timings
seed_ids = list({s.id for s in all_seeds})
@@ -164,102 +164,30 @@ class LinkExpansionRetriever(GraphRetriever):
# Run entity and causal expansion sequentially on same connection
query_start = time.time()
# For observations, traverse through source_memory_ids to find entity connections.
# Observations don't have direct unit_entities - they inherit entities via their
# source world/experience facts.
#
# Path: observation → source_memory_ids → world fact → entities →
# ALL world facts with those entities → their observations (excluding seeds)
if fact_type == "observation":
# Debug: Check what source_memory_ids exist on seed observations
debug_sources = await conn.fetch(
f"""
SELECT id, source_memory_ids
FROM {fq_table("memory_units")}
WHERE id = ANY($1::uuid[])
""",
seed_ids,
)
source_ids_found = []
for row in debug_sources:
if row["source_memory_ids"]:
source_ids_found.extend(row["source_memory_ids"])
logger.debug(
f"[LinkExpansion] observation graph: {len(seed_ids)} seeds, "
f"{len(source_ids_found)} source_memory_ids found"
)
entity_rows = await conn.fetch(
f"""
WITH seed_sources AS (
-- Get source memory IDs from seed observations
SELECT DISTINCT unnest(source_memory_ids) AS source_id
FROM {fq_table("memory_units")}
WHERE id = ANY($1::uuid[])
AND source_memory_ids IS NOT NULL
),
source_entities AS (
-- Get entities from those source memories (filtered by frequency)
SELECT DISTINCT ue.entity_id
FROM seed_sources ss
JOIN {fq_table("unit_entities")} ue ON ss.source_id = ue.unit_id
JOIN {fq_table("entities")} e ON ue.entity_id = e.id
WHERE e.mention_count < $2
),
all_connected_sources AS (
-- Find ALL world facts sharing those entities (don't exclude seed sources)
-- The exclusion happens at the observation level, not the source level
SELECT DISTINCT other_ue.unit_id AS source_id
FROM source_entities se
JOIN {fq_table("unit_entities")} other_ue ON se.entity_id = other_ue.entity_id
)
-- Find observations derived from connected source memories
-- Only exclude the actual seed observations
SELECT
mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
mu.occurred_end, mu.mentioned_at, mu.embedding,
mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
COUNT(DISTINCT cs.source_id)::float AS score
FROM all_connected_sources cs
JOIN {fq_table("memory_units")} mu
ON mu.source_memory_ids @> ARRAY[cs.source_id]
WHERE mu.fact_type = 'observation'
AND mu.id != ALL($1::uuid[])
GROUP BY mu.id
ORDER BY score DESC
LIMIT $3
""",
seed_ids,
self.max_entity_frequency,
budget,
)
logger.debug(f"[LinkExpansion] observation graph: found {len(entity_rows)} connected observations")
else:
# For world/experience facts, use direct entity lookup
entity_rows = await conn.fetch(
f"""
SELECT
mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
mu.occurred_end, mu.mentioned_at, mu.embedding,
mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
COUNT(*)::float AS score
FROM {fq_table("unit_entities")} seed_ue
JOIN {fq_table("entities")} e ON seed_ue.entity_id = e.id
JOIN {fq_table("unit_entities")} other_ue ON seed_ue.entity_id = other_ue.entity_id
JOIN {fq_table("memory_units")} mu ON other_ue.unit_id = mu.id
WHERE seed_ue.unit_id = ANY($1::uuid[])
AND e.mention_count < $2
AND mu.id != ALL($1::uuid[])
AND mu.fact_type = $3
GROUP BY mu.id
ORDER BY score DESC
LIMIT $4
""",
seed_ids,
self.max_entity_frequency,
fact_type,
budget,
)
entity_rows = await conn.fetch(
f"""
SELECT
mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
mu.occurred_end, mu.mentioned_at, mu.embedding,
mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
COUNT(*)::float AS score
FROM {fq_table("unit_entities")} seed_ue
JOIN {fq_table("entities")} e ON seed_ue.entity_id = e.id
JOIN {fq_table("unit_entities")} other_ue ON seed_ue.entity_id = other_ue.entity_id
JOIN {fq_table("memory_units")} mu ON other_ue.unit_id = mu.id
WHERE seed_ue.unit_id = ANY($1::uuid[])
AND e.mention_count < $2
AND mu.id != ALL($1::uuid[])
AND mu.fact_type = $3
GROUP BY mu.id
ORDER BY score DESC
LIMIT $4
""",
seed_ids,
self.max_entity_frequency,
fact_type,
budget,
)
causal_rows = await conn.fetch(
f"""
@@ -283,69 +211,11 @@ class LinkExpansionRetriever(GraphRetriever):
budget,
)
# Fallback: semantic/temporal/entity links from memory_links table
# These are secondary to entity links (via unit_entities) and causal links
# Weight is halved (0.5x) to prioritize primary link types
# Check both directions: seeds -> others AND others -> seeds
fallback_rows = await conn.fetch(
f"""
WITH outgoing AS (
-- Links FROM seeds TO other facts
SELECT mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
mu.occurred_end, mu.mentioned_at, mu.embedding,
mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
ml.weight
FROM {fq_table("memory_links")} ml
JOIN {fq_table("memory_units")} mu ON ml.to_unit_id = mu.id
WHERE ml.from_unit_id = ANY($1::uuid[])
AND ml.link_type IN ('semantic', 'temporal', 'entity')
AND ml.weight >= $2
AND mu.fact_type = $3
AND mu.id != ALL($1::uuid[])
),
incoming AS (
-- Links FROM other facts TO seeds (reverse direction)
SELECT mu.id, mu.text, mu.context, mu.event_date, mu.occurred_start,
mu.occurred_end, mu.mentioned_at, mu.embedding,
mu.fact_type, mu.document_id, mu.chunk_id, mu.tags,
ml.weight
FROM {fq_table("memory_links")} ml
JOIN {fq_table("memory_units")} mu ON ml.from_unit_id = mu.id
WHERE ml.to_unit_id = ANY($1::uuid[])
AND ml.link_type IN ('semantic', 'temporal', 'entity')
AND ml.weight >= $2
AND mu.fact_type = $3
AND mu.id != ALL($1::uuid[])
),
combined AS (
SELECT * FROM outgoing
UNION ALL
SELECT * FROM incoming
)
SELECT DISTINCT ON (id)
id, text, context, event_date, occurred_start,
occurred_end, mentioned_at, embedding,
fact_type, document_id, chunk_id, tags,
(MAX(weight) * 0.5) AS score
FROM combined
GROUP BY id, text, context, event_date, occurred_start,
occurred_end, mentioned_at, embedding,
fact_type, document_id, chunk_id, tags
ORDER BY id, score DESC
LIMIT $4
""",
seed_ids,
self.causal_weight_threshold,
fact_type,
budget,
)
timings.edge_load_time = time.time() - query_start
timings.db_queries = 3
timings.edge_count = len(entity_rows) + len(causal_rows) + len(fallback_rows)
timings.db_queries = 2
timings.edge_count = len(entity_rows) + len(causal_rows)
# Merge results, taking max score per fact
# Priority: entity links (unit_entities) > causal links > fallback links
score_map: dict[str, float] = {}
row_map: dict[str, dict] = {}
@@ -360,12 +230,6 @@ class LinkExpansionRetriever(GraphRetriever):
if fact_id not in row_map:
row_map[fact_id] = dict(row)
for row in fallback_rows:
fact_id = str(row["id"])
score_map[fact_id] = max(score_map.get(fact_id, 0), row["score"])
if fact_id not in row_map:
row_map[fact_id] = dict(row)
# Sort by score and limit
sorted_ids = sorted(score_map.keys(), key=lambda x: score_map[x], reverse=True)[:budget]
rows = [row_map[fact_id] for fact_id in sorted_ids]
@@ -0,0 +1,134 @@
"""
Scoring functions for memory search and retrieval.
Includes recency weighting, frequency weighting, temporal proximity,
and similarity calculations used in memory activation and ranking.
"""
from datetime import datetime
def cosine_similarity(vec1: list[float], vec2: list[float]) -> float:
"""
Calculate cosine similarity between two vectors.
Args:
vec1: First vector
vec2: Second vector
Returns:
Similarity score between 0 and 1
"""
if len(vec1) != len(vec2):
raise ValueError("Vectors must have same dimension")
dot_product = sum(a * b for a, b in zip(vec1, vec2))
magnitude1 = sum(a * a for a in vec1) ** 0.5
magnitude2 = sum(b * b for b in vec2) ** 0.5
if magnitude1 == 0 or magnitude2 == 0:
return 0.0
return dot_product / (magnitude1 * magnitude2)
def calculate_recency_weight(days_since: float, half_life_days: float = 365.0) -> float:
"""
Calculate recency weight using logarithmic decay.
This provides much better differentiation over long time periods compared to
exponential decay. Uses a log-based decay where the half-life parameter controls
when memories reach 50% weight.
Examples:
- Today (0 days): 1.0
- 1 year (365 days): ~0.5 (with default half_life=365)
- 2 years (730 days): ~0.33
- 5 years (1825 days): ~0.17
- 10 years (3650 days): ~0.09
This ensures that 2-year-old and 5-year-old memories have meaningfully
different weights, unlike exponential decay which makes them both ~0.
Args:
days_since: Number of days since the memory was created
half_life_days: Number of days for weight to reach 0.5 (default: 1 year)
Returns:
Weight between 0 and 1
"""
import math
# Logarithmic decay: 1 / (1 + log(1 + days_since/half_life))
# This decays much slower than exponential, giving better long-term differentiation
normalized_age = days_since / half_life_days
return 1.0 / (1.0 + math.log1p(normalized_age))
def calculate_temporal_anchor(occurred_start: datetime, occurred_end: datetime) -> datetime:
"""
Calculate a single temporal anchor point from a temporal range.
Used for spreading activation - we need a single representative date
to calculate temporal proximity between facts. This simplifies the
range-to-range distance problem.
Strategy: Use midpoint of the range for balanced representation.
Args:
occurred_start: Start of temporal range
occurred_end: End of temporal range
Returns:
Single datetime representing the temporal anchor (midpoint)
Examples:
- Point event (July 14): start=July 14, end=July 14 → anchor=July 14
- Month range (February): start=Feb 1, end=Feb 28 → anchor=Feb 14
- Year range (2023): start=Jan 1, end=Dec 31 → anchor=July 1
"""
# Calculate midpoint
time_delta = occurred_end - occurred_start
midpoint = occurred_start + (time_delta / 2)
return midpoint
def calculate_temporal_proximity(anchor_a: datetime, anchor_b: datetime, half_life_days: float = 30.0) -> float:
"""
Calculate temporal proximity between two temporal anchors.
Used for spreading activation to determine how "close" two facts are
in time. Uses logarithmic decay so that temporal similarity doesn't
drop off too quickly.
Args:
anchor_a: Temporal anchor of first fact
anchor_b: Temporal anchor of second fact
half_life_days: Number of days for proximity to reach 0.5
(default: 30 days = 1 month)
Returns:
Proximity score in [0, 1] where:
- 1.0 = same day
- 0.5 = ~half_life days apart
- 0.0 = very distant in time
Examples:
- Same day: 1.0
- 1 week apart (half_life=30): ~0.7
- 1 month apart (half_life=30): ~0.5
- 1 year apart (half_life=30): ~0.2
"""
import math
days_apart = abs((anchor_a - anchor_b).days)
if days_apart == 0:
return 1.0
# Logarithmic decay: 1 / (1 + log(1 + days_apart/half_life))
# Similar to calculate_recency_weight but for proximity between events
normalized_distance = days_apart / half_life_days
proximity = 1.0 / (1.0 + math.log1p(normalized_distance))
return proximity
@@ -144,21 +144,17 @@ class BrokerTaskBackend(TaskBackend):
self,
pool_getter: Callable[[], "asyncpg.Pool"],
schema: str | None = None,
schema_getter: Callable[[], str | None] | None = None,
):
"""
Initialize the broker task backend.
Args:
pool_getter: Callable that returns the asyncpg connection pool
schema: Database schema for multi-tenant support (optional, static)
schema_getter: Callable that returns current schema dynamically (optional).
If set, takes precedence over static schema for submit_task.
schema: Database schema for multi-tenant support (optional)
"""
super().__init__()
self._pool_getter = pool_getter
self._schema = schema
self._schema_getter = schema_getter
async def initialize(self):
"""Initialize the backend."""
@@ -184,8 +180,7 @@ class BrokerTaskBackend(TaskBackend):
bank_id = task_dict.get("bank_id")
payload_json = json.dumps(task_dict)
schema = self._schema_getter() if self._schema_getter else self._schema
table = fq_table("async_operations", schema)
table = fq_table("async_operations", self._schema)
if operation_id:
# Update existing operation with task payload
@@ -236,8 +231,7 @@ class BrokerTaskBackend(TaskBackend):
import asyncio
pool = self._pool_getter()
schema = self._schema_getter() if self._schema_getter else self._schema
table = fq_table("async_operations", schema)
table = fq_table("async_operations", self._schema)
start_time = asyncio.get_event_loop().time()
while asyncio.get_event_loop().time() - start_time < timeout:
+126
View File
@@ -65,3 +65,129 @@ async def extract_facts(
return [], chunks
return facts, chunks
def cosine_similarity(vec1: list[float], vec2: list[float]) -> float:
"""
Calculate cosine similarity between two vectors.
Args:
vec1: First vector
vec2: Second vector
Returns:
Similarity score between 0 and 1
"""
if len(vec1) != len(vec2):
raise ValueError("Vectors must have same dimension")
dot_product = sum(a * b for a, b in zip(vec1, vec2))
magnitude1 = sum(a * a for a in vec1) ** 0.5
magnitude2 = sum(b * b for b in vec2) ** 0.5
if magnitude1 == 0 or magnitude2 == 0:
return 0.0
return dot_product / (magnitude1 * magnitude2)
def calculate_recency_weight(days_since: float, half_life_days: float = 365.0) -> float:
"""
Calculate recency weight using logarithmic decay.
This provides much better differentiation over long time periods compared to
exponential decay. Uses a log-based decay where the half-life parameter controls
when memories reach 50% weight.
Examples:
- Today (0 days): 1.0
- 1 year (365 days): ~0.5 (with default half_life=365)
- 2 years (730 days): ~0.33
- 5 years (1825 days): ~0.17
- 10 years (3650 days): ~0.09
This ensures that 2-year-old and 5-year-old memories have meaningfully
different weights, unlike exponential decay which makes them both ~0.
Args:
days_since: Number of days since the memory was created
half_life_days: Number of days for weight to reach 0.5 (default: 1 year)
Returns:
Weight between 0 and 1
"""
import math
# Logarithmic decay: 1 / (1 + log(1 + days_since/half_life))
# This decays much slower than exponential, giving better long-term differentiation
normalized_age = days_since / half_life_days
return 1.0 / (1.0 + math.log1p(normalized_age))
def calculate_temporal_anchor(occurred_start: datetime, occurred_end: datetime) -> datetime:
"""
Calculate a single temporal anchor point from a temporal range.
Used for spreading activation - we need a single representative date
to calculate temporal proximity between facts. This simplifies the
range-to-range distance problem.
Strategy: Use midpoint of the range for balanced representation.
Args:
occurred_start: Start of temporal range
occurred_end: End of temporal range
Returns:
Single datetime representing the temporal anchor (midpoint)
Examples:
- Point event (July 14): start=July 14, end=July 14 → anchor=July 14
- Month range (February): start=Feb 1, end=Feb 28 → anchor=Feb 14
- Year range (2023): start=Jan 1, end=Dec 31 → anchor=July 1
"""
# Calculate midpoint
time_delta = occurred_end - occurred_start
midpoint = occurred_start + (time_delta / 2)
return midpoint
def calculate_temporal_proximity(anchor_a: datetime, anchor_b: datetime, half_life_days: float = 30.0) -> float:
"""
Calculate temporal proximity between two temporal anchors.
Used for spreading activation to determine how "close" two facts are
in time. Uses logarithmic decay so that temporal similarity doesn't
drop off too quickly.
Args:
anchor_a: Temporal anchor of first fact
anchor_b: Temporal anchor of second fact
half_life_days: Number of days for proximity to reach 0.5
(default: 30 days = 1 month)
Returns:
Proximity score in [0, 1] where:
- 1.0 = same day
- 0.5 = ~half_life days apart
- 0.0 = very distant in time
Examples:
- Same day: 1.0
- 1 week apart (half_life=30): ~0.7
- 1 month apart (half_life=30): ~0.5
- 1 year apart (half_life=30): ~0.2
"""
import math
days_apart = abs((anchor_a - anchor_b).days)
if days_apart == 0:
return 1.0
# Logarithmic decay: 1 / (1 + log(1 + days_apart/half_life))
# Similar to calculate_recency_weight but for proximity between events
normalized_distance = days_apart / half_life_days
proximity = 1.0 / (1.0 + math.log1p(normalized_distance))
return proximity
+4 -2
View File
@@ -209,13 +209,15 @@ def main():
mpfp_top_k_neighbors=config.mpfp_top_k_neighbors,
recall_max_concurrent=config.recall_max_concurrent,
recall_connection_budget=config.recall_connection_budget,
observation_min_facts=config.observation_min_facts,
observation_top_entities=config.observation_top_entities,
retain_max_completion_tokens=config.retain_max_completion_tokens,
retain_chunk_size=config.retain_chunk_size,
retain_extract_causal_links=config.retain_extract_causal_links,
retain_extraction_mode=config.retain_extraction_mode,
retain_custom_instructions=config.retain_custom_instructions,
retain_observations_async=config.retain_observations_async,
enable_observations=config.enable_observations,
enable_mental_models=config.enable_mental_models,
consolidation_similarity_threshold=config.consolidation_similarity_threshold,
consolidation_batch_size=config.consolidation_batch_size,
skip_llm_verification=config.skip_llm_verification,
lazy_reranker=config.lazy_reranker,
@@ -261,9 +261,6 @@ class WorkerPoller:
try:
schema_info = f", schema={task.schema}" if task.schema else ""
logger.debug(f"Executing task {task.operation_id} (type={task_type}, bank={bank_id}{schema_info})")
# Pass schema to executor so it can set the correct context
if task.schema:
task.task_dict["_schema"] = task.schema
await self._executor(task.task_dict)
await self._mark_completed(task.operation_id, task.schema)
logger.debug(f"Task {task.operation_id} completed successfully")
File diff suppressed because it is too large Load Diff
@@ -1,148 +0,0 @@
"""
Tests for XPC error recovery in LocalSTCrossEncoder.
This tests the automatic reinitialization of the cross-encoder model when
XPC connection errors occur on macOS (common in long-running daemon processes).
"""
import asyncio
from unittest.mock import MagicMock, patch
import pytest
from hindsight_api.engine.cross_encoder import LocalSTCrossEncoder
class TestCrossEncoderXPCErrorRecovery:
"""Tests for XPC error detection and recovery in LocalSTCrossEncoder."""
@pytest.fixture
def cross_encoder(self):
"""Create a LocalSTCrossEncoder instance."""
return LocalSTCrossEncoder(model_name="cross-encoder/ms-marco-TinyBERT-L-2-v2")
def test_is_xpc_error_detection(self, cross_encoder):
"""Test that XPC errors are correctly detected."""
# Test various XPC error message formats
xpc_error = Exception("Compiler encountered XPC_ERROR_CONNECTION_INVALID (is the OS shutting down?)")
assert cross_encoder._is_xpc_error(xpc_error)
xpc_error2 = Exception("XPC error occurred")
assert cross_encoder._is_xpc_error(xpc_error2)
# Test that non-XPC errors are not detected
normal_error = Exception("Some other error")
assert not cross_encoder._is_xpc_error(normal_error)
@pytest.mark.asyncio
async def test_predict_with_xpc_recovery(self, cross_encoder):
"""Test that predict() recovers from XPC errors by reinitializing."""
# Initialize the cross-encoder
await cross_encoder.initialize()
# Track calls to reinitialize
reinit_called = False
original_reinit = cross_encoder._reinitialize_model_sync
def track_reinit():
nonlocal reinit_called
reinit_called = True
original_reinit()
# Track predict attempts
predict_attempts = []
original_predict = cross_encoder._model.predict
def mock_predict(*args, **kwargs):
predict_attempts.append(1)
# Only fail on first attempt
if len(predict_attempts) == 1:
raise RuntimeError("Compiler encountered XPC_ERROR_CONNECTION_INVALID (is the OS shutting down?)")
else:
# After reinit: succeed
return original_predict(*args, **kwargs)
# Mock the initial predict to fail, reinit happens, then new model succeeds
with patch.object(cross_encoder, "_reinitialize_model_sync", side_effect=track_reinit):
with patch.object(cross_encoder._model, "predict", side_effect=mock_predict):
# This should trigger XPC error on first attempt, then recover and succeed
result = await cross_encoder.predict([("query", "document")])
# Verify we got a result
assert result is not None
assert len(result) == 1
assert isinstance(result[0], float)
assert reinit_called # Should have reinitialized
assert len(predict_attempts) >= 1 # At least one attempt was made
@pytest.mark.asyncio
async def test_predict_fails_on_non_xpc_error(self, cross_encoder):
"""Test that predict() does not retry for non-XPC errors."""
# Initialize the cross-encoder
await cross_encoder.initialize()
# Create a mock that raises a non-XPC error
def mock_predict(*args, **kwargs):
raise RuntimeError("Some other error")
# Patch the model's predict method
with patch.object(cross_encoder._model, "predict", side_effect=mock_predict):
# This should fail without retry
with pytest.raises(RuntimeError) as exc_info:
await cross_encoder.predict([("query", "document")])
assert "Some other error" in str(exc_info.value)
@pytest.mark.asyncio
async def test_reinitialize_clears_model(self, cross_encoder):
"""Test that _reinitialize_model_sync properly clears and reinits the model."""
# Initialize the cross-encoder
await cross_encoder.initialize()
original_model = cross_encoder._model
assert original_model is not None
# Reinitialize
cross_encoder._reinitialize_model_sync()
# Model should be reinitialized (new instance)
assert cross_encoder._model is not None
assert cross_encoder._model is not original_model
# Should still work
result = await cross_encoder.predict([("test query", "test document")])
assert len(result) == 1
assert isinstance(result[0], float)
@pytest.mark.asyncio
async def test_xpc_recovery_exhausts_retries(self, cross_encoder):
"""Test that XPC recovery gives up after max retries."""
# Initialize the cross-encoder
await cross_encoder.initialize()
# Track reinit calls
reinit_count = 0
original_reinit = cross_encoder._reinitialize_model_sync
def track_and_fail_reinit():
nonlocal reinit_count
reinit_count += 1
# Call original reinit, but the new model will also be mocked to fail
original_reinit()
# After reinit, patch the new model too
cross_encoder._model.predict = MagicMock(
side_effect=RuntimeError("Compiler encountered XPC_ERROR_CONNECTION_INVALID")
)
# Mock that always raises XPC error
cross_encoder._model.predict = MagicMock(
side_effect=RuntimeError("Compiler encountered XPC_ERROR_CONNECTION_INVALID")
)
with patch.object(cross_encoder, "_reinitialize_model_sync", side_effect=track_and_fail_reinit):
# Should try once, reinitialize, try again, and fail
with pytest.raises(Exception) as exc_info:
await cross_encoder.predict([("query", "document")])
assert "XPC_ERROR_CONNECTION_INVALID" in str(exc_info.value) or "Failed to recover" in str(exc_info.value)
assert reinit_count == 1 # Should have tried to reinitialize once
@@ -1,148 +0,0 @@
"""
Tests for XPC error recovery in LocalSTEmbeddings.
This tests the automatic reinitialization of the embedding model when
XPC connection errors occur on macOS (common in long-running daemon processes).
"""
import asyncio
from unittest.mock import MagicMock, patch
import pytest
from hindsight_api.engine.embeddings import LocalSTEmbeddings
class TestXPCErrorRecovery:
"""Tests for XPC error detection and recovery in LocalSTEmbeddings."""
@pytest.fixture
def embeddings(self):
"""Create a LocalSTEmbeddings instance."""
return LocalSTEmbeddings(model_name="sentence-transformers/all-MiniLM-L6-v2")
def test_is_xpc_error_detection(self, embeddings):
"""Test that XPC errors are correctly detected."""
# Test various XPC error message formats
xpc_error = Exception("Compiler encountered XPC_ERROR_CONNECTION_INVALID (is the OS shutting down?)")
assert embeddings._is_xpc_error(xpc_error)
xpc_error2 = Exception("XPC error occurred")
assert embeddings._is_xpc_error(xpc_error2)
# Test that non-XPC errors are not detected
normal_error = Exception("Some other error")
assert not embeddings._is_xpc_error(normal_error)
@pytest.mark.asyncio
async def test_encode_with_xpc_recovery(self, embeddings):
"""Test that encode() recovers from XPC errors by reinitializing."""
# Initialize the embeddings
await embeddings.initialize()
# Track calls to reinitialize
reinit_called = False
original_reinit = embeddings._reinitialize_model_sync
def track_reinit():
nonlocal reinit_called
reinit_called = True
original_reinit()
# Track encode attempts
encode_attempts = []
original_encode = embeddings._model.encode
def mock_encode(*args, **kwargs):
encode_attempts.append(1)
# Only fail on first attempt
if len(encode_attempts) == 1:
raise RuntimeError("Compiler encountered XPC_ERROR_CONNECTION_INVALID (is the OS shutting down?)")
else:
# After reinit: succeed
return original_encode(*args, **kwargs)
# Mock the initial encode to fail, reinit happens, then new model succeeds
with patch.object(embeddings, "_reinitialize_model_sync", side_effect=track_reinit):
with patch.object(embeddings._model, "encode", side_effect=mock_encode):
# This should trigger XPC error on first attempt, then recover and succeed
result = embeddings.encode(["test text"])
# Verify we got a result
assert result is not None
assert len(result) == 1
assert len(result[0]) > 0 # Should have embedding vector
assert reinit_called # Should have reinitialized
assert len(encode_attempts) >= 1 # At least one attempt was made
@pytest.mark.asyncio
async def test_encode_fails_on_non_xpc_error(self, embeddings):
"""Test that encode() does not retry for non-XPC errors."""
# Initialize the embeddings
await embeddings.initialize()
# Create a mock that raises a non-XPC error
def mock_encode(*args, **kwargs):
raise RuntimeError("Some other error")
# Patch the model's encode method
with patch.object(embeddings._model, "encode", side_effect=mock_encode):
# This should fail without retry
with pytest.raises(RuntimeError) as exc_info:
embeddings.encode(["test text"])
assert "Some other error" in str(exc_info.value)
@pytest.mark.asyncio
async def test_reinitialize_clears_model(self, embeddings):
"""Test that _reinitialize_model_sync properly clears and reinits the model."""
# Initialize the embeddings
await embeddings.initialize()
original_model = embeddings._model
assert original_model is not None
# Reinitialize
embeddings._reinitialize_model_sync()
# Model should be reinitialized (new instance)
assert embeddings._model is not None
assert embeddings._model is not original_model
# Should still work
result = embeddings.encode(["test"])
assert len(result) == 1
assert len(result[0]) > 0
@pytest.mark.asyncio
async def test_xpc_recovery_exhausts_retries(self, embeddings):
"""Test that XPC recovery gives up after max retries."""
# Initialize the embeddings
await embeddings.initialize()
# Track reinit calls
reinit_count = 0
original_reinit = embeddings._reinitialize_model_sync
def track_and_fail_reinit():
nonlocal reinit_count
reinit_count += 1
# Call original reinit, but the new model will also be mocked to fail
original_reinit()
# After reinit, patch the new model too
embeddings._model.encode = MagicMock(
side_effect=RuntimeError("Compiler encountered XPC_ERROR_CONNECTION_INVALID")
)
# Mock that always raises XPC error
embeddings._model.encode = MagicMock(
side_effect=RuntimeError("Compiler encountered XPC_ERROR_CONNECTION_INVALID")
)
with patch.object(embeddings, "_reinitialize_model_sync", side_effect=track_and_fail_reinit):
# Should try once, reinitialize, try again, and fail
with pytest.raises(RuntimeError) as exc_info:
embeddings.encode(["test"])
assert "XPC_ERROR_CONNECTION_INVALID" in str(exc_info.value)
assert reinit_count == 1 # Should have tried to reinitialize once
@@ -1,278 +0,0 @@
"""
Tests for LinkExpansion graph retrieval.
Tests cover the entity-based graph traversal for observations.
"""
from datetime import datetime, timezone
import pytest
@pytest.fixture(autouse=True)
def enable_observations():
"""Enable observations for all tests in this module."""
from hindsight_api.config import get_config
config = get_config()
original_value = config.enable_observations
config.enable_observations = True
yield
config.enable_observations = original_value
@pytest.mark.asyncio
async def test_link_expansion_observation_graph_retrieval(memory, request_context):
"""
Test that observations can find other observations via shared entities.
This tests the scenario where:
1. World fact A has entity "Python"
2. World fact B has entity "Python"
3. Observation OA is derived from world fact A
4. Observation OB is derived from world fact B
When searching for observations related to OA, graph retrieval should find OB
because they share the "Python" entity through their source world facts.
Current issue: Graph retrieval returns 0 for observations because:
- Entity links are copied from world facts to observations during consolidation
- But the entity expansion query filters by fact_type
- Observations only share entities with world facts (cross-type), not with other observations
- So filtering to fact_type='observation' returns 0 results
"""
bank_id = f"test_link_expansion_obs_{datetime.now(timezone.utc).timestamp()}"
try:
# Store world facts with shared entities using retain_batch_async
# We need enough facts that semantic search won't return all of them as seeds
# Key: "Alice" query should find Alice's observation but NOT Bob's via semantic search
# Then graph retrieval should find Bob via shared "Python" entity
await memory.retain_batch_async(
bank_id=bank_id,
contents=[
# Python developers - should be connected via "Python" entity
{
"content": "Alice works with Python at TechCorp building REST APIs",
"context": "employee info",
"entities": [{"text": "Python"}, {"text": "Alice"}, {"text": "TechCorp"}],
},
{
"content": "Bob uses Python at DataSoft for machine learning models",
"context": "employee info",
"entities": [{"text": "Python"}, {"text": "Bob"}, {"text": "DataSoft"}],
},
# Many unrelated facts to dilute semantic search and ensure
# "Alice" query only finds Alice-related content as seeds
{
"content": "The weather in San Francisco is often foggy and cool",
"context": "weather info",
"entities": [{"text": "San Francisco"}],
},
{
"content": "Tokyo is the capital city of Japan with many trains",
"context": "geography info",
"entities": [{"text": "Tokyo"}, {"text": "Japan"}],
},
{
"content": "The Great Wall of China is a historic fortification",
"context": "history info",
"entities": [{"text": "Great Wall"}, {"text": "China"}],
},
{
"content": "Coffee beans are grown in tropical regions worldwide",
"context": "food info",
"entities": [{"text": "Coffee"}],
},
{
"content": "Electric vehicles are becoming more popular globally",
"context": "technology info",
"entities": [{"text": "Electric vehicles"}],
},
{
"content": "The Amazon rainforest contains diverse wildlife species",
"context": "nature info",
"entities": [{"text": "Amazon"}, {"text": "Rainforest"}],
},
{
"content": "Basketball is a popular sport in the United States",
"context": "sports info",
"entities": [{"text": "Basketball"}, {"text": "United States"}],
},
{
"content": "Mozart composed many famous classical music pieces",
"context": "music info",
"entities": [{"text": "Mozart"}, {"text": "Classical music"}],
},
],
request_context=request_context,
)
# Consolidation runs automatically after retain - wait for it to complete
# by querying for observations (consolidation creates them)
import asyncio
from hindsight_api.engine.memory_engine import Budget
# Wait for consolidation to complete with retry logic
# Consolidation runs as a background task and may take longer in CI
obs_result = None
for _ in range(30): # Try up to 30 times (30 seconds max)
await asyncio.sleep(1) # Wait 1 second between attempts
obs_result = await memory.recall_async(
bank_id=bank_id,
query="Python developer",
fact_type=["observation"],
budget=Budget.MID,
max_tokens=2048,
request_context=request_context,
)
if obs_result.results and len(obs_result.results) >= 1:
break
assert obs_result is not None and obs_result.results is not None, "Should have observations after consolidation"
# We should have observations from consolidation
assert len(obs_result.results) >= 1, f"Should have at least 1 observation about Python, got {len(obs_result.results)}"
# Now test graph retrieval specifically
# Query for Alice - should find Bob via shared "Python" entity
result = await memory.recall_async(
bank_id=bank_id,
query="Alice",
fact_type=["observation"],
budget=Budget.MID,
max_tokens=2048,
enable_trace=True,
request_context=request_context,
)
# Verify graph retrieval is working by checking the internal debug logs
# The graph retrieval finds observations via entity links, but may not return
# NEW results if semantic search already found all connected observations.
# This is correct behavior - we verify the entity traversal path works.
# Check the trace for graph results
assert result.trace is not None, "Should have trace data"
# The key verification: the entity expansion path works (sources -> entities -> observations)
# We validated this in the debug logs above:
# - Observations have source_memory_ids pointing to world facts ✓
# - World facts have entity links ✓
# - Graph retrieval can traverse this path (seen in logs: potential_obs > 0)
# For a more rigorous test, we need data where semantic search misses something.
# Let's verify the world fact graph retrieval works (it uses direct entity links).
world_result = await memory.recall_async(
bank_id=bank_id,
query="Alice",
fact_type=["world"],
budget=Budget.MID,
max_tokens=2048,
enable_trace=True,
request_context=request_context,
)
assert world_result.trace is not None, "Should have trace data for world facts"
world_retrieval_results = world_result.trace.get("retrieval_results", [])
world_graph_results = [
r for r in world_retrieval_results if r.get("method_name") == "graph"
]
if world_graph_results:
world_graph_result = [r for r in world_graph_results if r.get("fact_type") == "world"][0]
world_graph_results_list = world_graph_result.get("results", [])
# World facts use direct entity links, so graph may find results
if world_graph_results_list:
print(f"\n✓ Graph retrieval found {len(world_graph_results_list)} connected world facts")
graph_texts = [r.get("text", "") for r in world_graph_results_list]
bob_found = any("Bob" in t or "DataSoft" in t for t in graph_texts)
if bob_found:
print(" Found Bob's world fact via shared 'Python' entity!")
print("\n✓ Link expansion observation test passed!")
print(" Entity traversal path verified (observations -> sources -> entities -> connected sources -> observations)")
finally:
await memory.delete_bank(bank_id, request_context=request_context)
@pytest.mark.asyncio
async def test_link_expansion_world_fact_graph_retrieval(memory, request_context):
"""
Test that world facts can find other world facts via shared entities.
This verifies the direct entity link traversal for world facts works correctly.
Note: When semantic search finds all world facts as seeds, graph retrieval
won't return NEW results (this is correct - it shouldn't duplicate results).
"""
bank_id = f"test_link_expansion_world_{datetime.now(timezone.utc).timestamp()}"
try:
# Store world facts with shared entities
await memory.retain_batch_async(
bank_id=bank_id,
contents=[
# Python developers - should be connected via "Python" entity
{
"content": "Alice works with Python at TechCorp building REST APIs",
"context": "employee info",
"entities": [{"text": "Python"}, {"text": "Alice"}, {"text": "TechCorp"}],
},
{
"content": "Bob uses Python at DataSoft for machine learning models",
"context": "employee info",
"entities": [{"text": "Python"}, {"text": "Bob"}, {"text": "DataSoft"}],
},
# Unrelated facts
{
"content": "The weather in San Francisco is often foggy",
"context": "weather info",
"entities": [{"text": "San Francisco"}],
},
{
"content": "Coffee beans are grown in tropical regions",
"context": "food info",
"entities": [{"text": "Coffee"}],
},
],
request_context=request_context,
)
from hindsight_api.engine.memory_engine import Budget
# Query for Alice
result = await memory.recall_async(
bank_id=bank_id,
query="Alice",
fact_type=["world"],
budget=Budget.MID,
max_tokens=2048,
enable_trace=True,
request_context=request_context,
)
assert result.trace is not None, "Should have trace data"
# Verify graph retrieval ran (it may or may not find new results depending
# on whether semantic search already found everything)
retrieval_results = result.trace.get("retrieval_results", [])
graph_results = [
r for r in retrieval_results if r.get("method_name") == "graph"
]
assert len(graph_results) > 0, "Should have graph retrieval results in trace"
# The important thing is that recall works and returns relevant results
assert result.results is not None and len(result.results) > 0, (
"Should return results for 'Alice' query"
)
# Alice's result should be at or near the top
result_texts = [r.text for r in result.results]
alice_found = any("Alice" in t for t in result_texts)
assert alice_found, f"Should find Alice in results: {result_texts[:3]}"
print("\n✓ Link expansion world fact test passed!")
print(f" Recall returned {len(result.results)} results for 'Alice' query")
finally:
await memory.delete_bank(bank_id, request_context=request_context)
+2 -2
View File
@@ -241,8 +241,8 @@ class TestReflectToolSchemas:
tools = get_reflect_tools()
tool_names = [t["function"]["name"] for t in tools]
assert "search_reflections" in tool_names
assert "search_mental_models" in tool_names
assert "search_observations" in tool_names
assert "recall" in tool_names
assert "expand" in tool_names
assert "done" in tool_names
@@ -273,8 +273,8 @@ class TestReflectToolSchemas:
assert "answer" in params
assert "memory_ids" in params
assert "observation_ids" in params
assert "mental_model_ids" in params
assert "reflection_ids" in params
class TestLLMToolCallResult:
+4 -15
View File
@@ -8,20 +8,9 @@ populated from the summary for backwards compatibility.
import pytest
from hindsight_api.engine.memory_engine import Budget
from hindsight_api import RequestContext
from hindsight_api.config import get_config
from datetime import datetime, timezone
@pytest.fixture
def disable_observations():
"""Disable observations for a specific test."""
config = get_config()
original_value = config.enable_observations
config.enable_observations = False
yield
config.enable_observations = original_value
@pytest.mark.asyncio
async def test_entity_extraction_on_retain(memory, request_context):
"""
@@ -381,12 +370,12 @@ async def test_get_entity_state(memory, request_context):
@pytest.mark.asyncio
async def test_observation_fact_type_in_database(memory, request_context, disable_observations):
async def test_observation_fact_type_in_database(memory, request_context):
"""
Test that when observations are disabled, no observation records are created.
Test that observations are NOT stored as memory_units with fact_type='observation'.
When enable_observations=False, consolidation does not run and no
memory_units with fact_type='observation' should exist.
NOTE: Observations are now handled via mental models, not as memory_units
or entity summaries.
"""
bank_id = f"test_obs_db_{datetime.now(timezone.utc).timestamp()}"
+4 -78
View File
@@ -14,7 +14,6 @@ from hindsight_api.engine.reflect.agent import (
_normalize_tool_name,
_is_done_tool,
_clean_answer_text,
_clean_done_answer,
run_reflect_agent,
)
from hindsight_api.engine.response_models import LLMToolCall, LLMToolCallResult, TokenUsage
@@ -62,79 +61,6 @@ class TestCleanAnswerText:
assert cleaned == "Summary of findings."
class TestCleanDoneAnswer:
"""Test cleanup of answer field from done() tool call that leaks structured output."""
def test_clean_answer_with_leaked_json_code_block(self):
"""Answer with leaked JSON code block at the end should be cleaned."""
text = '''The user's favorite color is blue.
```json
{"observation_ids": ["obs-1", "obs-2"]}
```'''
cleaned = _clean_done_answer(text)
assert cleaned == "The user's favorite color is blue."
assert "observation_ids" not in cleaned
def test_clean_answer_with_memory_ids_code_block(self):
"""Answer with leaked memory_ids JSON code block should be cleaned."""
text = '''Here is the answer.
```json
{"memory_ids": ["mem-1"]}
```'''
cleaned = _clean_done_answer(text)
assert cleaned == "Here is the answer."
def test_clean_answer_with_raw_json_object(self):
"""Answer with raw JSON object containing IDs at the end should be cleaned."""
text = 'The answer is 42. {"observation_ids": ["obs-1"]}'
cleaned = _clean_done_answer(text)
assert cleaned == "The answer is 42."
def test_clean_answer_with_trailing_ids_pattern(self):
"""Answer with 'observation_ids: [...]' pattern at the end should be cleaned."""
text = "This is the answer.\n\nobservation_ids: [\"obs-1\", \"obs-2\"]"
cleaned = _clean_done_answer(text)
assert cleaned == "This is the answer."
def test_clean_answer_with_memory_ids_equals(self):
"""Answer with 'memory_ids = [...]' pattern at the end should be cleaned."""
text = "Answer text here.\nmemory_ids = [\"mem-1\"]"
cleaned = _clean_done_answer(text)
assert cleaned == "Answer text here."
def test_clean_normal_answer_unchanged(self):
"""Normal answer without leaked output should be unchanged."""
text = "This is a normal answer about observation strategies."
cleaned = _clean_done_answer(text)
assert cleaned == text
def test_clean_empty_answer(self):
"""Empty answer should return empty."""
assert _clean_done_answer("") == ""
def test_clean_answer_with_observation_word_in_content(self):
"""The word 'observation' in regular text should not be stripped."""
text = "Based on my observation, the user prefers dark mode."
cleaned = _clean_done_answer(text)
assert cleaned == text
def test_clean_answer_multiline_with_markdown(self):
"""Answer with markdown and leaked JSON at end should clean only the leak."""
text = '''Summary:
- Point 1
- Point 2
```json
{"mental_model_ids": ["mm-1"]}
```'''
cleaned = _clean_done_answer(text)
assert "Point 1" in cleaned
assert "Point 2" in cleaned
assert "mental_model_ids" not in cleaned
class TestToolNameNormalization:
"""Test tool name normalization for various LLM output formats."""
@@ -142,15 +68,15 @@ class TestToolNameNormalization:
"""Standard tool names should pass through unchanged."""
assert _normalize_tool_name("done") == "done"
assert _normalize_tool_name("recall") == "recall"
assert _normalize_tool_name("search_reflections") == "search_reflections"
assert _normalize_tool_name("search_mental_models") == "search_mental_models"
assert _normalize_tool_name("search_observations") == "search_observations"
assert _normalize_tool_name("expand") == "expand"
def test_normalize_functions_prefix(self):
"""Tool names with 'functions.' prefix should be normalized."""
assert _normalize_tool_name("functions.done") == "done"
assert _normalize_tool_name("functions.recall") == "recall"
assert _normalize_tool_name("functions.search_mental_models") == "search_mental_models"
assert _normalize_tool_name("functions.search_reflections") == "search_reflections"
def test_normalize_call_equals_prefix(self):
"""Tool names with 'call=' prefix should be normalized."""
@@ -161,7 +87,7 @@ class TestToolNameNormalization:
"""Tool names with 'call=functions.' prefix should be normalized."""
assert _normalize_tool_name("call=functions.done") == "done"
assert _normalize_tool_name("call=functions.recall") == "recall"
assert _normalize_tool_name("call=functions.search_observations") == "search_observations"
assert _normalize_tool_name("call=functions.search_mental_models") == "search_mental_models"
def test_is_done_tool(self):
"""Test _is_done_tool helper."""
@@ -197,8 +123,8 @@ class TestReflectAgentMocked:
def mock_functions(self):
"""Create mock search/recall functions."""
return {
"search_reflections_fn": AsyncMock(return_value={"reflections": []}),
"search_mental_models_fn": AsyncMock(return_value={"mental_models": []}),
"search_observations_fn": AsyncMock(return_value={"observations": []}),
"recall_fn": AsyncMock(return_value={"memories": [{"id": "mem-1", "content": "test memory"}]}),
"expand_fn": AsyncMock(return_value={"memories": []}),
}
+124 -213
View File
@@ -1,4 +1,4 @@
"""Tests for mental models (formerly reflections), observations, and learnings functionality."""
"""Tests for reflections, mental models, and learnings functionality."""
import uuid
@@ -21,22 +21,22 @@ async def api_client(memory):
@pytest.fixture
def test_bank_id():
"""Provide a unique bank ID for this test run."""
return f"test_mental_models_{uuid.uuid4().hex[:8]}"
return f"test_reflections_{uuid.uuid4().hex[:8]}"
class TestMentalModelsCRUD:
"""Test mental models CRUD operations via memory engine."""
class TestReflectionsCRUD:
"""Test reflections CRUD operations via memory engine."""
@pytest.mark.asyncio
async def test_create_and_get_mental_model(self, memory: MemoryEngine, request_context):
"""Test creating and retrieving a mental model."""
bank_id = f"test-mental-model-{uuid.uuid4().hex[:8]}"
async def test_create_and_get_reflection(self, memory: MemoryEngine, request_context):
"""Test creating and retrieving a reflection."""
bank_id = f"test-reflection-{uuid.uuid4().hex[:8]}"
# Create the bank first
await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
# Create a mental model
mental_model = await memory.create_mental_model(
# Create a reflection
reflection = await memory.create_reflection(
bank_id=bank_id,
name="Team Preferences",
source_query="What are the team's communication preferences?",
@@ -45,45 +45,45 @@ class TestMentalModelsCRUD:
request_context=request_context,
)
assert mental_model["name"] == "Team Preferences"
assert mental_model["source_query"] == "What are the team's communication preferences?"
assert mental_model["content"] == "The team prefers async communication via Slack"
assert mental_model["tags"] == ["team"]
assert "id" in mental_model
assert reflection["name"] == "Team Preferences"
assert reflection["source_query"] == "What are the team's communication preferences?"
assert reflection["content"] == "The team prefers async communication via Slack"
assert reflection["tags"] == ["team"]
assert "id" in reflection
# Get the mental model
fetched = await memory.get_mental_model(
# Get the reflection
fetched = await memory.get_reflection(
bank_id=bank_id,
mental_model_id=mental_model["id"],
reflection_id=reflection["id"],
request_context=request_context,
)
assert fetched["id"] == mental_model["id"]
assert fetched["id"] == reflection["id"]
assert fetched["name"] == "Team Preferences"
# Cleanup
await memory.delete_bank(bank_id, request_context=request_context)
@pytest.mark.asyncio
async def test_list_mental_models(self, memory: MemoryEngine, request_context):
"""Test listing mental models with filters."""
bank_id = f"test-mental-model-list-{uuid.uuid4().hex[:8]}"
async def test_list_reflections(self, memory: MemoryEngine, request_context):
"""Test listing reflections with filters."""
bank_id = f"test-reflection-list-{uuid.uuid4().hex[:8]}"
# Create the bank first
await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
# Create multiple mental models
await memory.create_mental_model(
# Create multiple reflections
await memory.create_reflection(
bank_id=bank_id,
name="Mental Model 1",
name="Reflection 1",
source_query="Query 1",
content="Content 1",
tags=["tag1"],
request_context=request_context,
)
await memory.create_mental_model(
await memory.create_reflection(
bank_id=bank_id,
name="Mental Model 2",
name="Reflection 2",
source_query="Query 2",
content="Content 2",
tags=["tag2"],
@@ -91,33 +91,33 @@ class TestMentalModelsCRUD:
)
# List all
all_mental_models = await memory.list_mental_models(
all_reflections = await memory.list_reflections(
bank_id=bank_id,
request_context=request_context,
)
assert len(all_mental_models) == 2
assert len(all_reflections) == 2
# List with tag filter
tag1_mental_models = await memory.list_mental_models(
tag1_reflections = await memory.list_reflections(
bank_id=bank_id,
tags=["tag1"],
request_context=request_context,
)
assert len(tag1_mental_models) == 1
assert len(tag1_reflections) == 1
# Cleanup
await memory.delete_bank(bank_id, request_context=request_context)
@pytest.mark.asyncio
async def test_update_mental_model(self, memory: MemoryEngine, request_context):
"""Test updating a mental model."""
bank_id = f"test-mental-model-update-{uuid.uuid4().hex[:8]}"
async def test_update_reflection(self, memory: MemoryEngine, request_context):
"""Test updating a reflection."""
bank_id = f"test-reflection-update-{uuid.uuid4().hex[:8]}"
# Create the bank first
await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
# Create a mental model
mental_model = await memory.create_mental_model(
# Create a reflection
reflection = await memory.create_reflection(
bank_id=bank_id,
name="Original Name",
source_query="Original Query",
@@ -125,10 +125,10 @@ class TestMentalModelsCRUD:
request_context=request_context,
)
# Update the mental model
updated = await memory.update_mental_model(
# Update the reflection
updated = await memory.update_reflection(
bank_id=bank_id,
mental_model_id=mental_model["id"],
reflection_id=reflection["id"],
name="Updated Name",
content="Updated Content",
request_context=request_context,
@@ -141,15 +141,15 @@ class TestMentalModelsCRUD:
await memory.delete_bank(bank_id, request_context=request_context)
@pytest.mark.asyncio
async def test_delete_mental_model(self, memory: MemoryEngine, request_context):
"""Test deleting a mental model."""
bank_id = f"test-mental-model-delete-{uuid.uuid4().hex[:8]}"
async def test_delete_reflection(self, memory: MemoryEngine, request_context):
"""Test deleting a reflection."""
bank_id = f"test-reflection-delete-{uuid.uuid4().hex[:8]}"
# Create the bank first
await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
# Create a mental model
mental_model = await memory.create_mental_model(
# Create a reflection
reflection = await memory.create_reflection(
bank_id=bank_id,
name="To Delete",
source_query="Query",
@@ -157,17 +157,17 @@ class TestMentalModelsCRUD:
request_context=request_context,
)
# Delete the mental model
await memory.delete_mental_model(
# Delete the reflection
await memory.delete_reflection(
bank_id=bank_id,
mental_model_id=mental_model["id"],
reflection_id=reflection["id"],
request_context=request_context,
)
# Verify deletion - should return None
fetched = await memory.get_mental_model(
fetched = await memory.get_reflection(
bank_id=bank_id,
mental_model_id=mental_model["id"],
reflection_id=reflection["id"],
request_context=request_context,
)
assert fetched is None
@@ -176,45 +176,45 @@ class TestMentalModelsCRUD:
await memory.delete_bank(bank_id, request_context=request_context)
class TestObservationsAPI:
"""Test observations API endpoints.
class TestMentalModelsAPI:
"""Test mental models API endpoints.
NOTE: Observations are now stored in memory_units with fact_type='observation'
and accessed via recall with fact_type=["observation"]. The old /observations
NOTE: Mental models are now stored in memory_units with fact_type='mental_model'
and accessed via recall with fact_type=["mental_model"]. The old /mental-models
endpoint was removed. These tests are skipped.
"""
@pytest.mark.skip(reason="Observations endpoint removed - use recall with fact_type=['observation']")
@pytest.mark.skip(reason="Mental models endpoint removed - use recall with fact_type=['mental_model']")
@pytest.mark.asyncio
async def test_list_observations_empty(self, api_client, test_bank_id):
"""Test listing observations when none exist."""
async def test_list_mental_models_empty(self, api_client, test_bank_id):
"""Test listing mental models when none exist."""
pass
@pytest.mark.skip(reason="Observations endpoint removed - use recall with fact_type=['observation']")
@pytest.mark.skip(reason="Mental models endpoint removed - use recall with fact_type=['mental_model']")
@pytest.mark.asyncio
async def test_get_observation_not_found(self, api_client, test_bank_id):
"""Test getting a non-existent observation."""
async def test_get_mental_model_not_found(self, api_client, test_bank_id):
"""Test getting a non-existent mental model."""
pass
class TestMentalModelsAPI:
"""Test mental models API endpoints."""
class TestReflectionsAPI:
"""Test reflections API endpoints."""
@pytest.mark.asyncio
async def test_mental_models_api_crud(self, api_client, test_bank_id):
async def test_reflections_api_crud(self, api_client, test_bank_id):
"""Test full CRUD cycle through API."""
import asyncio
# Create bank first via profile endpoint
await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
# Create a mental model (async operation)
# Create a reflection (async operation)
response = await api_client.post(
f"/v1/default/banks/{test_bank_id}/mental-models",
f"/v1/default/banks/{test_bank_id}/reflections",
json={
"name": "API Test Mental Model",
"name": "API Test Reflection",
"source_query": "What is the API test about?",
"content": "This is an API test mental model",
"content": "This is an API test reflection",
"tags": ["api-test"],
},
)
@@ -232,72 +232,44 @@ class TestMentalModelsAPI:
break
await asyncio.sleep(1)
# List mental models to get the created mental model
response = await api_client.get(f"/v1/default/banks/{test_bank_id}/mental-models")
# List reflections to get the created reflection
response = await api_client.get(f"/v1/default/banks/{test_bank_id}/reflections")
assert response.status_code == 200
mental_models = response.json()["items"]
assert len(mental_models) >= 1
reflections = response.json()["items"]
assert len(reflections) >= 1
# Find our mental model
mental_model = next((m for m in mental_models if m["name"] == "API Test Mental Model"), None)
assert mental_model is not None, f"Mental model not found. Items: {mental_models}"
mental_model_id = mental_model["id"]
# Find our reflection
reflection = next((r for r in reflections if r["name"] == "API Test Reflection"), None)
assert reflection is not None, f"Reflection not found. Items: {reflections}"
reflection_id = reflection["id"]
# Get the mental model
response = await api_client.get(f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}")
# Get the reflection
response = await api_client.get(f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}")
assert response.status_code == 200
assert response.json()["name"] == "API Test Mental Model"
assert response.json()["name"] == "API Test Reflection"
# Update the mental model
# Update the reflection
response = await api_client.patch(
f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}",
json={"name": "Updated API Test Mental Model"},
f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}",
json={"name": "Updated API Test Reflection"},
)
assert response.status_code == 200
assert response.json()["name"] == "Updated API Test Mental Model"
assert response.json()["name"] == "Updated API Test Reflection"
# Delete the mental model
response = await api_client.delete(f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}")
# Delete the reflection
response = await api_client.delete(f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}")
assert response.status_code == 200
# Verify deletion
response = await api_client.get(f"/v1/default/banks/{test_bank_id}/mental-models/{mental_model_id}")
response = await api_client.get(f"/v1/default/banks/{test_bank_id}/reflections/{reflection_id}")
assert response.status_code == 404
# Cleanup
await api_client.delete(f"/v1/default/banks/{test_bank_id}")
class TestRecallWithObservationsAndMentalModels:
"""Test recall integration with observations and mental models."""
@pytest.mark.asyncio
async def test_recall_includes_observations(self, api_client, test_bank_id):
"""Test that recall can include observations in the response."""
# Create bank first via profile endpoint
await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
# Note: Observations are auto-created via consolidation, not manually
# This test just verifies the include parameter works
# Recall with observations included
response = await api_client.post(
f"/v1/default/banks/{test_bank_id}/memories/recall",
json={
"query": "What is machine learning?",
"include": {
"observations": {"max_results": 5},
},
},
)
assert response.status_code == 200
result = response.json()
# Should have observations field in response (may be empty)
assert "observations" in result or result.get("observations") is None
# Cleanup
await api_client.delete(f"/v1/default/banks/{test_bank_id}")
class TestRecallWithMentalModelsAndReflections:
"""Test recall integration with mental models and reflections."""
@pytest.mark.asyncio
async def test_recall_includes_mental_models(self, api_client, test_bank_id):
@@ -305,9 +277,37 @@ class TestRecallWithObservationsAndMentalModels:
# Create bank first via profile endpoint
await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
# Create a mental model first
# Note: Mental models are auto-created via consolidation, not manually
# This test just verifies the include parameter works
# Recall with mental models included
response = await api_client.post(
f"/v1/default/banks/{test_bank_id}/mental-models",
f"/v1/default/banks/{test_bank_id}/memories/recall",
json={
"query": "What is machine learning?",
"include": {
"mental_models": {"max_results": 5},
},
},
)
assert response.status_code == 200
result = response.json()
# Should have mental_models field in response (may be empty)
assert "mental_models" in result or result.get("mental_models") is None
# Cleanup
await api_client.delete(f"/v1/default/banks/{test_bank_id}")
@pytest.mark.asyncio
async def test_recall_includes_reflections(self, api_client, test_bank_id):
"""Test that recall can include reflections in the response."""
# Create bank first via profile endpoint
await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
# Create a reflection first
response = await api_client.post(
f"/v1/default/banks/{test_bank_id}/reflections",
json={
"name": "AI Overview",
"source_query": "What is AI?",
@@ -317,32 +317,32 @@ class TestRecallWithObservationsAndMentalModels:
)
assert response.status_code == 200
# Recall with mental models included
# Recall with reflections included
response = await api_client.post(
f"/v1/default/banks/{test_bank_id}/memories/recall",
json={
"query": "What is artificial intelligence?",
"include": {
"mental_models": {"max_results": 5},
"reflections": {"max_results": 5},
},
},
)
assert response.status_code == 200
result = response.json()
# Should have mental_models in response (may be empty if embedding not generated yet)
assert "mental_models" in result or result.get("mental_models") is None
# Should have reflections in response (may be empty if embedding not generated yet)
assert "reflections" in result or result.get("reflections") is None
# Cleanup
await api_client.delete(f"/v1/default/banks/{test_bank_id}")
@pytest.mark.asyncio
async def test_recall_without_observations_by_default(self, api_client, test_bank_id):
"""Test that recall does not include observations by default."""
async def test_recall_without_mental_models_by_default(self, api_client, test_bank_id):
"""Test that recall does not include mental models by default."""
# Create bank first via profile endpoint
await api_client.get(f"/v1/default/banks/{test_bank_id}/profile")
# Recall without specifying observations
# Recall without specifying mental models
response = await api_client.post(
f"/v1/default/banks/{test_bank_id}/memories/recall",
json={
@@ -352,97 +352,8 @@ class TestRecallWithObservationsAndMentalModels:
assert response.status_code == 200
result = response.json()
# Observations should not be in response
assert result.get("observations") is None
# Mental models should not be in response
assert result.get("mental_models") is None
# Cleanup
await api_client.delete(f"/v1/default/banks/{test_bank_id}")
class TestReflectUsesMentalModels:
"""Test that reflect searches and uses mental models when available."""
@pytest.mark.asyncio
async def test_reflect_searches_mental_models_when_available(self, memory: MemoryEngine, request_context):
"""Test that reflect uses search_mental_models when the bank has mental models.
Given:
- A bank with a mental model about "team collaboration"
Expected:
- Reflect should call search_mental_models tool
- The mental model content should influence the response
"""
bank_id = f"test-reflect-mm-{uuid.uuid4().hex[:8]}"
# Create the bank
await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
# Create a mental model about team collaboration
mental_model = await memory.create_mental_model(
bank_id=bank_id,
mental_model_id=str(uuid.uuid4()),
name="Team Collaboration Practices",
source_query="How does the team collaborate?",
content="The team uses async communication via Slack and holds daily standups at 9am. "
"Code reviews are required before merging. The team values documentation and "
"prefers written communication for complex decisions.",
tags=["team"],
request_context=request_context,
)
# Run reflect with a query about team collaboration
result = await memory.reflect_async(
bank_id=bank_id,
query="How does the team work together?",
request_context=request_context,
)
# Check that mental models were searched
tool_calls = result.tool_trace
search_mm_calls = [tc for tc in tool_calls if tc.tool == "search_mental_models"]
assert len(search_mm_calls) > 0, (
f"Expected search_mental_models to be called when bank has mental models. "
f"Tool calls: {[tc.tool for tc in tool_calls]}"
)
# Check that the reason field is populated for debugging
for tc in search_mm_calls:
assert tc.reason is not None, "Tool call should have a reason for debugging"
# The response should mention concepts from the mental model
response_text = result.text.lower()
has_relevant_content = any(
keyword in response_text
for keyword in ["slack", "async", "standup", "code review", "documentation", "communication"]
)
assert has_relevant_content, (
f"Expected response to reference mental model content. Got: {result.text[:500]}"
)
# Cleanup
await memory.delete_bank(bank_id, request_context=request_context)
@pytest.mark.asyncio
async def test_reflect_tool_trace_includes_reason(self, memory: MemoryEngine, request_context):
"""Test that tool traces include the reason field for debugging."""
bank_id = f"test-reflect-reason-{uuid.uuid4().hex[:8]}"
# Create the bank
await memory.get_bank_profile(bank_id=bank_id, request_context=request_context)
# Run reflect - it should use observations or recall
result = await memory.reflect_async(
bank_id=bank_id,
query="What is the weather like?",
request_context=request_context,
)
# All tool calls should have a reason
for tc in result.tool_trace:
if tc.tool != "done": # done doesn't need a reason
assert tc.reason is not None, f"Tool {tc.tool} should have a reason for debugging"
# Cleanup
await memory.delete_bank(bank_id, request_context=request_context)
-114
View File
@@ -2082,117 +2082,3 @@ def test_recall_result_model_empty_construction():
assert result.chunks == {}, "Should have empty chunks"
logger.info("✓ RecallResult empty construction works correctly")
@pytest.mark.asyncio
async def test_custom_extraction_mode():
"""
Test that custom extraction mode uses custom guidelines from env variable.
This test verifies that when HINDSIGHT_API_RETAIN_EXTRACTION_MODE=custom and
HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS is set, the fact extraction uses the
custom guidelines while keeping structural parts intact.
"""
import os
from hindsight_api import LLMConfig
from hindsight_api.engine.retain.fact_extraction import extract_facts_from_text
from hindsight_api.config import clear_config_cache
# Save original env vars
original_mode = os.getenv("HINDSIGHT_API_RETAIN_EXTRACTION_MODE")
original_instructions = os.getenv("HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS")
try:
# Set custom extraction mode with challenging language-specific guidelines
os.environ["HINDSIGHT_API_RETAIN_EXTRACTION_MODE"] = "custom"
os.environ["HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS"] = """ONLY extract facts that are in ITALIAN language.
DO NOT extract:
Facts in English
Facts in any other language besides Italian
If the text contains both Italian and English content, extract ONLY the Italian facts."""
# Clear config cache to pick up new env vars
clear_config_cache()
# Test content with BOTH Italian (should extract) and English (should NOT extract) facts
# This is a much harder test than filtering greetings
text = """
The team discussed the new architecture. We will use microservices.
Il database PostgreSQL ha ridotto la latenza delle query del 60%.
Alice ha suggerito di usare il connection pooling per migliorare le prestazioni.
Bob mentioned that the API endpoint is ready for testing.
The deployment pipeline has been updated to use Kubernetes.
Marco ha completato la revisione del codice e ha approvato le modifiche.
Il sistema di autenticazione è stato migrato a OAuth 2.0.
"""
llm_config = LLMConfig.for_memory()
facts, _, _ = await extract_facts_from_text(
text=text,
event_date=datetime(2024, 1, 15, tzinfo=timezone.utc),
context="team meeting notes",
llm_config=llm_config,
agent_name="TestUser"
)
logger.info(f"\nExtracted {len(facts)} facts with custom mode (Italian only):")
for i, fact in enumerate(facts):
logger.info(f" {i+1}. {fact.fact}")
assert len(facts) > 0, "Should extract at least one Italian fact"
# All facts text
all_facts_text = " ".join([f.fact for f in facts])
# Should HAVE Italian content
italian_keywords = ["postgresql", "latenza", "query", "alice", "connection pooling", "prestazioni",
"marco", "revisione", "codice", "autenticazione", "oauth"]
has_italian = any(keyword in all_facts_text.lower() for keyword in italian_keywords)
assert has_italian, f"Should extract Italian facts. Got: {all_facts_text}"
# Should NOT have English-only content
# These are facts that appear ONLY in English sections
english_only_keywords = ["microservices", "bob", "api endpoint", "testing", "deployment pipeline", "kubernetes"]
# Check if facts contain English-only content (this would be wrong)
facts_lower = all_facts_text.lower()
found_english_only = [kw for kw in english_only_keywords if kw in facts_lower]
if found_english_only:
logger.warning(f"⚠ Found English-only keywords in facts: {found_english_only}")
logger.warning(f" Facts: {all_facts_text}")
logger.warning(f" This may indicate the LLM is not strictly following language-specific custom guidelines")
# Log but don't fail - LLM behavior can vary
else:
logger.info("✓ Successfully extracted only Italian facts, ignored English facts")
# At least verify we have some Italian indicators
italian_indicators = ["latenza", "prestazioni", "revisione", "codice", "autenticazione"]
italian_count = sum(1 for ind in italian_indicators if ind in facts_lower)
assert italian_count >= 1, \
f"Should extract facts with Italian words. Found {italian_count} Italian indicators in: {all_facts_text}"
logger.info("✓ Custom extraction mode works with language-specific guidelines")
logger.info(f"✓ Extracted {len(facts)} Italian facts, found {italian_count} Italian indicators")
finally:
# Restore original env vars
if original_mode is not None:
os.environ["HINDSIGHT_API_RETAIN_EXTRACTION_MODE"] = original_mode
else:
os.environ.pop("HINDSIGHT_API_RETAIN_EXTRACTION_MODE", None)
if original_instructions is not None:
os.environ["HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS"] = original_instructions
else:
os.environ.pop("HINDSIGHT_API_RETAIN_CUSTOM_INSTRUCTIONS", None)
# Clear cache again to restore original config
clear_config_cache()
@@ -22,7 +22,7 @@ TABLES = [
"chunks",
"async_operations",
"directives",
"mental_models",
"reflections",
]
# Files to scan for SQL queries
+7 -13
View File
@@ -633,12 +633,7 @@ async def test_student_tracking_visibility(api_client):
@pytest.mark.asyncio
async def test_list_tags_returns_all_tags(api_client):
"""Test that list_tags returns all unique tags with counts.
Note: list_tags counts all memory units including observations.
Observations inherit tags from their source facts (for visibility security),
so counts may be higher than the number of stored memories.
"""
"""Test that list_tags returns all unique tags with counts."""
bank_id = f"list_tags_test_{datetime.now().timestamp()}"
# Store memories with various tags
@@ -667,19 +662,18 @@ async def test_list_tags_returns_all_tags(api_client):
assert "limit" in result
assert "offset" in result
# Verify tags exist with at least the expected counts
# Note: Counts may be higher due to observations inheriting source fact tags
# Verify tags and counts
tags_map = {item["tag"]: item["count"] for item in result["items"]}
assert "user:alice" in tags_map
assert tags_map["user:alice"] >= 3 # At least 3 memories have this tag
assert tags_map["user:alice"] == 3 # 3 memories have this tag
assert "user:bob" in tags_map
assert tags_map["user:bob"] >= 1
assert tags_map["user:bob"] == 1
assert "session:123" in tags_map
assert tags_map["session:123"] >= 1
assert tags_map["session:123"] == 1
assert "session:456" in tags_map
assert tags_map["session:456"] >= 1
assert tags_map["session:456"] == 1
assert result["total"] >= 4 # At least 4 unique tags
assert result["total"] == 4 # 4 unique tags
@pytest.mark.asyncio
+18 -43
View File
@@ -437,57 +437,57 @@ impl ApiClient {
})
}
// --- Mental Model Methods ---
// --- Reflection Methods ---
pub fn list_mental_models(&self, bank_id: &str, _verbose: bool) -> Result<types::MentalModelListResponse> {
pub fn list_reflections(&self, bank_id: &str, _verbose: bool) -> Result<types::ReflectionListResponse> {
self.runtime.block_on(async {
let response = self.client.list_mental_models(bank_id, None, None, None, None, None).await?;
let response = self.client.list_reflections(bank_id, None, None, None, None, None).await?;
Ok(response.into_inner())
})
}
pub fn get_mental_model(&self, bank_id: &str, mental_model_id: &str, _verbose: bool) -> Result<types::MentalModelResponse> {
pub fn get_reflection(&self, bank_id: &str, reflection_id: &str, _verbose: bool) -> Result<types::ReflectionResponse> {
self.runtime.block_on(async {
let response = self.client.get_mental_model(bank_id, mental_model_id, None).await?;
let response = self.client.get_reflection(bank_id, reflection_id, None).await?;
Ok(response.into_inner())
})
}
pub fn create_mental_model(
pub fn create_reflection(
&self,
bank_id: &str,
request: &types::CreateMentalModelRequest,
request: &types::CreateReflectionRequest,
_verbose: bool,
) -> Result<types::CreateMentalModelResponse> {
) -> Result<types::CreateReflectionResponse> {
self.runtime.block_on(async {
let response = self.client.create_mental_model(bank_id, None, request).await?;
let response = self.client.create_reflection(bank_id, None, request).await?;
Ok(response.into_inner())
})
}
pub fn update_mental_model(
pub fn update_reflection(
&self,
bank_id: &str,
mental_model_id: &str,
request: &types::UpdateMentalModelRequest,
reflection_id: &str,
request: &types::UpdateReflectionRequest,
_verbose: bool,
) -> Result<types::MentalModelResponse> {
) -> Result<types::ReflectionResponse> {
self.runtime.block_on(async {
let response = self.client.update_mental_model(bank_id, mental_model_id, None, request).await?;
let response = self.client.update_reflection(bank_id, reflection_id, None, request).await?;
Ok(response.into_inner())
})
}
pub fn delete_mental_model(&self, bank_id: &str, mental_model_id: &str, _verbose: bool) -> Result<serde_json::Value> {
pub fn delete_reflection(&self, bank_id: &str, reflection_id: &str, _verbose: bool) -> Result<serde_json::Value> {
self.runtime.block_on(async {
let response = self.client.delete_mental_model(bank_id, mental_model_id, None).await?;
let response = self.client.delete_reflection(bank_id, reflection_id, None).await?;
Ok(response.into_inner())
})
}
pub fn refresh_mental_model(&self, bank_id: &str, mental_model_id: &str, _verbose: bool) -> Result<types::AsyncOperationSubmitResponse> {
pub fn refresh_reflection(&self, bank_id: &str, reflection_id: &str, _verbose: bool) -> Result<types::AsyncOperationSubmitResponse> {
self.runtime.block_on(async {
let response = self.client.refresh_mental_model(bank_id, mental_model_id, None).await?;
let response = self.client.refresh_reflection(bank_id, reflection_id, None).await?;
Ok(response.into_inner())
})
}
@@ -539,31 +539,6 @@ impl ApiClient {
Ok(response.into_inner())
})
}
// --- Consolidation Methods ---
pub fn trigger_consolidation(&self, bank_id: &str, _verbose: bool) -> Result<types::ConsolidationResponse> {
self.runtime.block_on(async {
let response = self.client.trigger_consolidation(bank_id, None).await?;
Ok(response.into_inner())
})
}
pub fn clear_observations(&self, bank_id: &str, _verbose: bool) -> Result<types::DeleteResponse> {
self.runtime.block_on(async {
let response = self.client.clear_observations(bank_id, None).await?;
Ok(response.into_inner())
})
}
// --- Version Methods ---
pub fn get_version(&self, _verbose: bool) -> Result<types::VersionResponse> {
self.runtime.block_on(async {
let response = self.client.get_version().await?;
Ok(response.into_inner())
})
}
}
// Re-export types from the generated client for use in commands
-93
View File
@@ -495,96 +495,3 @@ pub fn delete(
Err(e) => Err(e)
}
}
/// Trigger consolidation to create/update observations
pub fn consolidate(
client: &ApiClient,
bank_id: &str,
verbose: bool,
output_format: OutputFormat,
) -> Result<()> {
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Triggering consolidation..."))
} else {
None
};
let response = client.trigger_consolidation(bank_id, verbose);
if let Some(mut sp) = spinner {
sp.finish();
}
match response {
Ok(result) => {
if output_format == OutputFormat::Pretty {
ui::print_success("Consolidation triggered");
println!(" {} {}", ui::dim("Operation ID:"), result.operation_id);
if result.deduplicated {
println!(" {} {}", ui::dim("Note:"), "Reusing existing pending consolidation task");
}
println!();
println!("{}", ui::dim("Use 'hindsight operation get' to check the operation status."));
} else {
output::print_output(&result, output_format)?;
}
Ok(())
}
Err(e) => Err(e),
}
}
/// Clear all observations for a bank
pub fn clear_observations(
client: &ApiClient,
bank_id: &str,
yes: bool,
verbose: bool,
output_format: OutputFormat,
) -> Result<()> {
// Confirmation prompt unless -y flag is used
if !yes && output_format == OutputFormat::Pretty {
let message = format!(
"Are you sure you want to clear all observations for bank '{}'? This cannot be undone.",
bank_id
);
let confirmed = ui::prompt_confirmation(&message)?;
if !confirmed {
ui::print_info("Operation cancelled");
return Ok(());
}
}
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Clearing observations..."))
} else {
None
};
let response = client.clear_observations(bank_id, verbose);
if let Some(mut sp) = spinner {
sp.finish();
}
match response {
Ok(result) => {
if output_format == OutputFormat::Pretty {
if result.success {
ui::print_success(&format!("Observations cleared for bank '{}'", bank_id));
if let Some(count) = result.deleted_count {
println!(" Observations deleted: {}", count);
}
} else {
ui::print_error("Failed to clear observations");
}
} else {
output::print_output(&result, output_format)?;
}
Ok(())
}
Err(e) => Err(e),
}
}
-39
View File
@@ -75,45 +75,6 @@ pub fn health(
}
}
/// Get API version information
pub fn version(
client: &ApiClient,
verbose: bool,
output_format: OutputFormat,
) -> Result<()> {
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Fetching version..."))
} else {
None
};
let response = client.get_version(verbose);
if let Some(mut sp) = spinner {
sp.finish();
}
match response {
Ok(result) => {
if output_format == OutputFormat::Pretty {
ui::print_section_header("API Version");
println!(" {} {}", ui::dim("Version:"), result.api_version);
println!();
println!(" {}", ui::dim("Features:"));
println!(" {} MCP Server: {}", ui::gradient_start(""), if result.features.mcp { "enabled" } else { "disabled" });
println!(" {} Observations: {}", ui::gradient_start(""), if result.features.observations { "enabled" } else { "disabled" });
println!(" {} Background Worker: {}", ui::gradient_start(""), if result.features.worker { "enabled" } else { "disabled" });
println!();
} else {
output::print_output(&result, output_format)?;
}
Ok(())
}
Err(e) => Err(e),
}
}
/// Get Prometheus metrics
pub fn metrics(
client: &ApiClient,
+1 -1
View File
@@ -7,5 +7,5 @@ pub mod explore;
pub mod health;
pub mod memory;
pub mod operation;
pub mod mental_model;
pub mod reflection;
pub mod tag;
@@ -1,4 +1,4 @@
//! Mental model commands for managing user-curated summaries.
//! Reflection commands for managing user-curated summaries.
use anyhow::Result;
@@ -8,7 +8,7 @@ use crate::ui;
use hindsight_client::types;
/// List mental models for a bank
/// List reflections for a bank
pub fn list(
client: &ApiClient,
bank_id: &str,
@@ -16,12 +16,12 @@ pub fn list(
output_format: OutputFormat,
) -> Result<()> {
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Fetching mental models..."))
Some(ui::create_spinner("Fetching reflections..."))
} else {
None
};
let response = client.list_mental_models(bank_id, verbose);
let response = client.list_reflections(bank_id, verbose);
if let Some(mut sp) = spinner {
sp.finish();
@@ -30,21 +30,21 @@ pub fn list(
match response {
Ok(result) => {
if output_format == OutputFormat::Pretty {
ui::print_section_header(&format!("Mental Models: {}", bank_id));
ui::print_section_header(&format!("Reflections: {}", bank_id));
if result.items.is_empty() {
println!(" {}", ui::dim("No mental models found."));
println!(" {}", ui::dim("No reflections found."));
} else {
for mental_model in &result.items {
for reflection in &result.items {
println!(
" {} {}",
ui::gradient_start(&mental_model.id),
mental_model.name
ui::gradient_start(&reflection.id),
reflection.name
);
// Show content preview
let preview: String = mental_model.content.chars().take(80).collect();
let ellipsis = if mental_model.content.len() > 80 { "..." } else { "" };
let preview: String = reflection.content.chars().take(80).collect();
let ellipsis = if reflection.content.len() > 80 { "..." } else { "" };
println!(" {}{}", ui::dim(&preview), ellipsis);
println!();
@@ -59,32 +59,32 @@ pub fn list(
}
}
/// Get a specific mental model
/// Get a specific reflection
pub fn get(
client: &ApiClient,
bank_id: &str,
mental_model_id: &str,
reflection_id: &str,
verbose: bool,
output_format: OutputFormat,
) -> Result<()> {
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Fetching mental model..."))
Some(ui::create_spinner("Fetching reflection..."))
} else {
None
};
let response = client.get_mental_model(bank_id, mental_model_id, verbose);
let response = client.get_reflection(bank_id, reflection_id, verbose);
if let Some(mut sp) = spinner {
sp.finish();
}
match response {
Ok(mental_model) => {
Ok(reflection) => {
if output_format == OutputFormat::Pretty {
print_mental_model_detail(&mental_model);
print_reflection_detail(&reflection);
} else {
output::print_output(&mental_model, output_format)?;
output::print_output(&reflection, output_format)?;
}
Ok(())
}
@@ -92,7 +92,7 @@ pub fn get(
}
}
/// Create a new mental model
/// Create a new reflection
pub fn create(
client: &ApiClient,
bank_id: &str,
@@ -102,20 +102,19 @@ pub fn create(
output_format: OutputFormat,
) -> Result<()> {
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Creating mental model..."))
Some(ui::create_spinner("Creating reflection..."))
} else {
None
};
let request = types::CreateMentalModelRequest {
let request = types::CreateReflectionRequest {
name: name.to_string(),
source_query: source_query.to_string(),
max_tokens: 2048,
tags: vec![],
trigger: None,
};
let response = client.create_mental_model(bank_id, &request, verbose);
let response = client.create_reflection(bank_id, &request, verbose);
if let Some(mut sp) = spinner {
sp.finish();
@@ -124,7 +123,7 @@ pub fn create(
match response {
Ok(result) => {
if output_format == OutputFormat::Pretty {
ui::print_success(&format!("Mental model created, operation_id: {}", result.operation_id));
ui::print_success(&format!("Reflection created, operation_id: {}", result.operation_id));
} else {
output::print_output(&result, output_format)?;
}
@@ -134,11 +133,11 @@ pub fn create(
}
}
/// Update a mental model
/// Update a reflection
pub fn update(
client: &ApiClient,
bank_id: &str,
mental_model_id: &str,
reflection_id: &str,
name: Option<String>,
verbose: bool,
output_format: OutputFormat,
@@ -148,33 +147,27 @@ pub fn update(
}
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Updating mental model..."))
Some(ui::create_spinner("Updating reflection..."))
} else {
None
};
let request = types::UpdateMentalModelRequest {
name,
source_query: None,
max_tokens: None,
tags: None,
trigger: None,
};
let request = types::UpdateReflectionRequest { name };
let response = client.update_mental_model(bank_id, mental_model_id, &request, verbose);
let response = client.update_reflection(bank_id, reflection_id, &request, verbose);
if let Some(mut sp) = spinner {
sp.finish();
}
match response {
Ok(mental_model) => {
Ok(reflection) => {
if output_format == OutputFormat::Pretty {
ui::print_success(&format!("Mental model '{}' updated successfully", mental_model_id));
ui::print_success(&format!("Reflection '{}' updated successfully", reflection_id));
println!();
print_mental_model_detail(&mental_model);
print_reflection_detail(&reflection);
} else {
output::print_output(&mental_model, output_format)?;
output::print_output(&reflection, output_format)?;
}
Ok(())
}
@@ -182,11 +175,11 @@ pub fn update(
}
}
/// Delete a mental model
/// Delete a reflection
pub fn delete(
client: &ApiClient,
bank_id: &str,
mental_model_id: &str,
reflection_id: &str,
yes: bool,
verbose: bool,
output_format: OutputFormat,
@@ -194,8 +187,8 @@ pub fn delete(
// Confirmation prompt unless -y flag is used
if !yes && output_format == OutputFormat::Pretty {
let message = format!(
"Are you sure you want to delete mental model '{}'? This cannot be undone.",
mental_model_id
"Are you sure you want to delete reflection '{}'? This cannot be undone.",
reflection_id
);
let confirmed = ui::prompt_confirmation(&message)?;
@@ -207,12 +200,12 @@ pub fn delete(
}
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Deleting mental model..."))
Some(ui::create_spinner("Deleting reflection..."))
} else {
None
};
let response = client.delete_mental_model(bank_id, mental_model_id, verbose);
let response = client.delete_reflection(bank_id, reflection_id, verbose);
if let Some(mut sp) = spinner {
sp.finish();
@@ -221,7 +214,7 @@ pub fn delete(
match response {
Ok(_) => {
if output_format == OutputFormat::Pretty {
ui::print_success(&format!("Mental model '{}' deleted successfully", mental_model_id));
ui::print_success(&format!("Reflection '{}' deleted successfully", reflection_id));
} else {
println!("{{\"success\": true}}");
}
@@ -231,21 +224,21 @@ pub fn delete(
}
}
/// Refresh a mental model
/// Refresh a reflection
pub fn refresh(
client: &ApiClient,
bank_id: &str,
mental_model_id: &str,
reflection_id: &str,
verbose: bool,
output_format: OutputFormat,
) -> Result<()> {
let spinner = if output_format == OutputFormat::Pretty {
Some(ui::create_spinner("Submitting mental model refresh..."))
Some(ui::create_spinner("Submitting reflection refresh..."))
} else {
None
};
let response = client.refresh_mental_model(bank_id, mental_model_id, verbose);
let response = client.refresh_reflection(bank_id, reflection_id, verbose);
if let Some(mut sp) = spinner {
sp.finish();
@@ -255,7 +248,7 @@ pub fn refresh(
Ok(operation) => {
if output_format == OutputFormat::Pretty {
ui::print_success(&format!(
"Mental model refresh submitted. Operation ID: {}",
"Reflection refresh submitted. Operation ID: {}",
operation.operation_id
));
println!(" {} {}", ui::dim("Status:"), operation.status);
@@ -270,16 +263,16 @@ pub fn refresh(
}
}
// Helper function to print mental model details
fn print_mental_model_detail(mental_model: &types::MentalModelResponse) {
ui::print_section_header(&mental_model.name);
// Helper function to print reflection details
fn print_reflection_detail(reflection: &types::ReflectionResponse) {
ui::print_section_header(&reflection.name);
println!(" {} {}", ui::dim("ID:"), ui::gradient_start(&mental_model.id));
println!(" {} {}", ui::dim("Source Query:"), &mental_model.source_query);
println!(" {} {}", ui::dim("ID:"), ui::gradient_start(&reflection.id));
println!(" {} {}", ui::dim("Source Query:"), &reflection.source_query);
println!();
println!("{}", ui::gradient_text("─── Content ───"));
println!();
println!("{}", &mental_model.content);
println!("{}", &reflection.content);
println!();
}
+34 -60
View File
@@ -95,9 +95,9 @@ enum Commands {
#[command(subcommand)]
Operation(OperationCommands),
/// Manage mental models (user-curated summaries)
/// Manage reflections (user-curated summaries)
#[command(subcommand)]
MentalModel(MentalModelCommands),
Reflection(ReflectionCommands),
/// Manage directives (behavioral rules)
#[command(subcommand)]
@@ -109,9 +109,6 @@ enum Commands {
/// Get Prometheus metrics
Metrics,
/// Get API version information
Version,
/// Interactive TUI explorer (k9s-style) for navigating banks, memories, entities, and performing recall/reflect
#[command(alias = "tui")]
Explore,
@@ -255,22 +252,6 @@ enum BankCommands {
#[arg(short = 'y', long)]
yes: bool,
},
/// Trigger consolidation to create/update observations
Consolidate {
/// Bank ID
bank_id: String,
},
/// Clear all observations for a bank
ClearObservations {
/// Bank ID
bank_id: String,
/// Skip confirmation prompt
#[arg(short = 'y', long)]
yes: bool,
},
}
#[derive(Subcommand)]
@@ -558,67 +539,67 @@ enum ChunkCommands {
}
#[derive(Subcommand)]
enum MentalModelCommands {
/// List mental models for a bank
enum ReflectionCommands {
/// List reflections for a bank
List {
/// Bank ID
bank_id: String,
},
/// Get a specific mental model
/// Get a specific reflection
Get {
/// Bank ID
bank_id: String,
/// Mental model ID
mental_model_id: String,
/// Reflection ID
reflection_id: String,
},
/// Create a new mental model
/// Create a new reflection
Create {
/// Bank ID
bank_id: String,
/// Mental model name
/// Reflection name
name: String,
/// Source query to generate the mental model from
/// Source query to generate the reflection from
source_query: String,
},
/// Update a mental model
/// Update a reflection
Update {
/// Bank ID
bank_id: String,
/// Mental model ID
mental_model_id: String,
/// Reflection ID
reflection_id: String,
/// New name
#[arg(long)]
name: Option<String>,
},
/// Delete a mental model
/// Delete a reflection
Delete {
/// Bank ID
bank_id: String,
/// Mental model ID
mental_model_id: String,
/// Reflection ID
reflection_id: String,
/// Skip confirmation prompt
#[arg(short = 'y', long)]
yes: bool,
},
/// Refresh a mental model (re-run the source query)
/// Refresh a reflection (re-run the source query)
Refresh {
/// Bank ID
bank_id: String,
/// Mental model ID
mental_model_id: String,
/// Reflection ID
reflection_id: String,
},
}
@@ -725,10 +706,9 @@ fn run() -> Result<()> {
Commands::Ui => unreachable!(), // Handled above
Commands::Explore => commands::explore::run(&client),
// Health, Metrics, and Version
// Health and Metrics
Commands::Health => commands::health::health(&client, verbose, output_format),
Commands::Metrics => commands::health::metrics(&client, verbose, output_format),
Commands::Version => commands::health::version(&client, verbose, output_format),
// Bank commands
Commands::Bank(bank_cmd) => match bank_cmd {
@@ -754,12 +734,6 @@ fn run() -> Result<()> {
BankCommands::Delete { bank_id, yes } => {
commands::bank::delete(&client, &bank_id, yes, verbose, output_format)
}
BankCommands::Consolidate { bank_id } => {
commands::bank::consolidate(&client, &bank_id, verbose, output_format)
}
BankCommands::ClearObservations { bank_id, yes } => {
commands::bank::clear_observations(&client, &bank_id, yes, verbose, output_format)
}
},
// Memory commands
@@ -843,25 +817,25 @@ fn run() -> Result<()> {
}
},
// Mental model commands
Commands::MentalModel(mm_cmd) => match mm_cmd {
MentalModelCommands::List { bank_id } => {
commands::mental_model::list(&client, &bank_id, verbose, output_format)
// Reflection commands
Commands::Reflection(ref_cmd) => match ref_cmd {
ReflectionCommands::List { bank_id } => {
commands::reflection::list(&client, &bank_id, verbose, output_format)
}
MentalModelCommands::Get { bank_id, mental_model_id } => {
commands::mental_model::get(&client, &bank_id, &mental_model_id, verbose, output_format)
ReflectionCommands::Get { bank_id, reflection_id } => {
commands::reflection::get(&client, &bank_id, &reflection_id, verbose, output_format)
}
MentalModelCommands::Create { bank_id, name, source_query } => {
commands::mental_model::create(&client, &bank_id, &name, &source_query, verbose, output_format)
ReflectionCommands::Create { bank_id, name, source_query } => {
commands::reflection::create(&client, &bank_id, &name, &source_query, verbose, output_format)
}
MentalModelCommands::Update { bank_id, mental_model_id, name } => {
commands::mental_model::update(&client, &bank_id, &mental_model_id, name, verbose, output_format)
ReflectionCommands::Update { bank_id, reflection_id, name } => {
commands::reflection::update(&client, &bank_id, &reflection_id, name, verbose, output_format)
}
MentalModelCommands::Delete { bank_id, mental_model_id, yes } => {
commands::mental_model::delete(&client, &bank_id, &mental_model_id, yes, verbose, output_format)
ReflectionCommands::Delete { bank_id, reflection_id, yes } => {
commands::reflection::delete(&client, &bank_id, &reflection_id, yes, verbose, output_format)
}
MentalModelCommands::Refresh { bank_id, mental_model_id } => {
commands::mental_model::refresh(&client, &bank_id, &mental_model_id, verbose, output_format)
ReflectionCommands::Refresh { bank_id, reflection_id } => {
commands::reflection::refresh(&client, &bank_id, &reflection_id, verbose, output_format)
}
},
-406
View File
@@ -481,409 +481,3 @@ fn test_json_yaml_output_formats() {
.expect("Expected valid YAML for bank list");
}
}
// ============================================================================
// Directive Tests
// ============================================================================
#[test]
fn test_directive_list() {
skip_if_no_server!();
let bank_id = test_bank_id("dir-list");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// List directives
let output = run_hindsight(&["directive", "list", &bank_id]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
// Should succeed (even if empty)
assert!(
output.status.success(),
"Directive list command failed: {} / {}",
stdout,
stderr
);
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
#[test]
fn test_directive_create_get_update_delete() {
skip_if_no_server!();
let bank_id = test_bank_id("dir-crud");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// Create a directive
let output = run_hindsight(&[
"directive", "create",
&bank_id,
"Test Directive",
"Always respond politely",
]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Directive create failed: stdout={}, stderr={}",
stdout,
stderr
);
// List directives and get the ID
let output = run_hindsight(&["directive", "list", &bank_id, "-o", "json"]);
let stdout = String::from_utf8_lossy(&output.stdout);
assert!(
output.status.success(),
"Directive list failed: {}",
stdout
);
// Parse JSON and get directive ID
let directive_id: Option<String> = if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
result.get("items")
.and_then(|v| v.as_array())
.and_then(|items| items.first())
.and_then(|item| item.get("id"))
.and_then(|v| v.as_str())
.map(|s| s.to_string())
} else {
None
};
if let Some(id) = directive_id {
// Get the directive
let output = run_hindsight(&["directive", "get", &bank_id, &id]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Directive get failed: stdout={}, stderr={}",
stdout,
stderr
);
// Update the directive
let output = run_hindsight(&[
"directive", "update",
&bank_id,
&id,
"--name", "Updated Directive",
"--content", "Always respond very politely",
]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Directive update failed: stdout={}, stderr={}",
stdout,
stderr
);
// Verify update in JSON
let output = run_hindsight(&["directive", "get", &bank_id, &id, "-o", "json"]);
if output.status.success() {
let stdout = String::from_utf8_lossy(&output.stdout);
let result: serde_json::Value = serde_json::from_str(&stdout).unwrap();
assert_eq!(
result.get("name").and_then(|v| v.as_str()),
Some("Updated Directive")
);
}
// Delete the directive
let output = run_hindsight(&["directive", "delete", &bank_id, &id, "-y"]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Directive delete failed: stdout={}, stderr={}",
stdout,
stderr
);
}
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
// ============================================================================
// Mental Model Extended Tests
// ============================================================================
#[test]
fn test_mental_model_get() {
skip_if_no_server!();
let bank_id = test_bank_id("mm-get");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// Create a mental model
let output = run_hindsight(&[
"mental-model", "create",
&bank_id,
"Test Get Model",
"What are the key facts?",
]);
if output.status.success() {
// List to get the ID
let output = run_hindsight(&["mental-model", "list", &bank_id, "-o", "json"]);
let stdout = String::from_utf8_lossy(&output.stdout);
if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
if let Some(id) = result.get("items")
.and_then(|v| v.as_array())
.and_then(|items| items.iter().find(|item| {
item.get("name").and_then(|v| v.as_str()) == Some("Test Get Model")
}))
.and_then(|item| item.get("id"))
.and_then(|v| v.as_str())
{
// Get the mental model
let output = run_hindsight(&["mental-model", "get", &bank_id, id]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Mental model get failed: stdout={}, stderr={}",
stdout,
stderr
);
}
}
}
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
#[test]
fn test_mental_model_update() {
skip_if_no_server!();
let bank_id = test_bank_id("mm-update");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// Create a mental model
let output = run_hindsight(&[
"mental-model", "create",
&bank_id,
"Test Update Model",
"What are the key facts?",
]);
if output.status.success() {
// List to get the ID
let output = run_hindsight(&["mental-model", "list", &bank_id, "-o", "json"]);
let stdout = String::from_utf8_lossy(&output.stdout);
if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
if let Some(id) = result.get("items")
.and_then(|v| v.as_array())
.and_then(|items| items.iter().find(|item| {
item.get("name").and_then(|v| v.as_str()) == Some("Test Update Model")
}))
.and_then(|item| item.get("id"))
.and_then(|v| v.as_str())
{
// Update the mental model
let output = run_hindsight(&[
"mental-model", "update",
&bank_id,
id,
"--name", "Updated Model Name",
]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Mental model update failed: stdout={}, stderr={}",
stdout,
stderr
);
// Verify update
let output = run_hindsight(&["mental-model", "get", &bank_id, id, "-o", "json"]);
if output.status.success() {
let stdout = String::from_utf8_lossy(&output.stdout);
let result: serde_json::Value = serde_json::from_str(&stdout).unwrap();
assert_eq!(
result.get("name").and_then(|v| v.as_str()),
Some("Updated Model Name")
);
}
}
}
}
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
#[test]
fn test_mental_model_refresh() {
skip_if_no_server!();
let bank_id = test_bank_id("mm-refresh");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// Create a mental model
let output = run_hindsight(&[
"mental-model", "create",
&bank_id,
"Test Refresh Model",
"What are the key facts?",
]);
if output.status.success() {
// List to get the ID
let output = run_hindsight(&["mental-model", "list", &bank_id, "-o", "json"]);
let stdout = String::from_utf8_lossy(&output.stdout);
if let Ok(result) = serde_json::from_str::<serde_json::Value>(&stdout) {
if let Some(id) = result.get("items")
.and_then(|v| v.as_array())
.and_then(|items| items.iter().find(|item| {
item.get("name").and_then(|v| v.as_str()) == Some("Test Refresh Model")
}))
.and_then(|item| item.get("id"))
.and_then(|v| v.as_str())
{
// Refresh the mental model
let output = run_hindsight(&["mental-model", "refresh", &bank_id, id]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
assert!(
output.status.success(),
"Mental model refresh failed: stdout={}, stderr={}",
stdout,
stderr
);
}
}
}
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
// ============================================================================
// Bank Consolidation Tests
// ============================================================================
#[test]
fn test_bank_consolidate() {
skip_if_no_server!();
let bank_id = test_bank_id("bank-consolidate");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// Trigger consolidation
let output = run_hindsight(&["bank", "consolidate", &bank_id]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
// Should succeed
assert!(
output.status.success(),
"Bank consolidate command failed: {} / {}",
stdout,
stderr
);
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
#[test]
fn test_bank_clear_observations() {
skip_if_no_server!();
let bank_id = test_bank_id("bank-clear-obs");
// Create the bank first
let _ = run_hindsight(&["bank", "create", &bank_id, "--name", "Test Bank"]);
// Clear observations
let output = run_hindsight(&["bank", "clear-observations", &bank_id, "-y"]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
// Should succeed
assert!(
output.status.success(),
"Bank clear-observations command failed: {} / {}",
stdout,
stderr
);
// Clean up
let _ = run_hindsight(&["bank", "delete", &bank_id, "-y"]);
}
// ============================================================================
// Version Test
// ============================================================================
#[test]
fn test_version() {
skip_if_no_server!();
let output = run_hindsight(&["version"]);
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
// Should succeed
assert!(
output.status.success(),
"Version command failed: {} / {}",
stdout,
stderr
);
}
#[test]
fn test_version_json() {
skip_if_no_server!();
let output = run_hindsight(&["version", "-o", "json"]);
if output.status.success() {
let stdout = String::from_utf8_lossy(&output.stdout);
let result: serde_json::Value = serde_json::from_str(&stdout)
.expect(&format!("Expected valid JSON output, got: {}", stdout));
// Should have api_version and features
assert!(result.get("api_version").is_some(), "Expected api_version field");
assert!(result.get("features").is_some(), "Expected features field");
}
}
@@ -5,9 +5,9 @@ hindsight_client_api/api/directives_api.py
hindsight_client_api/api/documents_api.py
hindsight_client_api/api/entities_api.py
hindsight_client_api/api/memory_api.py
hindsight_client_api/api/mental_models_api.py
hindsight_client_api/api/monitoring_api.py
hindsight_client_api/api/operations_api.py
hindsight_client_api/api/reflections_api.py
hindsight_client_api/api_client.py
hindsight_client_api/api_response.py
hindsight_client_api/configuration.py
@@ -28,8 +28,8 @@ hindsight_client_api/models/chunk_response.py
hindsight_client_api/models/consolidation_response.py
hindsight_client_api/models/create_bank_request.py
hindsight_client_api/models/create_directive_request.py
hindsight_client_api/models/create_mental_model_request.py
hindsight_client_api/models/create_mental_model_response.py
hindsight_client_api/models/create_reflection_request.py
hindsight_client_api/models/create_reflection_response.py
hindsight_client_api/models/delete_document_response.py
hindsight_client_api/models/delete_response.py
hindsight_client_api/models/directive_list_response.py
@@ -51,9 +51,6 @@ hindsight_client_api/models/list_documents_response.py
hindsight_client_api/models/list_memory_units_response.py
hindsight_client_api/models/list_tags_response.py
hindsight_client_api/models/memory_item.py
hindsight_client_api/models/mental_model_list_response.py
hindsight_client_api/models/mental_model_response.py
hindsight_client_api/models/mental_model_trigger.py
hindsight_client_api/models/operation_response.py
hindsight_client_api/models/operation_status_response.py
hindsight_client_api/models/operations_list_response.py
@@ -61,7 +58,6 @@ hindsight_client_api/models/recall_request.py
hindsight_client_api/models/recall_response.py
hindsight_client_api/models/recall_result.py
hindsight_client_api/models/reflect_based_on.py
hindsight_client_api/models/reflect_directive.py
hindsight_client_api/models/reflect_fact.py
hindsight_client_api/models/reflect_include_options.py
hindsight_client_api/models/reflect_llm_call.py
@@ -70,6 +66,8 @@ hindsight_client_api/models/reflect_request.py
hindsight_client_api/models/reflect_response.py
hindsight_client_api/models/reflect_tool_call.py
hindsight_client_api/models/reflect_trace.py
hindsight_client_api/models/reflection_list_response.py
hindsight_client_api/models/reflection_response.py
hindsight_client_api/models/retain_request.py
hindsight_client_api/models/retain_response.py
hindsight_client_api/models/tag_item.py
@@ -77,7 +75,7 @@ hindsight_client_api/models/token_usage.py
hindsight_client_api/models/tool_calls_include_options.py
hindsight_client_api/models/update_directive_request.py
hindsight_client_api/models/update_disposition_request.py
hindsight_client_api/models/update_mental_model_request.py
hindsight_client_api/models/update_reflection_request.py
hindsight_client_api/models/validation_error.py
hindsight_client_api/models/validation_error_loc_inner.py
hindsight_client_api/models/version_response.py
@@ -10,7 +10,7 @@ from datetime import datetime
from typing import Any, Literal
import hindsight_client_api
from hindsight_client_api.api import banks_api, directives_api, memory_api, mental_models_api
from hindsight_client_api.api import banks_api, memory_api
from hindsight_client_api.models import (
memory_item,
recall_request,
@@ -78,8 +78,6 @@ class Hindsight:
self._api_client.set_default_header("Authorization", f"Bearer {api_key}")
self._memory_api = memory_api.MemoryApi(self._api_client)
self._banks_api = banks_api.BanksApi(self._api_client)
self._mental_models_api = mental_models_api.MentalModelsApi(self._api_client)
self._directives_api = directives_api.DirectivesApi(self._api_client)
def __enter__(self):
"""Context manager entry."""
@@ -536,253 +534,3 @@ class Hindsight:
)
return await self._memory_api.reflect(bank_id, request_obj)
# Mental Models methods
def create_mental_model(
self,
bank_id: str,
name: str,
source_query: str,
tags: list[str] | None = None,
max_tokens: int | None = None,
trigger: dict[str, Any] | None = None,
):
"""
Create a mental model (runs reflect in background).
Args:
bank_id: The memory bank ID
name: Human-readable name for the mental model
source_query: The query to run to generate content
tags: Optional tags for filtering during retrieval
max_tokens: Optional maximum tokens for the mental model content
trigger: Optional trigger settings (e.g., {"refresh_after_consolidation": True})
Returns:
CreateMentalModelResponse with operation_id
"""
from hindsight_client_api.models import create_mental_model_request, mental_model_trigger
trigger_obj = None
if trigger:
trigger_obj = mental_model_trigger.MentalModelTrigger(**trigger)
request_obj = create_mental_model_request.CreateMentalModelRequest(
name=name,
source_query=source_query,
tags=tags,
max_tokens=max_tokens,
trigger=trigger_obj,
)
return _run_async(self._mental_models_api.create_mental_model(bank_id, request_obj))
def list_mental_models(self, bank_id: str, tags: list[str] | None = None):
"""
List all mental models in a bank.
Args:
bank_id: The memory bank ID
tags: Optional tags to filter by
Returns:
ListMentalModelsResponse with items
"""
return _run_async(self._mental_models_api.list_mental_models(bank_id, tags=tags))
def get_mental_model(self, bank_id: str, mental_model_id: str):
"""
Get a specific mental model.
Args:
bank_id: The memory bank ID
mental_model_id: The mental model ID
Returns:
MentalModelResponse
"""
return _run_async(self._mental_models_api.get_mental_model(bank_id, mental_model_id))
def refresh_mental_model(self, bank_id: str, mental_model_id: str):
"""
Refresh a mental model to update with current knowledge.
Args:
bank_id: The memory bank ID
mental_model_id: The mental model ID
Returns:
RefreshMentalModelResponse with operation_id
"""
return _run_async(self._mental_models_api.refresh_mental_model(bank_id, mental_model_id))
def update_mental_model(
self,
bank_id: str,
mental_model_id: str,
name: str | None = None,
source_query: str | None = None,
tags: list[str] | None = None,
max_tokens: int | None = None,
trigger: dict[str, Any] | None = None,
):
"""
Update a mental model's metadata.
Args:
bank_id: The memory bank ID
mental_model_id: The mental model ID
name: Optional new name
source_query: Optional new source query
tags: Optional new tags
max_tokens: Optional new max tokens
trigger: Optional trigger settings (e.g., {"refresh_after_consolidation": True})
Returns:
MentalModelResponse
"""
from hindsight_client_api.models import mental_model_trigger, update_mental_model_request
trigger_obj = None
if trigger:
trigger_obj = mental_model_trigger.MentalModelTrigger(**trigger)
request_obj = update_mental_model_request.UpdateMentalModelRequest(
name=name,
source_query=source_query,
tags=tags,
max_tokens=max_tokens,
trigger=trigger_obj,
)
return _run_async(self._mental_models_api.update_mental_model(bank_id, mental_model_id, request_obj))
def delete_mental_model(self, bank_id: str, mental_model_id: str):
"""
Delete a mental model.
Args:
bank_id: The memory bank ID
mental_model_id: The mental model ID
"""
return _run_async(self._mental_models_api.delete_mental_model(bank_id, mental_model_id))
# Directives methods
def create_directive(
self,
bank_id: str,
name: str,
content: str,
priority: int = 0,
is_active: bool = True,
tags: list[str] | None = None,
):
"""
Create a directive (hard rule for reflect).
Args:
bank_id: The memory bank ID
name: Human-readable name for the directive
content: The directive content/rules
priority: Priority level (higher = injected first)
is_active: Whether the directive is active
tags: Optional tags for filtering
Returns:
DirectiveResponse
"""
from hindsight_client_api.models import create_directive_request
request_obj = create_directive_request.CreateDirectiveRequest(
name=name,
content=content,
priority=priority,
is_active=is_active,
tags=tags,
)
return _run_async(self._directives_api.create_directive(bank_id, request_obj))
def list_directives(self, bank_id: str, tags: list[str] | None = None):
"""
List all directives in a bank.
Args:
bank_id: The memory bank ID
tags: Optional tags to filter by
Returns:
ListDirectivesResponse with items
"""
return _run_async(self._directives_api.list_directives(bank_id, tags=tags))
def get_directive(self, bank_id: str, directive_id: str):
"""
Get a specific directive.
Args:
bank_id: The memory bank ID
directive_id: The directive ID
Returns:
DirectiveResponse
"""
return _run_async(self._directives_api.get_directive(bank_id, directive_id))
def update_directive(
self,
bank_id: str,
directive_id: str,
name: str | None = None,
content: str | None = None,
priority: int | None = None,
is_active: bool | None = None,
tags: list[str] | None = None,
):
"""
Update a directive.
Args:
bank_id: The memory bank ID
directive_id: The directive ID
name: Optional new name
content: Optional new content
priority: Optional new priority
is_active: Optional new active status
tags: Optional new tags
Returns:
DirectiveResponse
"""
from hindsight_client_api.models import update_directive_request
request_obj = update_directive_request.UpdateDirectiveRequest(
name=name,
content=content,
priority=priority,
is_active=is_active,
tags=tags,
)
return _run_async(self._directives_api.update_directive(bank_id, directive_id, request_obj))
def delete_directive(self, bank_id: str, directive_id: str):
"""
Delete a directive.
Args:
bank_id: The memory bank ID
directive_id: The directive ID
"""
return _run_async(self._directives_api.delete_directive(bank_id, directive_id))
def delete_bank(self, bank_id: str):
"""
Delete a memory bank.
Args:
bank_id: The memory bank ID
"""
return _run_async(self._banks_api.delete_bank(bank_id))
@@ -22,9 +22,9 @@ from hindsight_client_api.api.directives_api import DirectivesApi
from hindsight_client_api.api.documents_api import DocumentsApi
from hindsight_client_api.api.entities_api import EntitiesApi
from hindsight_client_api.api.memory_api import MemoryApi
from hindsight_client_api.api.mental_models_api import MentalModelsApi
from hindsight_client_api.api.monitoring_api import MonitoringApi
from hindsight_client_api.api.operations_api import OperationsApi
from hindsight_client_api.api.reflections_api import ReflectionsApi
# import ApiClient
from hindsight_client_api.api_response import ApiResponse
@@ -53,8 +53,8 @@ from hindsight_client_api.models.chunk_response import ChunkResponse
from hindsight_client_api.models.consolidation_response import ConsolidationResponse
from hindsight_client_api.models.create_bank_request import CreateBankRequest
from hindsight_client_api.models.create_directive_request import CreateDirectiveRequest
from hindsight_client_api.models.create_mental_model_request import CreateMentalModelRequest
from hindsight_client_api.models.create_mental_model_response import CreateMentalModelResponse
from hindsight_client_api.models.create_reflection_request import CreateReflectionRequest
from hindsight_client_api.models.create_reflection_response import CreateReflectionResponse
from hindsight_client_api.models.delete_document_response import DeleteDocumentResponse
from hindsight_client_api.models.delete_response import DeleteResponse
from hindsight_client_api.models.directive_list_response import DirectiveListResponse
@@ -76,9 +76,6 @@ from hindsight_client_api.models.list_documents_response import ListDocumentsRes
from hindsight_client_api.models.list_memory_units_response import ListMemoryUnitsResponse
from hindsight_client_api.models.list_tags_response import ListTagsResponse
from hindsight_client_api.models.memory_item import MemoryItem
from hindsight_client_api.models.mental_model_list_response import MentalModelListResponse
from hindsight_client_api.models.mental_model_response import MentalModelResponse
from hindsight_client_api.models.mental_model_trigger import MentalModelTrigger
from hindsight_client_api.models.operation_response import OperationResponse
from hindsight_client_api.models.operation_status_response import OperationStatusResponse
from hindsight_client_api.models.operations_list_response import OperationsListResponse
@@ -86,7 +83,6 @@ from hindsight_client_api.models.recall_request import RecallRequest
from hindsight_client_api.models.recall_response import RecallResponse
from hindsight_client_api.models.recall_result import RecallResult
from hindsight_client_api.models.reflect_based_on import ReflectBasedOn
from hindsight_client_api.models.reflect_directive import ReflectDirective
from hindsight_client_api.models.reflect_fact import ReflectFact
from hindsight_client_api.models.reflect_include_options import ReflectIncludeOptions
from hindsight_client_api.models.reflect_llm_call import ReflectLLMCall
@@ -95,6 +91,8 @@ from hindsight_client_api.models.reflect_request import ReflectRequest
from hindsight_client_api.models.reflect_response import ReflectResponse
from hindsight_client_api.models.reflect_tool_call import ReflectToolCall
from hindsight_client_api.models.reflect_trace import ReflectTrace
from hindsight_client_api.models.reflection_list_response import ReflectionListResponse
from hindsight_client_api.models.reflection_response import ReflectionResponse
from hindsight_client_api.models.retain_request import RetainRequest
from hindsight_client_api.models.retain_response import RetainResponse
from hindsight_client_api.models.tag_item import TagItem
@@ -102,7 +100,7 @@ from hindsight_client_api.models.token_usage import TokenUsage
from hindsight_client_api.models.tool_calls_include_options import ToolCallsIncludeOptions
from hindsight_client_api.models.update_directive_request import UpdateDirectiveRequest
from hindsight_client_api.models.update_disposition_request import UpdateDispositionRequest
from hindsight_client_api.models.update_mental_model_request import UpdateMentalModelRequest
from hindsight_client_api.models.update_reflection_request import UpdateReflectionRequest
from hindsight_client_api.models.validation_error import ValidationError
from hindsight_client_api.models.validation_error_loc_inner import ValidationErrorLocInner
from hindsight_client_api.models.version_response import VersionResponse
@@ -6,7 +6,7 @@ from hindsight_client_api.api.directives_api import DirectivesApi
from hindsight_client_api.api.documents_api import DocumentsApi
from hindsight_client_api.api.entities_api import EntitiesApi
from hindsight_client_api.api.memory_api import MemoryApi
from hindsight_client_api.api.mental_models_api import MentalModelsApi
from hindsight_client_api.api.monitoring_api import MonitoringApi
from hindsight_client_api.api.operations_api import OperationsApi
from hindsight_client_api.api.reflections_api import ReflectionsApi
@@ -356,7 +356,7 @@ class BanksApi:
@validate_call
async def clear_observations(
async def clear_mental_models(
self,
bank_id: StrictStr,
authorization: Optional[StrictStr] = None,
@@ -373,9 +373,9 @@ class BanksApi:
_headers: Optional[Dict[StrictStr, Any]] = None,
_host_index: Annotated[StrictInt, Field(ge=0, le=0)] = 0,
) -> DeleteResponse:
"""Clear all observations
"""Clear all mental models
Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
:param bank_id: (required)
:type bank_id: str
@@ -403,7 +403,7 @@ class BanksApi:
:return: Returns the result object.
""" # noqa: E501
_param = self._clear_observations_serialize(
_param = self._clear_mental_models_serialize(
bank_id=bank_id,
authorization=authorization,
_request_auth=_request_auth,
@@ -428,7 +428,7 @@ class BanksApi:
@validate_call
async def clear_observations_with_http_info(
async def clear_mental_models_with_http_info(
self,
bank_id: StrictStr,
authorization: Optional[StrictStr] = None,
@@ -445,9 +445,9 @@ class BanksApi:
_headers: Optional[Dict[StrictStr, Any]] = None,
_host_index: Annotated[StrictInt, Field(ge=0, le=0)] = 0,
) -> ApiResponse[DeleteResponse]:
"""Clear all observations
"""Clear all mental models
Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
:param bank_id: (required)
:type bank_id: str
@@ -475,7 +475,7 @@ class BanksApi:
:return: Returns the result object.
""" # noqa: E501
_param = self._clear_observations_serialize(
_param = self._clear_mental_models_serialize(
bank_id=bank_id,
authorization=authorization,
_request_auth=_request_auth,
@@ -500,7 +500,7 @@ class BanksApi:
@validate_call
async def clear_observations_without_preload_content(
async def clear_mental_models_without_preload_content(
self,
bank_id: StrictStr,
authorization: Optional[StrictStr] = None,
@@ -517,9 +517,9 @@ class BanksApi:
_headers: Optional[Dict[StrictStr, Any]] = None,
_host_index: Annotated[StrictInt, Field(ge=0, le=0)] = 0,
) -> RESTResponseType:
"""Clear all observations
"""Clear all mental models
Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
:param bank_id: (required)
:type bank_id: str
@@ -547,7 +547,7 @@ class BanksApi:
:return: Returns the result object.
""" # noqa: E501
_param = self._clear_observations_serialize(
_param = self._clear_mental_models_serialize(
bank_id=bank_id,
authorization=authorization,
_request_auth=_request_auth,
@@ -567,7 +567,7 @@ class BanksApi:
return response_data.response
def _clear_observations_serialize(
def _clear_mental_models_serialize(
self,
bank_id,
authorization,
@@ -617,7 +617,7 @@ class BanksApi:
return self.api_client.param_serialize(
method='DELETE',
resource_path='/v1/default/banks/{bank_id}/observations',
resource_path='/v1/default/banks/{bank_id}/mental-models',
path_params=_path_params,
query_params=_query_params,
header_params=_header_params,
@@ -2056,7 +2056,7 @@ class BanksApi:
) -> ConsolidationResponse:
"""Trigger consolidation
Run memory consolidation to create/update observations from recent memories.
Run memory consolidation to create/update mental models from recent memories.
:param bank_id: (required)
:type bank_id: str
@@ -2128,7 +2128,7 @@ class BanksApi:
) -> ApiResponse[ConsolidationResponse]:
"""Trigger consolidation
Run memory consolidation to create/update observations from recent memories.
Run memory consolidation to create/update mental models from recent memories.
:param bank_id: (required)
:type bank_id: str
@@ -2200,7 +2200,7 @@ class BanksApi:
) -> RESTResponseType:
"""Trigger consolidation
Run memory consolidation to create/update observations from recent memories.
Run memory consolidation to create/update mental models from recent memories.
:param bank_id: (required)
:type bank_id: str
@@ -29,8 +29,8 @@ from hindsight_client_api.models.chunk_response import ChunkResponse
from hindsight_client_api.models.consolidation_response import ConsolidationResponse
from hindsight_client_api.models.create_bank_request import CreateBankRequest
from hindsight_client_api.models.create_directive_request import CreateDirectiveRequest
from hindsight_client_api.models.create_mental_model_request import CreateMentalModelRequest
from hindsight_client_api.models.create_mental_model_response import CreateMentalModelResponse
from hindsight_client_api.models.create_reflection_request import CreateReflectionRequest
from hindsight_client_api.models.create_reflection_response import CreateReflectionResponse
from hindsight_client_api.models.delete_document_response import DeleteDocumentResponse
from hindsight_client_api.models.delete_response import DeleteResponse
from hindsight_client_api.models.directive_list_response import DirectiveListResponse
@@ -52,9 +52,6 @@ from hindsight_client_api.models.list_documents_response import ListDocumentsRes
from hindsight_client_api.models.list_memory_units_response import ListMemoryUnitsResponse
from hindsight_client_api.models.list_tags_response import ListTagsResponse
from hindsight_client_api.models.memory_item import MemoryItem
from hindsight_client_api.models.mental_model_list_response import MentalModelListResponse
from hindsight_client_api.models.mental_model_response import MentalModelResponse
from hindsight_client_api.models.mental_model_trigger import MentalModelTrigger
from hindsight_client_api.models.operation_response import OperationResponse
from hindsight_client_api.models.operation_status_response import OperationStatusResponse
from hindsight_client_api.models.operations_list_response import OperationsListResponse
@@ -62,7 +59,6 @@ from hindsight_client_api.models.recall_request import RecallRequest
from hindsight_client_api.models.recall_response import RecallResponse
from hindsight_client_api.models.recall_result import RecallResult
from hindsight_client_api.models.reflect_based_on import ReflectBasedOn
from hindsight_client_api.models.reflect_directive import ReflectDirective
from hindsight_client_api.models.reflect_fact import ReflectFact
from hindsight_client_api.models.reflect_include_options import ReflectIncludeOptions
from hindsight_client_api.models.reflect_llm_call import ReflectLLMCall
@@ -71,6 +67,8 @@ from hindsight_client_api.models.reflect_request import ReflectRequest
from hindsight_client_api.models.reflect_response import ReflectResponse
from hindsight_client_api.models.reflect_tool_call import ReflectToolCall
from hindsight_client_api.models.reflect_trace import ReflectTrace
from hindsight_client_api.models.reflection_list_response import ReflectionListResponse
from hindsight_client_api.models.reflection_response import ReflectionResponse
from hindsight_client_api.models.retain_request import RetainRequest
from hindsight_client_api.models.retain_response import RetainResponse
from hindsight_client_api.models.tag_item import TagItem
@@ -78,7 +76,7 @@ from hindsight_client_api.models.token_usage import TokenUsage
from hindsight_client_api.models.tool_calls_include_options import ToolCallsIncludeOptions
from hindsight_client_api.models.update_directive_request import UpdateDirectiveRequest
from hindsight_client_api.models.update_disposition_request import UpdateDispositionRequest
from hindsight_client_api.models.update_mental_model_request import UpdateMentalModelRequest
from hindsight_client_api.models.update_reflection_request import UpdateReflectionRequest
from hindsight_client_api.models.validation_error import ValidationError
from hindsight_client_api.models.validation_error_loc_inner import ValidationErrorLocInner
from hindsight_client_api.models.version_response import VersionResponse
@@ -37,9 +37,9 @@ class BankStatsResponse(BaseModel):
pending_operations: StrictInt
failed_operations: StrictInt
last_consolidated_at: Optional[StrictStr] = None
pending_consolidation: Optional[StrictInt] = Field(default=0, description="Number of memories not yet processed into observations")
total_observations: Optional[StrictInt] = Field(default=0, description="Total number of observations")
__properties: ClassVar[List[str]] = ["bank_id", "total_nodes", "total_links", "total_documents", "nodes_by_fact_type", "links_by_link_type", "links_by_fact_type", "links_breakdown", "pending_operations", "failed_operations", "last_consolidated_at", "pending_consolidation", "total_observations"]
pending_consolidation: Optional[StrictInt] = Field(default=0, description="Number of memories not yet processed into mental models")
total_mental_models: Optional[StrictInt] = Field(default=0, description="Total number of mental models")
__properties: ClassVar[List[str]] = ["bank_id", "total_nodes", "total_links", "total_documents", "nodes_by_fact_type", "links_by_link_type", "links_by_fact_type", "links_breakdown", "pending_operations", "failed_operations", "last_consolidated_at", "pending_consolidation", "total_mental_models"]
model_config = ConfigDict(
populate_by_name=True,
@@ -109,7 +109,7 @@ class BankStatsResponse(BaseModel):
"failed_operations": obj.get("failed_operations"),
"last_consolidated_at": obj.get("last_consolidated_at"),
"pending_consolidation": obj.get("pending_consolidation") if obj.get("pending_consolidation") is not None else 0,
"total_observations": obj.get("total_observations") if obj.get("total_observations") is not None else 0
"total_mental_models": obj.get("total_mental_models") if obj.get("total_mental_models") is not None else 0
})
return _obj
@@ -20,20 +20,18 @@ import json
from pydantic import BaseModel, ConfigDict, Field, StrictStr
from typing import Any, ClassVar, Dict, List, Optional
from typing_extensions import Annotated
from hindsight_client_api.models.mental_model_trigger import MentalModelTrigger
from typing import Optional, Set
from typing_extensions import Self
class CreateMentalModelRequest(BaseModel):
class CreateReflectionRequest(BaseModel):
"""
Request model for creating a mental model.
Request model for creating a reflection.
""" # noqa: E501
name: StrictStr = Field(description="Human-readable name for the mental model")
name: StrictStr = Field(description="Human-readable name for the reflection")
source_query: StrictStr = Field(description="The query to run to generate content")
tags: Optional[List[StrictStr]] = Field(default=None, description="Tags for scoped visibility")
max_tokens: Optional[Annotated[int, Field(le=8192, strict=True, ge=256)]] = Field(default=2048, description="Maximum tokens for generated content")
trigger: Optional[MentalModelTrigger] = Field(default=None, description="Trigger settings")
__properties: ClassVar[List[str]] = ["name", "source_query", "tags", "max_tokens", "trigger"]
__properties: ClassVar[List[str]] = ["name", "source_query", "tags", "max_tokens"]
model_config = ConfigDict(
populate_by_name=True,
@@ -53,7 +51,7 @@ class CreateMentalModelRequest(BaseModel):
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of CreateMentalModelRequest from a JSON string"""
"""Create an instance of CreateReflectionRequest from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
@@ -74,14 +72,11 @@ class CreateMentalModelRequest(BaseModel):
exclude=excluded_fields,
exclude_none=True,
)
# override the default output from pydantic by calling `to_dict()` of trigger
if self.trigger:
_dict['trigger'] = self.trigger.to_dict()
return _dict
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of CreateMentalModelRequest from a dict"""
"""Create an instance of CreateReflectionRequest from a dict"""
if obj is None:
return None
@@ -92,8 +87,7 @@ class CreateMentalModelRequest(BaseModel):
"name": obj.get("name"),
"source_query": obj.get("source_query"),
"tags": obj.get("tags"),
"max_tokens": obj.get("max_tokens") if obj.get("max_tokens") is not None else 2048,
"trigger": MentalModelTrigger.from_dict(obj["trigger"]) if obj.get("trigger") is not None else None
"max_tokens": obj.get("max_tokens") if obj.get("max_tokens") is not None else 2048
})
return _obj
@@ -22,9 +22,9 @@ from typing import Any, ClassVar, Dict, List
from typing import Optional, Set
from typing_extensions import Self
class CreateMentalModelResponse(BaseModel):
class CreateReflectionResponse(BaseModel):
"""
Response model for mental model creation.
Response model for reflection creation.
""" # noqa: E501
operation_id: StrictStr = Field(description="Operation ID to track progress")
__properties: ClassVar[List[str]] = ["operation_id"]
@@ -47,7 +47,7 @@ class CreateMentalModelResponse(BaseModel):
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of CreateMentalModelResponse from a JSON string"""
"""Create an instance of CreateReflectionResponse from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
@@ -72,7 +72,7 @@ class CreateMentalModelResponse(BaseModel):
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of CreateMentalModelResponse from a dict"""
"""Create an instance of CreateReflectionResponse from a dict"""
if obj is None:
return None
@@ -26,10 +26,10 @@ class FeaturesInfo(BaseModel):
"""
Feature flags indicating which capabilities are enabled.
""" # noqa: E501
observations: StrictBool = Field(description="Whether observations (auto-consolidation) are enabled")
mental_models: StrictBool = Field(description="Whether mental models (auto-consolidation) are enabled")
mcp: StrictBool = Field(description="Whether MCP (Model Context Protocol) server is enabled")
worker: StrictBool = Field(description="Whether the background worker is enabled")
__properties: ClassVar[List[str]] = ["observations", "mcp", "worker"]
__properties: ClassVar[List[str]] = ["mental_models", "mcp", "worker"]
model_config = ConfigDict(
populate_by_name=True,
@@ -82,7 +82,7 @@ class FeaturesInfo(BaseModel):
return cls.model_validate(obj)
_obj = cls.model_validate({
"observations": obj.get("observations"),
"mental_models": obj.get("mental_models"),
"mcp": obj.get("mcp"),
"worker": obj.get("worker")
})
@@ -19,20 +19,16 @@ import json
from pydantic import BaseModel, ConfigDict, Field
from typing import Any, ClassVar, Dict, List, Optional
from hindsight_client_api.models.reflect_directive import ReflectDirective
from hindsight_client_api.models.reflect_fact import ReflectFact
from hindsight_client_api.models.reflect_mental_model import ReflectMentalModel
from typing import Optional, Set
from typing_extensions import Self
class ReflectBasedOn(BaseModel):
"""
Evidence the response is based on: memories, mental models, and directives.
Evidence the response is based on: memories and mental models.
""" # noqa: E501
memories: Optional[List[ReflectFact]] = Field(default=None, description="Memory facts used to generate the response")
mental_models: Optional[List[ReflectMentalModel]] = Field(default=None, description="Mental models used during reflection")
directives: Optional[List[ReflectDirective]] = Field(default=None, description="Directives applied during reflection")
__properties: ClassVar[List[str]] = ["memories", "mental_models", "directives"]
__properties: ClassVar[List[str]] = ["memories"]
model_config = ConfigDict(
populate_by_name=True,
@@ -80,20 +76,6 @@ class ReflectBasedOn(BaseModel):
if _item_memories:
_items.append(_item_memories.to_dict())
_dict['memories'] = _items
# override the default output from pydantic by calling `to_dict()` of each item in mental_models (list)
_items = []
if self.mental_models:
for _item_mental_models in self.mental_models:
if _item_mental_models:
_items.append(_item_mental_models.to_dict())
_dict['mental_models'] = _items
# override the default output from pydantic by calling `to_dict()` of each item in directives (list)
_items = []
if self.directives:
for _item_directives in self.directives:
if _item_directives:
_items.append(_item_directives.to_dict())
_dict['directives'] = _items
return _dict
@classmethod
@@ -106,9 +88,7 @@ class ReflectBasedOn(BaseModel):
return cls.model_validate(obj)
_obj = cls.model_validate({
"memories": [ReflectFact.from_dict(_item) for _item in obj["memories"]] if obj.get("memories") is not None else None,
"mental_models": [ReflectMentalModel.from_dict(_item) for _item in obj["mental_models"]] if obj.get("mental_models") is not None else None,
"directives": [ReflectDirective.from_dict(_item) for _item in obj["directives"]] if obj.get("directives") is not None else None
"memories": [ReflectFact.from_dict(_item) for _item in obj["memories"]] if obj.get("memories") is not None else None
})
return _obj
@@ -1,91 +0,0 @@
# coding: utf-8
"""
Hindsight HTTP API
HTTP API for Hindsight
The version of the OpenAPI document: 0.1.0
Generated by OpenAPI Generator (https://openapi-generator.tech)
Do not edit the class manually.
""" # noqa: E501
from __future__ import annotations
import pprint
import re # noqa: F401
import json
from pydantic import BaseModel, ConfigDict, Field, StrictStr
from typing import Any, ClassVar, Dict, List
from typing import Optional, Set
from typing_extensions import Self
class ReflectDirective(BaseModel):
"""
A directive applied during reflect.
""" # noqa: E501
id: StrictStr = Field(description="Directive ID")
name: StrictStr = Field(description="Directive name")
content: StrictStr = Field(description="Directive content")
__properties: ClassVar[List[str]] = ["id", "name", "content"]
model_config = ConfigDict(
populate_by_name=True,
validate_assignment=True,
protected_namespaces=(),
)
def to_str(self) -> str:
"""Returns the string representation of the model using alias"""
return pprint.pformat(self.model_dump(by_alias=True))
def to_json(self) -> str:
"""Returns the JSON representation of the model using alias"""
# TODO: pydantic v2: use .model_dump_json(by_alias=True, exclude_unset=True) instead
return json.dumps(self.to_dict())
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of ReflectDirective from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
"""Return the dictionary representation of the model using alias.
This has the following differences from calling pydantic's
`self.model_dump(by_alias=True)`:
* `None` is only added to the output dict for nullable fields that
were set at model initialization. Other fields with value `None`
are ignored.
"""
excluded_fields: Set[str] = set([
])
_dict = self.model_dump(
by_alias=True,
exclude=excluded_fields,
exclude_none=True,
)
return _dict
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of ReflectDirective from a dict"""
if obj is None:
return None
if not isinstance(obj, dict):
return cls.model_validate(obj)
_obj = cls.model_validate({
"id": obj.get("id"),
"name": obj.get("name"),
"content": obj.get("content")
})
return _obj
@@ -24,12 +24,14 @@ from typing_extensions import Self
class ReflectMentalModel(BaseModel):
"""
A mental model used during reflect.
A mental model accessed during reflect.
""" # noqa: E501
id: StrictStr = Field(description="Mental model ID")
text: StrictStr = Field(description="Mental model content")
context: Optional[StrictStr] = None
__properties: ClassVar[List[str]] = ["id", "text", "context"]
name: StrictStr = Field(description="Mental model name")
type: StrictStr = Field(description="Mental model type: entity, concept, event")
subtype: StrictStr = Field(description="Mental model subtype: structural, emergent, learned, directive")
observations: Optional[List[StrictStr]] = None
__properties: ClassVar[List[str]] = ["id", "name", "type", "subtype", "observations"]
model_config = ConfigDict(
populate_by_name=True,
@@ -70,10 +72,10 @@ class ReflectMentalModel(BaseModel):
exclude=excluded_fields,
exclude_none=True,
)
# set to None if context (nullable) is None
# set to None if observations (nullable) is None
# and model_fields_set contains the field
if self.context is None and "context" in self.model_fields_set:
_dict['context'] = None
if self.observations is None and "observations" in self.model_fields_set:
_dict['observations'] = None
return _dict
@@ -88,8 +90,10 @@ class ReflectMentalModel(BaseModel):
_obj = cls.model_validate({
"id": obj.get("id"),
"text": obj.get("text"),
"context": obj.get("context")
"name": obj.get("name"),
"type": obj.get("type"),
"subtype": obj.get("subtype"),
"observations": obj.get("observations")
})
return _obj
@@ -20,6 +20,7 @@ import json
from pydantic import BaseModel, ConfigDict, Field
from typing import Any, ClassVar, Dict, List, Optional
from hindsight_client_api.models.reflect_llm_call import ReflectLLMCall
from hindsight_client_api.models.reflect_mental_model import ReflectMentalModel
from hindsight_client_api.models.reflect_tool_call import ReflectToolCall
from typing import Optional, Set
from typing_extensions import Self
@@ -30,7 +31,8 @@ class ReflectTrace(BaseModel):
""" # noqa: E501
tool_calls: Optional[List[ReflectToolCall]] = Field(default=None, description="Tool calls made during reflection")
llm_calls: Optional[List[ReflectLLMCall]] = Field(default=None, description="LLM calls made during reflection")
__properties: ClassVar[List[str]] = ["tool_calls", "llm_calls"]
mental_models: Optional[List[ReflectMentalModel]] = Field(default=None, description="Mental models used during reflection (includes directives with subtype='directive')")
__properties: ClassVar[List[str]] = ["tool_calls", "llm_calls", "mental_models"]
model_config = ConfigDict(
populate_by_name=True,
@@ -85,6 +87,13 @@ class ReflectTrace(BaseModel):
if _item_llm_calls:
_items.append(_item_llm_calls.to_dict())
_dict['llm_calls'] = _items
# override the default output from pydantic by calling `to_dict()` of each item in mental_models (list)
_items = []
if self.mental_models:
for _item_mental_models in self.mental_models:
if _item_mental_models:
_items.append(_item_mental_models.to_dict())
_dict['mental_models'] = _items
return _dict
@classmethod
@@ -98,7 +107,8 @@ class ReflectTrace(BaseModel):
_obj = cls.model_validate({
"tool_calls": [ReflectToolCall.from_dict(_item) for _item in obj["tool_calls"]] if obj.get("tool_calls") is not None else None,
"llm_calls": [ReflectLLMCall.from_dict(_item) for _item in obj["llm_calls"]] if obj.get("llm_calls") is not None else None
"llm_calls": [ReflectLLMCall.from_dict(_item) for _item in obj["llm_calls"]] if obj.get("llm_calls") is not None else None,
"mental_models": [ReflectMentalModel.from_dict(_item) for _item in obj["mental_models"]] if obj.get("mental_models") is not None else None
})
return _obj
@@ -19,15 +19,15 @@ import json
from pydantic import BaseModel, ConfigDict
from typing import Any, ClassVar, Dict, List
from hindsight_client_api.models.mental_model_response import MentalModelResponse
from hindsight_client_api.models.reflection_response import ReflectionResponse
from typing import Optional, Set
from typing_extensions import Self
class MentalModelListResponse(BaseModel):
class ReflectionListResponse(BaseModel):
"""
Response model for listing mental models.
Response model for listing reflections.
""" # noqa: E501
items: List[MentalModelResponse]
items: List[ReflectionResponse]
__properties: ClassVar[List[str]] = ["items"]
model_config = ConfigDict(
@@ -48,7 +48,7 @@ class MentalModelListResponse(BaseModel):
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of MentalModelListResponse from a JSON string"""
"""Create an instance of ReflectionListResponse from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
@@ -80,7 +80,7 @@ class MentalModelListResponse(BaseModel):
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of MentalModelListResponse from a dict"""
"""Create an instance of ReflectionListResponse from a dict"""
if obj is None:
return None
@@ -88,7 +88,7 @@ class MentalModelListResponse(BaseModel):
return cls.model_validate(obj)
_obj = cls.model_validate({
"items": [MentalModelResponse.from_dict(_item) for _item in obj["items"]] if obj.get("items") is not None else None
"items": [ReflectionResponse.from_dict(_item) for _item in obj["items"]] if obj.get("items") is not None else None
})
return _obj
@@ -17,15 +17,14 @@ import pprint
import re # noqa: F401
import json
from pydantic import BaseModel, ConfigDict, StrictInt, StrictStr
from pydantic import BaseModel, ConfigDict, StrictStr
from typing import Any, ClassVar, Dict, List, Optional
from hindsight_client_api.models.mental_model_trigger import MentalModelTrigger
from typing import Optional, Set
from typing_extensions import Self
class MentalModelResponse(BaseModel):
class ReflectionResponse(BaseModel):
"""
Response model for a mental model (stored reflect response).
Response model for a reflection.
""" # noqa: E501
id: StrictStr
bank_id: StrictStr
@@ -33,12 +32,10 @@ class MentalModelResponse(BaseModel):
source_query: StrictStr
content: StrictStr
tags: Optional[List[StrictStr]] = None
max_tokens: Optional[StrictInt] = 2048
trigger: Optional[MentalModelTrigger] = None
last_refreshed_at: Optional[StrictStr] = None
created_at: Optional[StrictStr] = None
reflect_response: Optional[Dict[str, Any]] = None
__properties: ClassVar[List[str]] = ["id", "bank_id", "name", "source_query", "content", "tags", "max_tokens", "trigger", "last_refreshed_at", "created_at", "reflect_response"]
__properties: ClassVar[List[str]] = ["id", "bank_id", "name", "source_query", "content", "tags", "last_refreshed_at", "created_at", "reflect_response"]
model_config = ConfigDict(
populate_by_name=True,
@@ -58,7 +55,7 @@ class MentalModelResponse(BaseModel):
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of MentalModelResponse from a JSON string"""
"""Create an instance of ReflectionResponse from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
@@ -79,9 +76,6 @@ class MentalModelResponse(BaseModel):
exclude=excluded_fields,
exclude_none=True,
)
# override the default output from pydantic by calling `to_dict()` of trigger
if self.trigger:
_dict['trigger'] = self.trigger.to_dict()
# set to None if last_refreshed_at (nullable) is None
# and model_fields_set contains the field
if self.last_refreshed_at is None and "last_refreshed_at" in self.model_fields_set:
@@ -101,7 +95,7 @@ class MentalModelResponse(BaseModel):
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of MentalModelResponse from a dict"""
"""Create an instance of ReflectionResponse from a dict"""
if obj is None:
return None
@@ -115,8 +109,6 @@ class MentalModelResponse(BaseModel):
"source_query": obj.get("source_query"),
"content": obj.get("content"),
"tags": obj.get("tags"),
"max_tokens": obj.get("max_tokens") if obj.get("max_tokens") is not None else 2048,
"trigger": MentalModelTrigger.from_dict(obj["trigger"]) if obj.get("trigger") is not None else None,
"last_refreshed_at": obj.get("last_refreshed_at"),
"created_at": obj.get("created_at"),
"reflect_response": obj.get("reflect_response")
@@ -1,125 +0,0 @@
# coding: utf-8
"""
Hindsight HTTP API
HTTP API for Hindsight
The version of the OpenAPI document: 0.1.0
Generated by OpenAPI Generator (https://openapi-generator.tech)
Do not edit the class manually.
""" # noqa: E501
from __future__ import annotations
import pprint
import re # noqa: F401
import json
from pydantic import BaseModel, ConfigDict, Field, StrictStr
from typing import Any, ClassVar, Dict, List, Optional
from typing_extensions import Annotated
from hindsight_client_api.models.mental_model_trigger import MentalModelTrigger
from typing import Optional, Set
from typing_extensions import Self
class UpdateMentalModelRequest(BaseModel):
"""
Request model for updating a mental model.
""" # noqa: E501
name: Optional[StrictStr] = None
source_query: Optional[StrictStr] = None
max_tokens: Optional[Annotated[int, Field(le=8192, strict=True, ge=256)]] = None
tags: Optional[List[StrictStr]] = None
trigger: Optional[MentalModelTrigger] = None
__properties: ClassVar[List[str]] = ["name", "source_query", "max_tokens", "tags", "trigger"]
model_config = ConfigDict(
populate_by_name=True,
validate_assignment=True,
protected_namespaces=(),
)
def to_str(self) -> str:
"""Returns the string representation of the model using alias"""
return pprint.pformat(self.model_dump(by_alias=True))
def to_json(self) -> str:
"""Returns the JSON representation of the model using alias"""
# TODO: pydantic v2: use .model_dump_json(by_alias=True, exclude_unset=True) instead
return json.dumps(self.to_dict())
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of UpdateMentalModelRequest from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
"""Return the dictionary representation of the model using alias.
This has the following differences from calling pydantic's
`self.model_dump(by_alias=True)`:
* `None` is only added to the output dict for nullable fields that
were set at model initialization. Other fields with value `None`
are ignored.
"""
excluded_fields: Set[str] = set([
])
_dict = self.model_dump(
by_alias=True,
exclude=excluded_fields,
exclude_none=True,
)
# override the default output from pydantic by calling `to_dict()` of trigger
if self.trigger:
_dict['trigger'] = self.trigger.to_dict()
# set to None if name (nullable) is None
# and model_fields_set contains the field
if self.name is None and "name" in self.model_fields_set:
_dict['name'] = None
# set to None if source_query (nullable) is None
# and model_fields_set contains the field
if self.source_query is None and "source_query" in self.model_fields_set:
_dict['source_query'] = None
# set to None if max_tokens (nullable) is None
# and model_fields_set contains the field
if self.max_tokens is None and "max_tokens" in self.model_fields_set:
_dict['max_tokens'] = None
# set to None if tags (nullable) is None
# and model_fields_set contains the field
if self.tags is None and "tags" in self.model_fields_set:
_dict['tags'] = None
# set to None if trigger (nullable) is None
# and model_fields_set contains the field
if self.trigger is None and "trigger" in self.model_fields_set:
_dict['trigger'] = None
return _dict
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of UpdateMentalModelRequest from a dict"""
if obj is None:
return None
if not isinstance(obj, dict):
return cls.model_validate(obj)
_obj = cls.model_validate({
"name": obj.get("name"),
"source_query": obj.get("source_query"),
"max_tokens": obj.get("max_tokens"),
"tags": obj.get("tags"),
"trigger": MentalModelTrigger.from_dict(obj["trigger"]) if obj.get("trigger") is not None else None
})
return _obj
@@ -17,17 +17,17 @@ import pprint
import re # noqa: F401
import json
from pydantic import BaseModel, ConfigDict, Field, StrictBool
from pydantic import BaseModel, ConfigDict, StrictStr
from typing import Any, ClassVar, Dict, List, Optional
from typing import Optional, Set
from typing_extensions import Self
class MentalModelTrigger(BaseModel):
class UpdateReflectionRequest(BaseModel):
"""
Trigger settings for a mental model.
Request model for updating a reflection.
""" # noqa: E501
refresh_after_consolidation: Optional[StrictBool] = Field(default=False, description="If true, refresh this mental model after observations consolidation (real-time mode)")
__properties: ClassVar[List[str]] = ["refresh_after_consolidation"]
name: Optional[StrictStr] = None
__properties: ClassVar[List[str]] = ["name"]
model_config = ConfigDict(
populate_by_name=True,
@@ -47,7 +47,7 @@ class MentalModelTrigger(BaseModel):
@classmethod
def from_json(cls, json_str: str) -> Optional[Self]:
"""Create an instance of MentalModelTrigger from a JSON string"""
"""Create an instance of UpdateReflectionRequest from a JSON string"""
return cls.from_dict(json.loads(json_str))
def to_dict(self) -> Dict[str, Any]:
@@ -68,11 +68,16 @@ class MentalModelTrigger(BaseModel):
exclude=excluded_fields,
exclude_none=True,
)
# set to None if name (nullable) is None
# and model_fields_set contains the field
if self.name is None and "name" in self.model_fields_set:
_dict['name'] = None
return _dict
@classmethod
def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
"""Create an instance of MentalModelTrigger from a dict"""
"""Create an instance of UpdateReflectionRequest from a dict"""
if obj is None:
return None
@@ -80,7 +85,7 @@ class MentalModelTrigger(BaseModel):
return cls.model_validate(obj)
_obj = cls.model_validate({
"refresh_after_consolidation": obj.get("refresh_after_consolidation") if obj.get("refresh_after_consolidation") is not None else False
"name": obj.get("name")
})
return _obj
@@ -12,18 +12,18 @@ import type {
ClearBankMemoriesData,
ClearBankMemoriesErrors,
ClearBankMemoriesResponses,
ClearObservationsData,
ClearObservationsErrors,
ClearObservationsResponses,
ClearMentalModelsData,
ClearMentalModelsErrors,
ClearMentalModelsResponses,
CreateDirectiveData,
CreateDirectiveErrors,
CreateDirectiveResponses,
CreateMentalModelData,
CreateMentalModelErrors,
CreateMentalModelResponses,
CreateOrUpdateBankData,
CreateOrUpdateBankErrors,
CreateOrUpdateBankResponses,
CreateReflectionData,
CreateReflectionErrors,
CreateReflectionResponses,
DeleteBankData,
DeleteBankErrors,
DeleteBankResponses,
@@ -33,9 +33,9 @@ import type {
DeleteDocumentData,
DeleteDocumentErrors,
DeleteDocumentResponses,
DeleteMentalModelData,
DeleteMentalModelErrors,
DeleteMentalModelResponses,
DeleteReflectionData,
DeleteReflectionErrors,
DeleteReflectionResponses,
GetAgentStatsData,
GetAgentStatsErrors,
GetAgentStatsResponses,
@@ -60,12 +60,12 @@ import type {
GetMemoryData,
GetMemoryErrors,
GetMemoryResponses,
GetMentalModelData,
GetMentalModelErrors,
GetMentalModelResponses,
GetOperationStatusData,
GetOperationStatusErrors,
GetOperationStatusResponses,
GetReflectionData,
GetReflectionErrors,
GetReflectionResponses,
GetVersionData,
GetVersionResponses,
HealthEndpointHealthGetData,
@@ -85,12 +85,12 @@ import type {
ListMemoriesData,
ListMemoriesErrors,
ListMemoriesResponses,
ListMentalModelsData,
ListMentalModelsErrors,
ListMentalModelsResponses,
ListOperationsData,
ListOperationsErrors,
ListOperationsResponses,
ListReflectionsData,
ListReflectionsErrors,
ListReflectionsResponses,
ListTagsData,
ListTagsErrors,
ListTagsResponses,
@@ -102,9 +102,9 @@ import type {
ReflectData,
ReflectErrors,
ReflectResponses,
RefreshMentalModelData,
RefreshMentalModelErrors,
RefreshMentalModelResponses,
RefreshReflectionData,
RefreshReflectionErrors,
RefreshReflectionResponses,
RegenerateEntityObservationsData,
RegenerateEntityObservationsErrors,
RegenerateEntityObservationsResponses,
@@ -123,9 +123,9 @@ import type {
UpdateDirectiveData,
UpdateDirectiveErrors,
UpdateDirectiveResponses,
UpdateMentalModelData,
UpdateMentalModelErrors,
UpdateMentalModelResponses,
UpdateReflectionData,
UpdateReflectionErrors,
UpdateReflectionResponses,
} from "./types.gen";
export type Options<
@@ -363,33 +363,33 @@ export const regenerateEntityObservations = <
});
/**
* List mental models
* List reflections
*
* List user-curated living documents that stay current.
*/
export const listMentalModels = <ThrowOnError extends boolean = false>(
options: Options<ListMentalModelsData, ThrowOnError>,
export const listReflections = <ThrowOnError extends boolean = false>(
options: Options<ListReflectionsData, ThrowOnError>,
) =>
(options.client ?? client).get<
ListMentalModelsResponses,
ListMentalModelsErrors,
ListReflectionsResponses,
ListReflectionsErrors,
ThrowOnError
>({ url: "/v1/default/banks/{bank_id}/mental-models", ...options });
>({ url: "/v1/default/banks/{bank_id}/reflections", ...options });
/**
* Create mental model
* Create reflection
*
* Create a mental model by running reflect with the source query in the background. Returns an operation ID to track progress. The content is auto-generated by the reflect endpoint. Use the operations endpoint to check completion status.
* Create a reflection by running reflect with the source query in the background. Returns an operation ID to track progress. The content is auto-generated by the reflect endpoint. Use the operations endpoint to check completion status.
*/
export const createMentalModel = <ThrowOnError extends boolean = false>(
options: Options<CreateMentalModelData, ThrowOnError>,
export const createReflection = <ThrowOnError extends boolean = false>(
options: Options<CreateReflectionData, ThrowOnError>,
) =>
(options.client ?? client).post<
CreateMentalModelResponses,
CreateMentalModelErrors,
CreateReflectionResponses,
CreateReflectionErrors,
ThrowOnError
>({
url: "/v1/default/banks/{bank_id}/mental-models",
url: "/v1/default/banks/{bank_id}/reflections",
...options,
headers: {
"Content-Type": "application/json",
@@ -398,53 +398,53 @@ export const createMentalModel = <ThrowOnError extends boolean = false>(
});
/**
* Delete mental model
* Delete reflection
*
* Delete a mental model.
* Delete a reflection.
*/
export const deleteMentalModel = <ThrowOnError extends boolean = false>(
options: Options<DeleteMentalModelData, ThrowOnError>,
export const deleteReflection = <ThrowOnError extends boolean = false>(
options: Options<DeleteReflectionData, ThrowOnError>,
) =>
(options.client ?? client).delete<
DeleteMentalModelResponses,
DeleteMentalModelErrors,
DeleteReflectionResponses,
DeleteReflectionErrors,
ThrowOnError
>({
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}",
...options,
});
/**
* Get mental model
* Get reflection
*
* Get a specific mental model by ID.
* Get a specific reflection by ID.
*/
export const getMentalModel = <ThrowOnError extends boolean = false>(
options: Options<GetMentalModelData, ThrowOnError>,
export const getReflection = <ThrowOnError extends boolean = false>(
options: Options<GetReflectionData, ThrowOnError>,
) =>
(options.client ?? client).get<
GetMentalModelResponses,
GetMentalModelErrors,
GetReflectionResponses,
GetReflectionErrors,
ThrowOnError
>({
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}",
...options,
});
/**
* Update mental model
* Update reflection
*
* Update a mental model's name and/or source query.
* Update a reflection's name.
*/
export const updateMentalModel = <ThrowOnError extends boolean = false>(
options: Options<UpdateMentalModelData, ThrowOnError>,
export const updateReflection = <ThrowOnError extends boolean = false>(
options: Options<UpdateReflectionData, ThrowOnError>,
) =>
(options.client ?? client).patch<
UpdateMentalModelResponses,
UpdateMentalModelErrors,
UpdateReflectionResponses,
UpdateReflectionErrors,
ThrowOnError
>({
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}",
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}",
...options,
headers: {
"Content-Type": "application/json",
@@ -453,19 +453,19 @@ export const updateMentalModel = <ThrowOnError extends boolean = false>(
});
/**
* Refresh mental model
* Refresh reflection
*
* Submit an async task to re-run the source query through reflect and update the content.
*/
export const refreshMentalModel = <ThrowOnError extends boolean = false>(
options: Options<RefreshMentalModelData, ThrowOnError>,
export const refreshReflection = <ThrowOnError extends boolean = false>(
options: Options<RefreshReflectionData, ThrowOnError>,
) =>
(options.client ?? client).post<
RefreshMentalModelResponses,
RefreshMentalModelErrors,
RefreshReflectionResponses,
RefreshReflectionErrors,
ThrowOnError
>({
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}/refresh",
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}/refresh",
...options,
});
@@ -799,23 +799,23 @@ export const createOrUpdateBank = <ThrowOnError extends boolean = false>(
});
/**
* Clear all observations
* Clear all mental models
*
* Delete all observations for a memory bank. This is useful for resetting the consolidated knowledge.
* Delete all mental models for a memory bank. This is useful for resetting the consolidated knowledge.
*/
export const clearObservations = <ThrowOnError extends boolean = false>(
options: Options<ClearObservationsData, ThrowOnError>,
export const clearMentalModels = <ThrowOnError extends boolean = false>(
options: Options<ClearMentalModelsData, ThrowOnError>,
) =>
(options.client ?? client).delete<
ClearObservationsResponses,
ClearObservationsErrors,
ClearMentalModelsResponses,
ClearMentalModelsErrors,
ThrowOnError
>({ url: "/v1/default/banks/{bank_id}/observations", ...options });
>({ url: "/v1/default/banks/{bank_id}/mental-models", ...options });
/**
* Trigger consolidation
*
* Run memory consolidation to create/update observations from recent memories.
* Run memory consolidation to create/update mental models from recent memories.
*/
export const triggerConsolidation = <ThrowOnError extends boolean = false>(
options: Options<TriggerConsolidationData, ThrowOnError>,
@@ -194,15 +194,15 @@ export type BankStatsResponse = {
/**
* Pending Consolidation
*
* Number of memories not yet processed into observations
* Number of memories not yet processed into mental models
*/
pending_consolidation?: number;
/**
* Total Observations
* Total Mental Models
*
* Total number of observations
* Total number of mental models
*/
total_observations?: number;
total_mental_models?: number;
};
/**
@@ -388,15 +388,15 @@ export type CreateDirectiveRequest = {
};
/**
* CreateMentalModelRequest
* CreateReflectionRequest
*
* Request model for creating a mental model.
* Request model for creating a reflection.
*/
export type CreateMentalModelRequest = {
export type CreateReflectionRequest = {
/**
* Name
*
* Human-readable name for the mental model
* Human-readable name for the reflection
*/
name: string;
/**
@@ -417,18 +417,14 @@ export type CreateMentalModelRequest = {
* Maximum tokens for generated content
*/
max_tokens?: number;
/**
* Trigger settings
*/
trigger?: MentalModelTrigger;
};
/**
* CreateMentalModelResponse
* CreateReflectionResponse
*
* Response model for mental model creation.
* Response model for reflection creation.
*/
export type CreateMentalModelResponse = {
export type CreateReflectionResponse = {
/**
* Operation Id
*
@@ -787,11 +783,11 @@ export type FactsIncludeOptions = {
*/
export type FeaturesInfo = {
/**
* Observations
* Mental Models
*
* Whether observations (auto-consolidation) are enabled
* Whether mental models (auto-consolidation) are enabled
*/
observations: boolean;
mental_models: boolean;
/**
* Mcp
*
@@ -986,85 +982,6 @@ export type MemoryItem = {
tags?: Array<string> | null;
};
/**
* MentalModelListResponse
*
* Response model for listing mental models.
*/
export type MentalModelListResponse = {
/**
* Items
*/
items: Array<MentalModelResponse>;
};
/**
* MentalModelResponse
*
* Response model for a mental model (stored reflect response).
*/
export type MentalModelResponse = {
/**
* Id
*/
id: string;
/**
* Bank Id
*/
bank_id: string;
/**
* Name
*/
name: string;
/**
* Source Query
*/
source_query: string;
/**
* Content
*/
content: string;
/**
* Tags
*/
tags?: Array<string>;
/**
* Max Tokens
*/
max_tokens?: number;
trigger?: MentalModelTrigger;
/**
* Last Refreshed At
*/
last_refreshed_at?: string | null;
/**
* Created At
*/
created_at?: string | null;
/**
* Reflect Response
*
* Full reflect API response payload including based_on facts and observations
*/
reflect_response?: {
[key: string]: unknown;
} | null;
};
/**
* MentalModelTrigger
*
* Trigger settings for a mental model.
*/
export type MentalModelTrigger = {
/**
* Refresh After Consolidation
*
* If true, refresh this mental model after observations consolidation (real-time mode)
*/
refresh_after_consolidation?: boolean;
};
/**
* OperationResponse
*
@@ -1178,7 +1095,7 @@ export type RecallRequest = {
/**
* Types
*
* List of fact types to recall: 'world', 'experience', 'observation'. Defaults to world and experience if not specified. Note: 'opinion' is accepted but ignored (opinions are excluded from recall).
* List of fact types to recall: 'world', 'experience', 'mental_model'. Defaults to world and experience if not specified. Note: 'opinion' is accepted but ignored (opinions are excluded from recall).
*/
types?: Array<string> | null;
budget?: Budget;
@@ -1309,7 +1226,7 @@ export type RecallResult = {
/**
* ReflectBasedOn
*
* Evidence the response is based on: memories, mental models, and directives.
* Evidence the response is based on: memories and mental models.
*/
export type ReflectBasedOn = {
/**
@@ -1318,44 +1235,6 @@ export type ReflectBasedOn = {
* Memory facts used to generate the response
*/
memories?: Array<ReflectFact>;
/**
* Mental Models
*
* Mental models used during reflection
*/
mental_models?: Array<ReflectMentalModel>;
/**
* Directives
*
* Directives applied during reflection
*/
directives?: Array<ReflectDirective>;
};
/**
* ReflectDirective
*
* A directive applied during reflect.
*/
export type ReflectDirective = {
/**
* Id
*
* Directive ID
*/
id: string;
/**
* Name
*
* Directive name
*/
name: string;
/**
* Content
*
* Directive content
*/
content: string;
};
/**
@@ -1429,7 +1308,7 @@ export type ReflectLlmCall = {
/**
* ReflectMentalModel
*
* A mental model used during reflect.
* A mental model accessed during reflect.
*/
export type ReflectMentalModel = {
/**
@@ -1439,17 +1318,29 @@ export type ReflectMentalModel = {
*/
id: string;
/**
* Text
* Name
*
* Mental model content
* Mental model name
*/
text: string;
name: string;
/**
* Context
* Type
*
* Additional context
* Mental model type: entity, concept, event
*/
context?: string | null;
type: string;
/**
* Subtype
*
* Mental model subtype: structural, emergent, learned, directive
*/
subtype: string;
/**
* Observations
*
* Observations for directive mental models (subtype='directive')
*/
observations?: Array<string> | null;
};
/**
@@ -1595,6 +1486,72 @@ export type ReflectTrace = {
* LLM calls made during reflection
*/
llm_calls?: Array<ReflectLlmCall>;
/**
* Mental Models
*
* Mental models used during reflection (includes directives with subtype='directive')
*/
mental_models?: Array<ReflectMentalModel>;
};
/**
* ReflectionListResponse
*
* Response model for listing reflections.
*/
export type ReflectionListResponse = {
/**
* Items
*/
items: Array<ReflectionResponse>;
};
/**
* ReflectionResponse
*
* Response model for a reflection.
*/
export type ReflectionResponse = {
/**
* Id
*/
id: string;
/**
* Bank Id
*/
bank_id: string;
/**
* Name
*/
name: string;
/**
* Source Query
*/
source_query: string;
/**
* Content
*/
content: string;
/**
* Tags
*/
tags?: Array<string>;
/**
* Last Refreshed At
*/
last_refreshed_at?: string | null;
/**
* Created At
*/
created_at?: string | null;
/**
* Reflect Response
*
* Full reflect API response payload including based_on facts and mental_models
*/
reflect_response?: {
[key: string]: unknown;
} | null;
};
/**
@@ -1768,39 +1725,17 @@ export type UpdateDispositionRequest = {
};
/**
* UpdateMentalModelRequest
* UpdateReflectionRequest
*
* Request model for updating a mental model.
* Request model for updating a reflection.
*/
export type UpdateMentalModelRequest = {
export type UpdateReflectionRequest = {
/**
* Name
*
* New name for the mental model
* New name for the reflection
*/
name?: string | null;
/**
* Source Query
*
* New source query for the mental model
*/
source_query?: string | null;
/**
* Max Tokens
*
* Maximum tokens for generated content
*/
max_tokens?: number | null;
/**
* Tags
*
* Tags for scoped visibility
*/
tags?: Array<string> | null;
/**
* Trigger settings
*/
trigger?: MentalModelTrigger | null;
};
/**
@@ -2294,7 +2229,7 @@ export type RegenerateEntityObservationsResponses = {
export type RegenerateEntityObservationsResponse =
RegenerateEntityObservationsResponses[keyof RegenerateEntityObservationsResponses];
export type ListMentalModelsData = {
export type ListReflectionsData = {
body?: never;
headers?: {
/**
@@ -2330,31 +2265,31 @@ export type ListMentalModelsData = {
*/
offset?: number;
};
url: "/v1/default/banks/{bank_id}/mental-models";
url: "/v1/default/banks/{bank_id}/reflections";
};
export type ListMentalModelsErrors = {
export type ListReflectionsErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type ListMentalModelsError =
ListMentalModelsErrors[keyof ListMentalModelsErrors];
export type ListReflectionsError =
ListReflectionsErrors[keyof ListReflectionsErrors];
export type ListMentalModelsResponses = {
export type ListReflectionsResponses = {
/**
* Successful Response
*/
200: MentalModelListResponse;
200: ReflectionListResponse;
};
export type ListMentalModelsResponse =
ListMentalModelsResponses[keyof ListMentalModelsResponses];
export type ListReflectionsResponse =
ListReflectionsResponses[keyof ListReflectionsResponses];
export type CreateMentalModelData = {
body: CreateMentalModelRequest;
export type CreateReflectionData = {
body: CreateReflectionRequest;
headers?: {
/**
* Authorization
@@ -2368,30 +2303,30 @@ export type CreateMentalModelData = {
bank_id: string;
};
query?: never;
url: "/v1/default/banks/{bank_id}/mental-models";
url: "/v1/default/banks/{bank_id}/reflections";
};
export type CreateMentalModelErrors = {
export type CreateReflectionErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type CreateMentalModelError =
CreateMentalModelErrors[keyof CreateMentalModelErrors];
export type CreateReflectionError =
CreateReflectionErrors[keyof CreateReflectionErrors];
export type CreateMentalModelResponses = {
export type CreateReflectionResponses = {
/**
* Successful Response
*/
200: CreateMentalModelResponse;
200: CreateReflectionResponse;
};
export type CreateMentalModelResponse2 =
CreateMentalModelResponses[keyof CreateMentalModelResponses];
export type CreateReflectionResponse2 =
CreateReflectionResponses[keyof CreateReflectionResponses];
export type DeleteMentalModelData = {
export type DeleteReflectionData = {
body?: never;
headers?: {
/**
@@ -2405,32 +2340,32 @@ export type DeleteMentalModelData = {
*/
bank_id: string;
/**
* Mental Model Id
* Reflection Id
*/
mental_model_id: string;
reflection_id: string;
};
query?: never;
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}";
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}";
};
export type DeleteMentalModelErrors = {
export type DeleteReflectionErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type DeleteMentalModelError =
DeleteMentalModelErrors[keyof DeleteMentalModelErrors];
export type DeleteReflectionError =
DeleteReflectionErrors[keyof DeleteReflectionErrors];
export type DeleteMentalModelResponses = {
export type DeleteReflectionResponses = {
/**
* Successful Response
*/
200: unknown;
};
export type GetMentalModelData = {
export type GetReflectionData = {
body?: never;
headers?: {
/**
@@ -2444,36 +2379,35 @@ export type GetMentalModelData = {
*/
bank_id: string;
/**
* Mental Model Id
* Reflection Id
*/
mental_model_id: string;
reflection_id: string;
};
query?: never;
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}";
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}";
};
export type GetMentalModelErrors = {
export type GetReflectionErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type GetMentalModelError =
GetMentalModelErrors[keyof GetMentalModelErrors];
export type GetReflectionError = GetReflectionErrors[keyof GetReflectionErrors];
export type GetMentalModelResponses = {
export type GetReflectionResponses = {
/**
* Successful Response
*/
200: MentalModelResponse;
200: ReflectionResponse;
};
export type GetMentalModelResponse =
GetMentalModelResponses[keyof GetMentalModelResponses];
export type GetReflectionResponse =
GetReflectionResponses[keyof GetReflectionResponses];
export type UpdateMentalModelData = {
body: UpdateMentalModelRequest;
export type UpdateReflectionData = {
body: UpdateReflectionRequest;
headers?: {
/**
* Authorization
@@ -2486,35 +2420,35 @@ export type UpdateMentalModelData = {
*/
bank_id: string;
/**
* Mental Model Id
* Reflection Id
*/
mental_model_id: string;
reflection_id: string;
};
query?: never;
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}";
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}";
};
export type UpdateMentalModelErrors = {
export type UpdateReflectionErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type UpdateMentalModelError =
UpdateMentalModelErrors[keyof UpdateMentalModelErrors];
export type UpdateReflectionError =
UpdateReflectionErrors[keyof UpdateReflectionErrors];
export type UpdateMentalModelResponses = {
export type UpdateReflectionResponses = {
/**
* Successful Response
*/
200: MentalModelResponse;
200: ReflectionResponse;
};
export type UpdateMentalModelResponse =
UpdateMentalModelResponses[keyof UpdateMentalModelResponses];
export type UpdateReflectionResponse =
UpdateReflectionResponses[keyof UpdateReflectionResponses];
export type RefreshMentalModelData = {
export type RefreshReflectionData = {
body?: never;
headers?: {
/**
@@ -2528,33 +2462,33 @@ export type RefreshMentalModelData = {
*/
bank_id: string;
/**
* Mental Model Id
* Reflection Id
*/
mental_model_id: string;
reflection_id: string;
};
query?: never;
url: "/v1/default/banks/{bank_id}/mental-models/{mental_model_id}/refresh";
url: "/v1/default/banks/{bank_id}/reflections/{reflection_id}/refresh";
};
export type RefreshMentalModelErrors = {
export type RefreshReflectionErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type RefreshMentalModelError =
RefreshMentalModelErrors[keyof RefreshMentalModelErrors];
export type RefreshReflectionError =
RefreshReflectionErrors[keyof RefreshReflectionErrors];
export type RefreshMentalModelResponses = {
export type RefreshReflectionResponses = {
/**
* Successful Response
*/
200: AsyncOperationSubmitResponse;
};
export type RefreshMentalModelResponse =
RefreshMentalModelResponses[keyof RefreshMentalModelResponses];
export type RefreshReflectionResponse =
RefreshReflectionResponses[keyof RefreshReflectionResponses];
export type ListDirectivesData = {
body?: never;
@@ -3370,7 +3304,7 @@ export type CreateOrUpdateBankResponses = {
export type CreateOrUpdateBankResponse =
CreateOrUpdateBankResponses[keyof CreateOrUpdateBankResponses];
export type ClearObservationsData = {
export type ClearMentalModelsData = {
body?: never;
headers?: {
/**
@@ -3385,28 +3319,28 @@ export type ClearObservationsData = {
bank_id: string;
};
query?: never;
url: "/v1/default/banks/{bank_id}/observations";
url: "/v1/default/banks/{bank_id}/mental-models";
};
export type ClearObservationsErrors = {
export type ClearMentalModelsErrors = {
/**
* Validation Error
*/
422: HttpValidationError;
};
export type ClearObservationsError =
ClearObservationsErrors[keyof ClearObservationsErrors];
export type ClearMentalModelsError =
ClearMentalModelsErrors[keyof ClearMentalModelsErrors];
export type ClearObservationsResponses = {
export type ClearMentalModelsResponses = {
/**
* Successful Response
*/
200: DeleteResponse;
};
export type ClearObservationsResponse =
ClearObservationsResponses[keyof ClearObservationsResponses];
export type ClearMentalModelsResponse =
ClearMentalModelsResponses[keyof ClearMentalModelsResponses];
export type TriggerConsolidationData = {
body?: never;
-219
View File
@@ -321,225 +321,6 @@ export class HindsightClient {
return this.validateResponse(response, 'setMission');
}
/**
* Delete a bank.
*/
async deleteBank(bankId: string): Promise<void> {
const response = await sdk.deleteBank({
client: this.client,
path: { bank_id: bankId },
});
if (response.error) {
throw new Error(`deleteBank failed: ${JSON.stringify(response.error)}`);
}
}
// Directive methods
/**
* Create a directive (hard rule for reflect).
*/
async createDirective(
bankId: string,
name: string,
content: string,
options?: {
priority?: number;
isActive?: boolean;
tags?: string[];
}
): Promise<any> {
const response = await sdk.createDirective({
client: this.client,
path: { bank_id: bankId },
body: {
name,
content,
priority: options?.priority ?? 0,
is_active: options?.isActive ?? true,
tags: options?.tags,
},
});
return this.validateResponse(response, 'createDirective');
}
/**
* List all directives in a bank.
*/
async listDirectives(bankId: string, options?: { tags?: string[] }): Promise<any> {
const response = await sdk.listDirectives({
client: this.client,
path: { bank_id: bankId },
query: { tags: options?.tags },
});
return this.validateResponse(response, 'listDirectives');
}
/**
* Get a specific directive.
*/
async getDirective(bankId: string, directiveId: string): Promise<any> {
const response = await sdk.getDirective({
client: this.client,
path: { bank_id: bankId, directive_id: directiveId },
});
return this.validateResponse(response, 'getDirective');
}
/**
* Update a directive.
*/
async updateDirective(
bankId: string,
directiveId: string,
options: {
name?: string;
content?: string;
priority?: number;
isActive?: boolean;
tags?: string[];
}
): Promise<any> {
const response = await sdk.updateDirective({
client: this.client,
path: { bank_id: bankId, directive_id: directiveId },
body: {
name: options.name,
content: options.content,
priority: options.priority,
is_active: options.isActive,
tags: options.tags,
},
});
return this.validateResponse(response, 'updateDirective');
}
/**
* Delete a directive.
*/
async deleteDirective(bankId: string, directiveId: string): Promise<void> {
const response = await sdk.deleteDirective({
client: this.client,
path: { bank_id: bankId, directive_id: directiveId },
});
if (response.error) {
throw new Error(`deleteDirective failed: ${JSON.stringify(response.error)}`);
}
}
// Mental Model methods
/**
* Create a mental model (runs reflect in background).
*/
async createMentalModel(
bankId: string,
name: string,
sourceQuery: string,
options?: {
tags?: string[];
maxTokens?: number;
trigger?: { refreshAfterConsolidation?: boolean };
}
): Promise<any> {
const response = await sdk.createMentalModel({
client: this.client,
path: { bank_id: bankId },
body: {
name,
source_query: sourceQuery,
tags: options?.tags,
max_tokens: options?.maxTokens,
trigger: options?.trigger ? { refresh_after_consolidation: options.trigger.refreshAfterConsolidation } : undefined,
},
});
return this.validateResponse(response, 'createMentalModel');
}
/**
* List all mental models in a bank.
*/
async listMentalModels(bankId: string, options?: { tags?: string[] }): Promise<any> {
const response = await sdk.listMentalModels({
client: this.client,
path: { bank_id: bankId },
query: { tags: options?.tags },
});
return this.validateResponse(response, 'listMentalModels');
}
/**
* Get a specific mental model.
*/
async getMentalModel(bankId: string, mentalModelId: string): Promise<any> {
const response = await sdk.getMentalModel({
client: this.client,
path: { bank_id: bankId, mental_model_id: mentalModelId },
});
return this.validateResponse(response, 'getMentalModel');
}
/**
* Refresh a mental model to update with current knowledge.
*/
async refreshMentalModel(bankId: string, mentalModelId: string): Promise<any> {
const response = await sdk.refreshMentalModel({
client: this.client,
path: { bank_id: bankId, mental_model_id: mentalModelId },
});
return this.validateResponse(response, 'refreshMentalModel');
}
/**
* Update a mental model's metadata.
*/
async updateMentalModel(
bankId: string,
mentalModelId: string,
options: {
name?: string;
sourceQuery?: string;
tags?: string[];
maxTokens?: number;
trigger?: { refreshAfterConsolidation?: boolean };
}
): Promise<any> {
const response = await sdk.updateMentalModel({
client: this.client,
path: { bank_id: bankId, mental_model_id: mentalModelId },
body: {
name: options.name,
source_query: options.sourceQuery,
tags: options.tags,
max_tokens: options.maxTokens,
trigger: options.trigger ? { refresh_after_consolidation: options.trigger.refreshAfterConsolidation } : undefined,
},
});
return this.validateResponse(response, 'updateMentalModel');
}
/**
* Delete a mental model.
*/
async deleteMentalModel(bankId: string, mentalModelId: string): Promise<void> {
const response = await sdk.deleteMentalModel({
client: this.client,
path: { bank_id: bankId, mental_model_id: mentalModelId },
});
if (response.error) {
throw new Error(`deleteMentalModel failed: ${JSON.stringify(response.error)}`);
}
}
}
// Re-export types for convenience
@@ -1,116 +0,0 @@
import { NextResponse } from "next/server";
const DATAPLANE_URL = process.env.HINDSIGHT_CP_DATAPLANE_API_URL || "http://localhost:8888";
export async function GET(
request: Request,
{ params }: { params: Promise<{ bankId: string; mentalModelId: string }> }
) {
try {
const { bankId, mentalModelId } = await params;
if (!bankId || !mentalModelId) {
return NextResponse.json(
{ error: "bank_id and mental_model_id are required" },
{ status: 400 }
);
}
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/mental-models/${mentalModelId}`,
{ method: "GET" }
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error getting mental model:", errorText);
return NextResponse.json(
{ error: "Failed to get mental model" },
{ status: response.status }
);
}
const data = await response.json();
return NextResponse.json(data, { status: 200 });
} catch (error) {
console.error("Error getting mental model:", error);
return NextResponse.json({ error: "Failed to get mental model" }, { status: 500 });
}
}
export async function PATCH(
request: Request,
{ params }: { params: Promise<{ bankId: string; mentalModelId: string }> }
) {
try {
const { bankId, mentalModelId } = await params;
if (!bankId || !mentalModelId) {
return NextResponse.json(
{ error: "bank_id and mental_model_id are required" },
{ status: 400 }
);
}
const body = await request.json();
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/mental-models/${mentalModelId}`,
{
method: "PATCH",
headers: { "Content-Type": "application/json" },
body: JSON.stringify(body),
}
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error updating mental model:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to update mental model" },
{ status: response.status }
);
}
const data = await response.json();
return NextResponse.json(data, { status: 200 });
} catch (error) {
console.error("Error updating mental model:", error);
return NextResponse.json({ error: "Failed to update mental model" }, { status: 500 });
}
}
export async function DELETE(
request: Request,
{ params }: { params: Promise<{ bankId: string; mentalModelId: string }> }
) {
try {
const { bankId, mentalModelId } = await params;
if (!bankId || !mentalModelId) {
return NextResponse.json(
{ error: "bank_id and mental_model_id are required" },
{ status: 400 }
);
}
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/mental-models/${mentalModelId}`,
{ method: "DELETE" }
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error deleting mental model:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to delete mental model" },
{ status: response.status }
);
}
return NextResponse.json({ success: true }, { status: 200 });
} catch (error) {
console.error("Error deleting mental model:", error);
return NextResponse.json({ error: "Failed to delete mental model" }, { status: 500 });
}
}
@@ -1,47 +1,54 @@
import { NextResponse } from "next/server";
const DATAPLANE_URL = process.env.HINDSIGHT_CP_DATAPLANE_API_URL || "http://localhost:8888";
import { sdk, lowLevelClient } from "@/lib/hindsight-client";
export async function GET(request: Request, { params }: { params: Promise<{ bankId: string }> }) {
try {
const { bankId } = await params;
const { searchParams } = new URL(request.url);
const tags = searchParams.getAll("tags");
const tagsMatch = searchParams.get("tags_match");
if (!bankId) {
return NextResponse.json({ error: "bank_id is required" }, { status: 400 });
}
const queryParams = new URLSearchParams();
if (tags.length > 0) {
tags.forEach((t) => queryParams.append("tags", t));
}
if (tagsMatch) {
queryParams.append("tags_match", tagsMatch);
// Note: tags filtering is not supported by the list_memories API endpoint
const response = await sdk.listMemories({
client: lowLevelClient,
path: { bank_id: bankId },
query: {
type: "mental_model",
limit: 1000,
},
});
if (response.error) {
console.error("API error listing mental models:", response.error);
return NextResponse.json({ error: "Failed to list mental models" }, { status: 500 });
}
const url = `${DATAPLANE_URL}/v1/default/banks/${bankId}/mental-models${queryParams.toString() ? `?${queryParams}` : ""}`;
const response = await fetch(url, { method: "GET" });
// Transform list memories response to mental models format
const items = (response.data?.items || []).map((item) => ({
id: item.id,
bank_id: bankId,
text: item.text,
proof_count: 1,
history: [],
tags: item.tags || [],
source_memory_ids: [],
source_memories: [],
created_at: item.date,
updated_at: item.date,
}));
if (!response.ok) {
const errorText = await response.text();
console.error("API error listing mental models:", errorText);
return NextResponse.json(
{ error: "Failed to list mental models" },
{ status: response.status }
);
}
const data = await response.json();
return NextResponse.json(data, { status: 200 });
return NextResponse.json({ items }, { status: 200 });
} catch (error) {
console.error("Error listing mental models:", error);
return NextResponse.json({ error: "Failed to list mental models" }, { status: 500 });
}
}
export async function POST(request: Request, { params }: { params: Promise<{ bankId: string }> }) {
export async function DELETE(
request: Request,
{ params }: { params: Promise<{ bankId: string }> }
) {
try {
const { bankId } = await params;
@@ -49,28 +56,19 @@ export async function POST(request: Request, { params }: { params: Promise<{ ban
return NextResponse.json({ error: "bank_id is required" }, { status: 400 });
}
const body = await request.json();
const response = await fetch(`${DATAPLANE_URL}/v1/default/banks/${bankId}/mental-models`, {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify(body),
const response = await sdk.clearMentalModels({
client: lowLevelClient,
path: { bank_id: bankId },
});
if (!response.ok) {
const errorText = await response.text();
console.error("API error creating mental model:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to create mental model" },
{ status: response.status }
);
if (response.error) {
console.error("API error clearing mental models:", response.error);
return NextResponse.json({ error: "Failed to clear mental models" }, { status: 500 });
}
const data = await response.json();
// Returns operation_id - content is generated in background
return NextResponse.json(data, { status: 202 });
return NextResponse.json(response.data, { status: 200 });
} catch (error) {
console.error("Error creating mental model:", error);
return NextResponse.json({ error: "Failed to create mental model" }, { status: 500 });
console.error("Error clearing mental models:", error);
return NextResponse.json({ error: "Failed to clear mental models" }, { status: 500 });
}
}
@@ -1,74 +0,0 @@
import { NextResponse } from "next/server";
import { sdk, lowLevelClient } from "@/lib/hindsight-client";
export async function GET(request: Request, { params }: { params: Promise<{ bankId: string }> }) {
try {
const { bankId } = await params;
if (!bankId) {
return NextResponse.json({ error: "bank_id is required" }, { status: 400 });
}
// Note: tags filtering is not supported by the list_memories API endpoint
const response = await sdk.listMemories({
client: lowLevelClient,
path: { bank_id: bankId },
query: {
type: "observation",
limit: 1000,
},
});
if (response.error) {
console.error("API error listing observations:", response.error);
return NextResponse.json({ error: "Failed to list observations" }, { status: 500 });
}
// Transform list memories response to observations format
const items = (response.data?.items || []).map((item) => ({
id: item.id,
bank_id: bankId,
text: item.text,
proof_count: 1,
history: [],
tags: item.tags || [],
source_memory_ids: [],
source_memories: [],
created_at: item.date,
updated_at: item.date,
}));
return NextResponse.json({ items }, { status: 200 });
} catch (error) {
console.error("Error listing observations:", error);
return NextResponse.json({ error: "Failed to list observations" }, { status: 500 });
}
}
export async function DELETE(
request: Request,
{ params }: { params: Promise<{ bankId: string }> }
) {
try {
const { bankId } = await params;
if (!bankId) {
return NextResponse.json({ error: "bank_id is required" }, { status: 400 });
}
const response = await sdk.clearObservations({
client: lowLevelClient,
path: { bank_id: bankId },
});
if (response.error) {
console.error("API error clearing observations:", response.error);
return NextResponse.json({ error: "Failed to clear observations" }, { status: 500 });
}
return NextResponse.json(response.data, { status: 200 });
} catch (error) {
console.error("Error clearing observations:", error);
return NextResponse.json({ error: "Failed to clear observations" }, { status: 500 });
}
}
@@ -4,28 +4,28 @@ const DATAPLANE_URL = process.env.HINDSIGHT_CP_DATAPLANE_API_URL || "http://loca
export async function POST(
request: Request,
{ params }: { params: Promise<{ bankId: string; mentalModelId: string }> }
{ params }: { params: Promise<{ bankId: string; reflectionId: string }> }
) {
try {
const { bankId, mentalModelId } = await params;
const { bankId, reflectionId } = await params;
if (!bankId || !mentalModelId) {
if (!bankId || !reflectionId) {
return NextResponse.json(
{ error: "bank_id and mental_model_id are required" },
{ error: "bank_id and reflection_id are required" },
{ status: 400 }
);
}
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/mental-models/${mentalModelId}/refresh`,
`${DATAPLANE_URL}/v1/default/banks/${bankId}/reflections/${reflectionId}/refresh`,
{ method: "POST" }
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error refreshing mental model:", errorText);
console.error("API error refreshing reflection:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to refresh mental model" },
{ error: errorText || "Failed to refresh reflection" },
{ status: response.status }
);
}
@@ -33,7 +33,7 @@ export async function POST(
const data = await response.json();
return NextResponse.json(data, { status: 200 });
} catch (error) {
console.error("Error refreshing mental model:", error);
return NextResponse.json({ error: "Failed to refresh mental model" }, { status: 500 });
console.error("Error refreshing reflection:", error);
return NextResponse.json({ error: "Failed to refresh reflection" }, { status: 500 });
}
}
@@ -0,0 +1,113 @@
import { NextResponse } from "next/server";
const DATAPLANE_URL = process.env.HINDSIGHT_CP_DATAPLANE_API_URL || "http://localhost:8888";
export async function GET(
request: Request,
{ params }: { params: Promise<{ bankId: string; reflectionId: string }> }
) {
try {
const { bankId, reflectionId } = await params;
if (!bankId || !reflectionId) {
return NextResponse.json(
{ error: "bank_id and reflection_id are required" },
{ status: 400 }
);
}
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/reflections/${reflectionId}`,
{ method: "GET" }
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error getting reflection:", errorText);
return NextResponse.json({ error: "Failed to get reflection" }, { status: response.status });
}
const data = await response.json();
return NextResponse.json(data, { status: 200 });
} catch (error) {
console.error("Error getting reflection:", error);
return NextResponse.json({ error: "Failed to get reflection" }, { status: 500 });
}
}
export async function PATCH(
request: Request,
{ params }: { params: Promise<{ bankId: string; reflectionId: string }> }
) {
try {
const { bankId, reflectionId } = await params;
if (!bankId || !reflectionId) {
return NextResponse.json(
{ error: "bank_id and reflection_id are required" },
{ status: 400 }
);
}
const body = await request.json();
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/reflections/${reflectionId}`,
{
method: "PATCH",
headers: { "Content-Type": "application/json" },
body: JSON.stringify(body),
}
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error updating reflection:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to update reflection" },
{ status: response.status }
);
}
const data = await response.json();
return NextResponse.json(data, { status: 200 });
} catch (error) {
console.error("Error updating reflection:", error);
return NextResponse.json({ error: "Failed to update reflection" }, { status: 500 });
}
}
export async function DELETE(
request: Request,
{ params }: { params: Promise<{ bankId: string; reflectionId: string }> }
) {
try {
const { bankId, reflectionId } = await params;
if (!bankId || !reflectionId) {
return NextResponse.json(
{ error: "bank_id and reflection_id are required" },
{ status: 400 }
);
}
const response = await fetch(
`${DATAPLANE_URL}/v1/default/banks/${bankId}/reflections/${reflectionId}`,
{ method: "DELETE" }
);
if (!response.ok) {
const errorText = await response.text();
console.error("API error deleting reflection:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to delete reflection" },
{ status: response.status }
);
}
return NextResponse.json({ success: true }, { status: 200 });
} catch (error) {
console.error("Error deleting reflection:", error);
return NextResponse.json({ error: "Failed to delete reflection" }, { status: 500 });
}
}
@@ -0,0 +1,76 @@
import { NextResponse } from "next/server";
const DATAPLANE_URL = process.env.HINDSIGHT_CP_DATAPLANE_API_URL || "http://localhost:8888";
export async function GET(request: Request, { params }: { params: Promise<{ bankId: string }> }) {
try {
const { bankId } = await params;
const { searchParams } = new URL(request.url);
const tags = searchParams.getAll("tags");
const tagsMatch = searchParams.get("tags_match");
if (!bankId) {
return NextResponse.json({ error: "bank_id is required" }, { status: 400 });
}
const queryParams = new URLSearchParams();
if (tags.length > 0) {
tags.forEach((t) => queryParams.append("tags", t));
}
if (tagsMatch) {
queryParams.append("tags_match", tagsMatch);
}
const url = `${DATAPLANE_URL}/v1/default/banks/${bankId}/reflections${queryParams.toString() ? `?${queryParams}` : ""}`;
const response = await fetch(url, { method: "GET" });
if (!response.ok) {
const errorText = await response.text();
console.error("API error listing reflections:", errorText);
return NextResponse.json(
{ error: "Failed to list reflections" },
{ status: response.status }
);
}
const data = await response.json();
return NextResponse.json(data, { status: 200 });
} catch (error) {
console.error("Error listing reflections:", error);
return NextResponse.json({ error: "Failed to list reflections" }, { status: 500 });
}
}
export async function POST(request: Request, { params }: { params: Promise<{ bankId: string }> }) {
try {
const { bankId } = await params;
if (!bankId) {
return NextResponse.json({ error: "bank_id is required" }, { status: 400 });
}
const body = await request.json();
const response = await fetch(`${DATAPLANE_URL}/v1/default/banks/${bankId}/reflections`, {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify(body),
});
if (!response.ok) {
const errorText = await response.text();
console.error("API error creating reflection:", errorText);
return NextResponse.json(
{ error: errorText || "Failed to create reflection" },
{ status: response.status }
);
}
const data = await response.json();
// Returns operation_id - content is generated in background
return NextResponse.json(data, { status: 202 });
} catch (error) {
console.error("Error creating reflection:", error);
return NextResponse.json({ error: "Failed to create reflection" }, { status: 500 });
}
}
@@ -9,11 +9,11 @@ import { EntitiesView } from "@/components/entities-view";
import { ThinkView } from "@/components/think-view";
import { SearchDebugView } from "@/components/search-debug-view";
import { BankProfileView } from "@/components/bank-profile-view";
import { MentalModelsView } from "@/components/mental-models-view";
import { ReflectionsView } from "@/components/reflections-view";
import { useFeatures } from "@/lib/features-context";
type NavItem = "recall" | "reflect" | "data" | "documents" | "entities" | "profile";
type DataSubTab = "world" | "experience" | "observations" | "mental-models";
type DataSubTab = "world" | "experience" | "models" | "reflections";
export default function BankPage() {
const params = useParams();
@@ -24,7 +24,7 @@ export default function BankPage() {
const bankId = params.bankId as string;
const view = (searchParams.get("view") || "profile") as NavItem;
const subTab = (searchParams.get("subTab") || "world") as DataSubTab;
const observationsEnabled = features?.observations ?? false;
const mentalModelsEnabled = features?.mental_models ?? false;
const handleTabChange = (tab: NavItem) => {
router.push(`/banks/${bankId}?view=${tab}`);
@@ -71,8 +71,8 @@ export default function BankPage() {
<div>
<h1 className="text-3xl font-bold mb-2 text-foreground">Reflect</h1>
<p className="text-muted-foreground mb-6">
Run an agentic loop that autonomously gathers evidence and reasons through the
lens of the bank&apos;s disposition to generate contextual responses.
Query the memory bank and generate a response with optional disposition-aware
reasoning.
</p>
<ThinkView />
</div>
@@ -115,33 +115,33 @@ export default function BankPage() {
)}
</button>
<button
onClick={() => handleDataSubTabChange("observations")}
onClick={() => handleDataSubTabChange("models")}
className={`px-6 py-3 font-semibold text-sm transition-all relative ${
subTab === "observations"
? "text-primary"
: "text-muted-foreground hover:text-foreground"
}`}
>
Observations
{!observationsEnabled && (
<span className="ml-2 text-xs px-1.5 py-0.5 rounded bg-muted text-muted-foreground">
Off
</span>
)}
{subTab === "observations" && (
<div className="absolute bottom-0 left-0 right-0 h-0.5 bg-primary" />
)}
</button>
<button
onClick={() => handleDataSubTabChange("mental-models")}
className={`px-6 py-3 font-semibold text-sm transition-all relative ${
subTab === "mental-models"
subTab === "models"
? "text-primary"
: "text-muted-foreground hover:text-foreground"
}`}
>
Mental Models
{subTab === "mental-models" && (
{!mentalModelsEnabled && (
<span className="ml-2 text-xs px-1.5 py-0.5 rounded bg-muted text-muted-foreground">
Off
</span>
)}
{subTab === "models" && (
<div className="absolute bottom-0 left-0 right-0 h-0.5 bg-primary" />
)}
</button>
<button
onClick={() => handleDataSubTabChange("reflections")}
className={`px-6 py-3 font-semibold text-sm transition-all relative ${
subTab === "reflections"
? "text-primary"
: "text-muted-foreground hover:text-foreground"
}`}
>
Reflections
{subTab === "reflections" && (
<div className="absolute bottom-0 left-0 right-0 h-0.5 bg-primary" />
)}
</button>
@@ -149,31 +149,11 @@ export default function BankPage() {
</div>
<div>
{subTab === "world" && (
<div>
<p className="text-sm text-muted-foreground mb-4">
Objective facts about the world received from external sources.
</p>
<DataView key="world" factType="world" />
</div>
)}
{subTab === "experience" && (
<div>
<p className="text-sm text-muted-foreground mb-4">
The bank&apos;s own actions, interactions, and first-person experiences.
</p>
<DataView key="experience" factType="experience" />
</div>
)}
{subTab === "observations" &&
(observationsEnabled ? (
<div>
<p className="text-sm text-muted-foreground mb-4">
Consolidated knowledge synthesized from facts patterns, preferences, and
learnings that emerge from accumulated evidence.
</p>
<DataView key="observations" factType="observation" />
</div>
{subTab === "world" && <DataView key="world" factType="world" />}
{subTab === "experience" && <DataView key="experience" factType="experience" />}
{subTab === "models" &&
(mentalModelsEnabled ? (
<DataView key="models" factType="mental_model" />
) : (
<div className="flex flex-col items-center justify-center py-16 text-center">
<div className="text-muted-foreground mb-2">
@@ -194,26 +174,18 @@ export default function BankPage() {
</svg>
</div>
<h3 className="text-lg font-semibold text-foreground mb-1">
Observations Not Enabled
Mental Models Not Enabled
</h3>
<p className="text-sm text-muted-foreground max-w-md">
Observations consolidation is disabled on this server. Set{" "}
Mental models consolidation is disabled on this server. Set{" "}
<code className="px-1 py-0.5 bg-muted rounded text-xs">
HINDSIGHT_API_ENABLE_OBSERVATIONS=true
HINDSIGHT_API_ENABLE_MENTAL_MODELS=true
</code>{" "}
to enable.
</p>
</div>
))}
{subTab === "mental-models" && (
<div>
<p className="text-sm text-muted-foreground mb-4">
User-curated summaries generated from queries reusable knowledge snapshots
that can be refreshed as memories evolve.
</p>
<MentalModelsView key="mental-models" />
</div>
)}
{subTab === "reflections" && <ReflectionsView key="reflections" />}
</div>
</div>
)}
@@ -214,13 +214,12 @@ export function BankProfileView() {
const router = useRouter();
const { currentBank, setCurrentBank, loadBanks } = useBank();
const { features } = useFeatures();
const observationsEnabled = features?.observations ?? false;
const mentalModelsEnabled = features?.mental_models ?? false;
const [profile, setProfile] = useState<BankProfile | null>(null);
const [stats, setStats] = useState<BankStats | null>(null);
const [operations, setOperations] = useState<Operation[]>([]);
const [totalOperations, setTotalOperations] = useState(0);
const [directives, setDirectives] = useState<Directive[]>([]);
const [mentalModelsCount, setMentalModelsCount] = useState(0);
const [loading, setLoading] = useState(false);
const [saving, setSaving] = useState(false);
const [editMode, setEditMode] = useState(false);
@@ -244,9 +243,9 @@ export function BankProfileView() {
const [showDeleteDialog, setShowDeleteDialog] = useState(false);
const [isDeleting, setIsDeleting] = useState(false);
// Clear observations state
const [showClearObservationsDialog, setShowClearObservationsDialog] = useState(false);
const [isClearingObservations, setIsClearingObservations] = useState(false);
// Clear mental models state
const [showClearMentalModelsDialog, setShowClearMentalModelsDialog] = useState(false);
const [isClearingMentalModels, setIsClearingMentalModels] = useState(false);
// Consolidation state
const [isConsolidating, setIsConsolidating] = useState(false);
@@ -290,14 +289,12 @@ export function BankProfileView() {
// Use ref to get current value (avoids stale closure in setInterval)
if (isPolling) {
try {
const [statsData, directivesData, mentalModelsData] = await Promise.all([
const [statsData, directivesData] = await Promise.all([
client.getBankStats(currentBank),
client.listDirectives(currentBank),
client.listMentalModels(currentBank),
]);
setStats(statsData as BankStats);
setDirectives(directivesData.items || []);
setMentalModelsCount(mentalModelsData.items?.length || 0);
// Skip operations refresh during polling to not interfere with filter/pagination state
} catch (error) {
console.error("Error refreshing stats:", error);
@@ -307,16 +304,14 @@ export function BankProfileView() {
setLoading(true);
try {
const [profileData, statsData, directivesData, mentalModelsData] = await Promise.all([
const [profileData, statsData, directivesData] = await Promise.all([
client.getBankProfile(currentBank),
client.getBankStats(currentBank),
client.listDirectives(currentBank),
client.listMentalModels(currentBank),
]);
setProfile(profileData);
setStats(statsData as BankStats);
setDirectives(directivesData.items || []);
setMentalModelsCount(mentalModelsData.items?.length || 0);
await loadOperations();
// Only initialize edit state when not in edit mode
@@ -377,20 +372,20 @@ export function BankProfileView() {
}
};
const handleClearObservations = async () => {
const handleClearMentalModels = async () => {
if (!currentBank) return;
setIsClearingObservations(true);
setIsClearingMentalModels(true);
try {
const result = await client.clearObservations(currentBank);
setShowClearObservationsDialog(false);
const result = await client.clearMentalModels(currentBank);
setShowClearMentalModelsDialog(false);
await loadData();
alert(result.message || "Observations cleared successfully");
alert(result.message || "Mental models cleared successfully");
} catch (error) {
console.error("Error clearing observations:", error);
alert("Error clearing observations: " + (error as Error).message);
console.error("Error clearing mental models:", error);
alert("Error clearing mental models: " + (error as Error).message);
} finally {
setIsClearingObservations(false);
setIsClearingMentalModels(false);
}
};
@@ -542,8 +537,8 @@ export function BankProfileView() {
<DropdownMenuSeparator />
<DropdownMenuItem
onClick={handleTriggerConsolidation}
disabled={isConsolidating || !observationsEnabled}
title={!observationsEnabled ? "Observations feature is not enabled" : undefined}
disabled={isConsolidating || !mentalModelsEnabled}
title={!mentalModelsEnabled ? "Mental models feature is not enabled" : undefined}
>
{isConsolidating ? (
<Loader2 className="w-4 h-4 mr-2 animate-spin" />
@@ -551,19 +546,19 @@ export function BankProfileView() {
<Brain className="w-4 h-4 mr-2" />
)}
{isConsolidating ? "Consolidating..." : "Run Consolidation"}
{!observationsEnabled && (
{!mentalModelsEnabled && (
<span className="ml-auto text-xs text-muted-foreground">Off</span>
)}
</DropdownMenuItem>
<DropdownMenuItem
onClick={() => setShowClearObservationsDialog(true)}
disabled={!observationsEnabled}
onClick={() => setShowClearMentalModelsDialog(true)}
disabled={!mentalModelsEnabled}
className="text-amber-600 dark:text-amber-400 focus:text-amber-700 dark:focus:text-amber-300"
title={!observationsEnabled ? "Observations feature is not enabled" : undefined}
title={!mentalModelsEnabled ? "Mental models feature is not enabled" : undefined}
>
<Trash2 className="w-4 h-4 mr-2" />
Clear Observations
{!observationsEnabled && (
Clear Mental Models
{!mentalModelsEnabled && (
<span className="ml-auto text-xs text-muted-foreground">Off</span>
)}
</DropdownMenuItem>
@@ -650,7 +645,7 @@ export function BankProfileView() {
{/* Memory Type Breakdown */}
{stats && (
<div className="grid grid-cols-5 gap-3">
<div className="grid grid-cols-4 gap-3">
<div className="bg-blue-500/10 border border-blue-500/20 rounded-xl p-4 text-center">
<p className="text-xs text-blue-600 dark:text-blue-400 font-semibold uppercase tracking-wide">
World Facts
@@ -669,34 +664,26 @@ export function BankProfileView() {
</div>
<div
className={`rounded-xl p-4 text-center ${
observationsEnabled
mentalModelsEnabled
? "bg-amber-500/10 border border-amber-500/20"
: "bg-muted/50 border border-muted"
}`}
title={!observationsEnabled ? "Observations feature is not enabled" : undefined}
title={!mentalModelsEnabled ? "Mental models feature is not enabled" : undefined}
>
<p
className={`text-xs font-semibold uppercase tracking-wide ${
observationsEnabled ? "text-amber-600 dark:text-amber-400" : "text-muted-foreground"
mentalModelsEnabled ? "text-amber-600 dark:text-amber-400" : "text-muted-foreground"
}`}
>
Observations
{!observationsEnabled && <span className="ml-1 normal-case">(Off)</span>}
Mental Models
{!mentalModelsEnabled && <span className="ml-1 normal-case">(Off)</span>}
</p>
<p
className={`text-2xl font-bold mt-1 ${
observationsEnabled ? "text-amber-600 dark:text-amber-400" : "text-muted-foreground"
mentalModelsEnabled ? "text-amber-600 dark:text-amber-400" : "text-muted-foreground"
}`}
>
{observationsEnabled ? stats.total_mental_models || 0 : "—"}
</p>
</div>
<div className="bg-cyan-500/10 border border-cyan-500/20 rounded-xl p-4 text-center">
<p className="text-xs text-cyan-600 dark:text-cyan-400 font-semibold uppercase tracking-wide">
Mental Models
</p>
<p className="text-2xl font-bold text-cyan-600 dark:text-cyan-400 mt-1">
{mentalModelsCount}
{mentalModelsEnabled ? stats.total_mental_models || 0 : "—"}
</p>
</div>
<div className="bg-rose-500/10 border border-rose-500/20 rounded-xl p-4 text-center">
@@ -1037,35 +1024,35 @@ export function BankProfileView() {
</AlertDialogContent>
</AlertDialog>
{/* Clear Observations Confirmation Dialog */}
<AlertDialog open={showClearObservationsDialog} onOpenChange={setShowClearObservationsDialog}>
{/* Clear Mental Models Confirmation Dialog */}
<AlertDialog open={showClearMentalModelsDialog} onOpenChange={setShowClearMentalModelsDialog}>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>Clear Observations</AlertDialogTitle>
<AlertDialogTitle>Clear Mental Models</AlertDialogTitle>
<AlertDialogDescription asChild>
<div className="space-y-2 text-sm text-muted-foreground">
<p>
Are you sure you want to clear all observations for{" "}
Are you sure you want to clear all mental models for{" "}
<span className="font-semibold text-foreground">{currentBank}</span>?
</p>
<p className="text-amber-600 dark:text-amber-400 font-medium">
This will delete all consolidated knowledge. Observations will be regenerated the
This will delete all consolidated knowledge. Mental models will be regenerated the
next time consolidation runs.
</p>
{stats && stats.total_mental_models > 0 && (
<p>This will delete {stats.total_mental_models} observations.</p>
<p>This will delete {stats.total_mental_models} mental models.</p>
)}
</div>
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel disabled={isClearingObservations}>Cancel</AlertDialogCancel>
<AlertDialogCancel disabled={isClearingMentalModels}>Cancel</AlertDialogCancel>
<AlertDialogAction
onClick={handleClearObservations}
disabled={isClearingObservations}
onClick={handleClearMentalModels}
disabled={isClearingMentalModels}
className="bg-amber-500 text-white hover:bg-amber-600"
>
{isClearingObservations ? (
{isClearingMentalModels ? (
<>
<Loader2 className="w-4 h-4 mr-2 animate-spin" />
Clearing...
@@ -1073,7 +1060,7 @@ export function BankProfileView() {
) : (
<>
<Trash2 className="w-4 h-4 mr-2" />
Clear Observations
Clear Mental Models
</>
)}
</AlertDialogAction>
@@ -1082,9 +1069,8 @@ export function BankProfileView() {
</AlertDialog>
{/* Create Directive Dialog */}
<DirectiveFormDialog
<CreateDirectiveDialog
open={showCreateDirective}
mode="create"
onClose={() => setShowCreateDirective(false)}
onCreated={(d) => {
setDirectives((prev) => [d, ...prev]);
@@ -1133,99 +1119,68 @@ export function BankProfileView() {
name: selectedDirective.name,
})
}
onUpdated={(updated) => {
setDirectives((prev) => prev.map((d) => (d.id === updated.id ? updated : d)));
setSelectedDirective(updated);
}}
/>
)}
</div>
);
}
// ============= DIRECTIVE FORM DIALOG (CREATE/EDIT) =============
// ============= CREATE DIRECTIVE DIALOG =============
function DirectiveFormDialog({
function CreateDirectiveDialog({
open,
mode,
directive,
onClose,
onCreated,
onSaved,
}: {
open: boolean;
mode: "create" | "edit";
directive?: Directive;
onClose: () => void;
onCreated?: (d: Directive) => void;
onSaved?: (d: Directive) => void;
onCreated: (d: Directive) => void;
}) {
const { currentBank } = useBank();
const [submitting, setSubmitting] = useState(false);
const [form, setForm] = useState({ name: "", content: "", tags: "" });
const [creating, setCreating] = useState(false);
const [form, setForm] = useState({ name: "", description: "", tags: "" });
// Reset form when dialog opens or directive changes
useEffect(() => {
if (mode === "edit" && directive) {
setForm({
name: directive.name,
content: directive.content,
tags: (directive.tags || []).join(", "),
});
} else if (mode === "create") {
setForm({ name: "", content: "", tags: "" });
}
}, [open, mode, directive]);
const handleCreate = async () => {
if (!currentBank || !form.name.trim() || !form.description.trim()) return;
const handleSubmit = async () => {
if (!currentBank || !form.name.trim() || !form.content.trim()) return;
setSubmitting(true);
setCreating(true);
try {
const tags = form.tags
.split(",")
.map((t) => t.trim())
.filter((t) => t.length > 0);
if (mode === "create") {
const result = await client.createDirective(currentBank, {
name: form.name.trim(),
content: form.content.trim(),
tags: tags.length > 0 ? tags : undefined,
});
setForm({ name: "", content: "", tags: "" });
onCreated?.(result);
} else if (directive) {
const result = await client.updateDirective(currentBank, directive.id, {
name: form.name.trim(),
content: form.content.trim(),
tags: tags,
});
onSaved?.(result);
onClose();
}
} catch (error) {
console.error(`Error ${mode === "create" ? "creating" : "updating"} directive:`, error);
alert(`Error ${mode === "create" ? "creating" : "updating"}: ` + (error as Error).message);
} finally {
setSubmitting(false);
}
};
const result = await client.createDirective(currentBank, {
name: form.name.trim(),
content: form.description.trim(),
tags: tags.length > 0 ? tags : undefined,
});
const handleClose = () => {
if (mode === "create") {
setForm({ name: "", content: "", tags: "" });
setForm({ name: "", description: "", tags: "" });
onCreated(result);
} catch (error) {
console.error("Error creating directive:", error);
alert("Error creating directive: " + (error as Error).message);
} finally {
setCreating(false);
}
onClose();
};
return (
<Dialog open={open} onOpenChange={(o) => !o && handleClose()}>
<Dialog
open={open}
onOpenChange={(o) => {
if (!o) {
setForm({ name: "", description: "", tags: "" });
onClose();
}
}}
>
<DialogContent className="sm:max-w-lg">
<DialogHeader>
<DialogTitle className="flex items-center gap-2">
<AlertTriangle className="w-5 h-5 text-rose-500" />
{mode === "create" ? "Create" : "Edit"} Directive
Create Directive
</DialogTitle>
<DialogDescription>
Directives are hard rules that must be followed during reflect.
@@ -1244,8 +1199,8 @@ function DirectiveFormDialog({
<div className="space-y-2">
<label className="text-sm font-medium text-foreground">Rule *</label>
<Textarea
value={form.content}
onChange={(e) => setForm({ ...form, content: e.target.value })}
value={form.description}
onChange={(e) => setForm({ ...form, description: e.target.value })}
placeholder="e.g., Never mention competitor products directly."
className="min-h-[120px]"
/>
@@ -1263,16 +1218,16 @@ function DirectiveFormDialog({
</div>
<DialogFooter>
<Button variant="outline" onClick={handleClose} disabled={submitting}>
<Button variant="outline" onClick={onClose}>
Cancel
</Button>
<Button
onClick={handleSubmit}
disabled={submitting || !form.name.trim() || !form.content.trim()}
onClick={handleCreate}
disabled={creating || !form.name.trim() || !form.description.trim()}
className="bg-rose-500 hover:bg-rose-600"
>
{submitting ? <Loader2 className="w-4 h-4 animate-spin mr-1" /> : null}
{mode === "create" ? "Create" : "Save"}
{creating ? <Loader2 className="w-4 h-4 animate-spin mr-1" /> : null}
Create
</Button>
</DialogFooter>
</DialogContent>
@@ -1286,15 +1241,11 @@ function DirectiveDetailPanel({
directive,
onClose,
onDelete,
onUpdated,
}: {
directive: Directive;
onClose: () => void;
onDelete: () => void;
onUpdated: (d: Directive) => void;
}) {
const [showEditModal, setShowEditModal] = useState(false);
return (
<div className="fixed right-0 top-0 h-screen w-1/2 bg-card border-l-2 border-rose-500 shadow-2xl z-50 overflow-y-auto animate-in slide-in-from-right duration-300 ease-out">
<div className="p-6">
@@ -1303,35 +1254,15 @@ function DirectiveDetailPanel({
<div className="flex items-start gap-3">
<AlertTriangle className="w-5 h-5 text-rose-500" />
<div>
<div className="flex items-center gap-2">
<h3 className="text-xl font-bold text-foreground">{directive.name}</h3>
<Button
variant="ghost"
size="sm"
onClick={() => setShowEditModal(true)}
className="h-7 w-7 p-0"
>
<Pencil className="h-3.5 w-3.5" />
</Button>
</div>
<h3 className="text-xl font-bold text-foreground">{directive.name}</h3>
<span className="text-xs px-1.5 py-0.5 rounded bg-rose-500/10 text-rose-600 dark:text-rose-400">
directive
</span>
</div>
</div>
<div className="flex items-center gap-2">
<Button
variant="ghost"
size="sm"
onClick={onDelete}
className="h-8 w-8 p-0 text-muted-foreground hover:text-rose-500"
>
<Trash2 className="h-4 w-4" />
</Button>
<Button variant="ghost" size="sm" onClick={onClose} className="h-8 w-8 p-0">
<X className="h-4 w-4" />
</Button>
</div>
<Button variant="ghost" size="sm" onClick={onClose} className="h-8 w-8 p-0">
<X className="h-4 w-4" />
</Button>
</div>
<div className="space-y-6">
@@ -1365,7 +1296,7 @@ function DirectiveDetailPanel({
)}
{/* ID */}
<div>
<div className="p-4 bg-muted/50 rounded-lg">
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide mb-2">
ID
</div>
@@ -1373,17 +1304,21 @@ function DirectiveDetailPanel({
{directive.id}
</code>
</div>
{/* Actions */}
<div className="pt-4 border-t border-border">
<Button
variant="outline"
size="sm"
onClick={onDelete}
className="text-muted-foreground hover:text-rose-500 hover:border-rose-500 hover:bg-rose-500/10"
>
<Trash2 className="h-4 w-4 mr-2" />
Delete
</Button>
</div>
</div>
</div>
{/* Edit Modal */}
<DirectiveFormDialog
open={showEditModal}
mode="edit"
directive={directive}
onClose={() => setShowEditModal(false)}
onSaved={onUpdated}
/>
</div>
);
}
@@ -6,6 +6,8 @@ import { useBank } from "@/lib/bank-context";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import {
Copy,
Check,
Calendar,
ZoomIn,
ZoomOut,
@@ -19,8 +21,6 @@ import {
RefreshCw,
CheckCircle,
Clock,
Network,
List,
} from "lucide-react";
import {
Table,
@@ -34,10 +34,9 @@ import { Label } from "@/components/ui/label";
import { Slider } from "@/components/ui/slider";
import { Switch } from "@/components/ui/switch";
import { MemoryDetailPanel } from "./memory-detail-panel";
import { MemoryDetailModal } from "./memory-detail-modal";
import { Graph2D, convertHindsightGraphData, GraphNode } from "./graph-2d";
type FactType = "world" | "experience" | "observation";
type FactType = "world" | "experience" | "mental_model";
type ViewMode = "graph" | "table" | "timeline";
interface DataViewProps {
@@ -50,9 +49,10 @@ export function DataView({ factType }: DataViewProps) {
const [data, setData] = useState<any>(null);
const [loading, setLoading] = useState(false);
const [searchQuery, setSearchQuery] = useState("");
const [copiedId, setCopiedId] = useState<string | null>(null);
const [currentPage, setCurrentPage] = useState(1);
const [selectedGraphNode, setSelectedGraphNode] = useState<any>(null);
const [modalMemoryId, setModalMemoryId] = useState<string | null>(null);
const [selectedTableMemory, setSelectedTableMemory] = useState<any>(null);
const itemsPerPage = 100;
// Fetch limit state - how many memories to load from the API
@@ -95,6 +95,16 @@ export function DataView({ factType }: DataViewProps) {
return () => window.removeEventListener("keydown", handleKeyDown);
}, [selectedGraphNode]);
const copyToClipboard = async (text: string) => {
try {
await navigator.clipboard.writeText(text);
setCopiedId(text);
setTimeout(() => setCopiedId(null), 2000);
} catch (err) {
console.error("Failed to copy:", err);
}
};
const loadData = async (limit?: number) => {
if (!currentBank) return;
@@ -107,8 +117,8 @@ export function DataView({ factType }: DataViewProps) {
});
setData(graphData);
// Fetch consolidation status for observations
if (factType === "observation") {
// Fetch consolidation status for mental models
if (factType === "mental_model") {
const stats: any = await client.getBankStats(currentBank);
setConsolidationStatus({
pending_consolidation: stats.pending_consolidation || 0,
@@ -297,8 +307,8 @@ export function DataView({ factType }: DataViewProps) {
)}
</div>
{/* Consolidation status for observations */}
{factType === "observation" && consolidationStatus && (
{/* Consolidation status for mental models */}
{factType === "mental_model" && consolidationStatus && (
<div
className={`flex items-center gap-1.5 px-2.5 py-1 rounded-full text-xs font-medium ${
consolidationStatus.pending_consolidation === 0
@@ -328,36 +338,33 @@ export function DataView({ factType }: DataViewProps) {
<div className="flex items-center gap-2 bg-muted rounded-lg p-1">
<button
onClick={() => setViewMode("graph")}
className={`px-3 py-1.5 rounded-md text-sm font-medium transition-all flex items-center gap-1.5 ${
className={`px-4 py-2 rounded-md text-sm font-medium transition-all ${
viewMode === "graph"
? "bg-background text-foreground shadow-sm"
: "text-muted-foreground hover:text-foreground"
}`}
>
<Network className="w-4 h-4" />
Graph
Graph View
</button>
<button
onClick={() => setViewMode("table")}
className={`px-3 py-1.5 rounded-md text-sm font-medium transition-all flex items-center gap-1.5 ${
className={`px-4 py-2 rounded-md text-sm font-medium transition-all ${
viewMode === "table"
? "bg-background text-foreground shadow-sm"
: "text-muted-foreground hover:text-foreground"
}`}
>
<List className="w-4 h-4" />
Table
Table View
</button>
<button
onClick={() => setViewMode("timeline")}
className={`px-3 py-1.5 rounded-md text-sm font-medium transition-all flex items-center gap-1.5 ${
className={`px-4 py-2 rounded-md text-sm font-medium transition-all ${
viewMode === "timeline"
? "bg-background text-foreground shadow-sm"
: "text-muted-foreground hover:text-foreground"
}`}
>
<Calendar className="w-4 h-4" />
Timeline
Timeline View
</button>
</div>
</div>
@@ -609,12 +616,25 @@ export function DataView({ factType }: DataViewProps) {
<Table className="table-fixed">
<TableHeader>
<TableRow className="bg-muted/50">
<TableHead className="w-[45%]">
{factType === "observation" ? "Observation" : "Memory"}
<TableHead
className={factType === "mental_model" ? "w-[55%]" : "w-[45%]"}
>
{factType === "mental_model" ? "Mental Model" : "Memory"}
</TableHead>
<TableHead className="w-[20%]">Entities</TableHead>
<TableHead className="w-[17%]">Occurred</TableHead>
<TableHead className="w-[18%]">Mentioned</TableHead>
{factType === "mental_model" ? (
<>
<TableHead className="w-[10%]">Sources</TableHead>
<TableHead className="w-[15%]">Created</TableHead>
<TableHead className="w-[15%]">Mentioned</TableHead>
</>
) : (
<>
<TableHead className="w-[20%]">Entities</TableHead>
<TableHead className="w-[15%]">Occurred</TableHead>
<TableHead className="w-[15%]">Mentioned</TableHead>
</>
)}
<TableHead className="w-[5%]"></TableHead>
</TableRow>
</TableHeader>
<TableBody>
@@ -623,66 +643,112 @@ export function DataView({ factType }: DataViewProps) {
? new Date(row.occurred_start).toLocaleDateString("en-US", {
month: "short",
day: "numeric",
year: "numeric",
})
: null;
const mentionedDisplay = row.mentioned_at
? new Date(row.mentioned_at).toLocaleDateString("en-US", {
month: "short",
day: "numeric",
year: "numeric",
})
: null;
const createdDisplay = row.created_at
? new Date(row.created_at).toLocaleDateString("en-US", {
month: "short",
day: "numeric",
})
: null;
return (
<TableRow
key={row.id || idx}
onClick={() => setModalMemoryId(row.id)}
className="cursor-pointer hover:bg-muted/50"
onClick={() => setSelectedTableMemory(row)}
className={`cursor-pointer hover:bg-muted/50 ${
selectedTableMemory?.id === row.id ? "bg-primary/10" : ""
}`}
>
<TableCell className="py-2">
<div className="line-clamp-2 text-sm leading-snug text-foreground">
{row.text}
</div>
{row.context && factType !== "observation" && (
{row.context && (
<div className="text-xs text-muted-foreground mt-0.5 truncate">
{row.context}
</div>
)}
</TableCell>
<TableCell className="py-2">
{row.entities ? (
<div className="flex gap-1 flex-wrap">
{row.entities
.split(", ")
.slice(0, 2)
.map((entity: string, i: number) => (
<span
key={i}
className="text-[10px] px-1.5 py-0.5 rounded-full bg-primary/10 text-primary font-medium"
>
{entity}
</span>
))}
{row.entities.split(", ").length > 2 && (
<span className="text-[10px] text-muted-foreground">
+{row.entities.split(", ").length - 2}
{factType === "mental_model" ? (
<>
<TableCell className="text-xs py-2 text-foreground text-center">
{row.proof_count || 1}
</TableCell>
<TableCell className="text-xs py-2 text-foreground">
{createdDisplay || (
<span className="text-muted-foreground">-</span>
)}
</TableCell>
<TableCell className="text-xs py-2 text-foreground">
{mentionedDisplay || (
<span className="text-muted-foreground">-</span>
)}
</TableCell>
</>
) : (
<>
<TableCell className="py-2">
{row.entities ? (
<div className="flex gap-1 flex-wrap">
{row.entities
.split(", ")
.slice(0, 2)
.map((entity: string, i: number) => (
<span
key={i}
className="text-[10px] px-1.5 py-0.5 rounded-full bg-primary/10 text-primary font-medium"
>
{entity}
</span>
))}
{row.entities.split(", ").length > 2 && (
<span className="text-[10px] text-muted-foreground">
+{row.entities.split(", ").length - 2}
</span>
)}
</div>
) : (
<span className="text-xs text-muted-foreground">
-
</span>
)}
</div>
) : (
<span className="text-xs text-muted-foreground">-</span>
)}
</TableCell>
<TableCell className="text-xs py-2 text-foreground">
{occurredDisplay || (
<span className="text-muted-foreground">-</span>
)}
</TableCell>
<TableCell className="text-xs py-2 text-foreground">
{mentionedDisplay || (
<span className="text-muted-foreground">-</span>
)}
</TableCell>
<TableCell className="text-xs py-2 text-foreground">
{occurredDisplay || (
<span className="text-muted-foreground">-</span>
)}
</TableCell>
<TableCell className="text-xs py-2 text-foreground">
{mentionedDisplay || (
<span className="text-muted-foreground">-</span>
)}
</TableCell>
</>
)}
<TableCell className="py-2">
<Button
onClick={(e) => {
e.stopPropagation();
copyToClipboard(row.id);
}}
size="sm"
variant="secondary"
className="h-6 w-6 p-0"
title="Copy ID"
>
{copiedId === row.id ? (
<Check className="h-3 w-3 text-green-600" />
) : (
<Copy className="h-3 w-3" />
)}
</Button>
</TableCell>
</TableRow>
);
@@ -753,6 +819,18 @@ export function DataView({ factType }: DataViewProps) {
)}
</div>
</div>
{/* Memory Detail Panel for Table View - Fixed on Right */}
{selectedTableMemory && (
<div className="fixed right-0 top-0 h-screen w-[420px] bg-card border-l-2 border-primary shadow-2xl z-50 overflow-y-auto animate-in slide-in-from-right duration-300 ease-out">
<MemoryDetailPanel
memory={selectedTableMemory}
onClose={() => setSelectedTableMemory(null)}
inPanel
bankId={currentBank || undefined}
/>
</div>
)}
</div>
)}
@@ -772,9 +850,6 @@ export function DataView({ factType }: DataViewProps) {
</div>
</div>
)}
{/* Memory Detail Modal */}
<MemoryDetailModal memoryId={modalMemoryId} onClose={() => setModalMemoryId(null)} />
</div>
);
}
@@ -6,16 +6,6 @@ import { useBank } from "@/lib/bank-context";
import { Dialog, DialogContent, DialogHeader, DialogTitle } from "@/components/ui/dialog";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import { Loader2, Calendar, Tag, Users, FileText, Layers } from "lucide-react";
import { Button } from "@/components/ui/button";
interface SourceMemory {
id: string;
text: string;
context: string | null;
type: string;
occurred_start: string | null;
mentioned_at: string | null;
}
interface MemoryDetail {
id: string;
@@ -30,7 +20,6 @@ interface MemoryDetail {
document_id: string | null;
chunk_id: string | null;
tags: string[];
source_memories?: SourceMemory[];
}
interface MemoryDetailModalProps {
@@ -51,9 +40,6 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
const [loadingDocument, setLoadingDocument] = useState(false);
const [loadingChunk, setLoadingChunk] = useState(false);
// Source memory modal (for viewing source memories of observations)
const [sourceMemoryModalId, setSourceMemoryModalId] = useState<string | null>(null);
// Load memory details
useEffect(() => {
if (!memoryId || !currentBank) return;
@@ -120,80 +106,114 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
const isOpen = memoryId !== null;
// Determine the display title based on memory type
const getMemoryTypeTitle = () => {
if (memory?.type === "observation") return "Observation";
if (memory?.type === "world") return "World Fact";
if (memory?.type === "experience") return "Experience";
return "Memory Details";
};
const isObservation = memory?.type === "observation";
return (
<>
<Dialog open={isOpen} onOpenChange={(open) => !open && onClose()}>
<DialogContent className="max-w-2xl max-h-[80vh] overflow-hidden flex flex-col">
<DialogHeader>
<DialogTitle>{memory ? getMemoryTypeTitle() : "Memory Details"}</DialogTitle>
</DialogHeader>
<Dialog open={isOpen} onOpenChange={(open) => !open && onClose()}>
<DialogContent className="max-w-2xl max-h-[80vh] overflow-hidden flex flex-col">
<DialogHeader>
<DialogTitle>Memory Details</DialogTitle>
</DialogHeader>
{loading ? (
<div className="flex items-center justify-center py-20">
<Loader2 className="w-8 h-8 animate-spin text-muted-foreground" />
{loading ? (
<div className="flex items-center justify-center py-20">
<Loader2 className="w-8 h-8 animate-spin text-muted-foreground" />
</div>
) : error ? (
<div className="flex items-center justify-center py-20">
<div className="text-center text-destructive">
<div className="text-sm">Error: {error}</div>
</div>
) : error ? (
<div className="flex items-center justify-center py-20">
<div className="text-center text-destructive">
<div className="text-sm">Error: {error}</div>
</div>
</div>
) : memory ? (
isObservation ? (
/* Observation view - no tabs since chunk/document don't apply */
<div className="flex-1 overflow-y-auto space-y-4">
{/* Text */}
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">Text</div>
</div>
) : memory ? (
<Tabs
value={activeTab}
onValueChange={setActiveTab}
className="flex-1 flex flex-col overflow-hidden"
>
<TabsList className="grid w-full grid-cols-3">
<TabsTrigger value="memory" className="flex items-center gap-1.5">
<FileText className="w-3.5 h-3.5" />
Memory
</TabsTrigger>
<TabsTrigger
value="chunk"
disabled={!memory.chunk_id}
className="flex items-center gap-1.5"
>
<Layers className="w-3.5 h-3.5" />
Chunk
</TabsTrigger>
<TabsTrigger
value="document"
disabled={!memory.document_id}
className="flex items-center gap-1.5"
>
<FileText className="w-3.5 h-3.5" />
Document
</TabsTrigger>
</TabsList>
<div className="flex-1 overflow-y-auto mt-4">
<TabsContent value="memory" className="mt-0 space-y-4">
{/* Memory text */}
<div className="p-4 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Memory Text
</div>
<p className="text-sm text-foreground leading-relaxed">{memory.text}</p>
</div>
{/* Dates */}
{memory.occurred_start && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Occurred
</div>
<div className="flex items-center gap-2 text-sm text-foreground">
<Calendar className="h-4 w-4 text-muted-foreground flex-shrink-0" />
<span>
{new Date(memory.occurred_start).toLocaleString()}
{memory.occurred_end && memory.occurred_end !== memory.occurred_start && (
<>
<span className="text-muted-foreground mx-1"></span>
{new Date(memory.occurred_end).toLocaleString()}
</>
)}
</span>
{/* Metadata grid */}
<div className="grid grid-cols-2 gap-3">
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Type
</div>
<div className="text-sm text-foreground capitalize">{memory.type}</div>
</div>
)}
{memory.context && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Context
</div>
<div className="text-sm text-foreground">{memory.context}</div>
</div>
)}
</div>
{memory.mentioned_at && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Mentioned
</div>
<div className="flex items-center gap-2 text-sm text-foreground">
<Calendar className="h-4 w-4 text-muted-foreground flex-shrink-0" />
<span>{new Date(memory.mentioned_at).toLocaleString()}</span>
</div>
{/* Dates */}
{(memory.mentioned_at || memory.occurred_start) && (
<div className="grid grid-cols-2 gap-3">
{memory.mentioned_at && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1 flex items-center gap-1">
<Calendar className="w-3 h-3" />
Mentioned At
</div>
<div className="text-sm text-foreground">
{new Date(memory.mentioned_at).toLocaleString()}
</div>
</div>
)}
{memory.occurred_start && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1 flex items-center gap-1">
<Calendar className="w-3 h-3" />
Occurred
</div>
<div className="text-sm text-foreground">
{new Date(memory.occurred_start).toLocaleDateString()}
{memory.occurred_end && memory.occurred_end !== memory.occurred_start && (
<> - {new Date(memory.occurred_end).toLocaleDateString()}</>
)}
</div>
</div>
)}
</div>
)}
{/* Entities */}
{memory.entities && memory.entities.length > 0 && (
<div>
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2 flex items-center gap-1">
<Users className="w-3 h-3" />
Entities
@@ -202,7 +222,7 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
{memory.entities.map((entity, idx) => (
<span
key={idx}
className="px-2 py-0.5 bg-primary/10 text-primary rounded text-xs"
className="px-2 py-0.5 bg-background rounded text-xs text-foreground"
>
{entity}
</span>
@@ -213,7 +233,7 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
{/* Tags */}
{memory.tags && memory.tags.length > 0 && (
<div>
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2 flex items-center gap-1">
<Tag className="w-3 h-3" />
Tags
@@ -222,7 +242,7 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
{memory.tags.map((tag, idx) => (
<span
key={idx}
className="px-2 py-0.5 bg-amber-500/10 text-amber-600 dark:text-amber-400 rounded text-xs"
className="px-2 py-0.5 bg-primary/10 text-primary rounded text-xs"
>
{tag}
</span>
@@ -231,69 +251,8 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
</div>
)}
{/* Source Memories */}
{memory.source_memories && memory.source_memories.length > 0 && (
<div className="border-t border-border pt-4">
<div className="text-xs font-bold text-muted-foreground uppercase mb-3">
Source Memories ({memory.source_memories.length})
</div>
<div className="space-y-3">
{memory.source_memories.map((source, i) => (
<div
key={source.id || i}
className="p-3 bg-muted/50 rounded-lg border border-border/50"
>
<div className="flex items-start justify-between gap-2 mb-2">
<span
className={`px-2 py-0.5 rounded text-xs flex-shrink-0 ${
source.type === "experience"
? "bg-green-500/10 text-green-600 dark:text-green-400"
: "bg-blue-500/10 text-blue-600 dark:text-blue-400"
}`}
>
{source.type}
</span>
<Button
variant="outline"
size="sm"
className="h-6 text-xs"
onClick={() => setSourceMemoryModalId(source.id)}
>
View
</Button>
</div>
<p className="text-sm text-foreground mb-2">{source.text}</p>
{source.context && (
<p className="text-xs text-muted-foreground mb-2 italic">
Context: {source.context}
</p>
)}
<div className="grid grid-cols-2 gap-2 text-xs">
{source.occurred_start && (
<div className="p-2 bg-background/50 rounded">
<div className="text-muted-foreground mb-0.5">Occurred</div>
<div className="font-medium">
{new Date(source.occurred_start).toLocaleString()}
</div>
</div>
)}
{source.mentioned_at && (
<div className="p-2 bg-background/50 rounded">
<div className="text-muted-foreground mb-0.5">Mentioned</div>
<div className="font-medium">
{new Date(source.mentioned_at).toLocaleString()}
</div>
</div>
)}
</div>
</div>
))}
</div>
</div>
)}
{/* ID */}
<div>
{/* IDs */}
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Memory ID
</div>
@@ -301,278 +260,132 @@ export function MemoryDetailModal({ memoryId, onClose }: MemoryDetailModalProps)
{memory.id}
</code>
</div>
</div>
) : (
/* World/Experience view - with tabs */
<Tabs
value={activeTab}
onValueChange={setActiveTab}
className="flex-1 flex flex-col overflow-hidden"
>
<TabsList className="grid w-full grid-cols-3">
<TabsTrigger value="memory" className="flex items-center gap-1.5">
<FileText className="w-3.5 h-3.5" />
{memory.type === "world" ? "World Fact" : "Experience"}
</TabsTrigger>
<TabsTrigger
value="chunk"
disabled={!memory.chunk_id}
className="flex items-center gap-1.5"
>
<Layers className="w-3.5 h-3.5" />
Chunk
</TabsTrigger>
<TabsTrigger
value="document"
disabled={!memory.document_id}
className="flex items-center gap-1.5"
>
<FileText className="w-3.5 h-3.5" />
Document
</TabsTrigger>
</TabsList>
</TabsContent>
<div className="flex-1 overflow-y-auto mt-4">
<TabsContent value="memory" className="mt-0 space-y-4">
{/* Memory text */}
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Text
<TabsContent value="chunk" className="mt-0 space-y-4">
{loadingChunk ? (
<div className="flex items-center justify-center py-12">
<Loader2 className="w-6 h-6 animate-spin text-muted-foreground" />
</div>
) : chunk ? (
<>
<div className="grid grid-cols-2 gap-3">
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Chunk Index
</div>
<div className="text-sm text-foreground">{chunk.chunk_index}</div>
</div>
<p className="text-sm text-foreground leading-relaxed">{memory.text}</p>
{chunk.chunk_text && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Text Length
</div>
<div className="text-sm text-foreground">
{chunk.chunk_text.length.toLocaleString()} chars
</div>
</div>
)}
</div>
{/* Context */}
{memory.context && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Context
</div>
<div className="text-sm text-foreground">{memory.context}</div>
</div>
)}
{/* Dates */}
{memory.occurred_start && (
{chunk.chunk_text && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Occurred
Chunk Text
</div>
<div className="flex items-center gap-2 text-sm text-foreground">
<Calendar className="h-4 w-4 text-muted-foreground flex-shrink-0" />
<span>
{new Date(memory.occurred_start).toLocaleString()}
{memory.occurred_end &&
memory.occurred_end !== memory.occurred_start && (
<>
<span className="text-muted-foreground mx-1"></span>
{new Date(memory.occurred_end).toLocaleString()}
</>
)}
</span>
<div className="p-4 bg-muted rounded-lg border border-border max-h-[300px] overflow-y-auto">
<pre className="text-sm whitespace-pre-wrap font-mono text-foreground">
{chunk.chunk_text}
</pre>
</div>
</div>
)}
{memory.mentioned_at && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Mentioned
</div>
<div className="flex items-center gap-2 text-sm text-foreground">
<Calendar className="h-4 w-4 text-muted-foreground flex-shrink-0" />
<span>{new Date(memory.mentioned_at).toLocaleString()}</span>
</div>
</div>
)}
{/* Entities */}
{memory.entities && memory.entities.length > 0 && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2 flex items-center gap-1">
<Users className="w-3 h-3" />
Entities
</div>
<div className="flex flex-wrap gap-1.5">
{memory.entities.map((entity, idx) => (
<span
key={idx}
className="px-2 py-0.5 bg-primary/10 text-primary rounded text-xs"
>
{entity}
</span>
))}
</div>
</div>
)}
{/* Tags */}
{memory.tags && memory.tags.length > 0 && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2 flex items-center gap-1">
<Tag className="w-3 h-3" />
Tags
</div>
<div className="flex flex-wrap gap-1.5">
{memory.tags.map((tag, idx) => (
<span
key={idx}
className="px-2 py-0.5 bg-amber-500/10 text-amber-600 dark:text-amber-400 rounded text-xs"
>
{tag}
</span>
))}
</div>
</div>
)}
{/* ID */}
<div>
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Memory ID
Chunk ID
</div>
<code className="text-xs font-mono text-muted-foreground break-all">
{memory.id}
{chunk.chunk_id}
</code>
</div>
</TabsContent>
<TabsContent value="chunk" className="mt-0 space-y-4">
{loadingChunk ? (
<div className="flex items-center justify-center py-12">
<Loader2 className="w-6 h-6 animate-spin text-muted-foreground" />
</div>
) : chunk ? (
<>
<div className="grid grid-cols-2 gap-3">
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Chunk Index
</div>
<div className="text-sm text-foreground">{chunk.chunk_index}</div>
</div>
{chunk.chunk_text && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Text Length
</div>
<div className="text-sm text-foreground">
{chunk.chunk_text.length.toLocaleString()} chars
</div>
</div>
)}
</div>
{chunk.chunk_text && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Chunk Text
</div>
<div className="p-4 bg-muted rounded-lg border border-border max-h-[300px] overflow-y-auto">
<pre className="text-sm whitespace-pre-wrap font-mono text-foreground">
{chunk.chunk_text}
</pre>
</div>
</div>
)}
</>
) : (
<div className="text-center py-12 text-muted-foreground">
No chunk data available
</div>
)}
</TabsContent>
<TabsContent value="document" className="mt-0 space-y-4">
{loadingDocument ? (
<div className="flex items-center justify-center py-12">
<Loader2 className="w-6 h-6 animate-spin text-muted-foreground" />
</div>
) : document ? (
<>
<div className="grid grid-cols-2 gap-3">
{document.created_at && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Chunk ID
Created
</div>
<div className="text-sm text-foreground">
{new Date(document.created_at).toLocaleString()}
</div>
<code className="text-xs font-mono text-muted-foreground break-all">
{chunk.chunk_id}
</code>
</div>
</>
) : (
<div className="text-center py-12 text-muted-foreground">
No chunk data available
)}
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Memory Units
</div>
<div className="text-sm text-foreground">{document.memory_unit_count}</div>
</div>
)}
</TabsContent>
</div>
<TabsContent value="document" className="mt-0 space-y-4">
{loadingDocument ? (
<div className="flex items-center justify-center py-12">
<Loader2 className="w-6 h-6 animate-spin text-muted-foreground" />
</div>
) : document ? (
{document.original_text && (
<>
<div className="grid grid-cols-2 gap-3">
{document.created_at && (
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Created
</div>
<div className="text-sm text-foreground">
{new Date(document.created_at).toLocaleString()}
</div>
</div>
)}
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Memory Units
</div>
<div className="text-sm text-foreground">
{document.memory_unit_count}
</div>
</div>
</div>
{document.original_text && (
<>
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Text Length
</div>
<div className="text-sm text-foreground">
{document.original_text.length.toLocaleString()} chars
</div>
</div>
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Original Text
</div>
<div className="p-4 bg-muted rounded-lg border border-border max-h-[300px] overflow-y-auto">
<pre className="text-sm whitespace-pre-wrap font-mono text-foreground">
{document.original_text}
</pre>
</div>
</div>
</>
)}
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Document ID
Text Length
</div>
<div className="text-sm text-foreground">
{document.original_text.length.toLocaleString()} chars
</div>
</div>
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Original Text
</div>
<div className="p-4 bg-muted rounded-lg border border-border max-h-[300px] overflow-y-auto">
<pre className="text-sm whitespace-pre-wrap font-mono text-foreground">
{document.original_text}
</pre>
</div>
<code className="text-xs font-mono text-muted-foreground break-all">
{document.id}
</code>
</div>
</>
) : (
<div className="text-center py-12 text-muted-foreground">
No document data available
</div>
)}
</TabsContent>
</div>
</Tabs>
)
) : null}
</DialogContent>
</Dialog>
{/* Nested modal for viewing source memories */}
{sourceMemoryModalId && (
<MemoryDetailModal
memoryId={sourceMemoryModalId}
onClose={() => setSourceMemoryModalId(null)}
/>
)}
</>
<div className="p-3 bg-muted rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-1">
Document ID
</div>
<code className="text-xs font-mono text-muted-foreground break-all">
{document.id}
</code>
</div>
</>
) : (
<div className="text-center py-12 text-muted-foreground">
No document data available
</div>
)}
</TabsContent>
</div>
</Tabs>
) : null}
</DialogContent>
</Dialog>
);
}
@@ -2,7 +2,7 @@
import { useState, useEffect } from "react";
import { Button } from "@/components/ui/button";
import { Copy, Check, X, Loader2, Calendar } from "lucide-react";
import { Copy, Check, X, Loader2 } from "lucide-react";
import { DocumentChunkModal } from "./document-chunk-modal";
import { MemoryDetailModal } from "./memory-detail-modal";
import { client } from "@/lib/api";
@@ -58,18 +58,8 @@ export function MemoryDetailPanel({
// Use full memory data if available, otherwise fall back to the partial data passed in
const displayMemory = fullMemory || memory;
const isObservation =
displayMemory?.fact_type === "observation" || displayMemory?.type === "observation";
// Determine the display title based on memory type
const getMemoryTypeTitle = () => {
const factType = displayMemory?.fact_type || displayMemory?.type;
if (factType === "observation") return "Observation";
if (factType === "world") return "World Fact";
if (factType === "experience") return "Experience";
return "Memory Details";
};
const memoryTypeTitle = getMemoryTypeTitle();
const isMentalModel =
displayMemory?.fact_type === "mental_model" || displayMemory?.type === "mental_model";
const copyToClipboard = async (text: string) => {
try {
@@ -111,7 +101,10 @@ export function MemoryDetailPanel({
<div className="p-5">
{/* Header with close button */}
<div className="flex justify-between items-center mb-6 pb-4 border-b border-border">
<h3 className="text-xl font-bold text-foreground">{memoryTypeTitle}</h3>
<div>
<h3 className="text-xl font-bold text-foreground">Memory Details</h3>
<p className="text-sm text-muted-foreground mt-1">Full memory content and metadata</p>
</div>
<Button variant="secondary" size="sm" onClick={onClose} className="h-8 w-8 p-0">
<X className="h-5 w-5" />
</Button>
@@ -124,17 +117,19 @@ export function MemoryDetailPanel({
</div>
) : (
<div className="space-y-5">
{/* Text */}
{/* Full Text */}
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">Text</div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Full Text
</div>
<div className="text-sm whitespace-pre-wrap leading-relaxed text-foreground">
{displayMemory.text}
</div>
</div>
{/* Context (not shown for observations) */}
{displayMemory.context && !isObservation && (
<div>
{/* Context (not shown for mental models) */}
{displayMemory.context && !isMentalModel && (
<div className="p-4 bg-muted/50 rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Context
</div>
@@ -143,38 +138,28 @@ export function MemoryDetailPanel({
)}
{/* Dates */}
{displayMemory.occurred_start && (
<div>
<div className="grid grid-cols-2 gap-4">
<div className="p-4 bg-muted/50 rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Occurred
</div>
<div className="flex items-center gap-2 text-sm text-foreground">
<Calendar className="h-4 w-4 text-muted-foreground flex-shrink-0" />
<span>
{new Date(displayMemory.occurred_start).toLocaleString()}
{displayMemory.occurred_end &&
displayMemory.occurred_end !== displayMemory.occurred_start && (
<>
<span className="text-muted-foreground mx-1"></span>
{new Date(displayMemory.occurred_end).toLocaleString()}
</>
)}
</span>
<div className="text-sm font-medium text-foreground">
{displayMemory.occurred_start
? new Date(displayMemory.occurred_start).toLocaleString()
: "N/A"}
</div>
</div>
)}
{displayMemory.mentioned_at && (
<div>
<div className="p-4 bg-muted/50 rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Mentioned
</div>
<div className="flex items-center gap-2 text-sm text-foreground">
<Calendar className="h-4 w-4 text-muted-foreground flex-shrink-0" />
<span>{new Date(displayMemory.mentioned_at).toLocaleString()}</span>
<div className="text-sm font-medium text-foreground">
{displayMemory.mentioned_at
? new Date(displayMemory.mentioned_at).toLocaleString()
: "N/A"}
</div>
</div>
)}
</div>
{/* Entities */}
{displayMemory.entities &&
@@ -224,7 +209,7 @@ export function MemoryDetailPanel({
</div>
)}
{/* Source Memories (for observations) */}
{/* Source Memories (for mental models) */}
{displayMemory.source_memories && displayMemory.source_memories.length > 0 && (
<div className="border-t border-border pt-5">
<div className="text-xs font-bold text-muted-foreground uppercase mb-3">
@@ -285,6 +270,32 @@ export function MemoryDetailPanel({
</div>
)}
{/* ID */}
{memoryId && (
<div className="p-4 bg-muted/50 rounded-lg">
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Memory ID
</div>
<div className="flex items-center gap-2">
<code className="text-xs font-mono break-all flex-1 text-muted-foreground">
{memoryId}
</code>
<Button
variant="ghost"
size="sm"
className="h-8 w-8 p-0 flex-shrink-0"
onClick={() => copyToClipboard(memoryId)}
>
{copiedId === memoryId ? (
<Check className="h-4 w-4 text-green-600" />
) : (
<Copy className="h-4 w-4" />
)}
</Button>
</div>
</div>
)}
{/* Document/Chunk buttons */}
{(displayMemory.document_id || displayMemory.chunk_id) && (
<div className="flex gap-3 pt-2">
@@ -308,30 +319,6 @@ export function MemoryDetailPanel({
)}
</div>
)}
{/* Memory ID */}
{memoryId && (
<div>
<div className="text-xs font-bold text-muted-foreground uppercase mb-2">
Memory ID
</div>
<div className="flex items-center gap-2">
<code className="text-xs font-mono text-muted-foreground">{memoryId}</code>
<Button
variant="ghost"
size="sm"
className="h-5 w-5 p-0"
onClick={() => copyToClipboard(memoryId)}
>
{copiedId === memoryId ? (
<Check className="h-3 w-3 text-green-600" />
) : (
<Copy className="h-3 w-3 text-muted-foreground" />
)}
</Button>
</div>
</div>
)}
</div>
)}
</div>
@@ -361,7 +348,12 @@ export function MemoryDetailPanel({
className={`bg-card border-2 border-primary rounded-lg ${padding} sticky top-4 max-h-[calc(100vh-120px)] overflow-y-auto`}
>
<div className="flex justify-between items-start mb-4">
<h3 className={`${titleSize} font-bold text-card-foreground`}>{memoryTypeTitle}</h3>
<div>
<h3 className={`${titleSize} font-bold text-card-foreground`}>Memory Details</h3>
{!compact && (
<p className="text-sm text-muted-foreground">Full memory content and metadata</p>
)}
</div>
<Button
variant="ghost"
size="sm"
@@ -379,17 +371,17 @@ export function MemoryDetailPanel({
</div>
) : (
<div className={gap}>
{/* Text */}
{/* Full Text */}
<div className={`${compact ? "p-2" : "p-3"} bg-muted rounded-lg`}>
<div className={`${labelSize} font-bold text-muted-foreground uppercase mb-1`}>
Text
Full Text
</div>
<div className={`${textSize} whitespace-pre-wrap`}>{displayMemory.text}</div>
</div>
{/* Context */}
{displayMemory.context && (
<div>
<div className={`${compact ? "p-2" : "p-3"} bg-muted rounded-lg`}>
<div className={`${labelSize} font-bold text-muted-foreground uppercase mb-1`}>
Context
</div>
@@ -398,42 +390,28 @@ export function MemoryDetailPanel({
)}
{/* Dates */}
{displayMemory.occurred_start && (
<div className="grid grid-cols-2 gap-2">
<div className={`${compact ? "p-2" : "p-3"} bg-muted rounded-lg`}>
<div className={`${labelSize} font-bold text-muted-foreground uppercase mb-1`}>
Occurred
</div>
<div className={`flex items-center gap-2 ${textSize}`}>
<Calendar
className={`${compact ? "h-3 w-3" : "h-4 w-4"} text-muted-foreground flex-shrink-0`}
/>
<span>
{new Date(displayMemory.occurred_start).toLocaleString()}
{displayMemory.occurred_end &&
displayMemory.occurred_end !== displayMemory.occurred_start && (
<>
<span className="text-muted-foreground mx-1"></span>
{new Date(displayMemory.occurred_end).toLocaleString()}
</>
)}
</span>
<div className={textSize}>
{displayMemory.occurred_start
? new Date(displayMemory.occurred_start).toLocaleString()
: "N/A"}
</div>
</div>
)}
{displayMemory.mentioned_at && (
<div className={`${compact ? "p-2" : "p-3"} bg-muted rounded-lg`}>
<div className={`${labelSize} font-bold text-muted-foreground uppercase mb-1`}>
Mentioned
</div>
<div className={`flex items-center gap-2 ${textSize}`}>
<Calendar
className={`${compact ? "h-3 w-3" : "h-4 w-4"} text-muted-foreground flex-shrink-0`}
/>
<span>{new Date(displayMemory.mentioned_at).toLocaleString()}</span>
<div className={textSize}>
{displayMemory.mentioned_at
? new Date(displayMemory.mentioned_at).toLocaleString()
: "N/A"}
</div>
</div>
)}
</div>
{/* Entities */}
{displayMemory.entities &&
@@ -485,6 +463,32 @@ export function MemoryDetailPanel({
</div>
)}
{/* ID */}
{memoryId && (
<div className={`${compact ? "p-2" : "p-3"} bg-muted rounded-lg`}>
<div className={`${labelSize} font-bold text-muted-foreground uppercase mb-1`}>
Memory ID
</div>
<div className="flex items-center gap-2">
<span className={`${compact ? "text-[10px]" : "text-sm"} font-mono break-all`}>
{memoryId}
</span>
<Button
variant="ghost"
size="sm"
className="h-6 w-6 p-0 flex-shrink-0"
onClick={() => copyToClipboard(memoryId)}
>
{copiedId === memoryId ? (
<Check className="h-3 w-3 text-green-600" />
) : (
<Copy className="h-3 w-3" />
)}
</Button>
</div>
</div>
)}
{/* Document/Chunk buttons */}
{(displayMemory.document_id || displayMemory.chunk_id) && (
<div className={`flex gap-2 ${compact ? "pt-1" : ""}`}>
@@ -553,36 +557,6 @@ export function MemoryDetailPanel({
</div>
</div>
)}
{/* Memory ID */}
{memoryId && (
<div>
<div className={`${labelSize} font-bold text-muted-foreground uppercase mb-1`}>
Memory ID
</div>
<div className="flex items-center gap-2">
<code
className={`${compact ? "text-[9px]" : "text-xs"} font-mono text-muted-foreground`}
>
{memoryId}
</code>
<Button
variant="ghost"
size="sm"
className={`${compact ? "h-4 w-4" : "h-5 w-5"} p-0`}
onClick={() => copyToClipboard(memoryId)}
>
{copiedId === memoryId ? (
<Check className={`${compact ? "h-2.5 w-2.5" : "h-3 w-3"} text-green-600`} />
) : (
<Copy
className={`${compact ? "h-2.5 w-2.5" : "h-3 w-3"} text-muted-foreground`}
/>
)}
</Button>
</div>
</div>
)}
</div>
)}
</div>
@@ -1,165 +0,0 @@
"use client";
import { useState, useEffect } from "react";
import { client, MentalModel } from "@/lib/api";
import { useBank } from "@/lib/bank-context";
import { Dialog, DialogContent, DialogTitle } from "@/components/ui/dialog";
import { VisuallyHidden } from "@radix-ui/react-visually-hidden";
import { Loader2, Zap } from "lucide-react";
import ReactMarkdown from "react-markdown";
interface MentalModelDetailContentProps {
mentalModel: MentalModel;
}
const formatDateTime = (dateStr: string) => {
const date = new Date(dateStr);
return `${date.toLocaleDateString("en-US", {
month: "short",
day: "numeric",
year: "numeric",
})} at ${date.toLocaleTimeString("en-US", {
hour: "2-digit",
minute: "2-digit",
hour12: false,
})}`;
};
/**
* Shared content component for displaying mental model details.
* Matches the layout of MentalModelDetailPanel for consistency.
*/
export function MentalModelDetailContent({ mentalModel }: MentalModelDetailContentProps) {
return (
<div className="space-y-6">
{/* Header: Name, ID, Source Query */}
<div className="pb-5 border-b border-border">
<div className="flex items-center gap-2">
<h3 className="text-xl font-bold text-foreground">{mentalModel.name}</h3>
{mentalModel.trigger?.refresh_after_consolidation && (
<span className="flex items-center gap-1 px-2 py-0.5 rounded-full bg-amber-500/10 text-amber-600 dark:text-amber-400 text-xs font-medium">
<Zap className="w-3 h-3" />
Auto refresh
</span>
)}
</div>
<code className="text-xs font-mono text-muted-foreground/70">{mentalModel.id}</code>
{mentalModel.source_query && (
<p className="text-sm text-muted-foreground mt-1">{mentalModel.source_query}</p>
)}
</div>
{/* Created / Last Refreshed */}
<div className="flex gap-8">
<div>
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide mb-1">
Created
</div>
<div className="text-sm text-foreground">{formatDateTime(mentalModel.created_at)}</div>
</div>
<div>
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide mb-1">
Last Refreshed
</div>
<div className="text-sm text-foreground">
{formatDateTime(mentalModel.last_refreshed_at)}
</div>
</div>
</div>
{/* Content */}
<div>
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide mb-3">
Content
</div>
<div className="prose prose-base dark:prose-invert max-w-none">
<ReactMarkdown>{mentalModel.content}</ReactMarkdown>
</div>
</div>
{/* Tags */}
{mentalModel.tags && mentalModel.tags.length > 0 && (
<div>
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide mb-3">
Tags
</div>
<div className="flex flex-wrap gap-1.5">
{mentalModel.tags.map((tag: string, idx: number) => (
<span
key={idx}
className="px-2 py-0.5 bg-amber-500/10 text-amber-600 dark:text-amber-400 rounded text-xs"
>
{tag}
</span>
))}
</div>
</div>
)}
</div>
);
}
interface MentalModelDetailModalProps {
mentalModelId: string | null;
onClose: () => void;
}
/**
* Modal wrapper for MentalModelDetailContent.
* Fetches the mental model by ID and displays it in a dialog.
*/
export function MentalModelDetailModal({ mentalModelId, onClose }: MentalModelDetailModalProps) {
const { currentBank } = useBank();
const [mentalModel, setMentalModel] = useState<MentalModel | null>(null);
const [loading, setLoading] = useState(false);
const [error, setError] = useState<string | null>(null);
useEffect(() => {
if (!mentalModelId || !currentBank) return;
const loadMentalModel = async () => {
setLoading(true);
setError(null);
setMentalModel(null);
try {
const data = await client.getMentalModel(currentBank, mentalModelId);
setMentalModel(data);
} catch (err) {
console.error("Error loading mental model:", err);
setError((err as Error).message);
} finally {
setLoading(false);
}
};
loadMentalModel();
}, [mentalModelId, currentBank]);
const isOpen = mentalModelId !== null;
return (
<Dialog open={isOpen} onOpenChange={(open) => !open && onClose()}>
<DialogContent className="max-w-2xl max-h-[80vh] overflow-hidden flex flex-col p-6">
<VisuallyHidden>
<DialogTitle>Mental Model Details</DialogTitle>
</VisuallyHidden>
{loading ? (
<div className="flex items-center justify-center py-20">
<Loader2 className="w-8 h-8 animate-spin text-muted-foreground" />
</div>
) : error ? (
<div className="flex items-center justify-center py-20">
<div className="text-center text-destructive">
<div className="text-sm">Error: {error}</div>
</div>
</div>
) : mentalModel ? (
<div className="flex-1 overflow-y-auto">
<MentalModelDetailContent mentalModel={mentalModel} />
</div>
) : null}
</DialogContent>
</Dialog>
);
}
@@ -57,9 +57,10 @@ interface ReflectResponseBasedOnFact {
interface ReflectResponse {
text: string;
based_on: Record<string, ReflectResponseBasedOnFact[]>;
mental_models?: Array<{ id: string; text: string }>;
}
interface MentalModel {
interface Reflection {
id: string;
bank_id: string;
name: string;
@@ -71,31 +72,30 @@ interface MentalModel {
reflect_response?: ReflectResponse;
}
export function MentalModelsView() {
export function ReflectionsView() {
const { currentBank } = useBank();
const [mentalModels, setMentalModels] = useState<MentalModel[]>([]);
const [reflections, setReflections] = useState<Reflection[]>([]);
const [loading, setLoading] = useState(false);
const [searchQuery, setSearchQuery] = useState("");
const [currentPage, setCurrentPage] = useState(1);
const itemsPerPage = 100;
const [showCreateMentalModel, setShowCreateMentalModel] = useState(false);
const [selectedMentalModel, setSelectedMentalModel] = useState<MentalModel | null>(null);
const [showCreateReflection, setShowCreateReflection] = useState(false);
const [selectedReflection, setSelectedReflection] = useState<Reflection | null>(null);
const [deleteTarget, setDeleteTarget] = useState<{
id: string;
name: string;
} | null>(null);
const [deleting, setDeleting] = useState(false);
// Filter mental models based on search query
const filteredMentalModels = mentalModels.filter((m) => {
// Filter reflections based on search query
const filteredReflections = reflections.filter((r) => {
if (!searchQuery) return true;
const query = searchQuery.toLowerCase();
return (
m.id.toLowerCase().includes(query) ||
m.name.toLowerCase().includes(query) ||
m.source_query.toLowerCase().includes(query) ||
m.content.toLowerCase().includes(query)
r.name.toLowerCase().includes(query) ||
r.source_query.toLowerCase().includes(query) ||
r.content.toLowerCase().includes(query)
);
});
@@ -104,10 +104,10 @@ export function MentalModelsView() {
setLoading(true);
try {
const mentalModelsData = await client.listMentalModels(currentBank);
setMentalModels(mentalModelsData.items || []);
const reflectionsData = await client.listReflections(currentBank);
setReflections(reflectionsData.items || []);
} catch (error) {
console.error("Error loading mental models:", error);
console.error("Error loading reflections:", error);
} finally {
setLoading(false);
}
@@ -118,12 +118,12 @@ export function MentalModelsView() {
setDeleting(true);
try {
await client.deleteMentalModel(currentBank, deleteTarget.id);
setMentalModels((prev) => prev.filter((m) => m.id !== deleteTarget.id));
if (selectedMentalModel?.id === deleteTarget.id) setSelectedMentalModel(null);
await client.deleteReflection(currentBank, deleteTarget.id);
setReflections((prev) => prev.filter((r) => r.id !== deleteTarget.id));
if (selectedReflection?.id === deleteTarget.id) setSelectedReflection(null);
setDeleteTarget(null);
} catch (error) {
console.error("Error deleting mental model:", error);
console.error("Error deleting reflection:", error);
alert("Error deleting: " + (error as Error).message);
} finally {
setDeleting(false);
@@ -139,7 +139,7 @@ export function MentalModelsView() {
useEffect(() => {
const handleKeyDown = (e: KeyboardEvent) => {
if (e.key === "Escape") {
setSelectedMentalModel(null);
setSelectedReflection(null);
}
};
window.addEventListener("keydown", handleKeyDown);
@@ -155,17 +155,17 @@ export function MentalModelsView() {
return (
<Card>
<CardContent className="p-10 text-center">
<p className="text-muted-foreground">Select a memory bank to view mental models.</p>
<p className="text-muted-foreground">Select a memory bank to view reflections.</p>
</CardContent>
</Card>
);
}
// Pagination calculations
const totalPages = Math.ceil(filteredMentalModels.length / itemsPerPage);
const totalPages = Math.ceil(filteredReflections.length / itemsPerPage);
const startIndex = (currentPage - 1) * itemsPerPage;
const endIndex = startIndex + itemsPerPage;
const paginatedMentalModels = filteredMentalModels.slice(startIndex, endIndex);
const paginatedReflections = filteredReflections.slice(startIndex, endIndex);
return (
<div>
@@ -182,7 +182,7 @@ export function MentalModelsView() {
type="text"
value={searchQuery}
onChange={(e) => setSearchQuery(e.target.value)}
placeholder="Filter mental models by name, query, or content..."
placeholder="Filter reflections by name, query, or content..."
className="max-w-md"
/>
</div>
@@ -190,31 +190,30 @@ export function MentalModelsView() {
<div className="flex items-center justify-between mb-6">
<div className="text-sm text-muted-foreground">
{searchQuery
? `${filteredMentalModels.length} of ${mentalModels.length} mental models`
: `${mentalModels.length} mental model${mentalModels.length !== 1 ? "s" : ""}`}
? `${filteredReflections.length} of ${reflections.length} reflections`
: `${reflections.length} reflection${reflections.length !== 1 ? "s" : ""}`}
</div>
<Button onClick={() => setShowCreateMentalModel(true)} variant="outline" size="sm">
<Button onClick={() => setShowCreateReflection(true)} variant="outline" size="sm">
<Plus className="w-4 h-4 mr-2" />
Add Mental Model
Add Reflection
</Button>
</div>
{filteredMentalModels.length > 0 ? (
{filteredReflections.length > 0 ? (
<>
<div className="border rounded-lg overflow-hidden">
<Table className="table-fixed">
<TableHeader>
<TableRow className="bg-muted/50">
<TableHead className="w-[20%]">ID</TableHead>
<TableHead className="w-[20%]">Name</TableHead>
<TableHead className="w-[35%]">Source Query</TableHead>
<TableHead className="w-[15%]">Last Refreshed</TableHead>
<TableHead className="w-[25%]">Name</TableHead>
<TableHead className="w-[45%]">Source Query</TableHead>
<TableHead className="w-[20%]">Last Refreshed</TableHead>
<TableHead className="w-[10%]"></TableHead>
</TableRow>
</TableHeader>
<TableBody>
{paginatedMentalModels.map((m) => {
const refreshedDate = new Date(m.last_refreshed_at);
{paginatedReflections.map((r) => {
const refreshedDate = new Date(r.last_refreshed_at);
const dateDisplay = refreshedDate.toLocaleDateString("en-US", {
month: "short",
day: "numeric",
@@ -228,23 +227,18 @@ export function MentalModelsView() {
return (
<TableRow
key={m.id}
key={r.id}
className={`cursor-pointer hover:bg-muted/50 ${
selectedMentalModel?.id === m.id ? "bg-primary/10" : ""
selectedReflection?.id === r.id ? "bg-primary/10" : ""
}`}
onClick={() => setSelectedMentalModel(m)}
onClick={() => setSelectedReflection(r)}
>
<TableCell className="py-2">
<code className="text-xs font-mono text-muted-foreground truncate block">
{m.id}
</code>
</TableCell>
<TableCell className="py-2">
<div className="font-medium text-foreground">{m.name}</div>
<div className="font-medium text-foreground">{r.name}</div>
</TableCell>
<TableCell className="py-2">
<div className="text-sm text-muted-foreground truncate">
{m.source_query}
{r.source_query}
</div>
</TableCell>
<TableCell className="py-2 text-sm text-foreground">
@@ -258,7 +252,7 @@ export function MentalModelsView() {
className="h-8 w-8 p-0 text-muted-foreground hover:text-destructive"
onClick={(e) => {
e.stopPropagation();
setDeleteTarget({ id: m.id, name: m.name });
setDeleteTarget({ id: r.id, name: r.name });
}}
>
<Trash2 className="h-4 w-4" />
@@ -275,8 +269,8 @@ export function MentalModelsView() {
{totalPages > 1 && (
<div className="flex items-center justify-between mt-3 pt-3 border-t">
<div className="text-xs text-muted-foreground">
{startIndex + 1}-{Math.min(endIndex, filteredMentalModels.length)} of{" "}
{filteredMentalModels.length}
{startIndex + 1}-{Math.min(endIndex, filteredReflections.length)} of{" "}
{filteredReflections.length}
</div>
<div className="flex items-center gap-1">
<Button
@@ -327,20 +321,20 @@ export function MentalModelsView() {
<Sparkles className="w-6 h-6 mx-auto mb-2 text-muted-foreground" />
<p className="text-sm text-muted-foreground">
{searchQuery
? "No mental models match your filter"
: "No mental models yet. Create a mental model to generate and save a summary from your memories."}
? "No reflections match your filter"
: "No reflections yet. Create a reflection to generate and save a summary from your memories."}
</p>
</div>
)}
</>
)}
<CreateMentalModelDialog
open={showCreateMentalModel}
onClose={() => setShowCreateMentalModel(false)}
<CreateReflectionDialog
open={showCreateReflection}
onClose={() => setShowCreateReflection(false)}
onCreated={() => {
setShowCreateMentalModel(false);
// Reload the list immediately to show the new mental model
setShowCreateReflection(false);
// Reload the list immediately to show the new reflection
loadData();
}}
/>
@@ -348,7 +342,7 @@ export function MentalModelsView() {
<AlertDialog open={!!deleteTarget} onOpenChange={(open) => !open && setDeleteTarget(null)}>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>Delete Mental Model</AlertDialogTitle>
<AlertDialogTitle>Delete Reflection</AlertDialogTitle>
<AlertDialogDescription>
Are you sure you want to delete{" "}
<span className="font-semibold">&quot;{deleteTarget?.name}&quot;</span>?
@@ -371,16 +365,16 @@ export function MentalModelsView() {
</AlertDialogContent>
</AlertDialog>
{selectedMentalModel && (
<MentalModelDetailPanel
mentalModel={selectedMentalModel}
onClose={() => setSelectedMentalModel(null)}
{selectedReflection && (
<ReflectionDetailPanel
reflection={selectedReflection}
onClose={() => setSelectedReflection(null)}
onDelete={() =>
setDeleteTarget({ id: selectedMentalModel.id, name: selectedMentalModel.name })
setDeleteTarget({ id: selectedReflection.id, name: selectedReflection.name })
}
onRefreshed={(updated) => {
setMentalModels((prev) => prev.map((m) => (m.id === updated.id ? updated : m)));
setSelectedMentalModel(updated);
setReflections((prev) => prev.map((r) => (r.id === updated.id ? updated : r)));
setSelectedReflection(updated);
}}
/>
)}
@@ -388,7 +382,7 @@ export function MentalModelsView() {
);
}
function CreateMentalModelDialog({
function CreateReflectionDialog({
open,
onClose,
onCreated,
@@ -413,8 +407,8 @@ function CreateMentalModelDialog({
const maxTokens = parseInt(form.maxTokens) || 2048;
// Submit mental model creation - content will be generated in background
await client.createMentalModel(currentBank, {
// Submit reflection creation - content will be generated in background
await client.createReflection(currentBank, {
name: form.name.trim(),
source_query: form.sourceQuery.trim(),
tags: tags.length > 0 ? tags : undefined,
@@ -424,8 +418,8 @@ function CreateMentalModelDialog({
setForm({ name: "", sourceQuery: "", maxTokens: "2048", tags: "" });
onCreated();
} catch (error) {
console.error("Error creating mental model:", error);
alert("Error creating mental model: " + (error as Error).message);
console.error("Error creating reflection:", error);
alert("Error creating reflection: " + (error as Error).message);
} finally {
setCreating(false);
}
@@ -443,9 +437,9 @@ function CreateMentalModelDialog({
>
<DialogContent className="sm:max-w-lg">
<DialogHeader>
<DialogTitle>Create Mental Model</DialogTitle>
<DialogTitle>Create Reflection</DialogTitle>
<DialogDescription>
Create a mental model by running a query. The content will be auto-generated and can be
Create a reflection by running a query. The content will be auto-generated and can be
refreshed later.
</DialogDescription>
</DialogHeader>
@@ -519,39 +513,39 @@ function CreateMentalModelDialog({
);
}
function MentalModelDetailPanel({
mentalModel,
function ReflectionDetailPanel({
reflection,
onClose,
onDelete,
onRefreshed,
}: {
mentalModel: MentalModel;
reflection: Reflection;
onClose: () => void;
onDelete: () => void;
onRefreshed: (m: MentalModel) => void;
onRefreshed: (r: Reflection) => void;
}) {
const { currentBank } = useBank();
const [refreshing, setRefreshing] = useState(false);
const [viewMemoryId, setViewMemoryId] = useState<string | null>(null);
const [isEditing, setIsEditing] = useState(false);
const [editName, setEditName] = useState(mentalModel.name);
const [editName, setEditName] = useState(reflection.name);
const [saving, setSaving] = useState(false);
// Reset edit form when mental model changes
// Reset edit form when reflection changes
useEffect(() => {
setEditName(mentalModel.name);
setEditName(reflection.name);
setIsEditing(false);
}, [mentalModel.id, mentalModel.name]);
}, [reflection.id, reflection.name]);
const handleRefresh = async () => {
if (!currentBank) return;
setRefreshing(true);
const originalRefreshedAt = mentalModel.last_refreshed_at;
const originalRefreshedAt = reflection.last_refreshed_at;
try {
// Submit the refresh task
await client.refreshMentalModel(currentBank, mentalModel.id);
await client.refreshReflection(currentBank, reflection.id);
// Poll until last_refreshed_at changes
const pollInterval = 1000; // 1 second
@@ -561,7 +555,7 @@ function MentalModelDetailPanel({
const poll = async (): Promise<void> => {
attempts++;
try {
const updated = await client.getMentalModel(currentBank, mentalModel.id);
const updated = await client.getReflection(currentBank, reflection.id);
if (updated.last_refreshed_at !== originalRefreshedAt) {
// Refresh complete
onRefreshed(updated);
@@ -577,7 +571,7 @@ function MentalModelDetailPanel({
// Continue polling
setTimeout(poll, pollInterval);
} catch (error) {
console.error("Error polling mental model:", error);
console.error("Error polling reflection:", error);
setRefreshing(false);
}
};
@@ -585,7 +579,7 @@ function MentalModelDetailPanel({
// Start polling after a short delay
setTimeout(poll, pollInterval);
} catch (error) {
console.error("Error refreshing mental model:", error);
console.error("Error refreshing reflection:", error);
alert("Error refreshing: " + (error as Error).message);
setRefreshing(false);
}
@@ -596,13 +590,13 @@ function MentalModelDetailPanel({
setSaving(true);
try {
const updated = await client.updateMentalModel(currentBank, mentalModel.id, {
const updated = await client.updateReflection(currentBank, reflection.id, {
name: editName.trim(),
});
onRefreshed(updated);
setIsEditing(false);
} catch (error) {
console.error("Error updating mental model:", error);
console.error("Error updating reflection:", error);
alert("Error updating: " + (error as Error).message);
} finally {
setSaving(false);
@@ -622,15 +616,14 @@ function MentalModelDetailPanel({
})}`;
};
// Extract all memories from based_on (excluding observations which are shown separately)
const basedOnFacts = mentalModel.reflect_response?.based_on
? Object.entries(mentalModel.reflect_response.based_on)
.filter(([factType]) => factType !== "observation")
.flatMap(([factType, facts]) => facts.map((fact) => ({ ...fact, factType })))
// Extract all memories from based_on
const basedOnFacts = reflection.reflect_response?.based_on
? Object.entries(reflection.reflect_response.based_on).flatMap(([factType, facts]) =>
facts.map((fact) => ({ ...fact, factType }))
)
: [];
// Observations are now in based_on with type=observation
const observations = mentalModel.reflect_response?.based_on?.observation || [];
const mentalModels = reflection.reflect_response?.mental_models || [];
return (
<div className="fixed right-0 top-0 h-screen w-1/2 bg-card border-l shadow-2xl z-50 overflow-y-auto animate-in slide-in-from-right duration-300 ease-out">
@@ -654,7 +647,7 @@ function MentalModelDetailPanel({
size="sm"
variant="outline"
onClick={() => {
setEditName(mentalModel.name);
setEditName(reflection.name);
setIsEditing(false);
}}
>
@@ -665,7 +658,7 @@ function MentalModelDetailPanel({
) : (
<>
<div className="flex items-center gap-2">
<h3 className="text-xl font-bold text-foreground">{mentalModel.name}</h3>
<h3 className="text-xl font-bold text-foreground">{reflection.name}</h3>
<Button
variant="ghost"
size="sm"
@@ -675,7 +668,7 @@ function MentalModelDetailPanel({
<Pencil className="h-3.5 w-3.5" />
</Button>
</div>
<p className="text-sm text-muted-foreground mt-1">{mentalModel.source_query}</p>
<p className="text-sm text-muted-foreground mt-1">{reflection.source_query}</p>
</>
)}
</div>
@@ -706,7 +699,7 @@ function MentalModelDetailPanel({
Content
</div>
<div className="prose prose-base dark:prose-invert max-w-none">
<ReactMarkdown>{mentalModel.content}</ReactMarkdown>
<ReactMarkdown>{reflection.content}</ReactMarkdown>
</div>
</div>
@@ -750,32 +743,32 @@ function MentalModelDetailPanel({
</div>
)}
{/* Observations Used Section */}
{observations.length > 0 && (
{/* Mental Models Used Section */}
{mentalModels.length > 0 && (
<div className="border-t border-border pt-5">
<div className="text-xs font-bold text-muted-foreground uppercase mb-3">
Observations Used ({observations.length})
Mental Models Used ({mentalModels.length})
</div>
<div className="space-y-3">
{observations.map((obs, i) => (
{mentalModels.map((model, i) => (
<div
key={obs.id || i}
key={model.id || i}
className="p-4 bg-muted/50 rounded-lg border border-border/50"
>
<div className="flex items-start justify-between gap-2 mb-2">
<span className="px-2 py-0.5 rounded text-xs font-medium bg-amber-500/10 text-amber-600 dark:text-amber-400">
observation
mental_model
</span>
<Button
variant="outline"
size="sm"
className="h-6 text-xs"
onClick={() => setViewMemoryId(obs.id)}
onClick={() => setViewMemoryId(model.id)}
>
View
</Button>
</div>
<p className="text-sm text-foreground leading-relaxed">{obs.text}</p>
<p className="text-sm text-foreground leading-relaxed">{model.text}</p>
</div>
))}
</div>
@@ -783,7 +776,7 @@ function MentalModelDetailPanel({
)}
{/* No based_on data yet */}
{!mentalModel.reflect_response && (
{!reflection.reflect_response && (
<div className="border-t border-border pt-5">
<div className="text-xs font-bold text-muted-foreground uppercase mb-3">Based On</div>
<p className="text-sm text-muted-foreground">
@@ -793,13 +786,13 @@ function MentalModelDetailPanel({
</div>
)}
{mentalModel.tags && mentalModel.tags.length > 0 && (
{reflection.tags && reflection.tags.length > 0 && (
<div>
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide mb-3">
Tags
</div>
<div className="flex flex-wrap gap-2">
{mentalModel.tags.map((tag) => (
{reflection.tags.map((tag) => (
<span
key={tag}
className="px-2 py-1 rounded bg-muted text-muted-foreground text-sm"
@@ -812,8 +805,8 @@ function MentalModelDetailPanel({
)}
<div className="flex gap-6 text-sm text-muted-foreground">
<span>Created: {formatDateTime(mentalModel.created_at)}</span>
<span>Refreshed: {formatDateTime(mentalModel.last_refreshed_at)}</span>
<span>Created: {formatDateTime(reflection.created_at)}</span>
<span>Refreshed: {formatDateTime(reflection.last_refreshed_at)}</span>
</div>
<div className="p-4 bg-muted/50 rounded-lg">
@@ -821,7 +814,7 @@ function MentalModelDetailPanel({
ID
</div>
<code className="text-sm font-mono break-all text-muted-foreground">
{mentalModel.id}
{reflection.id}
</code>
</div>
@@ -32,7 +32,7 @@ import JsonView from "react18-json-view";
import "react18-json-view/src/style.css";
import { MemoryDetailPanel } from "./memory-detail-panel";
type FactType = "world" | "experience" | "observation";
type FactType = "world" | "experience" | "mental_model";
type Budget = "low" | "mid" | "high";
type TagsMatch = "any" | "all" | "any_strict" | "all_strict";
type ViewMode = "results" | "trace" | "json";
@@ -55,7 +55,7 @@ export function SearchDebugView() {
const [results, setResults] = useState<any[] | null>(null);
const [entities, setEntities] = useState<any[] | null>(null);
const [chunks, setChunks] = useState<any[] | null>(null);
const [observations, setObservations] = useState<any[] | null>(null);
const [mentalModels, setMentalModels] = useState<any[] | null>(null);
const [trace, setTrace] = useState<any | null>(null);
const [loading, setLoading] = useState(false);
const [viewMode, setViewMode] = useState<ViewMode>("results");
@@ -109,7 +109,7 @@ export function SearchDebugView() {
// Must select at least one type
if (factTypes.length === 0) {
alert("Please select at least one type (World, Experience, or Observations)");
alert("Please select at least one type (World, Experience, or Mental Models)");
return;
}
@@ -142,7 +142,7 @@ export function SearchDebugView() {
setResults(data.results || []);
setEntities(data.entities || null);
setChunks(data.chunks || null);
setObservations(data.observations || null);
setMentalModels(data.mental_models || null);
setTrace(data.trace || null);
setViewMode("results");
} catch (error) {
@@ -208,10 +208,10 @@ export function SearchDebugView() {
))}
<label className="flex items-center gap-2 cursor-pointer">
<Checkbox
checked={factTypes.includes("observation")}
onCheckedChange={() => toggleFactType("observation")}
checked={factTypes.includes("mental_model")}
onCheckedChange={() => toggleFactType("mental_model")}
/>
<span className="text-sm">Observations</span>
<span className="text-sm">Mental Models</span>
</label>
</div>
</div>
@@ -360,29 +360,29 @@ export function SearchDebugView() {
{/* Results View */}
{viewMode === "results" && (
<div className="space-y-4">
{/* Observations Section */}
{observations && observations.length > 0 && (
{/* Mental Models Section */}
{mentalModels && mentalModels.length > 0 && (
<Card className="border-orange-500/30 bg-orange-500/5">
<CardHeader className="py-3">
<CardTitle className="text-base flex items-center gap-2">
<Database className="h-4 w-4 text-orange-500" />
<span>Observations</span>
<span className="text-xs text-muted-foreground">({observations.length})</span>
<span>Mental Models</span>
<span className="text-xs text-muted-foreground">({mentalModels.length})</span>
</CardTitle>
</CardHeader>
<CardContent className="pt-0 space-y-2">
{observations.map((obs: any, idx: number) => (
{mentalModels.map((mm: any, idx: number) => (
<div
key={obs.id || idx}
key={mm.id || idx}
className="p-3 bg-background rounded-lg border border-orange-500/20"
>
<p className="text-sm text-foreground">{obs.text}</p>
<p className="text-sm text-foreground">{mm.text}</p>
<div className="flex items-center gap-3 mt-2 text-xs text-muted-foreground">
<span className="px-2 py-0.5 rounded bg-orange-500/10 text-orange-600">
Observation
Mental Model
</span>
<span>Proof count: {obs.proof_count || 1}</span>
<span>Relevance: {(obs.relevance || 0).toFixed(3)}</span>
<span>Proof count: {mm.proof_count || 1}</span>
<span>Relevance: {(mm.relevance || 0).toFixed(3)}</span>
</div>
</div>
))}
@@ -392,7 +392,7 @@ export function SearchDebugView() {
{/* Memories Section */}
<div className="space-y-3">
{results.length === 0 && (!observations || observations.length === 0) ? (
{results.length === 0 && (!mentalModels || mentalModels.length === 0) ? (
<Card>
<CardContent className="flex flex-col items-center justify-center py-12">
<Search className="h-12 w-12 text-muted-foreground mb-4" />
@@ -1010,7 +1010,7 @@ export function SearchDebugView() {
results,
...(entities && { entities }),
...(chunks && { chunks }),
...(observations && { observations }),
...(mentalModels && { mental_models: mentalModels }),
trace,
}}
collapsed={2}
@@ -24,18 +24,14 @@ import {
MessageSquare,
Shield,
X,
Check,
Play,
} from "lucide-react";
import { Textarea } from "@/components/ui/textarea";
import JsonView from "react18-json-view";
import "react18-json-view/src/style.css";
import { MemoryDetailModal } from "./memory-detail-modal";
import { MentalModelDetailModal } from "./mental-model-detail-modal";
import { MemoryDetailPanel } from "./memory-detail-panel";
type TagsMatch = "any" | "all" | "any_strict" | "all_strict";
type ViewMode = "answer" | "trace" | "json";
type BasedOnTab = "directives" | "mental_models" | "observations" | "world" | "experience";
export function ThinkView() {
const { currentBank } = useBank();
@@ -52,15 +48,13 @@ export function ThinkView() {
const [feedback, setFeedback] = useState("");
const [feedbackSubmitting, setFeedbackSubmitting] = useState(false);
const [feedbackSubmitted, setFeedbackSubmitted] = useState(false);
const [selectedMemoryId, setSelectedMemoryId] = useState<string | null>(null);
const [selectedMemory, setSelectedMemory] = useState<any | null>(null);
const [selectedDirective, setSelectedDirective] = useState<any | null>(null);
const [fullDirective, setFullDirective] = useState<any | null>(null);
const [loadingDirective, setLoadingDirective] = useState(false);
const [selectedObservation, setSelectedObservation] = useState<any | null>(null);
const [fullObservation, setFullObservation] = useState<any | null>(null);
const [loadingObservation, setLoadingObservation] = useState(false);
const [selectedMentalModelId, setSelectedMentalModelId] = useState<string | null>(null);
const [activeBasedOnTab, setActiveBasedOnTab] = useState<BasedOnTab>("world");
const [selectedMentalModel, setSelectedMentalModel] = useState<any | null>(null);
const [fullMentalModel, setFullMentalModel] = useState<any | null>(null);
const [loadingMentalModel, setLoadingMentalModel] = useState(false);
const FEEDBACK_DIRECTIVE_NAME = "General Feedback";
@@ -83,22 +77,22 @@ export function ThinkView() {
}
};
// Load full observation data when one is selected
const handleSelectObservation = async (observation: any) => {
setSelectedObservation(observation);
setFullObservation(null);
if (!currentBank || !observation?.id) return;
// Load full mental model data when one is selected
const handleSelectMentalModel = async (model: any) => {
setSelectedMentalModel(model);
setFullMentalModel(null);
if (!currentBank || !model?.id) return;
setLoadingObservation(true);
setLoadingMentalModel(true);
try {
const observations = await client.listObservations(currentBank);
const fullObs = observations.items?.find((o: any) => o.id === observation.id);
setFullObservation(fullObs || observation);
const models = await client.listMentalModels(currentBank);
const fullModel = models.items?.find((m: any) => m.id === model.id);
setFullMentalModel(fullModel || model);
} catch (error) {
console.error("Failed to load observation:", error);
setFullObservation(observation); // Fall back to partial data
console.error("Failed to load mental model:", error);
setFullMentalModel(model); // Fall back to partial data
} finally {
setLoadingObservation(false);
setLoadingMentalModel(false);
}
};
@@ -393,15 +387,15 @@ export function ThinkView() {
</Card>
)}
{/* Directive */}
{/* Feedback */}
<Card className="border-blue-200 dark:border-blue-800">
<CardHeader className="py-4">
<CardTitle className="flex items-center gap-2 text-base">
<MessageSquare className="w-4 h-4" />
Add Directive
Provide Feedback
</CardTitle>
<CardDescription className="text-xs">
Hard rules injected into prompts that the agent must follow
Your feedback will be saved as a directive to improve future responses
</CardDescription>
</CardHeader>
<CardContent className="pt-0">
@@ -409,7 +403,7 @@ export function ThinkView() {
<div className="flex items-center gap-2 text-green-600 dark:text-green-400">
<span className="text-lg">&#10003;</span>
<span className="text-sm font-medium">
Directive saved to {FEEDBACK_DIRECTIVE_NAME}
Feedback saved to {FEEDBACK_DIRECTIVE_NAME}
</span>
</div>
) : (
@@ -417,7 +411,7 @@ export function ThinkView() {
<Textarea
value={feedback}
onChange={(e) => setFeedback(e.target.value)}
placeholder="e.g., Always respond in formal English..."
placeholder="Enter your feedback here..."
className="flex-1 min-h-[60px] resize-none"
onKeyDown={(e) => {
if (e.key === "Enter" && (e.metaKey || e.ctrlKey)) {
@@ -442,33 +436,33 @@ export function ThinkView() {
{/* Trace View - Split Layout */}
{viewMode === "trace" && (
<div className="space-y-4">
{/* Observations Created */}
{result.observations_created && result.observations_created.length > 0 && (
{/* Mental Models Created */}
{result.mental_models_created && result.mental_models_created.length > 0 && (
<Card className="border-emerald-200 dark:border-emerald-800">
<CardHeader className="bg-emerald-50 dark:bg-emerald-950 py-3">
<CardTitle className="flex items-center gap-2 text-base">
<Brain className="w-4 h-4 text-emerald-600" />
Observations Created ({result.observations_created.length})
Mental Models Created ({result.mental_models_created.length})
</CardTitle>
<CardDescription className="text-xs">
New observations learned during this reflection
New mental models learned during this reflection
</CardDescription>
</CardHeader>
<CardContent className="pt-4">
<div className="space-y-2">
{result.observations_created.map((obs: any, i: number) => (
{result.mental_models_created.map((model: any, i: number) => (
<div
key={i}
className="p-3 bg-emerald-50 dark:bg-emerald-950/50 rounded-lg border border-emerald-200 dark:border-emerald-800"
>
<div className="font-medium text-sm text-emerald-900 dark:text-emerald-100">
{obs.name}
{model.name}
</div>
<div className="text-xs text-emerald-700 dark:text-emerald-300 mt-1">
{obs.description}
{model.description}
</div>
<div className="text-[10px] text-muted-foreground mt-2 font-mono">
ID: {obs.id}
ID: {model.id}
</div>
</div>
))}
@@ -509,7 +503,7 @@ export function ThinkView() {
</div>
) : (result.trace?.llm_calls && result.trace.llm_calls.length > 0) ||
(result.trace?.tool_calls && result.trace.tool_calls.length > 0) ? (
<div className="max-h-[500px] overflow-y-auto pr-2">
<div className="max-h-[500px] overflow-y-auto">
{/* Build timeline: LLM -> Tools -> LLM -> Tools */}
{(() => {
const llmCalls = result.trace?.llm_calls || [];
@@ -566,19 +560,13 @@ export function ThinkView() {
// LLM Call
<div className="flex items-start gap-3 pb-3">
<div
className={`w-6 h-6 rounded-full flex items-center justify-center flex-shrink-0 ${
className={`w-6 h-6 rounded-full flex items-center justify-center text-[10px] font-bold flex-shrink-0 ${
item.isFinal
? "bg-emerald-500/15 text-emerald-600 dark:text-emerald-400"
: "bg-primary/10 text-primary"
? "bg-emerald-100 dark:bg-emerald-900 text-emerald-700 dark:text-emerald-300"
: "bg-violet-100 dark:bg-violet-900 text-violet-700 dark:text-violet-300"
}`}
>
{item.isFinal ? (
<Check className="w-3.5 h-3.5" strokeWidth={2.5} />
) : (
<span className="text-[10px] font-semibold">
{item.iteration}
</span>
)}
{item.isFinal ? "✓" : item.iteration}
</div>
<div className="flex-1 min-w-0">
<div className="flex items-center justify-between">
@@ -598,8 +586,8 @@ export function ThinkView() {
) : (
// Tool Calls
<div className="flex items-start gap-3 pb-3">
<div className="w-6 h-6 rounded-full flex items-center justify-center bg-blue-500/15 text-blue-600 dark:text-blue-400 flex-shrink-0">
<Play className="w-3 h-3" fill="currentColor" />
<div className="w-6 h-6 rounded-full flex items-center justify-center text-[10px] bg-blue-100 dark:bg-blue-900 text-blue-700 dark:text-blue-300 flex-shrink-0">
</div>
<div className="flex-1 min-w-0 space-y-2">
<div className="text-xs text-muted-foreground">
@@ -677,10 +665,11 @@ export function ThinkView() {
<CardTitle className="text-base">Based On</CardTitle>
<CardDescription className="text-xs">
{(result.based_on?.memories?.length || 0) +
(result.based_on?.observations?.filter(
(o: any) => o.subtype !== "directive"
(result.based_on?.mental_models?.filter(
(m: any) => m.subtype !== "directive"
)?.length || 0) +
(result.based_on?.directives?.length || 0)}{" "}
(result.trace?.mental_models?.filter((m: any) => m.subtype === "directive")
?.length || 0)}{" "}
items used
</CardDescription>
</CardHeader>
@@ -697,144 +686,164 @@ export function ThinkView() {
</div>
) : (result.based_on?.memories && result.based_on.memories.length > 0) ||
(result.based_on?.mental_models &&
result.based_on.mental_models.length > 0) ||
(result.based_on?.directives && result.based_on.directives.length > 0) ||
(result.based_on?.observations && result.based_on.observations.length > 0) ? (
(() => {
const memories = result.based_on?.memories || [];
const worldFacts = memories.filter((f: any) => f.type === "world");
const experienceFacts = memories.filter(
(f: any) => f.type === "experience"
);
// Mental models are in based_on.mental_models
const mentalModelFacts = result.based_on?.mental_models || [];
const observations = (result.based_on?.observations || []).filter(
(o: any) => o.subtype !== "directive"
);
// Directives are in based_on.directives
const directives = result.based_on?.directives || [];
result.based_on.mental_models.length > 0) ? (
<div className="space-y-4 max-h-[500px] overflow-y-auto">
{(() => {
const memories = result.based_on?.memories || [];
const worldFacts = memories.filter((f: any) => f.type === "world");
const experienceFacts = memories.filter(
(f: any) => f.type === "experience"
);
const opinionFacts = memories.filter((f: any) => f.type === "opinion");
const mentalModels = (result.based_on?.mental_models || []).filter(
(m: any) => m.subtype !== "directive"
);
const directives =
result.trace?.mental_models?.filter(
(m: any) => m.subtype === "directive"
) || [];
// Build tabs array with all categories
const tabs: { id: BasedOnTab; label: string; count: number }[] = [
{ id: "directives", label: "Directives", count: directives.length },
{
id: "mental_models",
label: "Mental Models",
count: mentalModelFacts.length,
},
{ id: "observations", label: "Observations", count: observations.length },
{ id: "world", label: "World", count: worldFacts.length },
{ id: "experience", label: "Experience", count: experienceFacts.length },
];
return (
<>
{/* Directives */}
{directives.length > 0 && (
<div className="space-y-1.5">
<div className="flex items-center gap-2 text-xs font-semibold text-foreground">
<Shield className="w-3 h-3" />
Directives ({directives.length})
</div>
<div className="space-y-1.5">
{directives.map((directive: any, i: number) => (
<div
key={i}
className="p-2 bg-muted rounded text-xs cursor-pointer hover:bg-muted/80 transition-colors"
onClick={() => handleSelectDirective(directive)}
>
<div className="font-medium">{directive.name}</div>
{directive.observations &&
directive.observations.length > 0 && (
<ul className="mt-1 space-y-0.5">
{directive.observations.map(
(obs: string, j: number) => (
<li
key={j}
className="text-[10px] text-muted-foreground flex items-start gap-1"
>
<span></span>
<span>{obs}</span>
</li>
)
)}
</ul>
)}
</div>
))}
</div>
</div>
)}
const currentTab = activeBasedOnTab;
{/* Mental Models */}
{mentalModels.length > 0 && (
<div className="space-y-1.5">
<div className="flex items-center gap-2 text-xs font-semibold text-orange-600 dark:text-orange-400">
<div className="w-2 h-2 rounded-full bg-orange-500" />
Mental Models ({mentalModels.length})
</div>
<div className="space-y-1.5">
{mentalModels.map((model: any, i: number) => (
<div
key={i}
className="p-2 bg-muted rounded text-xs cursor-pointer hover:bg-muted/80 transition-colors"
onClick={() => handleSelectMentalModel(model)}
>
<div className="font-medium">{model.name}</div>
</div>
))}
</div>
</div>
)}
const getCurrentFacts = () => {
switch (currentTab) {
case "directives":
return directives;
case "mental_models":
return mentalModelFacts;
case "observations":
return observations;
case "world":
return worldFacts;
case "experience":
return experienceFacts;
default:
return [];
}
};
const currentFacts = getCurrentFacts();
return (
<div>
{/* Tabs */}
<div className="flex items-center gap-1 bg-muted rounded-lg p-1 mb-4">
{tabs.map((tab) => (
<button
key={tab.id}
onClick={() => setActiveBasedOnTab(tab.id)}
className={`flex-1 px-3 py-1.5 rounded-md text-sm font-medium transition-all ${
currentTab === tab.id
? "bg-background text-foreground shadow-sm"
: "text-muted-foreground hover:text-foreground"
}`}
>
{tab.label} ({tab.count})
</button>
))}
</div>
{/* Tab Content */}
{currentFacts.length > 0 ? (
<div className="max-h-[400px] overflow-y-auto pr-2 space-y-3">
{currentFacts.map((item: any, i: number) => (
<div
key={item.id || i}
className={`p-4 bg-muted/50 rounded-lg border border-border/50 ${
currentTab !== "directives"
? "cursor-pointer hover:bg-muted/80 transition-colors"
: ""
}`}
onClick={() => {
if (currentTab === "directives") return; // Not clickable
if (currentTab === "observations")
handleSelectObservation(item);
else if (currentTab === "mental_models")
setSelectedMentalModelId(item.id);
else setSelectedMemoryId(item.id);
}}
>
{currentTab === "directives" ? (
<>
<div className="font-medium text-sm">{item.name}</div>
{item.content && (
<p className="mt-1 text-xs text-muted-foreground line-clamp-2">
{item.content}
</p>
)}
</>
) : currentTab === "observations" ? (
<div className="font-medium text-sm">{item.name}</div>
) : currentTab === "mental_models" ? (
(() => {
const colonIdx = item.text?.indexOf(": ") ?? -1;
const name =
colonIdx > 0 ? item.text.slice(0, colonIdx) : item.id;
return (
<>
<div className="font-medium text-sm">{name}</div>
<code className="text-xs font-mono text-muted-foreground">
{item.id}
</code>
</>
);
})()
) : (
<>
<p className="text-sm text-foreground leading-relaxed">
{item.text}
</p>
{item.context && (
<div className="text-xs text-muted-foreground mt-2">
{item.context}
{/* World Facts */}
{worldFacts.length > 0 && (
<div className="space-y-1.5">
<div className="flex items-center gap-2 text-xs font-semibold text-blue-600 dark:text-blue-400">
<div className="w-2 h-2 rounded-full bg-blue-500" />
World ({worldFacts.length})
</div>
<div className="space-y-1.5">
{worldFacts.map((fact: any, i: number) => (
<div
key={i}
className="p-2 bg-muted rounded text-xs cursor-pointer hover:bg-muted/80 transition-colors"
onClick={() => setSelectedMemory(fact)}
>
{fact.text}
{fact.context && (
<div className="text-[10px] text-muted-foreground mt-1">
{fact.context}
</div>
)}
</>
)}
</div>
))}
</div>
))}
</div>
) : (
<p className="text-sm text-muted-foreground text-center py-4">
No {currentTab} items
</p>
)}
</div>
);
})()
</div>
)}
{/* Experience Facts */}
{experienceFacts.length > 0 && (
<div className="space-y-1.5">
<div className="flex items-center gap-2 text-xs font-semibold text-green-600 dark:text-green-400">
<div className="w-2 h-2 rounded-full bg-green-500" />
Experience ({experienceFacts.length})
</div>
<div className="space-y-1.5">
{experienceFacts.map((fact: any, i: number) => (
<div
key={i}
className="p-2 bg-muted rounded text-xs cursor-pointer hover:bg-muted/80 transition-colors"
onClick={() => setSelectedMemory(fact)}
>
{fact.text}
{fact.context && (
<div className="text-[10px] text-muted-foreground mt-1">
{fact.context}
</div>
)}
</div>
))}
</div>
</div>
)}
{/* Opinion Facts */}
{opinionFacts.length > 0 && (
<div className="space-y-1.5">
<div className="flex items-center gap-2 text-xs font-semibold text-purple-600 dark:text-purple-400">
<div className="w-2 h-2 rounded-full bg-purple-500" />
Opinions ({opinionFacts.length})
</div>
<div className="space-y-1.5">
{opinionFacts.map((fact: any, i: number) => (
<div
key={i}
className="p-2 bg-muted rounded text-xs cursor-pointer hover:bg-muted/80 transition-colors"
onClick={() => setSelectedMemory(fact)}
>
{fact.text}
{fact.context && (
<div className="text-[10px] text-muted-foreground mt-1">
{fact.context}
</div>
)}
</div>
))}
</div>
</div>
)}
</>
);
})()}
</div>
) : (
<div className="flex items-start gap-3 p-3 bg-amber-50 dark:bg-amber-950 border border-amber-200 dark:border-amber-800 rounded-lg">
<Info className="w-4 h-4 text-amber-600 dark:text-amber-400 mt-0.5 flex-shrink-0" />
@@ -884,8 +893,17 @@ export function ThinkView() {
</Card>
)}
{/* Memory Detail Modal */}
<MemoryDetailModal memoryId={selectedMemoryId} onClose={() => setSelectedMemoryId(null)} />
{/* Memory Detail Panel */}
{selectedMemory && (
<div className="fixed right-0 top-0 h-screen w-[420px] bg-card border-l shadow-2xl z-50 overflow-y-auto">
<MemoryDetailPanel
memory={selectedMemory}
onClose={() => setSelectedMemory(null)}
inPanel
bankId={currentBank || undefined}
/>
</div>
)}
{/* Directive Detail Panel */}
{selectedDirective && (
@@ -941,14 +959,31 @@ export function ThinkView() {
</div>
</div>
)}
{/* Show content from directive */}
{(fullDirective?.content || selectedDirective.content) && (
{(fullDirective?.observations || selectedDirective.observations) && (
<div>
<h3 className="text-sm font-medium text-muted-foreground mb-2">Content</h3>
<div className="p-3 bg-muted rounded-lg">
<div className="text-sm text-muted-foreground whitespace-pre-wrap">
{fullDirective?.content || selectedDirective.content}
</div>
<h3 className="text-sm font-medium text-muted-foreground mb-2">
Observations (
{(fullDirective?.observations || selectedDirective.observations)?.length || 0}
)
</h3>
<div className="space-y-2">
{(fullDirective?.observations || selectedDirective.observations)?.map(
(obs: any, i: number) => (
<div key={i} className="p-3 bg-muted rounded-lg">
{obs.title && (
<div className="font-medium text-sm mb-1">{obs.title}</div>
)}
<div className="text-sm text-muted-foreground whitespace-pre-wrap">
{obs.content || obs.text || (typeof obs === "string" ? obs : "")}
</div>
{obs.memory_ids && obs.memory_ids.length > 0 && (
<div className="mt-2 text-xs text-muted-foreground">
Based on {obs.memory_ids.length} memories
</div>
)}
</div>
)
)}
</div>
</div>
)}
@@ -964,43 +999,73 @@ export function ThinkView() {
</div>
)}
{/* Observation Detail Panel */}
{selectedObservation && (
{/* Mental Model Detail Panel */}
{selectedMentalModel && (
<div className="fixed right-0 top-0 h-screen w-[420px] bg-card border-l shadow-2xl z-50 overflow-y-auto">
<div className="p-6">
<div className="flex items-center justify-between mb-6">
<div className="flex items-center gap-2">
<Brain className="w-5 h-5" />
<h2 className="text-lg font-semibold">Observation</h2>
<h2 className="text-lg font-semibold">Mental Model</h2>
</div>
<Button
variant="ghost"
size="icon"
onClick={() => {
setSelectedObservation(null);
setFullObservation(null);
setSelectedMentalModel(null);
setFullMentalModel(null);
}}
>
<X className="w-4 h-4" />
</Button>
</div>
{loadingObservation ? (
{loadingMentalModel ? (
<div className="flex items-center justify-center py-8">
<div className="animate-spin rounded-full h-8 w-8 border-b-2 border-primary"></div>
</div>
) : (
<div className="space-y-4">
<div>
<h3 className="text-sm font-medium text-muted-foreground">Text</h3>
<h3 className="text-sm font-medium text-muted-foreground">Name</h3>
<p className="mt-1 font-medium">
{fullObservation?.text || selectedObservation.text}
{fullMentalModel?.name || selectedMentalModel.name}
</p>
</div>
{fullObservation?.tags && fullObservation.tags.length > 0 && (
{fullMentalModel?.description && (
<div>
<h3 className="text-sm font-medium text-muted-foreground">Description</h3>
<p className="mt-1 text-sm">{fullMentalModel.description}</p>
</div>
)}
<div className="flex gap-4">
<div>
<h3 className="text-sm font-medium text-muted-foreground">Type</h3>
<p className="mt-1 text-sm">{selectedMentalModel.type}</p>
</div>
<div>
<h3 className="text-sm font-medium text-muted-foreground">Subtype</h3>
<span
className={`inline-block mt-1 text-xs px-2 py-0.5 rounded ${
selectedMentalModel.subtype === "structural"
? "bg-blue-500/10 text-blue-600"
: selectedMentalModel.subtype === "emergent"
? "bg-emerald-500/10 text-emerald-600"
: selectedMentalModel.subtype === "learned"
? "bg-violet-500/10 text-violet-600"
: selectedMentalModel.subtype === "directive"
? "bg-rose-500/10 text-rose-600"
: "bg-muted"
}`}
>
{selectedMentalModel.subtype}
</span>
</div>
</div>
{fullMentalModel?.tags && fullMentalModel.tags.length > 0 && (
<div>
<h3 className="text-sm font-medium text-muted-foreground mb-1">Tags</h3>
<div className="flex flex-wrap gap-1">
{fullObservation.tags.map((tag: string) => (
{fullMentalModel.tags.map((tag: string) => (
<span
key={tag}
className="text-xs px-2 py-0.5 rounded bg-muted text-muted-foreground flex items-center gap-1"
@@ -1012,17 +1077,23 @@ export function ThinkView() {
</div>
</div>
)}
{fullObservation?.source_memories && fullObservation.source_memories.length > 0 && (
{fullMentalModel?.observations && fullMentalModel.observations.length > 0 && (
<div>
<h3 className="text-sm font-medium text-muted-foreground mb-2">
Source Memories ({fullObservation.source_memories.length})
Observations ({fullMentalModel.observations.length})
</h3>
<div className="space-y-2">
{fullObservation.source_memories.map((mem: any, i: number) => (
{fullMentalModel.observations.map((obs: any, i: number) => (
<div key={i} className="p-3 bg-muted rounded-lg">
{obs.title && <div className="font-medium text-sm mb-1">{obs.title}</div>}
<div className="text-sm text-muted-foreground whitespace-pre-wrap">
{mem.text || (typeof mem === "string" ? mem : "")}
{obs.content || obs.text || (typeof obs === "string" ? obs : "")}
</div>
{obs.memory_ids && obs.memory_ids.length > 0 && (
<div className="mt-2 text-xs text-muted-foreground">
Based on {obs.memory_ids.length} memories
</div>
)}
</div>
))}
</div>
@@ -1031,7 +1102,7 @@ export function ThinkView() {
<div className="pt-2 border-t">
<h3 className="text-sm font-medium text-muted-foreground">ID</h3>
<p className="mt-1 font-mono text-xs text-muted-foreground">
{selectedObservation.id}
{selectedMentalModel.id}
</p>
</div>
</div>
@@ -1039,12 +1110,6 @@ export function ThinkView() {
</div>
</div>
)}
{/* Mental Model Detail Modal */}
<MentalModelDetailModal
mentalModelId={selectedMentalModelId}
onClose={() => setSelectedMentalModelId(null)}
/>
</div>
);
}
+48 -55
View File
@@ -3,20 +3,6 @@
* This should be used in client components, not the SDK directly
*/
export interface MentalModel {
id: string;
bank_id: string;
name: string;
source_query: string;
content: string;
tags: string[];
max_tokens: number;
trigger: { refresh_after_consolidation: boolean };
last_refreshed_at: string;
created_at: string;
reflect_response?: any;
}
export class ControlPlaneClient {
private async fetchApi<T>(path: string, options?: RequestInit): Promise<T> {
const response = await fetch(path, {
@@ -65,7 +51,7 @@ export class ControlPlaneClient {
include?: {
entities?: { max_tokens: number } | null;
chunks?: { max_tokens: number } | null;
observations?: { max_results?: number } | null;
mental_models?: { max_results?: number } | null;
};
query_timestamp?: string;
tags?: string[];
@@ -258,14 +244,14 @@ export class ControlPlaneClient {
}
/**
* Clear all observations for a bank
* Clear all mental models for a bank
*/
async clearObservations(bankId: string) {
async clearMentalModels(bankId: string) {
return this.fetchApi<{
success: boolean;
message: string;
deleted_count: number;
}>(`/api/banks/${bankId}/observations`, {
}>(`/api/banks/${bankId}/mental-models`, {
method: "DELETE",
});
}
@@ -484,12 +470,12 @@ export class ControlPlaneClient {
});
}
// ============= OBSERVATIONS (auto-consolidated, read-only) =============
// ============= MENTAL MODELS (auto-consolidated, read-only) =============
/**
* List observations for a bank (auto-consolidated knowledge)
* List mental models for a bank (auto-consolidated knowledge)
*/
async listObservations(bankId: string, tags?: string[], tagsMatch?: string) {
async listMentalModels(bankId: string, tags?: string[], tagsMatch?: string) {
const params = new URLSearchParams();
if (tags && tags.length > 0) {
tags.forEach((t) => params.append("tags", t));
@@ -522,13 +508,13 @@ export class ControlPlaneClient {
created_at: string;
updated_at: string;
}>;
}>(`/api/banks/${bankId}/observations${query ? `?${query}` : ""}`);
}>(`/api/banks/${bankId}/mental-models${query ? `?${query}` : ""}`);
}
/**
* Get an observation with source memories
* Get a mental model with source memories
*/
async getObservation(bankId: string, observationId: string) {
async getMentalModel(bankId: string, modelId: string) {
return this.fetchApi<{
id: string;
bank_id: string;
@@ -551,15 +537,15 @@ export class ControlPlaneClient {
}>;
created_at: string;
updated_at: string;
}>(`/api/banks/${bankId}/observations/${observationId}`);
}>(`/api/banks/${bankId}/mental-models/${modelId}`);
}
// ============= MENTAL MODELS (stored reflect responses) =============
// ============= REFLECTIONS =============
/**
* List mental models for a bank
* List reflections for a bank
*/
async listMentalModels(bankId: string, tags?: string[], tagsMatch?: string) {
async listReflections(bankId: string, tags?: string[], tagsMatch?: string) {
const params = new URLSearchParams();
if (tags && tags.length > 0) {
tags.forEach((t) => params.append("tags", t));
@@ -576,59 +562,67 @@ export class ControlPlaneClient {
source_query: string;
content: string;
tags: string[];
max_tokens: number;
trigger: { refresh_after_consolidation: boolean };
last_refreshed_at: string;
created_at: string;
reflect_response?: {
text: string;
based_on: Record<string, Array<{ id: string; text: string; type: string }>>;
mental_models?: Array<{ id: string; text: string }>;
};
}>;
}>(`/api/banks/${bankId}/mental-models${query ? `?${query}` : ""}`);
}>(`/api/banks/${bankId}/reflections${query ? `?${query}` : ""}`);
}
/**
* Create a mental model (async - content auto-generated in background)
* Create a reflection (async - content auto-generated in background)
* Returns operation_id to track progress
*/
async createMentalModel(
async createReflection(
bankId: string,
params: {
name: string;
source_query: string;
tags?: string[];
max_tokens?: number;
trigger?: { refresh_after_consolidation: boolean };
}
) {
return this.fetchApi<{
operation_id: string;
}>(`/api/banks/${bankId}/mental-models`, {
}>(`/api/banks/${bankId}/reflections`, {
method: "POST",
body: JSON.stringify(params),
});
}
/**
* Get a mental model
* Get a reflection
*/
async getMentalModel(bankId: string, mentalModelId: string): Promise<MentalModel> {
return this.fetchApi<MentalModel>(`/api/banks/${bankId}/mental-models/${mentalModelId}`);
async getReflection(bankId: string, reflectionId: string) {
return this.fetchApi<{
id: string;
bank_id: string;
name: string;
source_query: string;
content: string;
tags: string[];
last_refreshed_at: string;
created_at: string;
reflect_response?: {
text: string;
based_on: Record<string, Array<{ id: string; text: string; type: string }>>;
mental_models?: Array<{ id: string; text: string }>;
};
}>(`/api/banks/${bankId}/reflections/${reflectionId}`);
}
/**
* Update a mental model
* Update a reflection
*/
async updateMentalModel(
async updateReflection(
bankId: string,
mentalModelId: string,
reflectionId: string,
params: {
name?: string;
source_query?: string;
max_tokens?: number;
tags?: string[];
trigger?: { refresh_after_consolidation: boolean };
}
) {
return this.fetchApi<{
@@ -638,36 +632,35 @@ export class ControlPlaneClient {
source_query: string;
content: string;
tags: string[];
max_tokens: number;
trigger: { refresh_after_consolidation: boolean };
last_refreshed_at: string;
created_at: string;
reflect_response?: {
text: string;
based_on: Record<string, Array<{ id: string; text: string; type: string }>>;
mental_models?: Array<{ id: string; text: string }>;
};
}>(`/api/banks/${bankId}/mental-models/${mentalModelId}`, {
}>(`/api/banks/${bankId}/reflections/${reflectionId}`, {
method: "PATCH",
body: JSON.stringify(params),
});
}
/**
* Delete a mental model
* Delete a reflection
*/
async deleteMentalModel(bankId: string, mentalModelId: string) {
return this.fetchApi(`/api/banks/${bankId}/mental-models/${mentalModelId}`, {
async deleteReflection(bankId: string, reflectionId: string) {
return this.fetchApi(`/api/banks/${bankId}/reflections/${reflectionId}`, {
method: "DELETE",
});
}
/**
* Refresh a mental model (re-run source query) - async operation
* Refresh a reflection (re-run source query) - async operation
*/
async refreshMentalModel(bankId: string, mentalModelId: string) {
async refreshReflection(bankId: string, reflectionId: string) {
return this.fetchApi<{
operation_id: string;
}>(`/api/banks/${bankId}/mental-models/${mentalModelId}/refresh`, {
}>(`/api/banks/${bankId}/reflections/${reflectionId}/refresh`, {
method: "POST",
});
}
@@ -680,7 +673,7 @@ export class ControlPlaneClient {
return this.fetchApi<{
api_version: string;
features: {
observations: boolean;
mental_models: boolean;
mcp: boolean;
worker: boolean;
};
@@ -4,7 +4,7 @@ import React, { createContext, useContext, useState, useEffect } from "react";
import { client } from "./api";
interface Features {
observations: boolean;
mental_models: boolean;
mcp: boolean;
worker: boolean;
}
@@ -16,7 +16,7 @@ interface FeaturesContextType {
}
const defaultFeatures: Features = {
observations: false,
mental_models: false,
mcp: false,
worker: false,
};
@@ -15,6 +15,8 @@ The framework supports two answer generation patterns:
2. Integrated: Answer generator performs its own retrieval (e.g., think API)
- Indicated by needs_external_search() returning False
- Skips the search step for efficiency
Optional --include-mental-models flag enables returning mental models in recall results.
"""
import asyncio
@@ -534,6 +536,8 @@ class BenchmarkRunner:
max_tokens: int = 4096,
question_date: Optional[datetime] = None,
question_type: Optional[str] = None,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> Tuple[str, str, List[Dict], Dict[str, Dict]]:
"""
Answer a question using memory retrieval.
@@ -545,6 +549,8 @@ class BenchmarkRunner:
max_tokens: Maximum tokens to retrieve
question_date: Date when the question was asked (for temporal filtering)
question_type: Question category/type (e.g., 'multi-session', 'temporal-reasoning')
include_mental_models: If True, include mental models in recall results
only_mental_models: If True, only retrieve mental models (no facts)
Returns:
Tuple of (answer, reasoning, retrieved_memories, chunks)
@@ -559,16 +565,26 @@ class BenchmarkRunner:
import time
recall_start_time = time.time()
# Use default fact types (no filtering)
# Build fact_types based on what's requested
if only_mental_models:
# Only retrieve mental models
fact_types = ["mental_model"]
elif include_mental_models:
# Retrieve facts AND mental models
fact_types = ["world", "experience", "mental_model"]
else:
# Only retrieve facts
fact_types = ["world", "experience"]
search_result = await self.memory.recall_async(
bank_id=agent_id,
query=question,
budget=budget,
max_tokens=max_tokens,
fact_type=fact_types,
question_date=question_date,
include_entities=True,
include_entities=not only_mental_models, # Skip entities when only mental models
max_entity_tokens=2048,
include_chunks=True,
include_chunks=True, # Always include chunks (mental models fetch from source memories)
request_context=RequestContext(),
)
recall_time = time.time() - recall_start_time
@@ -625,12 +641,16 @@ class BenchmarkRunner:
max_tokens: int,
max_questions: Optional[int] = None,
semaphore: asyncio.Semaphore = None,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> List[Dict]:
"""
Evaluate QA task with parallel question processing.
Args:
semaphore: Semaphore to limit concurrent question processing
include_mental_models: If True, include mental models in recall results
only_mental_models: If True, only retrieve mental models (no facts)
Returns:
List of QA results
@@ -675,6 +695,8 @@ class BenchmarkRunner:
max_tokens,
question_date,
category,
include_mental_models,
only_mental_models,
)
# Remove embeddings from retrieved memories to reduce file size
@@ -853,6 +875,8 @@ class BenchmarkRunner:
question_semaphore: asyncio.Semaphore,
eval_semaphore_size: int = 8,
clear_this_agent: bool = True,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> Dict:
"""
Process a single item (ingest + evaluate).
@@ -860,6 +884,8 @@ class BenchmarkRunner:
Args:
clear_this_agent: Whether to clear this agent's data before ingesting.
Set to False to skip clearing (e.g., when agent_id is shared and already cleared)
include_mental_models: If True, include mental models in recall results and wait for consolidation after ingestion
only_mental_models: If True, only retrieve mental models (no facts)
Returns:
Result dict with metrics
@@ -876,10 +902,11 @@ class BenchmarkRunner:
await self.memory.delete_bank(agent_id, request_context=RequestContext())
console.print(f" [green]✓[/green] Cleared '{agent_id}' agent data")
# Ingest conversation
# Ingest conversation (wait for consolidation if mental models are requested)
step += 1
console.print(f" [{step}] Ingesting conversation (batch mode)...")
num_sessions = await self.ingest_conversation(item, agent_id, wait_for_consolidation=False)
wait_for_consolidation = include_mental_models or only_mental_models
num_sessions = await self.ingest_conversation(item, agent_id, wait_for_consolidation=wait_for_consolidation)
console.print(f" [green]✓[/green] Ingested {num_sessions} sessions")
else:
num_sessions = -1
@@ -896,6 +923,8 @@ class BenchmarkRunner:
max_tokens,
max_questions_per_item,
question_semaphore,
include_mental_models,
only_mental_models,
)
# Calculate metrics
@@ -927,6 +956,8 @@ class BenchmarkRunner:
max_concurrent_items: int = 1, # Max concurrent items (conversations) to process in parallel
output_path: Optional[Path] = None, # Path to save results incrementally
merge_with_existing: bool = False, # Whether to merge with existing results
include_mental_models: bool = False, # If True, include mental models in recall results
only_mental_models: bool = False, # If True, only retrieve mental models (no facts)
) -> Dict[str, Any]:
"""
Run the full benchmark evaluation.
@@ -946,6 +977,8 @@ class BenchmarkRunner:
separate_ingestion_phase: If True, ingest all data first, then evaluate all questions (single agent)
filln: If True, only process items where the agent has no indexed data yet
max_concurrent_items: Max concurrent items to process in parallel (requires clear_agent_per_item=True)
include_mental_models: If True, include mental models in recall results and wait for consolidation after ingestion.
only_mental_models: If True, only retrieve mental models (no facts). Implies waiting for consolidation.
Returns:
Dict with complete benchmark results
@@ -987,6 +1020,8 @@ class BenchmarkRunner:
eval_semaphore_size,
output_path,
merge_with_existing,
include_mental_models,
only_mental_models,
)
else:
# Original approach: process each item independently
@@ -1004,6 +1039,8 @@ class BenchmarkRunner:
max_concurrent_items,
output_path,
merge_with_existing,
include_mental_models,
only_mental_models,
)
async def _run_single_phase(
@@ -1021,6 +1058,8 @@ class BenchmarkRunner:
max_concurrent_items: int = 1,
output_path: Optional[Path] = None,
merge_with_existing: bool = False,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> Dict[str, Any]:
"""Original single-phase approach: process each item independently."""
# Create semaphore for question processing
@@ -1042,6 +1081,8 @@ class BenchmarkRunner:
max_concurrent_items,
output_path,
merge_with_existing,
include_mental_models,
only_mental_models,
)
else:
# Sequential item processing (original behavior)
@@ -1058,6 +1099,8 @@ class BenchmarkRunner:
filln,
output_path,
merge_with_existing,
include_mental_models,
only_mental_models,
)
# Calculate overall metrics
@@ -1093,6 +1136,8 @@ class BenchmarkRunner:
filln: bool,
output_path: Optional[Path] = None,
merge_with_existing: bool = False,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> List[Dict]:
"""Process items sequentially (original behavior)."""
all_results = []
@@ -1140,6 +1185,8 @@ class BenchmarkRunner:
question_semaphore,
eval_semaphore_size,
clear_this_agent,
include_mental_models,
only_mental_models,
)
# Replace existing result or append new one
@@ -1171,6 +1218,8 @@ class BenchmarkRunner:
max_concurrent_items: int,
output_path: Optional[Path] = None,
merge_with_existing: bool = False,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> List[Dict]:
"""Process items in parallel (requires unique agent IDs per item)."""
# Load existing results if merge_with_existing is True
@@ -1215,6 +1264,8 @@ class BenchmarkRunner:
question_semaphore,
eval_semaphore_size,
clear_this_agent=True, # Always clear for parallel processing
include_mental_models=include_mental_models,
only_mental_models=only_mental_models,
)
return result
@@ -1253,11 +1304,17 @@ class BenchmarkRunner:
eval_semaphore_size: int,
output_path: Optional[Path] = None,
merge_with_existing: bool = False,
include_mental_models: bool = False,
only_mental_models: bool = False,
) -> Dict[str, Any]:
"""
Two-phase approach: ingest all data into single agent, then evaluate all questions.
More realistic scenario where agent accumulates memories over time.
Args:
include_mental_models: If True, include mental models in recall results and wait for consolidation
only_mental_models: If True, only retrieve mental models (no facts)
"""
# Phase 1: Ingestion
if not skip_ingestion:
@@ -1293,6 +1350,10 @@ class BenchmarkRunner:
)
console.print(f" [green]✓[/green] Ingested {len(all_sessions)} sessions from {len(items)} items")
# Wait for consolidation if mental models are requested
if include_mental_models or only_mental_models:
await self._wait_for_consolidation(agent_id)
else:
console.print("\n[3] Skipping ingestion (using existing data)")
@@ -1319,6 +1380,8 @@ class BenchmarkRunner:
max_tokens,
max_questions_per_item,
question_semaphore,
include_mental_models,
only_mental_models,
)
# Calculate metrics
@@ -278,6 +278,8 @@ async def run_benchmark(
max_questions_per_conv: int = None,
skip_ingestion: bool = False,
use_think: bool = False,
include_mental_models: bool = False,
only_mental_models: bool = False,
conversation: str = None,
api_url: str = None,
max_concurrent_questions_override: int = None,
@@ -292,6 +294,8 @@ async def run_benchmark(
max_questions_per_conv: Maximum questions per conversation (None for all)
skip_ingestion: Whether to skip ingestion and use existing data
use_think: Whether to use the think API instead of search + LLM
include_mental_models: If True, include mental models in recall results and wait for consolidation after ingestion.
only_mental_models: If True, only retrieve mental models (no facts). Implies waiting for consolidation.
conversation: Specific conversation ID to run (e.g., "conv-26")
api_url: Optional API URL to connect to (default: use local memory)
only_failed: If True, only run conversations that have failed questions (is_correct=False)
@@ -399,7 +403,14 @@ async def run_benchmark(
dataset.load = filtered_load
# Determine output filename based on mode
suffix = "_think" if use_think else ""
if use_think:
suffix = "_think"
elif only_mental_models:
suffix = "_only_mental_models"
elif include_mental_models:
suffix = "_mental_models"
else:
suffix = ""
results_filename = f"benchmark_results{suffix}.json"
output_path = Path(__file__).parent / "results" / results_filename
@@ -412,7 +423,11 @@ async def run_benchmark(
# Each conversation gets its own isolated bank
separate_ingestion = False
clear_per_item = True # Use unique agent ID per conversation
concurrent_items = 3 # Process up to 3 conversations in parallel
if include_mental_models or only_mental_models:
# Mental models requires more time due to consolidation, limit parallelism
concurrent_items = 2
else:
concurrent_items = 3 # Process up to 3 conversations in parallel
# Run benchmark with parallel conversation processing
# Each conversation gets its own agent ID (locomo_conv-26, locomo_conv-30, etc.)
@@ -433,6 +448,8 @@ async def run_benchmark(
max_concurrent_items=concurrent_items,
output_path=output_path, # Save results incrementally
merge_with_existing=merge_with_existing,
include_mental_models=include_mental_models, # Include mental models in recall results
only_mental_models=only_mental_models, # Only retrieve mental models (no facts)
)
# Display results (final save already happened incrementally)
@@ -440,12 +457,16 @@ async def run_benchmark(
console.print(f"\n[green]✓[/green] Results saved incrementally to {output_path}")
# Generate markdown table
generate_markdown_table(results, use_think=use_think)
generate_markdown_table(
results, use_think=use_think, include_mental_models=include_mental_models, only_mental_models=only_mental_models
)
return results
def generate_markdown_table(results: dict, use_think: bool = False):
def generate_markdown_table(
results: dict, use_think: bool = False, include_mental_models: bool = False, only_mental_models: bool = False
):
"""
Generate a markdown table with benchmark results.
@@ -463,7 +484,14 @@ def generate_markdown_table(results: dict, use_think: bool = False):
# Build markdown content
lines = []
mode_str = " (Think Mode)" if use_think else ""
if use_think:
mode_str = " (Think Mode)"
elif only_mental_models:
mode_str = " (Only Mental Models Mode)"
elif include_mental_models:
mode_str = " (Mental Models Mode)"
else:
mode_str = ""
lines.append(f"# LoComo Benchmark Results{mode_str}")
lines.append("")
@@ -514,7 +542,14 @@ def generate_markdown_table(results: dict, use_think: bool = False):
)
# Write to file with suffix
suffix = "_think" if use_think else ""
if use_think:
suffix = "_think"
elif only_mental_models:
suffix = "_only_mental_models"
elif include_mental_models:
suffix = "_mental_models"
else:
suffix = ""
output_file = Path(__file__).parent / "results" / f"results_table{suffix}.md"
output_file.parent.mkdir(parents=True, exist_ok=True)
output_file.write_text("\n".join(lines))
@@ -557,6 +592,16 @@ if __name__ == "__main__":
action="store_true",
help="Only run conversations that have invalid questions (is_invalid=True). Requires existing results file.",
)
parser.add_argument(
"--include-mental-models",
action="store_true",
help="Include mental models in recall results. This waits for consolidation to complete after ingestion and includes mental models in the recall response.",
)
parser.add_argument(
"--only-mental-models",
action="store_true",
help="Only retrieve mental models (no facts). This waits for consolidation to complete after ingestion and only returns mental models.",
)
args = parser.parse_args()
@@ -570,6 +615,8 @@ if __name__ == "__main__":
max_questions_per_conv=args.max_questions,
skip_ingestion=args.skip_ingestion,
use_think=args.use_think,
include_mental_models=args.include_mental_models,
only_mental_models=args.only_mental_models,
conversation=args.conversation,
api_url=args.api_url,
max_concurrent_questions_override=args.max_concurrent_questions,
@@ -433,6 +433,8 @@ async def run_benchmark(
results_filename: str = "benchmark_results.json",
context_format: str = "json",
source_results: str = None,
include_mental_models: bool = False,
only_mental_models: bool = False,
):
"""
Run the LongMemEval benchmark.
@@ -454,6 +456,8 @@ async def run_benchmark(
results_filename: Filename for results (default: benchmark_results.json). Directory is fixed to results/.
context_format: How to format context for answer generation. "json" (raw JSON) or "structured" (human-readable with facts+chunks).
source_results: Source results file to read failed/invalid questions from (for --only-failed/--only-invalid). Defaults to benchmark_results.json.
include_mental_models: If True, include mental models in recall results and wait for consolidation after ingestion.
only_mental_models: If True, only retrieve mental models (no facts). Implies waiting for consolidation.
"""
from rich.console import Console
@@ -625,6 +629,10 @@ async def run_benchmark(
answer_generator = LongMemEvalAnswerGenerator(context_format=context_format)
# Log context format being used
console.print(f"[blue]Context format: {context_format}[/blue]")
if only_mental_models:
console.print("[blue]Mental models: ONLY (no facts)[/blue]")
elif include_mental_models:
console.print("[blue]Mental models: included in recall[/blue]")
answer_evaluator = LLMAnswerEvaluator()
@@ -697,7 +705,7 @@ async def run_benchmark(
# Configuration for single-phase benchmark
separate_ingestion = False
clear_per_item = True # Use unique agent_id per question
concurrent_questions = 8
concurrent_questions = 4 if (include_mental_models or only_mental_models) else 8
results = await runner.run(
dataset_path=dataset_path,
@@ -718,6 +726,8 @@ async def run_benchmark(
max_concurrent_items=max_concurrent_items, # Parallel instance processing
output_path=output_path, # Save results incrementally
merge_with_existing=merge_with_existing, # Merge when using --fill, --category, --only-failed, --only-invalid flags or specific question
include_mental_models=include_mental_models, # Include mental models in recall results
only_mental_models=only_mental_models, # Only retrieve mental models (no facts)
)
# Display results (final save already happened incrementally)
@@ -968,6 +978,16 @@ if __name__ == "__main__":
default=None,
help="Source results file to read failed/invalid questions from (for --only-failed/--only-invalid). Defaults to benchmark_results.json if not specified.",
)
parser.add_argument(
"--include-mental-models",
action="store_true",
help="Include mental models in recall results. This waits for consolidation to complete after ingestion and includes mental models in the recall response.",
)
parser.add_argument(
"--only-mental-models",
action="store_true",
help="Only retrieve mental models (no facts). This waits for consolidation to complete after ingestion and only returns mental models.",
)
args = parser.parse_args()
@@ -998,5 +1018,7 @@ if __name__ == "__main__":
results_filename=args.results_filename,
context_format=args.context_format,
source_results=args.source_results,
include_mental_models=args.include_mental_models,
only_mental_models=args.only_mental_models,
)
)
+1 -8
View File
@@ -16,15 +16,8 @@ dependencies = [
"pydantic>=2.0.0",
]
[project.optional-dependencies]
test = [
"pytest>=8.0.0",
"httpx>=0.27.0",
"python-dotenv>=1.0.0",
]
[tool.hatch.build.targets.wheel]
packages = ["hindsight_dev", "benchmarks", "upgrade_tests"]
packages = ["hindsight_dev", "benchmarks"]
[tool.uv.sources]
hindsight-api = { workspace = true }
-1
View File
@@ -1 +0,0 @@
# Upgrade and backwards compatibility tests
-110
View File
@@ -1,110 +0,0 @@
"""
Pytest configuration and fixtures for upgrade tests.
"""
import asyncio
import logging
import os
from pathlib import Path
import pytest
from dotenv import load_dotenv
# Configure logging for tests
logging.basicConfig(
level=logging.INFO,
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",
)
# Reduce noise from httpx
logging.getLogger("httpx").setLevel(logging.WARNING)
logging.getLogger("httpcore").setLevel(logging.WARNING)
def pytest_configure(config):
"""Load environment variables before running tests."""
# Look for .env in the workspace root
env_file = Path(__file__).parent.parent.parent / ".env"
if env_file.exists():
load_dotenv(env_file)
_pg0_instance = None
_pg0_url = None
def _get_or_create_pg0():
"""Get or create the shared pg0 instance for upgrade tests."""
global _pg0_instance, _pg0_url
from hindsight_api.pg0 import EmbeddedPostgres
if _pg0_instance is None:
_pg0_instance = EmbeddedPostgres(name="hindsight-upgrade-test", port=5560)
loop = asyncio.new_event_loop()
try:
_pg0_url = loop.run_until_complete(_pg0_instance.ensure_running())
finally:
loop.close()
return _pg0_url
def _clean_database(db_url: str):
"""Drop all tables in the database to reset state for next test."""
from sqlalchemy import create_engine, text
engine = create_engine(db_url)
with engine.connect() as conn:
# Drop all tables in public schema (cascade to handle foreign keys)
tables = conn.execute(
text("""
SELECT tablename FROM pg_tables
WHERE schemaname = 'public'
AND tablename NOT LIKE 'pg_%'
""")
).fetchall()
for table in tables:
conn.execute(text(f'DROP TABLE IF EXISTS public."{table[0]}" CASCADE'))
conn.commit()
engine.dispose()
@pytest.fixture(scope="function")
def db_url():
"""
Provide a PostgreSQL connection URL for upgrade tests.
Uses pg0 (embedded PostgreSQL) for a clean, isolated test database.
The database is cleaned between tests to ensure fresh state for migrations.
"""
url = _get_or_create_pg0()
# Clean database before each test
_clean_database(url)
yield url
# No cleanup after - database is cleaned at start of next test
@pytest.fixture(scope="module")
def llm_config():
"""
Provide LLM configuration from environment.
Returns a dict with provider, api_key, and model.
"""
return {
"provider": os.getenv("HINDSIGHT_API_LLM_PROVIDER", "groq"),
"api_key": os.getenv("HINDSIGHT_API_LLM_API_KEY") or os.getenv("GROQ_API_KEY"),
"model": os.getenv("HINDSIGHT_API_LLM_MODEL", "llama-3.3-70b-versatile"),
}
@pytest.fixture
def unique_bank_id():
"""Generate a unique bank ID for each test."""
import uuid
return f"upgrade_test_{uuid.uuid4().hex[:8]}"
-303
View File
@@ -1,303 +0,0 @@
"""
Upgrade and backwards compatibility tests.
These tests verify that:
1. Data stored in older versions is accessible after upgrade
2. Database migrations run correctly
3. API behavior remains compatible
"""
import logging
import httpx
import pytest
from .version_runner import VersionRunner
logger = logging.getLogger(__name__)
# Version upgrade paths to test
# Format: (old_version, new_version)
UPGRADE_PATHS = [
("v0.3.0", "HEAD"),
]
class TestUpgrade:
"""Tests for version upgrades."""
@pytest.mark.parametrize("old_version,new_version", UPGRADE_PATHS)
def test_upgrade_preserves_memories(self, db_url, llm_config, unique_bank_id, old_version, new_version):
"""
Verify memories stored in old version are accessible after upgrade.
Workflow:
1. Start old version
2. Store memories via retain
3. Verify recall works on old version
4. Stop old version
5. Start new version (same database - migrations run)
6. Verify recall returns same data
7. Verify reflect works
"""
bank_id = unique_bank_id
# Test data to store
test_memories = [
{"content": "Alice is a software engineer at TechCorp.", "context": "team introduction"},
{"content": "Bob manages the infrastructure team and loves Kubernetes.", "context": "team introduction"},
{"content": "The project deadline is next Friday.", "context": "project planning"},
]
# Phase 1: Store data with old version
logger.info(f"=== Phase 1: Setting up data with {old_version} ===")
with VersionRunner(
old_version,
db_url,
port=8891,
llm_provider=llm_config["provider"],
llm_api_key=llm_config["api_key"],
llm_model=llm_config["model"],
) as old:
server = old.start()
client = httpx.Client(base_url=server.url, timeout=60)
# Store memories
resp = client.post(
f"/v1/default/banks/{bank_id}/memories",
json={"items": test_memories},
)
assert resp.status_code == 200, f"Failed to store memories: {resp.text}"
result = resp.json()
assert result["success"] is True
assert result["items_count"] == len(test_memories)
# Verify recall works on old version
resp = client.post(
f"/v1/default/banks/{bank_id}/memories/recall",
json={"query": "Who works at TechCorp?"},
)
assert resp.status_code == 200, f"Recall failed on old version: {resp.text}"
old_results = resp.json()["results"]
assert len(old_results) > 0, "No results from recall on old version"
# Get stats for comparison
resp = client.get(f"/v1/default/banks/{bank_id}/stats")
assert resp.status_code == 200
old_stats = resp.json()
logger.info(f"Old version stats: {old_stats}")
client.close()
# Phase 2: Verify data with new version
logger.info(f"=== Phase 2: Verifying data with {new_version} ===")
with VersionRunner(
new_version,
db_url,
port=8892,
llm_provider=llm_config["provider"],
llm_api_key=llm_config["api_key"],
llm_model=llm_config["model"],
) as new:
server = new.start()
client = httpx.Client(base_url=server.url, timeout=60)
# Verify recall returns data
resp = client.post(
f"/v1/default/banks/{bank_id}/memories/recall",
json={"query": "Who works at TechCorp?"},
)
assert resp.status_code == 200, f"Recall failed on new version: {resp.text}"
new_results = resp.json()["results"]
assert len(new_results) > 0, f"No results from recall after upgrade. Bank: {bank_id}"
# Verify Alice is found
found_alice = any("Alice" in r.get("text", "") for r in new_results)
assert found_alice, f"Alice not found in results after upgrade: {new_results}"
# Verify reflect works
resp = client.post(
f"/v1/default/banks/{bank_id}/reflect",
json={"query": "Tell me about the team members"},
)
assert resp.status_code == 200, f"Reflect failed after upgrade: {resp.text}"
reflect_result = resp.json()
assert len(reflect_result.get("text", "")) > 0, "Empty reflect response after upgrade"
# Verify stats are preserved
resp = client.get(f"/v1/default/banks/{bank_id}/stats")
assert resp.status_code == 200
new_stats = resp.json()
logger.info(f"New version stats: {new_stats}")
# Stats should be similar (might have small differences due to re-indexing)
assert new_stats["total_nodes"] >= old_stats["total_nodes"], (
f"Lost nodes after upgrade: {old_stats['total_nodes']} -> {new_stats['total_nodes']}"
)
# Cleanup - delete test bank
resp = client.delete(f"/v1/default/banks/{bank_id}")
assert resp.status_code == 200
client.close()
@pytest.mark.parametrize("old_version,new_version", UPGRADE_PATHS)
def test_upgrade_preserves_documents(self, db_url, llm_config, unique_bank_id, old_version, new_version):
"""
Verify documents stored in old version are accessible after upgrade.
"""
bank_id = unique_bank_id
doc_id = "test-document-001"
# Phase 1: Store document with old version
logger.info(f"=== Phase 1: Storing document with {old_version} ===")
with VersionRunner(
old_version,
db_url,
port=8893,
llm_provider=llm_config["provider"],
llm_api_key=llm_config["api_key"],
llm_model=llm_config["model"],
) as old:
server = old.start()
client = httpx.Client(base_url=server.url, timeout=60)
# Store memory with document
resp = client.post(
f"/v1/default/banks/{bank_id}/memories",
json={
"items": [
{
"content": "The quarterly report shows 25% revenue growth.",
"context": "Q1 financial review",
"document_id": doc_id,
}
]
},
)
assert resp.status_code == 200, f"Failed to store document: {resp.text}"
# Verify document exists
resp = client.get(f"/v1/default/banks/{bank_id}/documents")
assert resp.status_code == 200
docs = resp.json()["items"]
doc_ids = [d["id"] for d in docs]
assert doc_id in doc_ids, f"Document not found in old version: {doc_ids}"
client.close()
# Phase 2: Verify document with new version
logger.info(f"=== Phase 2: Verifying document with {new_version} ===")
with VersionRunner(
new_version,
db_url,
port=8894,
llm_provider=llm_config["provider"],
llm_api_key=llm_config["api_key"],
llm_model=llm_config["model"],
) as new:
server = new.start()
client = httpx.Client(base_url=server.url, timeout=60)
# Verify document still exists
resp = client.get(f"/v1/default/banks/{bank_id}/documents")
assert resp.status_code == 200
docs = resp.json()["items"]
doc_ids = [d["id"] for d in docs]
assert doc_id in doc_ids, f"Document not found after upgrade: {doc_ids}"
# Verify document details
resp = client.get(f"/v1/default/banks/{bank_id}/documents/{doc_id}")
assert resp.status_code == 200
doc_info = resp.json()
assert doc_info["id"] == doc_id
assert doc_info["memory_unit_count"] > 0
# Cleanup
resp = client.delete(f"/v1/default/banks/{bank_id}")
assert resp.status_code == 200
client.close()
@pytest.mark.parametrize("old_version,new_version", UPGRADE_PATHS)
def test_upgrade_preserves_bank_profile(self, db_url, llm_config, unique_bank_id, old_version, new_version):
"""
Verify bank profile (disposition) is preserved after upgrade.
"""
bank_id = unique_bank_id
# Phase 1: Create bank with custom disposition
logger.info(f"=== Phase 1: Creating bank profile with {old_version} ===")
with VersionRunner(
old_version,
db_url,
port=8895,
llm_provider=llm_config["provider"],
llm_api_key=llm_config["api_key"],
llm_model=llm_config["model"],
) as old:
server = old.start()
client = httpx.Client(base_url=server.url, timeout=60)
# Create bank by storing a memory
resp = client.post(
f"/v1/default/banks/{bank_id}/memories",
json={"items": [{"content": "Test memory", "context": "test"}]},
)
assert resp.status_code == 200
# Set custom disposition
resp = client.put(
f"/v1/default/banks/{bank_id}/profile",
json={
"disposition": {
"skepticism": 4,
"literalism": 2,
"empathy": 5,
}
},
)
assert resp.status_code == 200
# Verify profile
resp = client.get(f"/v1/default/banks/{bank_id}/profile")
assert resp.status_code == 200
old_profile = resp.json()
assert old_profile["disposition"]["skepticism"] == 4
assert old_profile["disposition"]["literalism"] == 2
assert old_profile["disposition"]["empathy"] == 5
client.close()
# Phase 2: Verify profile with new version
logger.info(f"=== Phase 2: Verifying profile with {new_version} ===")
with VersionRunner(
new_version,
db_url,
port=8896,
llm_provider=llm_config["provider"],
llm_api_key=llm_config["api_key"],
llm_model=llm_config["model"],
) as new:
server = new.start()
client = httpx.Client(base_url=server.url, timeout=60)
# Verify profile is preserved
resp = client.get(f"/v1/default/banks/{bank_id}/profile")
assert resp.status_code == 200
new_profile = resp.json()
assert new_profile["disposition"]["skepticism"] == 4, "Skepticism not preserved"
assert new_profile["disposition"]["literalism"] == 2, "Literalism not preserved"
assert new_profile["disposition"]["empathy"] == 5, "Empathy not preserved"
# Cleanup
resp = client.delete(f"/v1/default/banks/{bank_id}")
assert resp.status_code == 200
client.close()
@@ -1,275 +0,0 @@
"""
Version runner for upgrade tests.
Manages running different git versions of the Hindsight API for upgrade testing.
Handles git checkout, venv creation, dependency installation, and server lifecycle.
"""
import logging
import os
import shutil
import subprocess
import tempfile
import time
from dataclasses import dataclass
from pathlib import Path
import httpx
logger = logging.getLogger(__name__)
@dataclass
class ServerInfo:
"""Information about a running server."""
url: str
port: int
version: str
class VersionRunner:
"""
Manages running a specific git version of the Hindsight API.
For "HEAD" or "current", uses the current working directory.
For git tags (e.g., "v0.3.0"), clones the repo at that tag to a temp directory.
"""
def __init__(
self,
version: str,
db_url: str,
port: int = 8890,
llm_provider: str | None = None,
llm_api_key: str | None = None,
llm_model: str | None = None,
):
"""
Initialize a version runner.
Args:
version: Git tag (e.g., "v0.3.0") or "HEAD"/"current" for current code
db_url: PostgreSQL connection URL
port: Port to run the API on
llm_provider: LLM provider (defaults to env var)
llm_api_key: LLM API key (defaults to env var)
llm_model: LLM model (defaults to env var)
"""
self.version = version
self.db_url = db_url
self.port = port
self.llm_provider = llm_provider or os.getenv("HINDSIGHT_API_LLM_PROVIDER", "groq")
self.llm_api_key = llm_api_key or os.getenv("HINDSIGHT_API_LLM_API_KEY") or os.getenv("GROQ_API_KEY")
self.llm_model = llm_model or os.getenv("HINDSIGHT_API_LLM_MODEL", "llama-3.3-70b-versatile")
self.work_dir: Path | None = None
self.process: subprocess.Popen | None = None
self._temp_dir: str | None = None
self._is_current = version.lower() in ("head", "current")
def _find_repo_root(self) -> Path:
"""Find the git repository root."""
result = subprocess.run(
["git", "rev-parse", "--show-toplevel"],
capture_output=True,
text=True,
check=True,
)
return Path(result.stdout.strip())
def setup(self) -> None:
"""Checkout version and install dependencies."""
if self._is_current:
# Use current working directory
self.work_dir = self._find_repo_root()
logger.info(f"Using current code at {self.work_dir}")
return
# Create temp dir and checkout specific version
self._temp_dir = tempfile.mkdtemp(prefix=f"hindsight-{self.version}-")
self.work_dir = Path(self._temp_dir)
repo_root = self._find_repo_root()
logger.info(f"Cloning {repo_root} at {self.version} to {self.work_dir}")
# Shallow clone at specific tag
subprocess.run(
["git", "clone", "--depth", "1", "--branch", self.version, str(repo_root), str(self.work_dir)],
check=True,
capture_output=True,
)
# Create venv and install
venv_path = self.work_dir / ".venv-upgrade-test"
logger.info(f"Creating venv at {venv_path}")
subprocess.run(["uv", "venv", str(venv_path)], check=True, capture_output=True)
api_path = self.work_dir / "hindsight-api"
logger.info(f"Installing hindsight-api from {api_path}")
# Install with uv pip - use --index-strategy for pytorch
subprocess.run(
[
"uv",
"pip",
"install",
"-e",
str(api_path),
"--python",
str(venv_path / "bin" / "python"),
"--index-strategy",
"unsafe-best-match",
],
check=True,
capture_output=True,
env={**os.environ, "UV_INDEX": "pytorch=https://download.pytorch.org/whl/cpu"},
)
logger.info(f"Version {self.version} setup complete")
def _get_venv_path(self) -> Path:
"""Get the path to the venv for this version."""
if self._is_current:
# For current code, the venv is at the workspace root (uv workspace layout)
# Check both possible locations
workspace_venv = self.work_dir / ".venv"
api_venv = self.work_dir / "hindsight-api" / ".venv"
if (workspace_venv / "bin" / "hindsight-api").exists():
return workspace_venv
elif (api_venv / "bin" / "hindsight-api").exists():
return api_venv
else:
# Default to workspace root
return workspace_venv
return self.work_dir / ".venv-upgrade-test"
def start(self) -> ServerInfo:
"""
Start the API server.
Returns:
ServerInfo with the URL and port
"""
venv_path = self._get_venv_path()
hindsight_api_bin = venv_path / "bin" / "hindsight-api"
if not hindsight_api_bin.exists():
raise RuntimeError(f"hindsight-api binary not found at {hindsight_api_bin}")
env = os.environ.copy()
env.update(
{
"HINDSIGHT_API_PORT": str(self.port),
"HINDSIGHT_API_DATABASE_URL": self.db_url,
"HINDSIGHT_API_HOST": "127.0.0.1",
"HINDSIGHT_API_LLM_PROVIDER": self.llm_provider,
"HINDSIGHT_API_LLM_API_KEY": self.llm_api_key or "",
"HINDSIGHT_API_LLM_MODEL": self.llm_model,
"PYTHONUNBUFFERED": "1",
}
)
logger.info(f"Starting {self.version} API on port {self.port}")
logger.info(f"Database URL: {self.db_url}")
# Determine working directory
# For HEAD/current, use a temp directory to avoid .env file from workspace root
# (hindsight-api loads .env with override=True which would override our env vars)
if self._is_current:
# Create a temp directory for HEAD to avoid workspace .env
self._head_cwd = tempfile.mkdtemp(prefix="hindsight-head-cwd-")
cwd = self._head_cwd
else:
cwd = str(self.work_dir)
self._head_cwd = None
# Start the server
self.process = subprocess.Popen(
[str(hindsight_api_bin)],
env=env,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
cwd=cwd,
)
self._wait_healthy()
url = f"http://127.0.0.1:{self.port}"
logger.info(f"Server {self.version} ready at {url}")
return ServerInfo(url=url, port=self.port, version=self.version)
def _wait_healthy(self, timeout: int = 120) -> None:
"""Wait for /health endpoint to respond."""
url = f"http://127.0.0.1:{self.port}/health"
deadline = time.time() + timeout
while time.time() < deadline:
# Check if process is still alive
if self.process and self.process.poll() is not None:
stdout = self.process.stdout.read().decode() if self.process.stdout else ""
raise RuntimeError(f"Server {self.version} exited unexpectedly.\nLogs:\n{stdout}")
try:
resp = httpx.get(url, timeout=2)
if resp.status_code == 200:
return
except httpx.RequestError:
pass
time.sleep(1)
# Timeout - dump logs
if self.process:
self.process.terminate()
try:
stdout, _ = self.process.communicate(timeout=5)
logs = stdout.decode() if stdout else ""
except Exception:
logs = "(failed to read logs)"
raise TimeoutError(f"Server {self.version} not healthy after {timeout}s.\nLogs:\n{logs}")
def stop(self) -> None:
"""Stop the server and cleanup temp directory."""
if self.process:
logger.info(f"Stopping {self.version} server")
self.process.terminate()
try:
self.process.wait(timeout=10)
except subprocess.TimeoutExpired:
logger.warning(f"Server {self.version} did not stop gracefully, killing")
self.process.kill()
self.process.wait()
self.process = None
if self._temp_dir and os.path.exists(self._temp_dir):
logger.info(f"Cleaning up {self._temp_dir}")
shutil.rmtree(self._temp_dir, ignore_errors=True)
self._temp_dir = None
# Clean up HEAD's temp cwd
if hasattr(self, "_head_cwd") and self._head_cwd and os.path.exists(self._head_cwd):
shutil.rmtree(self._head_cwd, ignore_errors=True)
self._head_cwd = None
def get_logs(self) -> str:
"""Get current server logs (if process is running)."""
if self.process and self.process.stdout:
# Non-blocking read of available output
import select
if hasattr(select, "select"):
readable, _, _ = select.select([self.process.stdout], [], [], 0)
if readable:
return self.process.stdout.read(4096).decode()
return ""
def __enter__(self) -> "VersionRunner":
self.setup()
return self
def __exit__(self, *args) -> None:
self.stop()
@@ -48,7 +48,7 @@ OpenAI Assistant (analyzes, gives advice)
|
Function Call: store_memory(advice as experience)
|
Hindsight API (stores coach's advice, consolidates into observations)
Hindsight API (stores coach's advice, consolidates into mental models)
|
Personalized Answer
```
@@ -126,7 +126,7 @@ retrieve_memories(query, fact_types, top_k)
search_workouts(after_date, before_date, workout_type)
get_nutrition_summary(after_date, before_date)
get_user_goals()
get_coach_insights(about) # Retrieves observations
get_coach_insights(about) # Retrieves mental models
```
Each function makes API calls to Hindsight to fetch relevant memories.
@@ -192,7 +192,7 @@ The OpenAI Agent can retrieve different memory types from Hindsight:
- **World Facts** (`fact_type: "world"`): Workouts, meals, activities
- **Experience Facts** (`fact_type: "experience"`): Goals, intentions, coach advice
- **Observations** (`fact_type: "observation"`): Consolidated knowledge about user patterns
- **Mental Models** (`fact_type: "mental_model"`): Consolidated knowledge about user patterns
## Customization
@@ -266,7 +266,7 @@ The key benefit: **Separation of concerns**
**Use Hindsight directly when:**
- You want a complete memory-first solution
- You want automatic memory retrieval and observation consolidation
- You want automatic memory retrieval and mental model consolidation
- You want to use different LLM providers (not just OpenAI)
- You want the `/reflect` endpoint's integrated approach
@@ -127,7 +127,7 @@ for r in results.results:
## Reflect: Generate Insights
The `reflect` operation performs reasoning over existing memories using the bank's disposition. It retrieves relevant facts and observations to generate contextual responses.
The `reflect` operation performs reasoning over existing memories using the bank's disposition. It retrieves relevant facts and mental models to generate contextual responses.
Example use cases:
- An AI Project Manager reflecting on what risks need to be mitigated
@@ -142,11 +142,11 @@ print(response)
## Memory Types
Hindsight organizes knowledge into facts and consolidated observations:
Hindsight organizes knowledge into facts and consolidated mental models:
- **World**: Facts about the world ("The stove gets hot")
- **Experience**: Agent's own experiences ("I touched the stove and it really hurt")
- **Observation**: Consolidated knowledge synthesized from facts ("Always be careful around hot surfaces")
- **Mental Model**: Consolidated knowledge synthesized from facts ("Always be careful around hot surfaces")
## Cleanup
+1 -1
View File
@@ -78,7 +78,7 @@ The backup includes:
- Memory banks and their configuration
- Documents and chunks
- Entities and their relationships
- Memory units (facts, experiences, observations)
- Memory units (facts, experiences, mental models)
- Entity cooccurrences and memory links
:::note Consistency
@@ -89,7 +89,7 @@ hindsight recall my-bank "Tell me about Alice" -v
## Reflect: Reason with Disposition
Generate disposition-aware responses using memories and observations.
Generate disposition-aware responses using memories and mental models.
<Tabs>
<TabItem value="python" label="Python">
@@ -104,7 +104,7 @@ Generate disposition-aware responses using memories and observations.
# Basic reflect
hindsight reflect my-bank "Should we adopt TypeScript for our backend?"
# Verbose output (shows sources and observations)
# Verbose output (shows sources and mental models)
hindsight reflect my-bank "What are Alice's strengths for the team lead role?" -v
# With higher reasoning budget
@@ -114,7 +114,7 @@ hindsight reflect my-bank "Analyze our tech stack" --budget high
</TabItem>
</Tabs>
**What happens:** Memories and observations are recalled, bank disposition is applied, and the LLM reasons through the evidence to generate a response.
**What happens:** Memories and mental models are recalled, bank disposition is applied, and the LLM reasons through the evidence to generate a response.
**See:** [Reflect Details](./reflect) for disposition configuration.
@@ -126,9 +126,9 @@ hindsight reflect my-bank "Analyze our tech stack" --budget high
|---------|--------|--------|---------|
| **Purpose** | Store information | Find information | Reason about information |
| **Input** | Raw text/documents | Search query | Question/prompt |
| **Output** | Memory IDs | Ranked facts + observations | Reasoned response |
| **Output** | Memory IDs | Ranked facts + mental models | Reasoned response |
| **Uses LLM** | Yes (extraction) | No | Yes (generation) |
| **Uses observations** | No | Yes | Yes |
| **Uses mental models** | No | Yes | Yes |
| **Disposition** | No | No | Yes |
---
@@ -13,8 +13,6 @@ import CodeSnippet from '@site/src/components/CodeSnippet';
{/* Import raw source files */}
import memoryBanksPy from '!!raw-loader!@site/examples/api/memory-banks.py';
import memoryBanksMjs from '!!raw-loader!@site/examples/api/memory-banks.mjs';
import directivesPy from '!!raw-loader!@site/examples/api/directives.py';
import directivesMjs from '!!raw-loader!@site/examples/api/directives.mjs';
## What is a Memory Bank?
@@ -24,7 +22,6 @@ A memory bank is a complete, isolated storage unit containing:
- **Documents** — Files and content indexed for retrieval
- **Entities** — People, places, concepts extracted from memories
- **Relationships** — Connections between entities in the knowledge graph
- **Directives** — Hard rules the agent must follow during reflect operations
Banks are completely isolated from each other — memories stored in one bank are not visible to another.
@@ -89,73 +86,3 @@ Disposition traits influence how reasoning is performed during reflection. Each
| **Skepticism** | Trusting, accepts information at face value | Skeptical, questions and doubts claims |
| **Literalism** | Flexible interpretation, reads between the lines | Literal interpretation, takes things exactly as stated |
| **Empathy** | Detached, focuses on facts and logic | Empathetic, considers emotional context |
## Directives
Directives are hard rules that the agent must follow during [reflect](./reflect) operations. Unlike disposition traits which influence *how* the agent reasons, directives are explicit instructions that are *always* enforced.
:::info
Directives only affect the `reflect` operation. They are injected into prompts and the agent is required to comply with them in all responses.
:::
### When to Use Directives
Use directives for rules that must never be violated:
- **Language/style constraints**: "Always respond in formal English"
- **Privacy rules**: "Never share personal data with third parties"
- **Domain constraints**: "Prefer conservative investment recommendations"
- **Behavioral guardrails**: "Always cite sources when making claims"
### Creating Directives
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={directivesPy} section="create-directive" language="python" />
</TabItem>
<TabItem value="node" label="Node.js">
<CodeSnippet code={directivesMjs} section="create-directive" language="javascript" />
</TabItem>
</Tabs>
### Listing Directives
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={directivesPy} section="list-directives" language="python" />
</TabItem>
<TabItem value="node" label="Node.js">
<CodeSnippet code={directivesMjs} section="list-directives" language="javascript" />
</TabItem>
</Tabs>
### Updating Directives
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={directivesPy} section="update-directive" language="python" />
</TabItem>
<TabItem value="node" label="Node.js">
<CodeSnippet code={directivesMjs} section="update-directive" language="javascript" />
</TabItem>
</Tabs>
### Deleting Directives
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={directivesPy} section="delete-directive" language="python" />
</TabItem>
<TabItem value="node" label="Node.js">
<CodeSnippet code={directivesMjs} section="delete-directive" language="javascript" />
</TabItem>
</Tabs>
### Directives vs Disposition
| Aspect | Directives | Disposition |
|--------|------------|-------------|
| **Nature** | Hard rules, must be followed | Soft influence on reasoning style |
| **Enforcement** | Strict — responses are rejected if violated | Flexible — shapes interpretation |
| **Use case** | Compliance, guardrails, constraints | Personality, character, tone |
| **Example** | "Never recommend specific stocks" | High skepticism: questions claims |
@@ -1,262 +0,0 @@
---
sidebar_position: 4
---
# Mental Models
User-curated summaries that provide high-quality, pre-computed answers for common queries.
import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';
import CodeSnippet from '@site/src/components/CodeSnippet';
{/* Import raw source files */}
import mentalModelsPy from '!!raw-loader!@site/examples/api/mental-models.py';
## What Are Mental Models?
Mental models are **saved reflect responses** that you curate for your memory bank. When you create a mental model, Hindsight runs a reflect operation with your source query and stores the result. During future reflect calls, these pre-computed summaries are checked first — providing faster, more consistent answers.
```mermaid
graph LR
A[Create Mental Model] --> B[Run Reflect]
B --> C[Store Result]
C --> D[Future Queries]
D --> E{Match Found?}
E -->|Yes| F[Return Mental Model]
E -->|No| G[Run Full Reflect]
```
### Why Use Mental Models?
| Benefit | Description |
|---------|-------------|
| **Consistency** | Same answer every time for common questions |
| **Speed** | Pre-computed responses are returned instantly |
| **Quality** | Manually curated summaries you've reviewed |
| **Control** | Define exactly how key topics should be answered |
### Hierarchical Retrieval
During reflect, the agent checks sources in priority order:
1. **Mental Models** — User-curated summaries (highest priority)
2. **Observations** — Consolidated knowledge
3. **Raw Facts** — Ground truth memories
Mental models are checked first because they represent your explicitly curated knowledge.
---
## Create a Mental Model
Creating a mental model runs a reflect operation in the background and saves the result:
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="create-mental-model" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
# Create a mental model (async operation)
curl -X POST "http://localhost:8888/v1/default/banks/my-bank/mental-models" \
-H "Content-Type: application/json" \
-d '{
"name": "Team Communication Preferences",
"source_query": "How does the team prefer to communicate?",
"tags": ["team"]
}'
# Response: {"operation_id": "op-123"}
# Use the operations endpoint to check completion
```
</TabItem>
</Tabs>
### Parameters
| Parameter | Type | Required | Description |
|-----------|------|----------|-------------|
| `name` | string | Yes | Human-readable name for the mental model |
| `source_query` | string | Yes | The query to run to generate content |
| `tags` | list | No | Tags for filtering during retrieval |
| `max_tokens` | int | No | Maximum tokens for the mental model content |
| `trigger` | object | No | Trigger settings (see [Automatic Refresh](#automatic-refresh)) |
---
## Automatic Refresh
Mental models can be configured to **automatically refresh** when observations are updated. This keeps them in sync with the latest knowledge without manual intervention.
### Trigger Settings
| Setting | Type | Default | Description |
|---------|------|---------|-------------|
| `refresh_after_consolidation` | bool | false | Automatically refresh after observations consolidation |
When `refresh_after_consolidation` is enabled, the mental model will be re-generated every time the bank's observations are consolidated — ensuring it always reflects the latest synthesized knowledge.
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="create-mental-model-with-trigger" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
# Create a mental model with automatic refresh enabled
curl -X POST "http://localhost:8888/v1/default/banks/my-bank/mental-models" \
-H "Content-Type: application/json" \
-d '{
"name": "Project Status",
"source_query": "What is the current project status?",
"trigger": {"refresh_after_consolidation": true}
}'
```
</TabItem>
</Tabs>
### When to Use Automatic Refresh
| Use Case | Automatic Refresh | Why |
|----------|-------------------|-----|
| **Real-time dashboards** | ✅ Enabled | Status should always be current |
| **Policy summaries** | ❌ Disabled | Policies change infrequently, manual refresh preferred |
| **User preferences** | ✅ Enabled | Preferences evolve with new interactions |
| **FAQ answers** | ❌ Disabled | Answers are curated, should be reviewed before updating |
:::tip
Enable automatic refresh for mental models that need to stay current. Disable it for curated content where you want to review changes before they go live.
:::
---
## List Mental Models
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="list-mental-models" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
curl "http://localhost:8888/v1/default/banks/my-bank/mental-models"
```
</TabItem>
</Tabs>
---
## Get a Mental Model
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="get-mental-model" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
curl "http://localhost:8888/v1/default/banks/my-bank/mental-models/{mental_model_id}"
```
</TabItem>
</Tabs>
### Response Fields
| Field | Type | Description |
|-------|------|-------------|
| `id` | string | Unique mental model ID |
| `bank_id` | string | Memory bank ID |
| `name` | string | Human-readable name |
| `source_query` | string | The query used to generate content |
| `content` | string | The generated mental model text |
| `tags` | list | Tags for filtering |
| `last_refreshed_at` | string | When the mental model was last updated |
| `created_at` | string | When the mental model was created |
| `reflect_response` | object | Full reflect response including `based_on` facts |
---
## Refresh a Mental Model
Re-run the source query to update the mental model with current knowledge:
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="refresh-mental-model" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
curl -X POST "http://localhost:8888/v1/default/banks/my-bank/mental-models/{mental_model_id}/refresh"
```
</TabItem>
</Tabs>
Refreshing is useful when:
- New memories have been retained that affect the topic
- Observations have been updated
- You want to ensure the mental model reflects current knowledge
---
## Update a Mental Model
Update the mental model's name:
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="update-mental-model" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
curl -X PATCH "http://localhost:8888/v1/default/banks/my-bank/mental-models/{mental_model_id}" \
-H "Content-Type: application/json" \
-d '{"name": "Updated Team Communication Preferences"}'
```
</TabItem>
</Tabs>
---
## Delete a Mental Model
<Tabs>
<TabItem value="python" label="Python">
<CodeSnippet code={mentalModelsPy} section="delete-mental-model" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
```bash
curl -X DELETE "http://localhost:8888/v1/default/banks/my-bank/mental-models/{mental_model_id}"
```
</TabItem>
</Tabs>
---
## Use Cases
| Use Case | Example |
|----------|---------|
| **FAQ Answers** | Pre-compute answers to common customer questions |
| **Onboarding Summaries** | "What should new team members know?" |
| **Status Reports** | "What's the current project status?" refreshed weekly |
| **Policy Summaries** | "What are our security policies?" |
---
## Next Steps
- [**Reflect**](./reflect) — How the agentic loop uses mental models
- [**Observations**](/developer/observations) — How knowledge is consolidated
- [**Operations**](./operations) — Track async mental model creation
@@ -25,7 +25,7 @@ Support for external streaming platforms like Kafka for scale-out processing is
| Operation | Trigger | Description |
|-----------|---------|-------------|
| **batch_retain** | `retain_batch` with `async=True` | Processes large content batches in the background |
| **consolidate** | After `retain` | Consolidates new facts into observations |
| **consolidate** | After `retain` | Consolidates new facts into mental models |
## Async Retain Example
+4 -4
View File
@@ -42,7 +42,7 @@ Make sure you've completed the [Quick Start](./quickstart) to install the client
| Parameter | Type | Default | Description |
|-----------|------|---------|-------------|
| `query` | string | required | Natural language query |
| `types` | list | all | Filter: `world`, `experience`, `observation` |
| `types` | list | all | Filter: `world`, `experience`, `mental_model` |
| `budget` | string | "mid" | Budget level: `low`, `mid`, `high` |
| `max_tokens` | int | 4096 | Token budget for results |
| `trace` | bool | false | Enable trace output for debugging |
@@ -68,15 +68,15 @@ Recall specific memory types:
<TabItem value="python" label="Python">
<CodeSnippet code={recallPy} section="recall-world-only" language="python" />
<CodeSnippet code={recallPy} section="recall-experience-only" language="python" />
<CodeSnippet code={recallPy} section="recall-observations-only" language="python" />
<CodeSnippet code={recallPy} section="recall-mental-models-only" language="python" />
</TabItem>
<TabItem value="cli" label="CLI">
<CodeSnippet code={recallSh} section="recall-fact-type" language="bash" />
</TabItem>
</Tabs>
:::tip About Observations
Observations are consolidated knowledge synthesized from multiple facts. They capture patterns, preferences, and learnings that the memory bank has built up over time. Observations are automatically created in the background after retain operations.
:::tip About Mental Models
Mental models are consolidated knowledge synthesized from multiple facts. They capture patterns, preferences, and learnings that the memory bank has built up over time. Mental models are automatically created in the background after retain operations.
:::
## Token Budget Management

Some files were not shown because too many files have changed in this diff Show More